Change in vdsm[master]: stomp: client side subscription
Yaniv Bronhaim has posted comments on this change. Change subject: stomp: client side subscription .. Patch Set 19: (2 comments) https://gerrit.ovirt.org/#/c/36368/19/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 379: _frame_handler > There could be more than single message in a frame. so add comment and explain it above the peek_message call. Line 547: self._message_handler = message_handler Line 548: self._destination = destination Line 549: Line 550: def handle_message(self, frame): Line 551: self._message_handler(self, frame) message_handler can be none as far as I see. I really don't understand this message_handler pass over and rolling it from object to object. can't you have one singleton for each handler that we expose (what is it - json handler, stomp handler?) it's impossible to follow which handler you pass where and if you change it in runtime (which I don't understand any reason to change the handler during runtime). if something that handle messages have states and in each state it uses different handler - the flow should be understandable by reading the class itself and not the usages which control its state from outside. Line 552: Line 553: def set_message_handler(self, handler): Line 554: self._message_handler = handler Line 555: -- To view, visit https://gerrit.ovirt.org/36368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronheim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: client side subscription
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: client side subscription
..
Patch Set 19: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/36368/19/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReactor.py:
Line 332: self._destination = destination
Line 333: self._client = client
Line 334: self._message_handler = lambda arg: None
Line 335:
Line 336: def setMessageHandler(self, handler):
> This is contract that we use for setting a message handler.
did you sign on that? at least call it from the constructor with none. don't
you need to set this handler also to the subscription\sub (please change) ? it
smalls bad
Line 337: self._message_handler = handler
Line 338:
Line 339: def send(self, data):
Line 340: headers = {
--
To view, visit https://gerrit.ovirt.org/36368
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronheim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: password: Prevent password logging and persisting
Francesco Romani has posted comments on this change. Change subject: password: Prevent password logging and persisting .. Patch Set 5: Code-Review+1 It seems to me that you replaced a few comments -as Dan requested- in the code with a sentence in the commit message. I'm slightly against this move, but I don't think it's worth further delay of this patch. -- To view, visit https://gerrit.ovirt.org/40707 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc849ad8bdc1b1fd09884e18038427d96e66110f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: remove getVmStats before migration
Francesco Romani has posted comments on this change. Change subject: migration: remove getVmStats before migration .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic83ab46173d5d7e5bfd85bf00b8f86a530da5dd4 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Feng Yang Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: raise proper execption if mount point already used
automat...@ovirt.org has posted comments on this change. Change subject: gluster: raise proper execption if mount point already used .. Patch Set 2: * Update tracker::#1209475::OK * Check Bug-Url::OK * Check Public Bug::#1209475::OK, public bug * Check Product::#1209475::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40892 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic12acd2e4bf6a88936af582bb17d50d72cdfb84f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: lib: drop forward port from python 2.7
automat...@ovirt.org has posted comments on this change. Change subject: tests: lib: drop forward port from python 2.7 .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/40879 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id943e5db3f972ccf89291f3d7c112db7907eba1d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: Fix cpu usage key names
Francesco Romani has posted comments on this change. Change subject: vmstats: Fix cpu usage key names .. Patch Set 2: Code-Review+1 thanks for the changes. Looks fine now. -- To view, visit https://gerrit.ovirt.org/40845 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id26c427d67de47cbcc39ddd43ab4cfe8467432c4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: lib: drop forward port from python 2.7
Francesco Romani has abandoned this change. Change subject: tests: lib: drop forward port from python 2.7 .. Abandoned obsoleted by https://gerrit.ovirt.org/#/c/40888 -- To view, visit https://gerrit.ovirt.org/40879 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id943e5db3f972ccf89291f3d7c112db7907eba1d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testlib: drop python-2.6-specific code
Francesco Romani has posted comments on this change. Change subject: testlib: drop python-2.6-specific code .. Patch Set 2: probably also safe_repr can go. -- To view, visit https://gerrit.ovirt.org/40888 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0784adea1c4156daf824c4a5092b91ce9e97a643 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: models, configurators: replace the internal 'async' flag wit...
Ido Barkan has posted comments on this change. Change subject: models, configurators: replace the internal 'async' flag with blockingdhcp .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e60040320d65ddbc4146a31c02c388ddad13ea9 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: set default value for dataalignment and physicalext...
automat...@ovirt.org has posted comments on this change. Change subject: gluster: set default value for dataalignment and physicalextent value .. Patch Set 2: * Update tracker::#1210296::OK * Check Bug-Url::OK * Check Public Bug::#1210296::OK, public bug * Check Product::#1210296::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40890 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8b7f3104705e5d303f4c0739f15cfd592e84b8e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testlib: drop python-2.6-specific code
Ido Barkan has posted comments on this change. Change subject: testlib: drop python-2.6-specific code .. Patch Set 2: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/40888/2//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-05-13 22:01:32 +0100 Line 6: Line 7: testlib: drop python-2.6-specific code Line 8: Line 9: Noe that we no longer support el6 and its python-2.6, we can drop these Now Line 10: backports. Line 11: Line 12: Change-Id: I0784adea1c4156daf824c4a5092b91ce9e97a643 https://gerrit.ovirt.org/#/c/40888/2/tests/testlib.py File tests/testlib.py: _AssertRaisesContext is also part of 2.7. So we don't need it anymore. -- To view, visit https://gerrit.ovirt.org/40888 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0784adea1c4156daf824c4a5092b91ce9e97a643 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: Fix cpu usage key names
Nir Soffer has posted comments on this change. Change subject: vmstats: Fix cpu usage key names .. Patch Set 2: Francesco, this version uses the fix you suggested. Can you review it again? -- To view, visit https://gerrit.ovirt.org/40845 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id26c427d67de47cbcc39ddd43ab4cfe8467432c4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: Fix cpu usage key names
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: Fix cpu usage key names .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40845 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id26c427d67de47cbcc39ddd43ab4cfe8467432c4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sslutils: move createSSLContext from clientIF
Nir Soffer has posted comments on this change.
Change subject: sslutils: move createSSLContext from clientIF
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/36699/8/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
Line 340:
Line 341:
Line 342: def ssl_enabled():
Line 343: return config.getboolean('vars', 'ssl')
Line 344:
> redundant. there are many locations that have this condition if config.getb
This was my suggestion :-)
We can fix this by using sslutils.ssl_enabled() instead of repeating
config.getboolean('vars', 'ssl').
Line 345:
Line 346: def create_ssl_context():
Line 347: if ssl_enabled():
Line 348: truststore_path = config.get('vars', 'trust_store_path')
--
To view, visit https://gerrit.ovirt.org/36699
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c7e324759892232d16a4913314f1dfa76ea85b8
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronheim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: password: Prevent password logging and persisting
Nir Soffer has posted comments on this change. Change subject: password: Prevent password logging and persisting .. Patch Set 5: Dan, Francesco, I believe this version address your comments. Would you review it again? -- To view, visit https://gerrit.ovirt.org/40707 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc849ad8bdc1b1fd09884e18038427d96e66110f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: allow to get the nth-last sample
Dan Kenigsberg has posted comments on this change. Change subject: sampling: allow to get the nth-last sample .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40427 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If73a6c0dc3503f6bcb02300517bbd2ff1424bcc3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
Dan Kenigsberg has posted comments on this change. Change subject: sampling: less verbose debug in _getInterfaceStats .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: password: Prevent password logging and persisting
automat...@ovirt.org has posted comments on this change. Change subject: password: Prevent password logging and persisting .. Patch Set 5: * Update tracker::#1220039::OK * Check Bug-Url::OK * Check Public Bug::#1220039::OK, public bug * Check Product::#1220039::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40707 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc849ad8bdc1b1fd09884e18038427d96e66110f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
Dan Kenigsberg has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 3: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testlib: drop python-2.6-specific code
automat...@ovirt.org has posted comments on this change. Change subject: testlib: drop python-2.6-specific code .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40888 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0784adea1c4156daf824c4a5092b91ce9e97a643 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: debug: Add virt-alignment-scan.debug tool
automat...@ovirt.org has posted comments on this change. Change subject: debug: Add virt-alignment-scan.debug tool .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ec4d0219ea039d57ee8809339a7e03d71980bf8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: debug: Add virt-alignment-scan.debug tool
automat...@ovirt.org has posted comments on this change. Change subject: debug: Add virt-alignment-scan.debug tool .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ec4d0219ea039d57ee8809339a7e03d71980bf8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: debug: Add virt-alignment-scan.debug tool
automat...@ovirt.org has posted comments on this change. Change subject: debug: Add virt-alignment-scan.debug tool .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ec4d0219ea039d57ee8809339a7e03d71980bf8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: debug: Add virt-alignment-scan.debug tool
Nir Soffer has uploaded a new change for review. Change subject: debug: Add virt-alignment-scan.debug tool .. debug: Add virt-alignment-scan.debug tool Change-Id: I2ec4d0219ea039d57ee8809339a7e03d71980bf8 Signed-off-by: Nir Soffer --- A vdsm/virt-alignment-scan.debug 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/40896/1 diff --git a/vdsm/virt-alignment-scan.debug b/vdsm/virt-alignment-scan.debug new file mode 100755 index 000..e904b45 --- /dev/null +++ b/vdsm/virt-alignment-scan.debug @@ -0,0 +1,24 @@ +#!/bin/sh +# +# Debug tool for virt-alignmnet-scan +# +# Installation: +# +#mv /usr/bin/virt-alignment-scan /usr/bin/virt-alignment-scan.real +#ln -s /usr/share/vdsm/virt-alignment-scan.debug /usr/bin/virt-alignment-scan +# +# Uinstall +# +#mv /usr/bin/virt-alignment-scan.real /usr/bin/virt-alignment-scan + +log="/var/log/vdsm/virt-alignmnet-scan.debug.log" + +/usr/bin/virt-alignment-scan "$@" +rc=$? +if [ $rc -ne 0 ]; then +# See https://bugzilla.redhat.com/show_bug.cgi?id=1151838#c28 +sleep 30 +/usr/bin/libguestfs-test-tool >> $log 2>&1 +fi + +exit $rc -- To view, visit https://gerrit.ovirt.org/40896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2ec4d0219ea039d57ee8809339a7e03d71980bf8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: raise proper execption if mount point already used
Timothy Asir has uploaded a new change for review. Change subject: gluster: raise proper execption if mount point already used .. gluster: raise proper execption if mount point already used Currently if an already used mount point is given for the brick create function, it does all the lvm tasks and returns Unexpected Exception when it tries to mout the device at the end of brick create scenario. This patch will check given mount point availablity and returns an appropriate exception. Change-Id: Ic12acd2e4bf6a88936af582bb17d50d72cdfb84f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1209475 Signed-off-by: Timothy Asir Jeyasingh --- M vdsm/gluster/exception.py M vdsm/gluster/storagedev.py 2 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/40892/1 diff --git a/vdsm/gluster/exception.py b/vdsm/gluster/exception.py index d093661..cd5babe 100644 --- a/vdsm/gluster/exception.py +++ b/vdsm/gluster/exception.py @@ -467,6 +467,16 @@ message = "Make directories failed" +class GlusterHostStorageMountPointAlreadyFoundException(GlusterHostException): +code = 4517 + +def __init__(self, mountPoint, rc=0, out=(), err=()): +self.rc = rc +self.out = out +self.err = err +self.message = "Mount point %s already found" % mountPoint) + + # Hook class GlusterHookException(GlusterException): code = 4500 diff --git a/vdsm/gluster/storagedev.py b/vdsm/gluster/storagedev.py index a860179..0968e6b 100644 --- a/vdsm/gluster/storagedev.py +++ b/vdsm/gluster/storagedev.py @@ -32,6 +32,7 @@ from blivet.devices import LVMThinLogicalVolumeDevice import storage.lvm as lvm +import storage.mount as mount from vdsm import utils import fstab @@ -214,6 +215,10 @@ blivetEnv.reset() return blivetEnv.devicetree.getDeviceByName(poolLv.name) +if mount.isMounted(mountPoint): +raise ge.GlusterHostStorageMountPointAlreadyFoundException( +mountPoint, rc, out, err) + vgName = "vg-" + brickName poolName = "pool-" + brickName alignment = 0 -- To view, visit https://gerrit.ovirt.org/40892 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic12acd2e4bf6a88936af582bb17d50d72cdfb84f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: raise proper execption if mount point already used
automat...@ovirt.org has posted comments on this change. Change subject: gluster: raise proper execption if mount point already used .. Patch Set 1: * Update tracker::#1209475::OK * Check Bug-Url::OK * Check Public Bug::#1209475::OK, public bug * Check Product::#1209475::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40892 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic12acd2e4bf6a88936af582bb17d50d72cdfb84f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: set default value for dataalignment and physicalext...
Timothy Asir has uploaded a new change for review.
Change subject: gluster: set default value for dataalignment and physicalextent
value
..
gluster: set default value for dataalignment and physicalextent value
Set default value as 256 for dataalignment and
physical extent size as 256.
Change-Id: Ib8b7f3104705e5d303f4c0739f15cfd592e84b8e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1210296
Signed-off-by: Timothy Asir Jeyasingh
---
M vdsm/gluster/storagedev.py
1 file changed, 23 insertions(+), 40 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/40890/1
diff --git a/vdsm/gluster/storagedev.py b/vdsm/gluster/storagedev.py
index a860179..8a9aefe 100644
--- a/vdsm/gluster/storagedev.py
+++ b/vdsm/gluster/storagedev.py
@@ -131,44 +131,16 @@
blivet.partitioning.doPartitioning(blivetEnv)
return pvDeviceList
-def _createPV(deviceList, alignment=0):
-def _createAlignedPV(deviceList, alignment):
-for dev in deviceList:
-rc, out, err = lvm._createpv(
-[dev.path], metadataSize=0,
-options=('--dataalignment', '%sK' % alignment))
-if rc:
-raise ge.GlusterHostStorageDevicePVCreateFailedException(
-dev.path, alignment, rc, out, err)
-
-blivetEnv.reset()
-return _getDeviceList([dev.name for dev in deviceList])
-
-if alignment:
-blivetEnv.doIt()
-return _createAlignedPV(deviceList, alignment)
-
-for dev in deviceList:
-lvmpv = blivet.formats.getFormat("lvmpv", device=dev.path)
-blivetEnv.formatDevice(dev, lvmpv)
-
-blivet.partitioning.doPartitioning(blivetEnv)
-return deviceList
-
-def _createVG(vgName, deviceList, stripeSize=0):
-if stripeSize:
-vg = LVMVolumeGroupDevice(
-vgName, peSize=blivet.size.Size('%s KiB' % stripeSize),
-parents=deviceList)
-else:
-vg = LVMVolumeGroupDevice(vgName, parents=deviceList)
-
+def _createVG(vgName, deviceList, stripeSize):
+vg = LVMVolumeGroupDevice(
+vgName, peSize=blivet.size.Size('%s KiB' % stripeSize),
+parents=deviceList)
blivetEnv.createDevice(vg)
return vg
def _createThinPool(poolName, vg, alignment=0,
poolMetaDataSize=0, poolDataSize=0):
-if not alignment:
+if not poolDataSize:
# bz#1180228: blivet doesn't handle percentage-based sizes properly
# Workaround: Till the bz gets fixed, we take only 99% size from vg
pool = LVMThinPoolDevice(poolName, parents=[vg],
@@ -216,16 +188,17 @@
vgName = "vg-" + brickName
poolName = "pool-" + brickName
-alignment = 0
+alignment = 256
chunkSize = 0
poolDataSize = 0
count = 0
metaDataSize = DEFAULT_METADATA_SIZE_KB
-if raidParams.get('type') == '6':
+raidType = raidParams.get('type', None)
+if raidType== '6':
count = raidParams['pdCount'] - 2
alignment = raidParams['stripeSize'] * count
chunkSize = alignment
-elif raidParams.get('type') == '10':
+elif raidType == '10':
count = raidParams['pdCount'] / 2
alignment = raidParams['stripeSize'] * count
chunkSize = DEFAULT_CHUNK_SIZE_KB
@@ -246,14 +219,24 @@
raise ge.GlusterHostStorageDeviceInUseException(inUseList)
pvDeviceList = _makePartition(deviceList)
-pvDeviceList = _createPV(pvDeviceList, alignment)
-vg = _createVG(vgName, pvDeviceList, raidParams.get('stripeSize', 0))
+for dev in deviceList:
+lvmpv = blivet.formats.getFormat(
+"lvmpv", device=dev.path,
+dataAlignment=blivet.size.Size('%s KiB' % alignment))
+blivetEnv.formatDevice(dev, lvmpv)
+blivet.partitioning.doPartitioning(blivetEnv)
+return deviceList
+vg = LVMVolumeGroupDevice(
+vgName, peSize=blivet.size.Size(
+'%s KiB' % raidParams.get('stripeSize', 256)),
+parents=deviceList)
+blivetEnv.createDevice(vg)
# The following calculation is based on the redhat storage performance doc
# http://docbuilder.usersys.redhat.com/22522
# /#chap-Configuring_Red_Hat_Storage_for_Enhancing_Performance
-if alignment:
+if raidType:
vgSizeKib = int(vg.size.convertTo(spec="KiB"))
if vg.size.convertTo(spec='MiB') < MIN_VG_SIZE:
metaDataSize = vgSizeKib * MIN_METADATA_PERCENT
@@ -273,7 +256,7 @@
thinlv.path, alignment, raidParams.get('stripeSize', 0), fsType)
format = blivet.formats.getFormat(DEFAULT_FS_TYPE, device=thinlv.path)
-if alignment:
+if raidType:
format._defaultFormatOptions = [
"-f", "-K", "-i", "size=512",
"-d", "sw=%s,su=%s
Change in vdsm[master]: gluster: set default value for dataalignment and physicalext...
automat...@ovirt.org has posted comments on this change. Change subject: gluster: set default value for dataalignment and physicalextent value .. Patch Set 1: * Update tracker::#1210296::OK * Check Bug-Url::OK * Check Public Bug::#1210296::OK, public bug * Check Product::#1210296::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40890 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8b7f3104705e5d303f4c0739f15cfd592e84b8e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testlib: drop python-2.6-specific code
automat...@ovirt.org has posted comments on this change. Change subject: testlib: drop python-2.6-specific code .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40888 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0784adea1c4156daf824c4a5092b91ce9e97a643 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testlib: drop python-2.6-specific code
Dan Kenigsberg has uploaded a new change for review.
Change subject: testlib: drop python-2.6-specific code
..
testlib: drop python-2.6-specific code
Noe that we no longer support el6 and its python-2.6, we can drop these
backports.
Change-Id: I0784adea1c4156daf824c4a5092b91ce9e97a643
Signed-off-by: Dan Kenigsberg
---
M tests/testlib.py
1 file changed, 0 insertions(+), 83 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/40888/1
diff --git a/tests/testlib.py b/tests/testlib.py
index 35c870a..2dda547 100644
--- a/tests/testlib.py
+++ b/tests/testlib.py
@@ -162,89 +162,6 @@
from vdsm.utils import retry
return retry(expectedException=AssertionError, *args, **kwargs)
-def assertRaises(self, excClass, callableObj=None, *args, **kwargs):
-# FIXME: This is a forward port of the assertRaises from python
-#2.7, remove when no loger supporting earlier versions
-context = _AssertRaisesContext(excClass, self)
-if callableObj is None:
-return context
-with context:
-callableObj(*args, **kwargs)
-
-def assertNotRaises(self, callableObj=None, *args, **kwargs):
-# This is required when any exception raised during the call should be
-# considered as a test failure.
-context = not_raises(self)
-if callableObj is None:
-return context
-with context:
-callableObj(*args, **kwargs)
-
-# FIXME: This is a forward port of the assertIn from python
-#2.7, remove when no loger supporting earlier versions
-def assertIn(self, member, container, msg=None):
-"""
-Just like self.assertTrue(a in b), but with a nicer default message.
-"""
-if member not in container:
-if msg is None:
-msg = '%s not found in %s' % (safe_repr(member),
- safe_repr(container))
-raise self.failureException(msg)
-
-# FIXME: This is a forward port of the assertNotIn from python
-#2.7, remove when no loger supporting earlier versions
-def assertNotIn(self, member, container, msg=None):
-"""
-Just like self.assertTrue(a not in b), but with a nicer default message
-"""
-if member in container:
-if msg is None:
-msg = '%s unexpectedly found in %s' % (safe_repr(member),
- safe_repr(container))
-raise self.failureException(msg)
-
-# FIXME: This is a forward port of the assertAlmostEqual from python
-#2.7, remove when no longer supporting earlier versions
-# we need the 'delta' keyword argument, which was added in python 2.7
-def assertAlmostEqual(self, first, second, places=None,
- msg=None, delta=None):
-"""Fail if the two objects are unequal as determined by their
- difference rounded to the given number of decimal places
- (default 7) and comparing to zero, or by comparing that the
- between the two objects is more than the given delta.
-
- Note that decimal places (from zero) are usually not the same
- as significant digits (measured from the most signficant digit).
-
- If the two objects compare equal then they will automatically
- compare almost equal.
-"""
-if first == second:
-# shortcut
-return
-if delta is not None and places is not None:
-raise TypeError("specify delta or places not both")
-
-if delta is not None:
-if abs(first - second) <= delta:
-return
-
-standardMsg = '%s != %s within %s delta' % (safe_repr(first),
-safe_repr(second),
-safe_repr(delta))
-else:
-if places is None:
-places = 7
-
-if round(abs(second-first), places) == 0:
-return
-
-standardMsg = '%s != %s within %r places' % (
-safe_repr(first), safe_repr(second), places)
-msg = self._formatMessage(msg, standardMsg)
-raise self.failureException(msg)
-
@contextmanager
def assertElapsed(self, expected, tolerance=0.5):
start = vdsm.utils.monotonic_time()
--
To view, visit https://gerrit.ovirt.org/40888
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0784adea1c4156daf824c4a5092b91ce9e97a643
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listin
Change in vdsm[master]: migration: remove getVmStats before migration
Yaniv Bronhaim has posted comments on this change. Change subject: migration: remove getVmStats before migration .. Patch Set 9: not related to the chain at all .. -- To view, visit https://gerrit.ovirt.org/39202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic83ab46173d5d7e5bfd85bf00b8f86a530da5dd4 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Feng Yang Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: remove getVmStats before migration
Yaniv Bronhaim has posted comments on this change. Change subject: migration: remove getVmStats before migration .. Patch Set 9: Code-Review+1 please don't depend on the rest of the patches. lets merge it separately -- To view, visit https://gerrit.ovirt.org/39202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic83ab46173d5d7e5bfd85bf00b8f86a530da5dd4 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Feng Yang Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sslutils: move createSSLContext from clientIF
Yaniv Bronhaim has posted comments on this change.
Change subject: sslutils: move createSSLContext from clientIF
..
Patch Set 8: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/36699/8/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
Line 340:
Line 341:
Line 342: def ssl_enabled():
Line 343: return config.getboolean('vars', 'ssl')
Line 344:
redundant. there are many locations that have this condition if
config.getboolean('vars', 'ssl'):
Line 345:
Line 346: def create_ssl_context():
Line 347: if ssl_enabled():
Line 348: truststore_path = config.get('vars', 'trust_store_path')
--
To view, visit https://gerrit.ovirt.org/36699
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c7e324759892232d16a4913314f1dfa76ea85b8
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronheim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: verbs to enable/disable snapshot scheduling.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: verbs to enable/disable snapshot scheduling. .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff8f21593921bac18950a9ee42bb3972d278f7aa Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: require qemu-*-ev on CentOS >= 7
Yaniv Bronhaim has submitted this change and it was merged. Change subject: spec: require qemu-*-ev on CentOS >= 7 .. spec: require qemu-*-ev on CentOS >= 7 Added a requirement for qemu-kvm-ev and qemu-img-ev on CentOS >= 7. qemu-*-ev rpms are upstream version for qemu-*-rhev. These supply features needed that are not available in the regular qemu-*, for example 'Live Snapshot'. Change-Id: Ibbec719863d7b12150574a60d071f38bcfa62398 Signed-off-by: Idan Shaby Signed-off-by: Fred Rolland Bug-Url: https://bugzilla.redhat.com/1221192 Bug-Url: https://bugzilla.redhat.com/1220333 Reviewed-on: https://gerrit.ovirt.org/40670 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg Reviewed-by: Allon Mureinik Reviewed-on: https://gerrit.ovirt.org/40876 Continuous-Integration: Dan Kenigsberg --- M vdsm.spec.in 1 file changed, 11 insertions(+), 7 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved; Passed CI tests Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/40876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibbec719863d7b12150574a60d071f38bcfa62398 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: updated qemu-* requirements on EL
automat...@ovirt.org has posted comments on this change. Change subject: spec: updated qemu-* requirements on EL .. Patch Set 5: * Update tracker::#1221192::OK * Update tracker::#1220333::OK * Set MODIFIED::bug 1221192#1221192IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager * Set MODIFIED::bug 1221192bug 1220333#1220333IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager -- To view, visit https://gerrit.ovirt.org/40877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbd1fdd425f773776c5ce7596a0f339480a3296c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: updated qemu-* requirements on EL
Yaniv Bronhaim has submitted this change and it was merged. Change subject: spec: updated qemu-* requirements on EL .. spec: updated qemu-* requirements on EL Updated the build version for qemu-kvm-ev,qemu-kvm-rev,qemu-img-ev and qemu-img-rhev for a EL build on EL >= 7. The required qemu-img version solves a crash when using qemu-img convert -t none on some block storage devices (see https://bugzilla.redhat.com/show_bug.cgi?id=1203543 for details). Change-Id: Ifbd1fdd425f773776c5ce7596a0f339480a3296c Signed-off-by: Idan Shaby Signed-off-by: Fred Rolland Bug-Url: https://bugzilla.redhat.com/1221192 Bug-Url: https://bugzilla.redhat.com/1220333 Reviewed-on: https://gerrit.ovirt.org/40671 Reviewed-by: Allon Mureinik Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/40877 Reviewed-by: Yaniv Bronhaim Continuous-Integration: Yaniv Bronhaim --- M vdsm.spec.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, approved; Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/40877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbd1fdd425f773776c5ce7596a0f339480a3296c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: updated qemu-* requirements on EL
Yaniv Bronhaim has posted comments on this change. Change subject: spec: updated qemu-* requirements on EL .. Patch Set 4: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/40877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbd1fdd425f773776c5ce7596a0f339480a3296c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: add an option to create a stomp client
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: add an option to create a stomp client
..
Patch Set 9:
(2 comments)
https://gerrit.ovirt.org/#/c/38491/9/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 449: def createStompClient(self, client_socket):
Line 450: try:
Line 451: json_binding = self.bindings['jsonrpc']
Line 452: except KeyError:
Line 453: raise Exception("json rpc server is not available")
not better to check "if config.getboolean('vars', 'jsonrpc_enable')" ??
Line 454: reactor = json_binding.reactor
Line 455: stompClient = reactor.createClient(client_socket)
Line 456: if stompClient is None:
Line 457: raise Exception("Failed to create a stomp client")
Line 453: raise Exception("json rpc server is not available")
Line 454: reactor = json_binding.reactor
Line 455: stompClient = reactor.createClient(client_socket)
Line 456: if stompClient is None:
Line 457: raise Exception("Failed to create a stomp client")
could you be more specific with the exceptions? you can raise StompError or
RuntimeException
Line 458: else:
Line 459: return stompClient
Line 460:
Line 461:
--
To view, visit https://gerrit.ovirt.org/38491
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronheim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: client side subscription
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: client side subscription
..
Patch Set 19:
(1 comment)
https://gerrit.ovirt.org/#/c/36368/19/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReactor.py:
Line 332: self._destination = destination
Line 333: self._client = client
Line 334: self._message_handler = lambda arg: None
Line 335:
Line 336: def setMessageHandler(self, handler):
> quite weird.. you set the handler in __init__ and allow to set another hand
This is contract that we use for setting a message handler.
Line 337: self._message_handler = handler
Line 338:
Line 339: def send(self, data):
Line 340: headers = {
--
To view, visit https://gerrit.ovirt.org/36368
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronheim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: updated qemu-* requirements on EL
Freddy Rolland has posted comments on this change. Change subject: spec: updated qemu-* requirements on EL .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/40877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbd1fdd425f773776c5ce7596a0f339480a3296c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: require qemu-*-ev on CentOS >= 7
Dan Kenigsberg has posted comments on this change. Change subject: spec: require qemu-*-ev on CentOS >= 7 .. Patch Set 5: Continuous-Integration+1 testMethodReturnsNullAndServerReturnsTrue failure unrelated to this patch. -- To view, visit https://gerrit.ovirt.org/40876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbec719863d7b12150574a60d071f38bcfa62398 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: require qemu-*-ev on CentOS >= 7
automat...@ovirt.org has posted comments on this change. Change subject: spec: require qemu-*-ev on CentOS >= 7 .. Patch Set 6: * Update tracker::#1221192::OK * Update tracker::#1220333::OK * Set MODIFIED::bug 1221192#1221192IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager * Set MODIFIED::bug 1221192bug 1220333#1220333IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager -- To view, visit https://gerrit.ovirt.org/40876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbec719863d7b12150574a60d071f38bcfa62398 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: subscription cleanup when connection lost
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: subscription cleanup when connection lost
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/39969/6/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line 406: return int(round(monotonic_time() * 1000))
Line 407:
Line 408: def handle_close(self, dispatcher):
Line 409: self.connection.close()
Line 410:
> now you put that? should be in separate patch and get in today.
No it shouldn't it is part of cleanup.
Line 411:
Line 412: class AsyncClient(object):
Line 413: log = logging.getLogger("yajsonrpc.stomp.AsyncClient")
Line 414:
--
To view, visit https://gerrit.ovirt.org/39969
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff05e4ff9d336dbfddf80002bad5bcd0dbac697f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: add an option to create a stomp client
Yaniv Bronhaim has posted comments on this change. Change subject: stomp: add an option to create a stomp client .. Patch Set 9: Code-Review-1 you have pep8 error here (vdsm/clientIF.py:462:5: E303 too many blank lines (2) -- To view, visit https://gerrit.ovirt.org/38491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronheim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: updated qemu-* requirements on EL
Allon Mureinik has posted comments on this change.
Change subject: spec: updated qemu-* requirements on EL
..
Patch Set 4: Code-Review+1
The Jenkins failure is just redundant noise, as usual - this time, failing unit
tests which have nothing to do with qemu:
ERROR: testDiff (samplingTests.InterfaceSampleTests)
--
Traceback (most recent call last):
File "/builddir/build/BUILD/vdsm-4.16.16/tests/samplingTests.py", line 139,
in testDiff
lo = ipwrapper.getLink('lo')
File "/builddir/build/BUILD/vdsm-4.16.16/lib/vdsm/ipwrapper.py", line 300, in
getLink
return Link.fromDict(netlink.get_link(dev))
File "/builddir/build/BUILD/vdsm-4.16.16/lib/vdsm/netlink.py", line 62, in
get_link
with _nl_link_cache(sock) as cache:
File "/usr/lib64/python2.7/contextlib.py", line 17, in __enter__
return self.gen.next()
File "/builddir/build/BUILD/vdsm-4.16.16/lib/vdsm/netlink.py", line 119, in
_cache_manager
cache = cache_allocator(sock)
File "/builddir/build/BUILD/vdsm-4.16.16/lib/vdsm/netlink.py", line 260, in
_rtnl_link_alloc_cache
raise IOError(-err, _nl_geterror())
IOError: [Errno 8] Unspecific failure
--
To view, visit https://gerrit.ovirt.org/40877
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbd1fdd425f773776c5ce7596a0f339480a3296c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Freddy Rolland
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Fred Rolland
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: outgoing connection to a broker
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: outgoing connection to a broker
..
Patch Set 13:
(9 comments)
https://gerrit.ovirt.org/#/c/38819/13/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 180: 'Enable HTTP/1.1 keep-alive connections'),
Line 181:
Line 182: ('jsonrpc_enable', 'true', 'Enable the JSON RPC server'),
Line 183:
Line 184: ('broker_enable', 'false', 'Enable outgoing connection to
broker'),
> mention in the commit message what values you add to vdsm config and the re
Done
Line 185:
Line 186: ('report_host_threads_as_cores', 'false',
Line 187: 'Count each cpu hyperthread as an individual core'),
Line 188:
Line 323: 'Port where the broker is listening at.'),
Line 324:
Line 325: ('request_queues',
Line 326: 'jms.topic.vdsm_requests,jms.topic.vdsm_irs_requests',
Line 327: 'Queues to subscribe to for RPC requests'),
> to or for?
This is naming convention used by a broker that we plan to use.
Line 328:
Line 329: ('event_queue', 'jms.topic.vdsm_responses',
Line 330: 'Queue used for events'),
Line 331: ]),
Line 326: 'jms.topic.vdsm_requests,jms.topic.vdsm_irs_requests',
Line 327: 'Queues to subscribe to for RPC requests'),
Line 328:
Line 329: ('event_queue', 'jms.topic.vdsm_responses',
Line 330: 'Queue used for events'),
> jsonrpc events
it uses jsonrpc as message format but it is more complex so I wouldn't use this
name here.
Line 331: ]),
Line 332:
Line 333: # Section: [sampling]
Line 334: ('sampling', [
https://gerrit.ovirt.org/#/c/38819/13/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReactor.py:
Line 162: return
Line 163: elif stomp.LEGACY_SUB_ID_REQ == destination:
Line 164: self._handle_internal(dispatcher, stomp.LEGACY_SUB_ID_RES,
Line 165: frame.body)
Line 166: return
> no else? could it cause keyerror next line?
No. we are using defaultdict here.
Line 167:
Line 168: subs = self._sub_dests[destination]
Line 169: if not subs:
Line 170: self._send_error("Subscription not available",
Line 256:
Line 257: class StompServer(object):
Line 258: log = logging.getLogger("yajsonrpc.StompServer")
Line 259:
Line 260: def __init__(self, reactor, subs):
> why do you do all those words shortcuts? call it subscriptions please
Done
Line 261: self._reactor = reactor
Line 262: self._messageHandler = None
Line 263: self._sub_map = subs
Line 264: self._req_dest = {}
Line 349:
Line 350: def send(
Line 351: self,
Line 352: message,
Line 353: destination=stomp.LEGACY_SUB_ID_RES,
> LEGACY_SUBSCRIPTION_ID_RESPONSE will fit in line
Done
Line 354: headers=None
Line 355: ):
Line 356: self.log.debug("Sending request")
Line 357: self._aclient.send(
Line 436: self.json_binding.add_socket(self._reactor, client_socket)
Line 437: self.log.debug("Stomp detected from %s", socket_address)
Line 438:
Line 439:
Line 440: class ServerRpcContextAdapter(object):
> please explain the need for this class . easy to understand but a comment s
Done
Line 441: @classmethod
Line 442: def subscription_handler(cls, server):
Line 443: def handler(sub, frame):
Line 444: server.queueRequest(
https://gerrit.ovirt.org/#/c/38819/13/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 91: self._generationID = str(uuid.uuid4())
Line 92: self.mom = None
Line 93: self.bindings = {}
Line 94: self._broker_client = None
Line 95: self.subs = defaultdict(list)
> self.subscriptions please
Done
Line 96: if _glusterEnabled:
Line 97: self.gluster = gapi.GlusterApi(self, log)
Line 98: else:
Line 99: self.gluster = None
Line 194:
Line 195: self._acceptor = MultiProtocolAcceptor(self._reactor, host,
Line 196:port, sslctx)
Line 197:
Line 198: def _connectToBroker(self):
> who calls it?
Good catch. Will update.
Line 199: if config.getboolean('vars', 'broker_enable'):
Line 200: broker_address = config.get('addresses', 'broker_address')
Line 201: broker_port = config.getint('addresses', 'broker_port')
Line 202: request_queues = config.get('addresses', 'request_queues')
--
To view, visit https://gerrit.ovirt.org/38819
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied3095a305fd5a5bfc19c8bc0342fba7cb811843
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewe
Change in vdsm[master]: stomp: client side subscription
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: client side subscription
..
Patch Set 19:
(1 comment)
https://gerrit.ovirt.org/#/c/36368/19/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReactor.py:
Line 332: self._destination = destination
Line 333: self._client = client
Line 334: self._message_handler = lambda arg: None
Line 335:
Line 336: def setMessageHandler(self, handler):
quite weird.. you set the handler in __init__ and allow to set another handler
afterwards but will never use the new one. im confused.
Line 337: self._message_handler = handler
Line 338:
Line 339: def send(self, data):
Line 340: headers = {
--
To view, visit https://gerrit.ovirt.org/36368
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronheim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: allow custom bondOption
Petr Horáček has posted comments on this change.
Change subject: network: allow custom bondOption
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/40882/1/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 2398: 'options': 'custom=foo
mode=balance-rr'}},
Line 2399: NOCHK)
Line 2400: self.assertEqual(status, SUCCESS, msg)
Line 2401: self.assertBondExists(BONDING_NAME, nics)
Line 2402: with open(NET_CONF_PREF + BONDING_NAME) as f:
> this is terribly specific to the ifcfg configurator. I think that passing t
it check if passed options are subset of real bond options, but i agree, we
just have to change it a bit
Line 2403: for l in f:
Line 2404: if 'BONDING_OPTS' in l:
Line 2405: self.assertNotIn('custom=foo', l)
Line 2406: self.assertIn('mode=balance-rr', l)
--
To view, visit https://gerrit.ovirt.org/40882
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ace532d959bc3195a8a92b4536bdc0062bc7d1d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: require qemu-*-ev on CentOS >= 7
automat...@ovirt.org has posted comments on this change. Change subject: spec: require qemu-*-ev on CentOS >= 7 .. Patch Set 5: * Update tracker::#1221192::OK * Update tracker::#1220333::OK * Check Bug-Url::OK * Check Public Bug::#1221192::OK, public bug * Check Public Bug::#1220333::OK, public bug * Check Product::#1221192::OK, Correct product Red Hat Enterprise Virtualization Manager * Check Product::#1220333::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1221192::OK, correct target release 3.5.3 * Check TR::#1220333::OK, correct target release 3.5.3 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/40876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbec719863d7b12150574a60d071f38bcfa62398 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: allow custom bondOption
Dan Kenigsberg has posted comments on this change.
Change subject: network: allow custom bondOption
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/40882/1/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 2398: 'options': 'custom=foo
mode=balance-rr'}},
Line 2399: NOCHK)
Line 2400: self.assertEqual(status, SUCCESS, msg)
Line 2401: self.assertBondExists(BONDING_NAME, nics)
Line 2402: with open(NET_CONF_PREF + BONDING_NAME) as f:
this is terribly specific to the ifcfg configurator. I think that passing the
expected option to assertBondExists() does what we need.
Line 2403: for l in f:
Line 2404: if 'BONDING_OPTS' in l:
Line 2405: self.assertNotIn('custom=foo', l)
Line 2406: self.assertIn('mode=balance-rr', l)
--
To view, visit https://gerrit.ovirt.org/40882
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ace532d959bc3195a8a92b4536bdc0062bc7d1d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: make relative imports PY3 compatible
Petr Horáček has uploaded a new change for review. Change subject: netlink: make relative imports PY3 compatible .. netlink: make relative imports PY3 compatible Change-Id: I43f01393790283eca5118e6e492eef1f7e6eb5c0 Signed-off-by: Petr Horáček --- M lib/vdsm/netlink/monitor.py 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/40883/1 diff --git a/lib/vdsm/netlink/monitor.py b/lib/vdsm/netlink/monitor.py index 41b3b1c..3ebfe51 100644 --- a/lib/vdsm/netlink/monitor.py +++ b/lib/vdsm/netlink/monitor.py @@ -31,9 +31,9 @@ _close_socket, _drop_socket_memberships, _int_proto, _nl_msg_parse, _nl_object_get_type, _nl_recvmsgs_default, _nl_socket_get_fd, _open_socket) -from addr import _addr_info -from link import _link_info -from route import _route_info +from .addr import _addr_info +from .link import _link_info +from .route import _route_info # If monitoring thread is running, queue waiting for new value and we call # stop(), we have to stop queue by passing special code. -- To view, visit https://gerrit.ovirt.org/40883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I43f01393790283eca5118e6e492eef1f7e6eb5c0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: make relative imports PY3 compatible
automat...@ovirt.org has posted comments on this change. Change subject: netlink: make relative imports PY3 compatible .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43f01393790283eca5118e6e492eef1f7e6eb5c0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netinfoTests: Do not try to read bonding options
Yaniv Bronhaim has submitted this change and it was merged. Change subject: netinfoTests: Do not try to read bonding options .. netinfoTests: Do not try to read bonding options A user running the tests usually does not have sudo permissions to create a bond. Change-Id: Id85764ac54a29a2359bb81ca1ce0819a0eee2758 Signed-off-by: Ondřej Svoboda Reviewed-on: http://gerrit.ovirt.org/31270 Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/40881 Continuous-Integration: Jenkins CI Reviewed-by: Yaniv Bronhaim Tested-by: Dan Kenigsberg --- M tests/netinfoTests.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, approved Jenkins CI: Passed CI tests Dan Kenigsberg: Verified -- To view, visit https://gerrit.ovirt.org/40881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id85764ac54a29a2359bb81ca1ce0819a0eee2758 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netinfoTests: Do not try to read bonding options
automat...@ovirt.org has posted comments on this change. Change subject: netinfoTests: Do not try to read bonding options .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id85764ac54a29a2359bb81ca1ce0819a0eee2758 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: verbs to enable/disable snapshot scheduling.
Darshan N has posted comments on this change. Change subject: gluster: verbs to enable/disable snapshot scheduling. .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/40141/5/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 150: snap_scheduler > can't this be loaded as module than exec? Done Line 162: try: Line 163: fcntl.flock(f, fcntl.LOCK_EX | fcntl.LOCK_NB) Line 164: safeWrite(SNAP_SCHEDULER_FLAG, value) Line 165: fcntl.flock(f, fcntl.LOCK_UN) Line 166: except IOError: > you should log the error Done Line 167: os.close(f) Line 168: raise ge.GlusterSnapshotScheduleFlagUpdateFailedException( Line 169: err=["unable to get the lock"]) Line 170: except OSError as e: -- To view, visit https://gerrit.ovirt.org/40141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff8f21593921bac18950a9ee42bb3972d278f7aa Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netinfoTests: Do not try to read bonding options
Dan Kenigsberg has posted comments on this change. Change subject: netinfoTests: Do not try to read bonding options .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id85764ac54a29a2359bb81ca1ce0819a0eee2758 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netinfoTests: Do not try to read bonding options
Yaniv Bronhaim has posted comments on this change. Change subject: netinfoTests: Do not try to read bonding options .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id85764ac54a29a2359bb81ca1ce0819a0eee2758 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: allow custom bondOption
automat...@ovirt.org has posted comments on this change. Change subject: network: allow custom bondOption .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40882 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ace532d959bc3195a8a92b4536bdc0062bc7d1d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: subscription cleanup when connection lost
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: subscription cleanup when connection lost
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/39969/6/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line 406: return int(round(monotonic_time() * 1000))
Line 407:
Line 408: def handle_close(self, dispatcher):
Line 409: self.connection.close()
Line 410:
now you put that? should be in separate patch and get in today.
Line 411:
Line 412: class AsyncClient(object):
Line 413: log = logging.getLogger("yajsonrpc.stomp.AsyncClient")
Line 414:
--
To view, visit https://gerrit.ovirt.org/39969
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff05e4ff9d336dbfddf80002bad5bcd0dbac697f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: allow custom bondOption
Petr Horáček has uploaded a new change for review.
Change subject: network: allow custom bondOption
..
network: allow custom bondOption
Allow 'custom' in bond options. This value will be accepted by
Bond.validateOptions method but it will not be passed to configurator.
Thanks to this patch, users will be allowed to pass custom properties
to setupNetworks hooks.
This path was reverted in past because of malfunction, now it should
work, there is a new test for sure.
Change-Id: I9ace532d959bc3195a8a92b4536bdc0062bc7d1d
Signed-off-by: Petr Horáček
---
M lib/vdsm/netinfo.py
M tests/functional/networkTests.py
M vdsm/network/models.py
3 files changed, 44 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/40882/1
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index e7563d6..3a2aa8e 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -70,8 +70,9 @@
_BONDING_FAILOVER_MODES = frozenset(('1', '3'))
_BONDING_LOADBALANCE_MODES = frozenset(('0', '2', '4', '5', '6'))
_EXCLUDED_BONDING_ENTRIES = frozenset((
-'slaves', 'active_slave', 'mii_status', 'queue_id', 'ad_aggregator',
-'ad_num_ports', 'ad_actor_key', 'ad_partner_key', 'ad_partner_mac'
+'slaves', 'active_slave', 'mii_status', 'queue_id', 'ad_aggregator',
+'ad_num_ports', 'ad_actor_key', 'ad_partner_key', 'ad_partner_mac',
+'custom'
))
_IFCFG_ZERO_SUFFIXED = frozenset(
('IPADDR0', 'GATEWAY0', 'PREFIX0', 'NETMASK0'))
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 0bfda68..1328783 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -1848,7 +1848,7 @@
else:
network_params.update(
{'ipaddr': IP_ADDRESS_IN_NETWORK, 'netmask': IP_MASK,
- 'gateway': IP_GATEWAY})
+ 'gateway': IP_GATEWAY})
status, msg = self.vdsm_net.setupNetworks(
{NETWORK_NAME: network_params}, {}, NOCHK)
@@ -2387,3 +2387,25 @@
self.assertNetworkDoesntExist(NETWORK_NAME)
self.assertBondDoesntExist(BONDING_NAME, [nic])
self.vdsm_net.save_config()
+
+@cleanupNet
+@ValidateRunningAsRoot
+def test_setupNetworks_bond_with_custom_option(self):
+with dummyIf(1) as nics:
+status, msg = self.vdsm_net.setupNetworks(
+{},
+{BONDING_NAME: {'nics': nics,
+'options': 'custom=foo mode=balance-rr'}},
+NOCHK)
+self.assertEqual(status, SUCCESS, msg)
+self.assertBondExists(BONDING_NAME, nics)
+with open(NET_CONF_PREF + BONDING_NAME) as f:
+for l in f:
+if 'BONDING_OPTS' in l:
+self.assertNotIn('custom=foo', l)
+self.assertIn('mode=balance-rr', l)
+
+status, msg = self.vdsm_net.setupNetworks(
+{}, {BONDING_NAME: {'remove': True}}, NOCHK)
+self.assertEqual(status, SUCCESS, msg)
+self.assertBondDoesntExist(BONDING_NAME, nics)
diff --git a/vdsm/network/models.py b/vdsm/network/models.py
index 708bad8..9526b99 100644
--- a/vdsm/network/models.py
+++ b/vdsm/network/models.py
@@ -276,9 +276,25 @@
_netinfo=_netinfo))
return slaves
+@staticmethod
+def remove_custom_option(options):
+""" 'custom' property should not be exposed to configurator, it is
+only for purpose of hooks """
+d_opts = dict(opt.split('=', 1) for opt in options.split())
+try:
+d_opts.pop('custom')
+d_opts = ['%s=%s' % (key, value) for key, value in d_opts.items()]
+return ' '.join(d_opts)
+except KeyError:
+return options
+
@classmethod
def objectivize(cls, name, configurator, options, nics, mtu, _netinfo,
destroyOnMasterRemoval=None):
+
+if options:
+options = cls.remove_custom_option(options)
+
if nics: # New bonding or edit bonding.
slaves = cls._objectivizeSlaves(name, configurator, _nicSort(nics),
mtu, _netinfo)
@@ -318,8 +334,8 @@
try:
for option in bondingOptions.split():
key, _ = option.split('=')
-if not os.path.exists('/sys/class/net/%s/bonding/%s' %
- (bond, key)):
+if key != 'custom' and not os.path.exists(
+'/sys/class/net/%s/bonding/%s' % (bond, key)):
raise ConfigNetworkError(ne.ERR_BAD_BONDING, '%r is '
'not a valid bonding option' %
key)
-
Change in vdsm[master]: gluster: verbs to enable/disable snapshot scheduling.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: verbs to enable/disable snapshot scheduling. .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff8f21593921bac18950a9ee42bb3972d278f7aa Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: require qemu-*-ev on CentOS >= 7
Freddy Rolland has posted comments on this change. Change subject: spec: require qemu-*-ev on CentOS >= 7 .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/40876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbec719863d7b12150574a60d071f38bcfa62398 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: require qemu-*-ev on CentOS >= 7
Freddy Rolland has posted comments on this change. Change subject: spec: require qemu-*-ev on CentOS >= 7 .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/40876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbec719863d7b12150574a60d071f38bcfa62398 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: outgoing connection to a broker
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: outgoing connection to a broker
..
Patch Set 13: Code-Review-1
(9 comments)
https://gerrit.ovirt.org/#/c/38819/13/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 180: 'Enable HTTP/1.1 keep-alive connections'),
Line 181:
Line 182: ('jsonrpc_enable', 'true', 'Enable the JSON RPC server'),
Line 183:
Line 184: ('broker_enable', 'false', 'Enable outgoing connection to
broker'),
mention in the commit message what values you add to vdsm config and the reason
for the defaults
Line 185:
Line 186: ('report_host_threads_as_cores', 'false',
Line 187: 'Count each cpu hyperthread as an individual core'),
Line 188:
Line 323: 'Port where the broker is listening at.'),
Line 324:
Line 325: ('request_queues',
Line 326: 'jms.topic.vdsm_requests,jms.topic.vdsm_irs_requests',
Line 327: 'Queues to subscribe to for RPC requests'),
to or for?
what is jms?
Line 328:
Line 329: ('event_queue', 'jms.topic.vdsm_responses',
Line 330: 'Queue used for events'),
Line 331: ]),
Line 326: 'jms.topic.vdsm_requests,jms.topic.vdsm_irs_requests',
Line 327: 'Queues to subscribe to for RPC requests'),
Line 328:
Line 329: ('event_queue', 'jms.topic.vdsm_responses',
Line 330: 'Queue used for events'),
jsonrpc events
Line 331: ]),
Line 332:
Line 333: # Section: [sampling]
Line 334: ('sampling', [
https://gerrit.ovirt.org/#/c/38819/13/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReactor.py:
Line 162: return
Line 163: elif stomp.LEGACY_SUB_ID_REQ == destination:
Line 164: self._handle_internal(dispatcher, stomp.LEGACY_SUB_ID_RES,
Line 165: frame.body)
Line 166: return
no else? could it cause keyerror next line?
Line 167:
Line 168: subs = self._sub_dests[destination]
Line 169: if not subs:
Line 170: self._send_error("Subscription not available",
Line 256:
Line 257: class StompServer(object):
Line 258: log = logging.getLogger("yajsonrpc.StompServer")
Line 259:
Line 260: def __init__(self, reactor, subs):
why do you do all those words shortcuts? call it subscriptions please
req can easily refer to request, but when you also have res req sub its quite
annoying in a code that should be readable imo.
Line 261: self._reactor = reactor
Line 262: self._messageHandler = None
Line 263: self._sub_map = subs
Line 264: self._req_dest = {}
Line 349:
Line 350: def send(
Line 351: self,
Line 352: message,
Line 353: destination=stomp.LEGACY_SUB_ID_RES,
LEGACY_SUBSCRIPTION_ID_RESPONSE will fit in line
Line 354: headers=None
Line 355: ):
Line 356: self.log.debug("Sending request")
Line 357: self._aclient.send(
Line 436: self.json_binding.add_socket(self._reactor, client_socket)
Line 437: self.log.debug("Stomp detected from %s", socket_address)
Line 438:
Line 439:
Line 440: class ServerRpcContextAdapter(object):
please explain the need for this class . easy to understand but a comment
should help readers.
Line 441: @classmethod
Line 442: def subscription_handler(cls, server):
Line 443: def handler(sub, frame):
Line 444: server.queueRequest(
https://gerrit.ovirt.org/#/c/38819/13/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 91: self._generationID = str(uuid.uuid4())
Line 92: self.mom = None
Line 93: self.bindings = {}
Line 94: self._broker_client = None
Line 95: self.subs = defaultdict(list)
self.subscriptions please
Line 96: if _glusterEnabled:
Line 97: self.gluster = gapi.GlusterApi(self, log)
Line 98: else:
Line 99: self.gluster = None
Line 194:
Line 195: self._acceptor = MultiProtocolAcceptor(self._reactor, host,
Line 196:port, sslctx)
Line 197:
Line 198: def _connectToBroker(self):
who calls it?
Line 199: if config.getboolean('vars', 'broker_enable'):
Line 200: broker_address = config.get('addresses', 'broker_address')
Line 201: broker_port = config.getint('addresses', 'broker_port')
Line 202: request_queues = config.get('addresses', 'request_queues')
--
To view, visit https://gerrit.ovirt.org/38819
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied3095a305fd5a5bfc19c8bc0342fba7cb811843
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewe
Change in vdsm[master]: jsonrpc: events
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: events
..
Patch Set 19:
(6 comments)
https://gerrit.ovirt.org/#/c/38069/19/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 167:
Line 168: return JsonRpcResponse(result, error, reqId)
Line 169:
Line 170:
Line 171: class Notification(object):
> why don't you comment when you introduce new class. I have no idea where do
In my opinion here are the details that clientIF should not be aware of. I will
document this class.
Line 172: log = logging.getLogger("jsonrpc.Notification")
Line 173:
Line 174: def __init__(self, event_id, cb):
Line 175: self._event_id = event_id
https://gerrit.ovirt.org/#/c/38069/19/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line 75: class StompError(RuntimeError):
Line 76: def __init__(self, frame):
Line 77: self.frame = frame
Line 78: super(RuntimeError, self).__init__(
Line 79: self.body,
> shouldn't it be frame.body?
Done
Line 80: )
Line 81:
Line 82:
Line 83: class _HeartBeatFrame(object):
https://gerrit.ovirt.org/#/c/38069/19/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReactor.py:
Line 303
Line 304
Line 305
Line 306
Line 307
> we don't close the connections anymore? please mention in the comment messa
Done
Line 273:
Line 274: def send(
Line 275: self,
Line 276: message,
Line 277: destination=_DEFAULT_RESPONSE_DESTINATION,
> have a comment that explains what is the default_response_destination when
Done
Line 278: ):
Line 279: self.log.debug("Sending response")
Line 280: try:
Line 281: resp = json.loads(message)
https://gerrit.ovirt.org/#/c/38069/19/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 17
Line 18
Line 19
Line 20
Line 21
> not related..
Done
https://gerrit.ovirt.org/#/c/38069/19/vdsm/rpc/BindingJsonRpc.py
File vdsm/rpc/BindingJsonRpc.py:
Line 31:
Line 32: def __init__(self, bridge):
Line 33: self._server = JsonRpcServer(bridge, _simpleThreadFactory)
Line 34: self._reactor = StompReactor()
Line 35: self.startReactor(self._reactor)
> why do you pass it.. its the class parameter :?
Done
Line 36:
Line 37: def add_socket(self, reactor, client_socket):
Line 38: reactor.createListener(client_socket, self._onAccept)
Line 39:
--
To view, visit https://gerrit.ovirt.org/38069
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id27b5ca1773139932eb5cb16921d5abec4991c5e
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: require qemu-*-ev on CentOS >= 7
Dan Kenigsberg has posted comments on this change. Change subject: spec: require qemu-*-ev on CentOS >= 7 .. Patch Set 4: Code-Review+2 build failure is unrelated to this patch, and should be fixed by this backport https://gerrit.ovirt.org/#/c/40881/ -- To view, visit https://gerrit.ovirt.org/40876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbec719863d7b12150574a60d071f38bcfa62398 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netinfoTests: Do not try to read bonding options
Hello Ondřej Svoboda,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40881
to review the following change.
Change subject: netinfoTests: Do not try to read bonding options
..
netinfoTests: Do not try to read bonding options
A user running the tests usually does not have sudo permissions
to create a bond.
Change-Id: Id85764ac54a29a2359bb81ca1ce0819a0eee2758
Signed-off-by: Ondřej Svoboda
Reviewed-on: http://gerrit.ovirt.org/31270
Reviewed-by: Dan Kenigsberg
---
M tests/netinfoTests.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/40881/1
diff --git a/tests/netinfoTests.py b/tests/netinfoTests.py
index 3d2c1af..276fe4f 100644
--- a/tests/netinfoTests.py
+++ b/tests/netinfoTests.py
@@ -115,6 +115,7 @@
@MonkeyPatch(ipwrapper.Link, '_detectType',
partial(_fakeTypeDetection, ipwrapper.Link))
@MonkeyPatch(netinfo, 'networks', lambda: {'fake': {'bridged': True}})
+@MonkeyPatch(netinfo, '_getBondingOptions', lambda x: {})
def testGetNonExistantBridgeInfo(self):
# Getting info of non existing bridge should not raise an exception,
# just log a traceback. If it raises an exception the test will fail as
--
To view, visit https://gerrit.ovirt.org/40881
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id85764ac54a29a2359bb81ca1ce0819a0eee2758
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Dan Kenigsberg
Gerrit-Reviewer: Ondřej Svoboda
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netinfoTests: Do not try to read bonding options
automat...@ovirt.org has posted comments on this change. Change subject: netinfoTests: Do not try to read bonding options .. Patch Set 1: Verified-1 * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/40881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id85764ac54a29a2359bb81ca1ce0819a0eee2758 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: server side subscriptions
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: server side subscriptions
..
Patch Set 18:
(3 comments)
https://gerrit.ovirt.org/#/c/38451/18/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line 462: sub_id = frame.headers.get(Headers.SUBSCRIPTION)
Line 463: if sub_id is None:
Line 464: self.log.warning(
Line 465: "Got message without subscription id '%s'",
Line 466: sub_id
> Why do we need to print None?
Will remove
Line 467: )
Line 468: return
Line 469: sub = self._subscriptions.get(sub_id)
Line 470: if sub is None:
https://gerrit.ovirt.org/#/c/38451/18/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReactor.py:
Line 107: self.queue_frame(resp)
Line 108: self._reactor.wakeup()
Line 109:
Line 110: def _cmd_subscribe(self, dispatcher, frame):
Line 111: self.log.info("Subscribe command received")
> Wouldn't it be helpful to log the command received with the sender details
You have this information when a client is connected.
Line 112: destination = frame.headers.get("destination", None)
Line 113: sub_id = frame.headers.get("id", None)
Line 114:
Line 115: if not destination or not sub_id:
Line 112: destination = frame.headers.get("destination", None)
Line 113: sub_id = frame.headers.get("id", None)
Line 114:
Line 115: if not destination or not sub_id:
Line 116: self._send_error("Missing destination or id header",
> I would add 'subscription request is missing...' at the beginning...
Done
Line 117: dispatcher.connection)
Line 118: return
Line 119:
Line 120: ack = frame.headers.get("ack", stomp.AckMode.AUTO)
--
To view, visit https://gerrit.ovirt.org/38451
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Oved Ourfali
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: updated qemu-* requirements on EL
automat...@ovirt.org has posted comments on this change. Change subject: spec: updated qemu-* requirements on EL .. Patch Set 4: * Update tracker::#1221192::OK * Update tracker::#1220333::OK * Check Bug-Url::OK * Check Public Bug::#1221192::OK, public bug * Check Public Bug::#1220333::OK, public bug * Check Product::#1221192::OK, Correct product Red Hat Enterprise Virtualization Manager * Check Product::#1220333::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1221192::OK, correct target release 3.5.3 * Check TR::#1220333::OK, correct target release 3.5.3 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/40877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbd1fdd425f773776c5ce7596a0f339480a3296c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: require qemu-*-ev on CentOS >= 7
automat...@ovirt.org has posted comments on this change. Change subject: spec: require qemu-*-ev on CentOS >= 7 .. Patch Set 4: * Update tracker::#1221192::OK * Update tracker::#1220333::OK * Check Bug-Url::OK * Check Public Bug::#1221192::OK, public bug * Check Public Bug::#1220333::OK, public bug * Check Product::#1221192::OK, Correct product Red Hat Enterprise Virtualization Manager * Check Product::#1220333::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1221192::OK, correct target release 3.5.3 * Check TR::#1220333::OK, correct target release 3.5.3 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/40876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbec719863d7b12150574a60d071f38bcfa62398 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: events
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: events
..
Patch Set 19: Code-Review-1
(6 comments)
https://gerrit.ovirt.org/#/c/38069/19/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 167:
Line 168: return JsonRpcResponse(result, error, reqId)
Line 169:
Line 170:
Line 171: class Notification(object):
why don't you comment when you introduce new class. I have no idea where do you
plan to use this new class and what its purpose.
if only clientIF uses it why do you need it at all ?
def notify could just compose the json directly with the event id and set the
callback
Line 172: log = logging.getLogger("jsonrpc.Notification")
Line 173:
Line 174: def __init__(self, event_id, cb):
Line 175: self._event_id = event_id
https://gerrit.ovirt.org/#/c/38069/19/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line 75: class StompError(RuntimeError):
Line 76: def __init__(self, frame):
Line 77: self.frame = frame
Line 78: super(RuntimeError, self).__init__(
Line 79: self.body,
shouldn't it be frame.body?
Line 80: )
Line 81:
Line 82:
Line 83: class _HeartBeatFrame(object):
https://gerrit.ovirt.org/#/c/38069/19/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReactor.py:
Line 303
Line 304
Line 305
Line 306
Line 307
we don't close the connections anymore? please mention in the comment message
what and why you remove things
Line 273:
Line 274: def send(
Line 275: self,
Line 276: message,
Line 277: destination=_DEFAULT_RESPONSE_DESTINATION,
have a comment that explains what is the default_response_destination when you
don't specify destination and what "destination" can be.
Line 278: ):
Line 279: self.log.debug("Sending response")
Line 280: try:
Line 281: resp = json.loads(message)
https://gerrit.ovirt.org/#/c/38069/19/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 17
Line 18
Line 19
Line 20
Line 21
not related..
https://gerrit.ovirt.org/#/c/38069/19/vdsm/rpc/BindingJsonRpc.py
File vdsm/rpc/BindingJsonRpc.py:
Line 31:
Line 32: def __init__(self, bridge):
Line 33: self._server = JsonRpcServer(bridge, _simpleThreadFactory)
Line 34: self._reactor = StompReactor()
Line 35: self.startReactor(self._reactor)
why do you pass it.. its the class parameter :?
Line 36:
Line 37: def add_socket(self, reactor, client_socket):
Line 38: reactor.createListener(client_socket, self._onAccept)
Line 39:
--
To view, visit https://gerrit.ovirt.org/38069
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id27b5ca1773139932eb5cb16921d5abec4991c5e
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: client side subscription
Piotr Kliczewski has posted comments on this change. Change subject: stomp: client side subscription .. Patch Set 19: (1 comment) https://gerrit.ovirt.org/#/c/36368/19/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 484: None > I think 'if headers' might be enough... why? -- To view, visit https://gerrit.ovirt.org/36368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronheim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: password: Prevent password logging and persisting
Francesco Romani has posted comments on this change.
Change subject: password: Prevent password logging and persisting
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/40707/4/tests/passwordsTests.py
File tests/passwordsTests.py:
Line 29: class ProtectedPasswordTests(VdsmTestCase):
Line 30:
Line 31: def test_str(self):
Line 32: p = ProtectedPassword("12345678")
Line 33: self.assertFalse("12345678" in str(p))
> I will change it in the next version.
Posted the patch mentioned above: https://gerrit.ovirt.org/#/c/40879/
Line 34:
Line 35: def test_repr(self):
Line 36: p = ProtectedPassword("12345678")
Line 37: self.assertFalse("12345678" in repr(p))
--
To view, visit https://gerrit.ovirt.org/40707
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc849ad8bdc1b1fd09884e18038427d96e66110f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: lib: drop forward port from python 2.7
Francesco Romani has posted comments on this change. Change subject: tests: lib: drop forward port from python 2.7 .. Patch Set 1: Verified+1 verified running 'make check' on F21 - Python 2.7.8 -- To view, visit https://gerrit.ovirt.org/40879 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id943e5db3f972ccf89291f3d7c112db7907eba1d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: lib: drop forward port from python 2.7
Francesco Romani has uploaded a new change for review.
Change subject: tests: lib: drop forward port from python 2.7
..
tests: lib: drop forward port from python 2.7
Since we now depend on (distributions which ship) python 2.7,
we can drop the forward ports we added back in time, and make
use of all the new utilities found in modern unittest module.
Change-Id: Id943e5db3f972ccf89291f3d7c112db7907eba1d
Signed-off-by: Francesco Romani
---
M tests/testlib.py
1 file changed, 0 insertions(+), 65 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/40879/1
diff --git a/tests/testlib.py b/tests/testlib.py
index 35c870a..c272c36 100644
--- a/tests/testlib.py
+++ b/tests/testlib.py
@@ -180,71 +180,6 @@
with context:
callableObj(*args, **kwargs)
-# FIXME: This is a forward port of the assertIn from python
-#2.7, remove when no loger supporting earlier versions
-def assertIn(self, member, container, msg=None):
-"""
-Just like self.assertTrue(a in b), but with a nicer default message.
-"""
-if member not in container:
-if msg is None:
-msg = '%s not found in %s' % (safe_repr(member),
- safe_repr(container))
-raise self.failureException(msg)
-
-# FIXME: This is a forward port of the assertNotIn from python
-#2.7, remove when no loger supporting earlier versions
-def assertNotIn(self, member, container, msg=None):
-"""
-Just like self.assertTrue(a not in b), but with a nicer default message
-"""
-if member in container:
-if msg is None:
-msg = '%s unexpectedly found in %s' % (safe_repr(member),
- safe_repr(container))
-raise self.failureException(msg)
-
-# FIXME: This is a forward port of the assertAlmostEqual from python
-#2.7, remove when no longer supporting earlier versions
-# we need the 'delta' keyword argument, which was added in python 2.7
-def assertAlmostEqual(self, first, second, places=None,
- msg=None, delta=None):
-"""Fail if the two objects are unequal as determined by their
- difference rounded to the given number of decimal places
- (default 7) and comparing to zero, or by comparing that the
- between the two objects is more than the given delta.
-
- Note that decimal places (from zero) are usually not the same
- as significant digits (measured from the most signficant digit).
-
- If the two objects compare equal then they will automatically
- compare almost equal.
-"""
-if first == second:
-# shortcut
-return
-if delta is not None and places is not None:
-raise TypeError("specify delta or places not both")
-
-if delta is not None:
-if abs(first - second) <= delta:
-return
-
-standardMsg = '%s != %s within %s delta' % (safe_repr(first),
-safe_repr(second),
-safe_repr(delta))
-else:
-if places is None:
-places = 7
-
-if round(abs(second-first), places) == 0:
-return
-
-standardMsg = '%s != %s within %r places' % (
-safe_repr(first), safe_repr(second), places)
-msg = self._formatMessage(msg, standardMsg)
-raise self.failureException(msg)
-
@contextmanager
def assertElapsed(self, expected, tolerance=0.5):
start = vdsm.utils.monotonic_time()
--
To view, visit https://gerrit.ovirt.org/40879
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id943e5db3f972ccf89291f3d7c112db7907eba1d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: lib: drop forward port from python 2.7
automat...@ovirt.org has posted comments on this change. Change subject: tests: lib: drop forward port from python 2.7 .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40879 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id943e5db3f972ccf89291f3d7c112db7907eba1d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert "network: allow custom bondOption"
automat...@ovirt.org has posted comments on this change. Change subject: Revert "network: allow custom bondOption" .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40868 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idde421af396995b123bea866baf02212f2d3be47 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert "network: allow custom bondOption"
Dan Kenigsberg has submitted this change and it was merged. Change subject: Revert "network: allow custom bondOption" .. Revert "network: allow custom bondOption" This patch was based on misunderstanding of bond's 'areOptionsApplied'. Because of that, custom options were passed to configurator. This will be fixed in following patch. Change-Id: Idde421af396995b123bea866baf02212f2d3be47 Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/40868 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg Tested-by: Dan Kenigsberg --- M lib/vdsm/netinfo.py M vdsm/network/models.py 2 files changed, 5 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40868 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idde421af396995b123bea866baf02212f2d3be47 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: require qemu-*-ev on CentOS >= 7
Yaniv Bronhaim has posted comments on this change. Change subject: spec: require qemu-*-ev on CentOS >= 7 .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbec719863d7b12150574a60d071f38bcfa62398 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: updated qemu-* requirements on EL
Yaniv Bronhaim has posted comments on this change. Change subject: spec: updated qemu-* requirements on EL .. Patch Set 3: Code-Review+2 same as master. -- To view, visit https://gerrit.ovirt.org/40877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbd1fdd425f773776c5ce7596a0f339480a3296c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Add vdsClient secrets verbs
automat...@ovirt.org has posted comments on this change. Change subject: ceph: Add vdsClient secrets verbs .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40735 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29a2a6a7ccb036d0055a0935cbe6f3efb43a6546 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Support ephemeral Libvirt secrets
automat...@ovirt.org has posted comments on this change. Change subject: ceph: Support ephemeral Libvirt secrets .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e9ee33a7447ee07b0c82cf5a80d1f9b470663bb Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Add option to clear other secrets
automat...@ovirt.org has posted comments on this change. Change subject: ceph: Add option to clear other secrets .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I476e5aa0bd4a48d1837de09c59597f180fa38823 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: password: Prevent password logging and persisting
Nir Soffer has posted comments on this change.
Change subject: password: Prevent password logging and persisting
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/40707/4/tests/passwordsTests.py
File tests/passwordsTests.py:
Line 29: class ProtectedPasswordTests(VdsmTestCase):
Line 30:
Line 31: def test_str(self):
Line 32: p = ProtectedPassword("12345678")
Line 33: self.assertFalse("12345678" in str(p))
> Thought the same. Will post a patch for that.
I will change it in the next version.
Line 34:
Line 35: def test_repr(self):
Line 36: p = ProtectedPassword("12345678")
Line 37: self.assertFalse("12345678" in repr(p))
--
To view, visit https://gerrit.ovirt.org/40707
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc849ad8bdc1b1fd09884e18038427d96e66110f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: Handle missing system_time and user_time
Nir Soffer has posted comments on this change. Change subject: vmstats: Handle missing system_time and user_time .. Patch Set 1: Thanks Francesco, I will fix it as you suggest. -- To view, visit https://gerrit.ovirt.org/40845 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id26c427d67de47cbcc39ddd43ab4cfe8467432c4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: updated qemu-* requirements on EL
automat...@ovirt.org has posted comments on this change. Change subject: spec: updated qemu-* requirements on EL .. Patch Set 3: * Update tracker::#1221192::OK * Update tracker::#1220333::OK * Check Bug-Url::OK * Check Public Bug::#1221192::OK, public bug * Check Public Bug::#1220333::OK, public bug * Check Product::#1221192::OK, Correct product Red Hat Enterprise Virtualization Manager * Check Product::#1220333::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1221192::OK, correct target release 3.5.3 * Check TR::#1220333::OK, correct target release 3.5.3 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/40877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbd1fdd425f773776c5ce7596a0f339480a3296c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: require qemu-*-ev on CentOS >= 7
automat...@ovirt.org has posted comments on this change. Change subject: spec: require qemu-*-ev on CentOS >= 7 .. Patch Set 3: -Verified * Update tracker::#1221192::OK * Update tracker::#1220333::OK * Check Bug-Url::OK * Check Public Bug::#1221192::OK, public bug * Check Public Bug::#1220333::OK, public bug * Check Product::#1221192::OK, Correct product Red Hat Enterprise Virtualization Manager * Check Product::#1220333::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1221192::OK, correct target release 3.5.3 * Check TR::#1220333::OK, correct target release 3.5.3 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/40876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbec719863d7b12150574a60d071f38bcfa62398 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: updated qemu-* requirements on EL
automat...@ovirt.org has posted comments on this change. Change subject: spec: updated qemu-* requirements on EL .. Patch Set 2: Verified-1 * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/40877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbd1fdd425f773776c5ce7596a0f339480a3296c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: require qemu-*-ev on CentOS >= 7
automat...@ovirt.org has posted comments on this change. Change subject: spec: require qemu-*-ev on CentOS >= 7 .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/40876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbec719863d7b12150574a60d071f38bcfa62398 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: updated qemu-* requirements on EL
automat...@ovirt.org has posted comments on this change. Change subject: spec: updated qemu-* requirements on EL .. Patch Set 1: * Update tracker::#1199014::OK * Update tracker::#1209034::OK * Check Bug-Url::OK * Check Public Bug::#1199014::OK, public bug * Check Public Bug::#1209034::OK, public bug * Check Product::#1199014::OK, Correct product Red Hat Enterprise Virtualization Manager * Check Product::#1209034::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1199014::ERROR, wrong target release for stable branch, 3.6.0 should match ^3.[54321].* * Check TR::#1209034::OK, correct target release 3.5.4 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/40877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbd1fdd425f773776c5ce7596a0f339480a3296c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: updated qemu-* requirements on EL
Hello Fred Rolland, Dan Kenigsberg, Allon Mureinik,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40877
to review the following change.
Change subject: spec: updated qemu-* requirements on EL
..
spec: updated qemu-* requirements on EL
Updated the build version for qemu-kvm-ev,qemu-kvm-rev,qemu-img-ev and
qemu-img-rhev for a EL build on EL >= 7.
The required qemu-img version solves a crash when using qemu-img convert
-t none on some block storage devices (see
https://bugzilla.redhat.com/show_bug.cgi?id=1203543 for details).
Change-Id: Ifbd1fdd425f773776c5ce7596a0f339480a3296c
Signed-off-by: Idan Shaby
Signed-off-by: Fred Rolland
Bug-Url: https://bugzilla.redhat.com/1199014
Bug-Url: https://bugzilla.redhat.com/1209034
Reviewed-on: https://gerrit.ovirt.org/40671
Reviewed-by: Allon Mureinik
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/40877/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index dafa85d..0c02f95 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -272,8 +272,8 @@
%if 0%{?rhel}
%if 0%{?rhel} >= 7
-Requires: qemu-kvm%{?qemu_suffix} >= 10:1.5.3-60.el7
-Requires: qemu-img%{?qemu_suffix} >= 10:1.5.3-60.el7
+Requires: qemu-kvm%{?qemu_suffix} >= 10:2.1.2-23.el7_1.2
+Requires: qemu-img%{?qemu_suffix} >= 10:2.1.2-23.el7_1.2
%else
Requires: qemu-kvm%{?qemu_suffix} >= 2:0.12.1.2-2.422
Requires: qemu-img%{?qemu_suffix} >= 2:0.12.1.2-2.422
--
To view, visit https://gerrit.ovirt.org/40877
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifbd1fdd425f773776c5ce7596a0f339480a3296c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Freddy Rolland
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Fred Rolland
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: require qemu-*-ev on CentOS >= 7
Hello Fred Rolland, Allon Mureinik, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40876
to review the following change.
Change subject: spec: require qemu-*-ev on CentOS >= 7
..
spec: require qemu-*-ev on CentOS >= 7
Added a requirement for qemu-kvm-ev and qemu-img-ev on CentOS >= 7.
qemu-*-ev rpms are upstream version for qemu-*-rhev.
These supply features needed that are not available in the regular
qemu-*, for example 'Live Snapshot'.
Change-Id: Ibbec719863d7b12150574a60d071f38bcfa62398
Signed-off-by: Idan Shaby
Signed-off-by: Fred Rolland
Reviewed-on: https://gerrit.ovirt.org/40670
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg
Reviewed-by: Allon Mureinik
---
M vdsm.spec.in
1 file changed, 11 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/76/40876/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 63a711a..dafa85d 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -263,17 +263,21 @@
%endif
%if !%{fedora_koji_build}
-%global rhev_suffix -rhev
-%endif
+%if 0%{?rhev_build}
+%global qemu_suffix -rhev
+%else
+%global qemu_suffix -ev
+%endif # rhev_build
+%endif # !%{fedora_koji_build}
%if 0%{?rhel}
%if 0%{?rhel} >= 7
-Requires: qemu-kvm%{?rhev_suffix}
-Requires: qemu-img%{?rhev_suffix}
+Requires: qemu-kvm%{?qemu_suffix} >= 10:1.5.3-60.el7
+Requires: qemu-img%{?qemu_suffix} >= 10:1.5.3-60.el7
%else
-Requires: qemu-kvm%{?rhev_suffix} >= 2:0.12.1.2-2.415.el6_5.3
-Requires: qemu-img%{?rhev_suffix} >= 2:0.12.1.2-2.415.el6_5.3
-%endif
+Requires: qemu-kvm%{?qemu_suffix} >= 2:0.12.1.2-2.422
+Requires: qemu-img%{?qemu_suffix} >= 2:0.12.1.2-2.422
+%endif # rhel > = 7
%else
Requires: qemu-kvm >= 2:0.15.0-4
Requires: qemu-img >= 2:0.15.0-4
--
To view, visit https://gerrit.ovirt.org/40876
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibbec719863d7b12150574a60d071f38bcfa62398
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Freddy Rolland
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Fred Rolland
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: require qemu-*-ev on CentOS >= 7
automat...@ovirt.org has posted comments on this change. Change subject: spec: require qemu-*-ev on CentOS >= 7 .. Patch Set 1: Verified-1 * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/40876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbec719863d7b12150574a60d071f38bcfa62398 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: password: Prevent password logging and persisting
Francesco Romani has posted comments on this change.
Change subject: password: Prevent password logging and persisting
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/40707/4/tests/passwordsTests.py
File tests/passwordsTests.py:
Line 29: class ProtectedPasswordTests(VdsmTestCase):
Line 30:
Line 31: def test_str(self):
Line 32: p = ProtectedPassword("12345678")
Line 33: self.assertFalse("12345678" in str(p))
> Which reminds me - we can and should drop them from testlib, as python2.6 i
Thought the same. Will post a patch for that.
Line 34:
Line 35: def test_repr(self):
Line 36: p = ProtectedPassword("12345678")
Line 37: self.assertFalse("12345678" in repr(p))
--
To view, visit https://gerrit.ovirt.org/40707
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc849ad8bdc1b1fd09884e18038427d96e66110f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Update qemu requirement in EL7
automat...@ovirt.org has posted comments on this change. Change subject: spec: Update qemu requirement in EL7 .. Patch Set 1: * Update tracker::#1199014::OK -- To view, visit https://gerrit.ovirt.org/38408 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea5a0fea7631fc9128eac49ea2cdda24a42de352 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Update qemu requirement in EL7
Allon Mureinik has abandoned this change. Change subject: spec: Update qemu requirement in EL7 .. Abandoned Already covered by Ifbd1fdd425f773776c5ce7596a0f339480a3296c -- To view, visit https://gerrit.ovirt.org/38408 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Iea5a0fea7631fc9128eac49ea2cdda24a42de352 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: password: Prevent password logging and persisting
Dan Kenigsberg has posted comments on this change.
Change subject: password: Prevent password logging and persisting
..
Patch Set 4: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/40707/4/tests/passwordsTests.py
File tests/passwordsTests.py:
Line 29: class ProtectedPasswordTests(VdsmTestCase):
Line 30:
Line 31: def test_str(self):
Line 32: p = ProtectedPassword("12345678")
Line 33: self.assertFalse("12345678" in str(p))
> minor: we have assertNotIn, also backported in testlib.
Which reminds me - we can and should drop them from testlib, as python2.6 is no
longer supported with the demise of el6.
Line 34:
Line 35: def test_repr(self):
Line 36: p = ProtectedPassword("12345678")
Line 37: self.assertFalse("12345678" in repr(p))
--
To view, visit https://gerrit.ovirt.org/40707
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc849ad8bdc1b1fd09884e18038427d96e66110f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
