Change in vdsm[master]: RFE: Report downtime for each live migration
Francesco Romani has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 9:
(2 comments)
looks OK, but commit message needs to be updated.
https://gerrit.ovirt.org/#/c/40103/9//COMMIT_MSG
Commit Message:
Line 9: vm.py getStat() is called when migration is done and from Engine
Line 10: initiative.
Line 11:
Line 12: There is no need to call libvirts domain getStats twice, only when
Line 13: Engine initiate the call.
can you elaborate about how this reflects in the changes you made into
migration.py?
Line 14:
Line 15: Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d
Line 16: Bug-Url: https://bugzilla.redhat.com/970711
https://gerrit.ovirt.org/#/c/40103/9/vdsm/API.py
File vdsm/API.py:
Line 352: try:
Line 353: v = self._cif.vmContainer[self._UUID]
Line 354: except KeyError:
Line 355: return errCode['noVM']
Line 356: return {'status': doneCode, 'migrationStats':
v.migrateStatus()}
this - and the Bridge.py counterpart - looks like a separate change squashed
inside this one. If it is not, please add a few lines in the commit message
explaining the interdependencies.
Line 357:
Line 358: def getStats(self):
Line 359: """
Line 360: Obtain statistics of the specified VM
--
To view, visit https://gerrit.ovirt.org/40103
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: make _getCpuCoresStats a function
Ido Barkan has posted comments on this change. Change subject: sampling: make _getCpuCoresStats a function .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40429 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If602a84096db7aa7d1a6672b84d62287e08b0ac2 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: make _getInterfaceStats a function
Ido Barkan has posted comments on this change. Change subject: sampling: make _getInterfaceStats a function .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40430 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b5796f3463585794d2696ce73f8357cb0fd1f78 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network/models: check unified persistence only when it exists
Ido Barkan has posted comments on this change. Change subject: network/models: check unified persistence only when it exists .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41366 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I964ebd7594f1d1a8209ba0c62b9c4bee342309b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vdsm-tool: is-configured: on el6, we must disable sysv's lib...
Yaniv Bronhaim has submitted this change and it was merged. Change subject: vdsm-tool: is-configured: on el6, we must disable sysv's libvirtd job .. vdsm-tool: is-configured: on el6, we must disable sysv's libvirtd job In the old libvirt_configure.sh.in script we used to run chkconfig libvirtd off. It has been missing from the new configurators/libvirt.py implementation. This patch adds that part which introduced a regression after first host restarts. On upgrade, we check is-configured for libvirt module - if sysv still handles the service it will report NOT_CONFIGURED and reconfigure it to use upstart instead of sysv. Label: ovirt-3.5-only - initctl hack is relevant only to el6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1222154 Change-Id: I6326a34cc9e4bee82a427f2543354438205cd11d Signed-off-by: Yaniv Bronhaim Signed-off-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/41144 Reviewed-by: Dima Kuznetsov Continuous-Integration: Jenkins CI --- M lib/vdsm/tool/configurators/libvirt.py M lib/vdsm/tool/service.py M tests/toolTests.py 3 files changed, 25 insertions(+), 1 deletion(-) Approvals: Yaniv Bronhaim: Verified Jenkins CI: Passed CI tests Dima Kuznetsov: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6326a34cc9e4bee82a427f2543354438205cd11d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Mooli Tayer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vdsm-tool: is-configured: on el6, we must disable sysv's lib...
automat...@ovirt.org has posted comments on this change. Change subject: vdsm-tool: is-configured: on el6, we must disable sysv's libvirtd job .. Patch Set 10: * Update tracker::#1222154::OK * Set MODIFIED::bug 1222154#1222154IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager -- To view, visit https://gerrit.ovirt.org/41144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6326a34cc9e4bee82a427f2543354438205cd11d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Mooli Tayer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Hooks for Memory Hotplug
Dan Kenigsberg has posted comments on this change.
Change subject: Hooks for Memory Hotplug
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/40548/2/vdsm/hooks.py
File vdsm/hooks.py:
Line 322: return _runHooksDir(None, 'after_set_num_of_cpus', vmconf=vmconf,
Line 323: params=params, raiseError=False)
Line 324:
Line 325:
Line 326: def before_memory_hotplug(domxml, vmconf={}, params={}):
I don't understand this patch. You seem to be adding a hook point, but you
don't place it anywhere. Does it makes sense to pass domxml to this hook? The
signature of before_set_num_of_cpus() seems more fitting.
Line 327: return _runHooksDir(domxml, 'before_memory_hotplug',
vmconf=vmconf,
Line 328: params=params)
Line 329:
Line 330:
--
To view, visit https://gerrit.ovirt.org/40548
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I152e2dd0dfacadb703889fa8e909cf060731eb4f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vitor de Lima
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Hide errors when testing noisy code
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Hide errors when testing noisy code
..
tests: Hide errors when testing noisy code
configurator.remove_config try to remove all configurations even if some
configurators fail, so it writes errors to stderr and continue. This
behavior makes sense, but breaks tests progress display:
test_remove_config can't remove
configuration of module a
Traceback (most recent call last):
File "/home/nsoffer/src/vdsm/lib/vdsm/tool/configurator.py", line 236, in
remove_config
_removeConf(c)
File "/home/nsoffer/src/vdsm/lib/vdsm/tool/configurator.py", line 120, in
_removeConf
getattr(module, 'removeConf', lambda: None)()
File "/home/nsoffer/src/vdsm/tests/toolTests.py", line 75, in removeConf
raise Exception('mock invalid remove conf')
Exception: mock invalid remove conf
OK
Now we redirect stderr to stdout during this test, so the output is more
pleasing:
test_remove_config OK
Change-Id: I4d1bb16e0aabc9f4e2bb0ca88bc7ce4cd189e24d
Signed-off-by: Nir Soffer
Reviewed-on: https://gerrit.ovirt.org/41365
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim
Reviewed-by: mooli tayer
Reviewed-by: Dan Kenigsberg
---
M tests/toolTests.py
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Nir Soffer: Verified
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
mooli tayer: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41365
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d1bb16e0aabc9f4e2bb0ca88bc7ce4cd189e24d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Hide errors when testing noisy code
automat...@ovirt.org has posted comments on this change. Change subject: tests: Hide errors when testing noisy code .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/41365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d1bb16e0aabc9f4e2bb0ca88bc7ce4cd189e24d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Hide errors when testing noisy code
Dan Kenigsberg has posted comments on this change. Change subject: tests: Hide errors when testing noisy code .. Patch Set 1: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/41365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d1bb16e0aabc9f4e2bb0ca88bc7ce4cd189e24d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:fix NoneType error for some devices does not contain...
Dan Kenigsberg has posted comments on this change. Change subject: gluster:fix NoneType error for some devices does not contain sysfsPath .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41262 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54efdf3958519e2ae038b527a03e0b57569c2e8f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:fix NoneType error for some devices does not contain...
automat...@ovirt.org has posted comments on this change. Change subject: gluster:fix NoneType error for some devices does not contain sysfsPath .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/41262 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54efdf3958519e2ae038b527a03e0b57569c2e8f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:fix NoneType error for some devices does not contain...
Dan Kenigsberg has submitted this change and it was merged. Change subject: gluster:fix NoneType error for some devices does not contain sysfsPath .. gluster:fix NoneType error for some devices does not contain sysfsPath Currently devices list returns the list of available disks and its fs type properly. However it fails for some devices which does not contain sysfsPath and the dev details become None. This patch fixes this error by assigning empty dictonary if the dev is empty or None. Change-Id: I54efdf3958519e2ae038b527a03e0b57569c2e8f Signed-off-by: Timothy Asir Jeyasingh Reviewed-on: https://gerrit.ovirt.org/41262 Reviewed-by: Piotr Kliczewski Reviewed-by: Ramesh N Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M vdsm/gluster/storagedev.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Timothy Asir: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Ramesh N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41262 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54efdf3958519e2ae038b527a03e0b57569c2e8f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
automat...@ovirt.org has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
Dan Kenigsberg has submitted this change and it was merged. Change subject: sampling: hoststats: rationalize getInterfaceStats .. sampling: hoststats: rationalize getInterfaceStats The main job of the HostStatsThread._getInterfaceStats() method is to gather network stats. But this method also initializes the empty `stats' return dict with the default values. The initialization doesn't belong here, rather on the calling, orchestrating function, so this patch moves the initialization code outside. Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Signed-off-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/40426 Reviewed-by: Dan Kenigsberg Continuous-Integration: Jenkins CI --- M vdsm/virt/sampling.py 1 file changed, 19 insertions(+), 16 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: fix redefinition pyflakes error
automat...@ovirt.org has posted comments on this change. Change subject: tests: fix redefinition pyflakes error .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/41402 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I244dfbc031a4c10f1938d3f5a07daed757011d16 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: fix redefinition pyflakes error
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: fix redefinition pyflakes error .. tests: fix redefinition pyflakes error The build fails with the following error in pyflakes version "0.7.3-4" installed. ./tests/functional/networkTests.py:93: redefinition of unused 'vdsm' from line 28 ./tests/functional/networkTests.py:101: redefinition of unused 'vdsm' from line 28 make[1]: *** [pyflakes] Error 1 Change-Id: I244dfbc031a4c10f1938d3f5a07daed757011d16 Signed-off-by: Timothy Asir Jeyasingh Reviewed-on: https://gerrit.ovirt.org/41402 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer Reviewed-by: Piotr Kliczewski Reviewed-by: Dan Kenigsberg --- M tests/functional/networkTests.py 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Nir Soffer: Looks good to me, but someone else must approve Timothy Asir: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41402 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I244dfbc031a4c10f1938d3f5a07daed757011d16 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: fix redefinition pyflakes error
Dan Kenigsberg has posted comments on this change. Change subject: tests: fix redefinition pyflakes error .. Patch Set 2: Code-Review+2 Taken, but please use a newer pyflakes as suggested in http://www.ovirt.org/Vdsm_Developers -- To view, visit https://gerrit.ovirt.org/41402 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I244dfbc031a4c10f1938d3f5a07daed757011d16 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Detect RNG device by type
automat...@ovirt.org has posted comments on this change. Change subject: vm: Detect RNG device by type .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31a1c38eec5be96e298e0f1dd5a7598c2212cb21 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Shmuel Leib Melamud Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Detect RNG device by type
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: Detect RNG device by type .. vm: Detect RNG device by type In Vm._getUnderlyingRngDeviceInfo() method the RNG device must be detected in self.conf['devices'] list by 'type' attribute, not 'device'. See VmInfoBuilder.buildVmRngDevice() in the Engine for reference. Change-Id: I31a1c38eec5be96e298e0f1dd5a7598c2212cb21 Signed-off-by: Shmuel Melamud Reviewed-on: https://gerrit.ovirt.org/40095 Reviewed-by: Martin Polednik Reviewed-by: Michal Skrivanek Reviewed-by: Francesco Romani Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M vdsm/virt/vm.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve Michal Skrivanek: Looks good to me, but someone else must approve Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31a1c38eec5be96e298e0f1dd5a7598c2212cb21 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Shmuel Leib Melamud Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Detect RNG device by type
Dan Kenigsberg has posted comments on this change. Change subject: vm: Detect RNG device by type .. Patch Set 2: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/40095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31a1c38eec5be96e298e0f1dd5a7598c2212cb21 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Shmuel Leib Melamud Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Support SPICE seamless migration over NAT
Dan Kenigsberg has posted comments on this change.
Change subject: migration: Support SPICE seamless migration over NAT
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/41223/1/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 347: # TODO: use libvirt constants when bz#1222795 is fixed
Line 348: params = {VIR_MIGRATE_PARAM_URI: str(muri),
Line 349: VIR_MIGRATE_PARAM_BANDWIDTH: maxBandwidth}
Line 350: if self._consoleAddress:
Line 351: params[VIR_MIGRATE_PARAM_GRAPHICS_URI] = \
> what's wrong with the name? Seems ok to me
The question is whether Engine supplies and address or a more complex URI as
explained in the libvirt docs
http://libvirt.org/html/libvirt-libvirt-domain.html#VIR_MIGRATE_PARAM_GRAPHICS_URI
if it's only the address, someone needs to guess the port, tlsPort, and build
the URI.
Line 352: str(self._consoleAddress)
Line 353:
Line 354: flags = (libvirt.VIR_MIGRATE_LIVE |
Line 355: libvirt.VIR_MIGRATE_PEER2PEER |
--
To view, visit https://gerrit.ovirt.org/41223
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7b2b765c62aaf1cc694990205b518558e808516
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Tomas Jelinek
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Start using migrate3 instead of migrate2
Dan Kenigsberg has submitted this change and it was merged. Change subject: migration: Start using migrate3 instead of migrate2 .. migration: Start using migrate3 instead of migrate2 We would like to enable using the new libvirt migration parameters, this is the first step necessary. As new parameters can only be used with migrate3. Change-Id: I57a1d9aeb796998c5100e0c2ec3fb05e775022ed Signed-off-by: Yeela Kaplan Reviewed-on: https://gerrit.ovirt.org/41101 Reviewed-by: Francesco Romani Reviewed-by: Michal Skrivanek Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M vdsm/virt/migration.py 1 file changed, 22 insertions(+), 15 deletions(-) Approvals: Yeela Kaplan: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57a1d9aeb796998c5100e0c2ec3fb05e775022ed Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Start using migrate3 instead of migrate2
automat...@ovirt.org has posted comments on this change. Change subject: migration: Start using migrate3 instead of migrate2 .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/41101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57a1d9aeb796998c5100e0c2ec3fb05e775022ed Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Start using migrate3 instead of migrate2
Dan Kenigsberg has posted comments on this change. Change subject: migration: Start using migrate3 instead of migrate2 .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57a1d9aeb796998c5100e0c2ec3fb05e775022ed Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Start using migrate3 instead of migrate2
automat...@ovirt.org has posted comments on this change. Change subject: migration: Start using migrate3 instead of migrate2 .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57a1d9aeb796998c5100e0c2ec3fb05e775022ed Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netinfo: handle never-expiring leases
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: handle never-expiring leases .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic13657a559b7bd5cc32cd830e831acc39550bca3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: fix redefinition pyflakes error
Piotr Kliczewski has posted comments on this change. Change subject: tests: fix redefinition pyflakes error .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41402 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I244dfbc031a4c10f1938d3f5a07daed757011d16 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Configure libvirt to generate VM's core dumps
Douglas Schilling Landgraf has posted comments on this change. Change subject: Configure libvirt to generate VM's core dumps .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41072 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I068e1c6386a9076d3e713bc63e7895a5ac458d62 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim Gerrit-Reviewer: Amador Pahim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Configure libvirt to generate VM's core dumps
Amador Pahim has posted comments on this change. Change subject: Configure libvirt to generate VM's core dumps .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/41072 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I068e1c6386a9076d3e713bc63e7895a5ac458d62 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim Gerrit-Reviewer: Amador Pahim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Configure libvirt to generate VM's core dumps
automat...@ovirt.org has posted comments on this change. Change subject: Configure libvirt to generate VM's core dumps .. Patch Set 4: * Update tracker::#1220993::OK * Check Bug-Url::OK * Check Public Bug::#1220993::OK, public bug * Check Product::#1220993::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41072 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I068e1c6386a9076d3e713bc63e7895a5ac458d62 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim Gerrit-Reviewer: Amador Pahim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Support GUID list param in GetDeviceList
Freddy Rolland has posted comments on this change.
Change subject: hsm: Support GUID list param in GetDeviceList
..
Patch Set 5:
(9 comments)
https://gerrit.ovirt.org/#/c/40661/5/client/vdsClient.py
File client/vdsClient.py:
Line 720
Line 721
Line 722
Line 723
Line 724
> Can you send a cleanup patch on top of this series, renaming "devices" to "
I will
https://gerrit.ovirt.org/#/c/40661/5/vdsm/API.py
File vdsm/API.py:
Line 1611:
Line 1612: def getLVMVolumeGroups(self, storageType=None):
Line 1613: return self._irs.getVGList(storageType)
Line 1614:
Line 1615: def getDeviceList(self, storageType=None, guids=None):
> Please use guids=() everywhere, so we can assume that guides is *always* a
Done
Line 1616: return self._irs.getDeviceList(storageType, guids)
Line 1617:
Line 1618: def getDevicesVisibility(self, guidList):
Line 1619: return self._irs.getDevicesVisibility(guidList)
https://gerrit.ovirt.org/#/c/40661/5/vdsm/rpc/BindingXMLRPC.py
File vdsm/rpc/BindingXMLRPC.py:
Line 963: def vgsGetList(self, storageType=None, options=None):
Line 964: api = API.Global()
Line 965: return api.getLVMVolumeGroups(storageType)
Line 966:
Line 967: def devicesGetList(self, storageType=None, guids=None,
options=None):
> guids=()
Done
Line 968: api = API.Global()
Line 969: return api.getDeviceList(storageType, guids)
Line 970:
Line 971: def devicesGetVisibility(self, guids, options=None):
https://gerrit.ovirt.org/#/c/40661/5/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 2013
Line 2014
Line 2015
Line 2016
Line 2017
> guids=()
Done
Line 2040
Line 2041
Line 2042
Line 2043
Line 2044
> guides=guids
I don't understand the comment.
Line 1997: con['password'] = "**"
Line 1998: return logableDevs
Line 1999:
Line 2000: @public(logger=logged(resPrinter=partial(_logResp_getDeviceList,
None)))
Line 2001: def getDeviceList(self, storageType=None, guids=None,
options={}):
> guids=()
Done
Line 2002: """
Line 2003: List all Block Devices.
Line 2004:
Line 2005: :param storageType: Filter by storage type.
Line 2012: type specified.
Line 2013: :rtype: dict
Line 2014: """
Line 2015: vars.task.setDefaultException(se.BlockDeviceActionError())
Line 2016: devices = self._getDeviceList(storageType, guids)
> Both of these are optional parameters, so they do *not* have a position, an
Done
Line 2017: return dict(devList=devices)
Line 2018:
Line 2019: def _getDeviceList(self, storageType=None, guids=None):
Line 2020: sdCache.refreshStorage()
https://gerrit.ovirt.org/#/c/40661/5/vdsm/storage/multipath.py
File vdsm/storage/multipath.py:
Line 200
Line 201
Line 202
Line 203
Line 204
> filterGuids=()
Done
Line 201: return HBTL(*hbtl[0].split(":"))
Line 202:
Line 203:
Line 204: def pathListIter(filterGuids=None):
Line 205: filterLen = len(filterGuids) if filterGuids else -1
> We don't need this check If we use a default value of (), and make sure tha
Actually it is needed , otherwise the loop will break right at the beginning in
case the guids are empty: devsFound = filterLen = 0
Line 206: devsFound = 0
Line 207:
Line 208: knownSessions = {}
Line 209:
--
To view, visit https://gerrit.ovirt.org/40661
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic173d94a132e617ae97353d38520a86bede657d7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland
Gerrit-Reviewer: Fred Rolland
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Resize devices on Storage Pool Connect
automat...@ovirt.org has posted comments on this change. Change subject: storage: Resize devices on Storage Pool Connect .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia574a59047d2fb5dd3ac7360c2c3a9dde05237ef Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Support GUID list param in GetDeviceList
automat...@ovirt.org has posted comments on this change. Change subject: hsm: Support GUID list param in GetDeviceList .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic173d94a132e617ae97353d38520a86bede657d7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: fix redefinition pyflakes error
Nir Soffer has posted comments on this change. Change subject: tests: fix redefinition pyflakes error .. Patch Set 2: Code-Review+1 I think this is pyflakes bug, the name "vdsm" is not defined in line 28, but this change is ok anyway. -- To view, visit https://gerrit.ovirt.org/41402 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I244dfbc031a4c10f1938d3f5a07daed757011d16 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: do not catch unlikely ZeroDivisionError
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: do not catch unlikely ZeroDivisionError .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40916 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c6719414d185a8b359b5d8a9f4a28ac87b64327 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: TypeError is unlikely with modern libvirt
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: TypeError is unlikely with modern libvirt .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I937d7cf0107ea2285f937c3af0f44e5843fad224 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: more detailed stale sampling reporting
automat...@ovirt.org has posted comments on this change. Change subject: sampling: more detailed stale sampling reporting .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40390 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00cb8f602fc3f26d62dd34bafe05b8169e184b91 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: avoid spam logs if sampling hollow VMs
automat...@ovirt.org has posted comments on this change. Change subject: virt: avoid spam logs if sampling hollow VMs .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41406 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If130a4b31016e971ac9972b67ba5d3fd70de5b7d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: avoid spam logs if sampling hollow VMs
Francesco Romani has uploaded a new change for review.
Change subject: virt: avoid spam logs if sampling hollow VMs
..
virt: avoid spam logs if sampling hollow VMs
If the recover of a VM fails, the VM may end up being detected
as existing by VDSM, while it is actually down.
This is of course bad, and it is not something that periodic operations
or sampling can fix.
However, they can help in making not things worse by spamming the
logs with
File "/usr/lib64/python2.7/site-packages/libvirt.py", line 938, in
controlInfo
if ret is None: raise libvirtError ('virDomainGetControlInfo()
failed', dom=self)
libvirtError: Requested operation is not valid: domain is not running
To prevent this spam, we add another libvirt exception to
the whitelist of "known unharmful" error codes in
Vm.isDomainReadyForCommands().
Change-Id: If130a4b31016e971ac9972b67ba5d3fd70de5b7d
Signed-off-by: Francesco Romani
---
M vdsm/virt/vm.py
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/41406/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 8983965..815f1a7 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -2595,8 +2595,10 @@
# to avoid racy checks.
return False
except libvirt.libvirtError as e:
-if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
-# same as AttributeError above: possible race on shutdown
+if e.get_error_code() in (
+libvirt.VIR_ERR_NO_DOMAIN, # possible race on shutdown
+libvirt.VIR_ERR_OPERATION_INVALID, # dom misdetected up
+):
return False
else:
raise
--
To view, visit https://gerrit.ovirt.org/41406
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If130a4b31016e971ac9972b67ba5d3fd70de5b7d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: virt: do not poll storage in migrations
automat...@ovirt.org has posted comments on this change. Change subject: periodic: virt: do not poll storage in migrations .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40507 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43ec1e64700020b7d143e22c4c3d8bdceb57fb18 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network/models: check unified persistence only when it exists
Dan Kenigsberg has posted comments on this change. Change subject: network/models: check unified persistence only when it exists .. Patch Set 1: Ido, I have checked and rechecked the condition, and seems correct. It is too hard to parse, and this would be fixed in the master branch. -- To view, visit https://gerrit.ovirt.org/41366 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I964ebd7594f1d1a8209ba0c62b9c4bee342309b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vdsm-tool: is-configured: on el6, we must disable sysv's lib...
automat...@ovirt.org has posted comments on this change. Change subject: vdsm-tool: is-configured: on el6, we must disable sysv's libvirtd job .. Patch Set 9: * Update tracker::#1222154::OK * Check Bug-Url::OK * Check Public Bug::#1222154::OK, public bug * Check Product::#1222154::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1222154::OK, correct target release 3.5.3 * warn_if_not_merged_to_previous_branch: OK -- To view, visit https://gerrit.ovirt.org/41144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6326a34cc9e4bee82a427f2543354438205cd11d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Mooli Tayer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network/models: check unified persistence only when it exists
Dan Kenigsberg has posted comments on this change. Change subject: network/models: check unified persistence only when it exists .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41366 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I964ebd7594f1d1a8209ba0c62b9c4bee342309b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vdsm-tool: is-configured: on el6, we must disable sysv's lib...
Dan Kenigsberg has posted comments on this change. Change subject: vdsm-tool: is-configured: on el6, we must disable sysv's libvirtd job .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6326a34cc9e4bee82a427f2543354438205cd11d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Mooli Tayer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: fix redefinition pyflakes error
automat...@ovirt.org has posted comments on this change. Change subject: tests: fix redefinition pyflakes error .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41402 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I244dfbc031a4c10f1938d3f5a07daed757011d16 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vdsm-tool: is-configured: on el6, we must disable sysv's lib...
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: is-configured: on el6, we must disable sysv's libvirtd job .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6326a34cc9e4bee82a427f2543354438205cd11d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Mooli Tayer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
Dan Kenigsberg has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: fix redefinition pyflakes error
Timothy Asir has posted comments on this change. Change subject: tests: fix redefinition pyflakes error .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/41402 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I244dfbc031a4c10f1938d3f5a07daed757011d16 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: fix redefinition pyflakes error
Timothy Asir has uploaded a new change for review. Change subject: tests: fix redefinition pyflakes error .. tests: fix redefinition pyflakes error ./tests/functional/networkTests.py:93: redefinition of unused 'vdsm' from line 28 ./tests/functional/networkTests.py:101: redefinition of unused 'vdsm' from line 28 make[1]: *** [pyflakes] Error 1 Change-Id: I244dfbc031a4c10f1938d3f5a07daed757011d16 Signed-off-by: Timothy Asir Jeyasingh --- M tests/functional/networkTests.py 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/41402/1 diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py index 553f479..73f6b11 100644 --- a/tests/functional/networkTests.py +++ b/tests/functional/networkTests.py @@ -90,16 +90,14 @@ @RequireDummyMod def setupModule(): """Persists network configuration.""" -vdsm = VdsProxy() -vdsm.save_config() +VdsProxy().save_config() for _ in range(DUMMY_POOL_SIZE): dummyPool.add(dummy.create()) def tearDownModule(): """Restores the network configuration previous to running tests.""" -vdsm = VdsProxy() -vdsm.restoreNetConfig() +VdsProxy().restoreNetConfig() for nic in dummyPool: dummy.remove(nic) -- To view, visit https://gerrit.ovirt.org/41402 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I244dfbc031a4c10f1938d3f5a07daed757011d16 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: fix redefinition pyflakes error
automat...@ovirt.org has posted comments on this change. Change subject: tests: fix redefinition pyflakes error .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41402 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I244dfbc031a4c10f1938d3f5a07daed757011d16 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: switch to SampleWindow
Francesco Romani has posted comments on this change.
Change subject: sampling: hoststats: switch to SampleWindow
..
Patch Set 8:
(3 comments)
https://gerrit.ovirt.org/#/c/40428/8/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line 613: 'elapsedTime': int(time.time() - self.startTime)
Line 614: }
Line 615:
Line 616: hs0, hs1, _ = self._samples.stats()
Line 617: # we need a different interval, see below
> it is not clear (to me) to what does this comment relate to. Is it related
the comment is confusing, will drop it.
Line 618: if hs0 is None or hs1 is None:
Line 619: return stats
Line 620:
Line 621: stats.update(self._getInterfacesStats())
Line 614: }
Line 615:
Line 616: hs0, hs1, _ = self._samples.stats()
Line 617: # we need a different interval, see below
Line 618: if hs0 is None or hs1 is None:
> checking for hs1 is enough, right? if it is there, hs0 must exist.
Yep
Line 619: return stats
Line 620:
Line 621: stats.update(self._getInterfacesStats())
Line 622:
Line 681:
Line 682: def _getInterfacesStats(self):
Line 683: stats = {}
Line 684: hs0, hs1, _ = self._samples.stats()
Line 685: if hs0 is None:
> wouldn't this explode on the very start of vdsm, when only one sample has b
Yes, this is wrong.
Line 686: return stats
Line 687: interval = hs1.timestamp - hs0.timestamp
Line 688:
Line 689: rx = tx = rxDropped = txDropped = 0
--
To view, visit https://gerrit.ovirt.org/40428
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ec5712ee1fb69ed3d8dbc28ca4e6511998270c9
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: new vdsm config to output libvirtd log to file
automat...@ovirt.org has posted comments on this change. Change subject: new vdsm config to output libvirtd log to file .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa9c47273b134cf102dfe85dcb628619c1de53b5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
Francesco Romani has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 7: Verified+1 re-verified using tests -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add HostStatsThread._getCpuCoreStats test
automat...@ovirt.org has posted comments on this change. Change subject: tests: add HostStatsThread._getCpuCoreStats test .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41372 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c6a82c77054e76d7d08322ad83d086302c2bbad Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: host stats: switch to monotonic_time
automat...@ovirt.org has posted comments on this change. Change subject: sampling: host stats: switch to monotonic_time .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ca60654836018f040b7aa1b506b3479a0f4c996 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: HostStatsThread as periodic operation
automat...@ovirt.org has posted comments on this change. Change subject: sampling: HostStatsThread as periodic operation .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39c2e6e4bca286a513992b7231f1356e8dd871a1 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
automat...@ovirt.org has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: make _getCpuCoresStats a function
automat...@ovirt.org has posted comments on this change. Change subject: sampling: make _getCpuCoresStats a function .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40429 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If602a84096db7aa7d1a6672b84d62287e08b0ac2 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: rename variables for clarity
automat...@ovirt.org has posted comments on this change. Change subject: sampling: rename variables for clarity .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41219 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24d07414c96dcd047966bb28cd2f756640692f1c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: make _getInterfaceStats a function
automat...@ovirt.org has posted comments on this change. Change subject: sampling: make _getInterfaceStats a function .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40430 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b5796f3463585794d2696ce73f8357cb0fd1f78 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: switch to SampleWindow
automat...@ovirt.org has posted comments on this change. Change subject: sampling: hoststats: switch to SampleWindow .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40428 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ec5712ee1fb69ed3d8dbc28ca4e6511998270c9 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add allocation type for disk conversion
Shahar Havivi has posted comments on this change. Change subject: v2v: Add allocation type for disk conversion .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/40533 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd3ca2983455adbb51f11957e0ce042b0cfc5ef1 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: add format for disk conversion
automat...@ovirt.org has posted comments on this change. Change subject: v2v: add format for disk conversion .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Job related actions
Shahar Havivi has posted comments on this change. Change subject: v2v: Job related actions .. Patch Set 19: Verified+1 -- To view, visit https://gerrit.ovirt.org/39361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a58583a88e2f17ce0847626cd601efbe1a00ac9 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: add format for disk conversion
Shahar Havivi has posted comments on this change. Change subject: v2v: add format for disk conversion .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/40343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Add allocation type for disk conversion
automat...@ovirt.org has posted comments on this change. Change subject: v2v: Add allocation type for disk conversion .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40533 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd3ca2983455adbb51f11957e0ce042b0cfc5ef1 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Job related actions
automat...@ovirt.org has posted comments on this change. Change subject: v2v: Job related actions .. Patch Set 19: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a58583a88e2f17ce0847626cd601efbe1a00ac9 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: set system name for threads
Nir Soffer has posted comments on this change.
Change subject: lib: set system name for threads
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/41057/8/lib/vdsm/schedule.py
File lib/vdsm/schedule.py:
Line 188: def _set_system_name(self):
Line 189: if len(self._name) <= pthread.NAME_MAX_LENGTH:
Line 190: pthread.setname(self._name)
Line 191: else:
Line 192: pthread.setname('scheduler')
> How about brute-force clipping of the Python name, if the '.' is missing (w
I think this can work to get all threads with system name now, without much
work.
We will clean up and improve the names later by modifying the python thread
name.
Line 193:
Line 194:
Line 195: class ScheduledCall(object):
Line 196: """
--
To view, visit https://gerrit.ovirt.org/41057
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e8ffe2c598221d93ca154e4ee4f345568c5b35f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: only write to stderr on plaintext connection given t...
Dan Kenigsberg has posted comments on this change. Change subject: vdscli: only write to stderr on plaintext connection given timeout .. Patch Set 2: Code-Review-1 we have a proper fix planned. I understand that this is only a draft hack that should not be merged. -- To view, visit https://gerrit.ovirt.org/41384 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief84241e6fe34c8b0f75522458c87c2a5cabaf40 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: tests: add (more) unittests for caps.py
Francesco Romani has posted comments on this change. Change subject: caps: tests: add (more) unittests for caps.py .. Patch Set 15: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86c2203bf245ba209e10b0905ae1090835408201 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Job related actions
Dan Kenigsberg has posted comments on this change. Change subject: v2v: Job related actions .. Patch Set 18: Code-Review-1 a silly manual rebase is needed -- To view, visit https://gerrit.ovirt.org/39361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a58583a88e2f17ce0847626cd601efbe1a00ac9 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Detect RNG device by type
automat...@ovirt.org has posted comments on this change. Change subject: vm: Detect RNG device by type .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31a1c38eec5be96e298e0f1dd5a7598c2212cb21 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Shmuel Leib Melamud Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: new vdsm config to output libvirtd log to file
Yaniv Bronhaim has uploaded a new change for review.
Change subject: new vdsm config to output libvirtd log to file
..
new vdsm config to output libvirtd log to file
Having the config value libvirt_log_file=True will add to libvirtd.conf
the field log_outputs=1:file:/var/log/libvirt/libvirtd.log. otherwise libvirtd
uses the default output which is currently only to syslog.
Change-Id: Iaa9c47273b134cf102dfe85dcb628619c1de53b5
Signed-off-by: Yaniv Bronhaim
---
M lib/vdsm/config.py.in
M lib/vdsm/tool/configurators/libvirt.py
2 files changed, 13 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/41395/1
diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index 03a63c8..ca8517b 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -160,6 +160,10 @@
('ssl', 'true',
'Whether to use ssl encryption and authentication.'),
+('libvirt_log_file', 'False',
+'True to print libvirtd logs to /var/log/libvirt/libvirtd.log.'
+'False will uses the service default.'),
+
('vds_responsiveness_timeout', '60', None),
('vdsm_nice', '-5', None),
diff --git a/lib/vdsm/tool/configurators/libvirt.py
b/lib/vdsm/tool/configurators/libvirt.py
index e182231..891b188 100644
--- a/lib/vdsm/tool/configurators/libvirt.py
+++ b/lib/vdsm/tool/configurators/libvirt.py
@@ -72,6 +72,7 @@
config.read(_getFile('VDSM_CONF'))
vdsmConfiguration = {
'ssl_enabled': config.getboolean('vars', 'ssl'),
+'log_to_file': config.getboolen('vars', 'libvirt_log_file'),
'sanlock_enabled': constants.SANLOCK_ENABLED,
'libvirt_selinux': constants.LIBVIRT_SELINUX
}
@@ -343,6 +344,14 @@
},
},
+{
+'conditions': {
+"log_to_file": True,
+},
+'content': {
+'log_outputs': '1:file:/var/log/libvirt/libvirtd.log',
+},
+},
]
},
--
To view, visit https://gerrit.ovirt.org/41395
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa9c47273b134cf102dfe85dcb628619c1de53b5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: new vdsm config to output libvirtd log to file
automat...@ovirt.org has posted comments on this change. Change subject: new vdsm config to output libvirtd log to file .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa9c47273b134cf102dfe85dcb628619c1de53b5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Detect RNG device by type
Francesco Romani has posted comments on this change. Change subject: vm: Detect RNG device by type .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31a1c38eec5be96e298e0f1dd5a7598c2212cb21 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Shmuel Leib Melamud Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: detector: close acceptor when stopping detection
automat...@ovirt.org has posted comments on this change. Change subject: detector: close acceptor when stopping detection .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92e24b6265a7480218a7271e8c6242a78bb535cf Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: set system name for threads
Dan Kenigsberg has posted comments on this change.
Change subject: lib: set system name for threads
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/41057/8/lib/vdsm/schedule.py
File lib/vdsm/schedule.py:
Line 188: def _set_system_name(self):
Line 189: if len(self._name) <= pthread.NAME_MAX_LENGTH:
Line 190: pthread.setname(self._name)
Line 191: else:
Line 192: pthread.setname('scheduler')
> I like the concept of NamedThread you provided.
How about brute-force clipping of the Python name, if the '.' is missing (with
a warning logged)?
This would make all inheriting thread have system names, and give us time to
grant shorter prefix for the rest.
Line 193:
Line 194:
Line 195: class ScheduledCall(object):
Line 196: """
--
To view, visit https://gerrit.ovirt.org/41057
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e8ffe2c598221d93ca154e4ee4f345568c5b35f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:fix NoneType error for some devices does not contain...
Ramesh N has posted comments on this change. Change subject: gluster:fix NoneType error for some devices does not contain sysfsPath .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41262 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54efdf3958519e2ae038b527a03e0b57569c2e8f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:fix NoneType error for some devices does not contain...
Piotr Kliczewski has posted comments on this change. Change subject: gluster:fix NoneType error for some devices does not contain sysfsPath .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41262 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54efdf3958519e2ae038b527a03e0b57569c2e8f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:fix NoneType error for some devices does not contain...
Timothy Asir has posted comments on this change. Change subject: gluster:fix NoneType error for some devices does not contain sysfsPath .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/41262 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54efdf3958519e2ae038b527a03e0b57569c2e8f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:fix NoneType error for some devices does not contain...
automat...@ovirt.org has posted comments on this change. Change subject: gluster:fix NoneType error for some devices does not contain sysfsPath .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41262 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54efdf3958519e2ae038b527a03e0b57569c2e8f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: hook for booting from an ISO image gathered via https
Simone Tiraboschi has posted comments on this change. Change subject: vdsm: hook for booting from an ISO image gathered via https .. Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/41076/13/vdsm_hooks/httpsisoboot/README File vdsm_hooks/httpsisoboot/README: Line 9: between the VM and the web server: in case of latency spikes or packet loss, Line 10: the guest will see EIO errors. Line 11: So it could be adopted with a local web server with plenty of spare capacity Line 12: and a fast LAN link to RHEV-H, but using it with remotely available ISO Line 13: images is not recommended. > Have you considered downloading the image to a local cache first? http/https support via curl is directly embedded into qemu. And in ovirt we already have the ISO storage domain; so what we could do on oVirt side is letting the user import the ISO directly from http to the ISO storage domain but this is completely a different feature. Line 14: Line 15: The support for plain http has been removed from qemu-kvm-rhev and qemu-kvm-ev Line 16: as a security improvement but it's available upstream. Line 17: -- To view, visit https://gerrit.ovirt.org/41076 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22b190b5d3d43cab7bdbfa81bdf0904b2988b2bc Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eldan Shachar Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: switch to SampleWindow
Dan Kenigsberg has posted comments on this change. Change subject: sampling: hoststats: switch to SampleWindow .. Patch Set 8: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/40428 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ec5712ee1fb69ed3d8dbc28ca4e6511998270c9 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: switch to SampleWindow
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: hoststats: switch to SampleWindow
..
Patch Set 8:
(3 comments)
https://gerrit.ovirt.org/#/c/40428/8/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line 613: 'elapsedTime': int(time.time() - self.startTime)
Line 614: }
Line 615:
Line 616: hs0, hs1, _ = self._samples.stats()
Line 617: # we need a different interval, see below
it is not clear (to me) to what does this comment relate to. Is it related to
the fact we ignore the interval here; it is calculated 2 lines below?
Line 618: if hs0 is None or hs1 is None:
Line 619: return stats
Line 620:
Line 621: stats.update(self._getInterfacesStats())
Line 614: }
Line 615:
Line 616: hs0, hs1, _ = self._samples.stats()
Line 617: # we need a different interval, see below
Line 618: if hs0 is None or hs1 is None:
checking for hs1 is enough, right? if it is there, hs0 must exist.
Line 619: return stats
Line 620:
Line 621: stats.update(self._getInterfacesStats())
Line 622:
Line 681:
Line 682: def _getInterfacesStats(self):
Line 683: stats = {}
Line 684: hs0, hs1, _ = self._samples.stats()
Line 685: if hs0 is None:
wouldn't this explode on the very start of vdsm, when only one sample has been
taken, and hs1 is None?
Line 686: return stats
Line 687: interval = hs1.timestamp - hs0.timestamp
Line 688:
Line 689: rx = tx = rxDropped = txDropped = 0
--
To view, visit https://gerrit.ovirt.org/40428
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ec5712ee1fb69ed3d8dbc28ca4e6511998270c9
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:fix NoneType error for some devices does not contain...
Timothy Asir has posted comments on this change.
Change subject: gluster:fix NoneType error for some devices does not contain
sysfsPath
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/41262/2/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:
Line 78: else:
Line 79: info['model'] = device.type
Line 80: if device.format:
Line 81: info['uuid'] = device.format.uuid or ''
Line 82: # bz#1223725: Device sysfsPath is empty for the device type
lvmvg
> Looks like this is not a bug from blivet. This is the standard behavior. Pl
Done
Line 83: # Workaround: Till the bz gets fixed, we assign {}
Line 84: # if device.sysfsPath is empty and the dev is None
Line 85: if hasattr(udev, 'get_device'):
Line 86: dev = udev.get_device(device.sysfsPath) or {}
--
To view, visit https://gerrit.ovirt.org/41262
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54efdf3958519e2ae038b527a03e0b57569c2e8f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Darshan N
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Ramesh N
Gerrit-Reviewer: Timothy Asir
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:fix NoneType error for some devices does not contain...
Ramesh N has posted comments on this change. Change subject: gluster:fix NoneType error for some devices does not contain sysfsPath .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41262/2/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 82: bz#1223725 Looks like this is not a bug from blivet. This is the standard behavior. Please change the comment. -- To view, visit https://gerrit.ovirt.org/41262 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54efdf3958519e2ae038b527a03e0b57569c2e8f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
Dan Kenigsberg has posted comments on this change. Change subject: sampling: less verbose debug in _getInterfaceStats .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
automat...@ovirt.org has posted comments on this change. Change subject: sampling: less verbose debug in _getInterfaceStats .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats
Dan Kenigsberg has submitted this change and it was merged. Change subject: sampling: less verbose debug in _getInterfaceStats .. sampling: less verbose debug in _getInterfaceStats HostStatsThread._getInterfaceStats() needs to compute network tx/rx rate from the sampled data. To help troubleshoot rate miscalculations, a debug log was added, to show on error (rate > 100%) all the samples used for computation. The problem here is that the log iterates over the gathered samples. We want to use SampleWindow in HostStatsThread to reduce code duplication, but SampleWindow doesn't give access to raw samples yet. To move further, we drop this detailed log for the time being. Future patches may want to reintroduce it on top of SampleWindow. Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Signed-off-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/40424 Reviewed-by: Ido Barkan Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M vdsm/virt/sampling.py 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: Ido Barkan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/40424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Configure libvirt to generate VM's core dumps
Amador Pahim has posted comments on this change.
Change subject: Configure libvirt to generate VM's core dumps
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/41072/3/init/systemd/unlimited-core.conf
File init/systemd/unlimited-core.conf:
Line 1: [Service]
> don't you want to specify that this additional conf file is installed by vd
Done
https://gerrit.ovirt.org/#/c/41072/3/vdsm.spec.in
File vdsm.spec.in:
Line 800: %if 0%{?with_systemd}
Line 801: install -Dm 0644 init/systemd/vdsm-tmpfiles.d.conf \
Line 802: %{buildroot}%{_tmpfilesdir}/%{vdsm_name}.conf
Line 803: install -Dm 0644 init/systemd/unlimited-core.conf \
Line 804:
%{buildroot}%{_sysconfdir}/systemd/system/libvirtd.service.d/unlimited-core.conf
> won't we delete that file during uninstall?
The file is deleted with yum remove. Could you clarify your suggestion?
Line 805: %endif
Line 806:
Line 807: %if 0%{?rhel}
Line 808: # This is not commonplace, but we want /var/log/core to be a
world-writable
--
To view, visit https://gerrit.ovirt.org/41072
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I068e1c6386a9076d3e713bc63e7895a5ac458d62
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim
Gerrit-Reviewer: Amador Pahim
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: create vg with custom pesize
Timothy Asir has uploaded a new change for review.
Change subject: gluster: create vg with custom pesize
..
gluster: create vg with custom pesize
Currently blivet forcefully creates vg with 1mb pesize
This will be an workaround patch till the blivet
bug: https://bugzilla.redhat.com/show_bug.cgi?id=1198568
get fixed.
Change-Id: I6ca89347b537e0ab6cffc2b1293ba9b5a32c366d
Signed-off-by: Timothy Asir Jeyasingh
---
M vdsm/gluster/storagedev.py
1 file changed, 14 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/41392/1
diff --git a/vdsm/gluster/storagedev.py b/vdsm/gluster/storagedev.py
index 0eea52c..0daf437 100644
--- a/vdsm/gluster/storagedev.py
+++ b/vdsm/gluster/storagedev.py
@@ -41,6 +41,9 @@
log = logging.getLogger("Gluster")
+_vgCreateCommandPath = utils.CommandPath("vgcreate",
+ "/sbin/vgcreate",
+ "/usr/sbin/vgcreate",)
_lvconvertCommandPath = utils.CommandPath("lvconvert",
"/sbin/lvconvert",
"/usr/sbin/lvconvert",)
@@ -164,13 +167,19 @@
def _createVG(vgName, deviceList, stripeSize=0):
if stripeSize:
-vg = LVMVolumeGroupDevice(
-vgName, peSize=blivet.size.Size('%s KiB' % stripeSize),
-parents=deviceList)
+devices = [device.path for device in deviceList]
+rc, out, err = utils.execCmd([_vgCreateCommandPath.cmd,
+ '-s', '%sk' % stripeSize,
+ vgName, ','.join(devices)])
+
+if rc:
+raise ge.GlusterHostStorageDeviceVGCreateFailedException(
+vgName, deviceList, stripeSize, rc, out, err)
+blivetEnv.reset()
+vg = blivetEnv.devicetree.getDeviceByName(vgName)
else:
vg = LVMVolumeGroupDevice(vgName, parents=deviceList)
-
-blivetEnv.createDevice(vg)
+blivetEnv.createDevice(vg)
return vg
def _createThinPool(poolName, vg, alignment=0,
--
To view, visit https://gerrit.ovirt.org/41392
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ca89347b537e0ab6cffc2b1293ba9b5a32c366d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: create vg with custom pesize
automat...@ovirt.org has posted comments on this change. Change subject: gluster: create vg with custom pesize .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41392 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ca89347b537e0ab6cffc2b1293ba9b5a32c366d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: hoststats: add test for empty stats
automat...@ovirt.org has posted comments on this change. Change subject: tests: hoststats: add test for empty stats .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/41371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7bf101c96624ee49018834d6e01cb0997c1bb4e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: hoststats: add test for empty stats
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: hoststats: add test for empty stats .. tests: hoststats: add test for empty stats If HostStats hasn't gathered enough samples, it should return a placeholder result with a few fields with predictable values. Add a test to ensure that. Change-Id: Ic7bf101c96624ee49018834d6e01cb0997c1bb4e Signed-off-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/41371 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M tests/samplingTests.py 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/41371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7bf101c96624ee49018834d6e01cb0997c1bb4e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: hoststats: add test for empty stats
Dan Kenigsberg has posted comments on this change. Change subject: tests: hoststats: add test for empty stats .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7bf101c96624ee49018834d6e01cb0997c1bb4e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: hook for booting from an ISO image gathered via https
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: hook for booting from an ISO image gathered via https .. Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/41076/13/vdsm_hooks/httpsisoboot/README File vdsm_hooks/httpsisoboot/README: Line 9: between the VM and the web server: in case of latency spikes or packet loss, Line 10: the guest will see EIO errors. Line 11: So it could be adopted with a local web server with plenty of spare capacity Line 12: and a fast LAN link to RHEV-H, but using it with remotely available ISO Line 13: images is not recommended. Have you considered downloading the image to a local cache first? Line 14: Line 15: The support for plain http has been removed from qemu-kvm-rhev and qemu-kvm-ev Line 16: as a security improvement but it's available upstream. Line 17: -- To view, visit https://gerrit.ovirt.org/41076 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22b190b5d3d43cab7bdbfa81bdf0904b2988b2bc Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eldan Shachar Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mailbox: Rename mailbox monitor threads
Dan Kenigsberg has submitted this change and it was merged. Change subject: mailbox: Rename mailbox monitor threads .. mailbox: Rename mailbox monitor threads Name the HSM and SPM mail monitor threads "mailbox.HSMMonitor" and "mailbox.SPMMonitor" instead of the default Thread-1234. Change-Id: I361760c2ca05e378dc8eb840f74a27002ffb0acf Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/41080 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M vdsm/storage/storage_mailbox.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I361760c2ca05e378dc8eb840f74a27002ffb0acf Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mailbox: Rename mailbox monitor threads
automat...@ovirt.org has posted comments on this change. Change subject: mailbox: Rename mailbox monitor threads .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/41080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I361760c2ca05e378dc8eb840f74a27002ffb0acf Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Remove QEMU passthrough hack in ppc64
automat...@ovirt.org has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 .. Patch Set 8: * Update tracker::#1122627::OK * Check Bug-Url::OK * Check Public Bug::#1122627::OK, public bug * Check Product::#1122627::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
