Timothy Asir has posted comments on this change. Change subject: gluster:fix NoneType error for some devices does not contain sysfsPath ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41262/2/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 78: else: Line 79: info['model'] = device.type Line 80: if device.format: Line 81: info['uuid'] = device.format.uuid or '' Line 82: # bz#1223725: Device sysfsPath is empty for the device type lvmvg > Looks like this is not a bug from blivet. This is the standard behavior. Pl Done Line 83: # Workaround: Till the bz gets fixed, we assign {} Line 84: # if device.sysfsPath is empty and the dev is None Line 85: if hasattr(udev, 'get_device'): Line 86: dev = udev.get_device(device.sysfsPath) or {} -- To view, visit https://gerrit.ovirt.org/41262 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54efdf3958519e2ae038b527a03e0b57569c2e8f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
