Change in vdsm[master]: hostdev: raise more meaningful exception without iommu support
Ido Barkan has posted comments on this change.
Change subject: hostdev: raise more meaningful exception without iommu support
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/41885/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1792: # KeyError would be raised if no IOMMU group is
found.
Line 1793: # Since that is more general than simply
KeyError, let's
Line 1794: # re-raise and add a message, that will be
visible in
Line 1795: # Engine.
Line 1796: raise Exception('hostdev passthrough without
iommu')
remember that you are loosing your stack trace here and can potentially hide
other bugs. You can consider logger.exception('message') and then just an empty
raise to preserve original st.
Line 1797:
Line 1798: if initDomain:
Line 1799: domxml =
hooks.before_vm_start(self._buildDomainXML(),
Line 1800:self.conf)
--
To view, visit https://gerrit.ovirt.org/41885
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I084b34876be937ed2022ca321c9584228344b3bb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Alona Kaplan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: destroy VM with hostdev even without IOMMU support
Ido Barkan has posted comments on this change. Change subject: hostdev: destroy VM with hostdev even without IOMMU support .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I857ec18c0932de247469f6fb780d1b28aa3873e8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemuimg: add support for convert progress
Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 7:
(3 comments)
https://gerrit.ovirt.org/#/c/33910/7/tests/qemuimgTests.py
File tests/qemuimgTests.py:
Line 368: PROGRESS_FORMAT = "(%.2f/100%%)\r"
Line 369:
Line 370: @staticmethod
Line 371: def _progress_iterator():
Line 372: return map(lambda x: x / 100.0, xrange(0, 1, 1))
Why not use a generator?
for value in xrange(0, 1, 1):
yield value / 100.0
Line 373:
Line 374: def test_failure(self):
Line 375: p = qemuimg.QemuImgProcess(['false'])
Line 376: self.assertRaises(qemuimg.QImgError, p.wait)
Line 378: def test_progress_simple(self):
Line 379: p = qemuimg.QemuImgProcess(['true'])
Line 380:
Line 381: for progress in self._progress_iterator():
Line 382: p._recvstdout(self.PROGRESS_FORMAT % progress)
This works but it assumes too much internal knowledge. I think we would like to
run a fake qemu-img program that generate expected outputs and errors instead
of this.
Another option, mock it so you can replace the process stdout with a StringIO
returning fake output.
Line 383: self.assertEquals(p.progress, progress)
Line 384:
Line 385: p.wait()
Line 386: self.assertEquals(p.finished, True)
Line 384:
Line 385: p.wait()
Line 386: self.assertEquals(p.finished, True)
Line 387:
Line 388: def test_progress_incomplete(self):
This test would be more clear if we limit the test to only few iterations, and
have constant output and result that we can see - for example:
@permutations([
# qemu-img output, progress value
(("(1/100%)\r", "(2/100%)\r"), (1, 2)),
(("(1/10", "0%)\r(2/100%)\r"), (1, 2)),
])
Line 389: p = qemuimg.QemuImgProcess(['true'])
Line 390:
Line 391: old_progress = 0.0
Line 392:
--
To view, visit https://gerrit.ovirt.org/33910
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0b53e418c62bb2e91444ba5f351c916ca417299
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: reactor: move creation to clientIF
automat...@ovirt.org has posted comments on this change. Change subject: reactor: move creation to clientIF .. Patch Set 17: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40170 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f36ec36b91fcc46e1ab46eb92f9739e9e19e448 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: reactor: move creation to clientIF
Dan Kenigsberg has submitted this change and it was merged. Change subject: reactor: move creation to clientIF .. reactor: move creation to clientIF It is final step performed in several patches to have single class responsible for processing i/o loop. Overall goal in number of changes was to simplify the code and have single responsibility per class. It was not the case with Protocoldetector and StompReactor before. Change-Id: I8f36ec36b91fcc46e1ab46eb92f9739e9e19e448 Signed-off-by: pkliczewski Reviewed-on: https://gerrit.ovirt.org/40170 Reviewed-by: Yaniv Bronhaim Reviewed-by: Yeela Kaplan Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M tests/jsonRpcHelper.py M tests/protocoldetectorTests.py M vdsm/clientIF.py M vdsm/protocoldetector.py 4 files changed, 23 insertions(+), 16 deletions(-) Approvals: Piotr Kliczewski: Verified Yeela Kaplan: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40170 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f36ec36b91fcc46e1ab46eb92f9739e9e19e448 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: remove not needed param
Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonrpc: remove not needed param .. jsonrpc: remove not needed param Change-Id: I24a9e44d272bb4d12c0816c7d168397ffa2758d2 Signed-off-by: pkliczew Reviewed-on: https://gerrit.ovirt.org/40171 Reviewed-by: Dan Kenigsberg Reviewed-by: Yaniv Bronhaim Reviewed-by: Yeela Kaplan Continuous-Integration: Jenkins CI --- M lib/yajsonrpc/stompreactor.py M vdsm/rpc/bindingjsonrpc.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Yeela Kaplan: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40171 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24a9e44d272bb4d12c0816c7d168397ffa2758d2 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: reactor: move creation to clientIF
Dan Kenigsberg has posted comments on this change. Change subject: reactor: move creation to clientIF .. Patch Set 16: Code-Review+2 I utterly hate giving clientIF more power, but I don't have a readily available alternative -- To view, visit https://gerrit.ovirt.org/40170 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f36ec36b91fcc46e1ab46eb92f9739e9e19e448 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: remove not needed param
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: remove not needed param .. Patch Set 17: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40171 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a9e44d272bb4d12c0816c7d168397ffa2758d2 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: client side subscription
automat...@ovirt.org has posted comments on this change. Change subject: stomp: client side subscription .. Patch Set 31: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/36368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronheim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: client side subscription
Dan Kenigsberg has submitted this change and it was merged. Change subject: stomp: client side subscription .. stomp: client side subscription In this patch we introduce concept of subscription for client perspective. We move queuing functionality out of AsyncDispatcher to frame_handler. New StompRpcClient class is responsible for sending subscriptions and ClientRpcTransportAdapter class adds 'reply-to' header using subscriptions id. Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71 Signed-off-by: Saggi Mizrahi Signed-off-by: pkliczewski Reviewed-on: https://gerrit.ovirt.org/36368 Continuous-Integration: Jenkins CI Reviewed-by: Yaniv Bronhaim Reviewed-by: Dan Kenigsberg --- M lib/yajsonrpc/__init__.py M lib/yajsonrpc/stomp.py M lib/yajsonrpc/stompreactor.py M tests/jsonRpcHelper.py M tests/jsonRpcTests.py 5 files changed, 216 insertions(+), 88 deletions(-) Approvals: Piotr Kliczewski: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/36368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronheim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: client side subscription
Dan Kenigsberg has posted comments on this change. Change subject: stomp: client side subscription .. Patch Set 30: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/36368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronheim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Clear only ovirt secrets
Daniel Erez has posted comments on this change. Change subject: ceph: Clear only ovirt secrets .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b86bd43a6d33a31ef2ee638a16f46657113316d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Undefine existing secret if usage changed
Daniel Erez has posted comments on this change. Change subject: ceph: Undefine existing secret if usage changed .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40967 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib258f0be1cdd4f2672b9adaad35da13d48279ce6 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ImageUpload-api
automat...@ovirt.org has posted comments on this change. Change subject: ImageUpload-api .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41870 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddf676fb15c88e126811a25e5e97609c6d937422 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Initial support for network disk
Nir Soffer has posted comments on this change. Change subject: ceph: Initial support for network disk .. Patch Set 14: (1 comment) https://gerrit.ovirt.org/#/c/38766/14/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 2598: # Line 2599: # @baseVolumeID: #optional When used as a parameter to @VM.merge, indicates Line 2600: #the Volume that should become the new base volume Line 2601: # Line 2602: # @diskType: #optional Disk type name. Currently used only for network > which types are acceptable? It seems that only 'network'. Consider to rephr The plan is to support also "block" and "file", so vdsm does not have to check the type. Engine created these domains and there is no reason vdsm should guess when engine can tell us (Federico is not happy about this plan :-). I will rephrase as you suggest. Line 2603: #disks Line 2604: #Since: 4.17.0 Line 2605: # Line 2606: # @hosts:#optional List of network disk host info objects. At least -- To view, visit https://gerrit.ovirt.org/38766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c5792bb6206a227ee0c2df9490b771a69c0093c Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Fix "COMPELNT"/"Compellent Vol" configuration
automat...@ovirt.org has posted comments on this change. Change subject: multipath: Fix "COMPELNT"/"Compellent Vol" configuration .. Patch Set 4: * Update tracker::#1225162::OK * Check Bug-Url::OK * Check Public Bug::#1225162::OK, public bug * Check Product::#1225162::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41244 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3bf5bab082c5063272bf8947a6e2039ce4cf90c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Simplify configuration data
automat...@ovirt.org has posted comments on this change. Change subject: multipath: Simplify configuration data .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41242 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f43d41bc7505155274d7c54c66c26fc3056c89f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Fix "HITACHI"/"DF.* configuration
automat...@ovirt.org has posted comments on this change. Change subject: multipath: Fix "HITACHI"/"DF.* configuration .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41243 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78195b148aa3953f56b5a0b97366ccbdb3030d00 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Clear only ovirt secrets
Daniel Erez has posted comments on this change. Change subject: ceph: Clear only ovirt secrets .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/41302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b86bd43a6d33a31ef2ee638a16f46657113316d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Add option to clear other secrets
Daniel Erez has posted comments on this change. Change subject: ceph: Add option to clear other secrets .. Patch Set 14: Verified+1 -- To view, visit https://gerrit.ovirt.org/40853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I476e5aa0bd4a48d1837de09c59597f180fa38823 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Initial support for network disk
Dan Kenigsberg has posted comments on this change. Change subject: ceph: Initial support for network disk .. Patch Set 14: (1 comment) https://gerrit.ovirt.org/#/c/38766/14/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 2598: # Line 2599: # @baseVolumeID: #optional When used as a parameter to @VM.merge, indicates Line 2600: #the Volume that should become the new base volume Line 2601: # Line 2602: # @diskType: #optional Disk type name. Currently used only for network which types are acceptable? It seems that only 'network'. Consider to rephrase "Currently only the 'network' type is supported" Line 2603: #disks Line 2604: #Since: 4.17.0 Line 2605: # Line 2606: # @hosts:#optional List of network disk host info objects. At least -- To view, visit https://gerrit.ovirt.org/38766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c5792bb6206a227ee0c2df9490b771a69c0093c Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemuimg: add support for convert progress
Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 7:
(4 comments)
Added some comments on the code, will review the tests later.
https://gerrit.ovirt.org/#/c/33910/7/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 241: idx = self._stdout.rindex('\r')
Line 242: except ValueError:
Line 243: return
Line 244:
Line 245: last_progress = self._stdout[:idx].rsplit('\r', 1)[-1]
This line is a little bit too complex, would be nicer as two simpler steps, and
maybe a diagram showing what we look for:
# [ (31/100%) \r (32/100%) \r (33/1 ]
Line 246: del self._stdout[:idx + 1]
Line 247:
Line 248: m = self.REGEXPR.match(last_progress.strip())
Line 249: if m is None:
Line 244:
Line 245: last_progress = self._stdout[:idx].rsplit('\r', 1)[-1]
Line 246: del self._stdout[:idx + 1]
Line 247:
Line 248: m = self.REGEXPR.match(last_progress.strip())
Why not add leading and trailing whitespace into the regex? This will perform
unneeded copy of the string.
Line 249: if m is None:
Line 250: raise ValueError('Unable to parse: "%s"' % last_progress)
Line 251:
Line 252: self._progress = float(m.group(1))
Line 246: del self._stdout[:idx + 1]
Line 247:
Line 248: m = self.REGEXPR.match(last_progress.strip())
Line 249: if m is None:
Line 250: raise ValueError('Unable to parse: "%s"' % last_progress)
%r is better here
Line 251:
Line 252: self._progress = float(m.group(1))
Line 253:
Line 254: @property
Line 269: if not self._stream.closed:
Line 270: return
Line 271:
Line 272: with self._term_lock:
Line 273: self._command.wait()
Taking the lock here means that terminate will wait forever if we call from
another thread. We want to allow termination while waiting for the command to
exit, right?
Line 274:
Line 275: if self._command.returncode != 0:
Line 276: raise QImgError(self._command.returncode, "", self.stderr)
Line 277:
--
To view, visit https://gerrit.ovirt.org/33910
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0b53e418c62bb2e91444ba5f351c916ca417299
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: serial console: add code to prepare the path
Alon Bar-Lev has posted comments on this change. Change subject: serial console: add code to prepare the path .. Patch Set 3: you cannot destroy this on startup as far as I know vdsm restart keeps vms up, you cannot destroy their sockets. -- To view, visit https://gerrit.ovirt.org/41896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f851d7f7233265d33896b3aad5604e84c8af53b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Clear all secrets during startup and shutdown
Daniel Erez has posted comments on this change. Change subject: ceph: Clear all secrets during startup and shutdown .. Patch Set 8: Code-Review+1 Verified+1 -- To view, visit https://gerrit.ovirt.org/40968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c5aa36ed752642745b7febc785750b438c102bb Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Always use chown hack
Nir Soffer has posted comments on this change. Change subject: lvm: Always use chown hack .. Patch Set 2: Tested with https://gerrit.ovirt.org/39309 and https://gerrit.ovirt.org/33874. - Create vm with thin provisioned disk (extend flows) - Create vm with raw disk - Live storage migration between different types - Cold merge with raw base volume - Remove vm and disks -- To view, visit https://gerrit.ovirt.org/41862 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib70d53d68776392dbb984f47172735c0f72a0643 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Cleanup lvm udev rules
Nir Soffer has posted comments on this change. Change subject: lvm: Cleanup lvm udev rules .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/33874 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib185a7d9a5da54036b8b0163a83ff6376b511533 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Candace Sheremeta Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Remove duplication in udev rules
Nir Soffer has posted comments on this change. Change subject: lvm: Remove duplication in udev rules .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/39309 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id259071c8c2c8e059308377823081e6b307ccbe0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Candace Sheremeta Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Always use chown hack
automat...@ovirt.org has posted comments on this change. Change subject: lvm: Always use chown hack .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41862 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib70d53d68776392dbb984f47172735c0f72a0643 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: serial console: add code to prepare the path
Francesco Romani has posted comments on this change. Change subject: serial console: add code to prepare the path .. Patch Set 3: v3 implements a more robust approach, along the lines Alon suggested. Open point: Do we want to check if the dir exists and has the right attributes? Or we can just destroy and recreate it sanely on startup as we do in v3? -- To view, visit https://gerrit.ovirt.org/41896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f851d7f7233265d33896b3aad5604e84c8af53b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: remove dup initialization of Vm._guestSockFile
automat...@ovirt.org has posted comments on this change. Change subject: vm: remove dup initialization of Vm._guestSockFile .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8d959dfc3ddd96e9d019dd93394bf4390adf5cf Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: move Vm._guestSockCleanup() into utils
automat...@ovirt.org has posted comments on this change. Change subject: virt: move Vm._guestSockCleanup() into utils .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a3334a824b0d0e4edaedff1687bb6477bb4534d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: bind console to unix domain socket
automat...@ovirt.org has posted comments on this change. Change subject: virt: bind console to unix domain socket .. Patch Set 11: * Update tracker::#1223671::OK * Check Bug-Url::OK * Check Public Bug::#1223671::OK, public bug * Check Product::#1223671::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40704 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a876cd7f3b848aa9dde8123d459dc292729b303 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: serial console: add code to prepare the path
automat...@ovirt.org has posted comments on this change. Change subject: serial console: add code to prepare the path .. Patch Set 3: * Update tracker::#1223671::OK * Check Bug-Url::OK * Check Public Bug::#1223671::OK, public bug * Check Product::#1223671::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f851d7f7233265d33896b3aad5604e84c8af53b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: console: tests for cleanup() and prepare()
automat...@ovirt.org has posted comments on this change. Change subject: tests: console: tests for cleanup() and prepare() .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40828 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9bf8b8e35078147869ae1adc4e777e3699aaee9d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: bootstrap socket-related tests
automat...@ovirt.org has posted comments on this change. Change subject: tests: bootstrap socket-related tests .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68e3a3163271e9632fce630ac5aa799a644c70e1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Support ephemeral Libvirt secrets
Daniel Erez has posted comments on this change. Change subject: ceph: Support ephemeral Libvirt secrets .. Patch Set 23: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e9ee33a7447ee07b0c82cf5a80d1f9b470663bb Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Support hotunplug of network disks
Daniel Erez has posted comments on this change. Change subject: ceph: Support hotunplug of network disks .. Patch Set 15: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38804 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I730474c54802c2b0cbb685d8088d496ad565e36c Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Validate network disk parameters
Daniel Erez has posted comments on this change. Change subject: ceph: Validate network disk parameters .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b10c54ba2732ee75e0e55c67e5e8c7bdfafa41d Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Initial support for network disk
Daniel Erez has posted comments on this change. Change subject: ceph: Initial support for network disk .. Patch Set 14: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c5792bb6206a227ee0c2df9490b771a69c0093c Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Require ceph-common package
Daniel Erez has posted comments on this change. Change subject: ceph: Require ceph-common package .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41804 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I244100d29b0b06c0387a2fdc69e659c902bbcd3c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tcTest: skip tests if somehow same bridge name is reused
automat...@ovirt.org has posted comments on this change. Change subject: tcTest: skip tests if somehow same bridge name is reused .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id678882d68976618360bcce76f16837d67e274ea Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Remove unneeded rules for deleted volumes
Nir Soffer has abandoned this change. Change subject: lvm: Remove unneeded rules for deleted volumes .. Abandoned wrong change -- To view, visit https://gerrit.ovirt.org/39310 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I8ebdae59e569293f6eb1cff69f5e1b3122159629 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Candace Sheremeta Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Remove unneeded rules for deleted volumes
automat...@ovirt.org has posted comments on this change. Change subject: lvm: Remove unneeded rules for deleted volumes .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/39310 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ebdae59e569293f6eb1cff69f5e1b3122159629 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Candace Sheremeta Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: chmod for spmprotect.sh script is not needed and expose an e...
Dan Kenigsberg has submitted this change and it was merged. Change subject: chmod for spmprotect.sh script is not needed and expose an error .. chmod for spmprotect.sh script is not needed and expose an error Without running make in storage/protect folder the spmprotect.sh won't appear while running configure and this raise an error. This chmod is not required - installing the file under /usr/libexec/vdsm/spmprotect.sh make it executable automatically. Change-Id: I0815728e876b33361ec1124a5c82b130e9b8ba2c Signed-off-by: Yaniv Bronhaim Reviewed-on: https://gerrit.ovirt.org/41883 Continuous-Integration: Jenkins CI Tested-by: David Caro Reviewed-by: Nir Soffer Reviewed-by: Dan Kenigsberg --- M configure.ac 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified Jenkins CI: Passed CI tests David Caro: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0815728e876b33361ec1124a5c82b130e9b8ba2c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: chmod for spmprotect.sh script is not needed and expose an e...
Dan Kenigsberg has posted comments on this change. Change subject: chmod for spmprotect.sh script is not needed and expose an error .. Patch Set 1: Code-Review+2 Apparently I misunderstood Nir's comment in https://gerrit.ovirt.org/#/c/41024/11..13/configure.ac I still do not follow, but don't let me block this patch. -- To view, visit https://gerrit.ovirt.org/41883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0815728e876b33361ec1124a5c82b130e9b8ba2c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: chmod for spmprotect.sh script is not needed and expose an e...
automat...@ovirt.org has posted comments on this change. Change subject: chmod for spmprotect.sh script is not needed and expose an error .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/41883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0815728e876b33361ec1124a5c82b130e9b8ba2c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: All modules configure should run on upgrade
automat...@ovirt.org has posted comments on this change. Change subject: All modules configure should run on upgrade .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39492 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ab88c2dc6321864d9d934355e618f70e95ca10 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing libvirt configure fallback from spec
automat...@ovirt.org has posted comments on this change. Change subject: Removing libvirt configure fallback from spec .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40669 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f1de9f34bdad5fbb0fda9d0fd31887a6e413d6a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Remove unneeded rules for deleted volumes
Nir Soffer has posted comments on this change. Change subject: lvm: Remove unneeded rules for deleted volumes .. Patch Set 2: Verified-1 Testing show that we do use these names when deleting the base volume when the volume is in raw format and using post zero. -- To view, visit https://gerrit.ovirt.org/39310 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ebdae59e569293f6eb1cff69f5e1b3122159629 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Candace Sheremeta Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Configure libvirt to generate VM's core dumps
automat...@ovirt.org has posted comments on this change. Change subject: Configure libvirt to generate VM's core dumps .. Patch Set 3: * Update tracker::#1220993::OK * Check Bug-Url::OK * Check Public Bug::#1220993::OK, public bug * Check Product::#1220993::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1220993::OK, correct target release 3.5.4 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/41474 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I068e1c6386a9076d3e713bc63e7895a5ac458d62 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Amador Pahim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: status: logging status values before sending event
Piotr Kliczewski has posted comments on this change. Change subject: status: logging status values before sending event .. Patch Set 7: build failure not related to this change. -- To view, visit https://gerrit.ovirt.org/41380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e266759ba0310dd83d6b65d9e3a63caacc0b637 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: outgoing connection to a broker
Yaniv Bronhaim has posted comments on this change. Change subject: stomp: outgoing connection to a broker .. Patch Set 25: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38819 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied3095a305fd5a5bfc19c8bc0342fba7cb811843 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tcTest: skip tests if somehow same bridge name is reused
Federico Simoncelli has posted comments on this change.
Change subject: tcTest: skip tests if somehow same bridge name is reused
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/41898/1/tests/tcTests.py
File tests/tcTests.py:
Line 80: def addDevice(self):
Line 81: try:
Line 82: check_call([EXT_BRCTL, 'addbr', self.devName])
Line 83: except RuntimeError as e:
Line 84: if 'can\'t create bridge with the same name' in e.message:
As rule of thumb I decided that I like to do what python repr would do with
strings:
print(repr("hello world"))
'hello world'
print(repr("hello world'"))
"hello world'"
So in this case I think it'd prefer double-quotes over single-quotes and the
escape for the apostrophe.
Line 85: raise SkipTest(e.message)
Line 86: else:
Line 87: raise
Line 88:
--
To view, visit https://gerrit.ovirt.org/41898
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id678882d68976618360bcce76f16837d67e274ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: serial console: add code to prepare the path
Alon Bar-Lev has posted comments on this change. Change subject: serial console: add code to prepare the path .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41896/2/vdsm/clientIF.py File vdsm/clientIF.py: Line 127:constants.P_OVIRT_VMCONSOLES) Line 128: Line 129: try: Line 130: supervdsm.getProxy().prepareVmConsolePath( Line 131: constants.P_OVIRT_VMCONSOLES) > this is all-of-nothing. What if the dir exists, but has wrong permissions, I think that if it is not something that is expected the command should fail to avoid security issues... this directory should either be non exist or exit with ovirt-vmconsole ownership. you do this by mkstemp -d at /var/run, set permissions and then rename. Line 132: except OSError as e: Line 133: if e.errno != os.errno.EEXIST: Line 134: raise Line 135: -- To view, visit https://gerrit.ovirt.org/41896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f851d7f7233265d33896b3aad5604e84c8af53b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tcTest: skip tests if somehow same bridge name is reused
automat...@ovirt.org has posted comments on this change. Change subject: tcTest: skip tests if somehow same bridge name is reused .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id678882d68976618360bcce76f16837d67e274ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tcTest: skip tests if somehow same bridge name is reused
Dan Kenigsberg has uploaded a new change for review.
Change subject: tcTest: skip tests if somehow same bridge name is reused
..
tcTest: skip tests if somehow same bridge name is reused
My commit 61fff86c did not solve the problem of tests magically
re-drawing the same bridge name as a formerly-started test. There is no
need to mark these jobs as failure, as the problem is not in our code
but in our broken test.
Change-Id: Id678882d68976618360bcce76f16837d67e274ea
Signed-off-by: Dan Kenigsberg
---
M tests/tcTests.py
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/41898/1
diff --git a/tests/tcTests.py b/tests/tcTests.py
index cbc7faa..49ad6f2 100644
--- a/tests/tcTests.py
+++ b/tests/tcTests.py
@@ -78,7 +78,14 @@
class _Bridge(_Interface):
def addDevice(self):
-check_call([EXT_BRCTL, 'addbr', self.devName])
+try:
+check_call([EXT_BRCTL, 'addbr', self.devName])
+except RuntimeError as e:
+if 'can\'t create bridge with the same name' in e.message:
+raise SkipTest(e.message)
+else:
+raise
+
# learning interval is different on different kernels, so set it
# explicit for 2.x kernels
if os.uname()[2].startswith("2"):
--
To view, visit https://gerrit.ovirt.org/41898
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id678882d68976618360bcce76f16837d67e274ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: events
Yaniv Bronhaim has posted comments on this change. Change subject: jsonrpc: events .. Patch Set 31: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id27b5ca1773139932eb5cb16921d5abec4991c5e Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: serial console: add code to prepare the path
Francesco Romani has posted comments on this change. Change subject: serial console: add code to prepare the path .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41896/2/vdsm/clientIF.py File vdsm/clientIF.py: Line 127:constants.P_OVIRT_VMCONSOLES) Line 128: Line 129: try: Line 130: supervdsm.getProxy().prepareVmConsolePath( Line 131: constants.P_OVIRT_VMCONSOLES) this is all-of-nothing. What if the dir exists, but has wrong permissions, or owner, or context? Should VDSM fix that? Maybe a followup patch(set)? Line 132: except OSError as e: Line 133: if e.errno != os.errno.EEXIST: Line 134: raise Line 135: -- To view, visit https://gerrit.ovirt.org/41896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f851d7f7233265d33896b3aad5604e84c8af53b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: serial console: add code to prepare the path
Francesco Romani has posted comments on this change. Change subject: serial console: add code to prepare the path .. Patch Set 2: Verified+1 Verification: - clean slate. Make sure /var/run does not contain ovirt-vmconcole-console, startup patched VDSM, check the directory gets created and has correct permissions/owner/context - restart: Make sure vdsm handles correctly already existing dir -- To view, visit https://gerrit.ovirt.org/41896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f851d7f7233265d33896b3aad5604e84c8af53b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: remove dup initialization of Vm._guestSockFile
automat...@ovirt.org has posted comments on this change. Change subject: vm: remove dup initialization of Vm._guestSockFile .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8d959dfc3ddd96e9d019dd93394bf4390adf5cf Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: console: tests for cleanup() and prepare()
automat...@ovirt.org has posted comments on this change. Change subject: tests: console: tests for cleanup() and prepare() .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40828 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9bf8b8e35078147869ae1adc4e777e3699aaee9d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: serial console: add code to prepare the path
automat...@ovirt.org has posted comments on this change. Change subject: serial console: add code to prepare the path .. Patch Set 2: * Update tracker::#1223671::OK * Check Bug-Url::OK * Check Public Bug::#1223671::OK, public bug * Check Product::#1223671::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f851d7f7233265d33896b3aad5604e84c8af53b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: bootstrap socket-related tests
automat...@ovirt.org has posted comments on this change. Change subject: tests: bootstrap socket-related tests .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68e3a3163271e9632fce630ac5aa799a644c70e1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: move Vm._guestSockCleanup() into utils
automat...@ovirt.org has posted comments on this change. Change subject: virt: move Vm._guestSockCleanup() into utils .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a3334a824b0d0e4edaedff1687bb6477bb4534d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: bind console to unix domain socket
automat...@ovirt.org has posted comments on this change. Change subject: virt: bind console to unix domain socket .. Patch Set 10: * Update tracker::#1223671::OK * Check Bug-Url::OK * Check Public Bug::#1223671::OK, public bug * Check Product::#1223671::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40704 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a876cd7f3b848aa9dde8123d459dc292729b303 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Use jsonrpc during migration of vms
Piotr Kliczewski has posted comments on this change. Change subject: migration: Use jsonrpc during migration of vms .. Patch Set 15: Verified+1 -- To view, visit https://gerrit.ovirt.org/36701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie38334e6cdcc4d7899bd5e836b3196567fc0bfd8 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Use jsonrpc during migration of vms
Piotr Kliczewski has posted comments on this change. Change subject: migration: Use jsonrpc during migration of vms .. Patch Set 15: Code-Review+1 -Verified -- To view, visit https://gerrit.ovirt.org/36701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie38334e6cdcc4d7899bd5e836b3196567fc0bfd8 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpcvdscli: create a client for vdsm with jsonrpc
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpcvdscli: create a client for vdsm with jsonrpc .. Patch Set 10: (2 comments) https://gerrit.ovirt.org/#/c/39203/10/lib/vdsm/jsonrpcvdscli.py File lib/vdsm/jsonrpcvdscli.py: Line 52: (methodName, args, e)) Line 53: Line 54: req = JsonRpcRequest(method, args, reqId=str(uuid4())) Line 55: call = self._client.call_async(req) Line 56: call.wait(CALL_TIMEOUT) > What do you think is the optimal default timeout? It is not about the timeout. I am thinking that it would be better to update client call method. There is wait without timeout so we can add it there with default value as you have here and remove it from here. Line 57: Line 58: resp = call.responses[0] Line 59: Line 60: if resp.error is not None: Line 54: req = JsonRpcRequest(method, args, reqId=str(uuid4())) Line 55: call = self._client.call_async(req) Line 56: call.wait(CALL_TIMEOUT) Line 57: Line 58: resp = call.responses[0] > How is it different than timeout not checked on call of jsonRpcClient? What I am thinking about is that responses will be not populated when the timeout occurs. Line 59: Line 60: if resp.error is not None: Line 61: raise JsonRpcError(resp.error['code'], resp.error['message']) Line 62: -- To view, visit https://gerrit.ovirt.org/39203 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9dbd70d28968db1305628281015f7b2379c8058 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: add an option to create a stomp client
Piotr Kliczewski has posted comments on this change. Change subject: stomp: add an option to create a stomp client .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronheim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: bind console to unix domain socket
automat...@ovirt.org has posted comments on this change. Change subject: virt: bind console to unix domain socket .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40704 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a876cd7f3b848aa9dde8123d459dc292729b303 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: serial console: add code to prepare the path
automat...@ovirt.org has posted comments on this change. Change subject: serial console: add code to prepare the path .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f851d7f7233265d33896b3aad5604e84c8af53b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: remove dup initialization of Vm._guestSockFile
automat...@ovirt.org has posted comments on this change. Change subject: vm: remove dup initialization of Vm._guestSockFile .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8d959dfc3ddd96e9d019dd93394bf4390adf5cf Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: move Vm._guestSockCleanup() into utils
automat...@ovirt.org has posted comments on this change. Change subject: virt: move Vm._guestSockCleanup() into utils .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a3334a824b0d0e4edaedff1687bb6477bb4534d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: bootstrap socket-related tests
automat...@ovirt.org has posted comments on this change. Change subject: tests: bootstrap socket-related tests .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68e3a3163271e9632fce630ac5aa799a644c70e1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: serial console: add code to prepare the path
Francesco Romani has uploaded a new change for review.
Change subject: serial console: add code to prepare the path
..
serial console: add code to prepare the path
Add support for vmconsole path preparation.
The new supervdsm method ensures that the unix domain socket directory
needed by ovirt-vmconsole integration exists and has
the following permissions, ownership and SELinux attributes:
/var/run/ovirt-vmconsole-console/ drwxrwxr-x. vdsm qemu
system_u:object_r:qemu_var_run_t:s0
Since /var/run is supposed to be on tmpfs, this is enforced at every
startup.
Added a new tunable, default to on, to optionally disable this feature.
Change-Id: I6f851d7f7233265d33896b3aad5604e84c8af53b
Signed-off-by: Francesco Romani
---
M lib/vdsm/config.py.in
M lib/vdsm/constants.py.in
M vdsm/clientIF.py
M vdsm/supervdsmServer
M vdsm/vdsm
5 files changed, 32 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/41896/1
diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index 03a63c8..49f18cc 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -195,6 +195,9 @@
('ssl_protocol', 'sslv23',
'SSL protocol used by encrypted connection'),
+
+('vm_console_enable', 'true',
+'Enable VM serial console access using ovirt-vmconsole.'),
]),
# Section: [mom]
diff --git a/lib/vdsm/constants.py.in b/lib/vdsm/constants.py.in
index 2890f3e..44a7ad4 100644
--- a/lib/vdsm/constants.py.in
+++ b/lib/vdsm/constants.py.in
@@ -67,6 +67,7 @@
# Path definitions
#
P_LIBVIRT_VMCHANNELS = '/var/lib/libvirt/qemu/channels/'
+P_OVIRT_VMCONSOLES = '/var/run/ovirt-vmconsole-console/'
P_VDSM = '@VDSMDIR@/'
P_VDSM_RPC = '@VDSMDIR@/rpc/'
P_VDSM_HOOKS = '@HOOKSDIR@/'
diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index b2bb119..6cfabd7 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -121,6 +121,18 @@
self.mom.stop()
raise
+def prepareVmConsoleDir(self):
+if config.getboolean('vars', 'vm_console_enable'):
+self.log.debug('preparing vmconsole directory: %s',
+ constants.P_OVIRT_VMCONSOLES)
+
+try:
+supervdsm.getProxy().prepareVmConsolePath(
+constants.P_OVIRT_VMCONSOLES)
+except OSError as e:
+if e.errno != os.errno.EEXIST:
+raise
+
def getVMs(self):
"""
Get a snapshot of the currently registered VMs.
diff --git a/vdsm/supervdsmServer b/vdsm/supervdsmServer
index ef7a710..fbd810e 100755
--- a/vdsm/supervdsmServer
+++ b/vdsm/supervdsmServer
@@ -31,6 +31,9 @@
import signal
import logging
import logging.config
+
+import selinux
+
from vdsm.infra import sigutils
import numaUtils
@@ -86,6 +89,10 @@
_UDEV_RULE_FILE_NAME_VFIO = os.path.join(
_UDEV_RULE_FILE_DIR, _UDEV_RULE_FILE_PREFIX + "iommu_group_%s" +
_UDEV_RULE_FILE_EXT)
+
+
+_SELINUX_VIRT_VMCONSOLE_LABEL = 'system_u:object_r:qemu_var_run_t:s0'
+
RUN_AS_TIMEOUT = config.getint("irs", "process_pool_timeout")
@@ -207,6 +214,13 @@
def changeNumvfs(self, device_name, numvfs):
return changeNumvfs(device_name, numvfs)
+@logDecorator
+def prepareVmConsolePath(self, consoleDir):
+os.makedirs(consoleDir, mode=0o775)
+chown(consoleDir, VDSM_USER, QEMU_PROCESS_GROUP)
+if selinux.is_selinux_enabled():
+selinux.chcon(consoleDir, _SELINUX_VIRT_VMCONSOLE_LABEL)
+
def _runAs(self, user, groups, func, args=(), kwargs={}):
def child(pipe):
res = ex = None
diff --git a/vdsm/vdsm b/vdsm/vdsm
index 67f21a4..c319d57 100755
--- a/vdsm/vdsm
+++ b/vdsm/vdsm
@@ -94,6 +94,8 @@
install_manhole({'irs': irs, 'cif': cif})
+cif.prepareVmConsoleDir()
+
cif.start()
periodic.start(cif)
try:
--
To view, visit https://gerrit.ovirt.org/41896
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f851d7f7233265d33896b3aad5604e84c8af53b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: console: tests for cleanup() and prepare()
automat...@ovirt.org has posted comments on this change. Change subject: tests: console: tests for cleanup() and prepare() .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40828 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9bf8b8e35078147869ae1adc4e777e3699aaee9d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sslutils: move createSSLContext from clientIF
Piotr Kliczewski has posted comments on this change. Change subject: sslutils: move createSSLContext from clientIF .. Patch Set 15: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/36699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c7e324759892232d16a4913314f1dfa76ea85b8 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronheim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: server side subscriptions
Piotr Kliczewski has posted comments on this change. Change subject: stomp: server side subscriptions .. Patch Set 29: Build failure not related to this change. -- To view, visit https://gerrit.ovirt.org/38451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpcvdscli: use subscription when creating a client
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpcvdscli: use subscription when creating a client .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33e1084a4016509aaf0e9e749ff05e33a331f580 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: vm status notifications
Piotr Kliczewski has posted comments on this change. Change subject: events: vm status notifications .. Patch Set 22: Build failure not related to this change. -- To view, visit https://gerrit.ovirt.org/38937 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I746299f9f1e2f49831a05072f19af1d242796276 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stompreactor: fix naming of default destination
Yaniv Bronhaim has posted comments on this change. Change subject: stompreactor: fix naming of default destination .. Patch Set 14: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40345 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fb12dc725930076c44ea9720605f6283df0ec46 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stompreactor: fix naming of default destination
Yaniv Bronhaim has posted comments on this change. Change subject: stompreactor: fix naming of default destination .. Patch Set 14: you can retrigger it http://jenkins.ovirt.org/gerrit_manual_trigger/ . just ran it, if its rebased it should be fine now -- To view, visit https://gerrit.ovirt.org/40345 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fb12dc725930076c44ea9720605f6283df0ec46 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stompreactor: fix naming of default destination
Piotr Kliczewski has posted comments on this change. Change subject: stompreactor: fix naming of default destination .. Patch Set 14: Build failure not related to this change. -- To view, visit https://gerrit.ovirt.org/40345 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fb12dc725930076c44ea9720605f6283df0ec46 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscliTests: add a test for connect with a timeout
Yeela Kaplan has posted comments on this change. Change subject: vdscliTests: add a test for connect with a timeout .. Patch Set 13: (3 comments) https://gerrit.ovirt.org/#/c/38806/13/tests/Makefile.am File tests/Makefile.am: Line 22: Line 23: SUBDIRS = \ Line 24: functional \ Line 25: devices \ Line 26: pki \ > Why do we still need this change? This is the vdscli path for vdsm certificates... Line 27: $(NULL) Line 28: Line 29: device_modules = \ Line 30:devices/parsing/complex_vm_tests.py \ https://gerrit.ovirt.org/#/c/38806/13/tests/pki/Makefile.am File tests/pki/Makefile.am: Line 1: # > Is this file still needed? It is needed because of the way vdscli works. Line 2: # Copyright 2015 Red Hat, Inc. Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by https://gerrit.ovirt.org/#/c/38806/13/tests/run_tests_local.sh.in File tests/run_tests_local.sh.in: Line 6: if [ ! -f @top_srcdir@/tests/server.crt ] || [ ! -f @top_srcdir@/tests/server.csr ] || [ ! -f @top_srcdir@/tests/server.key ] || [ ! -f @top_srcdir@/tests/other.crt ] || [ ! -f @top_srcdir@/tests/other.csr ] || [ ! -f @top_srcdir@/tests/other.key ]; then Line 7: @top_srcdir@/tests/makecert.sh Line 8: fi Line 9: Line 10: #cp @top_srcdir@/tests/server.key @top_srcdir@/tests/pki/keys/vdsmkey.pem > What is the reason for these comments? This is a mistake, will be fixed in next patch set. thanks. Line 11: #cp @top_srcdir@/tests/server.crt @top_srcdir@/tests/pki/certs/vdsmcert.pem Line 12: #cp @top_srcdir@/tests/server.crt @top_srcdir@/tests/pki/certs/cacert.pem Line 13: -- To view, visit https://gerrit.ovirt.org/38806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21793986338a00caa1163c7f9297d160a9d1fc45 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stompreactor: fix naming of default destination
Piotr Kliczewski has posted comments on this change. Change subject: stompreactor: fix naming of default destination .. Patch Set 14: Build failure not related to this change. -- To view, visit https://gerrit.ovirt.org/40345 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fb12dc725930076c44ea9720605f6283df0ec46 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: server side subscriptions
Yaniv Bronhaim has posted comments on this change. Change subject: stomp: server side subscriptions .. Patch Set 29: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ssl: m2crypto removal
Piotr Kliczewski has posted comments on this change. Change subject: ssl: m2crypto removal .. Patch Set 5: Do you see a value in having this backport or should I drop it? -- To view, visit https://gerrit.ovirt.org/40358 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: m2crypto removal
Yaniv Bronhaim has posted comments on this change. Change subject: ssl: m2crypto removal .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: client side subscription
Yaniv Bronhaim has posted comments on this change. Change subject: stomp: client side subscription .. Patch Set 30: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/36368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronheim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: m2crypto removal
automat...@ovirt.org has posted comments on this change. Change subject: ssl: m2crypto removal .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]:
Piotr Kliczewski has posted comments on this change. Change subject: .. Patch Set 8: Verified+1 Rebased and verified with latest engine. I based my event changes on top this patch and updated my vdsm. There are no issues with connecting. -- To view, visit https://gerrit.ovirt.org/39990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]:
automat...@ovirt.org has posted comments on this change. Change subject: .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: add a default timeout for client call
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: add a default timeout for client call .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41894 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf87de694c70260edba57b16ad4c12a8082a9346 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add a utility to create a socket
Yeela Kaplan has uploaded a new change for review.
Change subject: utils: add a utility to create a socket
..
utils: add a utility to create a socket
Needed for use both in jsonrpc unit tests
and jsonrpc migration
Change-Id: Ib66bf3c1d292cd25bb91ea2bf36c641ab6f68310
Signed-off-by: Yeela Kaplan
---
M lib/vdsm/utils.py
M tests/jsonRpcHelper.py
2 files changed, 19 insertions(+), 15 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/41893/1
diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py
index e4e7be1..1f75dae 100644
--- a/lib/vdsm/utils.py
+++ b/lib/vdsm/utils.py
@@ -47,11 +47,13 @@
import select
import shutil
import signal
+import socket
import stat
import string
import threading
import time
import vdsm.infra.zombiereaper as zombiereaper
+from M2Crypto import SSL
from cpopen import CPopen
from . import cmdutils
@@ -1282,3 +1284,15 @@
"""
count = int(n + size - 1) // size
return count * size
+
+
+def create_socket(host, port, sslctx=None, timeout=None):
+sock = None
+if sslctx:
+sock = SSL.Connection(sslctx.context)
+else:
+sock = socket.socket(socket.AF_INET,
+ socket.SOCK_STREAM)
+sock.settimeout(timeout)
+sock.connect((host, port))
+return sock
diff --git a/tests/jsonRpcHelper.py b/tests/jsonRpcHelper.py
index 2345f29..59e6267 100644
--- a/tests/jsonRpcHelper.py
+++ b/tests/jsonRpcHelper.py
@@ -26,7 +26,6 @@
from xmlrpclib import Transport, dumps, Fault
from contextlib import contextmanager
from itertools import product
-from M2Crypto import SSL
from rpc.bindingxmlrpc import BindingXMLRPC, XmlDetector
from yajsonrpc.betterAsyncore import Reactor
from yajsonrpc.stompreactor import StompDetector, StompRpcClient
@@ -37,6 +36,7 @@
from yajsonrpc import Notification
from protocoldetector import MultiProtocolAcceptor
from rpc.bindingjsonrpc import BindingJsonRpc
+from vdsm import utils
from sslhelper import DEAFAULT_SSL_CONTEXT
PERMUTATIONS = tuple(product((True, False), ("xml", "stomp")))
@@ -138,24 +138,14 @@
)
def clientFactory():
-return client(create_socket(
-sslctx,
+return client(utils.create_socket(
acceptor._host,
-acceptor._port
+acceptor._port,
+sslctx=sslctx,
+timeout=TIMEOUT
))
yield clientFactory
-
-
-def create_socket(sslctx, host, port):
-sock = None
-if sslctx:
-sock = SSL.Connection(sslctx.context)
-else:
-sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
-sock.settimeout(TIMEOUT)
-sock.connect((host, port))
-return sock
class XMLClient():
--
To view, visit https://gerrit.ovirt.org/41893
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib66bf3c1d292cd25bb91ea2bf36c641ab6f68310
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Use jsonrpc during migration of vms
automat...@ovirt.org has posted comments on this change. Change subject: migration: Use jsonrpc during migration of vms .. Patch Set 15: * Update tracker::#1112594::OK * Check Bug-Url::OK * Check Public Bug::#1112594::OK, public bug * Check Product::#1112594::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/36701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie38334e6cdcc4d7899bd5e836b3196567fc0bfd8 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpcvdscli: use subscription when creating a client
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpcvdscli: use subscription when creating a client .. Patch Set 7: * Update tracker::#1112594::OK * Check Bug-Url::OK * Check Public Bug::#1112594::OK, public bug * Check Product::#1112594::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33e1084a4016509aaf0e9e749ff05e33a331f580 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpcvdscli: create a client for vdsm with jsonrpc
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpcvdscli: create a client for vdsm with jsonrpc .. Patch Set 11: * Update tracker::#1112594::OK * Check Bug-Url::OK * Check Public Bug::#1112594::OK, public bug * Check Product::#1112594::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39203 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9dbd70d28968db1305628281015f7b2379c8058 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sslutils: move createSSLContext from clientIF
automat...@ovirt.org has posted comments on this change. Change subject: sslutils: move createSSLContext from clientIF .. Patch Set 15: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/36699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c7e324759892232d16a4913314f1dfa76ea85b8 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronheim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: add an option to create a stomp client
automat...@ovirt.org has posted comments on this change. Change subject: stomp: add an option to create a stomp client .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronheim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add a utility to create a socket
automat...@ovirt.org has posted comments on this change. Change subject: utils: add a utility to create a socket .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41893 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib66bf3c1d292cd25bb91ea2bf36c641ab6f68310 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
