Alon Bar-Lev has posted comments on this change. Change subject: serial console: add code to prepare the path ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41896/2/vdsm/clientIF.py File vdsm/clientIF.py: Line 127: constants.P_OVIRT_VMCONSOLES) Line 128: Line 129: try: Line 130: supervdsm.getProxy().prepareVmConsolePath( Line 131: constants.P_OVIRT_VMCONSOLES) > this is all-of-nothing. What if the dir exists, but has wrong permissions, I think that if it is not something that is expected the command should fail to avoid security issues... this directory should either be non exist or exit with ovirt-vmconsole ownership. you do this by mkstemp -d at /var/run, set permissions and then rename. Line 132: except OSError as e: Line 133: if e.errno != os.errno.EEXIST: Line 134: raise Line 135: -- To view, visit https://gerrit.ovirt.org/41896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f851d7f7233265d33896b3aad5604e84c8af53b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
