Change in vdsm[master]: gluster:cleanup: Remove unnecessary wrapper
automat...@ovirt.org has posted comments on this change. Change subject: gluster:cleanup: Remove unnecessary wrapper .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ff1b4f785f453a6fbf1660949db779712d88758 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Publish gluster get volume info
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Publish gluster get volume info .. Patch Set 9: * Update tracker::#1254499::OK * Check Bug-Url::OK * Check Public Bug::#1254499::OK, public bug * Check Product::#1254499::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c70e9afa2fd776dfd9c2767c2e83e7f179b5c2 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: remove unused and hide private functions
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: remove unused and hide private functions .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a93282b95f1d174192274c91c14c98e6f771c17 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Try to be nicer to other processes
Nir Soffer has posted comments on this change. Change subject: v2v: Try to be nicer to other processes .. Patch Set 5: Verified+1 This version is a rabase without any code change, copying verify flag. -- To view, visit https://gerrit.ovirt.org/43817 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id163844a5976384ca9e9a75d58a581645f08a89f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Try to be nicer to other processes
automat...@ovirt.org has posted comments on this change. Change subject: v2v: Try to be nicer to other processes .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43817 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id163844a5976384ca9e9a75d58a581645f08a89f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Require newer kernel version on el7
automat...@ovirt.org has posted comments on this change. Change subject: spec: Require newer kernel version on el7 .. Patch Set 2: * Update tracker::#980139::OK * Check Bug-Url::OK * Check Public Bug::#980139::OK, public bug * Check Product::#980139::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44851 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cdf2102fe567c6d087d9ef650d21ee34640a33a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Require newer libvirt version for el7
automat...@ovirt.org has posted comments on this change. Change subject: spec: Require newer libvirt version for el7 .. Patch Set 2: * Update tracker::#1251008::OK * Check Bug-Url::OK * Check Public Bug::#1251008::OK, public bug * Check Product::#1251008::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44834 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea42288e779ba8a63968087d1df27e0f3665e406 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Replace specific device sections with all_devs se...
Nir Soffer has posted comments on this change. Change subject: multipath: Replace specific device sections with all_devs section .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/44855 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If035b10558f8df37969ee694bfebd48068d2ee38 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Remove unneeded "features" configuration
Nir Soffer has posted comments on this change. Change subject: multipath: Remove unneeded "features" configuration .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/44943 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c77c5a3574e3dd7ec2f740e194a6e59efc46c2a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: remove an assertion from getBondingForNic
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: remove an assertion from getBondingForNic .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/45072/1/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 898 Line 899 Line 900 Line 901 Line 902 > This change is wrong. What is the likelihood that bondings, as implemented in the Linux kernel, began to accept NICs already enslaved to other bonds? I think we would not like to hear such news. I think (im)possible Linux bugs should not be caught in VDSM. Please not that we're not checking a user's configuration, this is no longer true (if it ever has). These functions are only convenience wrappers/accessors to information acquired from the kernel. -- To view, visit https://gerrit.ovirt.org/45072 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b39d3b0040c86a8c4c4babe4af03b9cf8f6bdd4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:cleanup: Remove unnecessary wrapper
Nir Soffer has posted comments on this change. Change subject: gluster:cleanup: Remove unnecessary wrapper .. Patch Set 3: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/45097/3//COMMIT_MSG Commit Message: Line 6: Line 7: gluster:cleanup: Remove unnecessary wrapper Line 8: Line 9: It seems that existing wrapper is redundant as it did not any logic to the Line 10: method. Hence, the decision to remove it. It seems? this wrapper *is* redundant :-) Line 11: Line 12: Change-Id: I9ff1b4f785f453a6fbf1660949db779712d88758 -- To view, visit https://gerrit.ovirt.org/45097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ff1b4f785f453a6fbf1660949db779712d88758 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Remove unneeded "features" configuration
automat...@ovirt.org has posted comments on this change. Change subject: multipath: Remove unneeded "features" configuration .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44943 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c77c5a3574e3dd7ec2f740e194a6e59efc46c2a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Replace specific device sections with all_devs se...
automat...@ovirt.org has posted comments on this change. Change subject: multipath: Replace specific device sections with all_devs section .. Patch Set 5: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#880738::ERROR, private bug * Check Public Bug::#1225162::OK, public bug * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44855 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If035b10558f8df37969ee694bfebd48068d2ee38 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:cleanup: Remove unnecessary wrapper
automat...@ovirt.org has posted comments on this change. Change subject: gluster:cleanup: Remove unnecessary wrapper .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ff1b4f785f453a6fbf1660949db779712d88758 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Publish gluster get volume info
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Publish gluster get volume info .. Patch Set 8: * Update tracker::#1254499::OK * Check Bug-Url::OK * Check Public Bug::#1254499::OK, public bug * Check Product::#1254499::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c70e9afa2fd776dfd9c2767c2e83e7f179b5c2 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multiapth: Require newer multiapth version
automat...@ovirt.org has posted comments on this change. Change subject: multiapth: Require newer multiapth version .. Patch Set 2: * Update tracker::#1255173::OK * Check Bug-Url::OK * Check Public Bug::#1255173::OK, public bug * Check Product::#1255173::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45115 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7baf2762166e93e6f458e8b380035bc9e2fd1bd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multiapth: Tell the user about backups
Nir Soffer has posted comments on this change. Change subject: multiapth: Tell the user about backups .. Patch Set 4: -Code-Review Verified+1 This version address Yeela comment, using more specific message. -- To view, visit https://gerrit.ovirt.org/44867 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e16c34c2a7410d78b7351fd0a6b7fc9c527d668 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: make getNicsVlanAndBondingForNetwork more readable, ...
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: make getNicsVlanAndBondingForNetwork more readable, drop asserts .. Patch Set 4: (1 comment) Hoping to make you change your mind :-) https://gerrit.ovirt.org/#/c/45095/4/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 917 Line 918 Line 919 Line 920 Line 921 > I guess your assumptions are correct, and having a test is great, but havin The whole point of rewriting the function was that we needed to remove the asserts (as you pointed out, they may be compiled out so they would be useless if semantics was incorrect) and maybe more importantly, figuring out what the heck the complicated code meant. After I understood (again) I replaced the asserts with (hopefully) better code, a long comment, an explanatory commit message that can be found by git blaming and a test covering the supported configurations. That's much more than what we usually have :-) The asserts' conditions have been tested by years of use in production (let me admit though that this function is not very important – but I envision it is moved to KernelConfig code, where it serves its purpose, sometime). Let me strees that unless the assumed network hierarchy ever changes, this code (as part of the whole VDSM networking subsystem) is correct. If this were systemd or kernel code, I would try much, much harder to make it even more readable and stuff it with assertions. I learned that VDSM, on the other hand, follows Pythonic intuition. Correctness follows from readability. I say, let's stick with this version :-) -- To view, visit https://gerrit.ovirt.org/45095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8535dbd29314c97e4519b160a47c9ea6489b5a3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multiapth: Require newer multiapth version
automat...@ovirt.org has posted comments on this change. Change subject: multiapth: Require newer multiapth version .. Patch Set 1: * Update tracker::#1255173::OK * Check Bug-Url::OK * Check Public Bug::#1255173::OK, public bug * Check Product::#1255173::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45115 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7baf2762166e93e6f458e8b380035bc9e2fd1bd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multiapth: Require newer multiapth version
Nir Soffer has posted comments on this change. Change subject: multiapth: Require newer multiapth version .. Patch Set 1: This patch is expected to fail on CI, since the fixed version is not available yet. -- To view, visit https://gerrit.ovirt.org/45115 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7baf2762166e93e6f458e8b380035bc9e2fd1bd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multiapth: Require newer multiapth version
Nir Soffer has uploaded a new change for review.
Change subject: multiapth: Require newer multiapth version
..
multiapth: Require newer multiapth version
Multipath did not identify iscsi devices correctly, so their session
recovery_tmo was not configured correctly. This caused slow failover
when path is having trouble, and may lead to blocking of multiple vdsm
threads for many minutes.
This issue was fixed in device-mapper-multipath-0.4.9-82.el7. We require
now this version.
Change-Id: Id7baf2762166e93e6f458e8b380035bc9e2fd1bd
Bug-Url: https://bugzilla.redhat.com/1255173
Relates-To: https://bugzilla.redhat.com/880738
Signed-off-by: Nir Soffer
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/45115/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 72e7df6..bc83d72 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -176,7 +176,7 @@
Requires: sanlock >= 2.8, sanlock-python
%if 0%{?rhel}
-Requires: device-mapper-multipath >= 0.4.9-68
+Requires: device-mapper-multipath >= 0.4.9-82
Requires: e2fsprogs
Requires: fence-agents-all
Requires: kernel >= 3.10.0-132.el7
--
To view, visit https://gerrit.ovirt.org/45115
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7baf2762166e93e6f458e8b380035bc9e2fd1bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Publish gluster get volume info
Nir Soffer has posted comments on this change. Change subject: gluster: Publish gluster get volume info .. Patch Set 7: Code-Review+1 Waiting for review from gluster folks. -- To view, visit https://gerrit.ovirt.org/45098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c70e9afa2fd776dfd9c2767c2e83e7f179b5c2 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfoTests: add a test for getNicsVlanAndBondingForNetwork
automat...@ovirt.org has posted comments on this change. Change subject: netinfoTests: add a test for getNicsVlanAndBondingForNetwork .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45112 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie196879ef7fd8ea54816cd090dead569c04c7f5b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: make getNicsVlanAndBondingForNetwork more readable, ...
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: make getNicsVlanAndBondingForNetwork more readable, drop asserts .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8535dbd29314c97e4519b160a47c9ea6489b5a3 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Publish gluster get volume info
Ala Hino has posted comments on this change. Change subject: gluster: Publish gluster get volume info .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/45098/6//COMMIT_MSG Commit Message: Line 7: gluster: Publish gluster get volume info Line 8: Line 9: In 3.6 we use glusterVolumeInfo API to get gluster volume info in order to Line 10: mount gluster to backup volume servers. glusterVolumeInfo API is defined in Line 11: vdsm/gluster/cli.py and is imported to supervdsm. \In vdsm/gluster/cli.py there > \In ? Done Line 12: are APIs that are used to manage gluster volumes; however, we don't want to Line 13: expose all these APIs in supervdsm unless gluster is used, while we do want to Line 14: expose getGlusterVolumeInfo. To achieve this goal, we expose RHEV_ENABLED Line 15: param. With this change, gluster API defined in vdsm/gluster/cli.py exposed on -- To view, visit https://gerrit.ovirt.org/45098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c70e9afa2fd776dfd9c2767c2e83e7f179b5c2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Publish gluster get volume info
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Publish gluster get volume info .. Patch Set 7: * Update tracker::#1254499::OK * Check Bug-Url::OK * Check Public Bug::#1254499::OK, public bug * Check Product::#1254499::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c70e9afa2fd776dfd9c2767c2e83e7f179b5c2 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Publish gluster get volume info
Nir Soffer has posted comments on this change. Change subject: gluster: Publish gluster get volume info .. Patch Set 6: (1 comment) Ok, lets remove that backslash the sneaked in https://gerrit.ovirt.org/#/c/45098/6//COMMIT_MSG Commit Message: Line 7: gluster: Publish gluster get volume info Line 8: Line 9: In 3.6 we use glusterVolumeInfo API to get gluster volume info in order to Line 10: mount gluster to backup volume servers. glusterVolumeInfo API is defined in Line 11: vdsm/gluster/cli.py and is imported to supervdsm. \In vdsm/gluster/cli.py there \In ? Line 12: are APIs that are used to manage gluster volumes; however, we don't want to Line 13: expose all these APIs in supervdsm unless gluster is used, while we do want to Line 14: expose getGlusterVolumeInfo. To achieve this goal, we expose RHEV_ENABLED Line 15: param. With this change, gluster API defined in vdsm/gluster/cli.py exposed on -- To view, visit https://gerrit.ovirt.org/45098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c70e9afa2fd776dfd9c2767c2e83e7f179b5c2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: make getNicsVlanAndBondingForNetwork more readable, ...
Nir Soffer has posted comments on this change. Change subject: netinfo: make getNicsVlanAndBondingForNetwork more readable, drop asserts .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/45095/4/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 917 Line 918 Line 919 Line 920 Line 921 > All asserts were correct under the assumption that I described in the new c I guess your assumptions are correct, and having a test is great, but having an assert or AssertionError that fail loudly if our assumptions are incorrect (maybe the bug in the kernel?) is even better. -- To view, visit https://gerrit.ovirt.org/45095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8535dbd29314c97e4519b160a47c9ea6489b5a3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Publish gluster get volume info
Ala Hino has posted comments on this change. Change subject: gluster: Publish gluster get volume info .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/45098/5//COMMIT_MSG Commit Message: Line 15: in supervdsm unless gluster is used, while we do want to Line 16: expose getGlusterVolumeInfo. Line 17: To achieve this goal, we expose RHEV_ENABLED param. Line 18: With this change, gluster API defined in vdsm/gluster/cli.py exposed Line 19: on supervdsm either when building with gluster or when building on RHEV. > Can you fix the formatting? Done Line 20: Line 21: Change-Id: Ib9c70e9afa2fd776dfd9c2767c2e83e7f179b5c2 Line 22: Bug-Url: https://bugzilla.redhat.com/1254499 -- To view, visit https://gerrit.ovirt.org/45098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c70e9afa2fd776dfd9c2767c2e83e7f179b5c2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Publish gluster get volume info
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Publish gluster get volume info .. Patch Set 6: * Update tracker::#1254499::OK * Check Bug-Url::OK * Check Public Bug::#1254499::OK, public bug * Check Product::#1254499::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c70e9afa2fd776dfd9c2767c2e83e7f179b5c2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: make getNicsVlanAndBondingForNetwork more readable, ...
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: make getNicsVlanAndBondingForNetwork more readable, drop asserts .. Patch Set 4: (1 comment) The checks are not necessary. One more thing to note: if a network doesn't exist, getNicsVlanAndBondingForNetwork raises IndexError. One caller is prepared to catch it, I'll check others (they should not reach it but let's be sure). https://gerrit.ovirt.org/#/c/45095/4/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 917 Line 918 Line 919 Line 920 Line 921 > Can you explain why this assert is not correct? All asserts were correct under the assumption that I described in the new comment: that there is at most a single hierarchy of a bridge, a VLAN and a bond, all of which may be missing, on top of NIC(s); the other ports are TUN devices. Since I am now pretty sure the assumption holds we don't need the asserts. To prove correctness of the function I wrote a (hopefully) comprehensive test, https://gerrit.ovirt.org/45112 -- To view, visit https://gerrit.ovirt.org/45095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8535dbd29314c97e4519b160a47c9ea6489b5a3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Write multipath.conf atomically
Nir Soffer has posted comments on this change. Change subject: multipath: Write multipath.conf atomically .. Patch Set 4: This is a rebase on previous patch, no code change since version 3. -- To view, visit https://gerrit.ovirt.org/44869 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I850d621b7cb09f2732b8b3eb2cb2897e87547ddb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Write multipath.conf atomically
Nir Soffer has posted comments on this change. Change subject: multipath: Write multipath.conf atomically .. Patch Set 4: -Code-Review Verified+1 -- To view, visit https://gerrit.ovirt.org/44869 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I850d621b7cb09f2732b8b3eb2cb2897e87547ddb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Write multipath.conf atomically
Nir Soffer has posted comments on this change. Change subject: multipath: Write multipath.conf atomically .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44869 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I850d621b7cb09f2732b8b3eb2cb2897e87547ddb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multiapth: Tell the user about backups
Nir Soffer has posted comments on this change. Change subject: multiapth: Tell the user about backups .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44867 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e16c34c2a7410d78b7351fd0a6b7fc9c527d668 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Publish gluster get volume info
Nir Soffer has posted comments on this change. Change subject: gluster: Publish gluster get volume info .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/45098/5//COMMIT_MSG Commit Message: Line 15: in supervdsm unless gluster is used, while we do want to Line 16: expose getGlusterVolumeInfo. Line 17: To achieve this goal, we expose RHEV_ENABLED param. Line 18: With this change, gluster API defined in vdsm/gluster/cli.py exposed Line 19: on supervdsm either when building with gluster or when building on RHEV. Can you fix the formatting? - Paragraphs separated by one empty line - Consistent line wrapping at 72 chars (or less). Vim will help you if you use this vimrc: https://github.com/nirs/home/blob/master/.vimrc Line 20: Line 21: Change-Id: Ib9c70e9afa2fd776dfd9c2767c2e83e7f179b5c2 Line 22: Bug-Url: https://bugzilla.redhat.com/1254499 -- To view, visit https://gerrit.ovirt.org/45098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c70e9afa2fd776dfd9c2767c2e83e7f179b5c2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: make getNicsVlanAndBondingForNetwork more readable, ...
Nir Soffer has posted comments on this change. Change subject: netinfo: make getNicsVlanAndBondingForNetwork more readable, drop asserts .. Patch Set 4: Code-Review-1 (1 comment) -1 for visibility https://gerrit.ovirt.org/#/c/45095/4/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 917 Line 918 Line 919 Line 920 Line 921 Can you explain why this assert is not correct? -- To view, visit https://gerrit.ovirt.org/45095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8535dbd29314c97e4519b160a47c9ea6489b5a3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Publish gluster get volume info
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Publish gluster get volume info .. Patch Set 5: * Update tracker::#1254499::OK * Check Bug-Url::OK * Check Public Bug::#1254499::OK, public bug * Check Product::#1254499::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c70e9afa2fd776dfd9c2767c2e83e7f179b5c2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: remove an assertion from getBondingForNic
Nir Soffer has posted comments on this change. Change subject: netinfo: remove an assertion from getBondingForNic .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/45072/1/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 898 Line 899 Line 900 Line 901 Line 902 This change is wrong. asserts are designed exactly for this use case; It is impossible to have more then one bonding, so we assert that this is indeed true. This assert protect us from the impossible, and document our intent. Without the assert, if our assumption is incorrect, we will silently ignore the reality. -- To view, visit https://gerrit.ovirt.org/45072 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b39d3b0040c86a8c4c4babe4af03b9cf8f6bdd4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Report librbd1 version also on Debian
Nir Soffer has posted comments on this change. Change subject: ceph: Report librbd1 version also on Debian .. Patch Set 2: Verified+1 Not tested on debian. -- To view, visit https://gerrit.ovirt.org/44730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic97979fd208364f3e2009ab29930702688a42d5a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: Live Merge: Fix pre-extension calculation for chunked drives
Nir Soffer has posted comments on this change. Change subject: Live Merge: Fix pre-extension calculation for chunked drives .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45058 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I959608dc2f5a71afca605610267478e8a16e2c4b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spmprotect: Switch from fencing by pid to fencing using syst...
Nir Soffer has posted comments on this change. Change subject: spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 7: Code-Review+1 Waiting for verification. -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Live merge: Update base size after live merge
Nir Soffer has posted comments on this change. Change subject: Live merge: Update base size after live merge .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45107 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic351d694ddeed5b4bf92a211c5d64fa6673b3221 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: virt: Introduce Vm._setVolumeSize helper
Nir Soffer has posted comments on this change. Change subject: virt: Introduce Vm._setVolumeSize helper .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41ae9d92b3d22cda342209d33a87c7163ab1e5d5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Live Merge: Allow extension of non-leaf raw volumes
Nir Soffer has posted comments on this change. Change subject: Live Merge: Allow extension of non-leaf raw volumes .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45105 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1918aa11876e9ebe9e43f6f95f3fff50c21b41c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: virt: Add _getVolumeInfo helper
Nir Soffer has posted comments on this change. Change subject: virt: Add _getVolumeInfo helper .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45104 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib67eecc4725ac272695a64fabefb969882d9c0e8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Replace misused asserts with InvalidConfiguration
Nir Soffer has abandoned this change. Change subject: netinfo: Replace misused asserts with InvalidConfiguration .. Abandoned Replaced by https://gerrit.ovirt.org/45072 and https://gerrit.ovirt.org/45095 -- To view, visit https://gerrit.ovirt.org/34361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I99ee49aa7e2364f57112e2452e3eab3940b6b00a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Replace misused asserts with InvalidConfiguration
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: Replace misused asserts with InvalidConfiguration .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/34361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99ee49aa7e2364f57112e2452e3eab3940b6b00a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Publish gluster get volume info
Nir Soffer has posted comments on this change. Change subject: gluster: Publish gluster get volume info .. Patch Set 4: Code-Review-1 -1 for visibility. -- To view, visit https://gerrit.ovirt.org/45098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c70e9afa2fd776dfd9c2767c2e83e7f179b5c2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:cleanup: Remove unnecessary wrapper
Nir Soffer has posted comments on this change. Change subject: gluster:cleanup: Remove unnecessary wrapper .. Patch Set 2: Code-Review-1 -1 for visibility. -- To view, visit https://gerrit.ovirt.org/45097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ff1b4f785f453a6fbf1660949db779712d88758 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactor v2v jobs for reusability
Nir Soffer has posted comments on this change. Change subject: Refactor v2v jobs for reusability .. Patch Set 3: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/44857 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida6b1c460c5030c820c540e836e423d4632410df Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:cleanup: Remove unnecessary wrapper
Nir Soffer has posted comments on this change. Change subject: gluster:cleanup: Remove unnecessary wrapper .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/45097/1//COMMIT_MSG Commit Message: Line 4: Commit: Ala Hino Line 5: CommitDate: 2015-08-19 18:03:26 +0300 Line 6: Line 7: gluster:cleanup: Remove unnecessary wrapper Line 8: Can you explain why it is unnecessary? Line 9: Change-Id: I9ff1b4f785f453a6fbf1660949db779712d88758 -- To view, visit https://gerrit.ovirt.org/45097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ff1b4f785f453a6fbf1660949db779712d88758 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Refactor v2v jobs for reusability
Nir Soffer has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 3:
(10 comments)
https://gerrit.ovirt.org/#/c/44857/3/vdsm/jobs.py
File vdsm/jobs.py:
Line 45: UNKNOWN: the job type is unknown
Line 46: V2V: the job is a v2v VM conversion job
Line 47: '''
Line 48: UNKNOWN = 'unknown'
Line 49: V2V = 'v2v'
We can remove this class now.
Line 50:
Line 51:
Line 52: class ClientError(Exception):
Line 53: ''' Base class for client error '''
Line 73: _JOB_TYPE = None
Line 74:
Line 75: def __init__(self, job_id, description=''):
Line 76: self._id = job_id
Line 77: self._status = STATUS.RUNNING
We should check with v2v guys that engine is not expecting the previous value
("starting"). If it does, I hope it is not too late to fix engine to use
the more generic term "running".
Line 78: self._description = description
Line 79:
Line 80: @property
Line 81: def id(self):
Line 115: May be implemented by child class
Line 116: """
Line 117:
Line 118:
Line 119: def clear():
Lets add a comment that this should be called only by the tests. To make it
more clear, we can make this private, like libvirtconnection._clear_connections.
Line 120: with _lock:
Line 121: _jobs.clear()
Line 122:
Line 123:
Line 120: with _lock:
Line 121: _jobs.clear()
Line 122:
Line 123:
Line 124: def delete_job(job_id):
> jobs.delete_job() looks redundant
I agree with Francesco, we don't need to repeat "job" in these names. This
module is dealing only with jobs.
Line 125: try:
Line 126: job = get_job(job_id)
Line 127: job.validate_not_running()
Line 128: _delete_job(job_id)
Line 150: ret[job_id] = {
Line 151: 'status': job.status,
Line 152: 'description': job.description,
Line 153: 'progress': job.progress,
Line 154: 'job_type': job.job_type,
This is better done in Job.info():
for job_id, job in items:
ret[job_id] = job.info()
Or since we support now only Python 2.7:
with _lock:
jobs = _jobs.values()
return {job.id: job.info() for job in jobs}
And implement info() in Job:
def info(self):
return {
'status': job.status,
'description': job.description,
'progress': job.progress,
'job_type': job.job_type,
}
This allows jobs to return additional job-specific info, for example,
v2v could return the name of the current disk and the progress
of the current disk.
Finally get_jobs_status() is incorrect, as this return job.status,
job.progress, etc. It should be called get_jobs_info() or get_jobs_stats().
This can be also done in a separate patch to keep this patch smaller.
Line 155: }
Line 156: return ret
Line 157:
Line 158:
Line 177: del _jobs[job_id]
Line 178:
Line 179:
Line 180: # Automatically initialize on first import
Line 181: clear()
> I prefer explicit initialization, but let's see what the other reviewers li
This is not needed now, as clear() is not initializing anything. It is only
need for the tests.
Everything is already initialized before line 180.
https://gerrit.ovirt.org/#/c/44857/3/vdsm/v2v.py
File vdsm/v2v.py:
Line 101
Line 102
Line 103
Line 104
Line 105
This is not a client error, but not related to your patch. Hopefully Shahar
will fix this later.
Line 45: import caps
Line 46: import jobs
Line 47:
Line 48:
Line 49: _V2V_JOB_TYPE = 'v2v'
Not needed, should be defined only in ImportVm._JOB_TYPE
Line 50: _V2V_DIR = os.path.join(P_VDSM_RUN, 'v2v')
Line 51: _VIRT_V2V = CommandPath('virt-v2v', '/usr/bin/virt-v2v')
Line 52: _OVF_RESOURCE_CPU = 3
Line 53: _OVF_RESOURCE_MEMORY = 4
Line 107:
Line 108: def get_jobs_status():
Line 109: all_jobs = jobs.get_jobs_status()
Line 110: return {job_id: status for (job_id, status) in all_jobs.items()
Line 111: if status['job_type'] == _V2V_JOB_TYPE}
> nice :)
Not nice, and not needed. job_type is set in jobs.get_jobs_status(), and this
extra step is not nice for the users of the jobs module.
Line 112:
Line 113:
Line 114: def get_external_vms(uri, username, password):
Line 115: if not supported():
Line 232: def __init__(self, vminfo, job_id, irs):
Line 233: '''
Line 234: do not use directly, use a factory method instead!
Line 235: '''
Line 236: jobs.Job.__init__(self, job_id)
> why not super()?
Right, we should use super more:
https://www.youtube.com/watch?v=EiOglTERPEo
Line 237: self._vminfo = vminfo
Line 238: self._irs = irs
Line 239:
Line 240: self._disk_progress = 0
--
To view, visit https://gerrit.ovirt.org/44857
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida6b1c460c5030c820c540e836e423d4632410df
Gerr
Change in vdsm[master]: multipath: Write multipath.conf atomically
automat...@ovirt.org has posted comments on this change. Change subject: multipath: Write multipath.conf atomically .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44869 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I850d621b7cb09f2732b8b3eb2cb2897e87547ddb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multiapth: Tell the user about backups
automat...@ovirt.org has posted comments on this change. Change subject: multiapth: Tell the user about backups .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/44867 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e16c34c2a7410d78b7351fd0a6b7fc9c527d668 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding check-patch ci script
David Caro has posted comments on this change. Change subject: Adding check-patch ci script .. Patch Set 1: This passes the tests locally, will create and tests the jenkins job tomorrow, let me know if you want to run anything else/different -- To view, visit https://gerrit.ovirt.org/45114 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife4cd928b480469a0b1ef4a583efc0d0e0b06989 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: David Caro Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding check-patch ci script
automat...@ovirt.org has posted comments on this change. Change subject: Adding check-patch ci script .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45114 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife4cd928b480469a0b1ef4a583efc0d0e0b06989 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: David Caro Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding check-patch ci script
David Caro has uploaded a new change for review.
Change subject: Adding check-patch ci script
..
Adding check-patch ci script
For now only runs the vdsm unit tests
Change-Id: Ife4cd928b480469a0b1ef4a583efc0d0e0b06989
Signed-off-by: David Caro
---
A automation/README
A automation/check-patch.packages
A automation/check-patch.sh
3 files changed, 79 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/45114/1
diff --git a/automation/README b/automation/README
new file mode 100644
index 000..5350e45
--- /dev/null
+++ b/automation/README
@@ -0,0 +1,4 @@
+Take a look to the [wiki] page on the details of what is in this directory and
+how it's used.
+
+[wiki]: http://www.ovirt.org/index.php?title=CI/Build_and_test_standards
diff --git a/automation/check-patch.packages b/automation/check-patch.packages
new file mode 100644
index 000..afe7069
--- /dev/null
+++ b/automation/check-patch.packages
@@ -0,0 +1,51 @@
+yum
+sudo
+dhclient
+autoreconf
+gettext-devel
+make
+automake
+pyflakes
+python-pep8
+libvirt-python
+python-blivet
+python-devel
+python-nose
+sanlock-python
+python-ordereddict
+python-pthreading
+libselinux-python
+python-ethtool
+m2crypto
+python-dmidecode
+python-netaddr
+python-inotify
+python-argparse
+git
+python-cpopen
+bridge-utils
+libguestfs-tools-c
+pyparted
+openssl
+libnl
+libtool
+gettext-devel
+python-ioprocess
+autoconf
+automake
+pyflakes
+logrotate
+gcc
+python-pep8
+libvirt-python
+python-devel
+python-nose
+rpm-build
+sanlock-python
+genisoimage
+libnl3
+policycoreutils-python
+python-simplejson
+python-blivet
+python-six
+mom
diff --git a/automation/check-patch.sh b/automation/check-patch.sh
new file mode 100755
index 000..065b6f4
--- /dev/null
+++ b/automation/check-patch.sh
@@ -0,0 +1,24 @@
+#!/bin/bash -e
+#
+# Run on each patch to gerrit, should be faster than check-meged and require
+# less resources but thorough enough to provide relevant feedback
+
+# Nose 1.3.0 and later segatult with this flag
+#export NOSE_WITH_XUNIT=1
+
+export NOSE_SKIP_STRESS_TESTS=1
+export NOSE_EXCLUDE=
+# disable pep8 checks on unit test, since we have seperate job on it.
+export PEP8=$(which true)
+
+# really ugly and hopefully temporary fix
+# https://bugzilla.redhat.com/show_bug.cgi?id=1255142
+[[ -e /dev/net/tun ]] \
+|| {
+[[ -e /dev/net ]] || mkdir /dev/net
+mknod /dev/net/tun c 10 200
+}
+
+sh -x autogen.sh --system
+make all
+make check
--
To view, visit https://gerrit.ovirt.org/45114
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife4cd928b480469a0b1ef4a583efc0d0e0b06989
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Caro
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:cleanup: Remove unnecessary wrapper
Ala Hino has posted comments on this change. Change subject: gluster:cleanup: Remove unnecessary wrapper .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/45097/1/vdsm/gluster/__init__.py File vdsm/gluster/__init__.py: Line 19 Line 20 Line 21 Line 22 Line 23 > I think you can remove now this import, as we do not @wraps anything. Done -- To view, visit https://gerrit.ovirt.org/45097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ff1b4f785f453a6fbf1660949db779712d88758 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:cleanup: Remove unnecessary wrapper
automat...@ovirt.org has posted comments on this change. Change subject: gluster:cleanup: Remove unnecessary wrapper .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ff1b4f785f453a6fbf1660949db779712d88758 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Publish gluster get volume info
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Publish gluster get volume info .. Patch Set 4: * Update tracker::#1254499::OK * Check Bug-Url::OK * Check Public Bug::#1254499::OK, public bug * Check Product::#1254499::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c70e9afa2fd776dfd9c2767c2e83e7f179b5c2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Support testPvCreate param in getDeviceList
Nir Soffer has posted comments on this change.
Change subject: hsm: Support testPvCreate param in getDeviceList
..
Patch Set 1:
(8 comments)
https://gerrit.ovirt.org/#/c/45093/1//COMMIT_MSG
Commit Message:
Line 6:
Line 7: hsm: Support testPvCreate param in getDeviceList
Line 8:
Line 9: Add optional 'testPvCreate' boolean parameter to getDeviceList.
Line 10: By default it will be True to keep same behavior as before.
Please explain why this is needed, and provide some measurements how this
effects the user experience on a system with lot of devices.
Line 11:
Line 12: If specified as False, the PV create test will be skipped and the
Line 13: 'status' field will not be populated.
Line 14:
https://gerrit.ovirt.org/#/c/45093/1/client/vdsClient.py
File client/vdsClient.py:
Line 735: elif len(args) == 1:
Line 736: res = self.s.getDeviceList(args[0])
Line 737: else:
Line 738: res = self.s.getDeviceList(args[0],
Line 739:utils.tobool(args[1]),
args[2:])
Check if utils.tobool(args[1]) can be on the first line, this indentation looks
strange.
Line 740:
Line 741: if res['status']['code']:
Line 742: return res['status']['code'], res['status']['message']
Line 743: pp.pprint(res['devList'])
Line 2282: ('[storageType]',
Line 2283:'[testPvCreate]',
Line 2284:'[]',
Line 2285:'List of all block devices (optionally -
matching '
Line 2286:'storageType, optionally - perform PV
create test '
update name
Line 2287:'optionally - of each device listed).',
Line 2288:'getDeviceList',
Line 2289:'return all devices',
Line 2290:'getDeviceList FCP',
https://gerrit.ovirt.org/#/c/45093/1/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 1487
Line 1488
Line 1489
Line 1490
Line 1491
This type should be updated now, as status is optional, or it may return third
value when status was not checked.
Line 1477: #
Line 1478: # @storageType: #optional Only return devices of this type
Line 1479: #
Line 1480: # @testPvCreate: #optional Indicates if PV creation test should be
performed
Line 1481: # (new in version 4.17)
Update to describe what this does instead of how.
Line 1482: #
Line 1483: # @guids:#optional Only return info on specific list of
block device
Line 1484: # GUIDs (new in version 4.17)
Line 1485: #
https://gerrit.ovirt.org/#/c/45093/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 1956: return pool.reconstructMaster(hostId, poolName, masterDom,
domDict,
Line 1957: masterVersion, leaseParams)
Line 1958:
Line 1959: @public
Line 1960: def getDeviceList(self, storageType=None, testPvCreate=True,
This is too specific, what we want is to check the device status, so lets call
this parameter checkStatus (or another name that explain what it does, and not
how it does it).
Line 1961: guids=(), options={}):
Line 1962: """
Line 1963: List all Block Devices.
Line 1964:
Line 1978: devices = self._getDeviceList(storageType=storageType,
Line 1979: testPvCreate=testPvCreate,
guids=guids)
Line 1980: return dict(devList=devices)
Line 1981:
Line 1982: def _getDeviceList(self, storageType=None, testPvCreate=True,
guids=()):
Update to new parameter name.
Line 1983: sdCache.refreshStorage()
Line 1984: typeFilter = lambda dev: True
Line 1985: if storageType:
Line 1986: if sd.storageType(storageType) ==
sd.type2name(sd.ISCSI_DOMAIN):
Line 2046: guid = dev['GUID']
Line 2047: if guid in free:
Line 2048: dev['status'] = "free"
Line 2049: elif guid in used:
Line 2050: dev['status'] = "used"
This will not report device status now when new engine call with
checkStatus=False, so the schema should be update to explain this behavior.
Or, you can report dev["status"] = "unknown", which simplifies the schema, and
probably makes the client code simpler.
Line 2051: else:
Line 2052: raise KeyError("pvcreate response foresight is "
Line 2053:"can not be determined for %s",
dev)
Line 2054:
--
To view, visit https://gerrit.ovirt.org/45093
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic28954708f2fd7c7b721aa7f9a0fb6e1a6019597
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland
Gerrit-Reviewer: Fr
Change in vdsm[master]: netinfo: remove unused and hide private functions
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: remove unused and hide private functions .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a93282b95f1d174192274c91c14c98e6f771c17 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfoTests: add a test for getNicsVlanAndBondingForNetwork
automat...@ovirt.org has posted comments on this change. Change subject: netinfoTests: add a test for getNicsVlanAndBondingForNetwork .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45112 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie196879ef7fd8ea54816cd090dead569c04c7f5b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: make getNicsVlanAndBondingForNetwork more readable, ...
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: make getNicsVlanAndBondingForNetwork more readable, drop asserts .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8535dbd29314c97e4519b160a47c9ea6489b5a3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: make getNicsVlanAndBondingForNetwork more readable, ...
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: make getNicsVlanAndBondingForNetwork more readable, drop asserts .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8535dbd29314c97e4519b160a47c9ea6489b5a3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfoTests: add a test for getNicsVlanAndBondingForNetwork
automat...@ovirt.org has posted comments on this change. Change subject: netinfoTests: add a test for getNicsVlanAndBondingForNetwork .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45112 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie196879ef7fd8ea54816cd090dead569c04c7f5b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfoTests: add a test for getNicsVlanAndBondingForNetwork
Ondřej Svoboda has uploaded a new change for review.
Change subject: netinfoTests: add a test for getNicsVlanAndBondingForNetwork
..
netinfoTests: add a test for getNicsVlanAndBondingForNetwork
Change-Id: Ie196879ef7fd8ea54816cd090dead569c04c7f5b
Signed-off-by: Ondřej Svoboda
---
M tests/netinfoTests.py
1 file changed, 93 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/45112/1
diff --git a/tests/netinfoTests.py b/tests/netinfoTests.py
index 94bf924..b3e4330 100644
--- a/tests/netinfoTests.py
+++ b/tests/netinfoTests.py
@@ -336,3 +336,96 @@
self.assertEqual(gateway, '12.34.56.1')
gateway = netinfo._get_gateway(DUPLICATED_GATEWAY, TEST_IFACE)
self.assertEqual(gateway, '12.34.56.1')
+
+def test_getNicsVlanAndBondingForNetwork(self):
+FAKE_NETINFO = {
+'networks': {
+'just-nic': {
+'bridged': False,
+'iface': 'eth0',
+
+'_expected_nics': ['eth0'],
+'_expected_vlan': None,
+'_expected_vlan_id': None,
+'_expected_bond': None,
+},
+'bond': {
+'bridged': False,
+'iface': 'bond0',
+
+'_expected_nics': ['eth1', 'eth2'],
+'_expected_vlan': None,
+'_expected_vlan_id': None,
+'_expected_bond': 'bond0',
+},
+'vlan': {
+'bridged': False,
+'iface': 'eth0.123',
+
+'_expected_nics': ['eth0'],
+'_expected_vlan': 'eth0.123',
+'_expected_vlan_id': '123',
+'_expected_bond': None,
+},
+'vlan-bond': {
+'bridged': False,
+'iface': 'bond0.99',
+
+'_expected_nics': ['eth1', 'eth2'],
+'_expected_vlan': 'bond0.99',
+'_expected_vlan_id': '99',
+'_expected_bond': 'bond0',
+},
+},
+'vlans': {
+'eth0.123': {
+'iface': 'eth0',
+'vlanid': '123',
+},
+'bond0.99': {
+'iface': 'bond0',
+'vlanid': '99',
+},
+},
+'bondings': {
+'bond0': {
+'slaves': ['eth1', 'eth2'],
+},
+},
+'nics': {
+'eth0': {},
+'eth1': {},
+'eth2': {},
+'vnet0': {}, # TUN device of a running VM
+},
+'bridges': {'not necessary': 'for the test'},
+}
+
+def _test():
+fake_netinfo = NetInfo(FAKE_NETINFO)
+
+for network, netdict in FAKE_NETINFO['networks'].iteritems():
+nics, vlan, vlan_id, bond = (
+fake_netinfo.getNicsVlanAndBondingForNetwork(network))
+self.assertEqual(nics, netdict['_expected_nics'])
+self.assertEqual(vlan, netdict['_expected_vlan'])
+self.assertEqual(vlan_id, netdict['_expected_vlan_id'])
+self.assertEqual(bond, netdict['_expected_bond'])
+
+def _convert_to_bridged():
+for network, netdict in FAKE_NETINFO['networks'].iteritems():
+netdict['bridged'] = True
+netdict['ports'] = [netdict['iface']]
+del netdict['iface']
+
+def _add_vnet0():
+for network, netdict in FAKE_NETINFO['networks'].iteritems():
+if netdict['bridged']:
+netdict['ports'].append('vnet0')
+netdict['_expected_nics'].append('vnet0')
+
+_test()
+_convert_to_bridged()
+_test()
+_add_vnet0()
+_test()
--
To view, visit https://gerrit.ovirt.org/45112
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie196879ef7fd8ea54816cd090dead569c04c7f5b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Live merge: Update base size after live merge
Adam Litke has uploaded a new change for review.
Change subject: Live merge: Update base size after live merge
..
Live merge: Update base size after live merge
When performing a live merge, data is copied from a top volume into a
base volume. If the top volume is larger than the base volume (which
can happen if the drive size was extended), libvirt will change the size
of the base volume to match that of the top volume. When synchronizing
metadata after the merge, we need to update the 'capacity' field of the
base volume to reflect the new size. We do this inside the
LiveMergeCleanupThread to ensure that it gets retried in the event of
storage connection problems or vdsm restarts.
Change-Id: Ic351d694ddeed5b4bf92a211c5d64fa6673b3221
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1251958
Signed-off-by: Adam Litke
---
M vdsm/virt/vm.py
1 file changed, 25 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/45107/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 6d8cccb..62f40e4 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -5741,7 +5741,7 @@
def queryBlockJobs(self):
def startCleanup(job, drive, needPivot):
-t = LiveMergeCleanupThread(self, job['jobID'], drive, needPivot)
+t = LiveMergeCleanupThread(self, job, drive, needPivot)
t.start()
self._liveMergeCleanupThreads[job['jobID']] = t
@@ -6087,11 +6087,11 @@
class LiveMergeCleanupThread(threading.Thread):
-def __init__(self, vm, jobId, drive, doPivot):
+def __init__(self, vm, job, drive, doPivot):
threading.Thread.__init__(self)
self.setDaemon(True)
self.vm = vm
-self.jobId = jobId
+self.job = job
self.drive = drive
self.doPivot = doPivot
self.success = False
@@ -6115,7 +6115,7 @@
self.vm.stopDisksStatsCollection()
self.vm.log.info("Requesting pivot to complete active layer commit "
- "(job %s)", self.jobId)
+ "(job %s)", self.job['jobID'])
try:
flags = libvirt.VIR_DOMAIN_BLOCK_JOB_ABORT_PIVOT
ret = self.vm._dom.blockJobAbort(self.drive.name, flags)
@@ -6125,22 +6125,39 @@
else:
if ret != 0:
self.vm.log.error("Pivot failed for job %s (rc=%i)",
- self.jobId, ret)
+ self.job['jobID'], ret)
raise RuntimeError("pivot failed")
self._waitForXMLUpdate()
-self.vm.log.info("Pivot completed (job %s)", self.jobId)
+self.vm.log.info("Pivot completed (job %s)", self.job['jobID'])
+
+def update_base_size(self):
+# If the drive size was extended just after creating the snapshot which
+# we are removing, the size of the top volume might be larger than the
+# size of the base volume. In that case libvirt has enlarged the base
+# volume automatically as part of the blockCommit operation. Update
+# our metadata to reflect this change.
+topVolUUID = self.job['topVolume']
+baseVolUUID = self.job['baseVolume']
+topVolInfo = self.vm._getVolumeInfo(self.drive.domainID,
+self.drive.poolID,
+self.drive.imageID, topVolUUID)
+self.vm._setVolumeSize(self.drive.domainID, self.drive.poolID,
+ self.drive.imageID, baseVolUUID,
+ topVolInfo['capacity'])
@utils.traceback()
def run(self):
+self.update_base_size()
if self.doPivot:
self.tryPivot()
self.vm.log.info("Synchronizing volume chain after live merge "
- "(job %s)", self.jobId)
+ "(job %s)", self.job['jobID'])
self.vm._syncVolumeChain(self.drive)
if self.doPivot:
self.vm.startDisksStatsCollection()
self.success = True
-self.vm.log.info("Synchronization completed (job %s)", self.jobId)
+self.vm.log.info("Synchronization completed (job %s)",
+ self.job['jobID'])
def isSuccessful(self):
"""
--
To view, visit https://gerrit.ovirt.org/45107
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic351d694ddeed5b4bf92a211c5d64fa6673b3221
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: virt: Add _getVolumeInfo helper
Adam Litke has posted comments on this change. Change subject: virt: Add _getVolumeInfo helper .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/45104 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib67eecc4725ac272695a64fabefb969882d9c0e8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: virt: Introduce Vm._setVolumeSize helper
Adam Litke has posted comments on this change. Change subject: virt: Introduce Vm._setVolumeSize helper .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/45106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41ae9d92b3d22cda342209d33a87c7163ab1e5d5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Live Merge: Allow extension of non-leaf raw volumes
Adam Litke has posted comments on this change. Change subject: Live Merge: Allow extension of non-leaf raw volumes .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/45105 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1918aa11876e9ebe9e43f6f95f3fff50c21b41c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Live merge: Update base size after live merge
Adam Litke has posted comments on this change. Change subject: Live merge: Update base size after live merge .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/45107 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic351d694ddeed5b4bf92a211c5d64fa6673b3221 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: virt: Introduce Vm._setVolumeSize helper
automat...@ovirt.org has posted comments on this change. Change subject: virt: Introduce Vm._setVolumeSize helper .. Patch Set 1: * Update tracker::#1251958::OK * Check Bug-Url::OK * Check Public Bug::#1251958::OK, public bug * Check Product::#1251958::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1251958::OK, correct target release 3.5.5 * warn_if_not_merged_to_previous_branch: OK -- To view, visit https://gerrit.ovirt.org/45106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41ae9d92b3d22cda342209d33a87c7163ab1e5d5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Live merge: Update base size after live merge
automat...@ovirt.org has posted comments on this change. Change subject: Live merge: Update base size after live merge .. Patch Set 1: * Update tracker::#1251958::OK * Check Bug-Url::OK * Check Public Bug::#1251958::OK, public bug * Check Product::#1251958::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1251958::OK, correct target release 3.5.5 * warn_if_not_merged_to_previous_branch: OK -- To view, visit https://gerrit.ovirt.org/45107 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic351d694ddeed5b4bf92a211c5d64fa6673b3221 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Live Merge: Allow extension of non-leaf raw volumes
automat...@ovirt.org has posted comments on this change. Change subject: Live Merge: Allow extension of non-leaf raw volumes .. Patch Set 1: * Update tracker::#1251958::OK * Check Bug-Url::OK * Check Public Bug::#1251958::OK, public bug * Check Product::#1251958::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1251958::OK, correct target release 3.5.5 * warn_if_not_merged_to_previous_branch: OK -- To view, visit https://gerrit.ovirt.org/45105 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1918aa11876e9ebe9e43f6f95f3fff50c21b41c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: virt: Add _getVolumeInfo helper
automat...@ovirt.org has posted comments on this change. Change subject: virt: Add _getVolumeInfo helper .. Patch Set 1: * Update tracker::#1251958::OK * Check Bug-Url::OK * Check Public Bug::#1251958::OK, public bug * Check Product::#1251958::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1251958::OK, correct target release 3.5.5 * warn_if_not_merged_to_previous_branch: OK -- To view, visit https://gerrit.ovirt.org/45104 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib67eecc4725ac272695a64fabefb969882d9c0e8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: virt: Introduce Vm._setVolumeSize helper
Adam Litke has uploaded a new change for review. Change subject: virt: Introduce Vm._setVolumeSize helper .. virt: Introduce Vm._setVolumeSize helper Backport the Vm._setVolumeSize helper for use by LiveMergeCleanupThread to update the size of the base volume in cases where the top volume was smaller than the base volume. Change-Id: I41ae9d92b3d22cda342209d33a87c7163ab1e5d5 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1251958 Signed-off-by: Adam Litke --- M vdsm/virt/vm.py 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/45106/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index e4f270d..6d8cccb 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -5917,6 +5917,14 @@ (domainID, volumeID)) return res['info'] +def _setVolumeSize(self, domainID, poolID, imageID, volumeID, size): +res = self.cif.irs.setVolumeSize(domainID, poolID, imageID, volumeID, + size) +if res['status']['code'] != 0: +raise StorageUnavailableError( +"Unable to set volume size to %s for domain %s volume %s" % +(size, domainID, volumeID)) + def _diskXMLGetVolumeChainInfo(self, diskXML, drive): def find_element_by_name(doc, name): for child in doc.childNodes: -- To view, visit https://gerrit.ovirt.org/45106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I41ae9d92b3d22cda342209d33a87c7163ab1e5d5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Live Merge: Allow extension of non-leaf raw volumes
Adam Litke has uploaded a new change for review.
Change subject: Live Merge: Allow extension of non-leaf raw volumes
..
Live Merge: Allow extension of non-leaf raw volumes
volume.extendSize() is currently prohibited for any non-leaf volume.
For a very specific live merge scenario we must permit extension of an
internal raw base volume. Allow this usage and add a comment explaining
the reasoning.
The scenario:
- User begins with a raw block disk.
- User creates a snapshot.
- User enlarges the disk (diskSizeExtend)
- User performs live merge to remove the snapshot
In this case the base volume is too small to accommodate the data
from the child volume and an error is raised since libvirt cannot
enlarge a block device. The solution is to require engine to call
extendVolumeSize on the base volume before requesting the live merge
operation.
Change-Id: Ia1918aa11876e9ebe9e43f6f95f3fff50c21b41c
Signed-off-by: Adam Litke
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1251958
---
M vdsm/storage/volume.py
1 file changed, 9 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/05/45105/1
diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py
index 75fa1c4..0cd6de6 100644
--- a/vdsm/storage/volume.py
+++ b/vdsm/storage/volume.py
@@ -548,11 +548,10 @@
"""
Extend the size (virtual disk size seen by the guest) of the volume.
"""
-if not self.isLeaf() or self.isShared():
+if self.isShared():
raise se.VolumeNonWritable(self.volUUID)
volFormat = self.getFormat()
-
if volFormat == COW_FORMAT:
self.log.debug("skipping cow size extension for volume %s to "
"size %s", self.volUUID, newSize)
@@ -560,6 +559,14 @@
elif volFormat != RAW_FORMAT:
raise se.IncorrectFormat(self.volUUID)
+# Note: This function previously prohibited extending non-leaf volumes.
+# If a disk is enlarged a volume may become larger than its parent. In
+# order to support live merge of a larger volume into its raw parent we
+# must permit extension of this raw volume prior to starting the merge.
+isBase = self.getParent() == BLANK_UUID
+if not (isBase or self.isLeaf()):
+raise se.VolumeNonWritable(self.volUUID)
+
curRawSize = self.getVolumeSize()
if (newSize < curRawSize):
--
To view, visit https://gerrit.ovirt.org/45105
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1918aa11876e9ebe9e43f6f95f3fff50c21b41c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: virt: Add _getVolumeInfo helper
Adam Litke has uploaded a new change for review.
Change subject: virt: Add _getVolumeInfo helper
..
virt: Add _getVolumeInfo helper
The next patch needs to call into to storage to get detailed volume size
information. Add a helper to encapsulate this operation which makes
error checking and exception raising consistent for all call sites.
Change-Id: Ib67eecc4725ac272695a64fabefb969882d9c0e8
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1251958
Signed-off-by: Adam Litke
---
M vdsm/virt/vm.py
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/45104/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index f813af7..e4f270d 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -5909,6 +5909,14 @@
return {'status': doneCode}
+def _getVolumeInfo(self, domainID, poolID, imageID, volumeID):
+res = self.cif.irs.getVolumeInfo(domainID, poolID, imageID, volumeID)
+if res['status']['code'] != 0:
+raise StorageUnavailableError(
+"Unable to get volume info for domain %s volume %s" %
+(domainID, volumeID))
+return res['info']
+
def _diskXMLGetVolumeChainInfo(self, diskXML, drive):
def find_element_by_name(doc, name):
for child in doc.childNodes:
--
To view, visit https://gerrit.ovirt.org/45104
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib67eecc4725ac272695a64fabefb969882d9c0e8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Publish gluster get volume info
Nir Soffer has posted comments on this change. Change subject: gluster: Publish gluster get volume info .. Patch Set 3: (1 comment) Looks good but needs better commit message. https://gerrit.ovirt.org/#/c/45098/3//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-08-19 18:07:32 +0300 Line 6: Line 7: gluster: Publish gluster get volume info Line 8: Line 9: Publish glusterGetVolumeInfo when RHEV enabled. Please explain what was the previous situation, and the new situation from the user point of view. Also explain why we always need glusterGetVolumeInfo. Line 10: Line 11: Change-Id: Ib9c70e9afa2fd776dfd9c2767c2e83e7f179b5c2 Line 12: Bug-Url: https://bugzilla.redhat.com/1254499 -- To view, visit https://gerrit.ovirt.org/45098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c70e9afa2fd776dfd9c2767c2e83e7f179b5c2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:cleanup: Remove unnecessary wrapper
Nir Soffer has posted comments on this change. Change subject: gluster:cleanup: Remove unnecessary wrapper .. Patch Set 1: Code-Review-1 (1 comment) Looks like you have unused import. https://gerrit.ovirt.org/#/c/45097/1/vdsm/gluster/__init__.py File vdsm/gluster/__init__.py: Line 19 Line 20 Line 21 Line 22 Line 23 I think you can remove now this import, as we do not @wraps anything. -- To view, visit https://gerrit.ovirt.org/45097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ff1b4f785f453a6fbf1660949db779712d88758 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Publish gluster get volume info
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Publish gluster get volume info .. Patch Set 2: * Update tracker::#1254499::OK * Check Bug-Url::OK * Check Public Bug::#1254499::OK, public bug * Check Product::#1254499::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c70e9afa2fd776dfd9c2767c2e83e7f179b5c2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Publish gluster get volume info
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Publish gluster get volume info .. Patch Set 3: * Update tracker::#1254499::OK * Check Bug-Url::OK * Check Public Bug::#1254499::OK, public bug * Check Product::#1254499::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c70e9afa2fd776dfd9c2767c2e83e7f179b5c2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:cleanup: Remove unnecessary wrapper
Ala Hino has uploaded a new change for review. Change subject: gluster:cleanup: Remove unnecessary wrapper .. gluster:cleanup: Remove unnecessary wrapper Change-Id: I9ff1b4f785f453a6fbf1660949db779712d88758 Signed-off-by: Ala Hino --- M vdsm/gluster/__init__.py 1 file changed, 2 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/45097/1 diff --git a/vdsm/gluster/__init__.py b/vdsm/gluster/__init__.py index 0566ceb..ee033a2 100644 --- a/vdsm/gluster/__init__.py +++ b/vdsm/gluster/__init__.py @@ -27,12 +27,8 @@ def makePublic(func): -@wraps(func) -def wrapper(*args, **kwargs): -return func(*args, **kwargs) - -wrapper.superVdsm = True -return wrapper +func.superVdsm = True +return func def listPublicFunctions(): -- To view, visit https://gerrit.ovirt.org/45097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9ff1b4f785f453a6fbf1660949db779712d88758 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Publish gluster get volume info
Ala Hino has uploaded a new change for review.
Change subject: gluster: Publish gluster get volume info
..
gluster: Publish gluster get volume info
Publish glusterGetVolumeInfo when RHEV enabled.
Change-Id: Ib9c70e9afa2fd776dfd9c2767c2e83e7f179b5c2
Bug-Url: https://bugzilla.redhat.com/1254499
Signed-off-by: Ala Hino
---
M lib/vdsm/constants.py.in
M vdsm.spec.in
M vdsm/gluster/__init__.py
M vdsm/gluster/cli.py
M vdsm/supervdsmServer
5 files changed, 24 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/45098/1
diff --git a/lib/vdsm/constants.py.in b/lib/vdsm/constants.py.in
index 0c85b9f..541786b 100644
--- a/lib/vdsm/constants.py.in
+++ b/lib/vdsm/constants.py.in
@@ -23,6 +23,8 @@
from __future__ import absolute_import
import os
+RHEV_ENABLED = False if '@RHEV_TRUE@' else True
+
# SMBIOS manufacturer
SMBIOS_MANUFACTURER = '@SMBIOS_MANUFACTURER@'
SMBIOS_OSNAME = '@SMBIOS_OSNAME@'
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 72e7df6..bafd953 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -982,14 +982,10 @@
%{_datadir}/%{vdsm_name}/kaxmlrpclib.py*
%{_datadir}/%{vdsm_name}/momIF.py*
%{_datadir}/%{vdsm_name}/set-conf-item
-%if 0%{?with_gluster}
%dir %{_datadir}/%{vdsm_name}/gluster
%{_datadir}/%{vdsm_name}/gluster/__init__.py*
%{_datadir}/%{vdsm_name}/gluster/cli.py*
%{_datadir}/%{vdsm_name}/gluster/exception.py*
-%else
-%exclude %{_datadir}/%{vdsm_name}/gluster/*
-%endif
%{python_sitelib}/sos/plugins/vdsm.py*
%{_udevrulesdir}/12-vdsm-lvm.rules
/etc/security/limits.d/99-vdsm.conf
diff --git a/vdsm/gluster/__init__.py b/vdsm/gluster/__init__.py
index ee033a2..8932bb2 100644
--- a/vdsm/gluster/__init__.py
+++ b/vdsm/gluster/__init__.py
@@ -31,14 +31,19 @@
return func
-def listPublicFunctions():
+def makePublicRHEV(func):
+func.superVdsmRHEV = True
+return func
+
+
+def listPublicFunctions(rhev=False):
methods = []
for modName in MODULE_LIST:
try:
module = __import__('gluster.' + modName, fromlist=['gluster'])
for name in dir(module):
func = getattr(module, name)
-if getattr(func, 'superVdsm', False):
+if _shouldPublish(func, rhev):
funcName = 'gluster%s%s' % (name[0].upper(), name[1:])
methods.append((funcName, func))
except ImportError:
@@ -46,6 +51,13 @@
return methods
+def _shouldPublish(func, rehv):
+if rhev:
+return getattr(func, 'superVdsmRHEV', False)
+else:
+return getattr(func, 'superVdsm', False)
+
+
def safeWrite(fileName, content):
with tempfile.NamedTemporaryFile(dir=os.path.dirname(fileName),
delete=False) as tmp:
diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py
index b35f09f..8ff050f 100644
--- a/vdsm/gluster/cli.py
+++ b/vdsm/gluster/cli.py
@@ -473,6 +473,7 @@
@makePublic
+@makePublicRHEV
def volumeInfo(volumeName=None, remoteServer=None):
"""
Returns:
diff --git a/vdsm/supervdsmServer b/vdsm/supervdsmServer
index e836368..a8a8c2a 100755
--- a/vdsm/supervdsmServer
+++ b/vdsm/supervdsmServer
@@ -65,6 +65,7 @@
from network.api import editNetwork, setupNetworks, setSafeNetworkConfig,\
change_numvfs
+from gluster import cliutils
from network.tc import setPortMirroring, unsetPortMirroring
from storage.multipath import getScsiSerial as _getScsiSerial
from storage.iscsi import getDevIscsiInfo as _getdeviSCSIinfo
@@ -76,7 +77,7 @@
from vdsm.constants import METADATA_GROUP, EXT_CHOWN, EXT_UDEVADM, \
DISKIMAGE_USER, DISKIMAGE_GROUP, \
P_LIBVIRT_VMCHANNELS, P_OVIRT_VMCONSOLES, \
-VDSM_USER, QEMU_PROCESS_USER, QEMU_PROCESS_GROUP
+VDSM_USER, QEMU_PROCESS_USER, QEMU_PROCESS_GROUP, RHEV_ENABLED
from storage.devicemapper import _removeMapping, _getPathsStatus
from vdsm.config import config
import mkimage
@@ -220,6 +221,10 @@
@logDecorator
def changeNumvfs(self, device_name, numvfs):
return change_numvfs(device_name, numvfs)
+
+@logDecorator
+def getGlusterVolumeInfo(volumeName=None, remoteServer=None):
+return cliutils.volumeInfo(volumeName, remoteServer)
def _runAs(self, user, groups, func, args=(), kwargs={}):
def child(pipe):
@@ -493,7 +498,7 @@
return wrapper
if _glusterEnabled:
-for name, func in listPublicFunctions():
+for name, func in listPublicFunctions(RHEV_ENABLED):
setattr(_SuperVdsm, name, logDecorator(bind(func)))
try:
--
To view, visit https://gerrit.ovirt.org/45098
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9c70e9afa2fd776dfd9c2767c2e83e7f179b5c2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino
___
vdsm-patches mailing list
vdsm-
Change in vdsm[master]: gluster:cleanup: Remove unnecessary wrapper
automat...@ovirt.org has posted comments on this change. Change subject: gluster:cleanup: Remove unnecessary wrapper .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ff1b4f785f453a6fbf1660949db779712d88758 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Publish gluster get volume info
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Publish gluster get volume info .. Patch Set 1: * Update tracker::#1254499::OK * Check Bug-Url::OK * Check Public Bug::#1254499::OK, public bug * Check Product::#1254499::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c70e9afa2fd776dfd9c2767c2e83e7f179b5c2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Replace misused asserts with InvalidConfiguration
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Replace misused asserts with InvalidConfiguration .. Patch Set 3: The patch can now be abandoned in favour of https://gerrit.ovirt.org/45072 and https://gerrit.ovirt.org/45095, both of which remove the asserts and try to make the affected functions more understandable. -- To view, visit https://gerrit.ovirt.org/34361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99ee49aa7e2364f57112e2452e3eab3940b6b00a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: remove unused and hide private functions
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: remove unused and hide private functions .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a93282b95f1d174192274c91c14c98e6f771c17 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: make getNicsVlanAndBondingForNetwork more readable, ...
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: make getNicsVlanAndBondingForNetwork more readable, drop asserts .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8535dbd29314c97e4519b160a47c9ea6489b5a3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: make getNicsVlanAndBondingForNetwork more readable, ...
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: make getNicsVlanAndBondingForNetwork more readable, drop asserts .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8535dbd29314c97e4519b160a47c9ea6489b5a3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: make getNicsVlanAndBondingForNetwork more readable, ...
Ondřej Svoboda has uploaded a new change for review. Change subject: netinfo: make getNicsVlanAndBondingForNetwork more readable, drop asserts .. netinfo: make getNicsVlanAndBondingForNetwork more readable, drop asserts The function serves a complex purpose of reporting constituent devices of a network (bridged or bridgeless). Notably, now it determines a VLAN's underlying device and tag from the NetInfo object instead of reading this wastefully, again. After the rewrite it still employs a (maybe surprising) shortcut to handle bridged and bridgeless networks alike and also a fall-through to traverse from top to bottom of a VLAN-bond-NIC(s) hierarchy (possibly with some of the virtual devices missing). It relies on an assumption that there is at most one such hierarchy. If the network is bridged, attached TUN devices are also reported. Change-Id: If8535dbd29314c97e4519b160a47c9ea6489b5a3 Signed-off-by: Ondřej Svoboda --- M lib/vdsm/netinfo.py 1 file changed, 21 insertions(+), 21 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/45095/1 diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py index b5e62f9..3c1e0f4 100644 --- a/lib/vdsm/netinfo.py +++ b/lib/vdsm/netinfo.py @@ -867,33 +867,33 @@ def getNicsVlanAndBondingForNetwork(self, network): vlan = None -vlanid = None -bonding = None -lnics = [] +vlan_id = None +bond = None +nics = [] if self.networks[network]['bridged']: ports = self.networks[network]['ports'] else: -ports = [] -interface = self.networks[network]['iface'] -ports.append(interface) +ports = [self.networks[network]['iface']] -for port in ports: -if port in self.vlans: -assert vlan is None -nic = _vlan_device(port) -vlanid = getVlanID(port) -vlan = port # vlan devices can have an arbitrary name -assert self.vlans[port]['iface'] == nic -port = nic -if port in self.bondings: -assert bonding is None -bonding = port -lnics += self.bondings[bonding]['slaves'] -elif port in self.nics: -lnics.append(port) +# If the network is bridged, it is assumed that at most one of its +# ports is connected to physical NIC(s) possibly through a VLAN and/or +# bonding device. Other ports (if present) are virtual NICs that belong +# to VMs (but they are also reported by the function). +for device in ports: +vlan_info = self.vlans.get(device) +if vlan_info: +vlan = device +vlan_id = vlan_info['vlanid'] +device = vlan_info['iface'] +bond_info = self.bondings.get(device) +if bond_info: +bond = device +nics += bond_info['slaves'] +elif device in self.nics: +nics.append(device) -return lnics, vlan, vlanid, bonding +return nics, vlan, vlan_id, bond @staticmethod def getDefaultMtu(): -- To view, visit https://gerrit.ovirt.org/45095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If8535dbd29314c97e4519b160a47c9ea6489b5a3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Support testPvCreate param in getDeviceList
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/45093
to review the following change.
Change subject: hsm: Support testPvCreate param in getDeviceList
..
hsm: Support testPvCreate param in getDeviceList
Add optional 'testPvCreate' boolean parameter to getDeviceList.
By default it will be True to keep same behavior as before.
If specified as False, the PV create test will be skipped and the
'status' field will not be populated.
Examples:
getDeviceList
return all devices
getDeviceList FCP
return only FCP devices
getDeviceList FCP True
return only FCP devices and perform PV create test
getDeviceList ISCSI False guid1 guid2
return info for guid1 and guid2, assuming ISCSI type
without performing PV create test
Change-Id: Ic28954708f2fd7c7b721aa7f9a0fb6e1a6019597
Bug-Url: https://bugzilla.redhat.com/1217401
Signed-off-by: Fred Rolland
---
M client/vdsClient.py
M vdsm/API.py
M vdsm/rpc/bindingxmlrpc.py
M vdsm/rpc/vdsmapi-schema.json
M vdsm/storage/hsm.py
5 files changed, 46 insertions(+), 27 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/45093/1
diff --git a/client/vdsClient.py b/client/vdsClient.py
index ce40974..c62321d 100755
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -732,8 +732,11 @@
def getDeviceList(self, args):
if len(args) == 0:
res = self.s.getDeviceList()
+elif len(args) == 1:
+res = self.s.getDeviceList(args[0])
else:
-res = self.s.getDeviceList(args[0], args[1:])
+res = self.s.getDeviceList(args[0],
+ utils.tobool(args[1]), args[2:])
if res['status']['code']:
return res['status']['code'], res['status']['message']
@@ -2277,16 +2280,22 @@
)),
'getDeviceList': (serv.getDeviceList,
('[storageType]',
+ '[testPvCreate]',
'[]',
'List of all block devices (optionally - matching '
- 'storageType, optionally - of each device listed).',
+ 'storageType, optionally - perform PV create test '
+ 'optionally - of each device listed).',
'getDeviceList',
'return all devices',
'getDeviceList FCP',
'return only FCP devices',
- 'getDeviceList ISCSI guid1 guid2',
+ 'getDeviceList FCP True',
+ 'return only FCP devices and perform ',
+ 'PV creation test',
+ 'getDeviceList ISCSI False guid1 guid2',
'return info for guid1 and guid2',
- ', assuming ISCSI type'
+ ', assuming ISCSI type and skip PV ',
+ 'creation test'
)),
'getDevicesVisibility': (serv.getDevicesVisibility,
('',
diff --git a/vdsm/API.py b/vdsm/API.py
index 66822a5..bbc3f03 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1679,8 +1679,8 @@
def getLVMVolumeGroups(self, storageType=None):
return self._irs.getVGList(storageType)
-def getDeviceList(self, storageType=None, guids=()):
-return self._irs.getDeviceList(storageType, guids)
+def getDeviceList(self, storageType=None, testPvCreate=True, guids=()):
+return self._irs.getDeviceList(storageType, testPvCreate, guids)
def getDevicesVisibility(self, guidList):
return self._irs.getDevicesVisibility(guidList)
diff --git a/vdsm/rpc/bindingxmlrpc.py b/vdsm/rpc/bindingxmlrpc.py
index 7f1da4f..b23643b 100644
--- a/vdsm/rpc/bindingxmlrpc.py
+++ b/vdsm/rpc/bindingxmlrpc.py
@@ -1029,9 +1029,10 @@
api = API.Global()
return api.getLVMVolumeGroups(storageType)
-def devicesGetList(self, storageType=None, guids=(), options=None):
+def devicesGetList(self, storageType=None, testPvCreate=True,
+ guids=(), options=None):
api = API.Global()
-res = api.getDeviceList(storageType, guids)
+res = api.getDeviceList(storageType, testPvCreate, guids)
return unprotect_passwords(res)
def devicesGetVisibility(self, guids, options=None):
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 4cac5ae..42b9c91 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -1477,6 +1477,9 @@
#
# @storageType: #optional Only return devices of this type
#
+# @testPvCreate: #optional Indicates if P
Change in vdsm[master]: hsm: Support testPvCreate param in getDeviceList
automat...@ovirt.org has posted comments on this change. Change subject: hsm: Support testPvCreate param in getDeviceList .. Patch Set 1: * Update tracker::#1217401::OK * Check Bug-Url::OK * Check Public Bug::#1217401::OK, public bug * Check Product::#1217401::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45093 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic28954708f2fd7c7b721aa7f9a0fb6e1a6019597 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: tests: rename Interface methods.
Dan Kenigsberg has posted comments on this change. Change subject: net: tests: rename Interface methods. .. Patch Set 2: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/44693 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c667c11d709f9f888554bb4800dabb61097828a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horacek Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: tests: rename Interface methods.
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: tests: rename Interface methods. .. net: tests: rename Interface methods. Now they correspond better to the iproute2 commands that they call Change-Id: I8c667c11d709f9f888554bb4800dabb61097828a Signed-off-by: Ido Barkan Reviewed-on: https://gerrit.ovirt.org/44693 Reviewed-by: Petr Horáček Reviewed-by: Dan Kenigsberg Continuous-Integration: Dan Kenigsberg --- M tests/nettestlib.py 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Ido Barkan: Verified Petr Horáček: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44693 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c667c11d709f9f888554bb4800dabb61097828a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horacek Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: tests: rename Interface methods.
automat...@ovirt.org has posted comments on this change. Change subject: net: tests: rename Interface methods. .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/44693 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c667c11d709f9f888554bb4800dabb61097828a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horacek Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix misleading XML log
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: fix misleading XML log .. vm: fix misleading XML log When VDSM is asked to create a new VM, among the other things, it builds the domain XML according to the configuration sent by client (aka Engine) and run the before_vm_start hook. This is done also on the dehibernating (aka migration from file) path, for no apparent good reason. This is wasteful and useless at best, and most likely misleading, because VDSM logs the XML it produced, which is *not* what is gonna be used in the dehibernation path. This patch fixes this issue loggging the XML which is actually about to be fed to libvirt, not the useless one regenerated by VDSM. Backport-To: 3.6 Change-Id: I50f5b8a51830c8ce2a098e4ac11dd1bd6a89aac3 Related-To: https://bugzilla.redhat.com/1190210 Related-To: https://bugzilla.redhat.com/1234197 Signed-off-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/44843 Reviewed-by: Dan Kenigsberg Continuous-Integration: Dan Kenigsberg --- M vdsm/virt/vm.py 1 file changed, 16 insertions(+), 7 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved; Passed CI tests Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/44843 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50f5b8a51830c8ce2a098e4ac11dd1bd6a89aac3 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: fix misleading XML log
automat...@ovirt.org has posted comments on this change. Change subject: vm: fix misleading XML log .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/44843 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50f5b8a51830c8ce2a098e4ac11dd1bd6a89aac3 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
