Nir Soffer has posted comments on this change. Change subject: netinfo: make getNicsVlanAndBondingForNetwork more readable, drop asserts ......................................................................
Patch Set 4: Code-Review-1 (1 comment) -1 for visibility https://gerrit.ovirt.org/#/c/45095/4/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 917 Line 918 Line 919 Line 920 Line 921 Can you explain why this assert is not correct? -- To view, visit https://gerrit.ovirt.org/45095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8535dbd29314c97e4519b160a47c9ea6489b5a3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
