date:20151021

Change in vdsm[master]: spec: Unbreak build on rhel

2015-10-21 Thread fromani

Francesco Romani has posted comments on this change.

Change subject: spec: Unbreak build on rhel
..


Patch Set 1: Code-Review+1

Strange, I'm sure I tried a recent build on RHEL without encountering this 
issue (but stumbling on https://gerrit.ovirt.org/#/c/47554/ instead)

-- 
To view, visit https://gerrit.ovirt.org/47583
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9649f224648aec7c6bf78fef24ec121ebae5e99
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Barak Korren 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Unbreak build on rhel

2015-10-21 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: spec: Unbreak build on rhel
..


Patch Set 1:

We don't have a bug, but I don't think we need one.

-- 
To view, visit https://gerrit.ovirt.org/47600
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9649f224648aec7c6bf78fef24ec121ebae5e99
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Unbreak build on rhel

2015-10-21 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: spec: Unbreak build on rhel
..


Patch Set 1: Verified+1

Verified on master.

-- 
To view, visit https://gerrit.ovirt.org/47600
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9649f224648aec7c6bf78fef24ec121ebae5e99
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Live Merge: Fix pre-extension calculation for chunked drives

2015-10-21 Thread alitke

Adam Litke has uploaded a new change for review.

Change subject: Live Merge: Fix pre-extension calculation for chunked drives
..

Live Merge: Fix pre-extension calculation for chunked drives

Live merge causes data to be written from the volume that will be
removed (top volume) into its parent (base volume).  If the base volume
is on a thinly-provisioned block device (ie. COW_FORMAT) then we need to
make sure the parent's LV is large enough to accomodate growth of the
qcow2 volume as a result of the writes.  The amount of growth can be
anywhere between 0 (if all writes are replacing old data) and the
allocated size of the top volume (if all writes target unallocated
blocks in the base volume).  If the top volume is the active layer the
amount of growth required could be more due to writes from the VM that
come after this calculation is performed.

To prevent live merge failures when the base volume's LV is too small we
request an extension to accomodate the worst case scenario and increase
the base volume's LV by the size of the top volume's LV plus one
additional chunk.  The LV will never be increased beyond the actual
capacity of the VM disk.

The old code extended the base volume's LV to the size of the top
volume's LV which does not cover all the possible scenarios.

After live merge completes, the base volume's LV may be larger than is
necessary.  This will not impact the VM but a manual cleanup step could
be used to reclaim some storage space.

Change-Id: I959608dc2f5a71afca605610267478e8a16e2c4b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1272077
Signed-off-by: Adam Litke 
---
M vdsm/virt/vm.py
1 file changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/47589/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index ef62bc8..4fbc089 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -5874,6 +5874,7 @@
 if res['info']['voltype'] == 'SHARED':
 self.log.error("merge: Refusing to merge into a shared volume")
 return errCode['mergeErr']
+baseSize = int(res['info']['apparentsize'])
 
 # Indicate that we expect libvirt to maintain the relative paths of
 # backing files.  This is necessary to ensure that a volume chain is
@@ -5927,10 +5928,11 @@
 # copy all the required data.  Normally we'd use monitoring to extend
 # the volume on-demand but internal watermark information is not being
 # reported by libvirt so we must do the full extension up front.  In
-# the worst case, we'll need to extend 'base' to the same size as 'top'
-# plus a bit more to accomodate additional writes to 'top' during the
-# live merge operation.
-self.extendDriveVolume(drive, baseVolUUID, topSize)
+# the worst case, the allocated size of 'base' should be increased by
+# the allocated size of 'top' plus one additional chunk to accomodate
+# additional writes to 'top' during the live merge operation.
+maxAlloc = baseSize + topSize
+self.extendDriveVolume(drive, baseVolUUID, maxAlloc)
 
 # Trigger the collection of stats before returning so that callers
 # of getVmStats after this returns will see the new job


-- 
To view, visit https://gerrit.ovirt.org/47589
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I959608dc2f5a71afca605610267478e8a16e2c4b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Live Merge: Fix pre-extension calculation for chunked drives

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: Live Merge: Fix pre-extension calculation for chunked drives
..


Patch Set 1:

* Update tracker::#1272077::OK
* Check Bug-Url::OK
* Check Public Bug::#1272077::OK, public bug
* Check Product::#1272077::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1272077::OK, correct target milestone ovirt-3.5.6
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/47589
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I959608dc2f5a71afca605610267478e8a16e2c4b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Live Merge: Fix pre-extension calculation for chunked drives

2015-10-21 Thread alitke

Adam Litke has posted comments on this change.

Change subject: Live Merge: Fix pre-extension calculation for chunked drives
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/47589
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I959608dc2f5a71afca605610267478e8a16e2c4b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Unbreak build on rhel

2015-10-21 Thread nsoffer

Hello Yaniv Bronhaim, Dan Kenigsberg, Francesco Romani,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/47600

to review the following change.

Change subject: spec: Unbreak build on rhel
..

spec: Unbreak build on rhel

centos is not defined, breaking the build on a rhel machine.

Change-Id: Ic9649f224648aec7c6bf78fef24ec121ebae5e99
Backport-To: 3.6
Backport-To: 3.5
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/47583
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/47600/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index e05be56..95702c6 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -176,7 +176,7 @@
 Requires: sanlock >= 2.8, sanlock-python
 
 %if 0%{?rhel}
-%if 0%{centos}
+%if 0%{?centos}
 Requires: device-mapper-multipath >= 0.4.9-68
 %else
 Requires: device-mapper-multipath >= 0.4.9-77.el7_1.2


-- 
To view, visit https://gerrit.ovirt.org/47600
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9649f224648aec7c6bf78fef24ec121ebae5e99
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: multiapth: Require newer multiapth version

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: multiapth: Require newer multiapth version
..


Patch Set 2:

* Update tracker::#1255173::OK
* Update tracker::#1256081::OK
* Set MODIFIED::bug 1255173#1255173IGNORE, not oVirt prod but Red Hat 
Enterprise Virtualization Manager
* Set MODIFIED::bug 1255173bug 1256081#1256081IGNORE, not oVirt 
prod but vdsm

-- 
To view, visit https://gerrit.ovirt.org/47578
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7baf2762166e93e6f458e8b380035bc9e2fd1bd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: multiapth: Require newer multiapth version

2015-10-21 Thread fromani

Francesco Romani has submitted this change and it was merged.

Change subject: multiapth: Require newer multiapth version
..


multiapth: Require newer multiapth version

Multipath did not identify iscsi devices correctly, so their session
recovery_tmo was not configured correctly. This caused slow failover
when path is having trouble, and may lead to blocking of multiple vdsm
threads for many minutes.

This issue was fixed in device-mapper-multipath in some of the supported
platforms:

platformversion #bugavailable
--
RHEL 7.20.4.9-82.el7bz1254292   yes
RHEL 7.10.4.9-77.el7_1.2bz1267131   yes
Fedora 22   0.4.9-73.fc22.1 bz1256074   yes
Fedora 21   0.4.9-68.fc21.6 bz1261141   no
CentOS  na  na  no

We require now new version where it is available. We will update the
requirement when the fix is available on other platforms.

Change-Id: Id7baf2762166e93e6f458e8b380035bc9e2fd1bd
Bug-Url: https://bugzilla.redhat.com/1255173
Bug-Url: https://bugzilla.redhat.com/1256081
Backport-To: 3.6
Backport-To: 3.5
Relates-To: https://bugzilla.redhat.com/880738
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/45115
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/47578
Reviewed-by: Francesco Romani 
---
M vdsm.spec.in
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/47578
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id7baf2762166e93e6f458e8b380035bc9e2fd1bd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: wip

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: wip
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47581
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia65f080bc794ccc6bf79b298829358ca12ab78ad
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Unbreak build on rhel

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: spec: Unbreak build on rhel
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47583
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9649f224648aec7c6bf78fef24ec121ebae5e99
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Unbreak build on rhel

2015-10-21 Thread nsoffer

Nir Soffer has uploaded a new change for review.

Change subject: spec: Unbreak build on rhel
..

spec: Unbreak build on rhel

centos is not defined, breaking the build on a rhel machine.

Change-Id: Ic9649f224648aec7c6bf78fef24ec121ebae5e99
Signed-off-by: Nir Soffer 
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/47583/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 6a46b56..32a1e38 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -176,7 +176,7 @@
 Requires: sanlock >= 2.8, sanlock-python
 
 %if 0%{?rhel}
-%if 0%{centos}
+%if 0%{?centos}
 Requires: device-mapper-multipath >= 0.4.9-68
 %else
 Requires: device-mapper-multipath >= 0.4.9-77.el7_1.2


-- 
To view, visit https://gerrit.ovirt.org/47583
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9649f224648aec7c6bf78fef24ec121ebae5e99
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Unbreak build on rhel

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: spec: Unbreak build on rhel
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47583
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9649f224648aec7c6bf78fef24ec121ebae5e99
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Barak Korren 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: profiling: move exceptions in a module

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: profiling: move exceptions in a module
..


Patch Set 1: Verified-1

* Update tracker::IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/47593
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b12ea00b1613c028b0de2aeee9a9d3cc7a3b1e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: multiapth: Require newer multiapth version

2015-10-21 Thread nsoffer

Hello Dan Kenigsberg,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/47582

to review the following change.

Change subject: multiapth: Require newer multiapth version
..

multiapth: Require newer multiapth version

Multipath did not identify iscsi devices correctly, so their session
recovery_tmo was not configured correctly. This caused slow failover
when path is having trouble, and may lead to blocking of multiple vdsm
threads for many minutes.

This issue was fixed in device-mapper-multipath in some of the supported
platforms:

platformversion #bugavailable
--
RHEL 7.20.4.9-82.el7bz1254292   yes
RHEL 7.10.4.9-77.el7_1.2bz1267131   yes
Fedora 22   0.4.9-73.fc22.1 bz1256074   yes
Fedora 21   0.4.9-68.fc21.6 bz1261141   no
CentOS  na  na  no

We require now new version where it is available. We will update the
requirement when the fix is available on other platforms.

Change-Id: Id7baf2762166e93e6f458e8b380035bc9e2fd1bd
Bug-Url: https://bugzilla.redhat.com/1255173
Bug-Url: https://bugzilla.redhat.com/1256081
Backport-To: 3.6
Backport-To: 3.5
Relates-To: https://bugzilla.redhat.com/880738
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/45115
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M vdsm.spec.in
1 file changed, 10 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/47582/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 6c31e9c..a401883 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -221,7 +221,11 @@
 %if 0%{?rhel}
 Requires: python-ethtool >= 0.6-3
 %if 0%{?rhel} >= 7
-Requires: device-mapper-multipath
+%if 0%{centos}
+Requires: device-mapper-multipath >= 0.4.9-68
+%else
+Requires: device-mapper-multipath >= 0.4.9-77.el7_1.2
+%endif
 Requires: e2fsprogs
 Requires: fence-agents-all
 Requires: lvm2
@@ -253,7 +257,11 @@
 Requires: python >= 2.7.3
 Requires: python-ethtool >= 0.8-1
 Requires: initscripts >= 9.42.2-1
-Requires: device-mapper-multipath >= 0.4.9-18
+%if 0%{?fedora} >= 22
+Requires: device-mapper-multipath >= 0.4.9-73.fc22.1
+%else
+Requires: device-mapper-multipath >= 0.4.9-56
+%endif
 Requires: e2fsprogs >= 1.41.14
 Requires: policycoreutils-python
 Requires: sed >= 4.2.1-10


-- 
To view, visit https://gerrit.ovirt.org/47582
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7baf2762166e93e6f458e8b380035bc9e2fd1bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: multiapth: Require newer multiapth version

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: multiapth: Require newer multiapth version
..


Patch Set 1:

* Update tracker::#1255173::OK
* Update tracker::#1256081::OK
* Check Bug-Url::OK
* Check Public Bug::#1255173::OK, public bug
* Check Public Bug::#1256081::OK, public bug
* Check Product::#1255173::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check Product::#1256081::OK, Correct classification oVirt
* Check TM::#1255173::ERROR, wrong target milestone for stable branch, 
ovirt-3.6.1 should match ^.*3.5.*
* Check TM::#1256081::ERROR, wrong target milestone for stable branch, 
ovirt-3.6.0-rc should match ^.*3.5.*
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/47582
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7baf2762166e93e6f458e8b380035bc9e2fd1bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Unbreak build on rhel

2015-10-21 Thread ybronhei

Yaniv Bronhaim has posted comments on this change.

Change subject: spec: Unbreak build on rhel
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/47583
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9649f224648aec7c6bf78fef24ec121ebae5e99
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Barak Korren 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Unbreak build on rhel

2015-10-21 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: spec: Unbreak build on rhel
..


Patch Set 1: Verified+1

Tested on rhel 7.1, built rpms and install them.

-- 
To view, visit https://gerrit.ovirt.org/47583
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9649f224648aec7c6bf78fef24ec121ebae5e99
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Barak Korren 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: profiling: import yappi outside lock

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: profiling: import yappi outside lock
..


Patch Set 1: Verified-1

* Update tracker::IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/47591
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31d69a70efce2348e2b74e5d8a20e81b2c598321
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: profiling: disambiguate profile identifiers

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: profiling: disambiguate profile identifiers
..


Patch Set 1: Verified-1

* Update tracker::IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/47592
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia43159009318295313855a16688b249982e40b34
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: profile: transform into a subpackage

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: profile: transform into a subpackage
..


Patch Set 1: Verified-1

* Update tracker::IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/47590
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idfd925e566a9af69d4b42a70fa835b072bb1f7a0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: WIP profiling: memory: port from dowser to tracemalloc

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: WIP profiling: memory: port from dowser to tracemalloc
..


Patch Set 1: Verified-1

* Update tracker::IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::WARN, Still missing on branches master, ovirt-3.6

-- 
To view, visit https://gerrit.ovirt.org/47595
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If00a3af13ea48bb75d40ed11e56de04d90452ff7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: profiling: add support for memory profiling

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: profiling: add support for memory profiling
..


Patch Set 1: Verified-1

* Update tracker::IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/47594
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib56b65513e0118b68cd43791bf655c928d6a26e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: WIP profiling: memory: profile snapshots in vdsClient

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: WIP profiling: memory: profile snapshots in vdsClient
..


Patch Set 1: Verified-1

* Update tracker::IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::WARN, Still missing on branches master, ovirt-3.6

-- 
To view, visit https://gerrit.ovirt.org/47596
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c7c5a074953bd54a8c2704d8aa2b074e277fdde
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Unbreak build on rhel

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: spec: Unbreak build on rhel
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47600
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9649f224648aec7c6bf78fef24ec121ebae5e99
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: multiapth: Require newer multiapth version

2015-10-21 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: multiapth: Require newer multiapth version
..


Patch Set 1: Verified+1

Verified by the CI rpm jobs.

-- 
To view, visit https://gerrit.ovirt.org/47582
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7baf2762166e93e6f458e8b380035bc9e2fd1bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: multiapth: Require newer multiapth version

2015-10-21 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: multiapth: Require newer multiapth version
..


Patch Set 1: Code-Review-1

(1 comment)

We need to fix the centos macro, or backport also https://gerrit.ovirt.org/47583

https://gerrit.ovirt.org/#/c/47582/1/vdsm.spec.in
File vdsm.spec.in:

Line 220: 
Line 221: %if 0%{?rhel}
Line 222: Requires: python-ethtool >= 0.6-3
Line 223: %if 0%{?rhel} >= 7
Line 224: %if 0%{centos}
Should be ?centos

Fixed in master by https://gerrit.ovirt.org/47583
Line 225: Requires: device-mapper-multipath >= 0.4.9-68
Line 226: %else
Line 227: Requires: device-mapper-multipath >= 0.4.9-77.el7_1.2
Line 228: %endif


-- 
To view, visit https://gerrit.ovirt.org/47582
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7baf2762166e93e6f458e8b380035bc9e2fd1bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Unbreak build on rhel

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: spec: Unbreak build on rhel
..


Patch Set 3:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/47583
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9649f224648aec7c6bf78fef24ec121ebae5e99
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Barak Korren 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Unbreak build on rhel

2015-10-21 Thread danken

Dan Kenigsberg has posted comments on this change.

Change subject: spec: Unbreak build on rhel
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/47583
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9649f224648aec7c6bf78fef24ec121ebae5e99
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Barak Korren 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Unbreak build on rhel

2015-10-21 Thread danken

Dan Kenigsberg has submitted this change and it was merged.

Change subject: spec: Unbreak build on rhel
..


spec: Unbreak build on rhel

centos is not defined, breaking the build on a rhel machine.

Change-Id: Ic9649f224648aec7c6bf78fef24ec121ebae5e99
Backport-To: 3.6
Backport-To: 3.5
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/47583
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Nir Soffer: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/47583
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9649f224648aec7c6bf78fef24ec121ebae5e99
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Barak Korren 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ssl: runtime config to choose implementation

2015-10-21 Thread danken

Dan Kenigsberg has posted comments on this change.

Change subject: ssl: runtime config to choose implementation
..


Patch Set 24: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/44689/24/vdsm.spec.in
File vdsm.spec.in:

Line 614: sed -i -e 's/^software_version =.*/software_version = 
"'"${baseversion}"'"/' \
Line 615:-e 's/^raw_version_revision =.*/raw_version_revision = 
"'"${rawversion}"'"/' \
Line 616:-e 's/^software_revision =.*/software_revision = 
"'"${baserelease}"'"/' vdsm/dsaversion.py
Line 617: 
Line 618: sed -i -e 's/@SSL_IMPLEMENTATION@/m2c/g' lib/vdsm/config.py
I don't mind doing this for the mean while. A future patch can make it a pretty 
flag to ./configure.
Line 619: 
Line 620: %install
Line 621: rm -rf %{buildroot}
Line 622: make DESTDIR=%{buildroot} install


-- 
To view, visit https://gerrit.ovirt.org/44689
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9881d11e30ced9c34bfe602bba3d968f57e0fe15
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Unbreak build on rhel

2015-10-21 Thread fromani

Francesco Romani has posted comments on this change.

Change subject: spec: Unbreak build on rhel
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/47600
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9649f224648aec7c6bf78fef24ec121ebae5e99
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: net: Support VLAN hardware offloading in hostQOS

2015-10-21 Thread ibarkan

Ido Barkan has posted comments on this change.

Change subject: net: Support VLAN hardware offloading in hostQOS
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/47443
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I667a9f38f4314da309685f6ba247f705a2e9c23e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: SRIOV API change.

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: net: SRIOV API change.
..


Patch Set 1:

* Update tracker::#1261352::OK
* Check Bug-Url::OK
* Check Public Bug::#1261352::OK, public bug
* Check Product::#1261352::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47618
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I689629380996e5615f41e5705fa1f8fb322e0214
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: SRIOV API change.

2015-10-21 Thread ibarkan

Ido Barkan has uploaded a new change for review.

Change subject: net: SRIOV API change.
..

net: SRIOV API change.

Before that patch, Vdsm API for attaching an SRIOV VF network device to
a VM was using type=hostdev. This caused SR-IOV network devices to be
reported twice (by _getUnderlyingNetworkInterfaceInfo) back to the
engine, and causing all sorts of UI bugs. Fixing the reporting API
also changes the way VDSM serializes it's data to the disk in order
to recover from a restart, and so, during recovery, a 'new' device is
deserialized, which VDSM cannot handle correctly.
As an example, since it is not a host device, but a network device,
it will not get detached from the host when the VM is powered off,
and we get a lost, unusable VF.
In order to fix this properly, the reporing API and the incoming API
must match. To do so, the SRIOV XML creation logic was moved into the
Interface device class, and the VM object was taught how to also
attach/detach SRIOV devices, when needed.

Change-Id: I689629380996e5615f41e5705fa1f8fb322e0214
Bug-Url: https://bugzilla.redhat.com/1261352
Signed-off-by: Ido Barkan 
---
M tests/hostdevTests.py
M vdsm/virt/vm.py
M vdsm/virt/vmdevices/hostdevice.py
M vdsm/virt/vmdevices/network.py
4 files changed, 87 insertions(+), 74 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/47618/1

diff --git a/tests/hostdevTests.py b/tests/hostdevTests.py
index 3dedd3a..49ee995 100644
--- a/tests/hostdevTests.py
+++ b/tests/hostdevTests.py
@@ -22,7 +22,7 @@
 import hostdev
 import vmfakelib as fake
 
-from virt.vmdevices import hostdevice
+from virt.vmdevices import hostdevice, network, hwclass
 
 from testlib import VdsmTestCase as TestCaseBase, XMLTestCase
 from testlib import permutations, expandPermutations
@@ -115,17 +115,17 @@
 _SRIOV_VF:
 '''
 
-
+%s
+
 
 
 
-
 
 
 
 
-%s
+
 
 '''}
 
@@ -407,23 +407,25 @@
 _DEVICE_XML[device_name] %
 (self._PCI_ADDRESS_XML))
 
+# TODO: next 2 tests should reside in their own module (interfaceTests.py)
+# TODO: add a simple non-SR-IOV interface test
 def testCreateSRIOVVF(self):
-dev_spec = {'type': 'hostdev', 'device': _SRIOV_VF,
-'specParams':
-{'macAddr': 'ff:ff:ff:ff:ff:ff', 'vlanid': 3},
+dev_spec = {'type': hwclass.NIC, 'device': 'hostdev',
+'hostdev': _SRIOV_VF, 'macAddr': 'ff:ff:ff:ff:ff:ff',
+'specParams': {'vlanid': 3},
 'bootOrder': '9'}
-device = hostdevice.HostDevice(self.conf, self.log, **dev_spec)
+device = network.Interface(self.conf, self.log, **dev_spec)
 self.assertXMLEqual(device.getXML().toxml(),
 _DEVICE_XML[_SRIOV_VF] % ('',))
 
 def testCreateSRIOVVFWithAddress(self):
-dev_spec = {'type': 'hostdev', 'device': _SRIOV_VF,
-'specParams':
-{'macAddr': 'ff:ff:ff:ff:ff:ff', 'vlanid': 3},
+dev_spec = {'type': hwclass.NIC, 'device': 'hostdev',
+'hostdev': _SRIOV_VF, 'macAddr': 'ff:ff:ff:ff:ff:ff',
+'specParams': {'vlanid': 3},
 'bootOrder': '9', 'address':
 {'slot': '0x02', 'bus': '0x01', 'domain': '0x',
  'function': '0x0', 'type': 'pci'}}
-device = hostdevice.HostDevice(self.conf, self.log, **dev_spec)
+device = network.Interface(self.conf, self.log, **dev_spec)
 self.assertXMLEqual(
 device.getXML().toxml(),
 _DEVICE_XML[_SRIOV_VF] % (self._PCI_ADDRESS_XML))
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 8a297e1..9be2c86 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1250,13 +1250,20 @@
 
 def _reattachHostDevices(self):
 # reattach host devices
-for dev in self._devices[hwclass.HOSTDEV]:
+for dev in self._passthru_host_devices():
 self.log.debug('Reattaching device %s to host.' % dev.device)
 try:
 hostdev.reattach_detachable(dev.device)
 except hostdev.NoIOMMUSupportException:
 self.log.exception('Could not reattach device %s back to host '
'due to missing IOMMU support.')
+
+def _passthru_host_devices(self):
+for device in self._devices[hwclass.HOSTDEV]:
+yield device
+for device in self._devices[hwclass.NIC]:
+if device.is_hostdevice:
+yield device
 
 def setDownStatus(self, code, exitReasonCode, exitMessage=''):
 if not exitMessage:
@@ -1818,7 +1825,7 @@
 # domDependentInit, after the migration is

Change in vdsm[master]: net: Support VLAN hardware offloading in hostQOS

2015-10-21 Thread ibarkan

Ido Barkan has posted comments on this change.

Change subject: net: Support VLAN hardware offloading in hostQOS
..


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/47332/9/vdsm/network/tc/filter.py
File vdsm/network/tc/filter.py:

Line 170: 
Line 171: def _parse_ematch_match(first_arg, tokens):
Line 172: data = {}
Line 173: if first_arg in ('random', 'loadavg_1', 'nf_mark', 'vlan', 
'sk_rcvbuf',
Line 174:  'sk_snd_queue'):
> need to forward-port recent 3.6 changes.
the forward-port will be done in this patch in order to preserve identical 
change IDs in both branches.
Line 175: data['object'] = first_arg
Line 176: for token in tokens:
Line 177: if token in ('eq', 'lt', 'gt'):
Line 178: data['relation'] = token


-- 
To view, visit https://gerrit.ovirt.org/47332
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I667a9f38f4314da309685f6ba247f705a2e9c23e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: SRIOV API change.

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: net: SRIOV API change.
..


Patch Set 3:

* Update tracker::#1261352::OK
* Check Bug-Url::OK
* Check Public Bug::#1261352::OK, public bug
* Check Product::#1261352::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47618
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I689629380996e5615f41e5705fa1f8fb322e0214
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Support VLAN hardware offloading in hostQOS

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: net: Support VLAN hardware offloading in hostQOS
..


Patch Set 10:

* Update tracker::#1271205::OK
* Check Bug-Url::OK
* Check Public Bug::#1271205::OK, public bug
* Check Product::#1271205::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47332
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I667a9f38f4314da309685f6ba247f705a2e9c23e
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: tests: test tc upper limit using iperf

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: net: tests: test tc upper limit using iperf
..


Patch Set 15:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/46449
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9348a09e331195695c16862ef986df3b4abfa991
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: add simple network namespace functions to ipwrapper

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: net: add simple network namespace functions to ipwrapper
..


Patch Set 11:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/46447
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b83c9635fba4feb4946ceba460f3ab8c09ad656
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: tests: support iperf3 for performance tests

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: net: tests: support iperf3 for performance tests
..


Patch Set 15:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/46448
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15657f8844d131c5444dd680b8de7aa1c4ec2638
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: add simple network namespace functions to ipwrapper

2015-10-21 Thread ibarkan

Ido Barkan has posted comments on this change.

Change subject: net: add simple network namespace functions to ipwrapper
..


Patch Set 11: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/46447
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b83c9635fba4feb4946ceba460f3ab8c09ad656
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netinfo: silence one more needless debug

2015-10-21 Thread danken

Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: silence one more needless debug
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/47550
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6bc13258f082f8632c532fd1b8ac4fa2c4898b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: WIP profiling: memory: profile snapshots in vdsClient

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: WIP profiling: memory: profile snapshots in vdsClient
..


Patch Set 2: Verified-1

* Update tracker::IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::WARN, Still missing on branches master, ovirt-3.6

-- 
To view, visit https://gerrit.ovirt.org/47596
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c7c5a074953bd54a8c2704d8aa2b074e277fdde
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: WIP profiling: memory: port from dowser to tracemalloc

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: WIP profiling: memory: port from dowser to tracemalloc
..


Patch Set 2: Verified-1

* Update tracker::IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::WARN, Still missing on branches master, ovirt-3.6

-- 
To view, visit https://gerrit.ovirt.org/47595
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If00a3af13ea48bb75d40ed11e56de04d90452ff7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridge: Fix logging in dispatch

2015-10-21 Thread danken

Dan Kenigsberg has posted comments on this change.

Change subject: bridge: Fix logging in dispatch
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/47545
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6053bb322143c260bd57102480655c7efe6d34c0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: [WIP] Automation scripts for running vdsm functional tests job

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: [WIP] Automation scripts for running vdsm functional tests job
..


Patch Set 4:

* Update tracker::IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/41928
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24b446d3ae38c944b5a28d56ed0965d0f2edc206
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Caro 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: [WIP] Automation scripts for running vdsm functional tests job

2015-10-21 Thread eedri

Eyal Edri has abandoned this change.

Change subject: [WIP] Automation scripts for running vdsm functional tests job
..


Abandoned

already implemented. see danken comment.

-- 
To view, visit https://gerrit.ovirt.org/41928
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I24b446d3ae38c944b5a28d56ed0965d0f2edc206
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Caro 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: SRIOV API change.

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: net: SRIOV API change.
..


Patch Set 2:

* Update tracker::#1261352::OK
* Check Bug-Url::OK
* Check Public Bug::#1261352::OK, public bug
* Check Product::#1261352::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47618
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I689629380996e5615f41e5705fa1f8fb322e0214
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Unbreak build on rhel

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: spec: Unbreak build on rhel
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/47600
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9649f224648aec7c6bf78fef24ec121ebae5e99
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: tests: Fix unmount in mkimage tests

2015-10-21 Thread fromani

Francesco Romani has posted comments on this change.

Change subject: tests: Fix unmount in mkimage tests
..


Patch Set 3:

CI scripts run manually

-- 
To view, visit https://gerrit.ovirt.org/47038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If68a378133757f86b534f65808b2212828d97228
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: utils: Add stopwatch for timing operations

2015-10-21 Thread fromani

Francesco Romani has posted comments on this change.

Change subject: utils: Add stopwatch for timing operations
..


Patch Set 3:

CI scripts run manually

-- 
To view, visit https://gerrit.ovirt.org/47039
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0a60538936dbb4596243abe9d731779fd9efb47
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: tests: Fix unmount in mkimage tests

2015-10-21 Thread fromani

Francesco Romani has posted comments on this change.

Change subject: tests: Fix unmount in mkimage tests
..


Patch Set 3: Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/47038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If68a378133757f86b534f65808b2212828d97228
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: tests: Fix and simplify cleanup after failures

2015-10-21 Thread fromani

Francesco Romani has posted comments on this change.

Change subject: tests: Fix and simplify cleanup after failures
..


Patch Set 2: Continuous-Integration+1 Verified+1

CI scripts run manually
verified running the test itself.

-- 
To view, visit https://gerrit.ovirt.org/47326
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae829de5ae37008eff3154ad97d5f86c92a41eb2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: tests: Wait for udev events after unmounting

2015-10-21 Thread fromani

Francesco Romani has posted comments on this change.

Change subject: tests: Wait for udev events after unmounting
..


Patch Set 3: Continuous-Integration+1 Verified+1

CI scripts run manually
verified running the test itself

-- 
To view, visit https://gerrit.ovirt.org/47040
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bd2737dae37f944cb314077a77b29c27db44677
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic

2015-10-21 Thread osvoboda

Ondřej Svoboda has posted comments on this change.

Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/46983/2/lib/vdsm/sysctl.py
File lib/vdsm/sysctl.py:

Line 37: def set_rp_filter_strict(dev):
Line 38: set_rp_filter(dev, _RPFILTER_STRICT)
Line 39: 
Line 40: 
Line 41: def toggle_ipv6(dev, enable):
> The term Toggle usually means "flip current state", which we don't want.
That's true. I'll go with the more neutral "set".
Line 42: with open('/proc/sys/net/ipv6/conf/%s/disable_ipv6' % dev, 'w') as 
f:
Line 43: f.write('0' if enable else '1')
Line 44: 
Line 45: 


-- 
To view, visit https://gerrit.ovirt.org/46983
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I154f22a5f59174d0e33235d252aa42e463760e04
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Unbreak build on rhel

2015-10-21 Thread fromani

Francesco Romani has submitted this change and it was merged.

Change subject: spec: Unbreak build on rhel
..


spec: Unbreak build on rhel

centos is not defined, breaking the build on a rhel machine.

Change-Id: Ic9649f224648aec7c6bf78fef24ec121ebae5e99
Backport-To: 3.6
Backport-To: 3.5
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/47583
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/47600
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/47600
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9649f224648aec7c6bf78fef24ec121ebae5e99
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic

2015-10-21 Thread danken

Dan Kenigsberg has posted comments on this change.

Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/46983/2/lib/vdsm/sysctl.py
File lib/vdsm/sysctl.py:

Line 37: def set_rp_filter_strict(dev):
Line 38: set_rp_filter(dev, _RPFILTER_STRICT)
Line 39: 
Line 40: 
Line 41: def toggle_ipv6(dev, enable):
The term Toggle usually means "flip current state", which we don't want.

How about Enable-ipv6? Set-ipv6?
Line 42: with open('/proc/sys/net/ipv6/conf/%s/disable_ipv6' % dev, 'w') as 
f:
Line 43: f.write('0' if enable else '1')
Line 44: 
Line 45: 


-- 
To view, visit https://gerrit.ovirt.org/46983
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I154f22a5f59174d0e33235d252aa42e463760e04
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic

2015-10-21 Thread osvoboda

Ondřej Svoboda has posted comments on this change.

Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/46983/2/lib/vdsm/sysctl.py
File lib/vdsm/sysctl.py:

Line 37: def set_rp_filter_strict(dev):
Line 38: set_rp_filter(dev, _RPFILTER_STRICT)
Line 39: 
Line 40: 
Line 41: def toggle_ipv6(dev, enable):
> That's true. I'll go with the more neutral "set".
Actually, "enable" is much better.
Line 42: with open('/proc/sys/net/ipv6/conf/%s/disable_ipv6' % dev, 'w') as 
f:
Line 43: f.write('0' if enable else '1')
Line 44: 
Line 45: 


-- 
To view, visit https://gerrit.ovirt.org/46983
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I154f22a5f59174d0e33235d252aa42e463760e04
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: utils: Add stopwatch for timing operations

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: utils: Add stopwatch for timing operations
..


Patch Set 4:

* Update tracker::#1267851::OK
* Set MODIFIED::bug 1267851#1267851IGNORE, not oVirt prod but vdsm

-- 
To view, visit https://gerrit.ovirt.org/47039
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0a60538936dbb4596243abe9d731779fd9efb47
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: utils: Add stopwatch for timing operations

2015-10-21 Thread fromani

Francesco Romani has submitted this change and it was merged.

Change subject: utils: Add stopwatch for timing operations
..


utils: Add stopwatch for timing operations

stopwatch is a context manager that make it easy to time block of code
that may take significant amount of time.

Example:

with stopwatch("Resized multipath map %r" % name):
_resize_map(name)

Will log a debug message:

Resized multipath map 'dm-42': 0.12 seconds

If debug log level is not enabled, this contents manager does nothing.
The log can be disabled by disabling the vds.stopwatch logger.

Change-Id: Ie0a60538936dbb4596243abe9d731779fd9efb47
Signed-off-by: Nir Soffer 
Bug-Url: https://bugzilla.redhat.com/1267851
Reviewed-on: https://gerrit.ovirt.org/29685
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Federico Simoncelli 
Reviewed-on: https://gerrit.ovirt.org/47039
Tested-by: Francesco Romani 
Reviewed-by: Dan Kenigsberg 
Continuous-Integration: Francesco Romani 
---
M lib/vdsm/utils.py
M tests/utilsTests.py
2 files changed, 65 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/47039
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0a60538936dbb4596243abe9d731779fd9efb47
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: tests: Fix unmount in mkimage tests

2015-10-21 Thread fromani

Francesco Romani has submitted this change and it was merged.

Change subject: tests: Fix unmount in mkimage tests
..


tests: Fix unmount in mkimage tests

These tests seem to fail too much lately. Inspecting the code reveal
that we use freeloop=True in mkimage, but do not use this flag in the
tests. This lead to consuming of all available loop devices, causing
later mount attempts to fail.

Change-Id: If68a378133757f86b534f65808b2212828d97228
Signed-off-by: Nir Soffer 
Bug-Url: https://bugzilla.redhat.com/1267851
Reviewed-on: https://gerrit.ovirt.org/46336
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski 
Reviewed-by: Petr Horáček 
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/47038
Tested-by: Francesco Romani 
Continuous-Integration: Francesco Romani 
---
M tests/mkimageTests.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/47038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If68a378133757f86b534f65808b2212828d97228
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: tests: Fix and simplify cleanup after failures

2015-10-21 Thread fromani

Francesco Romani has submitted this change and it was merged.

Change subject: tests: Fix and simplify cleanup after failures
..


tests: Fix and simplify cleanup after failures

If mount or umount failed, temporary images were not removed because of
incorrect cleanup code. This was not an issue since the temporary files
were created in a temporary directory, but we had two of them, so
failures to remove the first would leave also the second.

This patch simplify cleanup by removing the incorrect cleanup of the
temporary images, as they are removed anyway when the temporary
directory is removed.

Instead of two temporary directories, we use now one directory, and
create the two subdirectories inside it. Now we have to remove only one
directory in tearDown. To make it easier to debug, the temporary
directory is created with a prefix.

Change-Id: Iae829de5ae37008eff3154ad97d5f86c92a41eb2
Bug-Url: https://bugzilla.redhat.com/1267851
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/46387
Continuous-Integration: Jenkins CI
Reviewed-by: Shmuel Leib Melamud 
Reviewed-by: Sandro Bonazzola 
Reviewed-by: Piotr Kliczewski 
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/47326
Continuous-Integration: Francesco Romani 
Tested-by: Francesco Romani 
Reviewed-by: Francesco Romani 
---
M tests/mkimageTests.py
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Francesco Romani: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/47326
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iae829de5ae37008eff3154ad97d5f86c92a41eb2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: support ipv6addrs in IPv6 hook and Open vSwitch hook

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: hooks: support ipv6addrs in IPv6 hook and Open vSwitch hook
..


Patch Set 9:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/39359
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I722d0007840060cdccdb12e4fba2a2066f33c62f
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: tests: Fix unmount in mkimage tests

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: tests: Fix unmount in mkimage tests
..


Patch Set 4:

* Update tracker::#1267851::OK
* Set MODIFIED::bug 1267851#1267851IGNORE, not oVirt prod but vdsm

-- 
To view, visit https://gerrit.ovirt.org/47038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If68a378133757f86b534f65808b2212828d97228
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: tests: Fix and simplify cleanup after failures

2015-10-21 Thread fromani

Francesco Romani has posted comments on this change.

Change subject: tests: Fix and simplify cleanup after failures
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/47326
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae829de5ae37008eff3154ad97d5f86c92a41eb2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: api: support multiple 'ipv6addrs' per network

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: api: support multiple 'ipv6addrs' per network
..


Patch Set 10:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/39307
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8d16083781919fe5e5d9c75e9dd4ab744afe45be
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: support ipv6addrs in IPv6 hook and Open vSwitch hook

2015-10-21 Thread osvoboda

Ondřej Svoboda has posted comments on this change.

Change subject: hooks: support ipv6addrs in IPv6 hook and Open vSwitch hook
..


Patch Set 1:

(1 comment)

One late answer from April.

https://gerrit.ovirt.org/#/c/39359/1/vdsm_hooks/ipv6/ipv6.py
File vdsm_hooks/ipv6/ipv6.py:

Line 33: hooking.write_json(setup_nets_config)
Line 34: 
Line 35: 
Line 36: def _process_network(attrs):
Line 37: for property_name in ('ipv6addrs', 'ipv6addr', 'ipv6gateway',
> how does it go? don't you need an ipv6gateway per ipv6 address?
Other than IPv6 source routing? It may come as an extension but let's go step 
by step. If I did not understand please specify the need for multiple 
(seemingly undistinguishable) gateways.
Line 38:   'ipv6autoconf', 'dhcpv6'):
Line 39: value = attrs['custom'].get(property_name)
Line 40: if value is not None:
Line 41: attrs[property_name] = value


-- 
To view, visit https://gerrit.ovirt.org/39359
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I722d0007840060cdccdb12e4fba2a2066f33c62f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sysctl: turn disable_ipv6 into switch_ipv6 to simplify logic

2015-10-21 Thread osvoboda

Ondřej Svoboda has posted comments on this change.

Change subject: sysctl: turn disable_ipv6 into switch_ipv6 to simplify logic
..


Patch Set 3: Verified+1

I only renamed "toggle" to "switch" (and changed an extra comment).

-- 
To view, visit https://gerrit.ovirt.org/46983
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I154f22a5f59174d0e33235d252aa42e463760e04
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: tests: Fix and simplify cleanup after failures

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: tests: Fix and simplify cleanup after failures
..


Patch Set 3:

* Update tracker::#1267851::OK
* Set MODIFIED::bug 1267851#1267851IGNORE, not oVirt prod but vdsm

-- 
To view, visit https://gerrit.ovirt.org/47326
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae829de5ae37008eff3154ad97d5f86c92a41eb2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sysctl: turn disable_ipv6 into switch_ipv6 to simplify logic

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: sysctl: turn disable_ipv6 into switch_ipv6 to simplify logic
..


Patch Set 3:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/46983
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I154f22a5f59174d0e33235d252aa42e463760e04
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: takset: fix taskset and tests on python 2.6

2015-10-21 Thread fromani

Francesco Romani has posted comments on this change.

Change subject: takset: fix taskset and tests on python 2.6
..


Patch Set 7: Code-Review+2 Continuous-Integration+1

CI tests run manually

-- 
To view, visit https://gerrit.ovirt.org/47013
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7621a1443367bfead7b953df5218dea24bf8095a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: utils: Add stopwatch for timing operations

2015-10-21 Thread fromani

Francesco Romani has posted comments on this change.

Change subject: utils: Add stopwatch for timing operations
..


Patch Set 3: Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/47039
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0a60538936dbb4596243abe9d731779fd9efb47
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: tests: Wait for udev events after unmounting

2015-10-21 Thread fromani

Francesco Romani has posted comments on this change.

Change subject: tests: Wait for udev events after unmounting
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/47040
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bd2737dae37f944cb314077a77b29c27db44677
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: tests: test tc upper limit using iperf

2015-10-21 Thread ibarkan

Ido Barkan has posted comments on this change.

Change subject: net: tests: test tc upper limit using iperf
..


Patch Set 15: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/46449
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9348a09e331195695c16862ef986df3b4abfa991
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: tests: support iperf3 for performance tests

2015-10-21 Thread ibarkan

Ido Barkan has posted comments on this change.

Change subject: net: tests: support iperf3 for performance tests
..


Patch Set 15: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/46448
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15657f8844d131c5444dd680b8de7aa1c4ec2638
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Support VLAN hardware offloading in hostQOS

2015-10-21 Thread ibarkan

Ido Barkan has posted comments on this change.

Change subject: net: Support VLAN hardware offloading in hostQOS
..


Patch Set 10: Verified+1

forward-port I667a9f38f4314da309685f6ba247f705a2e9c23e

-- 
To view, visit https://gerrit.ovirt.org/47332
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I667a9f38f4314da309685f6ba247f705a2e9c23e
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: netinfo: rework reporting of DHCPv4/6 on network devices

2015-10-21 Thread ibarkan

Ido Barkan has posted comments on this change.

Change subject: netinfo: rework reporting of DHCPv4/6 on network devices
..


Patch Set 10: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/46430/10/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 576: 'dhcpv4': network_info['dhcpv4'],
Line 577: 'dhcpv6': network_info['dhcpv6'],
Line 578: 'cfg': cfg,
Line 579: }
Line 580: cfg['BOOTPROTO'] = 'dhcp' if network_info['dhcpv4'] else 
'none'
should be also marked with the same comment as in _update_reported_dhcp ?
Line 581: break
Line 582: 
Line 583: return updated_networking
Line 584: 


-- 
To view, visit https://gerrit.ovirt.org/46430
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaffdc836f8f64ecdc0a7e37ef50c228032f99696
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: service: change vdsm KillMode to mixed

2015-10-21 Thread ybronhei

Yaniv Bronhaim has posted comments on this change.

Change subject: service: change vdsm KillMode to mixed
..


Patch Set 6: -Code-Review

Don't you need to use killMode=process?  
http://www.freedesktop.org/software/systemd/man/systemd.kill.html - otherwise 
you send sigkill directly to all subprocesses.

don't we want vdsm to kill the ioprocesses?

-- 
To view, visit https://gerrit.ovirt.org/45038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dima Kuznetsov 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: DynamicBridge: Log TypeError exceptions raised during dispatch

2015-10-21 Thread alitke

Adam Litke has posted comments on this change.

Change subject: DynamicBridge: Log TypeError exceptions raised during dispatch
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/47546/1/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:

Line 33
Line 34
Line 35
Line 36
Line 37
> Not related
ahh right.  Mistakenly added by the previous patch.  Will remove it there,


-- 
To view, visit https://gerrit.ovirt.org/47546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27181f94a39fc77eb60f1464c06d173c38e19367
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Support VLAN hardware offloading in hostQOS

2015-10-21 Thread danken

Dan Kenigsberg has posted comments on this change.

Change subject: net: Support VLAN hardware offloading in hostQOS
..


Patch Set 9: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/47332/9/vdsm/network/tc/filter.py
File vdsm/network/tc/filter.py:

Line 170: 
Line 171: def _parse_ematch_match(first_arg, tokens):
Line 172: data = {}
Line 173: if first_arg in ('random', 'loadavg_1', 'nf_mark', 'vlan', 
'sk_rcvbuf',
Line 174:  'sk_snd_queue'):
need to forward-port recent 3.6 changes.
Line 175: data['object'] = first_arg
Line 176: for token in tokens:
Line 177: if token in ('eq', 'lt', 'gt'):
Line 178: data['relation'] = token


-- 
To view, visit https://gerrit.ovirt.org/47332
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I667a9f38f4314da309685f6ba247f705a2e9c23e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: DynamicBridge: Log TypeError exceptions raised during dispatch

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: DynamicBridge: Log TypeError exceptions raised during dispatch
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27181f94a39fc77eb60f1464c06d173c38e19367
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridge: Fix logging in dispatch

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: bridge: Fix logging in dispatch
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47545
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6053bb322143c260bd57102480655c7efe6d34c0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ssl: runtime config to choose implementation

2015-10-21 Thread ybronhei

Yaniv Bronhaim has posted comments on this change.

Change subject: ssl: runtime config to choose implementation
..


Patch Set 24: Code-Review+1

Acked it - but still consider to use different format than @something@ which is 
used by the .in files.. lets see what others will say about it

-- 
To view, visit https://gerrit.ovirt.org/44689
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9881d11e30ced9c34bfe602bba3d968f57e0fe15
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: DynamicBridge: Log TypeError exceptions raised during dispatch

2015-10-21 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: DynamicBridge: Log TypeError exceptions raised during dispatch
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/47546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27181f94a39fc77eb60f1464c06d173c38e19367
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: extract migration completion check

2015-10-21 Thread mbetak

Martin Betak has posted comments on this change.

Change subject: vm: extract migration completion check
..


Patch Set 7: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/47086
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1afb406e3e2ca7b37a621fc1bcc8bc1bf37031b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: multiapth: Require newer multiapth version

2015-10-21 Thread fromani

Francesco Romani has posted comments on this change.

Change subject: multiapth: Require newer multiapth version
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/47578
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7baf2762166e93e6f458e8b380035bc9e2fd1bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Fix duplicate SR-IOV device reported by vdsm

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: net: Fix duplicate SR-IOV device reported by vdsm
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47518
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2092624d2b755fdeb40535159754cca0c9406ee2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: spec: Require newer kernel version for RHEL

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: spec: Require newer kernel version for RHEL
..


Patch Set 5:

* Update tracker::#1273421::OK
* Set MODIFIED::bug 1273421#1273421IGNORE, not oVirt prod but Red Hat 
Enterprise Virtualization Manager

-- 
To view, visit https://gerrit.ovirt.org/47502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91c2c6b268d728ba6cee0232f72fe2459baa1ca2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: spec: Require newer kernel version for RHEL

2015-10-21 Thread fromani

Francesco Romani has posted comments on this change.

Change subject: spec: Require newer kernel version for RHEL
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/47502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91c2c6b268d728ba6cee0232f72fe2459baa1ca2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: spec: Require newer kernel version for RHEL

2015-10-21 Thread fromani

Francesco Romani has submitted this change and it was merged.

Change subject: spec: Require newer kernel version for RHEL
..


spec: Require newer kernel version for RHEL

iSCSI default replacement_timeout is 120 seconds, resulting in too slow
iSCSI failover in multipath setup. In vdsm, this may lead to blocking of
multiple unrelated vdsm threads for many minutes, when lvm, multipath
ore scsi scan operation blocks.

This issue was resolved in multipath (BZ1099932), by configuring iscsi
session recovery_tmo sysfs attribute to multipath fast_io_fail_tmo
value, (5 seconds in vdsm configuration). However, this configuration
was reverted to the default 120 seconds after a device went down an up
again, or after restart of the iscsid daemon (BZ1139038).

This issue was fixed in kernel 3.10.0-229.17.1.el7. In this version,
setting session recovery_tmo using sysfs overrides the default value
defined in iscsid configuration file.

This fix is not available in CentOS, so we require the new kernel only
for RHEL.

Change-Id: I91c2c6b268d728ba6cee0232f72fe2459baa1ca2
Bug-Url: https://bugzilla.redhat.com/1273421
Backport-To: 3.6
Backport-To: 3.5
Relates-To: https://bugzilla.redhat.com/1099932
Relates-To: https://bugzilla.redhat.com/1139038
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/47078
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/47502
---
M vdsm.spec.in
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/47502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I91c2c6b268d728ba6cee0232f72fe2459baa1ca2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Fix duplicate SR-IOV device reported by vdsm

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: net: Fix duplicate SR-IOV device reported by vdsm
..


Patch Set 3:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47518
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2092624d2b755fdeb40535159754cca0c9406ee2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: spec: fix requirement version

2015-10-21 Thread fromani

Francesco Romani has uploaded a new change for review.

Change subject: spec: fix requirement version
..

spec: fix requirement version

Fixes this build error:

rpmbuild -ba --define \"_topdir \$(pwd)/rpm\" rpm/SPECS/vdsm.spec"

=
Standard output
=

error: line 235: Invalid version (double separator '-'):
selinux-policy-3.13.1-16.el7: Requires: selinux-policy-targeted >=
selinux-policy-3.13.1-16.el7

Change-Id: I9c30c0be4295e2c306496a1c7bd8d0eb34c076b9
Bug-Url: https://bugzilla.redhat.com/1267851
Signed-off-by: Francesco Romani 
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/47554/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 6c31e9c..36e29da 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -232,7 +232,7 @@
 Requires: kernel >= 3.10.0-229.17.1.el7
 %endif
 Requires: policycoreutils-python
-Requires: selinux-policy-targeted >= selinux-policy-3.13.1-16.el7
+Requires: selinux-policy-targeted >= 3.13.1-16.el7
 %else
 Requires: python
 Requires: device-mapper-multipath >= 0.4.9-52


-- 
To view, visit https://gerrit.ovirt.org/47554
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c30c0be4295e2c306496a1c7bd8d0eb34c076b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: automation: add build_artifacts

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: automation: add build_artifacts
..


Patch Set 11:

* Update tracker::#1267851::OK
* Check Bug-Url::OK
* Check Public Bug::#1267851::OK, public bug
* Check Product::#1267851::OK, Correct classification oVirt
* Check TM::#1267851::OK, correct target milestone ovirt-3.5.6
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/46886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia29761aa2ec920db4485bf704926b67e0d9851b1
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: tests: Fix unmount in mkimage tests

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: tests: Fix unmount in mkimage tests
..


Patch Set 3:

* Update tracker::#1267851::OK
* Check Bug-Url::OK
* Check Public Bug::#1267851::OK, public bug
* Check Product::#1267851::OK, Correct classification oVirt
* Check TM::#1267851::OK, correct target milestone ovirt-3.5.6
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/47038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If68a378133757f86b534f65808b2212828d97228
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: automation: enable pep8

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: automation: enable pep8
..


Patch Set 10:

* Update tracker::#1267851::OK
* Check Bug-Url::OK
* Check Public Bug::#1267851::OK, public bug
* Check Product::#1267851::OK, Correct classification oVirt
* Check TM::#1267851::OK, correct target milestone ovirt-3.5.6
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/46885
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2266725af30e45b414d040f7f8d6b47d46bf947
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: utils: Add stopwatch for timing operations

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: utils: Add stopwatch for timing operations
..


Patch Set 3:

* Update tracker::#1267851::OK
* Check Bug-Url::OK
* Check Public Bug::#1267851::OK, public bug
* Check Product::#1267851::OK, Correct classification oVirt
* Check TM::#1267851::OK, correct target milestone ovirt-3.5.6
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/47039
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0a60538936dbb4596243abe9d731779fd9efb47
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Adding check-patch ci script

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: Adding check-patch ci script
..


Patch Set 10:

* Update tracker::#1267851::OK
* Check Bug-Url::OK
* Check Public Bug::#1267851::OK, public bug
* Check Product::#1267851::OK, Correct classification oVirt
* Check TM::#1267851::OK, correct target milestone ovirt-3.5.6
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/46883
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4cd928b480469a0b1ef4a583efc0d0e0b06989
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: tests: Fix and simplify cleanup after failures

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: tests: Fix and simplify cleanup after failures
..


Patch Set 2:

* Update tracker::#1267851::OK
* Check Bug-Url::OK
* Check Public Bug::#1267851::OK, public bug
* Check Product::#1267851::OK, Correct classification oVirt
* Check TM::#1267851::OK, correct target milestone ovirt-3.5.6
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/47326
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae829de5ae37008eff3154ad97d5f86c92a41eb2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: tests: Fix unsafe monkeypatching

2015-10-21 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: tests: Fix unsafe monkeypatching
..


Patch Set 4:

* Update tracker::IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/47208
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I479fbd03db65e4c9cfa63fe4fe101f1b4b4c3876
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

1 2 >

1 - 100 of 170 matches

Mail list logo