Change in vdsm[master]: sdm: Add create_volume job

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Add create_volume job
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50221
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia614059f52c9625da7841ea9fbca2b2f2375cd75
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: XXX: All outstanding VolumeMetadata changes squashed

[automation]

gerrit-hooks has posted comments on this change.

Change subject: XXX: All outstanding VolumeMetadata changes squashed
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50362
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5db8bb8bdf405b8760ecbe103dcbb1a1907ca1db
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fileSD: Do not try to remove non-existent lease file

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: fileSD: Do not try to remove non-existent lease file
..


Patch Set 1: Verified+1

Verified delete image on export domain and data domain:

On export domain:

jsonrpc.Executor/6::DEBUG::2015-12-16 
22:22:18,394::fileSD::208::Storage.StorageDomainManifest::(deleteImage) 
Renaming dir 
/rhev/data-center/mnt/dumbo.tlv.redhat.com:_export_voodoo_data-03/f2925ed9-6239-4c1d-a68b-695a0969a59d/images/bbf18142-fa7b-4f9b-9564-e7fe4536cb13
 to 
/rhev/data-center/mnt/dumbo.tlv.redhat.com:_export_voodoo_data-03/f2925ed9-6239-4c1d-a68b-695a0969a59d/images/_remove_me_bbf18142-fa7b-4f9b-9564-e7fe4536cb13
jsonrpc.Executor/6::DEBUG::2015-12-16 
22:22:18,416::fileSD::217::Storage.StorageDomainManifest::(deleteImage) 
Removing file: 
/rhev/data-center/mnt/dumbo.tlv.redhat.com:_export_voodoo_data-03/f2925ed9-6239-4c1d-a68b-695a0969a59d/images/_remove_me_bbf18142-fa7b-4f9b-9564-e7fe4536cb13/9d62cb38-21ca-44e2-b26c-d13fefa6398d
jsonrpc.Executor/6::DEBUG::2015-12-16 
22:22:18,449::fileSD::220::Storage.StorageDomainManifest::(deleteImage) 
Removing file: 
/rhev/data-center/mnt/dumbo.tlv.redhat.com:_export_voodoo_data-03/f2925ed9-6239-4c1d-a68b-695a0969a59d/images/_remove_me_bbf18142-fa7b-4f9b-9564-e7fe4536cb13/9d62cb38-21ca-44e2-b26c-d13fefa6398d.meta
jsonrpc.Executor/6::DEBUG::2015-12-16 
22:22:18,499::fileSD::217::Storage.StorageDomainManifest::(deleteImage) 
Removing file: 
/rhev/data-center/mnt/dumbo.tlv.redhat.com:_export_voodoo_data-03/f2925ed9-6239-4c1d-a68b-695a0969a59d/images/_remove_me_bbf18142-fa7b-4f9b-9564-e7fe4536cb13/58ba2ac6-c979-41b1-aedd-2e6965197439
jsonrpc.Executor/6::DEBUG::2015-12-16 
22:22:18,549::fileSD::220::Storage.StorageDomainManifest::(deleteImage) 
Removing file: 
/rhev/data-center/mnt/dumbo.tlv.redhat.com:_export_voodoo_data-03/f2925ed9-6239-4c1d-a68b-695a0969a59d/images/_remove_me_bbf18142-fa7b-4f9b-9564-e7fe4536cb13/58ba2ac6-c979-41b1-aedd-2e6965197439.meta
jsonrpc.Executor/6::DEBUG::2015-12-16 
22:22:18,583::fileSD::217::Storage.StorageDomainManifest::(deleteImage) 
Removing file: 
/rhev/data-center/mnt/dumbo.tlv.redhat.com:_export_voodoo_data-03/f2925ed9-6239-4c1d-a68b-695a0969a59d/images/_remove_me_bbf18142-fa7b-4f9b-9564-e7fe4536cb13/5587e99b-dbf6-45e6-ab07-df8774a148c4
jsonrpc.Executor/6::DEBUG::2015-12-16 
22:22:18,599::fileSD::220::Storage.StorageDomainManifest::(deleteImage) 
Removing file: 
/rhev/data-center/mnt/dumbo.tlv.redhat.com:_export_voodoo_data-03/f2925ed9-6239-4c1d-a68b-695a0969a59d/images/_remove_me_bbf18142-fa7b-4f9b-9564-e7fe4536cb13/5587e99b-dbf6-45e6-ab07-df8774a148c4.meta
jsonrpc.Executor/6::DEBUG::2015-12-16 
22:22:18,608::fileSD::229::Storage.StorageDomainManifest::(deleteImage) 
Removing directory: 
/rhev/data-center/mnt/dumbo.tlv.redhat.com:_export_voodoo_data-03/f2925ed9-6239-4c1d-a68b-695a0969a59d/images/_remove_me_bbf18142-fa7b-4f9b-9564-e7fe4536cb13


On data domain:

jsonrpc.Executor/3::DEBUG::2015-12-16 
22:24:00,920::fileSD::208::Storage.StorageDomainManifest::(deleteImage) 
Renaming dir /rhev/data-center/mnt/dumbo.tlv.redhat.com:_export
_voodoo_data-02/869b6036-a9ca-43eb-9287-828803822783/images/fb13c2b8-34ef-4e3d-9f1a-59f07256085a
 to /rhev/data-center/mnt/dumbo.tlv.redhat.com:_export_voodoo_data-02/869b603
6-a9ca-43eb-9287-828803822783/images/_remove_me_fb13c2b8-34ef-4e3d-9f1a-59f07256085a
jsonrpc.Executor/3::DEBUG::2015-12-16 
22:24:00,962::fileSD::217::Storage.StorageDomainManifest::(deleteImage) 
Removing file: /rhev/data-center/mnt/dumbo.tlv.redhat.com:_expo
rt_voodoo_data-02/869b6036-a9ca-43eb-9287-828803822783/images/_remove_me_fb13c2b8-34ef-4e3d-9f1a-59f07256085a/652f38bb-111f-48ff-b93a-20cd91c31c37
jsonrpc.Executor/3::DEBUG::2015-12-16 
22:24:00,971::fileSD::220::Storage.StorageDomainManifest::(deleteImage) 
Removing file: /rhev/data-center/mnt/dumbo.tlv.redhat.com:_expo
rt_voodoo_data-02/869b6036-a9ca-43eb-9287-828803822783/images/_remove_me_fb13c2b8-34ef-4e3d-9f1a-59f07256085a/652f38bb-111f-48ff-b93a-20cd91c31c37.meta
jsonrpc.Executor/3::DEBUG::2015-12-16 
22:24:00,979::fileSD::224::Storage.StorageDomainManifest::(deleteImage) 
Removing file: 
/rhev/data-center/mnt/dumbo.tlv.redhat.com:_export_voodoo_data-02/869b6036-a9ca-43eb-9287-828803822783/images/_remove_me_fb13c2b8-34ef-4e3d-9f1a-59f07256085a/652f38bb-111f-48ff-b93a-20cd91c31c37.lease
jsonrpc.Executor/3::DEBUG::2015-12-16 
22:24:00,987::fileSD::217::Storage.StorageDomainManifest::(deleteImage) 
Removing file: 
/rhev/data-center/mnt/dumbo.tlv.redhat.com:_export_voodoo_data-02/869b6036-a9ca-43eb-9287-828803822783/images/_remove_me_fb13c2b8-34ef-4e3d-9f1a-59f07256085a/a7c25f1b-9241-4124-aaed-a42d1471eaa4
jsonrpc.Executor/3::DEBUG::2015-12-16 
22:24:01,396::fileSD::220::Storage.StorageDomainManifest::(deleteImage) 
Removing file: 

Change in vdsm[master]: storage: add getHostId to DomainMonitor

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: add getHostId to DomainMonitor
..


Patch Set 1: Code-Review+1

I like it, waiting for other people reviews.

-- 
To view, visit https://gerrit.ovirt.org/50630
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add getHostId to DomainMonitor

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: add getHostId to DomainMonitor
..


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/50630/2//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2015-12-16 15:41:26 -0500
Line 6: 
Line 7: storage: add getHostId to DomainMonitor
Line 8: 
Line 9: Some SDM verbs need to acquire the domainLock during their job.  In 
Trailing whitespace
Line 10: order to do this they must be passed the domain's hostId property.  An 
Line 11: easy way to expose this is to add a getHostId method to the 
Line 12: DomainMonitor.
Line 13: 


Line 8: 
Line 9: Some SDM verbs need to acquire the domainLock during their job.  In 
Line 10: order to do this they must be passed the domain's hostId property.  An 
Line 11: easy way to expose this is to add a getHostId method to the 
Line 12: DomainMonitor.
Explain why we don't use:

   getPools()[0].id
Line 13: 
Line 14: Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c


-- 
To view, visit https://gerrit.ovirt.org/50630
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Add constants module to storage

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Add constants module to storage
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id14e79d400d6936c8bb0da5dec39e3f9fb60c803
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fileVolume: refactor _putMetadata to support volume artifacts

[automation]

gerrit-hooks has posted comments on this change.

Change subject: fileVolume: refactor _putMetadata to support volume artifacts
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49545
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5253b6692b8c58967bbd2c421abcce05c584d769
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagefakelib: Add FakeResourceManager

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storagefakelib: Add FakeResourceManager
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50340
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0302b48d984ce7eb8ce2326ab4bb033430c032f9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add getHostId to DomainMonitor

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: add getHostId to DomainMonitor
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50630
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Introduce VolumeArtifacts

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Introduce VolumeArtifacts
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I352423e39a899b9b83ccf3b8f6c17ec433e9c353
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add get_volume_artifacts_class to the domain manifest

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: add get_volume_artifacts_class to the domain manifest
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50339
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iade716f7487f502243aaf280a7a8c147f501307d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move VOLUME_PERMISSIONS to constants module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Move VOLUME_PERMISSIONS to constants module
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50631
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaeb2c902ff41e71266689b42323624f8e7a38ed8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: XXX: Add _getDeletedImagePath until patch merged

[automation]

gerrit-hooks has posted comments on this change.

Change subject: XXX: Add _getDeletedImagePath until patch merged
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50218
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd67cacc58da27ffda7286582e263195dac96894
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move VOLUME_PERMISSIONS to constants module

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: storage: Move VOLUME_PERMISSIONS to constants module
..

storage: Move VOLUME_PERMISSIONS to constants module

Change-Id: Iaeb2c902ff41e71266689b42323624f8e7a38ed8
Signed-off-by: Adam Litke 
---
M vdsm/storage/fileVolume.py
M vdsm/storage/storageConstants.py
2 files changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/50631/1

diff --git a/vdsm/storage/fileVolume.py b/vdsm/storage/fileVolume.py
index 60c990c..e870352 100644
--- a/vdsm/storage/fileVolume.py
+++ b/vdsm/storage/fileVolume.py
@@ -42,7 +42,6 @@
 LEASE_FILEOFFSET = 0
 
 BLOCK_SIZE = volume.BLOCK_SIZE
-VOLUME_PERMISSIONS = 0o660
 
 
 def getDomUuidFromVolumePath(volPath):
@@ -410,7 +409,8 @@
 
 try:
 oop.getProcessPool(dom.sdUUID).truncateFile(
-volPath, truncSize, mode=VOLUME_PERMISSIONS, creatExcl=True)
+volPath, truncSize,
+mode=storageConstants.FILE_VOLUME_PERMISSIONS, creatExcl=True)
 except OSError as e:
 if e.errno == errno.EEXIST:
 raise se.VolumeAlreadyExists(volUUID)
@@ -441,7 +441,7 @@
 
 # Forcing the volume permissions in case one of the tools we use
 # (dd, qemu-img, etc.) will mistakenly change the file permissiosn.
-dom.oop.os.chmod(volPath, VOLUME_PERMISSIONS)
+dom.oop.os.chmod(volPath, storageConstants.FILE_VOLUME_PERMISSIONS)
 
 return (volPath,)
 
diff --git a/vdsm/storage/storageConstants.py b/vdsm/storage/storageConstants.py
index 7c4b5d5..dd5c9b1 100644
--- a/vdsm/storage/storageConstants.py
+++ b/vdsm/storage/storageConstants.py
@@ -24,3 +24,5 @@
 # This is the extension applied to FileVolume metadata files during the
 # volume creation process.
 ARTIFACT_FILEEXT = ".tmp"
+
+FILE_VOLUME_PERMISSIONS = 0o660


-- 
To view, visit https://gerrit.ovirt.org/50631
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaeb2c902ff41e71266689b42323624f8e7a38ed8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: add SDM.create_volume API stub

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: add SDM.create_volume API stub
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50220
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ff2656f2dd427812e557e6587429759a9c0a845
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add getHostId to DomainMonitor

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: add getHostId to DomainMonitor
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50630
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Add constants module to storage

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Add constants module to storage
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/49544/5/vdsm/storage/storageConstants.py
File vdsm/storage/storageConstants.py:

Line 22: SECTOR_SIZE = 512
Line 23: 
Line 24: # This is the extension applied to FileVolume metadata files during the
Line 25: # volume creation process.
Line 26: ARTIFACT_FILEEXT = ".tmp"
Are you should about the name?

Way not TEMPORARY_SUFFIX?

And we probably need similar constants for block storage, will be nice if we 
have both of them here.


-- 
To view, visit https://gerrit.ovirt.org/49544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id14e79d400d6936c8bb0da5dec39e3f9fb60c803
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add getHostId to DomainMonitor

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: storage: add getHostId to DomainMonitor
..

storage: add getHostId to DomainMonitor

Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c
Signed-off-by: Adam Litke 
---
M vdsm/storage/monitor.py
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/50630/1

diff --git a/vdsm/storage/monitor.py b/vdsm/storage/monitor.py
index d5156f3..b4a0846 100644
--- a/vdsm/storage/monitor.py
+++ b/vdsm/storage/monitor.py
@@ -149,6 +149,9 @@
 status[sdUUID] = monitor.getHostStatus(hostId)
 return status
 
+def getHostId(self, sdUUID):
+return self._monitors[sdUUID].hostId
+
 def shutdown(self):
 """
 Called during shutdown to stop all monitors without releasing the host


-- 
To view, visit https://gerrit.ovirt.org/50630
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Handle missing glusterfs-cli package

[ahino]

Ala Hino has posted comments on this change.

Change subject: gluster: Handle missing glusterfs-cli package
..


Patch Set 10:

(5 comments)

https://gerrit.ovirt.org/#/c/50363/10/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 320
Line 321
Line 322
Line 323
Line 324
> check here if we have gluster cli - if we don't need to call _get_backup_se
Done


Line 321: self.log.warning("Required glusterfs-cli package is 
missing "
Line 322:  "on this host. Note that no backup "
Line 323:  "servers will be used! Please install 
the "
Line 324:  "missing package in order to use gluster 
storage "
Line 325:  "backup servers")
> One issue with warning here, is this message is relevant only for connect, 
Moved to validate
Line 326: 
Line 327: @property
Line 328: def options(self):
Line 329: if "backup-volfile-servers" in self._options:


Line 336: 
Line 337: @property
Line 338: def volinfo(self):
Line 339: if not self._have_gluster_cli:
Line 340: return None
> Nobody should call volinfo if we don't have a gluster cli, don't protect th
Why not to protect? My unit test checked that volinfo is None and if I remove 
this if, the test fails
Line 341: 
Line 342: if self._volinfo is None:
Line 343: self._volinfo = self._get_gluster_volinfo()
Line 344: return self._volinfo


Line 344: return self._volinfo
Line 345: 
Line 346: def validate(self):
Line 347: if not self._have_gluster_cli:
Line 348: return
> I think warning here is better since this is used only during connect, and 
Done
Line 349: 
Line 350: replicaCount = self.volinfo['replicaCount']
Line 351: if replicaCount not in self.ALLOWED_REPLICA_COUNTS:
Line 352: self.log.warning("Unsupported replica count (%s) for 
volume %r, "


Line 354:  replicaCount, self._volname)
Line 355: 
Line 356: def _get_backup_servers_option(self):
Line 357: if not self._have_gluster_cli:
Line 358: return ""
> Why do we need to protect this? check if we have gluster cli in the code th
Done
Line 359: 
Line 360: servers = utils.unique(brick.split(":")[0] for brick
Line 361:in self.volinfo['bricks'])
Line 362: self.log.debug("Using bricks: %s", servers)


-- 
To view, visit https://gerrit.ovirt.org/50363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Handle missing glusterfs-cli package

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: Handle missing glusterfs-cli package
..


Patch Set 11:

* #1290997::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1290997::OK, public bug
* Check Product::#1290997::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Remove koji build flag and use specific one for vhostmd

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Remove koji build flag and use specific one for vhostmd
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49427
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2401a803243e3e64216fe62039c1b15c431a906
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Remove koji build flag and use specific one for vhostmd

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Remove koji build flag and use specific one for vhostmd
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/49427/4/configure.ac
File configure.ac:

Line 60: AC_ARG_ENABLE(
Line 61: [vhostmd],
Line 62: [AS_HELP_STRING(
Line 63: [--enable-vhostmd],
Line 64: [build vhostmd subpackage @<:@default=no@:>@]
package is more correct. If we want to avoid specifying the name of the 
package, we can say "enable vhostmd support"
Line 65: )],
Line 66: [enable_vhostmd="no"]
Line 67: )
Line 68: AS_IF([test "${enable_vhostmd}" = "yes"],


-- 
To view, visit https://gerrit.ovirt.org/49427
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2401a803243e3e64216fe62039c1b15c431a906
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Bridge: Allow _ in function names

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: Bridge: Allow _ in function names
..


Bridge: Allow _ in function names

Change-Id: I1ce4f8d5771362df6eefbc10f0bc4f638e439f0a
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/50626
Reviewed-by: Nir Soffer 
Reviewed-by: Piotr Kliczewski 
Continuous-Integration: Jenkins CI
---
M vdsm/rpc/Bridge.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, approved
  Adam Litke: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/50626
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1ce4f8d5771362df6eefbc10f0bc4f638e439f0a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Bridge: Allow _ in function names

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Bridge: Allow _ in function names
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/50626
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ce4f8d5771362df6eefbc10f0bc4f638e439f0a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: executor: Streamline __repr__

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: executor: Streamline __repr__
..


Patch Set 1: Continuous-Integration+1 Verified+1

CI failure is not relevant.

Verified using the tests and manhole:

 Python 2.7.5 (default, Oct 11 2015, 17:47:16) 
 [GCC 4.8.3 20140911 (Red Hat 4.8.3-9)] on linux2
 Type "help", "copyright", "credits" or "license" for more information.
 (ManholeConsole)
 >>> from virt import periodic
 >>> import pprint
 >>> import time
 >>> while True:
 ...pprint.pprint(periodic._executor._workers)
 ...time.sleep(5)
 ... 
 set([,
 ,
 ,
 ])
 ...
 set([,
 , timeout=7.5) at 
0x7ff97c038f10>,
 ,
  at 
0x7ff97c041c50>, timeout=7.5) at 0x7ff97c041510>])

-- 
To view, visit https://gerrit.ovirt.org/50627
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ddc1c0ebc5933ad5fad02b24cc1c32f417aa2d3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: executor: Fix the task-callable mismtach

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: executor: Fix the task-callable mismtach
..


Patch Set 3: Verified+1

Verified using the tests and manhole:

 Python 2.7.5 (default, Oct 11 2015, 17:47:16) 
 [GCC 4.8.3 20140911 (Red Hat 4.8.3-9)] on linux2
 Type "help", "copyright", "credits" or "license" for more information.
 (ManholeConsole)
 >>> from virt import periodic
 >>> import pprint
 >>> import time
 >>> while True:
 ...pprint.pprint(periodic._executor._workers)
 ...time.sleep(5)
 ... 
 set([,
 ,
 ,
 ])
 ...
 set([,
 , timeout=7.5) at 
0x7ff97c038f10>,
 ,
  at 
0x7ff97c041c50>, timeout=7.5) at 0x7ff97c041510>])

-- 
To view, visit https://gerrit.ovirt.org/50228
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id50a4175bc9cb27b9e432a2c871b1ba98cf625c8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move newVolumeLease

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: VolumeMetadata: move newVolumeLease
..


Patch Set 23: Code-Review-1

Needs indirection tests

-- 
To view, visit https://gerrit.ovirt.org/42002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If18aa7d526d9eb334c638fdf4cc93d31a4943cb6
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move newVolumeLease

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: move newVolumeLease
..


Patch Set 23:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If18aa7d526d9eb334c638fdf4cc93d31a4943cb6
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: Add create_volume job

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Add create_volume job
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50221
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia614059f52c9625da7841ea9fbca2b2f2375cd75
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagefakelib: Add FakeResourceManager

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storagefakelib: Add FakeResourceManager
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50340
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0302b48d984ce7eb8ce2326ab4bb033430c032f9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fileVolume: refactor _putMetadata to support volume artifacts

[automation]

gerrit-hooks has posted comments on this change.

Change subject: fileVolume: refactor _putMetadata to support volume artifacts
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49545
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5253b6692b8c58967bbd2c421abcce05c584d769
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fileVolume: define file extension for volume artifacts metadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: fileVolume: define file extension for volume artifacts metadata
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id14e79d400d6936c8bb0da5dec39e3f9fb60c803
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move newMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: move newMetadata
..


Patch Set 24:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I115fb4da48ef39bbbda5475cefbed1ab26ee1764
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add getHostId to DomainMonitor

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: add getHostId to DomainMonitor
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/50630/3//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: Some SDM verbs need to acquire the domainLock during their job.  In
Line 10: order to do this they must be passed the domain's hostId property.  An
Line 11: easy way to expose this is to add a getHostId method to the
Line 12: DomainMonitor.
Please explain why not use getPools()[0].id
Line 13: 
Line 14: Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c


-- 
To view, visit https://gerrit.ovirt.org/50630
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fileVolume: define file extension for volume artifacts metadata

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: fileVolume: define file extension for volume artifacts metadata
..


Patch Set 6: Code-Review-1

See comment in previous patch

-- 
To view, visit https://gerrit.ovirt.org/49544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id14e79d400d6936c8bb0da5dec39e3f9fb60c803
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fileVolume: refactor _putMetadata to support volume artifacts

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: fileVolume: refactor _putMetadata to support volume artifacts
..


Patch Set 7: Code-Review-1

(1 comment)

The old code is ugly, this patch only make it worse.

Can we avoid this code and copy the trivial code to VolumeArtifacts?

https://gerrit.ovirt.org/#/c/49545/7/vdsm/storage/fileVolume.py
File vdsm/storage/fileVolume.py:

Line 236: """
Line 237: self.file_setrw(self.getVolumePath(), rw=rw)
Line 238: 
Line 239: @classmethod
Line 240: def __writeMetadata(cls, metaPath, meta):
Do not add new __private method. Use single underscore.
Line 241: data = cls.formatMetadata(meta)
Line 242: with open(metaPath + ".new", "w") as f:
Line 243: f.write(data)
Line 244: 


-- 
To view, visit https://gerrit.ovirt.org/49545
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5253b6692b8c58967bbd2c421abcce05c584d769
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move newMetadata

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: VolumeMetadata: move newMetadata
..


Patch Set 23: Code-Review-1

Needs indirection tests

-- 
To view, visit https://gerrit.ovirt.org/42001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I115fb4da48ef39bbbda5475cefbed1ab26ee1764
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move validateDelete

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: VolumeMetadata: move validateDelete
..


Patch Set 24:

Waiting for CI

-- 
To view, visit https://gerrit.ovirt.org/42000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06c8a87cb5b07d342b47fc54e75bc54ba00f5be2
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Vdsm standard CI arrangement

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Vdsm standard CI arrangement
..


Patch Set 36: Code-Review-1

Please see comment about report name

-- 
To view, visit https://gerrit.ovirt.org/48268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c
Gerrit-PatchSet: 36
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Rename storageConstants.py to constants.py

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Rename storageConstants.py to constants.py
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50633
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74684fdf63fb08573dc2068dcfb32ba5febac82b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move validateDelete

[alitke]

Adam Litke has posted comments on this change.

Change subject: VolumeMetadata: move validateDelete
..


Patch Set 24: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/42000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06c8a87cb5b07d342b47fc54e75bc54ba00f5be2
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move newMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: move newMetadata
..


Patch Set 23:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I115fb4da48ef39bbbda5475cefbed1ab26ee1764
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move newMetadata

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: VolumeMetadata: move newMetadata
..


Patch Set 24: Code-Review+2 Verified+1

This version adds the missing indirection tests, no code change.

Verified using lsm with both iscsi and nfs storage.

-- 
To view, visit https://gerrit.ovirt.org/42001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I115fb4da48ef39bbbda5475cefbed1ab26ee1764
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: XXX: Add _getDeletedImagePath until patch merged

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: XXX: Add _getDeletedImagePath until patch merged
..


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/50218/5/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:

Line 200: Return a type specific volume generator object
Line 201: """
Line 202: return fileVolume.FileVolumeMetadata
Line 203: 
Line 204: def _getDeletedImagePath(self, imgUUID):
Make it public
Line 205: currImgDir = self.getImagePath(imgUUID)
Line 206: dirName, baseName = os.path.split(currImgDir)
Line 207: toDelDir = os.path.join(dirName, sd.REMOVED_IMAGE_PREFIX + 
baseName)
Line 208: return toDelDir


-- 
To view, visit https://gerrit.ovirt.org/50218
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd67cacc58da27ffda7286582e263195dac96894
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Vdsm standard CI arrangement

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Vdsm standard CI arrangement
..


Patch Set 36:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c
Gerrit-PatchSet: 36
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Vdsm standard CI arrangement

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Vdsm standard CI arrangement
..


Patch Set 35: Code-Review-1

The report is called now 
http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc23-x86_64/1492/artifact/exported-artifacts/functional_tests_stdout.fc23

So you cannot access it via the browser. Please rename with .txt or .log 
extension so we can view in directly in the browser.

-- 
To view, visit https://gerrit.ovirt.org/48268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c
Gerrit-PatchSet: 35
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: add SDM.create_volume API stub

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: add SDM.create_volume API stub
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50220
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ff2656f2dd427812e557e6587429759a9c0a845
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Introduce VolumeArtifacts

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Introduce VolumeArtifacts
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I352423e39a899b9b83ccf3b8f6c17ec433e9c353
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Rename storageConstants.py to constants.py

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: storage: Rename storageConstants.py to constants.py
..

storage: Rename storageConstants.py to constants.py

The SDM work is beginning an effort to reorganize storage constants.
Currently constants are peppered throughout the various storage modules.
Getting access to these constants introduces complex module
interdependencies which can lead to circular import dependencies.

In this first step, rename storageConstants.py to constants.py and make
necessary adjustments to the code which currently imports this module.
The new name is shorter and does not have the redundant 'storage' as
part of its name.  Future patches will move constants into this module.

Change-Id: I74684fdf63fb08573dc2068dcfb32ba5febac82b
Signed-off-by: Adam Litke 
---
M debian/vdsm.install
M vdsm.spec.in
M vdsm/storage/Makefile.am
R vdsm/storage/constants.py
M vdsm/storage/hsm.py
M vdsm/storage/misc.py
M vdsm/storage/sp.py
7 files changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/50633/1

diff --git a/debian/vdsm.install b/debian/vdsm.install
index 8495a4c..efa6045 100644
--- a/debian/vdsm.install
+++ b/debian/vdsm.install
@@ -83,6 +83,7 @@
 ./usr/share/vdsm/storage/blockSD.py
 ./usr/share/vdsm/storage/blockVolume.py
 ./usr/share/vdsm/storage/clusterlock.py
+./usr/share/vdsm/storage/constants.py
 ./usr/share/vdsm/storage/curlImgWrap.py
 ./usr/share/vdsm/storage/devicemapper.py
 ./usr/share/vdsm/storage/dispatcher.py
@@ -118,7 +119,6 @@
 ./usr/share/vdsm/storage/securable.py
 ./usr/share/vdsm/storage/sp.py
 ./usr/share/vdsm/storage/spbackends.py
-./usr/share/vdsm/storage/storageConstants.py
 ./usr/share/vdsm/storage/storageServer.py
 ./usr/share/vdsm/storage/storage_exception.py
 ./usr/share/vdsm/storage/storage_mailbox.py
diff --git a/vdsm.spec.in b/vdsm.spec.in
index d7b6ae8..4ca7827 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -899,6 +899,7 @@
 %{_datadir}/%{vdsm_name}/storage/__init__.py*
 %{_datadir}/%{vdsm_name}/storage/blockSD.py*
 %{_datadir}/%{vdsm_name}/storage/blockVolume.py*
+%{_datadir}/%{vdsm_name}/storage/constants.py*
 %{_datadir}/%{vdsm_name}/storage/curlImgWrap.py*
 %{_datadir}/%{vdsm_name}/storage/devicemapper.py*
 %{_datadir}/%{vdsm_name}/storage/dispatcher.py*
@@ -933,7 +934,6 @@
 %{_datadir}/%{vdsm_name}/storage/securable.py*
 %{_datadir}/%{vdsm_name}/storage/sp.py*
 %{_datadir}/%{vdsm_name}/storage/spbackends.py*
-%{_datadir}/%{vdsm_name}/storage/storageConstants.py*
 %{_datadir}/%{vdsm_name}/storage/storage_exception.py*
 %{_datadir}/%{vdsm_name}/storage/storage_mailbox.py*
 %{_datadir}/%{vdsm_name}/storage/storageServer.py*
diff --git a/vdsm/storage/Makefile.am b/vdsm/storage/Makefile.am
index e183e80..9ed7e61 100644
--- a/vdsm/storage/Makefile.am
+++ b/vdsm/storage/Makefile.am
@@ -28,6 +28,7 @@
blockSD.py \
blockVolume.py \
clusterlock.py \
+   constants.py \
curlImgWrap.py \
devicemapper.py \
dispatcher.py \
@@ -60,7 +61,6 @@
securable.py \
sp.py \
spbackends.py \
-   storageConstants.py \
storage_exception.py \
storage_mailbox.py \
 storageServer.py \
diff --git a/vdsm/storage/storageConstants.py b/vdsm/storage/constants.py
similarity index 100%
rename from vdsm/storage/storageConstants.py
rename to vdsm/storage/constants.py
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 33be84b..2397d27 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -63,8 +63,8 @@
 import storage_exception as se
 from threadLocal import vars
 from vdsm import constants
-from storageConstants import STORAGE
-from storageConstants import SECTOR_SIZE
+from constants import STORAGE
+from constants import SECTOR_SIZE
 import resourceManager as rm
 from resourceFactories import IMAGE_NAMESPACE
 import devicemapper
diff --git a/vdsm/storage/misc.py b/vdsm/storage/misc.py
index c40b676..8fcffcd 100644
--- a/vdsm/storage/misc.py
+++ b/vdsm/storage/misc.py
@@ -49,7 +49,7 @@
 from vdsm import concurrent
 from vdsm import constants
 from vdsm import utils
-from storageConstants import SECTOR_SIZE
+from constants import SECTOR_SIZE
 import storage_exception as se
 import logUtils
 
diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index 311eb5f..45cd85e 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -47,7 +47,7 @@
 from securable import secured, unsecured
 import image
 from resourceFactories import IMAGE_NAMESPACE
-from storageConstants import STORAGE
+from constants import STORAGE
 import resourceManager as rm
 import volume
 import mount


-- 
To view, visit https://gerrit.ovirt.org/50633
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I74684fdf63fb08573dc2068dcfb32ba5febac82b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master

Change in vdsm[master]: storage: add get_volume_artifacts_class to the domain manifest

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: add get_volume_artifacts_class to the domain manifest
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50339
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iade716f7487f502243aaf280a7a8c147f501307d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: XXX: All outstanding VolumeMetadata changes squashed

[automation]

gerrit-hooks has posted comments on this change.

Change subject: XXX: All outstanding VolumeMetadata changes squashed
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50362
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5db8bb8bdf405b8760ecbe103dcbb1a1907ca1db
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Move VOLUME_PERMISSIONS to storage constants

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Move VOLUME_PERMISSIONS to storage constants
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50631
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaeb2c902ff41e71266689b42323624f8e7a38ed8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Rename storageConstants.py to constants.py

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Rename storageConstants.py to constants.py
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50633
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74684fdf63fb08573dc2068dcfb32ba5febac82b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: XXX: Add _getDeletedImagePath until patch merged

[automation]

gerrit-hooks has posted comments on this change.

Change subject: XXX: Add _getDeletedImagePath until patch merged
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50218
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd67cacc58da27ffda7286582e263195dac96894
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add getHostId to DomainMonitor

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: add getHostId to DomainMonitor
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50630
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move validateDelete

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: move validateDelete
..


Patch Set 24:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06c8a87cb5b07d342b47fc54e75bc54ba00f5be2
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move validateDelete

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: VolumeMetadata: move validateDelete
..


Patch Set 24: Verified+1

Verified using lsm and delete vm on both iscsi and nfs storage.

-- 
To view, visit https://gerrit.ovirt.org/42000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06c8a87cb5b07d342b47fc54e75bc54ba00f5be2
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Vdsm standard CI arrangement

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Vdsm standard CI arrangement
..


Patch Set 37:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c
Gerrit-PatchSet: 37
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[derez]

Daniel Erez has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/44045/7/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 530: return meta
Line 531: 
Line 532: @classmethod
Line 533: def makeMetadata(cls, sdUUID, imgUUID, puuid, size, format, type, 
voltype,
Line 534:  disktype, desc="", legality=ILLEGAL_VOL):
> Hmm, not really sure what you mean here.  none of the lines are too long.
Just meant to align the variables with newMetadata method for easier 
identification of the difference.
I.e.
line 526: voltype, disktype, desc="", legality=ILLEGAL_VOL):
line 534: voltype, disktype, desc="", legality=ILLEGAL_VOL):
Line 535: return {
Line 536: FORMAT: str(format),
Line 537: TYPE: str(type),
Line 538: VOLTYPE: str(voltype),


-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: move validateDelete

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: VolumeMetadata: move validateDelete
..


Patch Set 24: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/42000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06c8a87cb5b07d342b47fc54e75bc54ba00f5be2
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Rename storageConstants.py to constants.py

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Rename storageConstants.py to constants.py
..


Patch Set 2: Code-Review+2

This version make the storage.constants import more clear, as in all modules 
using it, we also import vdsm.constants, and we have  lot of these imports.

-- 
To view, visit https://gerrit.ovirt.org/50633
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74684fdf63fb08573dc2068dcfb32ba5febac82b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: fix brick devices are created with incorrect data a...

[sabose]

Sahina Bose has posted comments on this change.

Change subject: gluster: fix brick devices are created with incorrect data 
alignment
..


Patch Set 3:

Dan, can this be merged?

-- 
To view, visit https://gerrit.ovirt.org/47959
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Manoj Pillai 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Introduce VolumeArtifacts

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Introduce VolumeArtifacts
..


Patch Set 11: Code-Review-1

(14 comments)

https://gerrit.ovirt.org/#/c/48097/11/vdsm/storage/sdm/volume_artifacts.py
File vdsm/storage/sdm/volume_artifacts.py:

Line 57: 
Line 58: def __init__(self, domain_manifest, img_id, vol_id):
Line 59: super(FileVolumeArtifacts, self).__init__(domain_manifest, 
img_id,
Line 60:   vol_id)
Line 61: self._image_path = self.domain_manifest.getImagePath(img_id)
The old name is too abstract, this is not a path but a directory. We should 
call this self._image_dir.
Line 62: 
Line 63: @property
Line 64: def _oop(self):
Line 65: return self.domain_manifest.oop


Line 75: # XXX: Remove these when support is added:
Line 76: if vol_format != volume.RAW_FORMAT:
Line 77: raise CannotCreateVolumeArtifacts("Only raw volumes are 
supported")
Line 78: if parent_vol_id != volume.BLANK_UUID:
Line 79: raise CannotCreateVolumeArtifacts("parent_vol_id not 
supported")
validating create parameters should be here.
Line 80: 
Line 81: # If these artifacts are forming a new image the artifacts 
path will be
Line 82: # a temporary directory.  Otherwise it's the existing image 
directory.
Line 83: artifacts_path = self._get_artifacts_path()


Line 81: # If these artifacts are forming a new image the artifacts 
path will be
Line 82: # a temporary directory.  Otherwise it's the existing image 
directory.
Line 83: artifacts_path = self._get_artifacts_path()
Line 84: if artifacts_path != self._image_path:
Line 85: self._create_artifacts_path(artifacts_path)
Add blank line.
Line 86: vol_path = os.path.join(artifacts_path, self.vol_id)
Line 87: meta_id = (vol_path,)
Line 88: 
Line 89: self._create_metadata_artifact(meta_id, size, vol_format, 
disk_type,


Line 83: artifacts_path = self._get_artifacts_path()
Line 84: if artifacts_path != self._image_path:
Line 85: self._create_artifacts_path(artifacts_path)
Line 86: vol_path = os.path.join(artifacts_path, self.vol_id)
Line 87: meta_id = (vol_path,)
This does not make any sense in this level. Methods that need to send meta_id 
can generate this useless tuple.
Line 88: 
Line 89: self._create_metadata_artifact(meta_id, size, vol_format, 
disk_type,
Line 90:desc, parent_vol_id)
Line 91: self._create_lease_artifact(meta_id)


Line 85: self._create_artifacts_path(artifacts_path)
Line 86: vol_path = os.path.join(artifacts_path, self.vol_id)
Line 87: meta_id = (vol_path,)
Line 88: 
Line 89: self._create_metadata_artifact(meta_id, size, vol_format, 
disk_type,
send vol_path instead.
Line 90:desc, parent_vol_id)
Line 91: self._create_lease_artifact(meta_id)
Line 92: self._create_container_artifact(vol_path, vol_format, size)
Line 93: 


Line 87: meta_id = (vol_path,)
Line 88: 
Line 89: self._create_metadata_artifact(meta_id, size, vol_format, 
disk_type,
Line 90:desc, parent_vol_id)
Line 91: self._create_lease_artifact(meta_id)
send vol_path instead
Line 92: self._create_container_artifact(vol_path, vol_format, size)
Line 93: 
Line 94: def commit(self):
Line 95: artifacts_path = self._get_artifacts_path()


Line 94: def commit(self):
Line 95: artifacts_path = self._get_artifacts_path()
Line 96: vol_path = os.path.join(artifacts_path, self.vol_id)
Line 97: commit_path = self.vol_class._metaVolumePath(vol_path)
Line 98: create_path = commit_path + constants.ARTIFACT_FILEEXT
We should move this to self.meta_artifact_path, and use it when we create the 
file.

Currently we use old code to create the file, and new code to rename it. Either 
we always get the path from the old code, or always compute it here, but not 
mix.
Line 99: try:
Line 100: self._oop.os.rename(create_path, commit_path)
Line 101: except OSError as e:
Line 102: if e.errno == errno.ENOENT:


Line 115: 
Line 116: # File volumes are always created sparse
Line 117: prealloc = volume.SPARSE_VOL
Line 118: self.domain_manifest.validateCreateVolumeParams(
Line 119: vol_format, parent_vol_id, preallocate=prealloc)
This should be first thing we do in create, before touching storage.
Line 120: leaf_type = volume.type2name(volume.LEAF_VOL)
Line 121: 
Line 122: meta = self.vol_class.makeMetadata(
Line 123: self.domain_manifest.sdUUID, self.img_id, parent_vol_id, 
size,


Line 122: meta = 

Change in vdsm[master]: migration: build new reason on success

[fromani]

Francesco Romani has abandoned this change.

Change subject: migration: build new reason on success
..


Abandoned

obsoleted by topic:migration_report

-- 
To view, visit https://gerrit.ovirt.org/42800
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic42b70be6f5a5406e23916e16a678dd8caf0f500
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: don't inherit from threading.Thread

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: don't inherit from threading.Thread
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/47399
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1385121990a885584fce607ce12f40011e67973d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: de-entangle migration stat reporting

[fromani]

Francesco Romani has abandoned this change.

Change subject: migration: de-entangle migration stat reporting
..


Abandoned

obsoleted by topic:migration_report

-- 
To view, visit https://gerrit.ovirt.org/42796
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I6d745bacddf80c54354a2f7ec2d290dfd3b12d03
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: don't inherit from threading.Thread

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: migration: don't inherit from threading.Thread
..

migration: don't inherit from threading.Thread

To have one class which inherits from threading.Thread is
bad practice. Better to have composition than inheritance.

Change-Id: I1385121990a885584fce607ce12f40011e67973d
Signed-off-by: Francesco Romani 
---
M vdsm/virt/migration.py
1 file changed, 37 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/47399/1

diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py
index 4b9a2b9..78ea855 100644
--- a/vdsm/virt/migration.py
+++ b/vdsm/virt/migration.py
@@ -73,7 +73,7 @@
 STALLED = 3
 
 
-class SourceThread(threading.Thread):
+class SourceThread(object):
 """
 A thread that takes care of migration on the source vdsm.
 """
@@ -112,10 +112,19 @@
 self._last_error = None
 self._last_status = MigrationStatus.IN_PROGRESS
 self._progress = 0
-threading.Thread.__init__(self)
 self._migrationPrepared = threading.Event()
 self._migrationCanceled = threading.Event()
 self._monitorThread = None
+self._destServer = None
+
+self._thread = threading.Thread(target=self._run)
+self._thread.daemon = True
+self._thread.start()
+
+def is_alive(self):
+return self._thread.is_alive()
+
+isAlive = is_alive
 
 @property
 def hibernating(self):
@@ -310,7 +319,7 @@
  -1, -1) # int1, int2
 raise e
 
-def run(self):
+def _run(self):
 try:
 startTime = time.time()
 self._setupVdsConnection()
@@ -465,22 +474,27 @@
 yield int(offset + base ** i)
 
 
-class DowntimeThread(threading.Thread):
+class DowntimeThread(object):
 def __init__(self, vm, downtime, steps):
-super(DowntimeThread, self).__init__()
-
 self._vm = vm
 self._downtime = downtime
 self._steps = steps
+
 self._stop = threading.Event()
+
+self._thread = threading.Thread(target=self._run)
+self._thread.daemon = True
+self._thread.start()
 
 delay_per_gib = config.getint('vars', 'migration_downtime_delay')
 memSize = int(vm.conf['memSize'])
 self._wait = (delay_per_gib * max(memSize, 2048) + 1023) / 1024
 
-self.daemon = True
+def stop(self):
+self._vm.log.debug('stopping migration downtime thread')
+self._stop.set()
 
-def run(self):
+def _run(self):
 self._vm.log.debug('migration downtime thread started (%i steps)',
self._steps)
 
@@ -490,10 +504,6 @@
 self._set_downtime(self._downtime)
 
 self._vm.log.debug('migration downtime thread exiting')
-
-def stop(self):
-self._vm.log.debug('stopping migration downtime thread')
-self._stop.set()
 
 def _set_downtime_by_steps(self, max_downtime):
 for downtime in exponential_downtime(max_downtime, self._steps):
@@ -509,30 +519,34 @@
 self._vm._dom.migrateSetMaxDowntime(downtime, 0)
 
 
-class MonitorThread(threading.Thread):
+class MonitorThread(object):
+
 _MIGRATION_MONITOR_INTERVAL = config.getint(
 'vars', 'migration_monitor_interval')  # seconds
 
 def __init__(self, vm, startTime):
-super(MonitorThread, self).__init__()
-self._stop = threading.Event()
 self._vm = vm
 self._startTime = startTime
-self.daemon = True
 self.progress = 0
 
+self._stop = threading.Event()
+
+if self.enabled:
+self._thread = threading.Thread(target=self._run)
+self._thread.daemon = True
+self._thread.start()
+else:
+self._vm.log.info('migration monitor thread disabled'
+  ' (monitoring interval set to 0)')
 @property
 def enabled(self):
 return MonitorThread._MIGRATION_MONITOR_INTERVAL > 0
 
-def run(self):
-if self.enabled:
-self.monitor_migration()
-else:
-self._vm.log.info('migration monitor thread disabled'
-  ' (monitoring interval set to 0)')
+def stop(self):
+self._vm.log.debug('stopping migration monitor thread')
+self._stop.set()
 
-def monitor_migration(self):
+def _run(self):
 def update_progress(remaining, total):
 if remaining == 0 and total:
 return 100
@@ -595,7 +609,3 @@
 self._vm.log.info('Migration Progress: %s seconds elapsed,'
   ' %s%% of data processed' %
   (timeElapsed / 1000, self.progress))
-
-def stop(self):
-self._vm.log.debug('stopping migration monitor thread')
-

Change in vdsm[master]: migration: make status attribute private

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: make status attribute private
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/42794
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33884c0e4942f9e2d7ef93b939f33b2e6147ca62
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: don't inherit from threading.Thread

[fromani]

Francesco Romani has abandoned this change.

Change subject: migration: don't inherit from threading.Thread
..


Abandoned

obsoleted by topic:migration_report

-- 
To view, visit https://gerrit.ovirt.org/47399
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I1385121990a885584fce607ce12f40011e67973d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: make status attribute private

[fromani]

Francesco Romani has abandoned this change.

Change subject: migration: make status attribute private
..


Abandoned

obsoleted by topic:migration_report

-- 
To view, visit https://gerrit.ovirt.org/42794
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I33884c0e4942f9e2d7ef93b939f33b2e6147ca62
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: return plain response on error

[fromani]

Francesco Romani has abandoned this change.

Change subject: migration: return plain response on error
..


Abandoned

obsoleted by topic:migration_report

-- 
To view, visit https://gerrit.ovirt.org/42799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ifafa5de4db317ed0e2f735eca6d944042e19c4e1
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: replace boolean with proper Events

[fromani]

Francesco Romani has abandoned this change.

Change subject: migration: replace boolean with proper Events
..


Abandoned

obsoleted by topic:migration_report

-- 
To view, visit https://gerrit.ovirt.org/42887
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I02639749ab884c3542c4d29715756044d777f738
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: return plain response on error

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: return plain response on error
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/42799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifafa5de4db317ed0e2f735eca6d944042e19c4e1
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: add helper to add status field

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: add helper to add status field
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/42798
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I047705e2f45221ad3a7527ca6b018dc6d0f3368e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: add helper to add status field

[fromani]

Francesco Romani has abandoned this change.

Change subject: migration: add helper to add status field
..


Abandoned

obsoleted by topic:migration_report

-- 
To view, visit https://gerrit.ovirt.org/42798
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I047705e2f45221ad3a7527ca6b018dc6d0f3368e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: move progress update into an helper

[fromani]

Francesco Romani has abandoned this change.

Change subject: migration: move progress update into an helper
..


Abandoned

obsoleted by topic:migration_report

-- 
To view, visit https://gerrit.ovirt.org/42797
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie9707fcc492a394f8d7aebd57482c44b7b5a703d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: build new reason on success

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: build new reason on success
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/42800
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic42b70be6f5a5406e23916e16a678dd8caf0f500
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: refactor testSuccessfulImport test

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: refactor testSuccessfulImport test
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50584
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30144a9f03d1d95837f43d8b5575aae1499d3c2a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: support for importing Xen VMs via libvirt on RHEL hosts

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49505
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If544c0247003b6bc7189f72130553b9402dc915d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add test testSuccessfulImportOVA

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: add test testSuccessfulImportOVA
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50585
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I465d68e5f42f6f5829d33bf62c2d40412a8aead4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: refactor testSuccessfulImport test

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: refactor testSuccessfulImport test
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50584
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30144a9f03d1d95837f43d8b5575aae1499d3c2a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: refactor get_external_vms

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: refactor get_external_vms
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49636
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5c331b3136b61b0ee81829d7e71eedbbc1fa6b9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add test testSuccessfulImportOVA

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: add test testSuccessfulImportOVA
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50585
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I465d68e5f42f6f5829d33bf62c2d40412a8aead4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: externalVMList Xen+Kvm support
..


Patch Set 20:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7d7e211a9343a528f260da2686b34cea00c53a4
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: improve safety between startup and shutdown

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: improve safety between startup and shutdown
..


Patch Set 2:

* #912390::Update tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/44989
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8718f58f1d255d9e603db75aa1f256c03c300f3a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: improve safety between startup and shutdown

[fromani]

Francesco Romani has abandoned this change.

Change subject: vm: improve safety between startup and shutdown
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/44989
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I8718f58f1d255d9e603db75aa1f256c03c300f3a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: add documentation for setupNetworks rollback mechanism.

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: add documentation for setupNetworks rollback mechanism.
..


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/50261/1/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 914: excepted
I don't think that the English verb means what you want here.
"handled", maybe?


https://gerrit.ovirt.org/#/c/50261/1/vdsm/API.py
File vdsm/API.py:

Line 1522: cleanup is done.
I don't understand this text. At this point, we are about to try to do a 
rollback. Before the next line succeeds, cleanup is not yet done.


-- 
To view, visit https://gerrit.ovirt.org/50261
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f7d66f9612ed6762fa80e7aa9e57d914dd65f34
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: extract specific classes for libvirt and ova

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: extract specific classes for libvirt and ova
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49951
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a9ecd4a2cde6f379188da647c3a6f8874c41abd
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: replace boolean with proper Events

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: replace boolean with proper Events
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/42887
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02639749ab884c3542c4d29715756044d777f738
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: de-entangle migration stat reporting

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: de-entangle migration stat reporting
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/42796
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6d745bacddf80c54354a2f7ec2d290dfd3b12d03
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: move progress update into an helper

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: move progress update into an helper
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/42797
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9707fcc492a394f8d7aebd57482c44b7b5a703d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Allow vm.cont() to resume VM in SAVING_STATE

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Allow vm.cont() to resume VM in SAVING_STATE
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/47527
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b1c7b4eecacf87ece48dc563fd2da294af0510b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: drop initial bonds' slaves IP config

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hooks: ovs: drop initial bonds' slaves IP config
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/50100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6584bdd8ee544880a77fc9d3e57e523d51e23532
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: lib: executor: report worker status in __repr__

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: lib: executor: report worker status in __repr__
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49722
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I558787e006d8c9cbbbff6b3dfbd744311ab31e42
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: drop initial bonds' slaves IP config

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: hooks: ovs: drop initial bonds' slaves IP config
..


hooks: ovs: drop initial bonds' slaves IP config

Ifcfg configurator's behavior of keeping network nic's IP and dropping
bonding nics' IP was considered as a bug and
test_keep_initial_bond_slaves_ip_config was renamed to
test_drop_initial_bond_slaves_ip_config.

Because of that, we have to remove IP configuration of nics
attached to Vdsm controlled OVS bonds.

Change-Id: I6584bdd8ee544880a77fc9d3e57e523d51e23532
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/50100
Reviewed-by: Ido Barkan 
Reviewed-by: Edward Haas 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M vdsm_hooks/ovs/ovs_before_network_setup.py
M vdsm_hooks/ovs/ovs_before_network_setup_ip.py
2 files changed, 11 insertions(+), 2 deletions(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/50100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6584bdd8ee544880a77fc9d3e57e523d51e23532
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: drop initial bonds' slaves IP config

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: ovs: drop initial bonds' slaves IP config
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/50100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6584bdd8ee544880a77fc9d3e57e523d51e23532
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Correctly apply MTU values on networks

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: Correctly apply MTU values on networks
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/50397
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba24363f5b9ea70392a68885cf5374800ab58549
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Correctly apply MTU values on networks

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: Correctly apply MTU values on networks
..


net: Correctly apply MTU values on networks

Two issues have been resolved by this change:

- New networks with no MTU specification are being
set by default with their connected device (bond,
vlan, nic) mtu (which does not have to be 1500).
Fixed by detecting when no MTU is specified in the
configuration, and adding the default (1500)
explicitly.
The assumption of a single default mtu when one is
not specified in the setup is wrong, causing in
some cases an unnecessary restoration of networks
during network restoration.
- Test fix: The NIC/s mtu should be set to the
maximum mtu of the remaining networks.

Change-Id: Iba24363f5b9ea70392a68885cf5374800ab58549
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/50397
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/kernelconfig.py
M lib/vdsm/network/api.py
M tests/configNetworkTests.py
M tests/functional/networkTests.py
4 files changed, 83 insertions(+), 30 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/50397
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iba24363f5b9ea70392a68885cf5374800ab58549
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches