Change in vdsm[master]: ipwrapper: unbreak oper_up

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: ipwrapper: unbreak oper_up
..


Patch Set 1: Verified+1

testGetLink OK

-- 
To view, visit https://gerrit.ovirt.org/54054
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd3b1837df9e5ae3f60814df1b912b5768c736e3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ipwrapper: unbreak oper_up

[danken]

Dan Kenigsberg has uploaded a new change for review.

Change subject: ipwrapper: unbreak oper_up
..

ipwrapper: unbreak oper_up

commit 65636d51 removed ipwrapper.Link.flags, but left behind a method
using it.

Fix the glitch and have the method tested.

Change-Id: Icd3b1837df9e5ae3f60814df1b912b5768c736e3
Signed-off-by: Dan Kenigsberg 
---
M lib/vdsm/ipwrapper.py
M tests/network/ipwrapper_test.py
2 files changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/54054/1

diff --git a/lib/vdsm/ipwrapper.py b/lib/vdsm/ipwrapper.py
index fb61916..499fa42 100644
--- a/lib/vdsm/ipwrapper.py
+++ b/lib/vdsm/ipwrapper.py
@@ -225,7 +225,7 @@
 
 @property
 def oper_up(self):
-return bool(self.flags & self.IFF_RUNNING)
+return bool(link.get_link(self.name)['flags'] & self.IFF_RUNNING)
 
 def get_promisc(self):
 return bool(link.get_link(self.name)['flags'] & self.IFF_PROMISC)
diff --git a/tests/network/ipwrapper_test.py b/tests/network/ipwrapper_test.py
index 6499de0..4353d25 100644
--- a/tests/network/ipwrapper_test.py
+++ b/tests/network/ipwrapper_test.py
@@ -109,6 +109,7 @@
 def testGetLink(self):
 link = ipwrapper.getLink(self._bridge.devName)
 self.assertTrue(link.isBRIDGE)
+self.assertTrue(link.oper_up)
 self.assertEqual(link.master, None)
 self.assertEqual(link.name, self._bridge.devName)
 


-- 
To view, visit https://gerrit.ovirt.org/54054
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd3b1837df9e5ae3f60814df1b912b5768c736e3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ipwrapper: unbreak oper_up

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ipwrapper: unbreak oper_up
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54054
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd3b1837df9e5ae3f60814df1b912b5768c736e3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: import missing module in functional/utils

[edwardh]

Edward Haas has posted comments on this change.

Change subject: tests: import missing module in functional/utils
..


Patch Set 3: Verified+1

passing tests (including functional net)

-- 
To view, visit https://gerrit.ovirt.org/53529
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefce053c06527e0745e22c3bd0d9cfd3a0a7084a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: extract destroyVm helper

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: extract destroyVm helper
..


Patch Set 1: Verified+1

verified with 53931 and 53747 stopping a running VM various way. This (trivial) 
patch had no regressions.

-- 
To view, visit https://gerrit.ovirt.org/53932
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id152a7aae3d4f644f34703f7f0b5f98035e4e295
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: clean and modernize the destroy() path

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: clean and modernize the destroy() path
..


Patch Set 1: Verified+1

verified with 53932 and 53747 stopping a running VM various way. This (trivial) 
patch had no regressions.

-- 
To view, visit https://gerrit.ovirt.org/53931
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46296fe7ac6c13e064014298148f518ea6b1e1d8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: adding StorageDomain.activateHsm()

[laravot]

Liron Aravot has uploaded a new change for review.

Change subject: adding StorageDomain.activateHsm()
..

adding StorageDomain.activateHsm()

Change-Id: Ic661b44b060ddfeeb2a2caedb2662c6102b950e0
Signed-off-by: lara...@redhat.com 
---
M client/vdsClient.py
M vdsm/API.py
M vdsm/rpc/BindingXMLRPC.py
M vdsm/rpc/vdsmapi-schema.json
M vdsm/storage/hsm.py
M vdsm/storage/sp.py
6 files changed, 96 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/43102/1

diff --git a/client/vdsClient.py b/client/vdsClient.py
index 01f2211..9c42228 100755
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -647,6 +647,14 @@
 return dom['status']['code'], dom['status']['message']
 return 0, ''
 
+def activateStorageDomainHsm(self, args):
+sdUUID = args[0]
+spUUID = args[1]
+dom = self.s.activateStorageDomainHsm(sdUUID, spUUID)
+if dom['status']['code']:
+return dom['status']['code'], dom['status']['message']
+return 0, ''
+
 def deactivateStorageDomain(self, args):
 sdUUID = args[0]
 spUUID = args[1]
@@ -2502,6 +2510,10 @@
  'Get list of VMs from the'
  'given backup domain'
  )),
+'updateStorageDomainVmData': (serv.updateStorageDomainVmData,
+  ('   ',
+   'Update VM on a Backup domain'
+   )),
 'validateStorageDomain': (serv.validateStorageDomain,
   ('',
'Validate storage domain'
@@ -2511,6 +2523,12 @@
'Activate a storage domain that is already '
'a member in a storage pool.'
)),
+'activateStorageDomainHsm': (serv.activateStorageDomainHsm,
+ (' ',
+  'Activate a storage domain that is '
+  'already a member in a storage pool '
+  'that operates without Spm.'
+  )),
 'deactivateStorageDomain': (serv.deactivateStorageDomain,
 ('   ',
diff --git a/vdsm/API.py b/vdsm/API.py
index 8af2ad0..73f1a1f 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -991,6 +991,9 @@
 def activate(self, storagepoolID):
 return self._irs.activateStorageDomain(self._UUID, storagepoolID)
 
+def activateHsm(self, storagepoolID):
+return self._irs.activateStorageDomainHsm(self._UUID, storagepoolID)
+
 def attach(self, storagepoolID):
 return self._irs.attachStorageDomain(self._UUID, storagepoolID)
 
@@ -1108,7 +,8 @@
 return self._irs.fenceSpmStorage(self._UUID, lastOwner, lastLver)
 
 def getBackedUpVmsInfo(self, storagedomainID, vmList):
-return self._irs.getVmsInfo(self._UUID, storagedomainID, vmList)
+return self._irs.getBackedUpVmsInfo(self._UUID,
+storagedomainID, vmList)
 
 def getBackedUpVmsList(self, storagedomainID):
 return self._irs.getVmsList(self._UUID, storagedomainID)
diff --git a/vdsm/rpc/BindingXMLRPC.py b/vdsm/rpc/BindingXMLRPC.py
index bd86804..0ab159f 100644
--- a/vdsm/rpc/BindingXMLRPC.py
+++ b/vdsm/rpc/BindingXMLRPC.py
@@ -607,6 +607,10 @@
 domain = API.StorageDomain(sdUUID)
 return domain.activate(spUUID)
 
+def domainActivateHsm(self, sdUUID, spUUID):
+domain = API.StorageDomain(sdUUID)
+return domain.activateHsm(spUUID)
+
 def domainAttach(self, sdUUID, spUUID, options=None):
 domain = API.StorageDomain(sdUUID)
 return domain.attach(spUUID)
@@ -1101,6 +1105,7 @@
  'upgradeStorageDomainVersion'),
 (self.domainGetBackedUpVmsInfo,
 'getStorageDomainBackedUpVmsInfo'),
+(self.domainActivateHsm, 'activateStorageDomainHsm'),
 (self.domainUpdateVMData, 'updateStorageDomainVmData'))
 
 def getIrsMethods(self):
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 96d7661..2173ac2 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -4968,6 +4968,22 @@
  'data': {'storagedomainID': 'UUID', 'storagepoolID': 'UUID'}}
 
 ##
+# @StorageDomain.activateHsm:
+#
+# Activate an attached but inactive Storage Domain.
+# Can be used only in Storage Pools that operate without SPM.
+#
+# @storagedomainID:  The UUID of the Storage Domain
+#
+# @storagepoolID:The UUID of the Storage Pool to which the Storage Domain
+#is attached
+#
+# Since: 4.18.0

Change in vdsm[master]: adding StorageDomain.activateHsm()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: adding StorageDomain.activateHsm()
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/43102
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic661b44b060ddfeeb2a2caedb2662c6102b950e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: adding StorageDomain.removeVmData()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: adding StorageDomain.removeVmData()
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/43103
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic964ac5c9cb57df881b895356a203529ab2a171a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: adding StorageDomain.activateHsm()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: adding StorageDomain.activateHsm()
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/43153
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68eccd300b8ba0cc45b2485f978eb3ae367c16e2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: adding StorageDomain.activateHsm()

[laravot]

Liron Aravot has abandoned this change.

Change subject: adding StorageDomain.activateHsm()
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/43153
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I68eccd300b8ba0cc45b2485f978eb3ae367c16e2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: adding StorageDomain.activateHsm()

[laravot]

Liron Aravot has uploaded a new change for review.

Change subject: adding StorageDomain.activateHsm()
..

adding StorageDomain.activateHsm()

Change-Id: I68eccd300b8ba0cc45b2485f978eb3ae367c16e2
Signed-off-by: lara...@redhat.com 
---
M client/vdsClient.py
M vdsm/API.py
M vdsm/rpc/BindingXMLRPC.py
M vdsm/rpc/vdsmapi-schema.json
M vdsm/storage/hsm.py
M vdsm/storage/sp.py
M vdsm/storage/storage_exception.py
7 files changed, 134 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/43153/4

diff --git a/client/vdsClient.py b/client/vdsClient.py
index d59ae7c..6169be7 100755
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -647,6 +647,14 @@
 return dom['status']['code'], dom['status']['message']
 return 0, ''
 
+def activateStorageDomainHsm(self, args):
+sdUUID = args[0]
+spUUID = args[1]
+dom = self.s.activateStorageDomainHsm(sdUUID, spUUID)
+if dom['status']['code']:
+return dom['status']['code'], dom['status']['message']
+return 0, ''
+
 def deactivateStorageDomain(self, args):
 sdUUID = args[0]
 spUUID = args[1]
@@ -2502,6 +2510,10 @@
'Get list of VMs from the'
'given backup domain'
)),
+'updateStorageDomainVmData': (serv.updateStorageDomainVmData,
+  ('   ',
+   'Update VM on a Backup domain'
+   )),
 'validateStorageDomain': (serv.validateStorageDomain,
   ('',
'Validate storage domain'
@@ -2511,6 +2523,12 @@
'Activate a storage domain that is already '
'a member in a storage pool.'
)),
+'activateStorageDomainHsm': (serv.activateStorageDomainHsm,
+ (' ',
+  'Activate a storage domain that is '
+  'already a member in a storage pool '
+  'that operates without Spm.'
+  )),
 'deactivateStorageDomain': (serv.deactivateStorageDomain,
 ('   ',
diff --git a/vdsm/API.py b/vdsm/API.py
index bc47e3f..3703d69 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -991,6 +991,9 @@
 def activate(self, storagepoolID):
 return self._irs.activateStorageDomain(self._UUID, storagepoolID)
 
+def activateHsm(self, storagepoolID):
+return self._irs.activateStorageDomainHsm(self._UUID, storagepoolID)
+
 def attach(self, storagepoolID):
 return self._irs.attachStorageDomain(self._UUID, storagepoolID)
 
@@ -1109,7 +1112,8 @@
 return self._irs.fenceSpmStorage(self._UUID, lastOwner, lastLver)
 
 def getBackedUpVmsInfo(self, storagedomainID, vmList):
-return self._irs.getVmsInfo(self._UUID, storagedomainID, vmList)
+return self._irs.getBackedUpVmsInfo(self._UUID,
+storagedomainID, vmList)
 
 def getBackedUpVmsList(self, storagedomainID):
 return self._irs.getVmsList(self._UUID, storagedomainID)
diff --git a/vdsm/rpc/BindingXMLRPC.py b/vdsm/rpc/BindingXMLRPC.py
index 039d564..c6fb25d 100644
--- a/vdsm/rpc/BindingXMLRPC.py
+++ b/vdsm/rpc/BindingXMLRPC.py
@@ -607,6 +607,10 @@
 domain = API.StorageDomain(sdUUID)
 return domain.activate(spUUID)
 
+def domainActivateHsm(self, sdUUID, spUUID):
+domain = API.StorageDomain(sdUUID)
+return domain.activateHsm(spUUID)
+
 def domainAttach(self, sdUUID, spUUID, options=None):
 domain = API.StorageDomain(sdUUID)
 return domain.attach(spUUID)
@@ -1099,7 +1103,8 @@
  'detachAnyStoragePoolHsm'),
 (self.domainGetStoredVmsInfo, 'getStorageDomainStoredVmsInfo'),
 (self.domainUpgradeVersion, 'upgradeStorageDomainVersion'),
-(self.domainUpdateVMData, 'updateStorageDomainVmData'))
+(self.domainUpdateVMData, 'updateStorageDomainVmData'),
+(self.domainActivateHsm, 'activateStorageDomainHsm'))
 
 def getIrsMethods(self):
 return ((self.domainActivate, 'activateStorageDomain'),
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index df11b53..d65ae22 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -4968,6 +4968,22 @@
  'data': {'storagedomainID': 'UUID', 'storagepoolID': 'UUID'}}
 
 ##
+# @StorageDomain.activateHsm:
+#
+# Activate an attached but inactive Storage Domain.
+# Can be used only in Storage Pools 

Change in vdsm[master]: adding StorageDomain.removeVmData()

[laravot]

Liron Aravot has uploaded a new change for review.

Change subject: adding StorageDomain.removeVmData()
..

adding StorageDomain.removeVmData()

Change-Id: Ic964ac5c9cb57df881b895356a203529ab2a171a
Signed-off-by: lara...@redhat.com 
---
M client/vdsClient.py
M vdsm/API.py
M vdsm/rpc/BindingXMLRPC.py
M vdsm/rpc/vdsmapi-schema.json
M vdsm/storage/hsm.py
M vdsm/storage/sp.py
6 files changed, 90 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/43103/2

diff --git a/client/vdsClient.py b/client/vdsClient.py
index 9c42228..2ddb536 100755
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -978,6 +978,15 @@
 return res['status']['code'], res['status']['message']
 return 0, ''
 
+def removeStorageDomainVmData(self, args):
+spUUID = args[0]
+vmUUID = args[1]
+sdUUID = args[2]
+res = self.s.removeStorageDomainVmData(sdUUID, spUUID, vmUUID)
+if res['status']['code']:
+return res['status']['code'], res['status']['message']
+return 0, ''
+
 def _parseDomainsMap(self, domMapString):
 """
 Parse domains map string: "sdUUID1=status1,sdUUID2=status2,..."
diff --git a/vdsm/API.py b/vdsm/API.py
index 73f1a1f..0748598 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1062,6 +1062,10 @@
 return self._irs.updateStorageDomainVmData(self._UUID, storagepoolID,
vmID, vmData)
 
+def removeVMData(self, storagepoolID, vmID):
+return self._irs.removeStorageDomainVmData(self._UUID, storagepoolID,
+   vmID)
+
 def validate(self):
 return self._irs.validateStorageDomain(self._UUID)
 
diff --git a/vdsm/rpc/BindingXMLRPC.py b/vdsm/rpc/BindingXMLRPC.py
index 0ab159f..d227d7f 100644
--- a/vdsm/rpc/BindingXMLRPC.py
+++ b/vdsm/rpc/BindingXMLRPC.py
@@ -644,6 +644,10 @@
 domain = API.StorageDomain(sdUUID)
 return domain.updateVMData(spUUID, vmUUID, vmData)
 
+def domainRemoveVMData(self, sdUUID, spUUID, vmUUID):
+domain = API.StorageDomain(sdUUID)
+return domain.removeVMData(spUUID, vmUUID)
+
 def domainDetachAnyStoragePoolHsm(self, sdUUID, hostID):
 domain = API.StorageDomain(sdUUID)
 return domain.detachAnyStoragePoolHsm(sdUUID, hostID)
@@ -1106,7 +1110,8 @@
 (self.domainGetBackedUpVmsInfo,
 'getStorageDomainBackedUpVmsInfo'),
 (self.domainActivateHsm, 'activateStorageDomainHsm'),
-(self.domainUpdateVMData, 'updateStorageDomainVmData'))
+(self.domainUpdateVMData, 'updateStorageDomainVmData'),
+(self.domainRemoveVMData, 'removeStorageDomainVmData'))
 
 def getIrsMethods(self):
 return ((self.domainActivate, 'activateStorageDomain'),
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 2173ac2..dee5e09 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -5051,6 +5051,23 @@
  'data': {'storagedomainID': 'UUID', 'storagepoolID': 'UUID',
   'vmID': 'UUID', 'vmData' : 'str'}}
 
+##
+# @StorageDomain.removeVMData:
+#
+# Remove a previously saved virtual machine definitio from a backup domain.
+#
+# @storagedomainID:  The backup Storage Domain id
+#
+# @storagepoolID:The UUID of the Storage Pool
+#
+# @vmUUID:   The id of the VM
+#
+# Since: 4.18.0
+##
+{'command': {'class': 'StorageDomain', 'name': 'removeVMData'},
+ 'data': {'storagedomainID': 'UUID', 'storagepoolID': 'UUID',
+  'vmUUID': 'UUID'}}
+
 
 ##
 # @StorageDomainCreateArgumentsBlock:
@@ -6192,6 +6209,24 @@
  'data': {'storagepoolID': 'UUID', 'vmUUID': 'UUID',
   '*storagedomainID': 'UUID'}}
 
+
+##
+# @StoragePool.removeVM:
+#
+# Remove a previously saved virtual machine definition.
+#
+# @storagepoolID:The UUID of the Storage Pool
+#
+# @vmUUID:   Remove the saved definition of the VM with this UUID
+#
+# @storagedomainID:  #optional The Storage Domain where the VM is stored
+#
+# Since: 4.10.0
+##
+{'command': {'class': 'StoragePool', 'name': 'removeVM'},
+ 'data': {'storagepoolID': 'UUID', 'vmUUID': 'UUID',
+  '*storagedomainID': 'UUID'}}
+
 ## Category: @Task 
 ##
 # @Task:
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 8302a52..346544a 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -1490,8 +1490,18 @@
 pool = self._prepareUpdateVM(spUUID, sdUUID)
 pool.updateVMHSM(sdUUID, vmUUID, vmData)
 
+def _prepareRemoveVm(self, spUUID, sdUUID, vmUUID):
+vars.task.getSharedLock(STORAGE, spUUID)
+pool = self.getPool(spUUID)
+if not sdUUID or sdUUID == sd.BLANK_UUID:
+sdUUID = pool.masterDomain.sdUUID
+
+

Change in vdsm[master]: adding StorageDomain.activateHsm()

[laravot]

Liron Aravot has abandoned this change.

Change subject: adding StorageDomain.activateHsm()
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/43102
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic661b44b060ddfeeb2a2caedb2662c6102b950e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: adding StorageDomain.removeVmData()

[laravot]

Liron Aravot has abandoned this change.

Change subject: adding StorageDomain.removeVmData()
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/43103
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic964ac5c9cb57df881b895356a203529ab2a171a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: adding StorageDomain.removeVmData()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: adding StorageDomain.removeVmData()
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/43154
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic53b19a43850341ee488b50fbb339fdf68c1a048
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: adding StorageDomain.removeVmData()

[laravot]

Liron Aravot has uploaded a new change for review.

Change subject: adding StorageDomain.removeVmData()
..

adding StorageDomain.removeVmData()

Change-Id: Ic53b19a43850341ee488b50fbb339fdf68c1a048
Signed-off-by: lara...@redhat.com 
---
M client/vdsClient.py
M vdsm/API.py
M vdsm/rpc/BindingXMLRPC.py
M vdsm/rpc/vdsmapi-schema.json
M vdsm/storage/hsm.py
M vdsm/storage/sp.py
6 files changed, 106 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/43154/4

diff --git a/client/vdsClient.py b/client/vdsClient.py
index 6169be7..e2123e1 100755
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -978,6 +978,15 @@
 return res['status']['code'], res['status']['message']
 return 0, ''
 
+def removeStorageDomainVmData(self, args):
+spUUID = args[0]
+vmUUID = args[1]
+sdUUID = args[2]
+res = self.s.removeStorageDomainVmData(sdUUID, spUUID, vmUUID)
+if res['status']['code']:
+return res['status']['code'], res['status']['message']
+return 0, ''
+
 def _parseDomainsMap(self, domMapString):
 """
 Parse domains map string: "sdUUID1=status1,sdUUID2=status2,..."
diff --git a/vdsm/API.py b/vdsm/API.py
index 3703d69..ca37aff 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1063,6 +1063,10 @@
 return self._irs.updateStorageDomainVmData(self._UUID, storagepoolID,
vmID, vmData)
 
+def removeVMData(self, storagepoolID, vmID):
+return self._irs.removeStorageDomainVmData(self._UUID, storagepoolID,
+   vmID)
+
 def validate(self):
 return self._irs.validateStorageDomain(self._UUID)
 
diff --git a/vdsm/rpc/BindingXMLRPC.py b/vdsm/rpc/BindingXMLRPC.py
index c6fb25d..9ee5cdd 100644
--- a/vdsm/rpc/BindingXMLRPC.py
+++ b/vdsm/rpc/BindingXMLRPC.py
@@ -644,6 +644,10 @@
 domain = API.StorageDomain(sdUUID)
 return domain.updateVMData(spUUID, vmUUID, vmData)
 
+def domainRemoveVMData(self, sdUUID, spUUID, vmUUID):
+domain = API.StorageDomain(sdUUID)
+return domain.removeVMData(spUUID, vmUUID)
+
 def domainDetachAnyStoragePoolHsm(self, sdUUID, hostID):
 domain = API.StorageDomain(sdUUID)
 return domain.detachAnyStoragePoolHsm(sdUUID, hostID)
@@ -1104,7 +1108,8 @@
 (self.domainGetStoredVmsInfo, 'getStorageDomainStoredVmsInfo'),
 (self.domainUpgradeVersion, 'upgradeStorageDomainVersion'),
 (self.domainUpdateVMData, 'updateStorageDomainVmData'),
-(self.domainActivateHsm, 'activateStorageDomainHsm'))
+(self.domainActivateHsm, 'activateStorageDomainHsm'),
+(self.domainRemoveVMData, 'removeStorageDomainVmData'))
 
 def getIrsMethods(self):
 return ((self.domainActivate, 'activateStorageDomain'),
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index d65ae22..afbd960 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -5051,6 +5051,23 @@
  'data': {'storagedomainID': 'UUID', 'storagepoolID': 'UUID',
   'vmID': 'UUID', 'vmData' : 'str'}}
 
+##
+# @StorageDomain.removeVMData:
+#
+# Remove a previously saved virtual machine definitio from a backup domain.
+#
+# @storagedomainID:  The backup Storage Domain id
+#
+# @storagepoolID:The UUID of the Storage Pool
+#
+# @vmUUID:   The id of the VM
+#
+# Since: 4.18.0
+##
+{'command': {'class': 'StorageDomain', 'name': 'removeVMData'},
+ 'data': {'storagedomainID': 'UUID', 'storagepoolID': 'UUID',
+  'vmUUID': 'UUID'}}
+
 
 ##
 # @StorageDomainCreateArgumentsBlock:
@@ -6192,6 +6209,24 @@
  'data': {'storagepoolID': 'UUID', 'vmUUID': 'UUID',
   '*storagedomainID': 'UUID'}}
 
+
+##
+# @StoragePool.removeVM:
+#
+# Remove a previously saved virtual machine definition.
+#
+# @storagepoolID:The UUID of the Storage Pool
+#
+# @vmUUID:   Remove the saved definition of the VM with this UUID
+#
+# @storagedomainID:  #optional The Storage Domain where the VM is stored
+#
+# Since: 4.10.0
+##
+{'command': {'class': 'StoragePool', 'name': 'removeVM'},
+ 'data': {'storagepoolID': 'UUID', 'vmUUID': 'UUID',
+  '*storagedomainID': 'UUID'}}
+
 ## Category: @Task 
 ##
 # @Task:
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index db82566..dda8895 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -1490,8 +1490,18 @@
 pool = self._prepareUpdateVM(spUUID, sdUUID)
 pool.updateVMHSM(sdUUID, vmUUID, vmData)
 
+def _prepareRemoveVm(self, spUUID, sdUUID, vmUUID):
+vars.task.getSharedLock(STORAGE, spUUID)
+pool = self.getPool(spUUID)
+if not sdUUID or sdUUID == sd.BLANK_UUID:
+

Change in vdsm[master]: adding StorageDomain.updateVmData()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: adding StorageDomain.updateVmData()
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/42930
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id79e7d6375e60216d1eb9a58e5a5c087db98625f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: adding StorageDomain.removeVmData()

[laravot]

Liron Aravot has abandoned this change.

Change subject: adding StorageDomain.removeVmData()
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/43154
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic53b19a43850341ee488b50fbb339fdf68c1a048
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: adding StorageDomain.updateVmData()

[laravot]

Liron Aravot has uploaded a new change for review.

Change subject: adding StorageDomain.updateVmData()
..

adding StorageDomain.updateVmData()

Change-Id: Id79e7d6375e60216d1eb9a58e5a5c087db98625f
Signed-off-by: lara...@redhat.com 
---
M client/vdsClient.py
M vdsm/API.py
M vdsm/rpc/BindingXMLRPC.py
M vdsm/rpc/vdsmapi-schema.json
M vdsm/storage/hsm.py
M vdsm/storage/sp.py
6 files changed, 79 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/42930/5

diff --git a/client/vdsClient.py b/client/vdsClient.py
index c3628c5..d59ae7c 100755
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -709,6 +709,16 @@
 return dom['status']['code'], dom['status']['message']
 return 0, ''
 
+def updateStorageDomainVmData(self, args):
+sdUUID = args[0]
+spUUID = args[1]
+vmUUID = args[2]
+vmData = args[3]
+dom = self.s.updateStorageDomainVmData(sdUUID, spUUID, vmUUID, vmData)
+if dom['status']['code']:
+return dom['status']['code'], dom['status']['message']
+return 0, ''
+
 def forcedDetachStorageDomain(self, args):
 sdUUID = args[0]
 spUUID = args[1]
diff --git a/vdsm/API.py b/vdsm/API.py
index 3007d93..bc47e3f 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1056,6 +1056,10 @@
 return self._irs.getStorageDomainStoredVmsInfo(storagepoolID,
self._UUID, vmList)
 
+def updateVMData(self, storagepoolID, vmID, vmData):
+return self._irs.updateStorageDomainVmData(self._UUID, storagepoolID,
+   vmID, vmData)
+
 def validate(self):
 return self._irs.validateStorageDomain(self._UUID)
 
diff --git a/vdsm/rpc/BindingXMLRPC.py b/vdsm/rpc/BindingXMLRPC.py
index 5294e6a..039d564 100644
--- a/vdsm/rpc/BindingXMLRPC.py
+++ b/vdsm/rpc/BindingXMLRPC.py
@@ -636,6 +636,10 @@
 domain = API.StorageDomain(sdUUID)
 return domain.detachHsm(spUUID, force)
 
+def domainUpdateVMData(self, sdUUID, spUUID, vmUUID, vmData):
+domain = API.StorageDomain(sdUUID)
+return domain.updateVMData(spUUID, vmUUID, vmData)
+
 def domainDetachAnyStoragePoolHsm(self, sdUUID, hostID):
 domain = API.StorageDomain(sdUUID)
 return domain.detachAnyStoragePoolHsm(sdUUID, hostID)
@@ -1094,7 +1098,8 @@
 (self.domainDetachAnyStoragePoolHsm,
  'detachAnyStoragePoolHsm'),
 (self.domainGetStoredVmsInfo, 'getStorageDomainStoredVmsInfo'),
-(self.domainUpgradeVersion, 'upgradeStorageDomainVersion'))
+(self.domainUpgradeVersion, 'upgradeStorageDomainVersion'),
+(self.domainUpdateVMData, 'updateStorageDomainVmData'))
 
 def getIrsMethods(self):
 return ((self.domainActivate, 'activateStorageDomain'),
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 7d514e3..df11b53 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -5017,6 +5017,26 @@
  'returns': 'OVFMap'}
 
 ##
+# @StorageDomain.updateVMData:
+#
+# Store virtual machine OVF file on a backup Storage Domain
+#
+# @storagepoolID:The UUID of the Storage Pool
+#
+# @storagedomainID:  The backup Storage Domain id
+#
+# @vmID: The id of the VM
+#
+# @vmData:   The VM definition in OVF format
+#
+# Since: 4.18.0
+##
+{'command': {'class': 'StorageDomain', 'name': 'updateVMData'},
+ 'data': {'storagedomainID': 'UUID', 'storagepoolID': 'UUID',
+  'vmID': 'UUID', 'vmData' : 'str'}}
+
+
+##
 # @StorageDomainCreateArgumentsBlock:
 #
 # Creation argument for Block-based Storage Domains.
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index b1687da..1c76208 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -1418,6 +1418,15 @@
 pool = self.getPool(spUUID)
 pool.setVolumeLegality(sdUUID, imgUUID, volUUID, legality)
 
+def _prepareUpdateVM(self, spUUID, sdUUID):
+vars.task.getSharedLock(STORAGE, spUUID)
+pool = self.getPool(spUUID)
+if not sdUUID or sdUUID == sd.BLANK_UUID:
+sdUUID = pool.masterDomain.sdUUID
+
+vars.task.getExclusiveLock(STORAGE, "vms_" + sdUUID)
+return pool
+
 @public
 def updateVM(self, spUUID, vmList, sdUUID=None, options=None):
 """
@@ -1438,15 +1447,31 @@
 :type sdUUID: UUID
 :param options: ?
 """
-vars.task.getSharedLock(STORAGE, spUUID)
-pool = self.getPool(spUUID)
-if not sdUUID or sdUUID == sd.BLANK_UUID:
-sdUUID = pool.masterDomain.sdUUID
-
-vars.task.getExclusiveLock(STORAGE, "vms_" + sdUUID)
+pool = self._prepareUpdateVM(spUUID, sdUUID)
 pool.updateVM(vmList=vmList, sdUUID=sdUUID)
 
 @public
+def 

Change in vdsm[master]: adding the StorageDomain.upgradeVersion verb

[laravot]

Liron Aravot has abandoned this change.

Change subject: adding the StorageDomain.upgradeVersion verb
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/42478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Id8fb87c6e04e48072ec90d07a0f4c7a61411a808
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: adding the StorageDomain.upgradeVersion verb

[laravot]

Liron Aravot has uploaded a new change for review.

Change subject: adding the StorageDomain.upgradeVersion verb
..

adding the StorageDomain.upgradeVersion verb

Change-Id: Id8fb87c6e04e48072ec90d07a0f4c7a61411a808
Signed-off-by: lara...@redhat.com 
---
M client/vdsClient.py
M vdsm/API.py
M vdsm/rpc/BindingXMLRPC.py
M vdsm/rpc/vdsmapi-schema.json
M vdsm/storage/hsm.py
M vdsm/storage/imageRepository/formatConverter.py
M vdsm/storage/sp.py
M vdsm/storage/storage_exception.py
8 files changed, 148 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/42478/7

diff --git a/client/vdsClient.py b/client/vdsClient.py
index e17ba76..c3628c5 100755
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -682,6 +682,15 @@
 return dom['status']['code'], dom['status']['message']
 return 0, ''
 
+def upgradeStorageDomainVersion(self, args):
+sdUUID = args[0]
+spUUID = args[1]
+version = args[2]
+dom = self.s.upgradeStorageDomainVersion(sdUUID, spUUID, version)
+if dom['status']['code']:
+return dom['status']['code'], dom['status']['message']
+return 0, ''
+
 def detachStorageDomainAnyStoragePoolHsm(self, args):
 sdUUID = args[0]
 hostID = args[1]
@@ -2521,6 +2530,12 @@
 'domain metadata is not modified to'
 'reflect its detached.'
 )),
+'upgradeStorageDomainVersion': (serv.upgradeStorageDomainVersion,
+('  ',
+ 'Upgrades a storage domain that is'
+ 'part of connected storage pool to'
+ 'the given version.'
+ )),
 'detachStorageDomainAnyStoragePoolHsm':
 (serv.detachStorageDomainAnyStoragePoolHsm,
  ('' '',
diff --git a/vdsm/API.py b/vdsm/API.py
index 3212616..3007d93 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1023,6 +1023,10 @@
 def detachAnyStoragePoolHsm(self, hostID):
 return self._irs.detachAnyStoragePoolHsm(self._UUID, hostID)
 
+def upgradeVersion(self, storagepoolID, version):
+return self._irs.upgradeStorageDomainVersion(self._UUID, storagepoolID,
+ version)
+
 def extend(self, storagepoolID, devlist, force=False):
 return self._irs.extendStorageDomain(self._UUID, storagepoolID,
  devlist, force)
diff --git a/vdsm/rpc/BindingXMLRPC.py b/vdsm/rpc/BindingXMLRPC.py
index 70db4ed..5294e6a 100644
--- a/vdsm/rpc/BindingXMLRPC.py
+++ b/vdsm/rpc/BindingXMLRPC.py
@@ -640,6 +640,10 @@
 domain = API.StorageDomain(sdUUID)
 return domain.detachAnyStoragePoolHsm(sdUUID, hostID)
 
+def domainUpgradeVersion(self, sdUUID, spUUID, version):
+domain = API.StorageDomain(sdUUID)
+return domain.upgradeVersion(spUUID, version)
+
 def domainDetachForced(self, sdUUID, spUUID, options=None):
 domain = API.StorageDomain(sdUUID)
 return domain.detach(spUUID, None, None, force=True)
@@ -1089,7 +1093,8 @@
 (self.domainDetachHsm, 'detachStorageDomainHsm'),
 (self.domainDetachAnyStoragePoolHsm,
  'detachAnyStoragePoolHsm'),
-(self.domainGetStoredVmsInfo, 'getStorageDomainStoredVmsInfo'))
+(self.domainGetStoredVmsInfo, 'getStorageDomainStoredVmsInfo'),
+(self.domainUpgradeVersion, 'upgradeStorageDomainVersion'))
 
 def getIrsMethods(self):
 return ((self.domainActivate, 'activateStorageDomain'),
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 86cfb6e..7d514e3 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -5173,6 +5173,22 @@
  'data': {'storagedomainID': 'UUID', 'hostID' : 'int'}}
 
 ##
+# @StorageDomain.upgradeVersion:
+#
+# Upgrades the StorageDomain version
+#
+# @storagedomainID:  The UUID of the Storage Domain
+#
+# @storagepoolID:The UUID of the Storage Pool
+#
+# @version:The target version
+#
+# Since: 4.18.0
+##
+{'command': {'class': 'StorageDomain', 'name': 'upgradeVersion'},
+ 'data': {'storagedomainID': 'UUID', 'storagepoolID': 'UUID', 'version': 
'int'}}
+
+##
 # @StorageDomain.extend:
 #
 # Extend a block-based Storage Domain onto more block devices.
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 95c4803..b1687da 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -844,6 +844,11 @@
 pool.detachSDHsm(sdUUID)
 
 @public
+def upgradeStorageDomainVersion(self, sdUUID, spUUID, version):
+pool = self.getPool(spUUID)
+pool.upgradeDomainFormat(sdUUID, 

Change in vdsm[master]: adding the StorageDomain.upgradeVersion verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: adding the StorageDomain.upgradeVersion verb
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/42478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8fb87c6e04e48072ec90d07a0f4c7a61411a808
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: adding StorageDomain.updateVmData()

[laravot]

Liron Aravot has abandoned this change.

Change subject: adding StorageDomain.updateVmData()
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/42930
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Id79e7d6375e60216d1eb9a58e5a5c087db98625f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: import missing module in functional/utils

[edwardh]

Edward Haas has posted comments on this change.

Change subject: tests: import missing module in functional/utils
..


Patch Set 3: Code-Review+1

Thank you

-- 
To view, visit https://gerrit.ovirt.org/53529
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefce053c06527e0745e22c3bd0d9cfd3a0a7084a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: rng: Rng device should not depend on caps.py

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: rng: Rng device should not depend on caps.py
..


Patch Set 5: Verified+1

verified using the tests and running a VM with 'random' souce on rng device.

-- 
To view, visit https://gerrit.ovirt.org/53558
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If74f6c262f6a0bd4ed6a968e17e883e1e264ed54
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Add `vm' argument to underlying_device_info methods

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Add `vm' argument to underlying_device_info methods
..


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/53676/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: virt: Add `vm' argument to underlying_device_info methods
Line 8: 
Line 9: One of the methods (storage) needs it to access VM related
Line 10: information (arch).  It's perhaps better to pass the whole Vm instance
> and vm.log also, but this is easier to replace
I'm aware of it, but as you say, vm.log is not a sufficient argument here.
Line 11: instead of adding more other arguments.  Perhaps we could remove some 
of
Line 12: the other underlying_device_info arguments when we've got `vm'.  
Perhaps
Line 13: we should take a different approach.  It's for discussion, but for now
Line 14: we take this path to make storage device handling movable out of Vm


Line 11: instead of adding more other arguments.  Perhaps we could remove some 
of
Line 12: the other underlying_device_info arguments when we've got `vm'.  
Perhaps
Line 13: we should take a different approach.  It's for discussion, but for now
Line 14: we take this path to make storage device handling movable out of Vm
Line 15: class.
> I think it is better to add only the specific argument in the place we need
Since we are going to make `domain' publicly accessible from Vm in another 
patch, we might think about passing `vm' instead of `domain'. Then we could 
also discard device_conf argument (and get it from `vm'). And this particular 
problem would be solved. Nevertheless I'm not sure whether exposing `vm' 
instances to these methods is a generally good idea, what do you think?
Line 16: 
Line 17: Change-Id: Ide9e8d105d6c14101f9ce367409af729a075b2df


-- 
To view, visit https://gerrit.ovirt.org/53676
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide9e8d105d6c14101f9ce367409af729a075b2df
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: virt: modernize vm* tests

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: tests: virt: modernize vm* tests
..


Patch Set 2: Code-Review-1

(7 comments)

https://gerrit.ovirt.org/#/c/54022/2/tests/vmApiTests.py
File tests/vmApiTests.py:

Line 51: list
no need to have a list here! I believe it's a python-modernize bug


https://gerrit.ovirt.org/#/c/54022/2/tests/vmOperationsTests.py
File tests/vmOperationsTests.py:

Line 343: self._offset = offset
Line 344: self._params = {}
Line 345: 
Line 346: def setSchedulerParameters(self, params):
Line 347: for k, v in list(params.items()):
ditto
Line 348: self._params[k] = int(v) + self._offset
Line 349: 
Line 350: def schedulerParameters(self):
Line 351: return self._params


https://gerrit.ovirt.org/#/c/54022/2/tests/vmStatsTests.py
File tests/vmStatsTests.py:

Line 234: self.samples = list(_FAKE_BULK_STATS.values())[0]
self.samples = list(_FAKE_BULK_STATS.values())[0]


Line 284: 
Line 285: def test_network_missing(self):
Line 286: # seen using SR-IOV
Line 287: 
Line 288: bulk_stats = list(_FAKE_BULK_STATS_SRIOV.values())[0]
next(six.itervalues(_FAKE_BULK_STATS_SRIOV)) would be a bit nicer.
Line 289: indexes = vmstats._find_bulk_stats_reverse_map(
Line 290: bulk_stats[0], 'net')
Line 291: self.assertTrue(indexes)
Line 292: 


https://gerrit.ovirt.org/#/c/54022/2/tests/vmTests.py
File tests/vmTests.py:

Line 64: from testValidation import slowtest
Line 65: from vmTestsData import CONF_TO_DOMXML_X86_64
Line 66: from vmTestsData import CONF_TO_DOMXML_PPC64
Line 67: import vmfakelib as fake
Line 68: import six
please import far above
Line 69: from six.moves import zip
Line 70: 
Line 71: 
Line 72: _VM_PARAMS = {


https://gerrit.ovirt.org/#/c/54022/2/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:

Line 24: from virt import vmexitreason
Line 25: 
Line 26: from testlib import permutations, expandPermutations
Line 27: from testlib import VdsmTestCase as TestCaseBase
Line 28: from six.moves import range
import belongs above
Line 29: 
Line 30: 
Line 31: class ExpiringCacheOperationTests(TestCaseBase):
Line 32: def setUp(self):


https://gerrit.ovirt.org/#/c/54022/2/tests/vmfakelib.py
File tests/vmfakelib.py:

Line 64: sec.usage_type = usage_type
Line 65: sec.description = description
Line 66: else:
Line 67: # (usage_type, usage_id) pair must be unique
Line 68: for sec in list(self.secrets.values()):
no need for list() call here.
Line 69: if sec.usage_type == usage_type and sec.usage_id == 
usage_id:
Line 70: raise Error(libvirt.VIR_ERR_INTERNAL_ERROR)
Line 71: sec = Secret(self, uuid, usage_type, usage_id, description)
Line 72: self.secrets[uuid] = sec


-- 
To view, visit https://gerrit.ovirt.org/54022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9324ef9d17df148ea38a03771b896132ec02e22
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: Add retry on full capacity

[ykaul]

Yaniv Kaul has posted comments on this change.

Change subject: migration: Add retry on full capacity
..


Patch Set 18:

Why is this a VDSM decision and not engine? What if by now, there's a better 
chance to migrate to a different host? Looks like a scheduling task to me, not 
a VDSM local task to do the retry.

-- 
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988fa2e501eb77d121668b22cc533b744a3dc755
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: import missing module in functional/utils

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: tests: import missing module in functional/utils
..


Patch Set 3: Verified+1

no more failures regarding not being able to import cache

-- 
To view, visit https://gerrit.ovirt.org/53529
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefce053c06527e0745e22c3bd0d9cfd3a0a7084a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: import missing module in functional/utils

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: import missing module in functional/utils
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53529
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefce053c06527e0745e22c3bd0d9cfd3a0a7084a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: Add retry on full capacity

[mbetak]

Martin Betak has posted comments on this change.

Change subject: migration: Add retry on full capacity
..


Patch Set 18: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988fa2e501eb77d121668b22cc533b744a3dc755
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: Enable lazy setting of incoming/outgoing limits

[mbetak]

Martin Betak has posted comments on this change.

Change subject: migration: Enable lazy setting of incoming/outgoing limits
..


Patch Set 14: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/53305
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79ab97f15788e4024c94d051e4aade713d760acf
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: Move saveState() out of constructor

[mbetak]

Martin Betak has posted comments on this change.

Change subject: vm: Move saveState() out of constructor
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/53950
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb38fdc06bf1a7b881cd64d2af45a93b16c935ea
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: response: Add support for specific error checking in is_error

[mbetak]

Martin Betak has posted comments on this change.

Change subject: response: Add support for specific error checking in is_error
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54036
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00d8d2914983f75293ece5ce05894ca3821b7b24
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: response: Add support for specific error checking in is_error

[mbetak]

Martin Betak has posted comments on this change.

Change subject: response: Add support for specific error checking in is_error
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/54036/1/tests/responseTests.py
File tests/responseTests.py:

Line 74: self.assertEqual(res[key], args[key])
Line 75: 
Line 76: def test_is_error(self):
Line 77: NAME = 'noVM'  # no special meaning, any error is fine
Line 78: NAME2 = 'hookError'
> let's add a specific testcase for this new code path
Done
Line 79: self.assertTrue(response.is_error(response.error(NAME)))
Line 80: 
Line 81: self.assertTrue(response.is_error(response.error(NAME), 
err=NAME))
Line 82: self.assertFalse(response.is_error(response.error(NAME), 
err=NAME2))


-- 
To view, visit https://gerrit.ovirt.org/54036
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00d8d2914983f75293ece5ce05894ca3821b7b24
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: tests: improve vmstats.disks coverage

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: improve vmstats.disks coverage
..


tests: improve vmstats.disks coverage

vmstats.disks() must be robust in presence of various missing
diks attributes. This patch adds the missing tests to make sure
all known misreportings are covered.

Backport-To: 3.6
Bug-Url: https://bugzilla.redhat.com/1281337
Bug-Url: https://bugzilla.redhat.com/1299480
Change-Id: I931d080d66b8a6087b05f01fbdce8fee0cd99039
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/50598
Reviewed-by: Milan Zamazal 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/53994
---
M tests/vmStatsTests.py
1 file changed, 36 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified
  Milan Zamazal: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/53994
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I931d080d66b8a6087b05f01fbdce8fee0cd99039
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: adding virt basic api module to supervdsm

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: virt: adding virt basic api module to supervdsm
..


Patch Set 2: Code-Review-1

ohhh.. you don't install the new file. add it to spec and makefile and then 
it'll reload it smoothly

-- 
To view, visit https://gerrit.ovirt.org/54004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9acf5a2f8fd14ac172bb6ea70bbc2aff8caf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: tests: extend coverage for vmstats.disks()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: extend coverage for vmstats.disks()
..


Patch Set 3:

* #1281337::Update tracker: OK
* #1299480::Update tracker: OK
* Set MODIFIED::bug 1281337#1281337IGNORE, not all related patches are 
closed, check 53991
* Set MODIFIED::bug 1281337bug 1299480#1299480IGNORE, not all 
related patches are closed, check 53056

-- 
To view, visit https://gerrit.ovirt.org/53993
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a257399988ae30955f0270f924a9a3a8e8a50b8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: tests: improve vmstats.disks coverage

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: tests: improve vmstats.disks coverage
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/53994
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I931d080d66b8a6087b05f01fbdce8fee0cd99039
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: tests: improve vmstats.disks coverage

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: improve vmstats.disks coverage
..


Patch Set 3:

* #1281337::Update tracker: OK
* #1299480::Update tracker: OK
* Set MODIFIED::bug 1281337#1281337IGNORE, not all related patches are 
closed, check 53991
* Set MODIFIED::bug 1281337bug 1299480#1299480IGNORE, not all 
related patches are closed, check 53056

-- 
To view, visit https://gerrit.ovirt.org/53994
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I931d080d66b8a6087b05f01fbdce8fee0cd99039
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Vm._getUnderlyingSoundDeviceInfo() moved to core.py

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Vm._getUnderlyingSoundDeviceInfo() moved to core.py
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/53616/2/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:

Line 246:  
> naming: what about "update_device_info"?
> this also feels like a staticmethod.

I'm not a big fan of static methods. I can see little benefit in using them and 
they are less flexible. E.g. even if nothing else, I prefer calling a utility 
method inside another method by cls._method() rather than 
ThatClassName._method(). And I can imagine doing something like

  for device_class in devices:
  device_class.update_device_info(...)

in future. But technically we can make this method static now, so I'm only 
lightly opposed to the suggestion.

> naming: what about "update_device_info"?

Good idea.


Line 252: :type domain: :class:`DomainDescriptor` instance
Line 253: :param sound_devices: current sound devices for update
Line 254: :type sound_devices: dictionary
Line 255: :param device_conf: current device configuration for update
Line 256: :type device_conf: dictionary
> I believe it is sufficient if you have this doc only in the base method, to
I agree.
Line 257: 
Line 258: """
Line 259: for x in domain.get_device_elements('sound'):
Line 260: alias = 
x.getElementsByTagName('alias')[0].getAttribute('name')


-- 
To view, visit https://gerrit.ovirt.org/53616
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05cb24e0a9776e21bd2546d62a56554d74559c61
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: tests: extend coverage for vmstats.disks()

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: extend coverage for vmstats.disks()
..


tests: extend coverage for vmstats.disks()

This patch extends the test coverage for vmstats.disks()

- make existing test helpers clearer avoiding default arguments
- make existing test clearer adding explicit data
- add test for zero-interval, which sometimes happens during
  migrations and it is already handled by the code.

Change-Id: I8a257399988ae30955f0270f924a9a3a8e8a50b8
Backport-To: 3.6
Bug-Url: https://bugzilla.redhat.com/1281337
Bug-Url: https://bugzilla.redhat.com/1299480
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/51854
Continuous-Integration: Jenkins CI
Reviewed-by: Milan Zamazal 
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/53993
---
M tests/vmStatsTests.py
1 file changed, 51 insertions(+), 8 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified
  Milan Zamazal: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/53993
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8a257399988ae30955f0270f924a9a3a8e8a50b8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: tests: extend coverage for vmstats.disks()

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: tests: extend coverage for vmstats.disks()
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/53993
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a257399988ae30955f0270f924a9a3a8e8a50b8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: adding virt mkimage api module to supervdsm

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: adding virt mkimage api module to supervdsm
..


Patch Set 2: Verified-1

same reason for patch 54004

-- 
To view, visit https://gerrit.ovirt.org/54005
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib64d63b223cca53e843f7e81d455308241443747
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: adding virt basic api module to supervdsm

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: adding virt basic api module to supervdsm
..


Patch Set 2: Verified-1

Need to understand why this happens:

Thread-72::ERROR::2016-02-25 
16:37:47,522::vm::1806::virt.vm::(_domDependentInit) 
vmId=`b29c12fe-d0ce-4bed-b2f5-184488854d37`::Failed to connect to guest agent 
channel
Traceback (most recent call last):
  File "/usr/share/vdsm/virt/vm.py", line 1804, in _domDependentInit
self.guestAgent.start()
  File "/usr/share/vdsm/virt/guestagent.py", line 169, in start
self._prepare_socket()
  File "/usr/share/vdsm/virt/guestagent.py", line 211, in _prepare_socket
supervdsm.getProxy().prepareVmChannel(self._socketName)
  File "/usr/lib/python2.7/site-packages/vdsm/supervdsm.py", line 53, in 
__call__
return callMethod()
  File "/usr/lib/python2.7/site-packages/vdsm/supervdsm.py", line 50, in 

getattr(self._supervdsmProxy._svdsm, self._funcName)(*args,
AttributeError: 'AutoProxy[instance]' object has no attribute 'prepareVmChannel'
Thread-72::ERROR::2016-02-25 
16:37:47,526::vm::752::virt.vm::(_startUnderlyingVm) 
vmId=`b29c12fe-d0ce-4bed-b2f5-184488854d37`::The vm start process failed
Traceback (most recent call last):
  File "/usr/share/vdsm/virt/vm.py", line 696, in _startUnderlyingVm
self._run()
  File "/usr/share/vdsm/virt/vm.py", line 1942, in _run
self._domDependentInit()
  File "/usr/share/vdsm/virt/vm.py", line 1809, in _domDependentInit
con.prepare()
  File "/usr/share/vdsm/virt/vmdevices/core.py", line 112, in prepare
constants.OVIRT_VMCONSOLE_GROUP)
  File "/usr/lib/python2.7/site-packages/vdsm/supervdsm.py", line 53, in 
__call__
return callMethod()
  File "/usr/lib/python2.7/site-packages/vdsm/supervdsm.py", line 50, in 

getattr(self._supervdsmProxy._svdsm, self._funcName)(*args,
AttributeError: 'AutoProxy[instance]' object has no attribute 'prepareVmChannel'
Thread-72::INFO::2016-02-25 16:37:47,594::vm::1290::virt.vm::(setDownStatus) 
vmId=`b29c12fe-d0ce-4bed-b2f5-184488854d37`::Changed state to Down: 
'AutoProxy[instance]' object has no attribute 'prepareVmChannel' (code=1)

-- 
To view, visit https://gerrit.ovirt.org/54004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9acf5a2f8fd14ac172bb6ea70bbc2aff8caf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: Add retry on full capacity

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: Add retry on full capacity
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988fa2e501eb77d121668b22cc533b744a3dc755
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: response: Add support for specific error checking in is_error

[automation]

gerrit-hooks has posted comments on this change.

Change subject: response: Add support for specific error checking in is_error
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54036
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00d8d2914983f75293ece5ce05894ca3821b7b24
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: Enable lazy setting of incoming/outgoing limits

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: Enable lazy setting of incoming/outgoing limits
..


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53305
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79ab97f15788e4024c94d051e4aade713d760acf
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: Move saveState() out of constructor

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: Move saveState() out of constructor
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53950
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb38fdc06bf1a7b881cd64d2af45a93b16c935ea
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: Add DynamicThrottling semaphores

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: Add DynamicThrottling semaphores
..


Patch Set 13:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53304
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67376d0bd990f89e0a013887cef1a0cb05fb855d
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingDeviceAddress() to vmxml.py

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingDeviceAddress() to vmxml.py
..


Patch Set 5:

> not sure if this is more xml processing or more device handling.

It should probably be reworked and integrated into vmxml.Device class in 
future, but let's keep it simple for now.

-- 
To view, visit https://gerrit.ovirt.org/53615
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9868ca1df6650b1262e6f30d639a08b1f38304d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-restore-net-config: wait for links with netlink monitor

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm-restore-net-config: wait for links with netlink monitor
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/53968/3/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:

Line 319: available_bonds[bond]['nics'] = available_bond_nics
Line 320: return available_bonds
Line 321: 
Line 322: 
Line 323: def _wait_for_all_devices_up(links):
> I think you need to continue checking 'mon' in a loop until either all link
I vote for simplicity. This code runs only once during boot. No need to 
optimize it with test-acquire-test.
Line 324: try:
Line 325: with monitor.Monitor(groups=('link',), timeout=5) as mon:
Line 326: down_links = _get_links_with_state_down(links)
Line 327: logging.debug("waiting for %s to be up.", down_links)


-- 
To view, visit https://gerrit.ovirt.org/53968
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c45430925a55bb54995b91a061bc15affe15763
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: added support for convergence schedule

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: added support for convergence schedule
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/46940
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I989cff12d08ef1cab36bd10df7daaa999a8dac14
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-restore-net-config: wait for links with netlink monitor

[edwardh]

Edward Haas has posted comments on this change.

Change subject: vdsm-restore-net-config: wait for links with netlink monitor
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/53968/3/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:

Line 319: available_bonds[bond]['nics'] = available_bond_nics
Line 320: return available_bonds
Line 321: 
Line 322: 
Line 323: def _wait_for_all_devices_up(links):
> I think you need to continue checking 'mon' in a loop until either all link
I just realized that iterating over mon is a blocking operation, no need for a 
loop. Sorry.
Line 324: try:
Line 325: with monitor.Monitor(groups=('link',), timeout=5) as mon:
Line 326: down_links = _get_links_with_state_down(links)
Line 327: logging.debug("waiting for %s to be up.", down_links)


-- 
To view, visit https://gerrit.ovirt.org/53968
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c45430925a55bb54995b91a061bc15affe15763
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-restore-net-config: wait for links with netlink monitor

[edwardh]

Edward Haas has posted comments on this change.

Change subject: vdsm-restore-net-config: wait for links with netlink monitor
..


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/53968/3/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:

Line 319: available_bonds[bond]['nics'] = available_bond_nics
Line 320: return available_bonds
Line 321: 
Line 322: 
Line 323: def _wait_for_all_devices_up(links):
I think you need to continue checking 'mon' in a loop until either all links 
come up or a timeout event occurs.
Not sure why you directly stop mon, it is stooped when exiting the context 
manager.

And IMO, I think that you should check for links down twice, once before the 
monitoring (why create an mon object if not needed), and a second time after 
the monitor has been activated as you have done.
Line 324: try:
Line 325: with monitor.Monitor(groups=('link',), timeout=5) as mon:
Line 326: down_links = _get_links_with_state_down(links)
Line 327: logging.debug("waiting for %s to be up.", down_links)


-- 
To view, visit https://gerrit.ovirt.org/53968
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c45430925a55bb54995b91a061bc15affe15763
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: Enable lazy setting of incoming/outgoing limits

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: Enable lazy setting of incoming/outgoing limits
..


Patch Set 13:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53305
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79ab97f15788e4024c94d051e4aade713d760acf
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: Add DynamicThrottling semaphores

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: Add DynamicThrottling semaphores
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53304
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67376d0bd990f89e0a013887cef1a0cb05fb855d
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: Add retry on full capacity

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: Add retry on full capacity
..


Patch Set 17:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988fa2e501eb77d121668b22cc533b744a3dc755
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: api: fix invalid refactoring

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: api: fix invalid refactoring
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f5ecd7682b05da4970930656b4f18c0f67b4180
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: api: fix invalid refactoring

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: api: fix invalid refactoring
..


net: api: fix invalid refactoring

else branch used to iterate 'nics' and if there was none, it just did
nothing.

During the refactoring [1] we get rid of 'nics' and replaced it with
'nic'. In case when 'bonding' is None, we go to else branch and
without any checking call _validateInterNetworkCompatibility()
which fails for None nic.

[1] https://gerrit.ovirt.org/#/c/53475/15/lib/vdsm/network/api.py

Change-Id: I7f5ecd7682b05da4970930656b4f18c0f67b4180
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/54016
Continuous-Integration: Jenkins CI
Reviewed-by: Edward Haas 
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/network/api.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/54016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7f5ecd7682b05da4970930656b4f18c0f67b4180
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: api: fix invalid refactoring

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: api: fix invalid refactoring
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/54016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f5ecd7682b05da4970930656b4f18c0f67b4180
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: response: Add support for specific error checking in is_error

[fromani]

Francesco Romani has posted comments on this change.

Change subject: response: Add support for specific error checking in is_error
..


Patch Set 1: Code-Review+1

(1 comment)

nice! let's just improve a bit the tests and it is fine. Partial ACK

https://gerrit.ovirt.org/#/c/54036/1/tests/responseTests.py
File tests/responseTests.py:

Line 74: self.assertEqual(res[key], args[key])
Line 75: 
Line 76: def test_is_error(self):
Line 77: NAME = 'noVM'  # no special meaning, any error is fine
Line 78: NAME2 = 'hookError'
let's add a specific testcase for this new code path

@permutations([
  # err_name
  ['noVM'],
  ['hookError'],
])
def test_is_specific_error(self, err_name):
   self.assertTrue(response.is_error(response.error(err_name), err_name)
Line 79: self.assertTrue(response.is_error(response.error(NAME)))
Line 80: 
Line 81: self.assertTrue(response.is_error(response.error(NAME), 
err=NAME))
Line 82: self.assertFalse(response.is_error(response.error(NAME), 
err=NAME2))


-- 
To view, visit https://gerrit.ovirt.org/54036
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00d8d2914983f75293ece5ce05894ca3821b7b24
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: Add DynamicThrottling semaphores

[mbetak]

Martin Betak has posted comments on this change.

Change subject: migration: Add DynamicThrottling semaphores
..


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/53304/11/vdsm/virt/utils.py
File vdsm/virt/utils.py:

Line 157: 
Line 158: def __exit__(self, exc_type, exc_val, exc_tb):
Line 159: self.release()
Line 160: 
Line 161: def set_bound(self, value):
I'm considering if it wouldn't be nicer if the bound was a property with this 
being it's setter and also a simple getter so outside world could easily read 
what the current bound setting is and also set it (perhaps more clearly?) as

  semaphore.bound = 5

rather than

  semaphore.set_bound(5)
Line 162: """ Dynamically updates semaphore bound.
Line 163: 
Line 164: When the the specified value is larger than the previous 
bound,
Line 165: it releases the semaphore the required number of times (and 
possibly


-- 
To view, visit https://gerrit.ovirt.org/53304
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67376d0bd990f89e0a013887cef1a0cb05fb855d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: Enable lazy setting of incoming/outgoing limits

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: Enable lazy setting of incoming/outgoing limits
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53305
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79ab97f15788e4024c94d051e4aade713d760acf
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: response: Add support for specific error checking in is_error

[automation]

gerrit-hooks has posted comments on this change.

Change subject: response: Add support for specific error checking in is_error
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54036
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00d8d2914983f75293ece5ce05894ca3821b7b24
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: Add retry on full capacity

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: Add retry on full capacity
..


Patch Set 16:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988fa2e501eb77d121668b22cc533b744a3dc755
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: Move saveState() out of constructor

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: Move saveState() out of constructor
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53950
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb38fdc06bf1a7b881cd64d2af45a93b16c935ea
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: Add DynamicThrottling semaphores

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: Add DynamicThrottling semaphores
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53304
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67376d0bd990f89e0a013887cef1a0cb05fb855d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: response: Add support for specific error checking in is_error

[mbetak]

Martin Betak has uploaded a new change for review.

Change subject: response: Add support for specific error checking in is_error
..

response: Add support for specific error checking in is_error

response.is_error can now take an optional 'err' argument to check
if given response is of that particular error type.

E.g. to check if given response if an instance of 'migrateLimit' error:

  response.is_error(result, 'migrateLimit')

This will return false for successful response as well for all error codes
other than that of 'migrateLimit'.

Change-Id: I00d8d2914983f75293ece5ce05894ca3821b7b24
Signed-off-by: Martin Betak 
---
M lib/vdsm/response.py
M tests/responseTests.py
2 files changed, 9 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/54036/1

diff --git a/lib/vdsm/response.py b/lib/vdsm/response.py
index 160898f..559c753 100644
--- a/lib/vdsm/response.py
+++ b/lib/vdsm/response.py
@@ -75,10 +75,13 @@
 }
 
 
-def is_error(res):
+def is_error(res, err=None):
 try:
 code = res["status"]["code"]
 except KeyError:
 raise MalformedResponse(res)
 else:
-return code != doneCode["code"]
+if err:
+return code == errCode[err]["status"]["code"]
+else:
+return code != doneCode["code"]
diff --git a/tests/responseTests.py b/tests/responseTests.py
index 569fce3..427bf48 100644
--- a/tests/responseTests.py
+++ b/tests/responseTests.py
@@ -75,8 +75,12 @@
 
 def test_is_error(self):
 NAME = 'noVM'  # no special meaning, any error is fine
+NAME2 = 'hookError'
 self.assertTrue(response.is_error(response.error(NAME)))
 
+self.assertTrue(response.is_error(response.error(NAME), err=NAME))
+self.assertFalse(response.is_error(response.error(NAME), err=NAME2))
+
 def test_malformed_empty(self):
 self.assertRaises(response.MalformedResponse,
   response.is_error,


-- 
To view, visit https://gerrit.ovirt.org/54036
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I00d8d2914983f75293ece5ce05894ca3821b7b24
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: api: fix invalid refactoring

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: api: fix invalid refactoring
..


Patch Set 3: Verified+1

Passed network tests OK, nic cannot be None error is not logged anymore.

-- 
To view, visit https://gerrit.ovirt.org/54016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f5ecd7682b05da4970930656b4f18c0f67b4180
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: _getUnderlyingNetworkInterfaceInfo() moved out of Vm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: _getUnderlyingNetworkInterfaceInfo() moved out of Vm
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53621
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d627a50c1ed52c584a834fb2f9066ac1ab6ac68
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move controller legacy conf out of Vm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Move controller legacy conf out of Vm
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53749
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9135e6524fe2566d1cf2c3cc4664fefe18995635
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move video legacy conf out of Vm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Move video legacy conf out of Vm
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53486
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2794d85a2508500ad1b9004bd502652f0cc71e39
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move legacy sound conf from Vm to vmdevices

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Move legacy sound conf from Vm to vmdevices
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53485
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5076938905fd39ecf5eed81500744c9a1547698
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move graphics legacy conf processing out of Vm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Move graphics legacy conf processing out of Vm
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53487
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6dbaa9aceae1c4b6da4bd81598873fac261cfc0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move network legacy conf processing out of Vm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Move network legacy conf processing out of Vm
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I189d0f7d86fb1e8d54adc96450fd0f92be4dd5c1
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Storage device legacy conf processing moved out of Vm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Storage device legacy conf processing moved out of Vm
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53489
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I36ccbeabf86ccb2db5f2135244e2699f43d7a495
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: _getUnderlyingDriveInfo() moved out of Vm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: _getUnderlyingDriveInfo() moved out of Vm
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53677
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6b372f86b82da7422727f3d084b9afc5505a289
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move _getUnderlyingUnknownDeviceInfo() out of Vm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Move _getUnderlyingUnknownDeviceInfo() out of Vm
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53678
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50d160317f91db92bb6a8ae22a45d9574d1434b3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Vm._getUnderlyingSoundDeviceInfo() moved to core.py

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Vm._getUnderlyingSoundDeviceInfo() moved to core.py
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53616
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05cb24e0a9776e21bd2546d62a56554d74559c61
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move most of _getUnderlyingVmDevicesInfo() out of Vm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Move most of _getUnderlyingVmDevicesInfo() out of Vm
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53679
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81a0da783bc40f0f08dfdac2bbb955bc55d81b0e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move _getUnderlyingHostDeviceInfo() out of Vm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Move _getUnderlyingHostDeviceInfo() out of Vm
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53620
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I789d7d2349fc24b48e52260de98fb3d66b168bf7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: _getUnderlyingGraphicsDeviceInfo() moved out of Vm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: _getUnderlyingGraphicsDeviceInfo() moved out of Vm
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53619
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1aff4f57905d0f2d1ee60a2ed963c843feee4540
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: _getUnderlyingMemoryDeviceInfo() moved out of Vm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: _getUnderlyingMemoryDeviceInfo() moved out of Vm
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53618
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8cdb648a25b26001d8251abb2c53d3317b60a302
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Most Vm._getUnderlying*() method of core devices moved...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Most Vm._getUnderlying*() method of core devices moved 
out of Vm
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53617
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56b742e181eb56db6ccf19a3ab162349be96853e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Add `vm' argument to underlying_device_info methods

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Add `vm' argument to underlying_device_info methods
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53676
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide9e8d105d6c14101f9ce367409af729a075b2df
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Don't use Vm device configuration in clientIF

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Don't use Vm device configuration in clientIF
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd0f7c99b4df18d27dfad36bf2275540bc8b958c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make Vm.devSpecMapFromConf() private

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Make Vm.devSpecMapFromConf() private
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6dffb82bde715453ff4ae3eae3b82b4890f04f8b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make Vm.devMapFromDevSpecMap() private

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Make Vm.devMapFromDevSpecMap() private
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53484
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a1d8d8d80313a8b4648a255413c26689d1c4657
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingDeviceAddress() to vmxml.py

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingDeviceAddress() to vmxml.py
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53615
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9868ca1df6650b1262e6f30d639a08b1f38304d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Add a dependency to vdsm on vdsm-cli

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: spec: Add a dependency to vdsm on vdsm-cli
..


Patch Set 1:

I agree. unless we want to support some sort of minimal installation.. but im 
not aware of any except old ovirt-node

-- 
To view, visit https://gerrit.ovirt.org/54006
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cf60a74128802d577485b674764d2ad45fcf1ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: tests: cleanup net after test_rollback

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: tests: cleanup net after test_rollback
..


Patch Set 1: Code-Review-1

Please describe why it is needed in the message.

In addition, note that this is not really cleaning up after the test, it is 
just cleaning up if an exception occurred.
Current requirement is for each func test to cleanup explicitly.

-- 
To view, visit https://gerrit.ovirt.org/54010
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b0fd6f549644c9d739303d255629998415263a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: api: fix invalid refactoring

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: api: fix invalid refactoring
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/54016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f5ecd7682b05da4970930656b4f18c0f67b4180
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt-sparsify: add in-place sparsify support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt-sparsify: add in-place sparsify support
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icef4021567df5da1cd5b74a94c2d76fefcde3aba
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: virt: modernize vm* tests

[fromani]

Francesco Romani has posted comments on this change.

Change subject: tests: virt: modernize vm* tests
..


Patch Set 2: Verified+1

the statement about verification still holds

-- 
To view, visit https://gerrit.ovirt.org/54022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9324ef9d17df148ea38a03771b896132ec02e22
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: Add retry on full capacity

[fromani]

Francesco Romani has posted comments on this change.

Change subject: migration: Add retry on full capacity
..


Patch Set 14:

(1 comment)

https://gerrit.ovirt.org/#/c/52799/14/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 601: self._vm.log.debug('stopping migration monitor thread')
Line 602: self._stop.set()
Line 603: 
Line 604: 
Line 605: def is_retry_error(result):
> would something like https://gerrit.ovirt.org/#/c/46971/15/lib/vdsm/respons
Yep, could be fine. Deserves a (trivial) separate patch as well.
Line 606: return result['status']['code'] == \


-- 
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988fa2e501eb77d121668b22cc533b744a3dc755
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: virt: modernize vm* tests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: virt: modernize vm* tests
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9324ef9d17df148ea38a03771b896132ec02e22
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: virt: modernize vm* tests

[fromani]

Francesco Romani has posted comments on this change.

Change subject: tests: virt: modernize vm* tests
..


Patch Set 1: Code-Review-1

let's move the from __future__ import *below* the copyright boilerplate. The 
code will behave the same, but it is nicer to read.

-- 
To view, visit https://gerrit.ovirt.org/54022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9324ef9d17df148ea38a03771b896132ec02e22
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: virt: modernize vm* tests

[fromani]

Francesco Romani has posted comments on this change.

Change subject: tests: virt: modernize vm* tests
..


Patch Set 1: Verified+1

changes made by an automated tool over test code. Jenkins verification is 
sufficient.

-- 
To view, visit https://gerrit.ovirt.org/54022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9324ef9d17df148ea38a03771b896132ec02e22
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches