Change in vdsm[master]: imagetickets: add tests
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 10:
(2 comments)
https://gerrit.ovirt.org/#/c/52900/10/tests/imagetickets_test.py
File tests/imagetickets_test.py:
Line 121:
Line 122: @MonkeyPatch(imagetickets, 'uhttp', FakeUHTTP())
Line 123: def test_res_header_error(self):
Line 124: imagetickets.uhttp.response = \
Line 125: FakeResponse(status=300, headers={"content-length":
"invalid"})
> Please avoid \ - use this format:
np, can you please elaborate why?
Line 126: with self.assertRaises(se.ImageDaemonError):
Line 127: imagetickets.remove_ticket("uuid")
Line 128:
Line 129: @MonkeyPatch(imagetickets, 'uhttp', FakeUHTTP())
Line 136: @MonkeyPatch(imagetickets, 'uhttp', FakeUHTTP())
Line 137: def test_image_daemon_error_ret(self):
Line 138: imagetickets.uhttp.response = \
Line 139: FakeResponse(status=300,
Line 140: data=u'{"image_daemon_message":'
u'"content"}')
> This should be one string - it works because Python joins multiple strings,
Done
Line 141: try:
Line 142: imagetickets.remove_ticket("uuid")
Line 143: except se.ImageDaemonError as e:
Line 144: self.assertTrue("image_daemon_message=content" in e.value)
--
To view, visit https://gerrit.ovirt.org/52900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2728851a91529ec35501f423d9a798af961fb82a
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram
Gerrit-Reviewer: Amit Aviram
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bridge: obtain method
Piotr Kliczewski has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/53472/7/tests/stompTests.py File tests/stompTests.py: Line 55: def unregister_server_address(self): Line 56: self.server_address = None Line 57: Line 58: def dispatch(self, method): Line 59: return getattr(self, method) > This will raise AttributeError, while the real code raise json rpc error ab Good point, will align this code to work as real code. Line 60: Line 61: Line 62: @expandPermutations Line 63: class StompTests(TestCaseBase): -- To view, visit https://gerrit.ovirt.org/53472 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b6cb53d8e42335510e34dfe372c1c21b80ac219 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: added support for convergence schedule
Tomas Jelinek has posted comments on this change. Change subject: migration: added support for convergence schedule .. Patch Set 18: Verified+1 -- To view, visit https://gerrit.ovirt.org/46940 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I989cff12d08ef1cab36bd10df7daaa999a8dac14 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: move logUtils to lib
Dan Kenigsberg has submitted this change and it was merged. Change subject: move logUtils to lib .. move logUtils to lib Change-Id: I39b833ff5746db7a764ab9d9120e73a083d14365 Signed-off-by: Yaniv Bronhaim Reviewed-on: https://gerrit.ovirt.org/53889 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg Reviewed-by: Edward Haas Reviewed-by: Francesco Romani Reviewed-by: Nir Soffer --- M debian/vdsm-python.install M debian/vdsm.install M lib/vdsm/Makefile.am R lib/vdsm/logUtils.py M vdsm.spec.in M vdsm/Makefile.am M vdsm/logger.conf.in M vdsm/storage/hsm.py M vdsm/storage/misc.py M vdsm/storage/resourceManager.py M vdsm/storage/task.py M vdsm/svdsm.logger.conf.in M vdsm/virt/vm.py 13 files changed, 11 insertions(+), 10 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Yaniv Bronhaim: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, but someone else must approve Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/53889 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39b833ff5746db7a764ab9d9120e73a083d14365 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: move logUtils to lib
gerrit-hooks has posted comments on this change. Change subject: move logUtils to lib .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/53889 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39b833ff5746db7a764ab9d9120e73a083d14365 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: lib: executor: log pool status on discard
Nir Soffer has posted comments on this change. Change subject: lib: executor: log pool status on discard .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48417 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I949181968a97a7bcec703bc36ef9e1a0f30c6858 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: imagetickets: add tests
Nir Soffer has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 10:
(2 comments)
https://gerrit.ovirt.org/#/c/52900/10/tests/imagetickets_test.py
File tests/imagetickets_test.py:
Line 121:
Line 122: @MonkeyPatch(imagetickets, 'uhttp', FakeUHTTP())
Line 123: def test_res_header_error(self):
Line 124: imagetickets.uhttp.response = \
Line 125: FakeResponse(status=300, headers={"content-length":
"invalid"})
Please avoid \ - use this format:
imagetickets.uhttp.response = FakeResponse(
status=300, headers={"content-length": "invalid"})
Same for other tests using this pattern.
Line 126: with self.assertRaises(se.ImageDaemonError):
Line 127: imagetickets.remove_ticket("uuid")
Line 128:
Line 129: @MonkeyPatch(imagetickets, 'uhttp', FakeUHTTP())
Line 136: @MonkeyPatch(imagetickets, 'uhttp', FakeUHTTP())
Line 137: def test_image_daemon_error_ret(self):
Line 138: imagetickets.uhttp.response = \
Line 139: FakeResponse(status=300,
Line 140: data=u'{"image_daemon_message":'
u'"content"}')
This should be one string - it works because Python joins multiple strings,
like C, but it is confusing.
u'{"image_daemon_message":"content"}'
Line 141: try:
Line 142: imagetickets.remove_ticket("uuid")
Line 143: except se.ImageDaemonError as e:
Line 144: self.assertTrue("image_daemon_message=content" in e.value)
--
To view, visit https://gerrit.ovirt.org/52900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2728851a91529ec35501f423d9a798af961fb82a
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram
Gerrit-Reviewer: Amit Aviram
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: move logUtils to lib
Nir Soffer has posted comments on this change. Change subject: move logUtils to lib .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53889 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39b833ff5746db7a764ab9d9120e73a083d14365 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bridge: obtain method
Nir Soffer has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/53472/7/tests/stompTests.py File tests/stompTests.py: Line 55: def unregister_server_address(self): Line 56: self.server_address = None Line 57: Line 58: def dispatch(self, method): Line 59: return getattr(self, method) This will raise AttributeError, while the real code raise json rpc error about method not found. Line 60: Line 61: Line 62: @expandPermutations Line 63: class StompTests(TestCaseBase): -- To view, visit https://gerrit.ovirt.org/53472 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b6cb53d8e42335510e34dfe372c1c21b80ac219 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils: Add atomic_symlink utility
Nir Soffer has uploaded a new change for review.
Change subject: fileUtils: Add atomic_symlink utility
..
fileUtils: Add atomic_symlink utility
This helper function creates or updates a symlink atomically. If the
symlink exists but links to different target, it is replaced atomically
with a link to the correct target.
We use this logic now for linking storage domain, and we want to use the
same logic for creating or updating the image rundir links
(/run/vdsm/storage/sd_uuid/img_uuid)
If the process is killed while creating a link, it may leave temporary
link (link.tmp). This file will be removed in the next time a link is
created.
Change-Id: I931eca7a25c7b10344fce78b274d633d73eb082d
Signed-off-by: Nir Soffer
---
M tests/fileUtilTests.py
M vdsm/storage/fileUtils.py
2 files changed, 89 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/53680/1
diff --git a/tests/fileUtilTests.py b/tests/fileUtilTests.py
index add36c2..8c6081a 100644
--- a/tests/fileUtilTests.py
+++ b/tests/fileUtilTests.py
@@ -226,3 +226,59 @@
fileUtils.copyUserModeToGroup(path)
self.assertEquals(os.stat(path).st_mode & self.MODE_MASK,
expectedMode)
+
+
+class TestAtomicSymlink(TestCaseBase):
+
+def test_create_new(self):
+with namedTemporaryDir() as tmpdir:
+target = os.path.join(tmpdir, "target")
+link = os.path.join(tmpdir, "link")
+fileUtils.atomic_symlink(target, link)
+self.assertEqual(os.readlink(link), target)
+self.assertFalse(os.path.exists(link + ".tmp"))
+
+def test_keep_current(self):
+with namedTemporaryDir() as tmpdir:
+target = os.path.join(tmpdir, "target")
+link = os.path.join(tmpdir, "link")
+fileUtils.atomic_symlink(target, link)
+current = os.lstat(link)
+fileUtils.atomic_symlink(target, link)
+new = os.lstat(link)
+self.assertEqual(current, new)
+self.assertFalse(os.path.exists(link + ".tmp"))
+
+def test_replace_stale(self):
+with namedTemporaryDir() as tmpdir:
+target = os.path.join(tmpdir, "target")
+link = os.path.join(tmpdir, "link")
+fileUtils.atomic_symlink("stale", link)
+fileUtils.atomic_symlink(target, link)
+self.assertEqual(os.readlink(link), target)
+self.assertFalse(os.path.exists(link + ".tmp"))
+
+def test_replace_stale_temporary_link(self):
+with namedTemporaryDir() as tmpdir:
+target = os.path.join(tmpdir, "target")
+link = os.path.join(tmpdir, "link")
+tmp_link = link + ".tmp"
+fileUtils.atomic_symlink("stale", tmp_link)
+fileUtils.atomic_symlink(target, link)
+self.assertEqual(os.readlink(link), target)
+self.assertFalse(os.path.exists(tmp_link))
+
+def test_error_isfile(self):
+with namedTemporaryDir() as tmpdir:
+target = os.path.join(tmpdir, "target")
+link = os.path.join(tmpdir, "link")
+with open(link, 'w') as f:
+f.write('data')
+self.assertRaises(OSError, fileUtils.atomic_symlink, target, link)
+
+def test_error_isdir(self):
+with namedTemporaryDir() as tmpdir:
+target = os.path.join(tmpdir, "target")
+link = os.path.join(tmpdir, "link")
+os.mkdir(link)
+self.assertRaises(OSError, fileUtils.atomic_symlink, target, link)
diff --git a/vdsm/storage/fileUtils.py b/vdsm/storage/fileUtils.py
index 69aac2f..a3584ed 100644
--- a/vdsm/storage/fileUtils.py
+++ b/vdsm/storage/fileUtils.py
@@ -202,6 +202,39 @@
return open(path, mode)
+def atomic_symlink(target, name):
+log.info("Linking %r to %r", target, name)
+try:
+current_target = os.readlink(name)
+except OSError as e:
+if e.errno != errno.ENOENT:
+raise
+else:
+if current_target == target:
+log.debug("link %r exists", name)
+return
+log.debug("Replacing stale link to %r", current_target)
+
+tmp_name = name + ".tmp"
+try:
+os.symlink(target, tmp_name)
+except OSError as e:
+if e.errno != errno.EEXIST:
+raise
+log.debug("Removing stale temporary link %r", tmp_name)
+os.unlink(tmp_name)
+os.symlink(target, tmp_name)
+
+try:
+os.rename(tmp_name, name)
+except:
+try:
+os.unlink(tmp_name)
+except OSError as e:
+log.error("Cannot remove temporary link %r: %s", tmp_name, e)
+raise
+
+
class DirectFile(object):
def __init__(self, path, mode):
if "d" not in mode:
--
To view, visit https://gerrit.ovirt.org/53680
To unsubscribe, visit https://gerrit.ovi
Change in vdsm[master]: fileUtils: Add atomic_symlink utility
Nir Soffer has posted comments on this change. Change subject: fileUtils: Add atomic_symlink utility .. Patch Set 1: Verified+1 Verified by the new tests. -- To view, visit https://gerrit.ovirt.org/53680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I931eca7a25c7b10344fce78b274d633d73eb082d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils: Add atomic_symlink utility
Adam Litke has posted comments on this change. Change subject: fileUtils: Add atomic_symlink utility .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I931eca7a25c7b10344fce78b274d633d73eb082d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: virt: stats: make _disk_iops_bytes more robust
Nir Soffer has posted comments on this change. Change subject: virt: stats: make _disk_iops_bytes more robust .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/53997 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I341779e2629a1122e4c0fa55206ad404f3eb2f48 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: virt: stats: make compute_latency more robust
Nir Soffer has posted comments on this change. Change subject: virt: stats: make compute_latency more robust .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/53996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4670309d48bd65a3afaba8124407598b76d808d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: virt: stats: make disk_rate more robust
Nir Soffer has posted comments on this change. Change subject: virt: stats: make disk_rate more robust .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/53995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2900e73161932f7fbecd9d7bfaba36dc1e84e19 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: provide more info when method not found
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: provide more info when method not found
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/53714/4/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 63: class JsonRpcMethodNotFoundError(JsonRpcError):
Line 64: def __init__(self, method_name):
Line 65: JsonRpcError.__init__(
Line 66: self, -32601,
Line 67: "The method %s does not exist or is not available." %
method_name)
> Better use %r - if the error is leading or trailing whitespace, or non-prin
Done
Line 68:
Line 69:
Line 70: class JsonRpcInvalidParamsError(JsonRpcError):
Line 71: def __init__(self):
https://gerrit.ovirt.org/#/c/53714/4/tests/integration/jsonRpcTests.py
File tests/integration/jsonRpcTests.py:
Line 138: with constructClient(self.log, bridge, ssl, type) as
clientFactory:
Line 139: with self._client(clientFactory) as client:
Line 140: if type == "xml":
Line 141: response = client.send(missing_method, ())
Line 142: self.assertTrue("\"I_DO_NOT_EXIST :(\" is not
supported"
> Why not:
Will check
Line 143: in response)
Line 144: else:
Line 145: with self.assertRaises(JsonRpcError) as cm:
Line 146: self._callTimeout(client, missing_method, [],
--
To view, visit https://gerrit.ovirt.org/53714
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib29240f002ab7c11744d164cf4e0ea5f47924929
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Add a dependency to vdsm on vdsm-cli
Piotr Kliczewski has posted comments on this change. Change subject: spec: Add a dependency to vdsm on vdsm-cli .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/54006/1/vdsm.spec.in File vdsm.spec.in: Line 255: Requires(post): /bin/hostname Line 256: %endif Line 257: Line 258: # Required by the sos plugin Line 259: Requires: vdsm-cli > we still call it vdsm for now, but better to use It is widely used practice in this file so we need to be consistent. Line 260: Line 261: Conflicts: vdsm-hook-sriov Line 262: Line 263: %description -- To view, visit https://gerrit.ovirt.org/54006 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cf60a74128802d577485b674764d2ad45fcf1ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json: use forzenset for filtered methods
Piotr Kliczewski has posted comments on this change.
Change subject: json: use forzenset for filtered methods
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/54160/1/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 468:
Line 469: class JsonRpcServer(object):
Line 470: log = logging.getLogger("jsonrpc.JsonRpcServer")
Line 471:
Line 472: filtered_methods = frozenset(['Host_getVMList',
'Host_getAllVmStats',
> This is a constant, so I think using uppercase would be good idea here.
Done
Line 473: 'Host_getStats',
'StorageDomain_getStats',
Line 474: 'VM_getStats', 'Host_fenceNode'])
Line 475:
Line 476: """
--
To view, visit https://gerrit.ovirt.org/54160
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17becc319fb8e226f0badc883007900c8862a520
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json: use forzenset for filtered methods
Nir Soffer has posted comments on this change.
Change subject: json: use forzenset for filtered methods
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/54160/1/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 468:
Line 469: class JsonRpcServer(object):
Line 470: log = logging.getLogger("jsonrpc.JsonRpcServer")
Line 471:
Line 472: filtered_methods = frozenset(['Host_getVMList',
'Host_getAllVmStats',
This is a constant, so I think using uppercase would be good idea here.
Line 473: 'Host_getStats',
'StorageDomain_getStats',
Line 474: 'VM_getStats', 'Host_fenceNode'])
Line 475:
Line 476: """
--
To view, visit https://gerrit.ovirt.org/54160
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17becc319fb8e226f0badc883007900c8862a520
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: move alignmentScan.py to lib
Nir Soffer has posted comments on this change. Change subject: move alignmentScan.py to lib .. Patch Set 6: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/53758/6/tests/alignmentScanTests.py File tests/alignmentScanTests.py: Line 24: from nose.tools import eq_, raises Line 25: from nose.plugins.skip import SkipTest Line 26: from testlib import VdsmTestCase as TestCaseBase Line 27: from testValidation import brokentest, slowtest Line 28: from vdsm.commands import execCmd Please keep using misc.execCmd - this changes the logging and may break our debugging tools depending on vdsm log. Looks like storage.misc must move first to lib - and alignmentScan should move into lib/vdsm/storage - this is not common infrastructure. Line 29: from vdsm.alignmentScan import runScanArgs, scanImage, VirtAlignError Line 30: Line 31: Line 32: def mkimage(imagepath, aligned=True): -- To view, visit https://gerrit.ovirt.org/53758 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0537393da342507c9e64e9d71656cfc69bbe15e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: move blkid to lib
Nir Soffer has posted comments on this change. Change subject: move blkid to lib .. Patch Set 2: Code-Review+1 Looks safe, but we need to verify the flow when preparing a UUID type drive. I don't know how to trigger this flow, adding Daniel to check this. -- To view, visit https://gerrit.ovirt.org/53872 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92390e82e1bc6b2170c81711ba0e639e3b0a3017 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Don't fail connect server when getting volume info
Nir Soffer has posted comments on this change.
Change subject: gluster: Don't fail connect server when getting volume info
..
Patch Set 5:
(3 comments)
https://gerrit.ovirt.org/#/c/53785/5/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:
Line 346: "automatically mount gluster storage
backup "
Line 347: "servers")
Line 348: return
Line 349:
Line 350: if self.volinfo is not None:
This will invoke get_gluster_volinfo once...
Line 351: replicaCount = self.volinfo['replicaCount']
Line 352: if replicaCount not in self.ALLOWED_REPLICA_COUNTS:
Line 353: self.log.warning("Unsupported replica count (%s) for
volume "
Line 354: " %r, please upgrade volume to
replica 3",
Line 354: " %r, please upgrade volume to
replica 3",
Line 355: replicaCount, self._volname)
Line 356:
Line 357: def _get_backup_servers_option(self):
Line 358: if self.volinfo is None:
This will invoke _get_gluster_volinfo() again..
Line 359: return
Line 360:
Line 361: servers = utils.unique(brick.split(":")[0] for brick
Line 362:in self.volinfo['bricks'])
Line 380:
self._volfileserver)
Line 381: return volinfo[self._volname]
Line 382: except ge.GlusterCmdExecFailedException as e:
Line 383: self.log.warning("Failed to get volume info. %s",
Line 384: e)
This should never return None - the logic of the lazy initialization is based
on this fact that this either return the info or raises, so we invoke it once.
We can solve this by returning empty volume info dict, e.g. one with empty
bricks list.
Do we have a test simulating this failure? Please start by adding such tests,
then we can fix the code so the test pass.
Line 385:
Line 386:
Line 387: class NFSConnection(object):
Line 388: DEFAULT_OPTIONS = ["soft", "nosharecache"]
--
To view, visit https://gerrit.ovirt.org/53785
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e1835b7de4c5c4c5c4616d3c36f15c1f91a01dc
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: provide more info when method not found
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: provide more info when method not found
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/53714/4/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 63: class JsonRpcMethodNotFoundError(JsonRpcError):
Line 64: def __init__(self, method_name):
Line 65: JsonRpcError.__init__(
Line 66: self, -32601,
Line 67: "The method %s does not exist or is not available." %
method_name)
Better use %r - if the error is leading or trailing whitespace, or
non-printable character in the method name, %r will expose this. This is true
for most logs where you want to show user provided string.
Line 68:
Line 69:
Line 70: class JsonRpcInvalidParamsError(JsonRpcError):
Line 71: def __init__(self):
https://gerrit.ovirt.org/#/c/53714/4/tests/integration/jsonRpcTests.py
File tests/integration/jsonRpcTests.py:
Line 138: with constructClient(self.log, bridge, ssl, type) as
clientFactory:
Line 139: with self._client(clientFactory) as client:
Line 140: if type == "xml":
Line 141: response = client.send(missing_method, ())
Line 142: self.assertTrue("\"I_DO_NOT_EXIST :(\" is not
supported"
Why not:
self.assertNotIn(missing_method, response)
?
Line 143: in response)
Line 144: else:
Line 145: with self.assertRaises(JsonRpcError) as cm:
Line 146: self._callTimeout(client, missing_method, [],
--
To view, visit https://gerrit.ovirt.org/53714
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib29240f002ab7c11744d164cf4e0ea5f47924929
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net: use the correct dict with all the networks for disable_...
Dan Kenigsberg has posted comments on this change. Change subject: net: use the correct dict with all the networks for disable_ipv6 restoration .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/53942/2/vdsm/vdsm-restore-net-config File vdsm/vdsm-restore-net-config: Line 140: available_config > I am afraid I don't follow, again. How would new bridges come to existence new bridges can pop up if (for some reason) initscripts failed to create them on time. _filter_changed_nets_bonds() would include them, and and ask setupNetworks to create them. HOWEVER, I have to correct myself: the setupNetwork flow is expected to turn ipv6 off (due to another few months old patch by Ondra). Still, this patch needs a fix: we do to touch ONLY the available networks, and BEFORE _filter_change_nets_bonds() is caused. We need to drop ipv6 from initscripts-created networks (not only bridges, but also other top-level devices) prior to the comparison. -- To view, visit https://gerrit.ovirt.org/53942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If49f549d91c54cb7b3c31a23436008dc1c622682 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: numa: add docstrings for public methods
Francesco Romani has posted comments on this change. Change subject: numa: add docstrings for public methods .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54171 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id84872556a3f0699a738071ca7d3f9809bea305b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: numa: reorganize module
Francesco Romani has posted comments on this change. Change subject: numa: reorganize module .. Patch Set 3: Code-Review-1 (1 comment) -1 for visibility: looks fine but I'd like more context https://gerrit.ovirt.org/#/c/54167/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2016-02-29 15:38:06 +0100 Line 4: Commit: Martin Polednik Line 5: CommitDate: 2016-02-29 16:45:12 +0100 Line 6: Line 7: numa: reorganize module A bit too terse :) Could you please explain how and why? Line 8: Line 9: Change-Id: I7e8ca3092d4c14827d0965a535ef3d0ac7ba4b0a -- To view, visit https://gerrit.ovirt.org/54167 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e8ca3092d4c14827d0965a535ef3d0ac7ba4b0a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps/numa: move autonuma status to sitelib
Francesco Romani has posted comments on this change. Change subject: caps/numa: move autonuma status to sitelib .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54166 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42e7eae743d319b0afd9653a9d6f1f2701856ca9 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: numa: refactor to single pass caps parse
Francesco Romani has posted comments on this change. Change subject: numa: refactor to single pass caps parse .. Patch Set 8: (1 comment) partial review, I need to do another pass later https://gerrit.ovirt.org/#/c/53288/8/lib/vdsm/numa.py File lib/vdsm/numa.py: Line 70: 'sockets': len(sockets), Line 71: 'cores': len(siblings), Line 72: 'threads': len(online_cpus), Line 73: 'onlineCpus': online_cpus Line 74: } same comment as per parent patch :) Line 75: Line 76: return NumaTopology(topology, distances, cpu_topology) Line 77: Line 78: -- To view, visit https://gerrit.ovirt.org/53288 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie81b5b76523070ec9fd7a6ffe902ffa25da9e3a6 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: numa: move cpu topology (numa) related functionality to sitelib
Francesco Romani has posted comments on this change. Change subject: numa: move cpu topology (numa) related functionality to sitelib .. Patch Set 8: Code-Review+2 (1 comment) looks fine, but pretty please read inside comments :) https://gerrit.ovirt.org/#/c/53287/8/lib/vdsm/numa.py File lib/vdsm/numa.py: Line 102: 'sockets': len(sockets), Line 103: 'cores': len(siblings), Line 104: 'threads': len(online_cpus), Line 105: 'onlineCpus': online_cpus, Line 106: } Can we have a namedtuple? :) I find topology.sockets so much nicer than topology["sockets"] I guess the return value should not be mutable, does it? Line 107: -- To view, visit https://gerrit.ovirt.org/53287 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie786e8a3626dd257c2a244decfe3e6a127d04b28 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: numa: move numa related functionality to sitelib
Francesco Romani has posted comments on this change.
Change subject: numa: move numa related functionality to sitelib
..
Patch Set 7: Code-Review-1
(2 comments)
looks fine, but we should take some (very cheap) preventive action about a
nasty bug we have hidden in libvirtconnection.py
-1 for visibility only, it will be +2 once this is done
https://gerrit.ovirt.org/#/c/53286/7/lib/vdsm/numa.py
File lib/vdsm/numa.py:
Line 27: from . import libvirtconnection
Line 28:
Line 29:
Line 30: def _get_libvirt_caps():
Line 31: return libvirtconnection.get().getCapabilities()
we have a bug lurking in libvirtconnection.py, and I don't really like this
style anyway, so let's use a few more vertical space. Please always use
conn = libvirtconnection.get()
return conn.getCapabilities()
here and in the rest of this module
Line 32:
Line 33:
Line 34: @utils.memoized
Line 35: def topology(capabilities=None):
Line 56: :param cell: the index of numa node
Line 57: :type cell: int
Line 58: :return: dict like {'total': '49141', 'free': '46783'}
Line 59: """
Line 60: meminfo = libvirtconnection.get().getMemoryStats(index, 0)
see comment in line 31
Line 61: meminfo['total'] = str(meminfo['total'] / 1024)
Line 62: meminfo['free'] = str(meminfo['free'] / 1024)
Line 63: return meminfo
Line 64:
--
To view, visit https://gerrit.ovirt.org/53286
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dffad8663ca50a67f117b1c74d4459e667d9f43
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: numa: get distance information from libvirt
Francesco Romani has posted comments on this change. Change subject: numa: get distance information from libvirt .. Patch Set 5: +2 because is virt/sla flow -- To view, visit https://gerrit.ovirt.org/53285 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80b423e27fa37bc49388cca72785b081e4365e69 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: numa: get distance information from libvirt
Francesco Romani has posted comments on this change. Change subject: numa: get distance information from libvirt .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53285 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80b423e27fa37bc49388cca72785b081e4365e69 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Add retry on full capacity
Francesco Romani has posted comments on this change. Change subject: migration: Add retry on full capacity .. Patch Set 18: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/52799 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I988fa2e501eb77d121668b22cc533b744a3dc755 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Add retry on full capacity
Francesco Romani has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 18: Code-Review+1
(3 comments)
Looks good, but a couple of questions inside. Overall, -1 for visibility
https://gerrit.ovirt.org/#/c/52799/18/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 334: 'migCancelErr', message='Migration
canceled')
Line 335: raise
Line 336: except MigrationLimitExceeded:
Line 337: self.log.debug("Migration destination busy.
Initiating "
Line 338:"retry in %d seconds." %
retry_timeout)
works. Better:
self.log.debug("Migration destination busy. Initiating "
"retry in %d seconds.", retry_timeout)
This is because python logging module will do the string formatting if and only
if the message is going to be logged. Otherwise, the string formatting will
always happen, and this is (indeed a [tiny] bit) wasteful.
Line 339: time.sleep(retry_timeout)
Line 340: except MigrationDestinationSetupError as e:
Line 341: self._recover(str(e))
Line 342: # we know what happened, no need to dump hollow stack
trace
Line 370: destCreationTime)
Line 371:
Line 372: if response.is_error(result):
Line 373: self.status = result
Line 374: # Differentiate between general migration failure and
a retry
I don't think this comment is worth keeping. Which value does it add?
Line 375: if is_retry_error(result):
Line 376: raise MigrationLimitExceeded()
Line 377: else:
Line 378: raise MigrationDestinationSetupError(
Line 601: self._vm.log.debug('stopping migration monitor thread')
Line 602: self._stop.set()
Line 603:
Line 604:
Line 605: def is_retry_error(result):
I don't really see the point of this helper. Could you please elaborate why it
is better to have it?
Btw, this is minor, I don't really mind that much.
--
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I988fa2e501eb77d121668b22cc533b744a3dc755
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Tomas Jelinek
Gerrit-Reviewer: Yaniv Kaul
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Move saveState() out of constructor
Francesco Romani has posted comments on this change. Change subject: vm: Move saveState() out of constructor .. Patch Set 3: Code-Review-1 -1 for visibility, please read. This change looks correct, but devil's in the details. Could you please add a detailed explanation about how you verified this patch? I find easy to believe that things works OK in the happy path, but I'm concerned about the error path. In the (albeit very unlikely) case Vdsm crashes while a Vm is running the Vm class constructor, of course after where saveState() was what would it happen? - before this patch: the Vm would have been recovered from file, and would have been recreated by the recovery flow. This means that Vdsm should automatically try to start it again, unless I'm mistaken (I didn't actually run the modified code) - after this patch: this would not happen, so the Vm will just disappear from the system. This will happen because libvirt is not yet into play and, the recovery file is not yet created. Can Engine cope with this case? Can we do better than this? -- To view, visit https://gerrit.ovirt.org/53950 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb38fdc06bf1a7b881cd64d2af45a93b16c935ea Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: response: Add support for specific error checking in is_error
Francesco Romani has posted comments on this change. Change subject: response: Add support for specific error checking in is_error .. Patch Set 2: Code-Review+1 Looks fine, +2'd on hold: please don't forget to add a comment on gerrit documenting how you verified this patch: it is required by Vdsm development process. It is fine to add "verified running the tests" especially in cases like this where the change is very simple and covered by the tests. -- To view, visit https://gerrit.ovirt.org/54036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00d8d2914983f75293ece5ce05894ca3821b7b24 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: response: Add support for specific error checking in is_error
Francesco Romani has posted comments on this change. Change subject: response: Add support for specific error checking in is_error .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00d8d2914983f75293ece5ce05894ca3821b7b24 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Apply storage QoS on running VM
Francesco Romani has posted comments on this change.
Change subject: Apply storage QoS on running VM
..
Patch Set 14: Code-Review-1
(3 comments)
Mostly OK, but please check iniline comments, especially about IDs.
-1 for visiblity.
https://gerrit.ovirt.org/#/c/52746/14//COMMIT_MSG
Commit Message:
Line 6:
Line 7: Apply storage QoS on running VM
Line 8:
Line 9: Modify updateVmPolicy command to accept disk ids and not its path.
Line 10: Add functions to access io tune info from MoM.
Could you please explain why those two changes (modify updateVolume and add
functions in MOM) need to stay in the same patch?
I think it is better to have each one in its own patch, of course in one series.
Line 11:
Line 12: Change-Id: I3f5fcb8705c974f1d91c90cdb3158d2e8dd314f8
Line 13: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1201482
https://gerrit.ovirt.org/#/c/52746/14/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:
Line 2583: # @poolID: #optional PoolId
Line 2584: #
Line 2585: # @imageID: #optional ImageId
Line 2586: #
Line 2587: # @volumeID:#optional VolumeId
this is OK since AFAIK we don't have a way in the schema to express that one
*group* of parameters is optional. But we can maybe add a comment about it (see
also comments in vm.py).
Line 2588: #
Line 2589: # @guaranteed: IO tune parameters - guaranteed values
Line 2590: #
Line 2591: # @maximum: IO tune parameters - the hard limits
https://gerrit.ovirt.org/#/c/52746/14/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2474: disk = self._findDriveByUUIDs({
Line 2475: 'domainID': ioTune.get("domainID"),
Line 2476: 'poolID': ioTune.get("poolID"),
Line 2477: 'imageID': ioTune.get("imageID"),
Line 2478: 'volumeID': ioTune.get("volumeID")})
ok, I think I made my mind: we should fail loudly if we don't have all of those
fours IDs, so please make sure we do.
Unless I missed a valid reason why one or two of them could be missing and we
could get away with that. In this case, please add a comment around line 2473
to remind us why this happens.
Line 2479:
Line 2480: self.log.debug("Device path: %s", disk.path)
Line 2481: ioTune["name"] = disk.name
Line 2482: ioTune["path"] = disk.path
--
To view, visit https://gerrit.ovirt.org/52746
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f5fcb8705c974f1d91c90cdb3158d2e8dd314f8
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir
Gerrit-Reviewer: Andrej Krejcir
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: Roman Mohr
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add `vm' argument to underlying_device_info methods
Francesco Romani has posted comments on this change. Change subject: virt: Add `vm' argument to underlying_device_info methods .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/53676/1//COMMIT_MSG Commit Message: Line 11: instead of adding more other arguments. Perhaps we could remove some of Line 12: the other underlying_device_info arguments when we've got `vm'. Perhaps Line 13: we should take a different approach. It's for discussion, but for now Line 14: we take this path to make storage device handling movable out of Vm Line 15: class. > Since we are going to make `domain' publicly accessible from Vm in another In general I don't think it is a good idea. Unfortunately, we are kinda constrained from the existing code and architecture. So we either redesign this flow from scratch, which is unlikely although everyone agrees that would be the best move, or we go on incrementally. If we go on incrementally, I'm persuaded we don't have other concrete options. Line 16: Line 17: Change-Id: Ide9e8d105d6c14101f9ce367409af729a075b2df -- To view, visit https://gerrit.ovirt.org/53676 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide9e8d105d6c14101f9ce367409af729a075b2df Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: vm: skip domDependentInit for containers
gerrit-hooks has posted comments on this change. Change subject: WIP: vm: skip domDependentInit for containers .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7360d75c4adcab655c2cd215c6b9d91f9d92a646 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: add sudo permissions to run containers
gerrit-hooks has posted comments on this change. Change subject: WIP: add sudo permissions to run containers .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e37ba8f510cf96990645868fca481b08aea4ba6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: containers: always add emulator to XML
gerrit-hooks has posted comments on this change. Change subject: containers: always add emulator to XML .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54176 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie40c6a3e2cdbb72053db71056092d3b7684b994d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: recovery: refactor entry points
gerrit-hooks has posted comments on this change. Change subject: virt: recovery: refactor entry points .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53819 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib60642992c7b7a33079a487d0ef27071b8b5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: containers: detect and report container support
gerrit-hooks has posted comments on this change. Change subject: containers: detect and report container support .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53820 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id236a30a5c875994c037b8d00c7463bceaab143f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: containers: make sure directory are ready
gerrit-hooks has posted comments on this change. Change subject: containers: make sure directory are ready .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54177 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48daf34026ece93032f9b336893b938fbab95f25 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: containers: initial support
gerrit-hooks has posted comments on this change. Change subject: containers: initial support .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09e4b0552613ee160760a5a9bb4b27e0ae1f5d2f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: numa: add docstrings for public methods
gerrit-hooks has posted comments on this change. Change subject: numa: add docstrings for public methods .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54171 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id84872556a3f0699a738071ca7d3f9809bea305b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps/numa: move autonuma status to sitelib
gerrit-hooks has posted comments on this change. Change subject: caps/numa: move autonuma status to sitelib .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54166 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42e7eae743d319b0afd9653a9d6f1f2701856ca9 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: numa: reorganize module
gerrit-hooks has posted comments on this change. Change subject: numa: reorganize module .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54167 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e8ca3092d4c14827d0965a535ef3d0ac7ba4b0a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: numa: add docstrings for public methods
gerrit-hooks has posted comments on this change. Change subject: numa: add docstrings for public methods .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54171 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id84872556a3f0699a738071ca7d3f9809bea305b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps/numa: move autonuma status to sitelib
gerrit-hooks has posted comments on this change. Change subject: caps/numa: move autonuma status to sitelib .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54166 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42e7eae743d319b0afd9653a9d6f1f2701856ca9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: numa: reorganize module
gerrit-hooks has posted comments on this change. Change subject: numa: reorganize module .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54167 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e8ca3092d4c14827d0965a535ef3d0ac7ba4b0a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sync debian folder with supervdsm_api dir
Simone Tiraboschi has posted comments on this change. Change subject: sync debian folder with supervdsm_api dir .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54153 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic126f9efc02d32f0edab9ea7c2fab362613319de Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: numa: add docstrings for public methods
gerrit-hooks has posted comments on this change. Change subject: numa: add docstrings for public methods .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54171 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id84872556a3f0699a738071ca7d3f9809bea305b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: numa: add docstrings for public methods
Martin Polednik has uploaded a new change for review.
Change subject: numa: add docstrings for public methods
..
numa: add docstrings for public methods
Change-Id: Id84872556a3f0699a738071ca7d3f9809bea305b
Signed-off-by: Martin Polednik
---
M lib/vdsm/numa.py
1 file changed, 32 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/54171/1
diff --git a/lib/vdsm/numa.py b/lib/vdsm/numa.py
index 9eac3f3..6ad3e69 100644
--- a/lib/vdsm/numa.py
+++ b/lib/vdsm/numa.py
@@ -41,13 +41,13 @@
def memory_by_cell(index):
-"""
+'''
Get the memory stats of a specified numa node, the unit is MiB.
:param cell: the index of numa node
:type cell: int
:return: dict like {'total': '49141', 'free': '46783'}
-"""
+'''
meminfo = libvirtconnection.get().getMemoryStats(index, 0)
meminfo['total'] = str(meminfo['total'] / 1024)
meminfo['free'] = str(meminfo['free'] / 1024)
@@ -55,14 +55,44 @@
def topology(capabilities=None):
+'''
+Get what we call 'numa topology' of the host from libvirt. This topology
+contains mapping numa cell -> (cpu ids, total memory).
+
+Example:
+{'0': {'cpus': [0, 1, 2, 3, 4, 10, 11, 12, 13, 14],
+ 'totalMemory': '32657'},
+ '1': {'cpus': [5, 6, 7, 8, 9, 15, 16, 17, 18, 19],
+ 'totalMemory': '32768'}}
+'''
return _numa(capabilities).topology
def distances():
+'''
+Get distances between numa nodes. The information is a mapping
+numa cell -> [distance], where distances are sorted relatively to cell id
+in ascending order.
+
+Example:
+{'0': [10, 21],
+ '1': [21, 10]}
+'''
return _numa().distances
def cpu_topology(capabilities=None):
+'''
+Get 'cpu topology' of the host from libvirt. This topology tries to
+summarize the cpu attributes over all numa cells. It is not reliable and
+should be reworked in future.
+
+Example:
+{'sockets': 1,
+ 'cores': 10,
+ 'threads': 20,
+ 'onlineCpus': '0,1,2,3,4,10,11,12,13,14,5,6,7,8,9,15,16,17,18,19'}
+'''
return _numa(capabilities).cpu_topology
--
To view, visit https://gerrit.ovirt.org/54171
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id84872556a3f0699a738071ca7d3f9809bea305b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: createImageLinks: recreate if the link exists but it's broken
Simone Tiraboschi has posted comments on this change.
Change subject: createImageLinks: recreate if the link exists but it's broken
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/52937/7/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:
Line 537: self.log.error(
Line 538: "Failed to re-create img run dir: %s",
Line 539: imgRunDir
Line 540: )
Line 541: raise
> This block is repeated in both fileSD.py and blockSD.py, and another very s
OK, let's wait for 53680 to be in and then I'll rebase on that.
Line 542: else:
Line 543: self.log.error("Failed to create img run dir: %s",
imgRunDir)
Line 544: raise
Line 545:
--
To view, visit https://gerrit.ovirt.org/52937
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0eb50f57cf6f21496f7a8ef70f80693336ae803
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sandro Bonazzola
Gerrit-Reviewer: Simone Tiraboschi
Gerrit-Reviewer: Tal Nisan
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: numa: reorganize module
gerrit-hooks has posted comments on this change. Change subject: numa: reorganize module .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54167 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e8ca3092d4c14827d0965a535ef3d0ac7ba4b0a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps/numa: move autonuma status to sitelib
gerrit-hooks has posted comments on this change. Change subject: caps/numa: move autonuma status to sitelib .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54166 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42e7eae743d319b0afd9653a9d6f1f2701856ca9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: numa: reorganize module
Martin Polednik has uploaded a new change for review.
Change subject: numa: reorganize module
..
numa: reorganize module
Change-Id: I7e8ca3092d4c14827d0965a535ef3d0ac7ba4b0a
Signed-off-by: Martin Polednik
---
M lib/vdsm/numa.py
1 file changed, 34 insertions(+), 34 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/54167/1
diff --git a/lib/vdsm/numa.py b/lib/vdsm/numa.py
index ab1f814..9eac3f3 100644
--- a/lib/vdsm/numa.py
+++ b/lib/vdsm/numa.py
@@ -40,22 +40,30 @@
_AUTONUMA_STATUS_UNKNOWN = 2
-@utils.memoized
-def autonuma_status():
-out = _run_command(['-n', '-e', 'kernel.numa_balancing'])
+def memory_by_cell(index):
+"""
+Get the memory stats of a specified numa node, the unit is MiB.
-if not out:
-return _AUTONUMA_STATUS_UNKNOWN
-elif out[0] == '0':
-return _AUTONUMA_STATUS_DISABLE
-elif out[0] == '1':
-return _AUTONUMA_STATUS_ENABLE
-else:
-return _AUTONUMA_STATUS_UNKNOWN
+:param cell: the index of numa node
+:type cell: int
+:return: dict like {'total': '49141', 'free': '46783'}
+"""
+meminfo = libvirtconnection.get().getMemoryStats(index, 0)
+meminfo['total'] = str(meminfo['total'] / 1024)
+meminfo['free'] = str(meminfo['free'] / 1024)
+return meminfo
-def _get_libvirt_caps():
-return libvirtconnection.get().getCapabilities()
+def topology(capabilities=None):
+return _numa(capabilities).topology
+
+
+def distances():
+return _numa().distances
+
+
+def cpu_topology(capabilities=None):
+return _numa(capabilities).cpu_topology
@utils.memoized
@@ -100,30 +108,22 @@
return NumaTopology(topology, distances, cpu_topology)
-def memory_by_cell(index):
-"""
-Get the memory stats of a specified numa node, the unit is MiB.
+@utils.memoized
+def autonuma_status():
+out = _run_command(['-n', '-e', 'kernel.numa_balancing'])
-:param cell: the index of numa node
-:type cell: int
-:return: dict like {'total': '49141', 'free': '46783'}
-"""
-meminfo = libvirtconnection.get().getMemoryStats(index, 0)
-meminfo['total'] = str(meminfo['total'] / 1024)
-meminfo['free'] = str(meminfo['free'] / 1024)
-return meminfo
+if not out:
+return _AUTONUMA_STATUS_UNKNOWN
+elif out[0] == '0':
+return _AUTONUMA_STATUS_DISABLE
+elif out[0] == '1':
+return _AUTONUMA_STATUS_ENABLE
+else:
+return _AUTONUMA_STATUS_UNKNOWN
-def topology(capabilities=None):
-return _numa(capabilities).topology
-
-
-def distances():
-return _numa().distances
-
-
-def cpu_topology(capabilities=None):
-return _numa(capabilities).cpu_topology
+def _get_libvirt_caps():
+return libvirtconnection.get().getCapabilities()
def _run_command(args):
--
To view, visit https://gerrit.ovirt.org/54167
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e8ca3092d4c14827d0965a535ef3d0ac7ba4b0a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: numa: move numa related functionality to sitelib
gerrit-hooks has posted comments on this change. Change subject: numa: move numa related functionality to sitelib .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2dffad8663ca50a67f117b1c74d4459e667d9f43 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: numa: move cpu topology (numa) related functionality to sitelib
gerrit-hooks has posted comments on this change. Change subject: numa: move cpu topology (numa) related functionality to sitelib .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53287 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie786e8a3626dd257c2a244decfe3e6a127d04b28 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: numa: refactor to single pass caps parse
gerrit-hooks has posted comments on this change. Change subject: numa: refactor to single pass caps parse .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53288 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie81b5b76523070ec9fd7a6ffe902ffa25da9e3a6 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps/numa: move autonuma status to sitelib
gerrit-hooks has posted comments on this change. Change subject: caps/numa: move autonuma status to sitelib .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54166 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42e7eae743d319b0afd9653a9d6f1f2701856ca9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps/numa: move autonuma status to sitelib
gerrit-hooks has posted comments on this change. Change subject: caps/numa: move autonuma status to sitelib .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54166 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42e7eae743d319b0afd9653a9d6f1f2701856ca9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps/numa: move autonuma status to sitelib
Martin Polednik has uploaded a new change for review.
Change subject: caps/numa: move autonuma status to sitelib
..
caps/numa: move autonuma status to sitelib
Change-Id: I42e7eae743d319b0afd9653a9d6f1f2701856ca9
Signed-off-by: Martin Polednik
---
M lib/vdsm/numa.py
M tests/capsTests.py
M vdsm/caps.py
3 files changed, 35 insertions(+), 22 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/54166/1
diff --git a/lib/vdsm/numa.py b/lib/vdsm/numa.py
index 64195e5..9ec6aac 100644
--- a/lib/vdsm/numa.py
+++ b/lib/vdsm/numa.py
@@ -23,11 +23,34 @@
from collections import defaultdict, namedtuple
import xml.etree.ElementTree as ET
+from . import commands
from . import utils
from . import libvirtconnection
NumaTopology = namedtuple('NumaTopology', 'topology, distances, cpu_topology')
+
+
+_SYSCTL = utils.CommandPath("sysctl", "/sbin/sysctl", "/usr/sbin/sysctl")
+
+
+_AUTONUMA_STATUS_DISABLE = 0
+_AUTONUMA_STATUS_ENABLE = 1
+_AUTONUMA_STATUS_UNKNOWN = 2
+
+
+@utils.memoized
+def autonuma_status():
+out = _run_command(['-n', '-e', 'kernel.numa_balancing'])
+
+if not out:
+return _AUTONUMA_STATUS_UNKNOWN
+elif out[0] == '0':
+return _AUTONUMA_STATUS_DISABLE
+elif out[0] == '1':
+return _AUTONUMA_STATUS_ENABLE
+else:
+return _AUTONUMA_STATUS_UNKNOWN
def _get_libvirt_caps():
@@ -100,3 +123,13 @@
def cpu_topology(capabilities=None):
return _numa(capabilities).cpu_topology
+
+
+def _run_command(args):
+cmd = [_SYSCTL.cmd]
+cmd.extend(args)
+rc, out, err = commands.execCmd(cmd, raw=True)
+if rc != 0:
+raise cmdutils.Error(cmd, rc, out, err)
+
+return out
diff --git a/tests/capsTests.py b/tests/capsTests.py
index 1a26189..4952ee5 100644
--- a/tests/capsTests.py
+++ b/tests/capsTests.py
@@ -150,7 +150,7 @@
@MonkeyPatch(commands, 'execCmd', lambda x: (0, ['0'], []))
def testAutoNumaBalancingInfo(self):
-t = caps.getAutoNumaBalancingInfo()
+t = numa.autonuma_status()
self.assertEqual(t, 0)
def testLiveSnapshotNoElementX86_64(self):
diff --git a/vdsm/caps.py b/vdsm/caps.py
index 19cadf3..d0ce072 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -80,12 +80,6 @@
POWERKVM = 'PowerKVM'
-class AutoNumaBalancingStatus:
-DISABLE = 0
-ENABLE = 1
-UNKNOWN = 2
-
-
RNG_SOURCES = {'random': '/dev/random',
'hwrng': '/dev/hwrng'}
@@ -167,20 +161,6 @@
logging.debug("libvirt is missing '%s': live merge disabled", flag)
return False
return True
-
-
-@utils.memoized
-def getAutoNumaBalancingInfo():
-retcode, out, err = commands.execCmd(['sysctl', '-n', '-e',
- 'kernel.numa_balancing'])
-if not out:
-return AutoNumaBalancingStatus.UNKNOWN
-elif out[0] == '0':
-return AutoNumaBalancingStatus.DISABLE
-elif out[0] == '1':
-return AutoNumaBalancingStatus.ENABLE
-else:
-return AutoNumaBalancingStatus.UNKNOWN
def _get_emulated_machines_from_node(node):
@@ -477,7 +457,7 @@
caps['numaNodes'] = numa.topology()
caps['numaNodeDistance'] = numa.distances()
-caps['autoNumaBalancing'] = getAutoNumaBalancingInfo()
+caps['autoNumaBalancing'] = numa.autonuma_status()
caps['selinux'] = _getSELinux()
--
To view, visit https://gerrit.ovirt.org/54166
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I42e7eae743d319b0afd9653a9d6f1f2701856ca9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Don't fail connect server when getting volume info
Ala Hino has posted comments on this change. Change subject: gluster: Don't fail connect server when getting volume info .. Patch Set 5: Tried the following: Provided this dummy path: test:/vol1 And provide these mount options: backup-volfile-servers=s1:s2 Got following mount cmd: /usr/bin/mount -t glusterfs -o backup-volfile-servers=s1:s2 test:/vol /rhev/data-center/mnt/glusterSD/test:_vol Didn't fail on getting vol info but of course failed, as expected, on mounting the fake servers -- To view, visit https://gerrit.ovirt.org/53785 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e1835b7de4c5c4c5c4616d3c36f15c1f91a01dc Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: remove unused methods
Piotr Kliczewski has posted comments on this change. Change subject: api: remove unused methods .. Patch Set 3: Verified+1 Verified by running local build. -- To view, visit https://gerrit.ovirt.org/53673 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa97a687aad51e319eceffd9f82bc863a28e6bb8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: remove unused methods
gerrit-hooks has posted comments on this change. Change subject: api: remove unused methods .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53673 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa97a687aad51e319eceffd9f82bc863a28e6bb8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: numa: get distance information from libvirt
gerrit-hooks has posted comments on this change. Change subject: numa: get distance information from libvirt .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53285 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80b423e27fa37bc49388cca72785b081e4365e69 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: numa: move cpu topology (numa) related functionality to sitelib
gerrit-hooks has posted comments on this change. Change subject: numa: move cpu topology (numa) related functionality to sitelib .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53287 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie786e8a3626dd257c2a244decfe3e6a127d04b28 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: numa: move numa related functionality to sitelib
gerrit-hooks has posted comments on this change. Change subject: numa: move numa related functionality to sitelib .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2dffad8663ca50a67f117b1c74d4459e667d9f43 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: numa: refactor to single pass caps parse
gerrit-hooks has posted comments on this change. Change subject: numa: refactor to single pass caps parse .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53288 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie81b5b76523070ec9fd7a6ffe902ffa25da9e3a6 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [wip] bridge: usage of yaml schema
Piotr Kliczewski has posted comments on this change. Change subject: [wip] bridge: usage of yaml schema .. Patch Set 4: Verified+1 Verified by host deploying the host and seeing no issues. Before I assume this patch to be ready I need to implement type verification. -- To view, visit https://gerrit.ovirt.org/53919 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id24a5e078fa92e4129d37a47593c7a167e78712e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: schema converter
Piotr Kliczewski has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 16: Verified+1 Verified by host deploying the host and seeing no issues. -- To view, visit https://gerrit.ovirt.org/52864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bridge: obtain method
Piotr Kliczewski has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 7: Verified+1 Verified by host deploying the host and seeing no issues. -- To view, visit https://gerrit.ovirt.org/53472 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b6cb53d8e42335510e34dfe372c1c21b80ac219 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json: use forzenset for filtered methods
Piotr Kliczewski has posted comments on this change. Change subject: json: use forzenset for filtered methods .. Patch Set 1: Verified+1 Verified by host deploying the host and seeing no issues. -- To view, visit https://gerrit.ovirt.org/54160 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17becc319fb8e226f0badc883007900c8862a520 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bridge: remove dead code
Piotr Kliczewski has posted comments on this change. Change subject: bridge: remove dead code .. Patch Set 3: Verified+1 Verified by host deploying the host and seeing no issues. -- To view, visit https://gerrit.ovirt.org/53918 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e9a1a1289ffb89d3b39cd4b46ef72df0a615ff3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: provide more info when method not found
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: provide more info when method not found .. Patch Set 4: Verified+1 Verified by host deploying the host and seeing no issues. -- To view, visit https://gerrit.ovirt.org/53714 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib29240f002ab7c11744d164cf4e0ea5f47924929 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: api: move networks removal to a separate function
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: api: move networks removal to a separate function .. net: api: move networks removal to a separate function As a part of preparation of network/api.py module split, we should extract networks removal handling from setupNetworks(). Change-Id: I50ddc121a220823a44173c95e5eafd0ee30d7a5c Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/54086 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M lib/vdsm/network/api.py 1 file changed, 36 insertions(+), 30 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54086 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50ddc121a220823a44173c95e5eafd0ee30d7a5c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: api: move networks removal to a separate function
gerrit-hooks has posted comments on this change. Change subject: net: api: move networks removal to a separate function .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/54086 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50ddc121a220823a44173c95e5eafd0ee30d7a5c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: api: move networks removal to a separate function
Dan Kenigsberg has posted comments on this change. Change subject: net: api: move networks removal to a separate function .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54086 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50ddc121a220823a44173c95e5eafd0ee30d7a5c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bridge: remove dead code
gerrit-hooks has posted comments on this change. Change subject: bridge: remove dead code .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53918 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e9a1a1289ffb89d3b39cd4b46ef72df0a615ff3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: remove unused types
gerrit-hooks has posted comments on this change. Change subject: schema: remove unused types .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e5ad34cce60feb18f0e8a481b3105b4ff9825cb Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: schema converter
gerrit-hooks has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 16: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json: use forzenset for filtered methods
gerrit-hooks has posted comments on this change. Change subject: json: use forzenset for filtered methods .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54160 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17becc319fb8e226f0badc883007900c8862a520 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [wip] bridge: usage of yaml schema
gerrit-hooks has posted comments on this change. Change subject: [wip] bridge: usage of yaml schema .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53919 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id24a5e078fa92e4129d37a47593c7a167e78712e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix schema
gerrit-hooks has posted comments on this change. Change subject: gluster: fix schema .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I070c9cd7509918a58cc70d4e66dae68b7d8cae0f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json: use forzenset for filtered methods
Piotr Kliczewski has uploaded a new change for review.
Change subject: json: use forzenset for filtered methods
..
json: use forzenset for filtered methods
Change-Id: I17becc319fb8e226f0badc883007900c8862a520
Signed-off-by: pkliczewski
---
M lib/yajsonrpc/__init__.py
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/54160/1
diff --git a/lib/yajsonrpc/__init__.py b/lib/yajsonrpc/__init__.py
index 3724a91..aa7e82d 100644
--- a/lib/yajsonrpc/__init__.py
+++ b/lib/yajsonrpc/__init__.py
@@ -469,6 +469,10 @@
class JsonRpcServer(object):
log = logging.getLogger("jsonrpc.JsonRpcServer")
+filtered_methods = frozenset(['Host_getVMList', 'Host_getAllVmStats',
+ 'Host_getStats', 'StorageDomain_getStats',
+ 'VM_getStats', 'Host_fenceNode'])
+
"""
Creates new JsonrRpcServer by providing a bridge, timeout in seconds
which defining how often we should log connections stats and thread
@@ -502,9 +506,7 @@
self._attempt_log_stats()
mangledMethod = req.method.replace(".", "_")
logLevel = logging.DEBUG
-if mangledMethod in ('Host_getVMList', 'Host_getAllVmStats',
- 'Host_getStats', 'StorageDomain_getStats',
- 'VM_getStats', 'Host_fenceNode'):
+if mangledMethod in self.filtered_methods:
logLevel = logging.TRACE
self.log.log(logLevel, "Calling '%s' in bridge with %s",
req.method, req.params)
--
To view, visit https://gerrit.ovirt.org/54160
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I17becc319fb8e226f0badc883007900c8862a520
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: provide more info when method not found
gerrit-hooks has posted comments on this change. Change subject: jsonrpc: provide more info when method not found .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53714 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib29240f002ab7c11744d164cf4e0ea5f47924929 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bridge: obtain method
gerrit-hooks has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53472 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b6cb53d8e42335510e34dfe372c1c21b80ac219 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: tests: cleanup net after test_rollback
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: tests: cleanup net after test_rollback .. net: tests: cleanup net after test_rollback Without @cleanupNet decorator, failed test can leave network remains which make other tests fail. With this decorator, failed test triggers cleanup of networks. Note that non-failed tests has to do the cleanup on its own. Change-Id: I9b0fd6f549644c9d739303d255629998415263a6 Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/54010 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M tests/functional/networkTests.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved Objections: Edward Haas: I would prefer that you didn't submit this -- To view, visit https://gerrit.ovirt.org/54010 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b0fd6f549644c9d739303d255629998415263a6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: tests: cleanup net after test_rollback
gerrit-hooks has posted comments on this change. Change subject: net: tests: cleanup net after test_rollback .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/54010 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0fd6f549644c9d739303d255629998415263a6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: tests: cleanup net after test_rollback
Dan Kenigsberg has posted comments on this change. Change subject: net: tests: cleanup net after test_rollback .. Patch Set 2: Code-Review+2 Edy's comment has been acted upon -- To view, visit https://gerrit.ovirt.org/54010 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0fd6f549644c9d739303d255629998415263a6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: tests: cleanup net after test_rollback
Petr Horáček has posted comments on this change. Change subject: net: tests: cleanup net after test_rollback .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/54010 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0fd6f549644c9d739303d255629998415263a6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: rename destroyOnMasterRemoval
gerrit-hooks has posted comments on this change. Change subject: net: rename destroyOnMasterRemoval .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/54082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ca4ba568c3f24b20a5e9ee70b3f6935bbc22eab Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: rename destroyOnMasterRemoval
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: rename destroyOnMasterRemoval .. net: rename destroyOnMasterRemoval destroyOnMasterRemoval parameter was needed to say whether bonding should be removed together with network (implicit bonding) or just detached. Now when we drop implicit bonding, we can change it's logic to something more understandable. With this patch, destroyOnMasterRemoval was renamed to on_removal_just_detach_from_network. It's extremely long, but verbosity is needed here. Default functionality of bond.remove() is evidently removal, so this new parameter is False by default. When a bonding is objectivized as a part of a network, we need it to be just detached from master, set it default MTU etc, so it will be a standalone bonding again. When we objectivize it as a part of bonding query, then by bond.remove() we really mean the removal. Change-Id: I0ca4ba568c3f24b20a5e9ee70b3f6935bbc22eab Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/54082 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M lib/vdsm/network/api.py M lib/vdsm/network/configurators/ifcfg.py M lib/vdsm/network/configurators/iproute2.py M lib/vdsm/network/models.py 4 files changed, 27 insertions(+), 29 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ca4ba568c3f24b20a5e9ee70b3f6935bbc22eab Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: rename destroyOnMasterRemoval
Dan Kenigsberg has posted comments on this change. Change subject: net: rename destroyOnMasterRemoval .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ca4ba568c3f24b20a5e9ee70b3f6935bbc22eab Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Don't fail connect server when getting volume info
Ala Hino has posted comments on this change.
Change subject: gluster: Don't fail connect server when getting volume info
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/53785/4/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:
Line 347: "servers")
Line 348: return
Line 349:
Line 350: if self.volinfo is None:
Line 351: return
> I think the flow is:
This return does not disable the entire flow, it only "breaks" the validate
method. Anyway, I will change it to id self.volinfo is not None and add the
validation block inside the if. This way, we don't break future validation that
are not related to volinfo.
Regarding the backup servers, we still have this feature even if volinfo is
None. In 'options' property we first check whether user provide the backup
option and if so we use it. If not, we try to get the servers using volinfo.
Line 352:
Line 353: replicaCount = self.volinfo['replicaCount']
Line 354: if replicaCount not in self.ALLOWED_REPLICA_COUNTS:
Line 355: self.log.warning("Unsupported replica count (%s) for
volume %r, "
--
To view, visit https://gerrit.ovirt.org/53785
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e1835b7de4c5c4c5c4616d3c36f15c1f91a01dc
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Don't fail connect server when getting volume info
gerrit-hooks has posted comments on this change. Change subject: gluster: Don't fail connect server when getting volume info .. Patch Set 5: * #1303977::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1303977::OK, public bug * Check Product::#1303977::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53785 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e1835b7de4c5c4c5c4616d3c36f15c1f91a01dc Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Apply storage QoS on running VM
gerrit-hooks has posted comments on this change. Change subject: Apply storage QoS on running VM .. Patch Set 14: * #1201482::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1201482::OK, public bug * Check Product::#1201482::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52746 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f5fcb8705c974f1d91c90cdb3158d2e8dd314f8 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Roman Mohr Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
