Change in vdsm[master]: net: Removing 'link' scoped addresses from the ip address list
gerrit-hooks has posted comments on this change. Change subject: net: Removing 'link' scoped addresses from the ip address list .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/54211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8bbee8deebdfc617bc82f811e8a20e4db11ebb5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Yevgeny Zaspitsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: add Rng and Tpm device to the device list
Dan Kenigsberg has posted comments on this change.
Change subject: schema: add Rng and Tpm device to the device list
..
Patch Set 7:
Traceback (most recent call last):
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/testlib.py",
line 73, in wrapper
return f(self, *args)
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/stompTests.py",
line 103, in test_event
client.callMethod("event", [], str(uuid4()))
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/lib/yajsonrpc/__init__.py",
line 339, in callMethod
raise JsonRpcNoResponseError(methodName)
JsonRpcNoResponseError: [-32605] No response for JSON-RPC event request.
--
To view, visit https://gerrit.ovirt.org/54425
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ad65b8714e3dfa7bdc8824461bfae2f9dacae1
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Arik Hadas
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...
gerrit-hooks has posted comments on this change. Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54555 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idddfb096e6ea384dbe6655c5c4178d4884a8db85 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: api: keep names and quotes consistent
gerrit-hooks has posted comments on this change. Change subject: net: api: keep names and quotes consistent .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54351 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cfbd8a9ecfbde9964d378449df9e9b0c227c0d6 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: api: replace custom logger with logging
gerrit-hooks has posted comments on this change. Change subject: net: api: replace custom logger with logging .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54350 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia05f237dedcf932028169e4d8fd336b42dbe5125 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: add Rng and Tpm device to the device list
gerrit-hooks has posted comments on this change. Change subject: schema: add Rng and Tpm device to the device list .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5ad65b8714e3dfa7bdc8824461bfae2f9dacae1 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bridge: data verification
gerrit-hooks has posted comments on this change. Change subject: bridge: data verification .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53919 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id24a5e078fa92e4129d37a47593c7a167e78712e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bridge: obtain method
gerrit-hooks has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53472 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b6cb53d8e42335510e34dfe372c1c21b80ac219 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json: use forzenset for filtered methods
gerrit-hooks has posted comments on this change. Change subject: json: use forzenset for filtered methods .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54160 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17becc319fb8e226f0badc883007900c8862a520 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json: removal of old schemas
Piotr Kliczewski has posted comments on this change. Change subject: json: removal of old schemas .. Patch Set 3: Verified+1 Verified by host deploying vdsm and seeing that there are no issues with communication. -- To view, visit https://gerrit.ovirt.org/54548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d8a9d0837408ab727ecdeaa37d49efbca5bebdc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: schema converter
gerrit-hooks has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 20: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json: removal of old schemas
gerrit-hooks has posted comments on this change. Change subject: json: removal of old schemas .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d8a9d0837408ab727ecdeaa37d49efbca5bebdc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bridge: usage of yaml schema
gerrit-hooks has posted comments on this change. Change subject: bridge: usage of yaml schema .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54528 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia76d8245568514d20e446237bd667d87fb4ad3e8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bridge: usage of yaml schema
Piotr Kliczewski has posted comments on this change. Change subject: bridge: usage of yaml schema .. Patch Set 3: Verified+1 Fixed issue in bridgeTests no code changes. -- To view, visit https://gerrit.ovirt.org/54528 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia76d8245568514d20e446237bd667d87fb4ad3e8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: provide more info when method not found
gerrit-hooks has posted comments on this change. Change subject: jsonrpc: provide more info when method not found .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53714 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib29240f002ab7c11744d164cf4e0ea5f47924929 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bridge: remove dead code
gerrit-hooks has posted comments on this change. Change subject: bridge: remove dead code .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53918 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e9a1a1289ffb89d3b39cd4b46ef72df0a615ff3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added fc23 packages to the automation scripts
gerrit-hooks has posted comments on this change. Change subject: Added fc23 packages to the automation scripts .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/48180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie64c291a55c8e5790effac48ae33c12b822a1259 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: David Caro Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added fc23 packages to the automation scripts
David Caro has abandoned this change. Change subject: Added fc23 packages to the automation scripts .. Abandoned reopen if needed -- To view, visit https://gerrit.ovirt.org/48180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ie64c291a55c8e5790effac48ae33c12b822a1259 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: David Caro Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move storage_exception module to lib
Nir Soffer has posted comments on this change. Change subject: storage: Move storage_exception module to lib .. Patch Set 8: Code-Review+2 Thanks! -- To view, visit https://gerrit.ovirt.org/54467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4995df5a670ca9bd460043d44d2855eb64a78f8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move storage_exception module to lib
Nir Soffer has posted comments on this change. Change subject: storage: Move storage_exception module to lib .. Patch Set 8: Waiting for jenkins -- To view, visit https://gerrit.ovirt.org/54467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4995df5a670ca9bd460043d44d2855eb64a78f8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...
gerrit-hooks has posted comments on this change. Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54555 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idddfb096e6ea384dbe6655c5c4178d4884a8db85 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move storage_exception module to lib
gerrit-hooks has posted comments on this change. Change subject: storage: Move storage_exception module to lib .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4995df5a670ca9bd460043d44d2855eb64a78f8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move storage_exception module to lib
Freddy Rolland has posted comments on this change. Change subject: storage: Move storage_exception module to lib .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/54467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4995df5a670ca9bd460043d44d2855eb64a78f8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move storage_exception module to lib
Freddy Rolland has posted comments on this change. Change subject: storage: Move storage_exception module to lib .. Patch Set 7: (8 comments) https://gerrit.ovirt.org/#/c/54467/7/tests/blockVolumeTests.py File tests/blockVolumeTests.py: Line 1: # Line 2: # Copyright 2016 Red Hat, Inc. > Should be 2015-2016 Done Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or https://gerrit.ovirt.org/#/c/54467/7/tests/functional/storageTests.py File tests/functional/storageTests.py: Line 1: # Line 2: # Copyright 2016 Red Hat, Inc. > 2012-2016 Done Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or https://gerrit.ovirt.org/#/c/54467/7/tests/storagefakelib.py File tests/storagefakelib.py: Line 1: # Copyright 2016 Red Hat, Inc. > 2015-2016 Done Line 2: # Line 3: # This program is free software; you can redistribute it and/or modify Line 4: # it under the terms of the GNU General Public License as published by Line 5: # the Free Software Foundation; either version 2 of the License, or https://gerrit.ovirt.org/#/c/54467/7/tests/storagefakelibTests.py File tests/storagefakelibTests.py: Line 1: # Copyright 2016 Red Hat, Inc. > 2015-2016 Done Line 2: # Line 3: # This program is free software; you can redistribute it and/or modify Line 4: # it under the terms of the GNU General Public License as published by Line 5: # the Free Software Foundation; either version 2 of the License, or https://gerrit.ovirt.org/#/c/54467/7/vdsm/storage/Makefile.am File vdsm/storage/Makefile.am: Line 9 Line 10 Line 11 Line 12 Line 13 > Is this copyright updated? It is already updated https://gerrit.ovirt.org/#/c/54467/7/vdsm/storage/imageRepository/formatConverter.py File vdsm/storage/imageRepository/formatConverter.py: Line 1: # Line 2: # Copyright 2016 Red Hat, Inc. > 2012-2016 Done Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or https://gerrit.ovirt.org/#/c/54467/7/vdsm/storage/misc.py File vdsm/storage/misc.py: Line 1 Line 2 Line 3 Line 4 > Is this copyright updated? It is already updated https://gerrit.ovirt.org/#/c/54467/7/vdsm/storage/resourceManager.py File vdsm/storage/resourceManager.py: Line 1: # Line 2: # Copyright 2016 Red Hat, Inc. > 2011-2016 Done Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or -- To view, visit https://gerrit.ovirt.org/54467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4995df5a670ca9bd460043d44d2855eb64a78f8 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...
gerrit-hooks has posted comments on this change. Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54555 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idddfb096e6ea384dbe6655c5c4178d4884a8db85 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...
Ondřej Svoboda has uploaded a new change for review. Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards .. ifcfg: re-enable IPv6 before device configuration, or disable afterwards If a network has been restored with no IPv6 requested, all its devices have disable_ipv6 set to 1 and up to now there was no other way to re-enable IPv6 than doing so manually or rebooting. This patch enables IPv6 on all devices prior to ifup, or disables IPv6 on them after ifup. Change-Id: Idddfb096e6ea384dbe6655c5c4178d4884a8db85 Signed-off-by: Ondřej Svoboda --- M lib/vdsm/network/configurators/__init__.py M lib/vdsm/network/configurators/ifcfg.py M lib/vdsm/network/models.py 3 files changed, 39 insertions(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/54555/1 diff --git a/lib/vdsm/network/configurators/__init__.py b/lib/vdsm/network/configurators/__init__.py index 69e97e7..d8e9e15 100644 --- a/lib/vdsm/network/configurators/__init__.py +++ b/lib/vdsm/network/configurators/__init__.py @@ -18,14 +18,17 @@ # from __future__ import absolute_import +import errno import logging from six.moves import configparser from vdsm.config import config from vdsm.netconfpersistence import RunningConfig from vdsm import ipwrapper +from vdsm.netinfo.misc import ipv6_supported from vdsm.netinfo import mtus from vdsm.netlink import monitor +from vdsm import sysctl from .dhclient import DhcpClient from ..errors import ConfigNetworkError, ERR_FAILED_IFUP @@ -204,3 +207,19 @@ return raise ConfigNetworkError(ERR_FAILED_IFUP, 'Device %s was not created ' 'during a %ss timeout.' % (name, timeout)) + + +def enable_ipv6(device_name, enable=True, wait_for_ifup=False): +if ipv6_supported(): +if wait_for_ifup: +wait_for_device(device_name) +try: +sysctl.disable_ipv6(device_name, disable=not enable) +except IOError as e: +if e.errno == errno.ENOENT: + # In broken networks, a device may be missing. If wait_for_ifup + # was used however, ConfigNetworkError would already have been + # raised. + pass +else: +raise diff --git a/lib/vdsm/network/configurators/ifcfg.py b/lib/vdsm/network/configurators/ifcfg.py index 395dd31..eb1f7da 100644 --- a/lib/vdsm/network/configurators/ifcfg.py +++ b/lib/vdsm/network/configurators/ifcfg.py @@ -44,7 +44,6 @@ from vdsm.netinfo import (bonding as netinfo_bonding, mtus, nics, vlans, misc, NET_PATH) from vdsm.netinfo.cache import ifaceUsed -from vdsm import sysctl from vdsm import utils from vdsm.netconfpersistence import RunningConfig, PersistentConfig from vdsm.netlink import monitor @@ -52,7 +51,9 @@ if utils.isOvirtNode(): from ovirt.node.utils import fs as node_fs -from . import Configurator, dhclient, getEthtoolOpts, libvirt, wait_for_device +from . import Configurator, enable_ipv6, getEthtoolOpts +from . import dhclient +from . import libvirt from ..errors import ConfigNetworkError, ERR_FAILED_IFUP from ..models import Nic, Bridge, IPv4, IPv6 from ..sourceroute import StaticSourceRoute, DynamicSourceRoute @@ -100,24 +101,26 @@ self.runningConfig = None def configureBridge(self, bridge, **opts): +if bridge.ipv6.requested: +enable_ipv6(bridge.name) self.configApplier.addBridge(bridge, **opts) ifdown(bridge.name) if bridge.port: bridge.port.configure(**opts) self._addSourceRoute(bridge) _ifup(bridge) -if not bridge.ipv6.address and not bridge.ipv6.ipv6autoconf and ( -not bridge.ipv6.dhcpv6 and misc.ipv6_supported()): -wait_for_device(bridge.name) -sysctl.disable_ipv6(bridge.name) def configureVlan(self, vlan, **opts): +if vlan.ipv6.requested: +enable_ipv6(vlan.name) self.configApplier.addVlan(vlan, **opts) vlan.device.configure(**opts) self._addSourceRoute(vlan) _ifup(vlan) def configureBond(self, bond, **opts): +if bond.ipv6.requested: +enable_ipv6(bond.name) self.configApplier.addBonding(bond, **opts) if not vlans.is_vlanned(bond.name): for slave in bond.slaves: @@ -174,6 +177,8 @@ 'nics': [slave.name for slave in bond.slaves]}) def configureNic(self, nic, **opts): +if nic.ipv6.requested: +enable_ipv6(nic.name) self.configApplier.addNic(nic, **opts) self._addSourceRoute(nic) if nic.bond is None: @@ -533,9 +538,8 @@ if ipv4.defaultRoute is not None: cfg += 'DEFROUTE=%s\n' % _to_ifcfg_bool(ipv4.defaultRoute) cfg += 'NM_CONTROLLED=no\n' -enab
Change in vdsm[master]: storage: Move storage_exception module to lib
Nir Soffer has posted comments on this change. Change subject: storage: Move storage_exception module to lib .. Patch Set 7: (8 comments) Some copyright years needs a fix. https://gerrit.ovirt.org/#/c/54467/7/tests/blockVolumeTests.py File tests/blockVolumeTests.py: Line 1: # Line 2: # Copyright 2016 Red Hat, Inc. Should be 2015-2016 Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or https://gerrit.ovirt.org/#/c/54467/7/tests/functional/storageTests.py File tests/functional/storageTests.py: Line 1: # Line 2: # Copyright 2016 Red Hat, Inc. 2012-2016 Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or https://gerrit.ovirt.org/#/c/54467/7/tests/storagefakelib.py File tests/storagefakelib.py: Line 1: # Copyright 2016 Red Hat, Inc. 2015-2016 Line 2: # Line 3: # This program is free software; you can redistribute it and/or modify Line 4: # it under the terms of the GNU General Public License as published by Line 5: # the Free Software Foundation; either version 2 of the License, or https://gerrit.ovirt.org/#/c/54467/7/tests/storagefakelibTests.py File tests/storagefakelibTests.py: Line 1: # Copyright 2016 Red Hat, Inc. 2015-2016 Line 2: # Line 3: # This program is free software; you can redistribute it and/or modify Line 4: # it under the terms of the GNU General Public License as published by Line 5: # the Free Software Foundation; either version 2 of the License, or https://gerrit.ovirt.org/#/c/54467/7/vdsm/storage/Makefile.am File vdsm/storage/Makefile.am: Line 9 Line 10 Line 11 Line 12 Line 13 Is this copyright updated? https://gerrit.ovirt.org/#/c/54467/7/vdsm/storage/imageRepository/formatConverter.py File vdsm/storage/imageRepository/formatConverter.py: Line 1: # Line 2: # Copyright 2016 Red Hat, Inc. 2012-2016 Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or https://gerrit.ovirt.org/#/c/54467/7/vdsm/storage/misc.py File vdsm/storage/misc.py: Line 1 Line 2 Line 3 Line 4 Is this copyright updated? https://gerrit.ovirt.org/#/c/54467/7/vdsm/storage/resourceManager.py File vdsm/storage/resourceManager.py: Line 1: # Line 2: # Copyright 2016 Red Hat, Inc. 2011-2016 Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or -- To view, visit https://gerrit.ovirt.org/54467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4995df5a670ca9bd460043d44d2855eb64a78f8 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move storage_exception module to lib
Freddy Rolland has posted comments on this change. Change subject: storage: Move storage_exception module to lib .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/54467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4995df5a670ca9bd460043d44d2855eb64a78f8 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: register: Fix certificate validation
gerrit-hooks has posted comments on this change. Change subject: register: Fix certificate validation .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/46981 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idcd1eab617ea21655ec89419c0f3532eefeec4f9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: register: Simplify setting defaults
gerrit-hooks has posted comments on this change. Change subject: register: Simplify setting defaults .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/46979 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id02327439fcc5a88a6489635ea9bd293bbe350cd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: register: Drop CA path redundancies
Fabian Deutsch has abandoned this change. Change subject: register: Drop CA path redundancies .. Abandoned -- To view, visit https://gerrit.ovirt.org/46980 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I0a386f9b3f398ea5e5537e146448954ec3b057cb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: register: Fix certificate validation
Fabian Deutsch has abandoned this change. Change subject: register: Fix certificate validation .. Abandoned -- To view, visit https://gerrit.ovirt.org/46981 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Idcd1eab617ea21655ec89419c0f3532eefeec4f9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: register: Simplify setting defaults
Fabian Deutsch has abandoned this change. Change subject: register: Simplify setting defaults .. Abandoned -- To view, visit https://gerrit.ovirt.org/46979 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id02327439fcc5a88a6489635ea9bd293bbe350cd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: register: Drop CA path redundancies
gerrit-hooks has posted comments on this change. Change subject: register: Drop CA path redundancies .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/46980 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a386f9b3f398ea5e5537e146448954ec3b057cb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json: removal of old schemas
gerrit-hooks has posted comments on this change. Change subject: json: removal of old schemas .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d8a9d0837408ab727ecdeaa37d49efbca5bebdc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: add Rng and Tpm device to the device list
Nir Soffer has posted comments on this change. Change subject: schema: add Rng and Tpm device to the device list .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5ad65b8714e3dfa7bdc8824461bfae2f9dacae1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: machinetype: document public functions
Dan Kenigsberg has posted comments on this change. Change subject: machinetype: document public functions .. Patch Set 4: Code-Review-1 (1 comment) silly nit from me, too. https://gerrit.ovirt.org/#/c/54302/4/lib/vdsm/machinetype.py File lib/vdsm/machinetype.py: Line 124: ''' cpu vendor. also, pep8 asks for triple-doublequotes in docstring, not singlequotes -- To view, visit https://gerrit.ovirt.org/54302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e3e4930566d36f1f58e3cf99b84094984cbd334 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: machinetype: split and slightly refactor cpu_models function
gerrit-hooks has posted comments on this change. Change subject: machinetype: split and slightly refactor cpu_models function .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/54301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I264209f94ef7140e27c534f1df408c7a3a17bbbf Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: machinetype: split and slightly refactor cpu_models function
Dan Kenigsberg has submitted this change and it was merged. Change subject: machinetype: split and slightly refactor cpu_models function .. machinetype: split and slightly refactor cpu_models function cpu_models has grown large as it has to a) having to find the correct architecture element, b) find the cpu models in that element. This patch splits the function and updates variables to have more descriptive names. Change-Id: I264209f94ef7140e27c534f1df408c7a3a17bbbf Signed-off-by: Martin Polednik Reviewed-on: https://gerrit.ovirt.org/54301 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani --- M lib/vdsm/machinetype.py 1 file changed, 30 insertions(+), 26 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/54301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I264209f94ef7140e27c534f1df408c7a3a17bbbf Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json: removal of old schemas
Nir Soffer has posted comments on this change. Change subject: json: removal of old schemas .. Patch Set 1: +226, -12738 - we need more patches like this :-) -- To view, visit https://gerrit.ovirt.org/54548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d8a9d0837408ab727ecdeaa37d49efbca5bebdc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bridge: usage of yaml schema
Piotr Kliczewski has posted comments on this change. Change subject: bridge: usage of yaml schema .. Patch Set 2: Verified+1 Verification as for patch set #1 -- To view, visit https://gerrit.ovirt.org/54528 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia76d8245568514d20e446237bd667d87fb4ad3e8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: osinfo: avoid excepting *
Martin Polednik has posted comments on this change.
Change subject: osinfo: avoid excepting *
..
Patch Set 1:
(3 comments)
will try to be more specific in future ps
https://gerrit.ovirt.org/#/c/54545/1/lib/vdsm/osinfo.py
File lib/vdsm/osinfo.py:
Line 156: def kernelDict():
Line 157: try:
Line 158: ret = os.uname()
Line 159: ver, rel = ret[2].split('-', 1)
Line 160: except Exception:
> let's try to be more specific. Maybe ValueError here?
KeyError and ValueError afaik, need to be careful at this point :/
Line 161: logging.error('kernel release not found', exc_info=True)
Line 162: ver, rel = '0', '0'
Line 163: try:
Line 164: t = ret[3].split()[2:]
Line 193: for pkg, names in KEY_PACKAGES.iteritems():
Line 194: try:
Line 195: mi = itertools.chain(*[ts.dbMatch('name', name)
Line 196:for name in names]).next()
Line 197: except StopIteration:
> uh, this is ugly :\
how? that is the standard approach for iterations
Line 198: logging.debug("rpm package %s not found",
Line 199: KEY_PACKAGES[pkg])
Line 200: else:
Line 201: pkgs[pkg] = {
Line 228: deb_pkg = KEY_PACKAGES[pkg]
Line 229: ver = cache[deb_pkg].installed.version
Line 230: # Debian just offers a version
Line 231: pkgs[pkg] = dict(version=ver, release="",
buildtime="")
Line 232: except Exception:
> maybe narrow down?
this one will be tricky too, unlike others
Line 233: logging.error('', exc_info=True)
Line 234:
--
To view, visit https://gerrit.ovirt.org/54545
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice9171e64fb6b3879a33f5d9566e8aa2546c424f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bridge: data verification
gerrit-hooks has posted comments on this change. Change subject: bridge: data verification .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53919 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id24a5e078fa92e4129d37a47593c7a167e78712e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json: removal of old schemas
gerrit-hooks has posted comments on this change. Change subject: json: removal of old schemas .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d8a9d0837408ab727ecdeaa37d49efbca5bebdc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bridge: remove dead code
gerrit-hooks has posted comments on this change. Change subject: bridge: remove dead code .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53918 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e9a1a1289ffb89d3b39cd4b46ef72df0a615ff3 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: osinfo: refactor package_versions function
Francesco Romani has posted comments on this change.
Change subject: osinfo: refactor package_versions function
..
Patch Set 1: Code-Review-1
(1 comment)
partial review, mostly OK
https://gerrit.ovirt.org/#/c/54546/1/lib/vdsm/osinfo.py
File lib/vdsm/osinfo.py:
Line 153:
Line 154:
Line 155: def package_versions():
Line 156: pkgs = {}
Line 157: pkgs.update(_packages_kernel())
maybe just
pkgs = _packages_kernel()
?
Or perhaps you have a different reason to write it the way you did?
Line 158:
Line 159: if _release() in (OSName.RHEVH,
Line 160: OSName.OVIRT,
Line 161: OSName.FEDORA,
--
To view, visit https://gerrit.ovirt.org/54546
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36e9a605bea5ec6b823eaca4d7669c5060122fcd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: add Rng and Tpm device to the device list
gerrit-hooks has posted comments on this change. Change subject: schema: add Rng and Tpm device to the device list .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5ad65b8714e3dfa7bdc8824461bfae2f9dacae1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: schema converter
gerrit-hooks has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bridge: obtain method
gerrit-hooks has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53472 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b6cb53d8e42335510e34dfe372c1c21b80ac219 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bridge: usage of yaml schema
gerrit-hooks has posted comments on this change. Change subject: bridge: usage of yaml schema .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54528 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia76d8245568514d20e446237bd667d87fb4ad3e8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: provide more info when method not found
gerrit-hooks has posted comments on this change. Change subject: jsonrpc: provide more info when method not found .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53714 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib29240f002ab7c11744d164cf4e0ea5f47924929 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json: removal of old schemas
Piotr Kliczewski has uploaded a new change for review. Change subject: json: removal of old schemas .. json: removal of old schemas Change-Id: I2d8a9d0837408ab727ecdeaa37d49efbca5bebdc Signed-off-by: pkliczewski --- D contrib/schema-converter M debian/vdsm-gluster.install M debian/vdsm.install M lib/api/Makefile.am D lib/api/process-schema.py D lib/api/schemaapi.py D lib/api/vdsmapi-gluster-schema.json D lib/api/vdsmapi-schema.json M lib/api/vdsmapi.py M lib/vdsm/rpc/Bridge.py M tests/Makefile.am D tests/schemaTests.py M tests/schemaValidationTest.py R tests/vdsmapi_test.py M tests/vmApiTests.py M vdsm.spec.in 16 files changed, 226 insertions(+), 12,738 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/54548/1 -- To view, visit https://gerrit.ovirt.org/54548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2d8a9d0837408ab727ecdeaa37d49efbca5bebdc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json: use forzenset for filtered methods
gerrit-hooks has posted comments on this change. Change subject: json: use forzenset for filtered methods .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54160 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17becc319fb8e226f0badc883007900c8862a520 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: Require new libvirt on RHEL
gerrit-hooks has posted comments on this change. Change subject: vdsm.spec: Require new libvirt on RHEL .. Patch Set 1: * #1260131::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1260131::OK, public bug * Check Product::#1260131::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ea25acd1bec9ce7f6f26225f0917d5e38f65508 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: osinfo: avoid excepting *
Francesco Romani has posted comments on this change.
Change subject: osinfo: avoid excepting *
..
Patch Set 1: Code-Review-1
(6 comments)
I like this patch, but -1 for visibility of the inline comments
https://gerrit.ovirt.org/#/c/54545/1/lib/vdsm/osinfo.py
File lib/vdsm/osinfo.py:
Line 156: def kernelDict():
Line 157: try:
Line 158: ret = os.uname()
Line 159: ver, rel = ret[2].split('-', 1)
Line 160: except Exception:
let's try to be more specific. Maybe ValueError here?
Line 161: logging.error('kernel release not found', exc_info=True)
Line 162: ver, rel = '0', '0'
Line 163: try:
Line 164: t = ret[3].split()[2:]
Line 163: try:
Line 164: t = ret[3].split()[2:]
Line 165: del t[4] # Delete timezone
Line 166: t = time.mktime(time.strptime(' '.join(t)))
Line 167: except Exception:
same
Line 168: logging.error('kernel build time not found',
exc_info=True)
Line 169: t = '0'
Line 170: return dict(version=ver, release=rel, buildtime=t)
Line 171:
Line 193: for pkg, names in KEY_PACKAGES.iteritems():
Line 194: try:
Line 195: mi = itertools.chain(*[ts.dbMatch('name', name)
Line 196:for name in names]).next()
Line 197: except StopIteration:
uh, this is ugly :\
Line 198: logging.debug("rpm package %s not found",
Line 199: KEY_PACKAGES[pkg])
Line 200: else:
Line 201: pkgs[pkg] = {
Line 202: 'version': mi['version'],
Line 203: 'release': mi['release'],
Line 204: 'buildtime': mi['buildtime'],
Line 205: }
Line 206: except Exception:
let's keep it this way. Maybe let's narrow down the try/except block in a
future patch.
Line 207: logging.error('', exc_info=True)
Line 208:
Line 209: elif _release() == OSName.DEBIAN and python_apt:
Line 210: KEY_PACKAGES = {
Line 203: 'release': mi['release'],
Line 204: 'buildtime': mi['buildtime'],
Line 205: }
Line 206: except Exception:
Line 207: logging.error('', exc_info=True)
let's use logging.exception() in a future patch.
Line 208:
Line 209: elif _release() == OSName.DEBIAN and python_apt:
Line 210: KEY_PACKAGES = {
Line 211: 'glusterfs-cli': 'glusterfs-cli',
Line 228: deb_pkg = KEY_PACKAGES[pkg]
Line 229: ver = cache[deb_pkg].installed.version
Line 230: # Debian just offers a version
Line 231: pkgs[pkg] = dict(version=ver, release="",
buildtime="")
Line 232: except Exception:
maybe narrow down?
Line 233: logging.error('', exc_info=True)
Line 234:
--
To view, visit https://gerrit.ovirt.org/54545
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice9171e64fb6b3879a33f5d9566e8aa2546c424f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: osinfo: pep8tify kdump_status
Francesco Romani has posted comments on this change. Change subject: osinfo: pep8tify kdump_status .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I989bee245d2ee1371750ab81265e146975989f06 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: osinfo: use pep8 function names
Francesco Romani has posted comments on this change. Change subject: osinfo: use pep8 function names .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54543 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11e49e94e7bfbac08ba11da0ffa773925cca3ef0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: move os-related information to osinfo module
Francesco Romani has posted comments on this change.
Change subject: caps: move os-related information to osinfo module
..
Patch Set 1: Code-Review-1
(1 comment)
good idea! and osinfo is a pretty name.
But please check whyw jenkins is not happy, and let's not leave debian behind!
-1 for visibility
https://gerrit.ovirt.org/#/c/54542/1/vdsm.spec.in
File vdsm.spec.in:
Line 1138: %{python_sitelib}/%{vdsm_name}/network/sourceroute.py*
Line 1139: %{python_sitelib}/%{vdsm_name}/network/sourceroutethread.py*
Line 1140: %{python_sitelib}/%{vdsm_name}/network/utils.py*
Line 1141: %{python_sitelib}/%{vdsm_name}/numa.py*
Line 1142: %{python_sitelib}/%{vdsm_name}/osinfo.py*
we forgot debian again :(
Line 1143: %{python_sitelib}/%{vdsm_name}/password.py*
Line 1144: %{python_sitelib}/%{vdsm_name}/panic.py*
Line 1145: %{python_sitelib}/%{vdsm_name}/ppc64HardwareInfo.py*
Line 1146: %{python_sitelib}/%{vdsm_name}/profiling/__init__.py*
--
To view, visit https://gerrit.ovirt.org/54542
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6f1f7683e0f5acf7ed77082ac9f69203cbcf6b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: use storage's getDefaultInitiatorName
Francesco Romani has posted comments on this change. Change subject: caps: use storage's getDefaultInitiatorName .. Patch Set 2: Code-Review+1 looks OK, but please get ACKs from storage devs. -- To view, visit https://gerrit.ovirt.org/54510 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If49286165b7855b96dd88221de06579485d576f4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: specialize and modernize _parseKeyVal
Francesco Romani has posted comments on this change. Change subject: caps: specialize and modernize _parseKeyVal .. Patch Set 1: Code-Review-1 nice, but I'd like some kind of tests here. Or is this code path already covered? -- To view, visit https://gerrit.ovirt.org/54541 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04b6f813c01fd8745510234ddb9bbb69f4bc67f4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add copyright info
Nir Soffer has submitted this change and it was merged. Change subject: storage: add copyright info .. storage: add copyright info Add copyright info to missing files under storage. Change-Id: I3f69d196a7d16341cd70568db69bba307ff31a41 Signed-off-by: Fred Rolland Reviewed-on: https://gerrit.ovirt.org/54508 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer --- M vdsm/storage/glusterSD.py M vdsm/storage/glusterVolume.py M vdsm/storage/iscsiadm.py M vdsm/storage/sync.py 4 files changed, 80 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/54508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f69d196a7d16341cd70568db69bba307ff31a41 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add copyright info
gerrit-hooks has posted comments on this change. Change subject: storage: add copyright info .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/54508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f69d196a7d16341cd70568db69bba307ff31a41 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add copyright info
Nir Soffer has posted comments on this change. Change subject: storage: add copyright info .. Patch Set 2: Thanks! -- To view, visit https://gerrit.ovirt.org/54508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f69d196a7d16341cd70568db69bba307ff31a41 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add copyright info
Nir Soffer has posted comments on this change. Change subject: storage: add copyright info .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f69d196a7d16341cd70568db69bba307ff31a41 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: osinfo: refactor package_versions function
gerrit-hooks has posted comments on this change. Change subject: osinfo: refactor package_versions function .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54546 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36e9a605bea5ec6b823eaca4d7669c5060122fcd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: osinfo: use pep8 function names
gerrit-hooks has posted comments on this change. Change subject: osinfo: use pep8 function names .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54543 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11e49e94e7bfbac08ba11da0ffa773925cca3ef0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: osinfo: pep8tify kdump_status
Martin Polednik has uploaded a new change for review.
Change subject: osinfo: pep8tify kdump_status
..
osinfo: pep8tify kdump_status
Change-Id: I989bee245d2ee1371750ab81265e146975989f06
Signed-off-by: Martin Polednik
---
M lib/vdsm/osinfo.py
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/54544/1
diff --git a/lib/vdsm/osinfo.py b/lib/vdsm/osinfo.py
index aef4f54..b0f7930 100644
--- a/lib/vdsm/osinfo.py
+++ b/lib/vdsm/osinfo.py
@@ -69,23 +69,23 @@
try:
# check if kdump service is running
with open('/sys/kernel/kexec_crash_loaded', 'r') as f:
-kdumpStatus = int(f.read().strip('\n'))
+status = int(f.read().strip('\n'))
-if kdumpStatus == KdumpStatus.ENABLED:
+if status == KdumpStatus.ENABLED:
# check if fence_kdump is configured
-kdumpStatus = KdumpStatus.DISABLED
+status = KdumpStatus.DISABLED
with open('/etc/kdump.conf', 'r') as f:
for line in f:
if line.startswith('fence_kdump_nodes'):
-kdumpStatus = KdumpStatus.ENABLED
+status = KdumpStatus.ENABLED
break
except (IOError, OSError, ValueError):
-kdumpStatus = KdumpStatus.UNKNOWN
+status = KdumpStatus.UNKNOWN
logging.debug(
'Error detecting fence_kdump configuration status',
exc_info=True,
)
-return kdumpStatus
+return status
@utils.memoized
--
To view, visit https://gerrit.ovirt.org/54544
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I989bee245d2ee1371750ab81265e146975989f06
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: osinfo: pep8tify kdump_status
gerrit-hooks has posted comments on this change. Change subject: osinfo: pep8tify kdump_status .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I989bee245d2ee1371750ab81265e146975989f06 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: specialize and modernize _parseKeyVal
Martin Polednik has uploaded a new change for review.
Change subject: caps: specialize and modernize _parseKeyVal
..
caps: specialize and modernize _parseKeyVal
_parseKeyVal was used as a very generic function to parse lines
including delimiter (in a key=value sense). This is easily implemented
either project-wide or without using parse that generic. Since it is
now only used to parse release and version of rhev-h/node, the function
can be specialized and modernized.
Change-Id: I04b6f813c01fd8745510234ddb9bbb69f4bc67f4
Signed-off-by: Martin Polednik
---
M tests/capsTests.py
M vdsm/caps.py
2 files changed, 13 insertions(+), 22 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/54541/1
diff --git a/tests/capsTests.py b/tests/capsTests.py
index 6249a57..35cd39b 100644
--- a/tests/capsTests.py
+++ b/tests/capsTests.py
@@ -112,14 +112,6 @@
'pc-0.10', 'pc-0.11', 'pc-0.14', 'pc-0.15']
self.assertEqual(machines, expectedMachines)
-def test_parseKeyVal(self):
-lines = ["x=&2", "y& = 2", " z = 2 ", " s=3=&'5", " w=", "4&"]
-expectedRes = [{'x': '&2', 'y&': '2', 'z': '2', 's': "3=&'5", 'w': ''},
- {'x=': '2', 'y': '= 2', 's=3=': "'5", '4': ''}]
-sign = ["=", "&"]
-for res, s in zip(expectedRes, sign):
-self.assertEqual(res, caps._parseKeyVal(lines, s))
-
@MonkeyPatch(numa, 'memory_by_cell', lambda x: {
'total': '49141', 'free': '46783'})
@MonkeyPatch(numa, '_get_libvirt_caps', lambda: _getTestData(
diff --git a/vdsm/caps.py b/vdsm/caps.py
index db7f532..3820d1e 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -164,17 +164,6 @@
return True
-def _parseKeyVal(lines, delim='='):
-d = {}
-for line in lines:
-kv = line.split(delim, 1)
-if len(kv) != 2:
-continue
-k, v = map(str.strip, kv)
-d[k] = v
-return d
-
-
def _getKdumpStatus():
try:
# check if kdump service is running
@@ -216,6 +205,18 @@
return OSName.UNKNOWN
+def _parse_node_version(path):
+data = {}
+with open(path) as f:
+for line in f:
+try:
+key, value = [kv.strip() for kv in line.split('=', 1)]
+except ValueError:
+continue
+
+return data.get('VERSION', ''), data.get('RELEASE', '')
+
+
@utils.memoized
def osversion():
version = release = ''
@@ -223,9 +224,7 @@
osname = getos()
try:
if osname == OSName.RHEVH or osname == OSName.OVIRT:
-d = _parseKeyVal(file('/etc/default/version'))
-version = d.get('VERSION', '')
-release = d.get('RELEASE', '')
+version, release = _parse_node_version('/etc/default/version')
elif osname == OSName.DEBIAN:
version = linecache.getline('/etc/debian_version', 1).strip("\n")
release = "" # Debian just has a version entry
--
To view, visit https://gerrit.ovirt.org/54541
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I04b6f813c01fd8745510234ddb9bbb69f4bc67f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: move os-related information to osinfo module
gerrit-hooks has posted comments on this change. Change subject: caps: move os-related information to osinfo module .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54542 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae6f1f7683e0f5acf7ed77082ac9f69203cbcf6b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: osinfo: refactor package_versions function
Martin Polednik has uploaded a new change for review.
Change subject: osinfo: refactor package_versions function
..
osinfo: refactor package_versions function
package_versions function is a large function that handles different
packaging systems (rpm, deb and kernel version). This patch splits it
into 3 helpers for each system, and only keeping the main function as
orchestrator of those.
Change-Id: I36e9a605bea5ec6b823eaca4d7669c5060122fcd
Signed-off-by: Martin Polednik
---
M lib/vdsm/osinfo.py
1 file changed, 93 insertions(+), 69 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/54546/1
diff --git a/lib/vdsm/osinfo.py b/lib/vdsm/osinfo.py
index 5edc8e0..9792b45 100644
--- a/lib/vdsm/osinfo.py
+++ b/lib/vdsm/osinfo.py
@@ -127,8 +127,8 @@
if osname == OSName.RHEVH or osname == OSName.OVIRT:
version, release_name = _parse_node_version('/etc/default/version')
elif osname == OSName.DEBIAN:
-version = linecache.getline('/etc/debian_version', 1).strip("\n")
-release_name = "" # Debian just has a version entry
+version = linecache.getline('/etc/debian_version', 1).strip('\n')
+release_name = '' # Debian just has a version entry
else:
if osname == OSName.POWERKVM:
release_path = '/etc/ibm_powerkvm-release'
@@ -153,83 +153,107 @@
def package_versions():
-def kernelDict():
-try:
-ret = os.uname()
-ver, rel = ret[2].split('-', 1)
-except Exception:
-logging.error('kernel release not found', exc_info=True)
-ver, rel = '0', '0'
-try:
-t = ret[3].split()[2:]
-del t[4] # Delete timezone
-t = time.mktime(time.strptime(' '.join(t)))
-except Exception:
-logging.error('kernel build time not found', exc_info=True)
-t = '0'
-return dict(version=ver, release=rel, buildtime=t)
+pkgs = {}
+pkgs.update(_packages_kernel())
-pkgs = {'kernel': kernelDict()}
-
-if _release() in (OSName.RHEVH, OSName.OVIRT, OSName.FEDORA, OSName.RHEL,
+if _release() in (OSName.RHEVH,
+ OSName.OVIRT,
+ OSName.FEDORA,
+ OSName.RHEL,
OSName.POWERKVM):
-KEY_PACKAGES = {
-'glusterfs-cli': ('glusterfs-cli',),
-'librbd1': ('librbd1',),
-'libvirt': ('libvirt', 'libvirt-daemon-kvm'),
-'mom': ('mom',),
-'qemu-img': ('qemu-img', 'qemu-img-rhev', 'qemu-img-ev'),
-'qemu-kvm': ('qemu-kvm', 'qemu-kvm-rhev', 'qemu-kvm-ev'),
-'spice-server': ('spice-server',),
-'vdsm': ('vdsm',),
-}
+pkgs.update(_packages_rpm())
+elif _release() == OSName.DEBIAN and python_apt:
+pkgs.update(_packages_apt())
-if glusterEnabled:
-KEY_PACKAGES.update(GLUSTER_RPM_PACKAGES)
+return pkgs
+
+def _packages_apt():
+key_packages = {
+'glusterfs-cli': 'glusterfs-cli',
+'librbd1': 'librbd1',
+'libvirt': 'libvirt0',
+'mom': 'mom',
+'qemu-img': 'qemu-utils',
+'qemu-kvm': 'qemu-kvm',
+'spice-server': 'libspice-server1',
+'vdsm': 'vdsmd',
+}
+
+if glusterEnabled:
+key_packages.update(GLUSTER_DEB_PACKAGES)
+
+key_package_versions = {}
+
+cache = apt.Cache()
+
+for pkg in key_packages:
try:
-ts = rpm.TransactionSet()
-
-for pkg, names in KEY_PACKAGES.iteritems():
-try:
-mi = itertools.chain(*[ts.dbMatch('name', name)
- for name in names]).next()
-except StopIteration:
-logging.debug("rpm package %s not found",
- KEY_PACKAGES[pkg])
-else:
-pkgs[pkg] = {
-'version': mi['version'],
-'release': mi['release'],
-'buildtime': mi['buildtime'],
-}
+deb_pkg = key_packages[pkg]
+ver = cache[deb_pkg].installed.version
+# Debian just offers a version
+key_package_versions[pkg] = dict(version=ver,
+ release='',
+ buildtime='')
except Exception:
logging.error('', exc_info=True)
-elif _release() == OSName.DEBIAN and python_apt:
-KEY_PACKAGES = {
-'glusterfs-cli': 'glusterfs-cli',
-'librbd1': 'librbd1',
-'libvirt': 'libvirt0',
-'mom': 'mom',
-'qemu-img': 'qemu-utils',
-'qemu-kvm': 'qemu-kvm',
-'spice-server': 'libspice-server1',
-
Change in vdsm[master]: osinfo: avoid excepting *
gerrit-hooks has posted comments on this change. Change subject: osinfo: avoid excepting * .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice9171e64fb6b3879a33f5d9566e8aa2546c424f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: osinfo: use pep8 function names
Martin Polednik has uploaded a new change for review.
Change subject: osinfo: use pep8 function names
..
osinfo: use pep8 function names
Change-Id: I11e49e94e7bfbac08ba11da0ffa773925cca3ef0
Signed-off-by: Martin Polednik
---
M lib/vdsm/osinfo.py
M vdsm/caps.py
2 files changed, 18 insertions(+), 18 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/54543/1
diff --git a/lib/vdsm/osinfo.py b/lib/vdsm/osinfo.py
index 0c3765a..aef4f54 100644
--- a/lib/vdsm/osinfo.py
+++ b/lib/vdsm/osinfo.py
@@ -65,7 +65,7 @@
ENABLED = 1
-def getKdumpStatus():
+def kdump_status():
try:
# check if kdump service is running
with open('/sys/kernel/kexec_crash_loaded', 'r') as f:
@@ -89,7 +89,7 @@
@utils.memoized
-def _getos():
+def _release():
if os.path.exists('/etc/rhev-hypervisor-release'):
return OSName.RHEVH
elif glob.glob('/etc/ovirt-node-*-release'):
@@ -119,16 +119,16 @@
@utils.memoized
-def osversion():
-version = release = ''
+def version():
+version = release_name = ''
-osname = getos()
+osname = _release()
try:
if osname == OSName.RHEVH or osname == OSName.OVIRT:
-version, release = _parse_node_version('/etc/default/version')
+version, release_name = _parse_node_version('/etc/default/version')
elif osname == OSName.DEBIAN:
version = linecache.getline('/etc/debian_version', 1).strip("\n")
-release = "" # Debian just has a version entry
+release_name = "" # Debian just has a version entry
else:
if osname == OSName.POWERKVM:
release_path = '/etc/ibm_powerkvm-release'
@@ -138,21 +138,21 @@
ts = rpm.TransactionSet()
for er in ts.dbMatch('basenames', release_path):
version = er['version']
-release = er['release']
+release_name = er['release']
except:
logging.error('failed to find version/release', exc_info=True)
-return dict(release=release, version=version, name=osname)
+return dict(release=release_name, version=version, name=osname)
-def getSELinux():
+def selinux_status():
selinux = dict()
selinux['mode'] = str(utils.get_selinux_enforce_mode())
return selinux
-def getKeyPackages():
+def package_versions():
def kernelDict():
try:
ret = os.uname()
@@ -171,8 +171,8 @@
pkgs = {'kernel': kernelDict()}
-if getos() in (OSName.RHEVH, OSName.OVIRT, OSName.FEDORA, OSName.RHEL,
- OSName.POWERKVM):
+if _release() in (OSName.RHEVH, OSName.OVIRT, OSName.FEDORA, OSName.RHEL,
+ OSName.POWERKVM):
KEY_PACKAGES = {
'glusterfs-cli': ('glusterfs-cli',),
'librbd1': ('librbd1',),
@@ -206,7 +206,7 @@
except:
logging.error('', exc_info=True)
-elif getos() == OSName.DEBIAN and python_apt:
+elif _release() == OSName.DEBIAN and python_apt:
KEY_PACKAGES = {
'glusterfs-cli': 'glusterfs-cli',
'librbd1': 'librbd1',
diff --git a/vdsm/caps.py b/vdsm/caps.py
index fbb9508..f877680 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -153,9 +153,9 @@
except:
logging.debug('not reporting hooks', exc_info=True)
-caps['operatingSystem'] = osinfo.osversion()
+caps['operatingSystem'] = osinfo.version()
caps['uuid'] = host.uuid()
-caps['packages2'] = osinfo.getKeyPackages()
+caps['packages2'] = osinfo.package_versions()
caps['emulatedMachines'] = machinetype.emulated_machines(
cpuarch.effective())
try:
@@ -191,13 +191,13 @@
caps['numaNodeDistance'] = dict(numa.distances())
caps['autoNumaBalancing'] = numa.autonuma_status()
-caps['selinux'] = osinfo.getSELinux()
+caps['selinux'] = osinfo.selinux_status()
liveSnapSupported = _getLiveSnapshotSupport(cpuarch.effective())
if liveSnapSupported is not None:
caps['liveSnapshot'] = str(liveSnapSupported).lower()
caps['liveMerge'] = str(getLiveMergeSupport()).lower()
-caps['kdumpStatus'] = osinfo.getKdumpStatus()
+caps['kdumpStatus'] = osinfo.kdump_status()
caps['hostdevPassthrough'] = str(hostdev.is_supported()).lower()
caps['additionalFeatures'] = []
--
To view, visit https://gerrit.ovirt.org/54543
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11e49e94e7bfbac08ba11da0ffa773925cca3ef0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: osinfo: avoid excepting *
Martin Polednik has uploaded a new change for review.
Change subject: osinfo: avoid excepting *
..
osinfo: avoid excepting *
Using 'except:' can easily hide things such as syntax errors. This
patch changes the code to except Exceptions, leading to possibly safer
code.
Change-Id: Ice9171e64fb6b3879a33f5d9566e8aa2546c424f
Signed-off-by: Martin Polednik
---
M lib/vdsm/osinfo.py
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/54545/1
diff --git a/lib/vdsm/osinfo.py b/lib/vdsm/osinfo.py
index b0f7930..5edc8e0 100644
--- a/lib/vdsm/osinfo.py
+++ b/lib/vdsm/osinfo.py
@@ -157,14 +157,14 @@
try:
ret = os.uname()
ver, rel = ret[2].split('-', 1)
-except:
+except Exception:
logging.error('kernel release not found', exc_info=True)
ver, rel = '0', '0'
try:
t = ret[3].split()[2:]
del t[4] # Delete timezone
t = time.mktime(time.strptime(' '.join(t)))
-except:
+except Exception:
logging.error('kernel build time not found', exc_info=True)
t = '0'
return dict(version=ver, release=rel, buildtime=t)
@@ -203,7 +203,7 @@
'release': mi['release'],
'buildtime': mi['buildtime'],
}
-except:
+except Exception:
logging.error('', exc_info=True)
elif _release() == OSName.DEBIAN and python_apt:
@@ -229,7 +229,7 @@
ver = cache[deb_pkg].installed.version
# Debian just offers a version
pkgs[pkg] = dict(version=ver, release="", buildtime="")
-except:
+except Exception:
logging.error('', exc_info=True)
return pkgs
--
To view, visit https://gerrit.ovirt.org/54545
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice9171e64fb6b3879a33f5d9566e8aa2546c424f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: move os-related information to osinfo module
Martin Polednik has uploaded a new change for review.
Change subject: caps: move os-related information to osinfo module
..
caps: move os-related information to osinfo module
As a part of ongoing effort to strip caps.py the 'trashbin of VDSM
capabilities' title, this patch moves functionality related to OS
(packages, kdump support, selinux) etc. to VDSM library, module osinfo.
This is mostly raw move, cleanups within osinfo will be added further
in the patch series.
Change-Id: Iae6f1f7683e0f5acf7ed77082ac9f69203cbcf6b
Signed-off-by: Martin Polednik
---
M lib/vdsm/Makefile.am
A lib/vdsm/osinfo.py
M tests/vmTests.py
M vdsm.spec.in
M vdsm/caps.py
M vdsm/virt/vm.py
6 files changed, 249 insertions(+), 220 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/54542/1
diff --git a/lib/vdsm/Makefile.am b/lib/vdsm/Makefile.am
index dd86ba3..72c81ad 100644
--- a/lib/vdsm/Makefile.am
+++ b/lib/vdsm/Makefile.am
@@ -48,6 +48,7 @@
machinetype.py \
netconfpersistence.py \
numa.py \
+ osinfo.py \
panic.py \
password.py \
ppc64HardwareInfo.py \
diff --git a/lib/vdsm/osinfo.py b/lib/vdsm/osinfo.py
new file mode 100644
index 000..0c3765a
--- /dev/null
+++ b/lib/vdsm/osinfo.py
@@ -0,0 +1,235 @@
+#
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+from __future__ import absolute_import
+
+import itertools
+import glob
+import linecache
+import logging
+import time
+import os
+
+from vdsm import utils
+
+# For debian systems we can use python-apt if available
+try:
+import apt
+python_apt = True
+except ImportError:
+python_apt = False
+
+# For systems without rpm support
+try:
+import rpm
+except ImportError:
+pass
+
+try:
+from gluster.api import GLUSTER_RPM_PACKAGES
+from gluster.api import GLUSTER_DEB_PACKAGES
+glusterEnabled = True
+except ImportError:
+glusterEnabled = False
+
+
+class OSName:
+UNKNOWN = 'unknown'
+OVIRT = 'oVirt Node'
+RHEL = 'RHEL'
+FEDORA = 'Fedora'
+RHEVH = 'RHEV Hypervisor'
+DEBIAN = 'Debian'
+POWERKVM = 'PowerKVM'
+
+
+class KdumpStatus(object):
+UNKNOWN = -1
+DISABLED = 0
+ENABLED = 1
+
+
+def getKdumpStatus():
+try:
+# check if kdump service is running
+with open('/sys/kernel/kexec_crash_loaded', 'r') as f:
+kdumpStatus = int(f.read().strip('\n'))
+
+if kdumpStatus == KdumpStatus.ENABLED:
+# check if fence_kdump is configured
+kdumpStatus = KdumpStatus.DISABLED
+with open('/etc/kdump.conf', 'r') as f:
+for line in f:
+if line.startswith('fence_kdump_nodes'):
+kdumpStatus = KdumpStatus.ENABLED
+break
+except (IOError, OSError, ValueError):
+kdumpStatus = KdumpStatus.UNKNOWN
+logging.debug(
+'Error detecting fence_kdump configuration status',
+exc_info=True,
+)
+return kdumpStatus
+
+
+@utils.memoized
+def _getos():
+if os.path.exists('/etc/rhev-hypervisor-release'):
+return OSName.RHEVH
+elif glob.glob('/etc/ovirt-node-*-release'):
+return OSName.OVIRT
+elif os.path.exists('/etc/fedora-release'):
+return OSName.FEDORA
+elif os.path.exists('/etc/redhat-release'):
+return OSName.RHEL
+elif os.path.exists('/etc/debian_version'):
+return OSName.DEBIAN
+elif os.path.exists('/etc/ibm_powerkvm-release'):
+return OSName.POWERKVM
+else:
+return OSName.UNKNOWN
+
+
+def _parse_node_version(path):
+data = {}
+with open(path) as f:
+for line in f:
+try:
+key, value = [kv.strip() for kv in line.split('=', 1)]
+except ValueError:
+continue
+
+return data.get('VERSION', ''), data.get('RELEASE', '')
+
+
+@utils.memoized
+def osversion():
+version = release = ''
+
+osname = getos()
+try:
+if osname == OSName.RHEVH or osname == OSName.OVIRT:
+version, release = _parse_node_version('/etc/default/version')
+elif osnam
Change in vdsm[master]: caps: use storage's getDefaultInitiatorName
gerrit-hooks has posted comments on this change. Change subject: caps: use storage's getDefaultInitiatorName .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54510 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If49286165b7855b96dd88221de06579485d576f4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: specialize and modernize _parseKeyVal
gerrit-hooks has posted comments on this change. Change subject: caps: specialize and modernize _parseKeyVal .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54541 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04b6f813c01fd8745510234ddb9bbb69f4bc67f4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add copyright info
Freddy Rolland has posted comments on this change. Change subject: storage: add copyright info .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/54508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f69d196a7d16341cd70568db69bba307ff31a41 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add copyright info
gerrit-hooks has posted comments on this change. Change subject: storage: add copyright info .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f69d196a7d16341cd70568db69bba307ff31a41 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add copyright info
Freddy Rolland has posted comments on this change. Change subject: storage: add copyright info .. Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/54508/1/vdsm/storage/glusterSD.py File vdsm/storage/glusterSD.py: Line 1: # Line 2: # Copyright 2016 Red Hat, Inc. > Lets add the year when this code was merged (-2016). Done Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or https://gerrit.ovirt.org/#/c/54508/1/vdsm/storage/glusterVolume.py File vdsm/storage/glusterVolume.py: Line 1: # Line 2: # Copyright 2016 Red Hat, Inc. > Same add the merge year Done Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or https://gerrit.ovirt.org/#/c/54508/1/vdsm/storage/iscsiadm.py File vdsm/storage/iscsiadm.py: Line 1: # Line 2: # Copyright 2016 Red Hat, Inc. > Same, merge year Done Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or https://gerrit.ovirt.org/#/c/54508/1/vdsm/storage/sync.py File vdsm/storage/sync.py: Line 1: # Line 2: # Copyright 2016 Red Hat, Inc. > Same, merge year Done Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or -- To view, visit https://gerrit.ovirt.org/54508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f69d196a7d16341cd70568db69bba307ff31a41 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: imagetickets: add tests
gerrit-hooks has posted comments on this change. Change subject: imagetickets: add tests .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2728851a91529ec35501f423d9a798af961fb82a Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: machinetype: pep8tify the module
Dan Kenigsberg has submitted this change and it was merged. Change subject: machinetype: pep8tify the module .. machinetype: pep8tify the module Change-Id: I5a641733f0e8e66c4be3b71872ec9967363914e2 Signed-off-by: Martin Polednik Reviewed-on: https://gerrit.ovirt.org/54299 Reviewed-by: Francesco Romani Continuous-Integration: Jenkins CI --- M lib/vdsm/machinetype.py 1 file changed, 13 insertions(+), 13 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/54299 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a641733f0e8e66c4be3b71872ec9967363914e2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: machinetype: pep8tify the module
gerrit-hooks has posted comments on this change. Change subject: machinetype: pep8tify the module .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/54299 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a641733f0e8e66c4be3b71872ec9967363914e2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: machinetype: update naming
gerrit-hooks has posted comments on this change. Change subject: machinetype: update naming .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/54298 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ce7596a1dbf0a565ba3665eda6e9b3a6fc3d56d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add copyright info
Nir Soffer has posted comments on this change. Change subject: storage: add copyright info .. Patch Set 1: (4 comments) Thanks for this cleanup! Lets get the copyright years right. https://gerrit.ovirt.org/#/c/54508/1/vdsm/storage/glusterSD.py File vdsm/storage/glusterSD.py: Line 1: # Line 2: # Copyright 2016 Red Hat, Inc. Lets add the year when this code was merged (-2016). git log -p will help you to find it. Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or https://gerrit.ovirt.org/#/c/54508/1/vdsm/storage/glusterVolume.py File vdsm/storage/glusterVolume.py: Line 1: # Line 2: # Copyright 2016 Red Hat, Inc. Same add the merge year Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or https://gerrit.ovirt.org/#/c/54508/1/vdsm/storage/iscsiadm.py File vdsm/storage/iscsiadm.py: Line 1: # Line 2: # Copyright 2016 Red Hat, Inc. Same, merge year Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or https://gerrit.ovirt.org/#/c/54508/1/vdsm/storage/sync.py File vdsm/storage/sync.py: Line 1: # Line 2: # Copyright 2016 Red Hat, Inc. Same, merge year Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or -- To view, visit https://gerrit.ovirt.org/54508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f69d196a7d16341cd70568db69bba307ff31a41 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: machinetype: update naming
Dan Kenigsberg has submitted this change and it was merged. Change subject: machinetype: update naming .. machinetype: update naming The old names of machinetype public functions were outdated, non-pep8-compilant. New names work nice with module name and are pep8 compilant! Change-Id: I5ce7596a1dbf0a565ba3665eda6e9b3a6fc3d56d Signed-off-by: Martin Polednik Reviewed-on: https://gerrit.ovirt.org/54298 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg Reviewed-by: Francesco Romani --- M lib/vdsm/machinetype.py M tests/capsTests.py M vdsm/caps.py 3 files changed, 18 insertions(+), 18 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, approved Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/54298 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ce7596a1dbf0a565ba3665eda6e9b3a6fc3d56d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: imagetickets: add tests
Nir Soffer has posted comments on this change. Change subject: imagetickets: add tests .. Patch Set 12: Amit, can you rebase and verify again? There is a path conflict, probably because of changes in the imagetickets in master. -- To view, visit https://gerrit.ovirt.org/52900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2728851a91529ec35501f423d9a798af961fb82a Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: imagetickets: add tests
Nir Soffer has posted comments on this change. Change subject: imagetickets: add tests .. Patch Set 12: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/52900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2728851a91529ec35501f423d9a798af961fb82a Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: remove unused sendKeys verb
Sandro Bonazzola has posted comments on this change. Change subject: vm: remove unused sendKeys verb .. Patch Set 1: Code-Review+1 AFAIK neither host-deploy nor hosted engine are using that verb, so ok for removing it on my side. -- To view, visit https://gerrit.ovirt.org/54514 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I709610a43cdf58464147ed6c7167d93558e29451 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: imagetickets: add tests
Amit Aviram has posted comments on this change. Change subject: imagetickets: add tests .. Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/52900/12/vdsm/storage/imagetickets.py File vdsm/storage/imagetickets.py: > Is this change related to the patch ? Yes, it is essential for the tests that uhttp will be used in that-The code we had before failed when ovirt_image_daemon was not installed. Thanks for the review! Line 1: # Line 2: # Copyright 2009-2012 Red Hat, Inc. Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify -- To view, visit https://gerrit.ovirt.org/52900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2728851a91529ec35501f423d9a798af961fb82a Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: remove not used monitorCommand
Francesco Romani has posted comments on this change. Change subject: vm: remove not used monitorCommand .. Patch Set 1: Code-Review+1 Verified-1 I like this (+1) but git grep in Engine reveals some apparent users. Cautionary -V until we find out the full story. -- To view, visit https://gerrit.ovirt.org/54513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab244c568d10f1920599da418168e5d381f4b8a5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: remove unused sendKeys verb
Francesco Romani has posted comments on this change. Change subject: vm: remove unused sendKeys verb .. Patch Set 1: Code-Review+1 Verified+1 I think this is OK. Adding more reviewers just in case I missed something. according to git grep, Engine is not using this at all: First, rewinding head to replay your work on top of it... Fast-forwarded ovirt-engine-3.6 to origin/ovirt-engine-3.6. 1016 12:30:01 fromani@musashi ~/Projects/upstream/ovirt-engine $ git grep -i sendKeys -- To view, visit https://gerrit.ovirt.org/54514 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I709610a43cdf58464147ed6c7167d93558e29451 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: imagetickets: add tests
Freddy Rolland has posted comments on this change. Change subject: imagetickets: add tests .. Patch Set 12: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/52900/12/vdsm/storage/imagetickets.py File vdsm/storage/imagetickets.py: Is this change related to the patch ? Line 1: # Line 2: # Copyright 2009-2012 Red Hat, Inc. Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify -- To view, visit https://gerrit.ovirt.org/52900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2728851a91529ec35501f423d9a798af961fb82a Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bridge: data verification
Piotr Kliczewski has posted comments on this change. Change subject: bridge: data verification .. Patch Set 6: Verified+1 Verified by host deploying vdsm and running bunch of verbs like creating, suspending vm and creating new disk. -- To view, visit https://gerrit.ovirt.org/53919 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id24a5e078fa92e4129d37a47593c7a167e78712e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bridge: usage of yaml schema
Piotr Kliczewski has posted comments on this change. Change subject: bridge: usage of yaml schema .. Patch Set 1: Verified+1 Verified by host deploying vdsm and running bunch of verbs like creating, suspending vm and creating new disk. -- To view, visit https://gerrit.ovirt.org/54528 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia76d8245568514d20e446237bd667d87fb4ad3e8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: schema converter
Piotr Kliczewski has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 18: Verified+1 Verified by host deploying vdsm and running bunch of verbs like creating, suspending vm and creating new disk. -- To view, visit https://gerrit.ovirt.org/52864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: schema converter
gerrit-hooks has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/52864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bridge: usage of yaml schema
gerrit-hooks has posted comments on this change. Change subject: bridge: usage of yaml schema .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54528 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia76d8245568514d20e446237bd667d87fb4ad3e8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bridge: obtain method
gerrit-hooks has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53472 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b6cb53d8e42335510e34dfe372c1c21b80ac219 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: provide more info when method not found
gerrit-hooks has posted comments on this change. Change subject: jsonrpc: provide more info when method not found .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53714 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib29240f002ab7c11744d164cf4e0ea5f47924929 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
