Change in vdsm[master]: virt: common handling of exceptions

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: common handling of exceptions
..


Patch Set 9:

(3 comments)

https://gerrit.ovirt.org/#/c/54664/9/tests/virt_api_test.py
File tests/virt_api_test.py:

Line 43: def test_success_with_args(self):
Line 44: status = { 'vmName': 'foo', 'vmId': 'bar' }
Line 45: self.assertRaises(TypeError,
Line 46:   self.vm.succeed_with_args,
Line 47:   status)
This is a strange success
Line 48: 
Line 49: def test_success_with_kwargs(self):
Line 50: port = 0
Line 51: res = self.vm.succeed_with_kwargs(migrationPort=port)


Line 70: self.assertEquals(res, expected)
Line 71: 
Line 72: def test_fail_with_plain_exception(self):
Line 73: res = self.vm.fail(ValueError)
Line 74: self.assertTrue(response.is_error(res))
It seems that we control both the error handler and the code raising the 
exception, so maybe we can do:

e = ValueError()
expected = exception.GeneralException(str(e)).response()

To make it less fragile, we can pass an instance of the error, and implement 
fail like this:

def fail(self, e):
raise e

Or if you think this is too fragile, at least check the error code of the 
response? This seems to be the contract of this wrapper, returning the response 
of vdsm exceptions, or general exception with the details of the original error.
Line 75: 
Line 76: 
Line 77: class FakeVM(object):
Line 78: 


Line 89: return ret
Line 90: 
Line 91: @api.method
Line 92: def succeed_with_args(self, *args):
Line 93: return args
We can use single method for these tests:

def succeed_with_args_kw(self, *args, **kw):
return {"args": args, "kwargs": kwargs}

Or return always a dict from both:

return {"args": args}

And in the following method:

return {"kwargs": kwargs}
Line 94: 
Line 95: @api.method
Line 96: def succeed_with_kwargs(self, **kwargs):


-- 
To view, visit https://gerrit.ovirt.org/54664
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic186dc8fa062d8b3789c6057bba68fbbc23f311b
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingNetworkInterfaceInfo() out of Vm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingNetworkInterfaceInfo() out of Vm
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53621
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d627a50c1ed52c584a834fb2f9066ac1ab6ac68
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingVmDevicesInfo() content out of Vm

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingVmDevicesInfo() content out of Vm
..


Patch Set 11: Verified+1

Verified by running a VM from Engine, migrating it to another host and back, 
and stopping it.

-- 
To view, visit https://gerrit.ovirt.org/53679
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81a0da783bc40f0f08dfdac2bbb955bc55d81b0e
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: containers: make sure directory are ready

[automation]

gerrit-hooks has posted comments on this change.

Change subject: containers: make sure directory are ready
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54177
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48daf34026ece93032f9b336893b938fbab95f25
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: WIP: vm: skip domDependentInit for containers

[automation]

gerrit-hooks has posted comments on this change.

Change subject: WIP: vm: skip domDependentInit for containers
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54179
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7360d75c4adcab655c2cd215c6b9d91f9d92a646
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: expose parameters needed to support hotunplug

[mpolednik]

Martin Polednik has uploaded a new change for review.

Change subject: hostdev: expose parameters needed to support hotunplug
..

hostdev: expose parameters needed to support hotunplug

Change-Id: I09e879051b1d47e48e9ae73c1f7d9bfbea8f1237
Signed-off-by: Martin Polednik 
---
M vdsm/virt/vmdevices/hostdevice.py
1 file changed, 30 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/54939/1

diff --git a/vdsm/virt/vmdevices/hostdevice.py 
b/vdsm/virt/vmdevices/hostdevice.py
index 37aff3d..3a5a719 100644
--- a/vdsm/virt/vmdevices/hostdevice.py
+++ b/vdsm/virt/vmdevices/hostdevice.py
@@ -18,6 +18,8 @@
 # Refer to the README and COPYING files for full details of the license
 #
 
+import xml.etree.ElementTree as ET
+
 from vdsm import utils
 from vdsm.hostdev import get_device_params, detach_detachable, \
 CAPABILITY_TO_XML_ATTR
@@ -26,13 +28,15 @@
 
 
 class HostDevice(core.Base):
-__slots__ = ('address', 'hostAddress', 'bootOrder', '_deviceParams')
+__slots__ = ('address', 'hostAddress', 'bootOrder', '_deviceParams',
+ 'name')
 
 def __init__(self, conf, log, **kwargs):
 super(HostDevice, self).__init__(conf, log, **kwargs)
 
 self._deviceParams = get_device_params(self.device)
 self.hostAddress = self._deviceParams.get('address')
+self.name = self.device
 
 def detach(self):
 """
@@ -41,6 +45,31 @@
 """
 self._deviceParams = detach_detachable(self.device)
 
+@property
+def _xpath(self):
+"""
+Returns xpath to the device in libvirt dom xml
+The path is relative to the root element
+"""
+def _padding(key):
+if CAPABILITY_TO_XML_ATTR[
+self._deviceParams['capability']] == 'pci':
+if key == 'domain':
+return {'base': '0x', 'padding': '04'}
+if key == 'function':
+return {'base': '0x', 'padding': ''}
+return {'base': '0x', 'padding': '02'}
+return {'base': '', 'padding': ''}
+
+return ('./devices/hostdev/source/address{}'.format(
+''.join(['[@{key}=\'{base}{value:{padding}}\']'.format(
+key=key, value=int(value), **_padding(key)) for
+key, value in self.hostAddress.items()])))
+
+def is_attached_to(self, xml_string):
+dom = ET.fromstring(xml_string)
+return bool(dom.findall(self._xpath))
+
 def getXML(self):
 """
 Create domxml for a host device.


-- 
To view, visit https://gerrit.ovirt.org/54939
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I09e879051b1d47e48e9ae73c1f7d9bfbea8f1237
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: expose hostdevReattach maintenance verb

[mpolednik]

Martin Polednik has uploaded a new change for review.

Change subject: hostdev: expose hostdevReattach maintenance verb
..

hostdev: expose hostdevReattach maintenance verb

If device detachment fails at some point, VDSM does nothing. That is
because detached device does not break anything - it just lacks the
correct driver and is not usable by the host. Such device wouldn't
normally be used by host at all, but we should provide option to
reattach it back without using virsh.

That way, users are able to reattach devices that they need to use
after them being detached.

Change-Id: Iebfb6a4e3854de8ea412417832a57fb896b78d1a
Signed-off-by: Martin Polednik 
---
M client/vdsClient.py
M lib/api/vdsmapi-schema.json
M lib/vdsm/define.py
M lib/vdsm/rpc/Bridge.py
M lib/vdsm/rpc/bindingxmlrpc.py
M vdsm/API.py
6 files changed, 34 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/54891/1

diff --git a/client/vdsClient.py b/client/vdsClient.py
index d86b713..638b5a9 100755
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -559,6 +559,10 @@
 return self.ExecAndExit(self.s.hostdevChangeNumvfs(device_name,
numvfs))
 
+def do_hostdevReattach(self, args):
+device_name = args[0]
+return self.ExecAndExit(self.s.hostdevReattach(device_name))
+
 def desktopLogin(self, args):
 vmId, domain, user, password = tuple(args[:4])
 if len(args) > 4:
@@ -2250,6 +2254,9 @@
  'Change number of virtual functions for '
  'given physical function.'
  )),
+'hostdevReattach': (serv.do_hostdevReattach,
+('

Change in vdsm[master]: hostdev: decode XML string when parsing devices

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hostdev: decode XML string when parsing devices
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/54802/1/lib/vdsm/hostdev.py
File lib/vdsm/hostdev.py:

Line 118:   'usb_device': _parse_usb_address}
Line 119: 
Line 120: params = {}
Line 121: 
Line 122: devXML = etree.fromstring(device_xml.decode('ascii', 
errors='ignore'))
> See the other comment - it's most likely case of un-printable characters. T
I did not understand your comment, but hey - 'replace' give the annoying 
unicode replace char. Is that what worries you?

>>> 'ÿ'.decode('ascii', 
>>> 'ignore')
u''
>>> 'ÿ'.decode('ascii', 
>>> 'replace')
u'\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd'
Line 123: name = devXML.find('name').text
Line 124: if name != 'computer':
Line 125: params['parent'] = devXML.find('parent').text
Line 126: 


-- 
To view, visit https://gerrit.ovirt.org/54802
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf9b9699790c83bb82a88a700c63d05604588d02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: Enable lazy setting of incoming/outgoing limits

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: Enable lazy setting of incoming/outgoing limits
..


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53305
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79ab97f15788e4024c94d051e4aade713d760acf
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: add support for hotplug

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: add support for hotplug
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2465360664ef9b659c52dc610a95d2c2f1555c54
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridge: usage of yaml schema

[alitke]

Adam Litke has posted comments on this change.

Change subject: bridge: usage of yaml schema
..


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/54528/5/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:

Line 70: class JsonRpcInvalidParamsError(JsonRpcError):
Line 71: def __init__(self, msg=None):
Line 72: if not msg:
Line 73: msg = "Invalid method parameter(s)."
Line 74: JsonRpcError.__init__(self, -32602, msg)
This is very unhelpful.  We are not told which parameter is invalid or what the 
offending value is.  Why not just fix the code that raises this exception to 
always provide a meaningful message?
Line 75: 
Line 76: 
Line 77: class JsonRpcInternalError(JsonRpcError):
Line 78: def __init__(self, msg=None):


https://gerrit.ovirt.org/#/c/54528/5/tests/bridgeTests.py
File tests/bridgeTests.py:

Line 93
Line 94
Line 95
Line 96
Line 97
This is style fixing only.  I support doing this cleanup but it should be 
separated from changes that affect logic.  Applies to this whole patch, not 
just this file.


-- 
To view, visit https://gerrit.ovirt.org/54528
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia76d8245568514d20e446237bd667d87fb4ad3e8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [1]

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [1]
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6d18b7d3e90902d29a2fdef246972a9fb1c705f1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [1]

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [1]
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/54821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6d18b7d3e90902d29a2fdef246972a9fb1c705f1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [1]

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [1]
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/54820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If008e061bdef9851ff9e71942d05bc5bd6861c10
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingGraphicsDeviceInfo() out of Vm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingGraphicsDeviceInfo() out of Vm
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53619
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1aff4f57905d0f2d1ee60a2ed963c843feee4540
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: HACK: hook: add imagerepo feed containers

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: HACK: hook: add imagerepo feed containers
..

HACK: hook: add imagerepo feed containers

***HACK***

until we get proper support to upload external images
into a data domain, we need some help to fetch the
appc/container images.

Introduce a hook to perform this task.

Change-Id: I94ae3b82150981c76a6079d5741aeca8faa1dd33
Signed-off-by: Francesco Romani 
---
M configure.ac
M vdsm.spec.in
M vdsm_hooks/Makefile.am
A vdsm_hooks/imagerepo/Makefile.am
A vdsm_hooks/imagerepo/README
A vdsm_hooks/imagerepo/before_vm_start.py
6 files changed, 250 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/54873/1

diff --git a/configure.ac b/configure.ac
index 0e108d1..a37e244 100644
--- a/configure.ac
+++ b/configure.ac
@@ -397,6 +397,7 @@
vdsm_hooks/hostusb/Makefile
vdsm_hooks/httpsisoboot/Makefile
vdsm_hooks/hugepages/Makefile
+   vdsm_hooks/imagerepo/Makefile
vdsm_hooks/ipv6/Makefile
vdsm_hooks/isolatedprivatevlan/Makefile
vdsm_hooks/macbind/Makefile
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 2321787..be1cc9e 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -495,6 +495,14 @@
 the need to import the ISO into an ISO storage domain.
 It doesn't support plain http.
 
+%package hook-imagerepo
+Summary:Attach locally-stored container images
+BuildArch:  noarch
+
+%description hook-imagerepo
+Temporary hack hook to attach images to containers run through Vdsm,
+until Engine gains proper support. Images will be stored in local fs.
+
 %package hook-hugepages
 Summary:Huge pages enable user to handle VM with 2048KB page files.
 
@@ -1354,6 +1362,10 @@
 %{_libexecdir}/%{vdsm_name}/hooks/before_device_migrate_destination/50_vmfex
 %{_libexecdir}/%{vdsm_name}/hooks/before_nic_hotplug/50_vmfex
 
+%files hook-imagerepo
+%defattr(-, root, root, -)
+%{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_imagerepo
+
 %if 0%{?with_hooks}
 %files hook-allocate_net
 %defattr(-, root, root, -)
diff --git a/vdsm_hooks/Makefile.am b/vdsm_hooks/Makefile.am
index d23fb1c..e09064c 100644
--- a/vdsm_hooks/Makefile.am
+++ b/vdsm_hooks/Makefile.am
@@ -21,6 +21,7 @@
 SUBDIRS = \
ethtool_options \
faqemu \
+   imagerepo \
ipv6 \
macspoof \
openstacknet \
diff --git a/vdsm_hooks/imagerepo/Makefile.am b/vdsm_hooks/imagerepo/Makefile.am
new file mode 100644
index 000..55f18d7
--- /dev/null
+++ b/vdsm_hooks/imagerepo/Makefile.am
@@ -0,0 +1,30 @@
+#
+# Copyright 2015 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  
USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+
+EXTRA_DIST = \
+   before_vm_start.py
+
+install-data-local:
+   $(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/before_vm_start
+   $(INSTALL_SCRIPT) $(srcdir)/before_vm_start.py \
+   $(DESTDIR)$(vdsmhooksdir)/before_vm_start/50_imagerepo
+
+uninstall-local:
+   $(RM) $(DESTDIR)$(vdsmhooksdir)/before_vm_start/50_imagerepo
diff --git a/vdsm_hooks/imagerepo/README b/vdsm_hooks/imagerepo/README
new file mode 100644
index 000..e69de29
--- /dev/null
+++ b/vdsm_hooks/imagerepo/README
diff --git a/vdsm_hooks/imagerepo/before_vm_start.py 
b/vdsm_hooks/imagerepo/before_vm_start.py
new file mode 100755
index 000..bcf28bf
--- /dev/null
+++ b/vdsm_hooks/imagerepo/before_vm_start.py
@@ -0,0 +1,206 @@
+#!/usr/bin/python
+
+import os
+import os.path
+import sys
+import traceback
+from xml.dom import minidom
+
+import hooking
+
+
+DEFAULT_REPO = '/srv/convirt/images'
+
+
+'''
+imagerepo hook:
+TODO
+syntax:
+imagerepo=/some/local/path
+'''
+
+
+def pretty_print(data):
+return '\n'.join(
+[
+line
+for line
+in data.toprettyxml(
+indent=' '*2,
+encoding='UTF-8',
+).split('\n')
+if line.strip()
+]
+)
+
+
+def increase_devices_boot_order(devices):
+xmldevices = [
+e for e in devices.childNodes
+if e.nodeType == e.ELEMENT_NODE
+]
+for d in xmldevices:
+boots = d.getElementsByTagName('boot')
+for boot in 

Change in vdsm[master]: hostdev: decode XML string when parsing devices

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: decode XML string when parsing devices
..


Patch Set 1:

If the system's already complaining, there is even little reason to add our 
whine on top of that. :)

-- 
To view, visit https://gerrit.ovirt.org/54802
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf9b9699790c83bb82a88a700c63d05604588d02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fileUtils: Remove open_ex

[alitke]

Adam Litke has posted comments on this change.

Change subject: fileUtils: Remove open_ex
..


Patch Set 3: Code-Review+1

Looks good.

-- 
To view, visit https://gerrit.ovirt.org/54679
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5a26cdd857b845b7bbd58d302e231bb7d6c33e5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: set correct permissions for hwrng device

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: virt: set correct permissions for hwrng device
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54806
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id958a291e5a15813309928ba3d8c67828273b6c6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: api: move rollback to network/api.py level

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: api: move rollback to network/api.py level
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54751
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9b45d8e11a1ae7af5bdb650dd617f50ee0ffaa1
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

[dcaro]

David Caro has posted comments on this change.

Change subject: tests: Run unit tests using travis-ci and docker
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/54856/2/.travis.yml
File .travis.yml:

Line 7:   - docker --version
Line 8:   - docker pull edwardhaas/ovirt-vdsm-dev
Line 9: 
Line 10: script:
Line 11:   - docker run  edwardhaas/ovirt-vdsm-dev
> Yes, you are right.
You can use the standard ci scripts already in place, that should run 
everything you need, source controlled, and already running on current ci. Not 
sure on how you expect to handle dependencies and such though


-- 
To view, visit https://gerrit.ovirt.org/54856
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cd647acb4c740f890e9b602783915439317880
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: conf: proper locking in status()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: conf: proper locking in status()
..


Patch Set 1:

* #1318550::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1318550::OK, public bug
* Check Product::#1318550::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54906
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I397562bb94c8b696a0b34484907e7d489a800878
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net tests: TestIPv6Addresses should run as root

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: TestIPv6Addresses should run as root
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54950
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8c681e3d0475bd4a76e5b371db08069aa1e518d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: guest-agent: Fix API version negotiation

[vfeenstr]

Vinzenz Feenstra has posted comments on this change.

Change subject: guest-agent: Fix API version negotiation
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/54871/1/lib/vdsm/virt/guestagent.py
File lib/vdsm/virt/guestagent.py:

Line 201: if commonVersion != self.effectiveApiVersion:
Line 202: # Only update if the value changed
Line 203: self.log.info("Guest API version changed from %d to %d",
Line 204:   self.effectiveApiVersion, commonVersion)
Line 205: self.effectiveApiVersion = commonVersion
> do we have tests for this flow? Worth adding, maybe for a future patch
Basically the whole GA is untested right now, so no we don't but that's 
something I want to work on quite soon
Line 206: if commonVersion != _IMPLICIT_API_VERSION_ZERO:
Line 207: # Only notify the guest agent if the API was not 
disabled
Line 208: self._forward('api-version', {'apiVersion': 
commonVersion})
Line 209: 


-- 
To view, visit https://gerrit.ovirt.org/54871
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5dd8a36395615d4b908a0c88a6bbfee3cab1952
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: json: removal of old schemas

[automation]

gerrit-hooks has posted comments on this change.

Change subject: json: removal of old schemas
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d8a9d0837408ab727ecdeaa37d49efbca5bebdc
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Run unit tests using travis-ci and docker
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54856
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cd647acb4c740f890e9b602783915439317880
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: contrib: schema converter

[automation]

gerrit-hooks has posted comments on this change.

Change subject: contrib: schema converter
..


Patch Set 23:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: common handling of exceptions

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: common handling of exceptions
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/54664/7/lib/vdsm/virt/api.py
File lib/vdsm/virt/api.py:

Line 45: 
Line 46: _log.debug("FINISH %s response=%s", func.__name__, ret)
Line 47: 
Line 48: if isinstance(ret, dict):
Line 49: return response.success(**ret)
> maybe add a debug log to document that the return value is discarded?
I just noticed this, we should not do this.

We should have a clear and strict api:
- if there is not return value, return None (e.g. no return in python)
- If there is a return value it must be a dict

The code should be:

if ret is None:
return response.success()
else:
return response.success(**ret)

Hopefully this works with current vdsm verbs.
Line 50: return response.success()
Line 51: 


-- 
To view, visit https://gerrit.ovirt.org/54664
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic186dc8fa062d8b3789c6057bba68fbbc23f311b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Remove unused code

[alitke]

Adam Litke has posted comments on this change.

Change subject: tests: Remove unused code
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54677
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f9532f049910b5d4121d9b15319cc9bca061f57
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: set correct permissions for hwrng device

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: set correct permissions for hwrng device
..


Patch Set 1: Code-Review+1

(3 comments)

looks OK, please check inline comments. partial ACK.

https://gerrit.ovirt.org/#/c/54806/1/vdsm/supervdsm_api/udev.py
File vdsm/supervdsm_api/udev.py:

Line 76: try:
   : os.remove(rule_file)
   : except OSError as e:
   : if e.errno == errno.ENOENT:
   : return
   : else:
   : raise
don't we have an utility to do this?
maybe rmFile?


https://gerrit.ovirt.org/#/c/54806/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1268: self.conf['vmId']
nit: self.id


https://gerrit.ovirt.org/#/c/54806/1/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:

Line 244: self.conf['vmId']
nit: self.id


-- 
To view, visit https://gerrit.ovirt.org/54806
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id958a291e5a15813309928ba3d8c67828273b6c6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: dsaversion: Remove 3.4 support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: dsaversion: Remove 3.4 support
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54875
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7332b7c11bee92868a51c972bfad2c4f1648df91
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingGraphicsDeviceInfo() out of Vm

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingGraphicsDeviceInfo() out of Vm
..


Patch Set 12: Verified+1

Verified by running a VM from Engine, migrating it to another host and back, 
and stopping it.

-- 
To view, visit https://gerrit.ovirt.org/53619
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1aff4f57905d0f2d1ee60a2ed963c843feee4540
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: virt: migration: initialize SourceThread._destServer on __in...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: migration: initialize SourceThread._destServer on __init__
..


Patch Set 1:

* #1299886::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1299886::OK, public bug
* Check Product::#1299886::OK, Correct classification oVirt
* Check TM::#1299886::ERROR, wrong target milestone for stable branch, 
ovirt-4.0.0 should match ^.*3.6.*
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/54949
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie773d7eadbacd1eac6e0929d5f264a5c2d4f6a57
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: guest-agent: Fix API version negotiation

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: guest-agent: Fix API version negotiation
..


guest-agent: Fix API version negotiation

The guest agent negotation is currently broken due to storing the wrong value
as effectiveAPIVersion.
Currently the reported value by the guest agent is stored, which actually
should not be stored, but the commonVersion value.

Change-Id: Id5dd8a36395615d4b908a0c88a6bbfee3cab1952
Bug-Url: https://bugzilla.redhat.com/1318657
Signed-off-by: Vinzenz Feenstra 
Reviewed-on: https://gerrit.ovirt.org/54871
Continuous-Integration: Jenkins CI
Reviewed-by: Milan Zamazal 
Reviewed-by: Martin Polednik 
Reviewed-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/54896
---
M vdsm/virt/guestagent.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Vinzenz Feenstra: Verified
  Francesco Romani: Looks good to me, approved
  Milan Zamazal: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/54896
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id5dd8a36395615d4b908a0c88a6bbfee3cab1952
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: common handling of exceptions

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: common handling of exceptions
..


Patch Set 8:

(3 comments)

https://gerrit.ovirt.org/#/c/54664/8/tests/api_response_test.py
File tests/api_response_test.py:

Line 24: 
Line 25: from testlib import VdsmTestCase as TestCaseBase
Line 26: 
Line 27: 
Line 28: class ResponseTests(TestCaseBase):
Can you name the class TestResponse?

This name is automatically detected by py.test, even if you don't subclass from 
VdsmTestCase.

We can do these changes later, but when adding new tests I think we should use 
this style to save work later.
Line 29: 
Line 30: def setUp(self):
Line 31: self.vm = FakeVM()
Line 32: 


Line 36: 
Line 37: def test_success_with_return_dict(self):
Line 38: vmList = ['foobar']
Line 39: res = self.vm.succeed_with_return({'vmList': vmList})
Line 40: self.assertEquals(response.is_error(res), False)
This is much easier to parse like this.
Line 41: self.assertEquals(res['vmList'], vmList)
Line 42: 
Line 43: def test_success_with_wrong_return(self):
Line 44: vmList = ['foobar']


Line 72: def succeed(self):
Line 73: pass
Line 74: 
Line 75: @api.method
Line 76: def succeed_with_return(self, ret):
What about testing kwargs?

Not sure that we need them, I think the bridge always call with positional 
args, but I did not test this.


-- 
To view, visit https://gerrit.ovirt.org/54664
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic186dc8fa062d8b3789c6057bba68fbbc23f311b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingDriveInfo() out of Vm

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..


Patch Set 11: Verified+1

Verified by running a VM from Engine, migrating it to another host and back, 
and stopping it.

-- 
To view, visit https://gerrit.ovirt.org/53677
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6b372f86b82da7422727f3d084b9afc5505a289
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: add support for hotunplug

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: add support for hotunplug
..


Patch Set 3: Code-Review+1

partial ACK, deeper review later

-- 
To view, visit https://gerrit.ovirt.org/42747
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If36f7da8f018615b76a1a8779ff15b890a823db8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm
..


Patch Set 12: Code-Review+1

(1 comment)

My +1 is only valid if I get promise of the test being improved in future.

https://gerrit.ovirt.org/#/c/53620/12/tests/deviceTests.py
File tests/deviceTests.py:

Line 550: vmdevices.hostdevice.HostDevice.update_device_info(testvm,
:
device_conf)
Idea for future patch: to really test the function, following flow should be 
executed:

1) define (fake) libvirt XML where the address is not present (source address 
needs to be present, generic device address does not) - this is what VDSM sends 
to libvirt
2) insert the address into XML (= play libvirt's role)
3) verify that the address is present in device object after updating the 
device info

to really test that the device detection works, XML must include multiple 
devices and test must verify that the addresses assigned to them are correct.


-- 
To view, visit https://gerrit.ovirt.org/53620
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I789d7d2349fc24b48e52260de98fb3d66b168bf7
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: conf: proper locking in migration path

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: conf: proper locking in migration path
..


Patch Set 1:

* #1318550::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1318550::OK, public bug
* Check Product::#1318550::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54905
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic943e4af2f444f8ffe167175e40a9a2f28afc344
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: guest-agent: Fix API version negotiation

[fromani]

Francesco Romani has posted comments on this change.

Change subject: guest-agent: Fix API version negotiation
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54871
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5dd8a36395615d4b908a0c88a6bbfee3cab1952
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingUnknownDeviceInfo() out of Vm

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingUnknownDeviceInfo() out of Vm
..


Patch Set 11: Verified+1

Verified by running a VM from Engine, migrating it to another host and back, 
and stopping it.

-- 
To view, visit https://gerrit.ovirt.org/53678
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50d160317f91db92bb6a8ae22a45d9574d1434b3
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: ovs: mock setupNetworks in OVSNetworkTests class

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: tests: ovs: mock setupNetworks in OVSNetworkTests class
..


Patch Set 1: Verified+1

OVS tests are running again.

-- 
To view, visit https://gerrit.ovirt.org/54889
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07127bb335da9462b8b439b3853f7e89eaef3064
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: expose hostdevReattach maintenance verb

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: expose hostdevReattach maintenance verb
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54891
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iebfb6a4e3854de8ea412417832a57fb896b78d1a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: ovs: mock setupNetworks in OVSNetworkTests class

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: ovs: mock setupNetworks in OVSNetworkTests class
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/53667
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia90cee83633b12a5bb40b58fc15864a3646018b5
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Separate storage health monitoring

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitoring: Separate storage health monitoring
..


Patch Set 4:

(4 comments)

https://gerrit.ovirt.org/#/c/54757/4/lib/vdsm/storage/check.py
File lib/vdsm/storage/check.py:

Line 35: def monotonic_time():
Line 36: return os.times()[4]
Line 37: 
Line 38: 
Line 39: class EventLoop(object):
This class will be replaced by vdsm.storage.eventloop.EventLoop
See previous patch.
Line 40: # TODO: schedule calls from other threads on the eventloop thread.
Line 41: 
Line 42: log = logging.getLogger("storage.eventloop")
Line 43: DEFAULT_DELAY = 30.0  # Used if no timers are scheduled


Line 132: expired.append((deadline, timer))
Line 133: return expired
Line 134: 
Line 135: 
Line 136: class Timer(object):
Will be dropped.
Line 137: 
Line 138: def __init__(self, callback, repeat=0.0):
Line 139: self.callback = callback
Line 140: self.repeat = repeat


Line 252: 
Line 253: def check(self):
Line 254: if not self.running:
Line 255: return
Line 256: if self._proc:
Unneeded, will schedule a new check when the check is finished.
Line 257: elapsed = monotonic_time() - self._check_time
Line 258: self.log.warning("Path %r stuck for %.02f seocnds",
Line 259:  self._path, elapsed)
Line 260: return


Line 288: self._rc = rc
Line 289: self._reaper = None
Line 290: self._proc = None
Line 291: self.log.debug("FINISH check %r rc=%s stats=%r elapsed=%.02f",
Line 292:self._path, self._rc, self._stats, elapsed)
Schedule a new check here - we don't really need repeating timers, and they are 
not supporting in asyncio eventloop.
Line 293: 
Line 294: 
Line 295: # TODO: replace this with tests
Line 296: if __name__ == '__main__':


-- 
To view, visit https://gerrit.ovirt.org/54757
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If22fe38b8b29116270f9012b75895506adc48852
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: conf: proper locking in onDisconnect()

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: vm: conf: proper locking in onDisconnect()
..

vm: conf: proper locking in onDisconnect()

Change-Id: I372e31b7b0d6eb6f8b69871b65e9243ee3ee45a2
Bug-Url: https://bugzilla.redhat.com/1318550
Signed-off-by: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/54908/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 955b8ad..7003808 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -871,14 +871,16 @@
   force=True)
 
 def onDisconnect(self, detail=None, clientIp='', clientPort=''):
-if self.conf['clientIp'] != clientIp:
-self.log.debug('Ignoring disconnect event because ip differs')
-return
 if self._clientPort and self._clientPort != clientPort:
 self.log.debug('Ignoring disconnect event because ports differ')
 return
 
-self.conf['clientIp'] = ''
+with self._confLock:
+if self.conf['clientIp'] != clientIp:
+self.log.debug('Ignoring disconnect event because ip differs')
+return
+self.conf['clientIp'] = ''
+
 # This is a hack to mitigate the issue of spice-gtk not respecting the
 # configured secure channels. Spice-gtk is always connecting first to
 # a non-secure channel and the server tells the client then to connect


-- 
To view, visit https://gerrit.ovirt.org/54908
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I372e31b7b0d6eb6f8b69871b65e9243ee3ee45a2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [1]

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [1]
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54890
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaf958554c0f71cfe652869bd75eb17aea5ca676
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [2], fake bridgeless

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [2], fake bridgeless
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54927
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bbf23d3864dfdf83d506a3b9885fc94eae01026
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [2], fake bridgeless

[phoracek]

Petr Horáček has uploaded a new change for review.

Change subject: net: native ovs [2], fake bridgeless
..

net: native ovs [2], fake bridgeless

Engine expects Display networks to be bridgeless. We can't create
bridgeless networks in OVS, but we can create them bridged and then
lie about them to engine.

Change-Id: I4bbf23d3864dfdf83d506a3b9885fc94eae01026
Signed-off-by: Petr Horáček 
---
M lib/vdsm/network/ovs_switch/caps.py
M lib/vdsm/network/ovs_switch/validator.py
2 files changed, 11 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/54927/1

diff --git a/lib/vdsm/network/ovs_switch/caps.py 
b/lib/vdsm/network/ovs_switch/caps.py
index 84c607f..056f0df 100644
--- a/lib/vdsm/network/ovs_switch/caps.py
+++ b/lib/vdsm/network/ovs_switch/caps.py
@@ -100,7 +100,7 @@
 interface = net if 'vlan' in attrs else BRIDGE_NAME
 net_info = _get_net_info(interface, routes)
 net_info['iface'] = net
-net_info['bridged'] = True
+net_info['bridged'] = attrs.get('bridge')
 net_info['ports'] = _get_ports(net, attrs)
 net_info['stp'] = supervdsm.getProxy().ovs_get_stp(interface)
 ovs_nets_caps[net] = net_info
@@ -111,14 +111,16 @@
 ovs_bridges_caps = {}
 routes = netinfo_routes.get_routes()
 for net, attrs in iter_ovs_nets(running_config.networks):
-interface = net if 'vlan' in attrs else BRIDGE_NAME
-net_info = _get_net_info(interface, routes)
-net_info['bridged'] = True
-net_info['ports'] = _get_ports(net, attrs)
-# TODO netinfo._bridge_options does not work here
-net_info['opts'] = {}
-net_info['stp'] = supervdsm.getProxy().ovs_get_stp(interface)
-ovs_bridges_caps[net] = net_info
+bridged = attrs.get('bridge')
+if bridged:
+interface = net if 'vlan' in attrs else BRIDGE_NAME
+net_info = _get_net_info(interface, routes)
+net_info['bridged'] = bridged
+net_info['ports'] = _get_ports(net, attrs)
+# TODO netinfo._bridge_options does not work here
+net_info['opts'] = {}
+net_info['stp'] = supervdsm.getProxy().ovs_get_stp(interface)
+ovs_bridges_caps[net] = net_info
 return ovs_bridges_caps
 
 
diff --git a/lib/vdsm/network/ovs_switch/validator.py 
b/lib/vdsm/network/ovs_switch/validator.py
index 16f44c2..4a5b81e 100644
--- a/lib/vdsm/network/ovs_switch/validator.py
+++ b/lib/vdsm/network/ovs_switch/validator.py
@@ -40,12 +40,8 @@
 nic = attrs.get('nic')
 bond = attrs.get('bonding')
 vlan = attrs.get('vlan')
-bridged = attrs.get('bridged', True)
 stp = attrs.get('stp', False)
 
-if not bridged:
-raise ConfigNetworkError(
-ne.ERR_BAD_PARAMS, 'OVS does not support bridgeless networks')
 if bond in running_config.bonds:
 if not is_ovs_bond(running_config.bonds[bond]):
 raise ConfigNetworkError(


-- 
To view, visit https://gerrit.ovirt.org/54927
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4bbf23d3864dfdf83d506a3b9885fc94eae01026
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [2], fake bridgeless

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [2], fake bridgeless
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54927
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bbf23d3864dfdf83d506a3b9885fc94eae01026
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [3], ip handling

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [3], ip handling
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54930
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie562fa5fb53c69fec85c8b368dbb5479d13dd473
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [3], ip handling

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [3], ip handling
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54930
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie562fa5fb53c69fec85c8b368dbb5479d13dd473
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net tests: TestIPv6Addresses should run as root

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net tests: TestIPv6Addresses should run as root
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54950
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8c681e3d0475bd4a76e5b371db08069aa1e518d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: guest-agent: Fix API version negotiation

[fromani]

Francesco Romani has posted comments on this change.

Change subject: guest-agent: Fix API version negotiation
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54896
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5dd8a36395615d4b908a0c88a6bbfee3cab1952
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: ovs: mock setupNetworks in OVSNetworkTests class

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: tests: ovs: mock setupNetworks in OVSNetworkTests class
..


Patch Set 5: Verified+1

OVS tests are running again.

Output:

[root@centos7-vdsmbox ~]# cat ovs_tests.log 
functional.networkTestsOVS.OVSNetworkTest
testHonorBlockingDhcp   SKIP: Slow 
tests are disabled
testLowerMtuDoesNotOverride OK
testNoBridgeLeftovers   OK
testSelectiveRestoreIgnoresVdsmRegParamsOK
testSetupNetworkOutboundQos(True)   ERROR
testSetupNetworksAddBadParams(True) OK
testSetupNetworksAddBondWithManyVlans(True) OK
testSetupNetworksAddDelBondedNetwork(True)  OK
testSetupNetworksAddDelDhcp(True, (4, 6))   FAIL
testSetupNetworksAddDelDhcp(True, (4,)) FAIL
testSetupNetworksAddDelDhcp(True, (6,)) FAIL
testSetupNetworksAddManyVlans(True) OK
testSetupNetworksAddNetworkToNicAfterBondBreaking(True) OK
testSetupNetworksAddVlan(True)  ERROR
testSetupNetworksConnectivityCheck  OK
testSetupNetworksConnectivityCheckOverExistingBond  OK
testSetupNetworksEmergencyDevicesCleanupBondOverwrite(True) SKIP: Slow 
tests are disabled
testSetupNetworksEmergencyDevicesCleanupVlanOverwrite(True) SKIP: Slow 
tests are disabled
testSetupNetworksKeepNetworkOnBondAfterBondResizing(True)   OK
testSetupNetworksMtus(True) FAIL
testSetupNetworksMultiMTUsOverBond(True)FAIL
testSetupNetworksMultiMTUsOverNic(True) FAIL
testSetupNetworksNiclessOK
testSetupNetworksOverExistingBridge OK
testSetupNetworksReconfigureBridge  FAIL
testStaticNetworkConfig((4, 6)) FAIL
testStaticNetworkConfig((4,))   OK
testStaticNetworkConfig((6,))   FAIL
testStaticSourceRouting(True)   OK
test_bond_mode0_caps_aggregator_id  OK
test_bond_mode4_caps_aggregator_id  FAIL
test_bondmode_in_capabilities({'options': 'mode=0'})OK
test_bondmode_in_capabilities({'options': 'mode=1'})OK
test_bondmode_in_capabilities({})   FAIL
test_drop_initial_bond_slaves_ip_config OK
test_drop_initial_network_nic_ip_config OK
test_ovirtmgmtm_to_ovs  OK
test_remove_bond_under_network  SKIP: OVS does 
not support bridgeless networks
test_rollback   OK
test_setupNetworks_swap_slaves_between_bondsFAIL

==
ERROR: testSetupNetworkOutboundQos(True) 
(functional.networkTestsOVS.OVSNetworkTest)
--
Traceback (most recent call last):
  File "/usr/share/vdsm/tests/testlib.py", line 73, in wrapper
return f(self, *args)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 212, in wrapper
func(*args, **kwargs)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 2493, in 
testSetupNetworkOutboundQos
self.assertNetworkExists(NETWORK_NAME, hostQos=hostQos)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 231, in 
assertNetworkExists
reported_qos = network_netinfo['hostQos']
KeyError: 'hostQos'
 >> begin captured logging << 
SuperVdsmProxy: DEBUG: Trying to connect to Super Vdsm
- >> end captured logging << -

==
ERROR: testSetupNetworksAddVlan(True) 
(functional.networkTestsOVS.OVSNetworkTest)
--
Traceback (most recent call last):
  File "/usr/share/vdsm/tests/testlib.py", line 73, in wrapper
return f(self, *args)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 212, in wrapper
func(*args, **kwargs)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 744, in 
testSetupNetworksAddVlan
self.assertNetworkExists(NETWORK_NAME, bridgeOpts=BRIDGE_OPTS)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 229, in 
assertNetworkExists
self.assertEqual(value, appliedOpts[opt])
KeyError: 'multicast_router'

Change in vdsm[master]: hostdev: decode XML string when parsing devices

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hostdev: decode XML string when parsing devices
..


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/54802/1//COMMIT_MSG
Commit Message:

Line 10: ascii
why is that? I would assume that UTF8 is likely to be used if a crazy BIOS 
likes to add Hebrew or Czech strings.


https://gerrit.ovirt.org/#/c/54802/1/lib/vdsm/hostdev.py
File lib/vdsm/hostdev.py:

Line 118:   'usb_device': _parse_usb_address}
Line 119: 
Line 120: params = {}
Line 121: 
Line 122: devXML = etree.fromstring(device_xml.decode('ascii', 
errors='ignore'))
I think that 'replace' would give the user a hint about information
Line 123: name = devXML.find('name').text
Line 124: if name != 'computer':
Line 125: params['parent'] = devXML.find('parent').text
Line 126: 


-- 
To view, visit https://gerrit.ovirt.org/54802
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf9b9699790c83bb82a88a700c63d05604588d02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: events: introduction of schema

[mmucha]

Martin Mucha has posted comments on this change.

Change subject: events: introduction of schema
..


Patch Set 1:

I went over files, I did not spot anything bad. However I'm not scoring, since 
my python knowledge is very beginner-ish and same applies for vdsm. I need to 
work on it so I can do proper CR.

-- 
To view, visit https://gerrit.ovirt.org/54754
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43a9f1852b1459a2e905244049507704f0187201
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: tests: Run unit tests using travis-ci and docker
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/54856/1/.travis.yml
File .travis.yml:

Line 8:  
Do we need this white space at the end of the line?


-- 
To view, visit https://gerrit.ovirt.org/54856
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cd647acb4c740f890e9b602783915439317880
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: add vdsClient hotunplug command

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: add vdsClient hotunplug command
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54940
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie00e5510b5306d689536b24091411332c8b80e75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: bump libvirt requirement

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: bump libvirt requirement
..


Patch Set 3:

* #1292096::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1292096::OK, public bug
* Check Product::#1292096::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54796
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c231a33161d91470e98165311f408cf6fa41d38
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: decode XML string when parsing devices

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: hostdev: decode XML string when parsing devices
..


Patch Set 1:

I know it's tempting to at least log something, but reading dmesg, you would 
probably have about 17 messages mentioning broken bios. Do we also need to 
report the same thing?

-- 
To view, visit https://gerrit.ovirt.org/54802
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf9b9699790c83bb82a88a700c63d05604588d02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the eventloop module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the eventloop module
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: directio: Port to Python 3

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: directio: Port to Python 3
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/54699/2/tests/Makefile.am
File tests/Makefile.am:

Line 38:permutationTests.py \
Line 39:pthreadTests.py \
Line 40:responseTests.py \
Line 41:scheduleTests.py \
Line 42:storage_directio_test.py \
> Should be in an earlier patch which added this test.
This is the list of test that can run on python 3 - and this patch make this 
possible. The test module was added to the python 2 test list in the patch 
adding this module.
Line 43:vmStatsTests.py \
Line 44:$(NULL)
Line 45: 
Line 46: device_modules = \


-- 
To view, visit https://gerrit.ovirt.org/54699
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad6f317df3efc70adb95063227c5e07513d34135
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: api: move rollback to network/api.py level

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: api: move rollback to network/api.py level
..


net: api: move rollback to network/api.py level

In order to simplify rollback handling we moved rollback from
API.py to network/api.py.

Note, that we also have to fix netinfo.cache import in vdsm/caps.py,
caps were added to scope as a side effect of RollbackIncomplete import
in API.py. For more info check https://gerrit.ovirt.org/#/c/53529

Change-Id: Ic9b45d8e11a1ae7af5bdb650dd617f50ee0ffaa1
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/54751
Continuous-Integration: Jenkins CI
Tested-by: Edward Haas 
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/network/api.py
M vdsm/API.py
M vdsm/caps.py
3 files changed, 63 insertions(+), 72 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/54751
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9b45d8e11a1ae7af5bdb650dd617f50ee0ffaa1
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: guest-agent: Fix API version negotiation

[vfeenstr]

Vinzenz Feenstra has uploaded a new change for review.

Change subject: guest-agent: Fix API version negotiation
..

guest-agent: Fix API version negotiation

The guest agent negotation is currently broken due to storing the wrong value
as effectiveAPIVersion.
Currently the reported value by the guest agent is stored, which actually
should not be stored, but the commonVersion value.

Change-Id: Id5dd8a36395615d4b908a0c88a6bbfee3cab1952
Bug-Url: https://bugzilla.redhat.com/1318657
Signed-off-by: Vinzenz Feenstra 
---
M lib/vdsm/virt/guestagent.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/54871/1

diff --git a/lib/vdsm/virt/guestagent.py b/lib/vdsm/virt/guestagent.py
index 61e75e9..a6b5b59 100644
--- a/lib/vdsm/virt/guestagent.py
+++ b/lib/vdsm/virt/guestagent.py
@@ -202,7 +202,7 @@
 # Only update if the value changed
 self.log.info("Guest API version changed from %d to %d",
   self.effectiveApiVersion, commonVersion)
-self.effectiveApiVersion = version
+self.effectiveApiVersion = commonVersion
 if commonVersion != _IMPLICIT_API_VERSION_ZERO:
 # Only notify the guest agent if the API was not disabled
 self._forward('api-version', {'apiVersion': commonVersion})


-- 
To view, visit https://gerrit.ovirt.org/54871
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5dd8a36395615d4b908a0c88a6bbfee3cab1952
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: ovs: mock setupNetworks in OVSNetworkTests class

[phoracek]

Petr Horáček has abandoned this change.

Change subject: tests: ovs: mock setupNetworks in OVSNetworkTests class
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/53667
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia90cee83633b12a5bb40b58fc15864a3646018b5
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: common handling of exceptions

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: common handling of exceptions
..


Patch Set 7:

(7 comments)

https://gerrit.ovirt.org/#/c/54664/7/tests/api_response_test.py
File tests/api_response_test.py:

Line 36: 
Line 37: def test_success_extra_params(self):
Line 38: vmList = ['foobar']
Line 39: res = self.vm.succeed_with_args(vmList=vmList)
Line 40: self.assertFalse(response.is_error(res))
> This double negative is confusing - do we have response.is_sucess()?
we don't yet :\
Let me try to improve a bit without adding (now) a new helper
Line 41: self.assertEquals(res['vmList'], vmList)
Line 42: 
Line 43: def test_success_override_message(self):
Line 44: message = 'this message overrides the default'


Line 41: self.assertEquals(res['vmList'], vmList)
Line 42: 
Line 43: def test_success_override_message(self):
Line 44: message = 'this message overrides the default'
Line 45: res = self.vm.succeed_with_args(message=message)
> I would use another "verb" (.e.g succeed_with_return) to test return values
Done
Line 46: self.assertFalse(response.is_error(res))
Line 47: self.assertEquals(res['status']['message'], message)
Line 48: 
Line 49: def test_fail_with_vdsm_exception(self):


Line 62: self.id = vm_id
Line 63: 
Line 64: @api.method
Line 65: def fail_with_vdsm_exception(self, exc):
Line 66: raise exc()
> I would call this fail(exception)
Done
Line 67: 
Line 68: @api.method
Line 69: def fail_with_plain_exception(self):
Line 70: raise ValueError()


Line 66: raise exc()
Line 67: 
Line 68: @api.method
Line 69: def fail_with_plain_exception(self):
Line 70: raise ValueError()
> This is not needed, we can use previous method (after rename).
Done
Line 71: 
Line 72: @api.method
Line 73: def succeed(self):
Line 74: pass


Line 69: def fail_with_plain_exception(self):
Line 70: raise ValueError()
Line 71: 
Line 72: @api.method
Line 73: def succeed(self):
> Lets add another one with parameter for testing return value:
Done
Line 74: pass
Line 75: 
Line 76: @api.method
Line 77: def succeed_with_args(self, **kwargs):


Line 70: raise ValueError()
Line 71: 
Line 72: @api.method
Line 73: def succeed(self):
Line 74: pass
> Lets add another one with parameter for testing return value:
Done
Line 75: 
Line 76: @api.method
Line 77: def succeed_with_args(self, **kwargs):


Line 73: def succeed(self):
Line 74: pass
Line 75: 
Line 76: @api.method
Line 77: def succeed_with_args(self, **kwargs):
> I would test:
OK. what those method should return?


-- 
To view, visit https://gerrit.ovirt.org/54664
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic186dc8fa062d8b3789c6057bba68fbbc23f311b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: supervdsm: move udev-related functions to udev.py

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: supervdsm: move udev-related functions to udev.py
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54458
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8c4a5120887c2cbf13463f33fad2ef5e002e0d6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [1]

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: native ovs [1]
..


Patch Set 4: Verified+1

Passed most of OVS test, except MTU and IP ones.

-- 
To view, visit https://gerrit.ovirt.org/54890
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaf958554c0f71cfe652869bd75eb17aea5ca676
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks:checkips: add checkips hook

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks:checkips: add checkips hook
..


Patch Set 5:

* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#994170::ERROR, private bug
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54102
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Artyom Lukianov 
Gerrit-Reviewer: Artyom Lukianov 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm
..


Patch Set 12: Code-Review+2

(1 comment)

raising score after Martin (conditional) approval :)

https://gerrit.ovirt.org/#/c/53620/12/tests/deviceTests.py
File tests/deviceTests.py:

Line 550: vmdevices.hostdevice.HostDevice.update_device_info(testvm,
:
device_conf)
> Idea for future patch: to really test the function, following flow should b
Added a trello card so we don't forget about this.


-- 
To view, visit https://gerrit.ovirt.org/53620
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I789d7d2349fc24b48e52260de98fb3d66b168bf7
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks:checkips: add checkips hook

[alukiano]

Artyom Lukianov has posted comments on this change.

Change subject: hooks:checkips: add checkips hook
..


Patch Set 4:

(13 comments)

https://gerrit.ovirt.org/#/c/54102/4/vdsm_hooks/checkips/README
File vdsm_hooks/checkips/README:

Line 2: =
Line 3: This hook check connectivity from host to given addresses
Line 4: 
Line 5: This hook is useful in cases where you need to check connectivity from 
host to
Line 6: specific vlan, before you start vm on it.
> this is not specific to vm networks; it applies just as well to a migration
Done
Line 7: 
Line 8: 
Line 9: Syntax:
Line 10: checkips=ipv4,ipv6


Line 6: specific vlan, before you start vm on it.
Line 7: 
Line 8: 
Line 9: Syntax:
Line 10: checkips=ipv4,ipv6
> it would be cooler to allow fqdn of ping target, not only ip address. this 
Done
Line 11: 
Line 12: Where:
Line 13: ipv4 is ip address in ipv4 format
Line 14: ipv6 is ip address in ipv6 format


https://gerrit.ovirt.org/#/c/54102/4/vdsm_hooks/checkips/after_get_stats.py
File vdsm_hooks/checkips/after_get_stats.py:

Line 19: # Refer to the README and COPYING files for full details of the license
Line 20: #
Line 21: import os
Line 22: import sys
Line 23: import time
> please split public from project-local import. sort each group alphabetical
Done
Line 24: import hooking
Line 25: import traceback
Line 26: import checkips_utils
Line 27: from vdsm import constants


Line 30: CHECK_IPS
> is this constant needed?
Done


Line 46: TEST_DIR
> should be local to the test() function. use mkdtemp() to avoid name clashes
Done


Line 50: file_dir
> the name is too vague. how about stats_dir?
Done


Line 105: 'check_ipv4': 'up',
Line 106: 'check_ipv6': 'up',
Line 107: 'test_network': 'down'
Line 108: }
Line 109: for interface, state in expected_states.iteritems():
> please remember python 3
Done
Line 110: test_msg = 'pass'
Line 111: if network_stats['network'][interface]['state'] != state:
Line 112: test_msg = 'fail'
Line 113: print(


https://gerrit.ovirt.org/#/c/54102/4/vdsm_hooks/checkips/checkips
File vdsm_hooks/checkips/checkips:

Line 22: import six
Line 23: import time
Line 24: import syslog
Line 25: import socket
Line 26: import hooking
> same comment about import order.
Done
Line 27: import threading
Line 28: import checkips_utils
Line 29: from vdsm import constants
Line 30: import vdsm.netconfpersistence as persist_net


Line 57: params
> we usually call this net_attrs
Done


Line 69: 
Line 70: 
Line 71: def main():
Line 72: try:
Line 73: while True:
> it's more precise to take the time before and after _ping_address, and slee
Done
Line 74: _ping_addresses()
Line 75: time.sleep(PING_SAMPLE_TIME)
Line 76: except Exception as e:
Line 77: syslog.syslog("Service checkips failed to start: %s" % e)


https://gerrit.ovirt.org/#/c/54102/4/vdsm_hooks/checkips/checkips.service.in
File vdsm_hooks/checkips/checkips.service.in:

Line 1: [Unit]
Line 2: Description=Service that ping given ips each 60 seconds
> naming issue: make sure that this service has the vdsm- prefix in its name.
Done
Line 3: 
Line 4: [Service]
Line 5: Type=simple
Line 6: LimitCORE=infinity


https://gerrit.ovirt.org/#/c/54102/4/vdsm_hooks/checkips/checkips_utils.py
File vdsm_hooks/checkips/checkips_utils.py:

Line 32: params
> net_attrs
Done


Line 30: 
Line 31: 
Line 32: def get_address(params):
Line 33: if 'custom' in params and CHECK_IPS in params['custom']:
Line 34: return params['custom'][CHECK_IPS]
> be explicit about this returning None if no address is found.
Done


-- 
To view, visit https://gerrit.ovirt.org/54102
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Artyom Lukianov 
Gerrit-Reviewer: Artyom Lukianov 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [3], ip handling

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [3], ip handling
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54930
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie562fa5fb53c69fec85c8b368dbb5479d13dd473
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: events: don't abort creation if event fails

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: events: don't abort creation if event fails
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54933
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a06df003fce796519df26550910352120da17a8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the eventloop module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the eventloop module
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: expose hotplug via vdsClient

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: expose hotplug via vdsClient
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54938
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46fb415c39d04b94428703ac19da505a2cf2800d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: expose hostdevReattach maintenance verb

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: expose hostdevReattach maintenance verb
..


Patch Set 2:

Adding Piotr because of the schema updates

-- 
To view, visit https://gerrit.ovirt.org/54891
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iebfb6a4e3854de8ea412417832a57fb896b78d1a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: add support for hotplug

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: add support for hotplug
..


Patch Set 9:

Adding Piotr because of the schema updates

-- 
To view, visit https://gerrit.ovirt.org/42661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2465360664ef9b659c52dc610a95d2c2f1555c54
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev/sr-iov: don't reattach devices

[mpolednik]

Martin Polednik has uploaded a new change for review.

Change subject: hostdev/sr-iov: don't reattach devices
..

hostdev/sr-iov: don't reattach devices

Change-Id: I890e103e193776f269ab7d4f98c006f1b0bcb266
Signed-off-by: Martin Polednik 
---
M vdsm/virt/vm.py
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/54937/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 093a660..f33c8b7 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -2314,8 +2314,6 @@
 try:
 self._dom.detachDevice(nicXml)
 self._waitForDeviceRemoval(nic)
-if nic.is_hostdevice:
-hostdev.reattach_detachable(nic.hostdev)
 except HotunplugTimeout as e:
 self.log.error("%s", e)
 self._rollback_nic_hotunplug(nicDev, nic)


-- 
To view, visit https://gerrit.ovirt.org/54937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I890e103e193776f269ab7d4f98c006f1b0bcb266
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [3], ip handling

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [3], ip handling
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54930
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie562fa5fb53c69fec85c8b368dbb5479d13dd473
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [2], fake bridgeless

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [2], fake bridgeless
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54927
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bbf23d3864dfdf83d506a3b9885fc94eae01026
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: ovs: mock setupNetworks in OVSNetworkTests class

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: ovs: mock setupNetworks in OVSNetworkTests class
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54889
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07127bb335da9462b8b439b3853f7e89eaef3064
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [1]

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [1]
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54890
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaf958554c0f71cfe652869bd75eb17aea5ca676
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches