Change in vdsm[ovirt-3.6]: migration: downtime: handle steps=1
Francesco Romani has posted comments on this change. Change subject: migration: downtime: handle steps=1 .. Patch Set 6: Continuous-Integration+1 Jenkins failure unrelated: 00:04:51.490 Traceback (most recent call last): 00:04:51.490 File "/home/jenkins/workspace/vdsm_3.6_check-patch-el7-x86_64/vdsm/tests/ipwrapperTests.py", line 130, in testEnablePromisc 00:04:51.491 "Could not enable promiscuous mode.") 00:04:51.491 AssertionError: Could not enable promiscuous mode. 00:04:51.491 >> begin captured logging << 00:04:51.492 root: DEBUG: /usr/bin/taskset --cpu-list 0-31 /usr/sbin/brctl show (cwd None) 00:04:51.492 root: DEBUG: SUCCESS: = ''; = 0 00:04:51.492 root: DEBUG: /usr/bin/taskset --cpu-list 0-31 /sbin/ip link add dev vdsm-3TaGJTh3DS type bridge (cwd None) 00:04:51.493 root: DEBUG: SUCCESS: = ''; = 0 00:04:51.493 root: DEBUG: /usr/bin/taskset --cpu-list 0-31 /sbin/ip link set vdsm-3TaGJTh3DS up (cwd None) 00:04:51.493 root: DEBUG: SUCCESS: = ''; = 0 00:04:51.494 - >> end captured logging << - -- To view, visit https://gerrit.ovirt.org/59218 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb99e617d227e8043a1e99f0e8b1040e02a9b7e3 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: migration: downtime: start thread after 1st iter
Francesco Romani has posted comments on this change. Change subject: migration: downtime: start thread after 1st iter .. Patch Set 8: Continuous-Integration+1 Jenkins failure unrelated: 00:04:34.392 == 00:04:34.392 FAIL: testDisablePromisc (ipwrapperTests.TestDrvinfo) 00:04:34.392 -- 00:04:34.392 Traceback (most recent call last): 00:04:34.392 File "/home/jenkins/workspace/vdsm_3.6_check-patch-el7-x86_64/vdsm/tests/ipwrapperTests.py", line 136, in testDisablePromisc 00:04:34.392 "Could not disable promiscuous mode.") 00:04:34.393 AssertionError: Could not disable promiscuous mode. 00:04:34.393 >> begin captured logging << 00:04:34.393 root: DEBUG: /usr/bin/taskset --cpu-list 0-15 /usr/sbin/brctl show (cwd None) 00:04:34.393 root: DEBUG: SUCCESS: = ''; = 0 00:04:34.393 root: DEBUG: /usr/bin/taskset --cpu-list 0-15 /sbin/ip link add dev vdsm-Jtx8FU3X2o type bridge (cwd None) 00:04:34.393 root: DEBUG: SUCCESS: = ''; = 0 00:04:34.393 root: DEBUG: /usr/bin/taskset --cpu-list 0-15 /sbin/ip link set vdsm-Jtx8FU3X2o up (cwd None) 00:04:34.394 root: DEBUG: SUCCESS: = ''; = 0 00:04:34.394 - >> end captured logging << - -- To view, visit https://gerrit.ovirt.org/59220 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I661c44d9dd7bdb9f1ec3a355038cfa8966946011 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Makefile: added 'tests' target
Irit Goihman has posted comments on this change. Change subject: Makefile: added 'tests' target .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/59417 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I378dbf38bbce6cadf87fbedbc9bf6a5d1c714571 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: migration: downtime: add tunable for back compat
Martin Polednik has posted comments on this change. Change subject: migration: downtime: add tunable for back compat .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If477f268354a9609ecca216dad1eee4f40910c8f Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Tomas Jelinek Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: migration: downtime: add tunable for back compat
Francesco Romani has posted comments on this change. Change subject: migration: downtime: add tunable for back compat .. Patch Set 12: Verified+1 in v11/v12 I documented that the option I added is provisional, so it should not to be expected to be present in the future versions of Vdsm (e.g. 4.18.z or greater) Changed only a string, 'make check' passes -> copied V+1 score. -- To view, visit https://gerrit.ovirt.org/59467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If477f268354a9609ecca216dad1eee4f40910c8f Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Tomas Jelinek Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: migration: downtime: add tunable for back compat
Martin Polednik has posted comments on this change. Change subject: migration: downtime: add tunable for back compat .. Patch Set 12: Code-Review+1 Good addition. -- To view, visit https://gerrit.ovirt.org/59467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If477f268354a9609ecca216dad1eee4f40910c8f Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Tomas Jelinek Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: migration: downtime: add tunable for back compat
Francesco Romani has posted comments on this change. Change subject: migration: downtime: add tunable for back compat .. Patch Set 12: Let's retry with jenkins: 00:05:00.936 MountError: (32, ';mount: /tmp/vdsm-mkimage-testszw5a8B/images/vmId_iso.ff8459743c0d487d8b26cc8042bb470e.img: failed to setup loop device: No such file or directory\n') -- To view, visit https://gerrit.ovirt.org/59467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If477f268354a9609ecca216dad1eee4f40910c8f Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Tomas Jelinek Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sla: Use GuestIoTuneOptional collector in MOM
Francesco Romani has posted comments on this change. Change subject: sla: Use GuestIoTuneOptional collector in MOM .. Patch Set 2: Code-Review+1 from my limited experience as policy writer, looks ok. -- To view, visit https://gerrit.ovirt.org/59936 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27162756b33441ab1962fca930a5459ff909fd81 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: gluster: remove clientIf frmo GlusterApi
Ramesh N has posted comments on this change. Change subject: gluster: remove clientIf frmo GlusterApi .. Patch Set 1: clientIF was used in bindingxmlrpc.py and I don't think it can be removed. Abandoning this patch. -- To view, visit https://gerrit.ovirt.org/59929 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f795a9d0aea8ea4478666f2a59b48cd3e0b7c98 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ramesh N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: gluster: remove clientIf frmo GlusterApi
Ramesh N has abandoned this change. Change subject: gluster: remove clientIf frmo GlusterApi .. Abandoned -- To view, visit https://gerrit.ovirt.org/59929 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I2f795a9d0aea8ea4478666f2a59b48cd3e0b7c98 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ramesh N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tests: converted main.py to a test module
Irit Goihman has uploaded a new change for review. Change subject: tests: converted main.py to a test module .. tests: converted main.py to a test module main.py is now a test module and has been renamed to storage_exceptions_test.py which is more informative name. Change-Id: Iea5585bc4f494ab09131e749164965c358bdf472 Signed-off-by: Irit Goihman --- M tests/Makefile.am R tests/storage_exceptions_test.py 2 files changed, 2 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/59975/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 352f5be..20e71e0 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -79,7 +79,6 @@ libvirtconnectionTests.py \ logutils_test.py \ lvmTests.py \ - main.py \ miscTests.py \ mkimageTests.py \ modprobe.py \ @@ -114,6 +113,7 @@ stompAsyncDispatcherTests.py \ stompTests.py \ storage_blkdiscard_test.py \ + storage_exceptions_test.py \ storagefakelibTests.py \ storageMailboxTests.py \ storageServerTests.py \ @@ -182,7 +182,6 @@ imagetickets_test.py \ iscsiTests.py \ lvmTests.py \ - main.py \ miscTests.py \ mkimageTests.py \ momPolicyTests.py \ @@ -223,6 +222,7 @@ storageServerTests.py \ storage_rwlock_test.py \ storage_blkdiscard_test.py \ + storage_exceptions_test.py \ storage_sdm_api_test.py \ storage_sdm_create_volume_test.py \ storage_volume_artifacts_test.py \ diff --git a/tests/main.py b/tests/storage_exceptions_test.py similarity index 96% rename from tests/main.py rename to tests/storage_exceptions_test.py index 4a691f5..ac785f9 100644 --- a/tests/main.py +++ b/tests/storage_exceptions_test.py @@ -19,7 +19,6 @@ # import types -import unittest from gluster import exception as gluster_exception @@ -63,7 +62,3 @@ # gluster exception range: 4100-4800 self.assertTrue(obj.code >= 4100) self.assertTrue(obj.code <= 4800) - - -if __name__ == '__main__': -unittest.main() -- To view, visit https://gerrit.ovirt.org/59975 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iea5585bc4f494ab09131e749164965c358bdf472 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sla: Use GuestIoTuneOptional collector in MOM
Dan Kenigsberg has submitted this change and it was merged. Change subject: sla: Use GuestIoTuneOptional collector in MOM .. sla: Use GuestIoTuneOptional collector in MOM All major collectors in MOM now have the optional variant that makes sure the VM can be processed even when some of the functionality is missing. The IoTune collector was the last one affected by this. Change-Id: I27162756b33441ab1962fca930a5459ff909fd81 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1348263 Signed-off-by: Martin Sivak Reviewed-on: https://gerrit.ovirt.org/59936 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani Reviewed-by: Dan Kenigsberg --- M vdsm.spec.in M vdsm/mom.conf.in M vdsm/mom.d/05-iotune.policy 3 files changed, 6 insertions(+), 5 deletions(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59936 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27162756b33441ab1962fca930a5459ff909fd81 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sla: Use GuestIoTuneOptional collector in MOM
Dan Kenigsberg has posted comments on this change. Change subject: sla: Use GuestIoTuneOptional collector in MOM .. Patch Set 2: Code-Review+2 trusting Martin here. -- To view, visit https://gerrit.ovirt.org/59936 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27162756b33441ab1962fca930a5459ff909fd81 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Andrej Krejcir Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Roman Mohr Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: spec: Require lvm version fixing filter
Dan Kenigsberg has submitted this change and it was merged. Change subject: spec: Require lvm version fixing filter .. spec: Require lvm version fixing filter Older lvm version was using filter incorrectly when running commands such as vgck and pvs. Instead of rejecting all the devices in the filter, the commands opened and scanned all block devices. This slow down these commands on systems with lot of block devices. On 3.6, lvm slowdowns cause delays in storage monitoring and may cause a host to become non-operational. These delays may also cause storage operations such as copying disks to fail with a timeout. On 4.0, these slowdowns may cause unwanted delays in various flows, but are not harmful to storage monitoring. Fedora 23 and later already include this fix (lvm2-2.02.132-2.fc23). Change-Id: I24040df9e19b4a093ce7e4f954375017f694099f Bug-Url: https://bugzilla.redhat.com/1346012 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/59907 Reviewed-by: Francesco Romani Reviewed-by: Dan Kenigsberg --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Nir Soffer: Verified; Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/59907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24040df9e19b4a093ce7e4f954375017f694099f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: spec: Require lvm version fixing filter
Dan Kenigsberg has posted comments on this change. Change subject: spec: Require lvm version fixing filter .. Patch Set 3: Code-Review+2 unrelated errors 20:28:23 nothing provides fcoe-utils needed by vdsm-hook-fcoe-4.18.999-168.gitf857e35.fc23.noarch. 20:28:23 nothing provides ed needed by vdsm-4.18.999-168.gitf857e35.fc23.x86_64. 20:28:23 package vdsm-tests-4.18.999-168.gitf857e35.fc23.noarch requires vdsm = 4.18.999-168.gitf857e35.fc23, but none of the providers can be installed. 20:28:23 package vdsm-hook-vmfex-dev-4.18.999-168.gitf857e35.fc23.noarch requires vdsm = 4.18.999-168.gitf857e35.fc23, but none of the providers can be installed. 20:28:23 package vdsm-hook-ovs-4.18.999-168.gitf857e35.fc23.noarch requires vdsm = 4.18.999-168.gitf857e35.fc23, but none of the providers can be installed. 20:28:23 package vdsm-hook-extnet-4.18.999-168.gitf857e35.fc23.noarch requires vdsm = 4.18.999-168.gitf857e35.fc23, but none of the providers can be installed. 20:28:23 package vdsm-hook-ethtool-options-4.18.999-168.gitf857e35.fc23.noarch requires vdsm = 4.18.999-168.gitf857e35.fc23, but none of the providers can be installed. 20:28:23 nothing provides ed needed by vdsm-4.18.999-168.gitf857e35.fc23.x86_64. 20:28:23 package vdsm-gluster-4.18.999-168.gitf857e35.fc23.noarch requires vdsm = 4.18.999-168.gitf857e35.fc23, but none of the providers can be installed. 20:28:23 package vdsm-hook-qemucmdline-4.18.999-168.gitf857e35.fc23.noarch requires vdsm, but none of the providers can be installed. 20:28:23 package vdsm-hook-macbind-4.18.999-168.gitf857e35.fc23.noarch requires vdsm >= 4.14, but none of the providers can be installed. 20:28:23 package vdsm-hook-ipv6-4.18.999-168.gitf857e35.fc23.noarch requires vdsm >= 4.16.7, but none of the providers can be installed. 20:28:23 package vdsm-hook-faqemu-4.18.999-168.gitf857e35.fc23.noarch requires vdsm, but none of the providers can be installed. 20:28:23 package vdsm-hook-fakevmstats-4.18.999-168.gitf857e35.fc23.noarch requires vdsm, but none of the providers can be installed. 20:28:23 nothing provides logrotate needed by vdsm-4.18.999-142.gitb53f26b.fc23.x86_64. 20:28:23 package vdsm-hook-checkimages-4.18.999-168.gitf857e35.fc23.noarch requires vdsm, but none of the providers can be installed. 20:28:23 package vdsm-hook-allocate_net-4.18.999-168.gitf857e35.fc23.noarch requires vdsm, but none of the providers can be installed -- To view, visit https://gerrit.ovirt.org/59907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24040df9e19b4a093ce7e4f954375017f694099f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: spec: Require lvm version fixing filter
Dan Kenigsberg has posted comments on this change. Change subject: spec: Require lvm version fixing filter .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/59907/3//COMMIT_MSG Commit Message: PS3, Line 21: Fedora 23 and later already include this fix (lvm2-2.02.132-2.fc23). > This is true, but from reading the spec file, all you see for Fedora is "Re +1, but let's rush this into 4.0.1! -- To view, visit https://gerrit.ovirt.org/59907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24040df9e19b4a093ce7e4f954375017f694099f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: sla: Use GuestIoTuneOptional collector in MOM
Martin Sivák has posted comments on this change. Change subject: sla: Use GuestIoTuneOptional collector in MOM .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/59988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27162756b33441ab1962fca930a5459ff909fd81 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Martin Sivák Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: sla: Use GuestIoTuneOptional collector in MOM
Martin Sivák has uploaded a new change for review. Change subject: sla: Use GuestIoTuneOptional collector in MOM .. sla: Use GuestIoTuneOptional collector in MOM All major collectors in MOM now have the optional variant that makes sure the VM can be processed even when some of the functionality is missing. The IoTune collector was the last one affected by this. Change-Id: I27162756b33441ab1962fca930a5459ff909fd81 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1348263 Signed-off-by: Martin Sivak Reviewed-on: https://gerrit.ovirt.org/59936 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani Reviewed-by: Dan Kenigsberg (cherry picked from commit a030644e6ba0c05b438f80c59c451839adffb353) --- M vdsm.spec.in M vdsm/mom.conf.in M vdsm/mom.d/05-iotune.policy 3 files changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/59988/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index 6f2157d..6f6ac60 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -71,7 +71,7 @@ BuildRequires: libselinux-python BuildRequires: libvirt-python BuildRequires: m2crypto -BuildRequires: mom >= 0.5.4 +BuildRequires: mom >= 0.5.5 BuildRequires: openssl BuildRequires: policycoreutils-python BuildRequires: psmisc diff --git a/vdsm/mom.conf.in b/vdsm/mom.conf.in index 0388162..f079673 100644 --- a/vdsm/mom.conf.in +++ b/vdsm/mom.conf.in @@ -81,4 +81,4 @@ [guest] # A comma-separated list of Collector plugins to use for Guest data collection. -collectors: GuestQemuProc, GuestMemoryOptional, GuestBalloonOptional, GuestCpuTune, GuestIoTune +collectors: GuestQemuProc, GuestMemoryOptional, GuestBalloonOptional, GuestCpuTune, GuestIoTuneOptional diff --git a/vdsm/mom.d/05-iotune.policy b/vdsm/mom.d/05-iotune.policy index 3132986..b9d845c 100644 --- a/vdsm/mom.d/05-iotune.policy +++ b/vdsm/mom.d/05-iotune.policy @@ -30,7 +30,8 @@ ### Main Script (if (== True ioTuneEnabled) { -(with Guests guest (set_io_limits guest)) +(with Guests guest (if (valid guest.io_tune) (set_io_limits guest) 0)) }{ -(with Guests guest (reset_io_limits guest)) -}) \ No newline at end of file +(with Guests guest (if (valid guest.io_tune) (reset_io_limits guest) 0)) +}) + -- To view, visit https://gerrit.ovirt.org/59988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I27162756b33441ab1962fca930a5459ff909fd81 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Martin Sivák ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: sla: Use GuestIoTuneOptional collector in MOM
Francesco Romani has posted comments on this change. Change subject: sla: Use GuestIoTuneOptional collector in MOM .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27162756b33441ab1962fca930a5459ff909fd81 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: sla: Use GuestIoTuneOptional collector in MOM
Francesco Romani has posted comments on this change. Change subject: sla: Use GuestIoTuneOptional collector in MOM .. Patch Set 1: let's wait for jenkins. -- To view, visit https://gerrit.ovirt.org/59988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27162756b33441ab1962fca930a5459ff909fd81 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: sla: Use GuestIoTuneOptional collector in MOM
Francesco Romani has posted comments on this change. Change subject: sla: Use GuestIoTuneOptional collector in MOM .. Patch Set 1: jenkins will not run tests for this change, so I'll do manually. -- To view, visit https://gerrit.ovirt.org/59988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27162756b33441ab1962fca930a5459ff909fd81 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: rpc: Use Suppressed class instead of logging workarounds
Hello Nir Soffer, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/59994 to review the following change. Change subject: rpc: Use Suppressed class instead of logging workarounds .. rpc: Use Suppressed class instead of logging workarounds We have got logging workarounds for getAllVmStats RPC calls. The workarounds are there to suppress logging large data regularly. We'd like to get rid of the workarounds, it's better to handle the large data in the API functions, where we can use specific handling of each kind of large data. This patch introduces a wrapper for large values, with the purpose of suppressing writing them to the log. The wrapper is used for getAllVmStats so that we get rid of the logging workarounds. There are other API calls that may produce large outputs, we will handle them in followup patches. Change-Id: Idaf00e557fccb8f08fa3aeb38d51cb4bbe0ffe53 Signed-off-by: Milan Zamazal Bug-Url: https://bugzilla.redhat.com/1351247 Backport-To: 4.0 Backport-To: 3.6 Reviewed-on: https://gerrit.ovirt.org/59078 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer --- M lib/api/vdsmapi.py M lib/vdsm/logUtils.py M lib/vdsm/rpc/bindingxmlrpc.py M lib/yajsonrpc/__init__.py M vdsm/API.py 5 files changed, 30 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/59994/1 diff --git a/lib/api/vdsmapi.py b/lib/api/vdsmapi.py old mode 100644 new mode 100755 index 73ce548..04a48b9 --- a/lib/api/vdsmapi.py +++ b/lib/api/vdsmapi.py @@ -27,6 +27,7 @@ import yaml from vdsm.config import config +from vdsm.logUtils import Suppressed from yajsonrpc import JsonRpcInvalidParamsError @@ -303,6 +304,8 @@ ret_args = self.get_ret_param(class_name, method_name) if ret_args: +if isinstance(ret, Suppressed): +ret = ret.value self._verify_type(ret_args.get('type'), ret, class_name, method_name) except JsonRpcInvalidParamsError: diff --git a/lib/vdsm/logUtils.py b/lib/vdsm/logUtils.py index 5a651c9..853889d 100644 --- a/lib/vdsm/logUtils.py +++ b/lib/vdsm/logUtils.py @@ -206,3 +206,16 @@ raise RuntimeError( "Attempt to open log with incorrect credentials") return logging.handlers.WatchedFileHandler._open(self) + + +class Suppressed(object): + +def __init__(self, value): +self._value = value + +@property +def value(self): +return self._value + +def __repr__(self): +return '(suppressed)' diff --git a/lib/vdsm/rpc/bindingxmlrpc.py b/lib/vdsm/rpc/bindingxmlrpc.py index 67f386a..2c4765a 100644 --- a/lib/vdsm/rpc/bindingxmlrpc.py +++ b/lib/vdsm/rpc/bindingxmlrpc.py @@ -34,6 +34,7 @@ from vdsm import utils from vdsm import xmlrpc from vdsm.define import doneCode, errCode +from vdsm.logUtils import Suppressed from vdsm.network.netinfo.addresses import getDeviceByIP import API from vdsm.exception import VdsmException @@ -1192,7 +1193,6 @@ def wrapper(*args, **kwargs): try: logLevel = logging.DEBUG -suppress_logging = f.__name__ in ('getAllVmStats',) suppress_args = f.__name__ in ('fenceNode',) # TODO: This password protection code is fragile and ugly. Password @@ -1239,9 +1239,14 @@ res = f(*args, **kwargs) else: res = errCode['recovery'] -log_res = "(suppressed)" if suppress_logging else res + f.__self__.cif.log.log(logLevel, 'return %s with %s', - f.__name__, log_res) + f.__name__, res) + +# Ugly hack, but this code is going to be deleted soon. +if isinstance(res.get('statsList'), Suppressed): +res['statsList'] = res['statsList'].value + return res except libvirt.libvirtError as e: f.__self__.cif.log.error("libvirt error", exc_info=True) diff --git a/lib/yajsonrpc/__init__.py b/lib/yajsonrpc/__init__.py index 6d1eaf7..71db724 100644 --- a/lib/yajsonrpc/__init__.py +++ b/lib/yajsonrpc/__init__.py @@ -21,6 +21,7 @@ from vdsm.compat import json +from vdsm.logUtils import Suppressed from vdsm.password import protect_passwords, unprotect_passwords from vdsm.utils import monotonic_time, traceback from vdsm.define import errCode @@ -469,8 +470,6 @@ class JsonRpcServer(object): log = logging.getLogger("jsonrpc.JsonRpcServer") -FILTERED_METHODS = frozenset(['Host.getAllVmStats']) - """ Creates new JsonrRpcServer by providing a bridge, timeout in seconds which defining how often we should log connections stats and thread @@ -504,7 +503,6 @@ def _serveRequest(self, ctx, req): self._attempt_log_stats() logLevel = logging.DEBUG -suppress_logging =
Change in vdsm[ovirt-4.0]: rpc: Log calls of API methods with possibly large results
Hello Nir Soffer, Francesco Romani, Michal Skrivanek, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/59993 to review the following change. Change subject: rpc: Log calls of API methods with possibly large results .. rpc: Log calls of API methods with possibly large results We can prevent some API methods from logging their excessively large results. But this doesn't mean we shouldn't log their calls at all, we just shouldn't log the large values. This patch re-enables logging calls of the methods with suppressed logging, it just disables logging their outputs. Change-Id: I85d7f0ceee7e120081e2d9ad4ca3c8148ee70554 Bug-Url: https://bugzilla.redhat.com/1351247 Backport-To: 4.0 Backport-To: 3.6 Signed-off-by: Milan Zamazal Reviewed-on: https://gerrit.ovirt.org/58464 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani Reviewed-by: Michal Skrivanek Reviewed-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/58709 Continuous-Integration: Francesco Romani --- M lib/vdsm/rpc/bindingxmlrpc.py M lib/yajsonrpc/__init__.py 2 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/59993/1 diff --git a/lib/vdsm/rpc/bindingxmlrpc.py b/lib/vdsm/rpc/bindingxmlrpc.py index 5cb7dff..67f386a 100644 --- a/lib/vdsm/rpc/bindingxmlrpc.py +++ b/lib/vdsm/rpc/bindingxmlrpc.py @@ -1192,8 +1192,7 @@ def wrapper(*args, **kwargs): try: logLevel = logging.DEBUG -if f.__name__ in ('getAllVmStats',): -logLevel = logging.TRACE +suppress_logging = f.__name__ in ('getAllVmStats',) suppress_args = f.__name__ in ('fenceNode',) # TODO: This password protection code is fragile and ugly. Password @@ -1240,8 +1239,9 @@ res = f(*args, **kwargs) else: res = errCode['recovery'] +log_res = "(suppressed)" if suppress_logging else res f.__self__.cif.log.log(logLevel, 'return %s with %s', - f.__name__, res) + f.__name__, log_res) return res except libvirt.libvirtError as e: f.__self__.cif.log.error("libvirt error", exc_info=True) diff --git a/lib/yajsonrpc/__init__.py b/lib/yajsonrpc/__init__.py index 1724a99..6d1eaf7 100644 --- a/lib/yajsonrpc/__init__.py +++ b/lib/yajsonrpc/__init__.py @@ -504,8 +504,7 @@ def _serveRequest(self, ctx, req): self._attempt_log_stats() logLevel = logging.DEBUG -if req.method in self.FILTERED_METHODS: -logLevel = logging.TRACE +suppress_logging = req.method in self.FILTERED_METHODS # VDSM should never respond to any request before all information about # running VMs is recovered, see https://bugzilla.redhat.com/1339291 @@ -544,8 +543,9 @@ req.id)) else: res = True if res is None else res +log_res = "(suppressed)" if suppress_logging else res self.log.log(logLevel, "Return '%s' in bridge with %s", - req.method, res) + req.method, log_res) ctx.requestDone(JsonRpcResponse(res, None, req.id)) @traceback(on=log.name) -- To view, visit https://gerrit.ovirt.org/59993 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I85d7f0ceee7e120081e2d9ad4ca3c8148ee70554 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: xmlrpc: Hide fenceNode password in the log
Hello Piotr Kliczewski, Nir Soffer, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/59991 to review the following change. Change subject: xmlrpc: Hide fenceNode password in the log .. xmlrpc: Hide fenceNode password in the log We enabled logging of fenceNode xmlrpc calls, however there is a plain password in the call parameters. This patch prevents the password from being written to the log. Password logging seems to be already handled with jsonrpc, so this patch just fixes xmlrpc. This patch doesn't change the actual behavior, but it is a preparation patch for the followup patches. Change-Id: I53318ed8ce425f042b5f783af779b540c1dfd7b5 Backport-To: 4.0 Backport-To: 3.6 Bug-Url: https://bugzilla.redhat.com/1351247 Signed-off-by: Milan Zamazal Reviewed-on: https://gerrit.ovirt.org/58833 Reviewed-by: Nir Soffer Continuous-Integration: Jenkins CI Reviewed-by: Piotr Kliczewski --- M lib/vdsm/rpc/bindingxmlrpc.py 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/59991/1 diff --git a/lib/vdsm/rpc/bindingxmlrpc.py b/lib/vdsm/rpc/bindingxmlrpc.py index d2f05fa..a1e32e7 100644 --- a/lib/vdsm/rpc/bindingxmlrpc.py +++ b/lib/vdsm/rpc/bindingxmlrpc.py @@ -1195,13 +1195,16 @@ if f.__name__ in ('getVMList', 'getAllVmStats', 'getStats', 'fenceNode', 'setKsmTune'): logLevel = logging.TRACE +suppress_args = f.__name__ in ('fenceNode',) # TODO: This password protection code is fragile and ugly. Password # protection should be done in the wrapped methods, and logging # shold be done in the next layers, similar to storage logs. displayArgs = args -if f.__name__ == 'vmDesktopLogin': +if suppress_args: +displayArgs = '(suppressed)' +elif f.__name__ == 'vmDesktopLogin': if 'password' in kwargs: raise TypeError("Got an unexpected keyword argument: " "'password'") -- To view, visit https://gerrit.ovirt.org/59991 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I53318ed8ce425f042b5f783af779b540c1dfd7b5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: logging: Introduce throttledlog
Hello Piotr Kliczewski, Nir Soffer, Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/59995 to review the following change. Change subject: logging: Introduce throttledlog .. logging: Introduce throttledlog In some situations, we want to log interesting information. A natural place to retrieve and log the information is where it is created. However the corresponding code may be called quite often and we don't need logging the information that often and fill logs with it excessively. It's sufficient to log it just from time to time. This patch provides means for occasional logging. The provided functions actually log only every given number of invocations or every given time span. We're going to use the functionality in followup patches. Change-Id: Ief96f74eb84880827ccf24c3e7ae854403090b8a Signed-off-by: Milan Zamazal Bug-Url: https://bugzilla.redhat.com/1351247 Reviewed-on: https://gerrit.ovirt.org/59461 Continuous-Integration: Jenkins CI Reviewed-by: Piotr Kliczewski Reviewed-by: Francesco Romani Reviewed-by: Nir Soffer --- M lib/vdsm/Makefile.am A lib/vdsm/throttledlog.py M tests/Makefile.am A tests/throttledlog_test.py M vdsm.spec.in 5 files changed, 201 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/59995/1 diff --git a/lib/vdsm/Makefile.am b/lib/vdsm/Makefile.am index 3fb3a65..c49ee61 100644 --- a/lib/vdsm/Makefile.am +++ b/lib/vdsm/Makefile.am @@ -60,6 +60,7 @@ supervdsm.py \ sysctl.py \ taskset.py \ + throttledlog.py \ udevadm.py \ utils.py \ v2v.py \ diff --git a/lib/vdsm/throttledlog.py b/lib/vdsm/throttledlog.py new file mode 100644 index 000..04cc104 --- /dev/null +++ b/lib/vdsm/throttledlog.py @@ -0,0 +1,113 @@ +# +# Copyright 2016 Red Hat, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA +# +# Refer to the README and COPYING files for full details of the license +# +from __future__ import absolute_import + +import logging + +from vdsm.utils import monotonic_time + + +_DEFAULT_TIMEOUT_SEC = 3600 +_DEFAULT_LOGGING_LEVEL = logging.DEBUG + +_logger = logging.getLogger('throttled') + +_periodic = {} + + +class _Periodic(object): + +def __init__(self, interval, timeout): +self._interval = interval +self._timeout = timeout +self._counter = 0 +self._last_time = 0 + +def tick(self): +now = monotonic_time() +result = self._result(now) +self._counter = (self._counter + 1) % self._interval +if result: +self._last_time = now +return result + +def _result(self, now): +return (self._counter == 0 or +(now - self._last_time) >= self._timeout) + + +def throttle(name, interval, timeout=_DEFAULT_TIMEOUT_SEC): +""" +Throttle log messages for `name`, logging at most one message per +`interval` calls or always after `timeout` seconds of silence. Throttling +applies only to logging performed via `log()` function of this module. The +first call of `log()` never throttles the log, following calls are +throttled according to the given parameters. + +If this function has already been called for `name`, replace the throttling +parameters for `name` with the new ones given here and start throttling +from beginning. + +:param name: Arbitrary identifier to be matched in `log()` calls. +:type name: basestring +:param interval: The number of `log()` calls that should log at least once. +:type interval: int +:param timeout: The number of seconds without log emitted after which + `log()` should always unthrottle the next message. +:type timeout: int +""" +_periodic[name] = _Periodic(interval, timeout) + + +def log(name, level, message, *args): +""" +Log `message` and `args` if throttling settings for `name` allow it. +See `throttle()` for information about throttling and `name`. +`level`, `message` and `args` are passed to `logging.Logger.log()` +unchanged. + +:param name: Arbitrary identifier to be matched by `throttle()` settings. +:type name: basestring + +.. note:: + + Depending on throttling settings and
Change in vdsm[ovirt-4.0]: sampling: periodic: improve logging
Hello Dan Kenigsberg, Francesco Romani, Martin Polednik, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/59996 to review the following change. Change subject: sampling: periodic: improve logging .. sampling: periodic: improve logging We received reports of incorrect monitoring, e.g. VMs set unresponsive, or periodic monitoring being slow to get back to normal after a disruption. Analysis of post-mortem logs provided nothing conclusive; actually Vdsm seems to have reacted well under the disruption. Still, we want to make sure everything is right. This patch refactors the bulk stats sampling logging, to add more information and to move it outside the critical section. We know logging is a controversial matter. Too much logging is unpractical and taxing over the host. Too little logging makes troubleshooting very hard, especially for monitoring issues that are most often detected and reported much after the incident happen. We still log once per operation, so four entries per minute, which is definitely bearable. Change-Id: I1e52a9c356be212ec72aace0f8d8aa5f1580ccb3 Bug-Url: https://bugzilla.redhat.com/1351247 Backport-To: 4.0 Backport-To: 3.6 Signed-off-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/58972 Reviewed-by: Milan Zamazal Reviewed-by: Martin Polednik Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M lib/vdsm/virt/sampling.py 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/59996/1 diff --git a/lib/vdsm/virt/sampling.py b/lib/vdsm/virt/sampling.py index b49666b..4cfd3b1 100644 --- a/lib/vdsm/virt/sampling.py +++ b/lib/vdsm/virt/sampling.py @@ -485,11 +485,13 @@ self._log = logging.getLogger("virt.sampling.VMBulkSampler") def __call__(self): +log_status = True timestamp = self._stats_cache.clock() acquired = self._sampling.acquire(blocking=False) # we are deep in the hot path. bool(ExpiringCache) # *is* costly so we should avoid it if we can. fast_path = acquired and not self._skip_doms +doms = [] # whitelist, meaningful only in the slow path try: if fast_path: # This is expected to be the common case. @@ -499,7 +501,6 @@ # A previous call got stuck, or not every domain # has properly recovered. Thus we must whitelist domains. doms = self._get_responsive_doms() -self._log.debug('sampling %d domains', len(doms)) if doms: bulk_stats = self._conn.domainListGetStats( doms, self._stats_flags) @@ -507,11 +508,17 @@ bulk_stats = [] except Exception: self._log.exception("vm sampling failed") +log_status = False else: self._stats_cache.put(_translate(bulk_stats), timestamp) finally: if acquired: self._sampling.release() +if log_status: +self._log.debug( +'sampled timestamp %r elapsed %.3f acquired %r domains %s', +timestamp, self._stats_cache.clock() - timestamp, acquired, +'all' if fast_path else len(doms)) def _get_responsive_doms(self): vms = self._get_vms() -- To view, visit https://gerrit.ovirt.org/59996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1e52a9c356be212ec72aace0f8d8aa5f1580ccb3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: rpc: Log RPC call summary on info level
Hello Piotr Kliczewski, Nir Soffer, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/59998 to review the following change. Change subject: rpc: Log RPC call summary on info level .. rpc: Log RPC call summary on info level We currently log relatively detailed information about all RPC calls. This information is logged on the debug level. We are going to switch to the info logging level sometimes in future and then information about RPC calls won't be logged anymore. But we still want to see some very basic information about the RPC calls, such as that they were performed and how much time they took. This patch adds the corresponding logging. We additionally add the response to the context at a single place as a preparation for the following patch that logs the response. Change-Id: Idde2f1ba7394f16770543f5ca13411e8c2339cc6 Bug-Url: https://bugzilla.redhat.com/1351247 Backport-To: 4.0 Signed-off-by: Milan Zamazal Reviewed-on: https://gerrit.ovirt.org/59080 Reviewed-by: Nir Soffer Reviewed-by: Piotr Kliczewski Continuous-Integration: Jenkins CI --- M lib/vdsm/rpc/bindingxmlrpc.py M lib/yajsonrpc/__init__.py 2 files changed, 26 insertions(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/59998/1 diff --git a/lib/vdsm/rpc/bindingxmlrpc.py b/lib/vdsm/rpc/bindingxmlrpc.py index 2c4765a..732918f 100644 --- a/lib/vdsm/rpc/bindingxmlrpc.py +++ b/lib/vdsm/rpc/bindingxmlrpc.py @@ -302,6 +302,8 @@ def _registerFunctions(self): def wrapIrsMethod(f): def wrapper(*args, **kwargs): +start_time = utils.monotonic_time() + fmt = "" logargs = [] @@ -321,6 +323,10 @@ except: self.log.error("Unexpected exception", exc_info=True) return errCode['unexpected'] +finally: +self.log.info("RPC call %s finished in %.2f seconds", + f.__name__, + utils.monotonic_time() - start_time) wrapper.__name__ = f.__name__ wrapper.__doc__ = f.__doc__ @@ -1191,6 +1197,7 @@ def wrapApiMethod(f): def wrapper(*args, **kwargs): +start_time = utils.monotonic_time() try: logLevel = logging.DEBUG suppress_args = f.__name__ in ('fenceNode',) @@ -1260,6 +1267,10 @@ except: f.__self__.cif.log.error("unexpected error", exc_info=True) return errCode['unexpected'] +finally: +f.__self__.cif.log.info("RPC call %s finished in %.2f seconds", +f.__name__, +utils.monotonic_time() - start_time) wrapper.__name__ = f.__name__ wrapper.__doc__ = f.__doc__ return wrapper diff --git a/lib/yajsonrpc/__init__.py b/lib/yajsonrpc/__init__.py index 71db724..ff8e4ae 100644 --- a/lib/yajsonrpc/__init__.py +++ b/lib/yajsonrpc/__init__.py @@ -501,6 +501,14 @@ self._counter = 0 def _serveRequest(self, ctx, req): +start_time = monotonic_time() +response = self._handle_request(req, ctx.server_address) +self.log.info("RPC call %s finished in %.2f seconds", + req.method, monotonic_time() - start_time) +if response is not None: +ctx.requestDone(response) + +def _handle_request(self, req, server_address): self._attempt_log_stats() logLevel = logging.DEBUG @@ -510,8 +518,7 @@ self.log.info("In recovery, ignoring '%s' in bridge with %s", req.method, req.params) # TODO: take the response from the exception instead of via errCode -ctx.requestDone(JsonRpcResponse(errCode['recovery'], None, req.id)) -return +return JsonRpcResponse(errCode['recovery'], None, req.id) self.log.log(logLevel, "Calling '%s' in bridge with %s", req.method, req.params) @@ -519,32 +526,29 @@ method = self._bridge.dispatch(req.method) except JsonRpcMethodNotFoundError as e: if req.isNotification(): -return +return None -ctx.requestDone(JsonRpcResponse(None, e, req.id)) -return +return JsonRpcResponse(None, e, req.id) try: params = req.params -self._bridge.register_server_address(ctx.server_address) +self._bridge.register_server_address(server_address) if isinstance(req.params, list): res = method(*params) else: res = method(**params) self._bridge.unregister_server_address() except JsonRpcError as e: -ctx.requestDone(JsonRpcResponse(None, e, req.id)) +
Change in vdsm[ovirt-4.0]: rpc: Log important info from VM stats
Hello Nir Soffer, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/59997 to review the following change. Change subject: rpc: Log important info from VM stats .. rpc: Log important info from VM stats Currently, we don't log results of getAllVmStats API calls. This is not to fill logs with a lot of uninteresting information. But information contained in the VM stats is useful and we'd like to have it somewhere. A possible solution to these contradictory requirements is to log just important information and to log it only occasionally. In this patch, we introduce logging VM ids and states in getAllVmStats calls from time to time. We implement this as a rather general functionality. We are going to use the same mechanism for other large API outputs in followup patches. There may be performance concerns but please consider that we perform data extraction only for calls that are global (not per VM) and that are not very frequent (like every second or so). So the processing overhead shouldn't hurt much and shouldn't be much big in comparison to creating the returned data inside Vdsm. Change-Id: Ifcbac615323b62fb9a27e5c0f5a4e98990076146 Signed-off-by: Milan Zamazal Bug-Url: https://bugzilla.redhat.com/1351247 Backport-To: 4.0 Backport-To: 3.6 Reviewed-on: https://gerrit.ovirt.org/58465 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer --- M lib/vdsm/logUtils.py M tests/Makefile.am A tests/logutils_test.py M vdsm/API.py 4 files changed, 54 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/59997/1 diff --git a/lib/vdsm/logUtils.py b/lib/vdsm/logUtils.py index 853889d..3794edd 100644 --- a/lib/vdsm/logUtils.py +++ b/lib/vdsm/logUtils.py @@ -219,3 +219,9 @@ def __repr__(self): return '(suppressed)' + + +class AllVmStatsValue(Suppressed): + +def __repr__(self): +return repr({vm.get('vmId'): vm.get('status') for vm in self._value}) diff --git a/tests/Makefile.am b/tests/Makefile.am index db35bdd..d9ffbf7 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -76,6 +76,7 @@ iscsiTests.py \ jobsTests.py \ libvirtconnectionTests.py \ + logutils_test.py \ lvmTests.py \ main.py \ miscTests.py \ diff --git a/tests/logutils_test.py b/tests/logutils_test.py new file mode 100644 index 000..ba9ef41 --- /dev/null +++ b/tests/logutils_test.py @@ -0,0 +1,40 @@ +# +# Copyright 2016 Red Hat, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA +# +# Refer to the README and COPYING files for full details of the license +# + +from vdsm.logUtils import AllVmStatsValue + +from testlib import VdsmTestCase as TestCaseBase + + +class TestAllVmStats(TestCaseBase): + +_STATS = [{'foo': 'bar', + 'status': 'Up', + 'vmId': u'43f02a2d-e563-4f11-a7bc-9ee191cfeba1'}, + {'foo': 'bar', + 'status': 'Powering up', + 'vmId': u'bd0d066b-971e-42f8-8bc6-d647ab7e0e70'}] +_SIMPLIFIED = ({u'43f02a2d-e563-4f11-a7bc-9ee191cfeba1': 'Up', +u'bd0d066b-971e-42f8-8bc6-d647ab7e0e70': 'Powering up'}) + +def test_allvmstats(self): +data = AllVmStatsValue(self._STATS) +result = str(data) +self.assertEqual(eval(result), self._SIMPLIFIED) diff --git a/vdsm/API.py b/vdsm/API.py index 753f6be..9d8f8ab 100644 --- a/vdsm/API.py +++ b/vdsm/API.py @@ -34,10 +34,11 @@ from vdsm import hostdev from vdsm import response from vdsm import supervdsm +from vdsm import throttledlog from vdsm import jobs from vdsm import v2v from vdsm.host import api as hostapi -from vdsm.logUtils import Suppressed +from vdsm.logUtils import AllVmStatsValue, Suppressed from vdsm.storage import clusterlock from vdsm.storage import misc from vdsm.storage import constants as sc @@ -64,6 +65,9 @@ # default message for system shutdown, will be displayed in guest USER_SHUTDOWN_MESSAGE = 'System going down' + + +throttledlog.throttle('getAllVmStats', 100) def updateTimestamp(): @@ -1343,6 +1347,8 @@ hooks.before_get_all_vm_stats() statsList = self._cif.getAllVmStats() statsList = hooks.after_get_all_vm_stats(statsList) +throttl
Change in vdsm[ovirt-4.0]: rpc: Log also error codes of RPC calls
Hello Piotr Kliczewski, Nir Soffer, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/5 to review the following change. Change subject: rpc: Log also error codes of RPC calls .. rpc: Log also error codes of RPC calls In one of the previous commits, we added logging of RPC calls on info level. It'd be useful to have information about response codes there, so this patch adds that information. Change-Id: I776e667fcfd1a20a9ef5f6c638d6c3d950672314 Bug-Url: https://bugzilla.redhat.com/1351247 Backport-To: 4.0 Signed-off-by: Milan Zamazal Reviewed-on: https://gerrit.ovirt.org/59234 Reviewed-by: Nir Soffer Reviewed-by: Piotr Kliczewski Continuous-Integration: Jenkins CI --- M lib/vdsm/rpc/bindingxmlrpc.py M lib/yajsonrpc/__init__.py 2 files changed, 27 insertions(+), 13 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/5/1 diff --git a/lib/vdsm/rpc/bindingxmlrpc.py b/lib/vdsm/rpc/bindingxmlrpc.py index 732918f..c60e204 100644 --- a/lib/vdsm/rpc/bindingxmlrpc.py +++ b/lib/vdsm/rpc/bindingxmlrpc.py @@ -318,15 +318,18 @@ self.log.debug(fmt, *logargs) +res = {} try: -return f(*args, **kwargs) +res = f(*args, **kwargs) except: self.log.error("Unexpected exception", exc_info=True) -return errCode['unexpected'] -finally: -self.log.info("RPC call %s finished in %.2f seconds", - f.__name__, - utils.monotonic_time() - start_time) +res = errCode['unexpected'] +self.log.info("RPC call %s finished (code=%s) in " + "%.2f seconds", + f.__name__, + res.get('status', {}).get('code'), + utils.monotonic_time() - start_time) +return res wrapper.__name__ = f.__name__ wrapper.__doc__ = f.__doc__ @@ -1198,6 +1201,7 @@ def wrapApiMethod(f): def wrapper(*args, **kwargs): start_time = utils.monotonic_time() +res = {} try: logLevel = logging.DEBUG suppress_args = f.__name__ in ('fenceNode',) @@ -1258,18 +1262,23 @@ except libvirt.libvirtError as e: f.__self__.cif.log.error("libvirt error", exc_info=True) if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN: -return errCode['noVM'] +res = errCode['noVM'] else: -return errCode['unexpected'] +res = errCode['unexpected'] +return res except VdsmException as e: f.__self__.cif.log.error("vdsm exception occured", exc_info=True) -return e.response() +res = e.response() +return res except: f.__self__.cif.log.error("unexpected error", exc_info=True) -return errCode['unexpected'] +res = errCode['unexpected'] +return res finally: -f.__self__.cif.log.info("RPC call %s finished in %.2f seconds", +f.__self__.cif.log.info("RPC call %s finished (code=%s) in " +"%.2f seconds", f.__name__, +res.get('status', {}).get('code'), utils.monotonic_time() - start_time) wrapper.__name__ = f.__name__ wrapper.__doc__ = f.__doc__ diff --git a/lib/yajsonrpc/__init__.py b/lib/yajsonrpc/__init__.py index ff8e4ae..3583dff 100644 --- a/lib/yajsonrpc/__init__.py +++ b/lib/yajsonrpc/__init__.py @@ -503,8 +503,13 @@ def _serveRequest(self, ctx, req): start_time = monotonic_time() response = self._handle_request(req, ctx.server_address) -self.log.info("RPC call %s finished in %.2f seconds", - req.method, monotonic_time() - start_time) +error = getattr(response, "error", None) +if error is None: +response_log = "succeeded" +else: +response_log = "failed (error %s)" % (error.code,) +self.log.info("RPC call %s %s in %.2f seconds", + req.method, response_log, monotonic_time() - start_time) if response is not None: ctx.requestDone(response) -- To view, visit https://gerrit.ovirt.org/5 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I776e667fcfd1a20a9ef5f6c638d6c3d950672314 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski
Change in vdsm[ovirt-4.0]: rpc: Lower logging priority just for getAllVmStats
Hello Piotr Kliczewski, Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/59992 to review the following change. Change subject: rpc: Lower logging priority just for getAllVmStats .. rpc: Lower logging priority just for getAllVmStats Currently, we effectively disable logging of calls for several methods. But we should consider whether it causes more harm to log the corresponding information or not to log it. We should avoid logging excessively large messages. This applies to getAllVmStats that may report quite a lot of information for many VMs. But there is probably no good reason not to log everything about the other methods currently silenced. So with this patch we suppress logging just of getAllVmStats. We should be informed about that method as well, we handle that in followup patches. Change-Id: I5eefac9f88ede84df06c0cc39b188c8ae75e456b Bug-Url: https://bugzilla.redhat.com/1351247 Backport-To: 4.0 Backport-To: 3.6 Signed-off-by: Milan Zamazal Reviewed-on: https://gerrit.ovirt.org/58463 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani Reviewed-by: Piotr Kliczewski Reviewed-on: https://gerrit.ovirt.org/58708 Continuous-Integration: Francesco Romani --- M lib/vdsm/rpc/bindingxmlrpc.py M lib/yajsonrpc/__init__.py 2 files changed, 2 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/59992/1 diff --git a/lib/vdsm/rpc/bindingxmlrpc.py b/lib/vdsm/rpc/bindingxmlrpc.py index a1e32e7..5cb7dff 100644 --- a/lib/vdsm/rpc/bindingxmlrpc.py +++ b/lib/vdsm/rpc/bindingxmlrpc.py @@ -1192,8 +1192,7 @@ def wrapper(*args, **kwargs): try: logLevel = logging.DEBUG -if f.__name__ in ('getVMList', 'getAllVmStats', 'getStats', - 'fenceNode', 'setKsmTune'): +if f.__name__ in ('getAllVmStats',): logLevel = logging.TRACE suppress_args = f.__name__ in ('fenceNode',) diff --git a/lib/yajsonrpc/__init__.py b/lib/yajsonrpc/__init__.py index ec3b5ed..1724a99 100644 --- a/lib/yajsonrpc/__init__.py +++ b/lib/yajsonrpc/__init__.py @@ -469,9 +469,7 @@ class JsonRpcServer(object): log = logging.getLogger("jsonrpc.JsonRpcServer") -FILTERED_METHODS = frozenset(['Host.getVMList', 'Host.getAllVmStats', - 'Host.getStats', 'StorageDomain.getStats', - 'VM.getStats', 'Host.fenceNode']) +FILTERED_METHODS = frozenset(['Host.getAllVmStats']) """ Creates new JsonrRpcServer by providing a bridge, timeout in seconds -- To view, visit https://gerrit.ovirt.org/59992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5eefac9f88ede84df06c0cc39b188c8ae75e456b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: sampling: periodic: improve logging
Milan Zamazal has abandoned this change. Change subject: sampling: periodic: improve logging .. Abandoned Inserted by mistake. -- To view, visit https://gerrit.ovirt.org/59996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I1e52a9c356be212ec72aace0f8d8aa5f1580ccb3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: sla: Use GuestIoTuneOptional collector in MOM
Francesco Romani has posted comments on this change. Change subject: sla: Use GuestIoTuneOptional collector in MOM .. Patch Set 1: Continuous-Integration+1 succesfully built rpms on fc23, centos 7.2, rhel 7.2 -- To view, visit https://gerrit.ovirt.org/59988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27162756b33441ab1962fca930a5459ff909fd81 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: flush IP config from attached nics
Edward Haas has posted comments on this change. Change subject: ovs: flush IP config from attached nics .. Patch Set 5: Code-Review-1 (5 comments) https://gerrit.ovirt.org/#/c/59958/4/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py: PS4, Line 205: remov Better be consistent and use 'remove'. PS4, Line 205: but it is not only nics, perhaps ifaces will fit better here. Line 203: Line 204: Line 205: def _remove_dhcp_config(iface): Line 206: dhclient.stop(iface) Line 207: It will be better moving it to the module scope as private, there is no need to create an instance of it each time the outer function is called. Line 208: Line 209: def _flush_ip_config_from_used_nics(netinfo_bonds, netinfo_nics, attrs): Line 210: Line 211: def flush_nic_ip(nic): PS4, Line 209: def _flush_ip_config_from_used_nics(netinfo_bonds, netinfo_nics, attrs): : : def flush_nic_ip(nic): : nic_info = netinfo_nics[nic] Why not just flush all? The you will not need nic_info Line 214: _flush_ip_config(nic, family=4) Line 215: if nic_info['ipv6address']: Line 216: _flush_ip_config(nic, family=6) Line 217: Line 218: nic = attrs.get('nic') If there is a bond and there are IP settings on its slaves, we have a corrupted system. However, an IP may exist on the bond itself. Bottom line, lets try and avoid netinfo here. Line 219: bond = attrs.get('bonding') Line 220: if nic: Line 221: flush_nic_ip(nic) Line 222: elif bond: -- To view, visit https://gerrit.ovirt.org/59958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66e0be6ea8583fae1814bb8fc776dd243932b192 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: flush IP config from attached nics
Edward Haas has posted comments on this change. Change subject: ovs: flush IP config from attached nics .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/59958/5/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py: Line 226: flush_nic_ip(nic) Line 227: Line 228: Line 229: def _flush_ip_config(iface, family): Line 230: dhclient.kill(iface, family) # kills dhclient and flushes IP What about static IP/s? Line 231: Line 232: Line 233: def _set_dhcp_config(iface, attrs): Line 234: # TODO: DHCPv6 -- To view, visit https://gerrit.ovirt.org/59958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66e0be6ea8583fae1814bb8fc776dd243932b192 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: sla: Use GuestIoTuneOptional collector in MOM
Francesco Romani has posted comments on this change. Change subject: sla: Use GuestIoTuneOptional collector in MOM .. Patch Set 1: correction: mom 0.5.5 is not yet available on RHEL. -- To view, visit https://gerrit.ovirt.org/59988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27162756b33441ab1962fca930a5459ff909fd81 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: sla: Use GuestIoTuneOptional collector in MOM
Francesco Romani has submitted this change and it was merged. Change subject: sla: Use GuestIoTuneOptional collector in MOM .. sla: Use GuestIoTuneOptional collector in MOM All major collectors in MOM now have the optional variant that makes sure the VM can be processed even when some of the functionality is missing. The IoTune collector was the last one affected by this. Change-Id: I27162756b33441ab1962fca930a5459ff909fd81 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1348263 Signed-off-by: Martin Sivak Reviewed-on: https://gerrit.ovirt.org/59936 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani Reviewed-by: Dan Kenigsberg (cherry picked from commit a030644e6ba0c05b438f80c59c451839adffb353) Reviewed-on: https://gerrit.ovirt.org/59988 Continuous-Integration: Francesco Romani --- M vdsm.spec.in M vdsm/mom.conf.in M vdsm/mom.d/05-iotune.policy 3 files changed, 6 insertions(+), 5 deletions(-) Approvals: Martin Sivák: Verified Francesco Romani: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/59988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27162756b33441ab1962fca930a5459ff909fd81 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: migration: wait for monitor thread before to exit
Martin Polednik has posted comments on this change. Change subject: migration: wait for monitor thread before to exit .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie36925992e083864c0320f810bce3824466dc7ce Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: migration: make MonitorThread own DowntimeThread
Martin Polednik has posted comments on this change. Change subject: migration: make MonitorThread own DowntimeThread .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57933 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ed5a95dcd8576d0391df175f43cd4677b24e57a Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: migration: early exit when stopped
Martin Polednik has posted comments on this change. Change subject: migration: early exit when stopped .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57935 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2def07d6907467347838824d71a4a16b9929266d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: migration: downtime: handle steps=1
Martin Polednik has posted comments on this change. Change subject: migration: downtime: handle steps=1 .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59218 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb99e617d227e8043a1e99f0e8b1040e02a9b7e3 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: migration: track qemu iterations
Martin Polednik has posted comments on this change. Change subject: migration: track qemu iterations .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59219 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f87c954031842c35c99888c228a34ec7f19d800 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: wip: py3: port storage misc.py file to python3
Irit Goihman has uploaded a new change for review. Change subject: wip: py3: port storage misc.py file to python3 .. wip: py3: port storage misc.py file to python3 Change-Id: I1adec40146967965329024718c6ff48d0fa089fb Signed-off-by: Irit Goihman --- M lib/vdsm/storage/misc.py 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/60001/1 diff --git a/lib/vdsm/storage/misc.py b/lib/vdsm/storage/misc.py index 173d608..162570e 100644 --- a/lib/vdsm/storage/misc.py +++ b/lib/vdsm/storage/misc.py @@ -33,7 +33,6 @@ import inspect import logging import os -import Queue import random import re import signal @@ -46,7 +45,8 @@ from array import array from collections import defaultdict from functools import wraps, partial -from itertools import chain, imap +from itertools import chain +from six.moves import queue, map, range from vdsm import commands from vdsm import concurrent @@ -69,7 +69,7 @@ def namedtuple2dict(nt): -return dict(imap(lambda f: (f, getattr(nt, f)), nt._fields)) +return dict(map(lambda f: (f, getattr(nt, f)), nt._fields)) class _LogSkip(object): @@ -95,7 +95,7 @@ def logskip(var): -if isinstance(var, types.StringTypes): +if isinstance(var, (str,)): return lambda func: _LogSkip.wrap(func, var) return _LogSkip.wrap(var, None) @@ -423,7 +423,7 @@ Raises InvalidParameterException if value is not a string or if it could not be converted to integer. """ -if not isinstance(size, basestring): +if not isinstance(size, six.string_types): log.error("Number of sectors as int is not supported, use size in " "bytes as string") raise se.InvalidParameterException("size", size) @@ -669,7 +669,7 @@ if maxthreads < 1 and maxthreads != UNLIMITED_THREADS: raise ValueError("Wrong input to function itmap: %s", maxthreads) -respQueue = Queue.Queue() +respQueue = queue.Queue() def wrapper(value): try: @@ -699,7 +699,7 @@ maxthreads -= 1 # waiting for rest threads to end -for i in xrange(threadsCount): +for i in range(threadsCount): yield respQueue.get() -- To view, visit https://gerrit.ovirt.org/60001 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1adec40146967965329024718c6ff48d0fa089fb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: migration: downtime: start thread after 1st iter
Martin Polednik has posted comments on this change. Change subject: migration: downtime: start thread after 1st iter .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59220 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I661c44d9dd7bdb9f1ec3a355038cfa8966946011 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: migration: downtime: update step delay computation
Martin Polednik has posted comments on this change. Change subject: migration: downtime: update step delay computation .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72ef8dc43e2143b7eb36f65ceb20f4b7ac919c5a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: client: use representation object
Tomas Jelinek has posted comments on this change. Change subject: client: use representation object .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/59827 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3492c104e726867dd75488a475202789277e8914 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonrpc: recovery error passed as response
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: recovery error passed as response .. Patch Set 1: Verified+1 Thanks to Dan's and Franceso's help I checked and the code and message is properly send to the engine. -- To view, visit https://gerrit.ovirt.org/59948 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87ca49c91f1705abe55e044980442faf61b0ed22 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: HACK: DONTMERGE: make the recovery slower
Francesco Romani has posted comments on this change. Change subject: HACK: DONTMERGE: make the recovery slower .. Patch Set 1: Code-Review-2 we should never merge this. -- To view, visit https://gerrit.ovirt.org/59987 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieaa1672c7184aab43b15d4c63680bcd50fac6099 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: HACK: DONTMERGE: make the recovery slower
Francesco Romani has uploaded a new change for review. Change subject: HACK: DONTMERGE: make the recovery slower .. HACK: DONTMERGE: make the recovery slower *** DONTMERGE *** Artificially delay recovery to make testing of real patches fixing real bugs easier. Change-Id: Ieaa1672c7184aab43b15d4c63680bcd50fac6099 Signed-off-by: Francesco Romani --- M vdsm/clientIF.py 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/59987/1 diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py index 1147e36..8996c0c 100644 --- a/vdsm/clientIF.py +++ b/vdsm/clientIF.py @@ -474,6 +474,8 @@ recovery.clean_vm_files(self) +time.sleep(30.) + self._recovery = False # Now if we have VMs to restore we should wait pool connection -- To view, visit https://gerrit.ovirt.org/59987 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieaa1672c7184aab43b15d4c63680bcd50fac6099 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: spec: Require lvm version fixing filter
Hello Dan Kenigsberg, Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/60004 to review the following change. Change subject: spec: Require lvm version fixing filter .. spec: Require lvm version fixing filter Older lvm version was using filter incorrectly when running commands such as vgck and pvs. Instead of rejecting all the devices in the filter, the commands opened and scanned all block devices. This slow down these commands on systems with lot of block devices. On 3.6, lvm slowdowns cause delays in storage monitoring and may cause a host to become non-operational. These delays may also cause storage operations such as copying disks to fail with a timeout. On 4.0, these slowdowns may cause unwanted delays in various flows, but are not harmful to storage monitoring. Fedora 23 and later already include this fix (lvm2-2.02.132-2.fc23). Change-Id: I24040df9e19b4a093ce7e4f954375017f694099f Bug-Url: https://bugzilla.redhat.com/1346012 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/59907 Reviewed-by: Francesco Romani Reviewed-by: Dan Kenigsberg --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/60004/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index 6f6ac60..3fe8094 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -214,7 +214,7 @@ Requires: e2fsprogs Requires: fence-agents-all Requires: kernel >= 3.10.0-327.18.1.el7 -Requires: lvm2 >= 2.02.130-2 +Requires: lvm2 >= 7:2.02.130-5.el7_2.5 Requires: python >= 2.7.5-18.el7_1.1 Requires: policycoreutils-python Requires: selinux-policy-targeted >= 3.13.1-16.el7 -- To view, visit https://gerrit.ovirt.org/60004 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I24040df9e19b4a093ce7e4f954375017f694099f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonrpc: recovery error passed as response
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: recovery error passed as response .. Patch Set 1: Verified+1 verified by QE and us. -- To view, visit https://gerrit.ovirt.org/59948 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87ca49c91f1705abe55e044980442faf61b0ed22 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonrpc: recovery error passed as response
Francesco Romani has posted comments on this change. Change subject: jsonrpc: recovery error passed as response .. Patch Set 2: Code-Review+1 nice catch -- To view, visit https://gerrit.ovirt.org/59948 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87ca49c91f1705abe55e044980442faf61b0ed22 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: spec: Require lvm version fixing filter
Hello Dan Kenigsberg, Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/60005 to review the following change. Change subject: spec: Require lvm version fixing filter .. spec: Require lvm version fixing filter Older lvm version was using filter incorrectly when running commands such as vgck and pvs. Instead of rejecting all the devices in the filter, the commands opened and scanned all block devices. This slow down these commands on systems with lot of block devices. On 3.6, lvm slowdowns cause delays in storage monitoring and may cause a host to become non-operational. These delays may also cause storage operations such as copying disks to fail with a timeout. On 4.0, these slowdowns may cause unwanted delays in various flows, but are not harmful to storage monitoring. Fedora 23 and later already include this fix (lvm2-2.02.132-2.fc23). Change-Id: I24040df9e19b4a093ce7e4f954375017f694099f Bug-Url: https://bugzilla.redhat.com/1346012 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/59907 Reviewed-by: Francesco Romani Reviewed-by: Dan Kenigsberg --- M vdsm.spec.in 1 file changed, 1 insertion(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/05/60005/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index 5c22f4d..1ae3cdb 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -187,12 +187,7 @@ Requires: e2fsprogs Requires: fence-agents-all Requires: kernel >= 3.10.0-327.18.1.el7 -%if 0%{?centos} -# TODO: Remove when lvm2 2.02.130 is available -Requires: lvm2 >= 2.02.107 -%else -Requires: lvm2 >= 2.02.130-2 -%endif +Requires: lvm2 >= 7:2.02.130-5.el7_2.5 Requires: python >= 2.7.5-18.el7_1.1 Requires: policycoreutils-python Requires: selinux-policy-targeted >= 3.13.1-16.el7 -- To view, visit https://gerrit.ovirt.org/60005 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I24040df9e19b4a093ce7e4f954375017f694099f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonrpc: recovery error passed as response
Francesco Romani has posted comments on this change. Change subject: jsonrpc: recovery error passed as response .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59948 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87ca49c91f1705abe55e044980442faf61b0ed22 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: spec: Require lvm version fixing filter
Nir Soffer has posted comments on this change. Change subject: spec: Require lvm version fixing filter .. Patch Set 1: Verified+1 Verified on master. -- To view, visit https://gerrit.ovirt.org/60004 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24040df9e19b4a093ce7e4f954375017f694099f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonrpc: recovery error passed as response
Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonrpc: recovery error passed as response .. jsonrpc: recovery error passed as response When we notice that vdsm is in recovery mode we return information about recovery as result instead of returning error. Backport-To: 4.0 Backport-To: 3.6 Change-Id: I87ca49c91f1705abe55e044980442faf61b0ed22 Signed-off-by: Piotr Kliczewski Bug-Url: https://bugzilla.redhat.com/1350763 Reviewed-on: https://gerrit.ovirt.org/59948 Reviewed-by: Oved Ourfali Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani --- M lib/yajsonrpc/__init__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59948 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87ca49c91f1705abe55e044980442faf61b0ed22 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: spec: Require lvm version fixing filter
Nir Soffer has posted comments on this change. Change subject: spec: Require lvm version fixing filter .. Patch Set 1: Verified+1 Verified on master. -- To view, visit https://gerrit.ovirt.org/60005 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24040df9e19b4a093ce7e4f954375017f694099f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: move dhclient_run/stop helpers to dhclient.py
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: move dhclient_run/stop helpers to dhclient.py .. net: move dhclient_run/stop helpers to dhclient.py dhclient.py will be moved to ip module in the next patch. Change-Id: Ib26ef12a7af7067d1b3b9105ce0173c36eecbb22 Bug-Url: https://bugzilla.redhat.com/1195208 Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/59007 Reviewed-by: Edward Haas Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M lib/vdsm/network/configurators/__init__.py M lib/vdsm/network/configurators/dhclient.py M lib/vdsm/network/configurators/iproute2.py M lib/vdsm/network/configurators/pyroute_two.py 4 files changed, 29 insertions(+), 21 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59007 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib26ef12a7af7067d1b3b9105ce0173c36eecbb22 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: spec: Require lvm version fixing filter
Francesco Romani has posted comments on this change. Change subject: spec: Require lvm version fixing filter .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60004 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24040df9e19b4a093ce7e4f954375017f694099f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: xmlrpc: Hide fenceNode password in the log
Francesco Romani has posted comments on this change. Change subject: xmlrpc: Hide fenceNode password in the log .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59991 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53318ed8ce425f042b5f783af779b540c1dfd7b5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: move dhclient.py to ip package
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: move dhclient.py to ip package .. net: move dhclient.py to ip package Change-Id: I4065d551e62cf6aa04021e2cfc5de73afd0334fd Bug-Url: https://bugzilla.redhat.com/1195208 Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/59727 Reviewed-by: Edward Haas Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M lib/vdsm/network/configurators/Makefile.am M lib/vdsm/network/configurators/ifcfg.py M lib/vdsm/network/configurators/iproute2.py M lib/vdsm/network/configurators/pyroute_two.py R lib/vdsm/network/ip/dhclient.py M vdsm.spec.in 6 files changed, 17 insertions(+), 17 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59727 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4065d551e62cf6aa04021e2cfc5de73afd0334fd Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: add network with dhcp configuration
Dan Kenigsberg has posted comments on this change. Change subject: ovs: add network with dhcp configuration .. Patch Set 12: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I792713f27f41faf5e2d4de02c51ad8d0ee02 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: add network with dhcp configuration
Dan Kenigsberg has submitted this change and it was merged. Change subject: ovs: add network with dhcp configuration .. ovs: add network with dhcp configuration Change-Id: I792713f27f41faf5e2d4de02c51ad8d0ee02 Bug-Url: https://bugzilla.redhat.com/1195208 Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/59039 Continuous-Integration: Jenkins CI Reviewed-by: Edward Haas Reviewed-by: Dan Kenigsberg --- M lib/vdsm/network/netswitch.py A tests/network/func_dhclient_test.py M tests/network/netfunctestlib.py 3 files changed, 127 insertions(+), 16 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I792713f27f41faf5e2d4de02c51ad8d0ee02 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: jsonrpc: recovery error passed as response
Hello Piotr Kliczewski, Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/60006 to review the following change. Change subject: jsonrpc: recovery error passed as response .. jsonrpc: recovery error passed as response When we notice that vdsm is in recovery mode we return information about recovery as result instead of returning error. Backport-To: 4.0 Backport-To: 3.6 Change-Id: I87ca49c91f1705abe55e044980442faf61b0ed22 Signed-off-by: Piotr Kliczewski Signed-off-by: Oved Ourfali Bug-Url: https://bugzilla.redhat.com/1350763 Reviewed-on: https://gerrit.ovirt.org/59948 Reviewed-by: Oved Ourfali Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani --- M lib/yajsonrpc/__init__.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/60006/1 diff --git a/lib/yajsonrpc/__init__.py b/lib/yajsonrpc/__init__.py index ec3b5ed..3f6c24b 100644 --- a/lib/yajsonrpc/__init__.py +++ b/lib/yajsonrpc/__init__.py @@ -515,7 +515,7 @@ self.log.info("In recovery, ignoring '%s' in bridge with %s", req.method, req.params) # TODO: take the response from the exception instead of via errCode -ctx.requestDone(JsonRpcResponse(errCode['recovery'], None, req.id)) +ctx.requestDone(JsonRpcResponse(None, errCode['recovery'], req.id)) return self.log.log(logLevel, "Calling '%s' in bridge with %s", -- To view, visit https://gerrit.ovirt.org/60006 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I87ca49c91f1705abe55e044980442faf61b0ed22 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Oved Ourfali Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Piotr Kliczewski ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: jsonrpc: recovery error passed as response
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: recovery error passed as response .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/60006 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87ca49c91f1705abe55e044980442faf61b0ed22 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Oved Ourfali Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: move bridges cleanup to a separate function
Dan Kenigsberg has submitted this change and it was merged. Change subject: ovs: move bridges cleanup to a separate function .. ovs: move bridges cleanup to a separate function In order to trigger rollback as late as possible, we have to separate ovs.switch.setup() in two functions, each containing one transaction. This will be needed in the next patch. Change-Id: I7a6b7bb45cf111ab522812b5bc46d38c4baec451 Bug-Url: https://bugzilla.redhat.com/1195208 Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/59903 Reviewed-by: Edward Haas Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M lib/vdsm/network/netswitch.py M lib/vdsm/network/ovs/switch.py 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59903 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a6b7bb45cf111ab522812b5bc46d38c4baec451 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: move bridges cleanup to a separate function
Dan Kenigsberg has posted comments on this change. Change subject: ovs: move bridges cleanup to a separate function .. Patch Set 3: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/59903 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a6b7bb45cf111ab522812b5bc46d38c4baec451 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: jsonrpc: recovery error passed as response
Francesco Romani has posted comments on this change. Change subject: jsonrpc: recovery error passed as response .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60006 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87ca49c91f1705abe55e044980442faf61b0ed22 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Oved Ourfali Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net ifcfg: fix bond rollback
Dan Kenigsberg has posted comments on this change. Change subject: net ifcfg: fix bond rollback .. Patch Set 2: Code-Review-1 please add a functional test for this condition (I suspect that adding a little assert_bond_does_not_exist after an existing test could be enough). -- To view, visit https://gerrit.ovirt.org/59940 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5cea6ec71c913d74d95317ff7318259d64b40969 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: hostdev: use specific device classes in HostDevice
Francesco Romani has posted comments on this change. Change subject: hostdev: use specific device classes in HostDevice .. Patch Set 7: (1 comment) +0: I like the improvements and I like the general direction, but I don't want to commit _yet_ to this solution. https://gerrit.ovirt.org/#/c/57963/7/vdsm/virt/vmdevices/hostdevice.py File vdsm/virt/vmdevices/hostdevice.py: PS7, Line 314: def __new__(cls, conf, log, **kwargs): : device_params = get_device_params(kwargs['device']) : device = cls._DEVICE_MAPPING[ : device_params['capability']](conf, log, **kwargs) : return device This is a massive improvement over the delegation approach. I'm a bit concerned about the usage of __new__. I'd like to avoid _too_ dynamic/clever code. Anyway this specific use seems still acceptable. I'm a fan of this idiom @classmethod def from_device_params(cls, conf, log, **kwargs): device_params = get_device_params(kwargs['device']) device = cls._DEVICE_MAPPING[ device_params['capability']](conf, log, **kwargs) return device but I concur that in this case we have little benefit, beside personal taste. TL;DR: I don't have any concrete reason against __new__, I'm just asking (not requiring) to evaluate possible alternatives. From my POV the class hierarchy approach could work, I've nothing against it either. -- To view, visit https://gerrit.ovirt.org/57963 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2734b7ec789c0ce57b64d7699cbe967c774bb608 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: jsonrpc: recovery error passed as response
Piotr Kliczewski has uploaded a new change for review. Change subject: jsonrpc: recovery error passed as response .. jsonrpc: recovery error passed as response When we notice that vdsm is in recovery mode we return information about recovery as result instead of returning error. Backport-To: 4.0 Backport-To: 3.6 Change-Id: I87ca49c91f1705abe55e044980442faf61b0ed22 Signed-off-by: Piotr Kliczewski Bug-Url: https://bugzilla.redhat.com/1350763 Reviewed-on: https://gerrit.ovirt.org/59948 Reviewed-by: Oved Ourfali Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani --- M lib/yajsonrpc/__init__.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/60008/1 diff --git a/lib/yajsonrpc/__init__.py b/lib/yajsonrpc/__init__.py index 83683cc..f824211 100644 --- a/lib/yajsonrpc/__init__.py +++ b/lib/yajsonrpc/__init__.py @@ -508,7 +508,7 @@ self.log.info("In recovery, ignoring '%s' in bridge with %s", req.method, req.params) # TODO: take the response from the exception instead of via errCode -ctx.requestDone(JsonRpcResponse(errCode['recovery'], None, req.id)) +ctx.requestDone(JsonRpcResponse(None, errCode['recovery'], req.id)) return self.log.log(logLevel, "Calling '%s' in bridge with %s", -- To view, visit https://gerrit.ovirt.org/60008 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I87ca49c91f1705abe55e044980442faf61b0ed22 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: hostdev: use specific device classes in HostDevice
Martin Polednik has posted comments on this change. Change subject: hostdev: use specific device classes in HostDevice .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/57963/7/vdsm/virt/vmdevices/hostdevice.py File vdsm/virt/vmdevices/hostdevice.py: PS7, Line 314: def __new__(cls, conf, log, **kwargs): : device_params = get_device_params(kwargs['device']) : device = cls._DEVICE_MAPPING[ : device_params['capability']](conf, log, **kwargs) : return device > This is a massive improvement over the delegation approach. I'm working with 2 conditions: 1) no changes in device creation code and 2) no interface-like object. To satisfy 1), we must be able to construct the proper device object from within HostDevice object. Using a more java-ish approach, except for being just bad, is therefore not possible. Same for traditional inheritance. On top of that, if we add 2) to the mix, we are out of possible composition (the previous version with delegation). I'm still trying to figure out a way of not creating too clever code - that is the reason for this patch series, after all. I like from_device_params idea, but as of now it would create additional complexity instead of reducing it. Devices are created in _devMapFromDevSpecMap with following code: dev_map[dev_type].append(dev_class(self.conf, self.log, **dev)) It can be argued that the code itself is a bit too clever at the moment. To avoid creating a device specific exception, I still prefer __new__. We could discuss adding similar API to other devices and using the added API to initialize the object. Such approach assumes that there is nontrivial benefit of such change for any non-host device. -- To view, visit https://gerrit.ovirt.org/57963 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2734b7ec789c0ce57b64d7699cbe967c774bb608 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: spec: Update Fedora lvm requirement
Nir Soffer has uploaded a new change for review. Change subject: spec: Update Fedora lvm requirement .. spec: Update Fedora lvm requirement In commit b63bdfb0a2d8 (spec: Require lvm version fixing filter) we updated the requirement for Fedora since this issue was fixed 7 month ago in Fedora 23. However we still require ancient version that does not include this fix. Now we require the latest lvm package, including this fix. Change-Id: I5b6ec57d8d3a6912b9ac344b44147fdadd3c366f Bug-Url: https://bugzilla.redhat.com/1346012 Signed-off-by: Nir Soffer --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/60009/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index d53a311..edc32fb 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -223,7 +223,7 @@ Requires: policycoreutils-python Requires: sed >= 4.2.1-10 Requires: ed -Requires: lvm2 >= 2.02.107 +Requires: lvm2 >= 2.02.132 Requires: selinux-policy-targeted >= 3.12.1-177 # In order to avoid a policycoreutils bug (rhbz 889698) when selinux is # disabled we now require the version 2.1.13-55 (or newer) of Fedora. -- To view, visit https://gerrit.ovirt.org/60009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5b6ec57d8d3a6912b9ac344b44147fdadd3c366f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: rpc: Lower logging priority just for getAllVmStats
Francesco Romani has posted comments on this change. Change subject: rpc: Lower logging priority just for getAllVmStats .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5eefac9f88ede84df06c0cc39b188c8ae75e456b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: rpc: Log calls of API methods with possibly large results
Francesco Romani has posted comments on this change. Change subject: rpc: Log calls of API methods with possibly large results .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59993 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85d7f0ceee7e120081e2d9ad4ca3c8148ee70554 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: spec: Require lvm version fixing filter
Nir Soffer has posted comments on this change. Change subject: spec: Require lvm version fixing filter .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/59907/3//COMMIT_MSG Commit Message: Line 17: Line 18: On 4.0, these slowdowns may cause unwanted delays in various flows, but Line 19: are not harmful to storage monitoring. Line 20: Line 21: Fedora 23 and later already include this fix (lvm2-2.02.132-2.fc23). > This is true, but from reading the spec file, all you see for Fedora is "Re Thanks! this is addressed in https://gerrit.ovirt.org/60009 Line 22: Line 23: Change-Id: I24040df9e19b4a093ce7e4f954375017f694099f Line 24: Bug-Url: https://bugzilla.redhat.com/1346012 -- To view, visit https://gerrit.ovirt.org/59907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24040df9e19b4a093ce7e4f954375017f694099f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: flush IP config from attached ifaces
Petr Horáček has posted comments on this change. Change subject: ovs: flush IP config from attached ifaces .. Patch Set 4: (6 comments) https://gerrit.ovirt.org/#/c/59958/4/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py: PS4, Line 205: flush > Better be consistent and use 'remove'. I wanted to emphasize, that it is not gentle removal like in case of dhclient.stop() but flush of the whole static/dynamic ip config. PS4, Line 205: nics > but it is not only nics, perhaps ifaces will fit better here. Done Line 203: Line 204: Line 205: def _flush_ip_config_from_used_nics(netinfo_bonds, netinfo_nics, attrs): Line 206: Line 207: def flush_nic_ip(nic): > It will be better moving it to the module scope as private, there is no nee Done Line 208: nic_info = netinfo_nics[nic] Line 209: if nic_info['ipv4address']: Line 210: _flush_ip_config(nic, family=4) Line 211: if nic_info['ipv6address']: PS4, Line 209: if nic_info['ipv4address']: : _flush_ip_config(nic, family=4) : if nic_info['ipv6address']: : _flush_ip_config(nic, family=6) > Why not just flush all? Done Line 214: nic = attrs.get('nic') Line 215: bond = attrs.get('bonding') Line 216: if nic: Line 217: flush_nic_ip(nic) Line 218: elif bond: > If there is a bond and there are IP settings on its slaves, we have a corru Before setupNetworks you have two nics, in first stage of setup you used them for a bond and used the bond in a network. Now we want to flush initial ip config from nics, how is that corrupted? Line 219: bond_info = netinfo_bonds[bond] Line 220: nics = bond_info['slaves'] Line 221: for nic in nics: Line 222: flush_nic_ip(nic) https://gerrit.ovirt.org/#/c/59958/5/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py: Line 226: dhclient.kill(iface, family) # kills dhclient and flushes IP Line 227: Line 228: Line 229: def _set_dhcp_config(iface, attrs): Line 230: # TODO: DHCPv6 > What about static IP/s? by # flushes IP i mean flushes both IP obtained from dhcp and static one. Line 231: blocking_dhcp = attrs.get('blockingdhcp', False) Line 232: duid_source = attrs.get('bonding') or attrs.get('nic') Line 233: Line 234: ipv4 = address.IPv4(*_ipv4_conf_params(attrs)) -- To view, visit https://gerrit.ovirt.org/59958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66e0be6ea8583fae1814bb8fc776dd243932b192 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: rpc: Use Suppressed class instead of logging workarounds
Francesco Romani has posted comments on this change. Change subject: rpc: Use Suppressed class instead of logging workarounds .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idaf00e557fccb8f08fa3aeb38d51cb4bbe0ffe53 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: xmlrpc: Hide fenceNode password in the log
Nir Soffer has posted comments on this change. Change subject: xmlrpc: Hide fenceNode password in the log .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59991 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53318ed8ce425f042b5f783af779b540c1dfd7b5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: logging: Introduce throttledlog
Francesco Romani has posted comments on this change. Change subject: logging: Introduce throttledlog .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief96f74eb84880827ccf24c3e7ae854403090b8a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: xmlrpc: Hide fenceNode password in the log
Nir Soffer has posted comments on this change. Change subject: xmlrpc: Hide fenceNode password in the log .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/59991/1//COMMIT_MSG Commit Message: Line 13: Password logging seems to be already handled with jsonrpc, so this patch Line 14: just fixes xmlrpc. Line 15: Line 16: This patch doesn't change the actual behavior, but it is a preparation Line 17: patch for the followup patches. Are you sure? looks to me like behavior change, you suppress now the arguments. Line 18: Line 19: Change-Id: I53318ed8ce425f042b5f783af779b540c1dfd7b5 Line 20: Backport-To: 4.0 Line 21: Backport-To: 3.6 -- To view, visit https://gerrit.ovirt.org/59991 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53318ed8ce425f042b5f783af779b540c1dfd7b5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: rpc: Lower logging priority just for getAllVmStats
Nir Soffer has posted comments on this change. Change subject: rpc: Lower logging priority just for getAllVmStats .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5eefac9f88ede84df06c0cc39b188c8ae75e456b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: rpc: Log important info from VM stats
Francesco Romani has posted comments on this change. Change subject: rpc: Log important info from VM stats .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59997 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcbac615323b62fb9a27e5c0f5a4e98990076146 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: rpc: Log RPC call summary on info level
Francesco Romani has posted comments on this change. Change subject: rpc: Log RPC call summary on info level .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idde2f1ba7394f16770543f5ca13411e8c2339cc6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: rpc: Log also error codes of RPC calls
Francesco Romani has posted comments on this change. Change subject: rpc: Log also error codes of RPC calls .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/5 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I776e667fcfd1a20a9ef5f6c638d6c3d950672314 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: spec: Require lvm version fixing filter
Francesco Romani has submitted this change and it was merged. Change subject: spec: Require lvm version fixing filter .. spec: Require lvm version fixing filter Older lvm version was using filter incorrectly when running commands such as vgck and pvs. Instead of rejecting all the devices in the filter, the commands opened and scanned all block devices. This slow down these commands on systems with lot of block devices. On 3.6, lvm slowdowns cause delays in storage monitoring and may cause a host to become non-operational. These delays may also cause storage operations such as copying disks to fail with a timeout. On 4.0, these slowdowns may cause unwanted delays in various flows, but are not harmful to storage monitoring. Fedora 23 and later already include this fix (lvm2-2.02.132-2.fc23). Change-Id: I24040df9e19b4a093ce7e4f954375017f694099f Bug-Url: https://bugzilla.redhat.com/1346012 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/59907 Reviewed-by: Francesco Romani Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/60004 Continuous-Integration: Jenkins CI --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60004 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24040df9e19b4a093ce7e4f954375017f694099f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: spec: Require lvm version fixing filter
Francesco Romani has posted comments on this change. Change subject: spec: Require lvm version fixing filter .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60005 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24040df9e19b4a093ce7e4f954375017f694099f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: spec: Require lvm version fixing filter
Francesco Romani has submitted this change and it was merged. Change subject: spec: Require lvm version fixing filter .. spec: Require lvm version fixing filter Older lvm version was using filter incorrectly when running commands such as vgck and pvs. Instead of rejecting all the devices in the filter, the commands opened and scanned all block devices. This slow down these commands on systems with lot of block devices. On 3.6, lvm slowdowns cause delays in storage monitoring and may cause a host to become non-operational. These delays may also cause storage operations such as copying disks to fail with a timeout. On 4.0, these slowdowns may cause unwanted delays in various flows, but are not harmful to storage monitoring. Fedora 23 and later already include this fix (lvm2-2.02.132-2.fc23). Change-Id: I24040df9e19b4a093ce7e4f954375017f694099f Bug-Url: https://bugzilla.redhat.com/1346012 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/59907 Reviewed-by: Francesco Romani Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/60005 Continuous-Integration: Jenkins CI --- M vdsm.spec.in 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60005 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24040df9e19b4a093ce7e4f954375017f694099f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: jsonrpc: recovery error passed as response
Francesco Romani has posted comments on this change. Change subject: jsonrpc: recovery error passed as response .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60008 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87ca49c91f1705abe55e044980442faf61b0ed22 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: jsonrpc: recovery error passed as response
Francesco Romani has posted comments on this change. Change subject: jsonrpc: recovery error passed as response .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60006 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87ca49c91f1705abe55e044980442faf61b0ed22 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Oved Ourfali Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: spec: Update Fedora lvm requirement
Nir Soffer has posted comments on this change. Change subject: spec: Update Fedora lvm requirement .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/60009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b6ec57d8d3a6912b9ac344b44147fdadd3c366f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: hostdev: refactor accessing libvirt information in PCI device
Martin Polednik has abandoned this change. Change subject: hostdev: refactor accessing libvirt information in PCI device .. Abandoned Not needed. -- To view, visit https://gerrit.ovirt.org/57957 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id55b60414579ed09c3ce37fa292f91de8606b9fb Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: hostdev: refactor accessing libvirt information in USB device
Martin Polednik has abandoned this change. Change subject: hostdev: refactor accessing libvirt information in USB device .. Abandoned Not needed. -- To view, visit https://gerrit.ovirt.org/57959 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I6c0dd9b684585709b3c696f83706f947e6566f75 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: hostdev: refactor accessing libvirt information in SCSI device
Martin Polednik has abandoned this change. Change subject: hostdev: refactor accessing libvirt information in SCSI device .. Abandoned Not needed. -- To view, visit https://gerrit.ovirt.org/57961 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I49c4529171241960834cf913fb9895e6c35a66c2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: spec: Update Fedora lvm requirement
Francesco Romani has posted comments on this change. Change subject: spec: Update Fedora lvm requirement .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b6ec57d8d3a6912b9ac344b44147fdadd3c366f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: spec: Update Fedora lvm requirement
Allon Mureinik has posted comments on this change. Change subject: spec: Update Fedora lvm requirement .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b6ec57d8d3a6912b9ac344b44147fdadd3c366f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: py3 tests: ported storage_exceptions_test.py test to python3
Nir Soffer has posted comments on this change. Change subject: py3 tests: ported storage_exceptions_test.py test to python3 .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/59869/3/tests/storage_exceptions_test.py File tests/storage_exceptions_test.py: Line 44 Line 45 Line 46 Line 47 Line 48 This should move to gluster_exception_test.py. -- To view, visit https://gerrit.ovirt.org/59869 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I345d28771c94d7e50ad27d842fd1a341690a96b2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tests: converted main.py to a test module
Nir Soffer has posted comments on this change. Change subject: tests: converted main.py to a test module .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/59975/1/tests/storage_exceptions_test.py File tests/storage_exceptions_test.py: Line 45: self.assertFalse(obj.code in codes) Line 46: self.assertTrue(obj.code < 5000) Line 47: Line 48: Line 49: class TestGlusterExceptions(TestCaseBase): Should move to gluster_exception_test.py Line 50: def test_collisions(self): Line 51: codes = {} Line 52: Line 53: for name in dir(gluster_exception): -- To view, visit https://gerrit.ovirt.org/59975 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea5585bc4f494ab09131e749164965c358bdf472 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: rpc: Log calls of API methods with possibly large results
Nir Soffer has posted comments on this change. Change subject: rpc: Log calls of API methods with possibly large results .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59993 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85d7f0ceee7e120081e2d9ad4ca3c8148ee70554 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: Limit the number of workers in executor
Milan Zamazal has posted comments on this change. Change subject: virt: Limit the number of workers in executor .. Patch Set 17: (11 comments) https://gerrit.ovirt.org/#/c/57754/16/tests/executorTests.py File tests/executorTests.py: Line 183 Line 184 Line 185 Line 186 Line 187 > Better change to wait on an event, so we can have block tasks, and release That would require touching the tests unrelated to this patch, so I'd leave it for a followup patch or patches. Line 35: Line 36: def setUp(self): Line 37: self.scheduler = schedule.Scheduler() Line 38: self.scheduler.start() Line 39: self.max_tasks = 20 > Why did you change max_task to be lower then max_workers? I didn't change the original max_tasks value, I just extracted it to an attribute, since it is used in the tests. As for max_workers, I selected higher value than max_tasks not to mess with other tests. But it seems all the tests should work with max_workers == 15, so let's use that value (getting rid of waiting on the queue is a good idea). An alternative would be to make a separate test (sub)class, but it's not needed now. Line 40: self.max_workers = 15 Line 41: self.executor = executor.Executor('test', Line 42: workers_count=10, Line 43: max_tasks=self.max_tasks, Line 46: self.executor.start() Line 47: time.sleep(0.1) # Give time to start all threads Line 48: Line 49: def tearDown(self): Line 50: self.executor.stop() > This is not a good idea. We want to clean up properly after each test. I agree, but in case there is a bug in the executor code that leaves a stuck task somewhere then we hang here. This is not what we want. Do you have a suggestion how to cleanup properly here even when a stuck task is present? I removed the wait parameter here and added a regular cleanup to the tests but we should still fix the problem in a followup patch. If we don't then we should improve the cleanup in the tests to make sure we don't hang on failed assertions, which may be a bit complex (especially with barriers). Line 51: self.scheduler.stop() Line 52: Line 53: def test_dispatch_not_running(self): Line 54: self.executor.stop() Line 137: time.sleep(0.3) Line 138: for task in tasks: Line 139: self.assertTrue(task.executed.is_set()) Line 140: Line 141: @slowtest > We can remove this if we fix max_tasks. Done Line 142: def test_max_workers(self): Line 143: limit = self.max_workers Line 144: blocked_forever = threading.Event() Line 145: blocked = threading.Event() Line 158: Line 159: # Try to run new tasks on the executor now, when the maximum number of Line 160: # workers is reached Line 161: n_extra_tasks = 2 Line 162: extra_tasks = [Task() for i in range(n_extra_tasks)] > Using bigger max_tasks will make this unneeded. Done Line 163: for t in extra_tasks: Line 164: self.executor.dispatch(t, 0) Line 165: Line 166: # Check that none of the new tasks got executed (the number of the Line 169: Line 170: # Unblock one of the tasks and check the new tasks run Line 171: blocked.set() Line 172: # The last task, the only unblocked one, should be executed now Line 173: self.assertTrue(tasks[-1].executed.wait(1)) > Same, not needed. Done Line 174: Line 175: # The other tasks shouldn't be unblocked and executed, let's check Line 176: # things go as expected before proceeding (however we don't want to Line 177: # stop and wait on each of the tasks, the first one is enough) Line 170: # Unblock one of the tasks and check the new tasks run Line 171: blocked.set() Line 172: # The last task, the only unblocked one, should be executed now Line 173: self.assertTrue(tasks[-1].executed.wait(1)) Line 174: > Add blank line to separate logical blocks. Done Line 175: # The other tasks shouldn't be unblocked and executed, let's check Line 176: # things go as expected before proceeding (however we don't want to Line 177: # stop and wait on each of the tasks, the first one is enough) Line 178: self.assertFalse(tasks[0].executed.wait(1)) Line 178: self.assertFalse(tasks[0].executed.wait(1)) Line 179: self.assertEqual([t for t in tasks if t.executed.is_set()], Line 180: [tasks[-1]]) Line 181: Line 182: # Extra tasks are not blocking, they were blocked just by the overflown > Add blank line to make it easier to follow. Done Line 183: # executor, so they should be all executed now when there is one free Line 184: # worker Line 185: self.assertEqual([t for t in extra_tasks if not t.executed.wai
Change in vdsm[ovirt-4.0]: rpc: Use Suppressed class instead of logging workarounds
Nir Soffer has posted comments on this change. Change subject: rpc: Use Suppressed class instead of logging workarounds .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idaf00e557fccb8f08fa3aeb38d51cb4bbe0ffe53 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org