Change in vdsm[ovirt-4.0]: api: fixing default value for GlusterHost.createBrick

2016-07-07 Thread sabose
Sahina Bose has posted comments on this change.

Change subject: api: fixing default value for GlusterHost.createBrick
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/60379
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9aaac0814f2c0754c58d99d73adeab03e01b2e1a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[ovirt-4.0]: api: fixing default value for GlusterHost.createBrick

2016-07-07 Thread rnachimu
Ramesh N has posted comments on this change.

Change subject: api: fixing default value for GlusterHost.createBrick
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/60379
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9aaac0814f2c0754c58d99d73adeab03e01b2e1a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[ovirt-4.0]: api: fixing default value for GlusterHost.createBrick

2016-07-07 Thread rnachimu
Ramesh N has uploaded a new change for review.

Change subject: api: fixing default value for GlusterHost.createBrick
..

api: fixing default value for GlusterHost.createBrick

Change default value for raidParamas to an empty dict in
string format.

Change-Id: I9aaac0814f2c0754c58d99d73adeab03e01b2e1a
Bug-Url: https://bugzilla.redhat.com/1352656
Signed-off-by: Ramesh Nachimuthu 
Reviewed-on: https://gerrit.ovirt.org/60206
Continuous-Integration: Jenkins CI
Reviewed-by: Sahina Bose 
Reviewed-by: Piotr Kliczewski 
(cherry picked from commit 57ce8b9776db4e931f8503cdf5e8d38d229f0634)
---
M lib/api/vdsm-api-gluster.yml
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/60379/1

diff --git a/lib/api/vdsm-api-gluster.yml b/lib/api/vdsm-api-gluster.yml
index 79d5d04..3bbb435 100644
--- a/lib/api/vdsm-api-gluster.yml
+++ b/lib/api/vdsm-api-gluster.yml
@@ -1051,7 +1051,7 @@
 name: fsType
 type: string
 
--   defaultvalue: {}
+-   defaultvalue: '{}'
 description: dictonary contains raid details of a raid device
 name: raidParams
 type: *RaidDevice


-- 
To view, visit https://gerrit.ovirt.org/60379
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9aaac0814f2c0754c58d99d73adeab03e01b2e1a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Ramesh N 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: vdscli: added DeprecationWarning to module

2016-07-07 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: vdscli: added DeprecationWarning to module
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/60318/4/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

Line 135: return server
Line 136: 
Line 137: warnings.simplefilter("always", category=DeprecationWarning)
Line 138: warnings.warn(
Line 139: 'XML-RPC binding is deprecated, please use jsonrpc', 
DeprecationWarning)
vdscli uses xmlrpc. since ovirt 3.6 xmlrpc is deprecated. please use 
vdsm.jsonrpccli
Line 140: 
Line 141: if __name__ == '__main__':
Line 142: print('connecting to %s:%s ssl %s ts %s' % (
Line 143: ADDRESS, PORT, _USE_SSL, _TRUSTED_STORE_PATH))


-- 
To view, visit https://gerrit.ovirt.org/60318
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I728db1ed55e1449000f82c78d26f2774a2650c7e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: schema: fix VM.create parameters

2016-07-07 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: schema: fix VM.create parameters
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/59258/7/tests/vdsmapi_test.py
File tests/vdsmapi_test.py:

Line 446: _schema.schema().verify_retval(
Line 447: vdsmapi.MethodRep('Host', 'getAllVmStats'), ret)
Line 448: 
Line 449: def test_vm_create_args(self):
Line 450: params = eval(read_data('vdsmapi_dumps/vmcreate_args.out'))
> During the process of making sure that the schema is up to date we need thi
It would be best to submit the test in a separate patch, since I don't think we 
should merge it.
Line 451: _schema.schema().verify_args(
Line 452: vdsmapi.MethodRep('VM', 'create'), params)
Line 453: 
Line 454: def test_missing_method(self):


-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: ovs: set mtu

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: ovs: set mtu
..


Patch Set 1:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie787af2372bb16c0d0b8fee0d246fde9c4e963ca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: ovs: early IP+link setup

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: ovs: early IP+link setup
..


Patch Set 1:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60371
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0555a61c9709be54bfb2587e3020d3046db10ec6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: schema: fix VM.create parameters

2016-07-07 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change.

Change subject: schema: fix VM.create parameters
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/59258/7/tests/vdsmapi_test.py
File tests/vdsmapi_test.py:

Line 446: _schema.schema().verify_retval(
Line 447: vdsmapi.MethodRep('Host', 'getAllVmStats'), ret)
Line 448: 
Line 449: def test_vm_create_args(self):
Line 450: params = eval(read_data('vdsmapi_dumps/vmcreate_args.out'))
> This test means you will have to change the data file each time you change 
During the process of making sure that the schema is up to date we need this. 
Later we can remove once we know that the schema is aligned with data.
Line 451: _schema.schema().verify_args(
Line 452: vdsmapi.MethodRep('VM', 'create'), params)
Line 453: 
Line 454: def test_missing_method(self):


-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: tests: Terminate watcher when tests fail

2016-07-07 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change.

Change subject: tests: Terminate watcher when tests fail
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/60239
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief975ac59c8c3ec106c42c93d5cb2a2fd32b69c1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: tests: Add test for testing the timeout mechanism

2016-07-07 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change.

Change subject: tests: Add test for testing the timeout mechanism
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/58423
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia405789ccff21f58bdaafefe1dcefa98e5d5f933
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: vdscli: added DeprecationWarning to module

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: vdscli: added DeprecationWarning to module
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60318
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I728db1ed55e1449000f82c78d26f2774a2650c7e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: tests: add helper to read test data

2016-07-07 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: tests: add helper to read test data
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/60271/2/tests/testlib.py
File tests/testlib.py:

Line 24: import inspect
Line 25: import io
Line 26: import logging
Line 27: import os
Line 28: import os.path
> right, but I wonder why jenkins didn't complain :\
Because you are using "os.path" in the code.
Line 29: import pickle
Line 30: import platform
Line 31: import unittest
Line 32: from functools import wraps


-- 
To view, visit https://gerrit.ovirt.org/60271
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id69ac8e6c5a2cc113f7573771f90da1dce2bcb74
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: tests: Move fake_mounts to storagefakelib

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: tests: Move fake_mounts to storagefakelib
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/58937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icde8191aa27a25977a13240eb0706e89b70426f6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: sdc: Safer way to access storage domain manifest

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: sdc: Safer way to access storage domain manifest
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/58879
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib274c58fc60f40a9f7396d6be05dfe9b461bc2c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: volume: Use StorageDomainManitest when possible

2016-07-07 Thread nsoffer
Nir Soffer has uploaded a new change for review.

Change subject: volume: Use StorageDomainManitest when possible
..

volume: Use StorageDomainManitest when possible

New code should use the StorageDomainManifest classes instead of the
StorageDomain classes when possible. This change use the new
sdCache.produce_manitest() in few places.

Change-Id: If64a3ff30124b6c3bee86101510379ac72678ac6
Signed-off-by: Nir Soffer 
---
M vdsm/storage/fileVolume.py
M vdsm/storage/volume.py
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/60347/1

diff --git a/vdsm/storage/fileVolume.py b/vdsm/storage/fileVolume.py
index 93e6e98..302495f 100644
--- a/vdsm/storage/fileVolume.py
+++ b/vdsm/storage/fileVolume.py
@@ -305,7 +305,7 @@
 self.oop.utils.forceLink(self._getMetaVolumePath(), dstMetaPath)
 
 # Link the lease file if the domain uses sanlock
-if sdCache.produce(self.sdUUID).hasVolumeLeases():
+if sdCache.produce_manifest(self.sdUUID).hasVolumeLeases():
 self._shareLease(dstImgPath)
 
 @classmethod
@@ -321,7 +321,7 @@
 volList = []
 for i in files:
 volid = os.path.splitext(os.path.basename(i))[0]
-if (sdCache.produce(sdUUID).
+if (sdCache.produce_manifest(sdUUID).
 produceVolume(imgUUID, volid).
 getImage() == imgUUID):
 volList.append(volid)
diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py
index b1cf15a..7fee1cd 100644
--- a/vdsm/storage/volume.py
+++ b/vdsm/storage/volume.py
@@ -304,7 +304,7 @@
 # However to avoid lvm MDA corruption we still need to set the volume
 # as read-only on domain version 2. The corruption is triggered on the
 # HSMs that are using the resource manager to prepare the volume chain.
-if int(sdCache.produce(self.sdUUID).getVersion()) < 3:
+if int(sdCache.produce_manifest(self.sdUUID).getVersion()) < 3:
 self._setrw(rw=rw)
 
 def setLeaf(self):
@@ -434,7 +434,7 @@
 """
 puuid = self.getParent()
 if puuid and puuid != sc.BLANK_UUID:
-sd_manifest = sdCache.produce(self.sdUUID).manifest
+sd_manifest = sdCache.produce_manifest(self.sdUUID)
 return sd_manifest.produceVolume(self.imgUUID, puuid)
 return None
 


-- 
To view, visit https://gerrit.ovirt.org/60347
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If64a3ff30124b6c3bee86101510379ac72678ac6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: vdscli: added DeprecationWarning to module

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: vdscli: added DeprecationWarning to module
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60318
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I728db1ed55e1449000f82c78d26f2774a2650c7e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: tests: add helper to read test data

2016-07-07 Thread fromani
Francesco Romani has posted comments on this change.

Change subject: tests: add helper to read test data
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/60271/2/tests/testlib.py
File tests/testlib.py:

Line 24: import inspect
Line 25: import io
Line 26: import logging
Line 27: import os
Line 28: import os.path
> Not needed
right, but I wonder why jenkins didn't complain :\
Line 29: import pickle
Line 30: import platform
Line 31: import unittest
Line 32: from functools import wraps


-- 
To view, visit https://gerrit.ovirt.org/60271
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id69ac8e6c5a2cc113f7573771f90da1dce2bcb74
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: contrib: add simple tool to prettify python dumps

2016-07-07 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: contrib: add simple tool to prettify python dumps
..


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/60272/3/contrib/refmt
File contrib/refmt:

Line 37: #
Line 38: # Example:
Line 39: # - before:
Line 40: # (please note line continuations to fit in 80 columns)
Line 41: # $ cat repoStats.out 
> trailing whitespace
What is repoStats.out? can we have a tool to reformat raw logs for better 
reading?

For example:

tail -f /var/log/vdsm/vdsm.log | logfmt
Line 42: # {u'b0390d9e-2f1d-43c0-a56c-a20af032e934': {'code': 0, 'actual': 
True, \
Line 43: # 'version': 0, 'acquired': True, 'delay': '0.000521661', \
Line 44: # 'lastCheck': '9.8', 'valid': True}, \
Line 45: # u'c17ac7f2-bec0-4ed1-a04e-790799e65d7c': {'code': 0, 'actual': True, 
\


Line 59: #'code': 0,
Line 60: #'delay': '0.000640848',
Line 61: #'lastCheck': '0.0',
Line 62: #'valid': True,
Line 63: #'version': 3}}
Nice!
Line 64: 
Line 65: import pprint
Line 66: import sys
Line 67: 


-- 
To view, visit https://gerrit.ovirt.org/60272
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3962648db542afb4297e7712c017ffa266c52424
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: contrib: add simple tool to prettify python dumps

2016-07-07 Thread fromani
Francesco Romani has posted comments on this change.

Change subject: contrib: add simple tool to prettify python dumps
..


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/60272/2/contrib/refmt
File contrib/refmt:

Line 37: #
Line 38: # Example:
Line 39: # - before:
Line 40: # (please note line continuations to fit in 80 columns)
Line 41: # $ cat repoStats.out 
trailing whitespace.
Line 42: # {u'b0390d9e-2f1d-43c0-a56c-a20af032e934': {'code': 0, 'actual': 
True, \
Line 43: # 'version': 0, 'acquired': True, 'delay': '0.000521661', \
Line 44: # 'lastCheck': '9.8', 'valid': True}, \
Line 45: # u'c17ac7f2-bec0-4ed1-a04e-790799e65d7c': {'code': 0, 'actual': True, 
\


https://gerrit.ovirt.org/#/c/60272/3/contrib/refmt
File contrib/refmt:

Line 37: #
Line 38: # Example:
Line 39: # - before:
Line 40: # (please note line continuations to fit in 80 columns)
Line 41: # $ cat repoStats.out 
trailing whitespace
Line 42: # {u'b0390d9e-2f1d-43c0-a56c-a20af032e934': {'code': 0, 'actual': 
True, \
Line 43: # 'version': 0, 'acquired': True, 'delay': '0.000521661', \
Line 44: # 'lastCheck': '9.8', 'valid': True}, \
Line 45: # u'c17ac7f2-bec0-4ed1-a04e-790799e65d7c': {'code': 0, 'actual': True, 
\


-- 
To view, visit https://gerrit.ovirt.org/60272
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3962648db542afb4297e7712c017ffa266c52424
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: tests: add helper to read test data

2016-07-07 Thread fromani
Francesco Romani has posted comments on this change.

Change subject: tests: add helper to read test data
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/60271/1/tests/testlib.py
File tests/testlib.py:

Line 567: return wrapper
Line 568: 
Line 569: 
Line 570: def read_data(filename):
Line 571: test_path = os.path.realpath(__file__)
> How about move data files to data/ on same directory, and making read_data(
good idea, fixing.
Line 572: dir_name = os.path.dirname(test_path)
Line 573: path = os.path.join(dir_name, filename)
Line 574: with open(path) as src:


-- 
To view, visit https://gerrit.ovirt.org/60271
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id69ac8e6c5a2cc113f7573771f90da1dce2bcb74
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: qos: fix invalid dictionary iteration

2016-07-07 Thread phoracek
Petr Horáček has posted comments on this change.

Change subject: qos: fix invalid dictionary iteration
..


Patch Set 1: Verified+1

Fails on master with 'too many values to unpack', it is OK with this patch:

NETSETUP = {
'case11_net1': {
'ipv6autoconf': False,
'hostQos': {
'out': {
'ls': {
'm2': 10
 }
}
},
'nic': 'ens3',
'vlan': 15,
'mtu': 1500,
'dhcpv6': False,
'STP': 'no',
'bridged': True
},
'case11_net_2': {
'ipv6autoconf': False,
'hostQos': {
'out': {
'ls': {
'm2': 10
 }
}
},
'nic': 'ens3',
'vlan': 16,
'mtu': 1500,
'dhcpv6': False,
'STP': 'no',
'bridged': True
}
}

-- 
To view, visit https://gerrit.ovirt.org/60333
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfdb43838cf34384d47e7b447ab8e1c1d685a16a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: qos: fix invalid dictionary iteration

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: qos: fix invalid dictionary iteration
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60333
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfdb43838cf34384d47e7b447ab8e1c1d685a16a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: qos: fix invalid dictionary iteration

2016-07-07 Thread phoracek
Petr Horáček has uploaded a new change for review.

Change subject: qos: fix invalid dictionary iteration
..

qos: fix invalid dictionary iteration

`for x, y in dictionary` is not valid dictionary iteration. This bug
was here for some time, but unexposed.

Change-Id: Icfdb43838cf34384d47e7b447ab8e1c1d685a16a
Signed-off-by: Petr Horáček 
---
M lib/vdsm/network/configurators/qos.py
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/60333/1

diff --git a/lib/vdsm/network/configurators/qos.py 
b/lib/vdsm/network/configurators/qos.py
index b95761a..e9caa86 100644
--- a/lib/vdsm/network/configurators/qos.py
+++ b/lib/vdsm/network/configurators/qos.py
@@ -21,6 +21,8 @@
 import os
 from distutils.version import StrictVersion
 
+import six
+
 from vdsm.network import tc
 from vdsm.network.netinfo import qos as netinfo_qos
 from vdsm.network.netinfo.cache import ifaceUsed, NetInfo, get as cache_get
@@ -203,7 +205,7 @@
 definitions.
 """
 netinfo = NetInfo(cache_get())
-for _, attrs in netinfo.networks:
+for attrs in six.itervalues(netinfo.networks):
 if 'vlan' not in attrs and 'hostQos' in attrs and (
attrs['iface'] == dev):
 return True


-- 
To view, visit https://gerrit.ovirt.org/60333
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icfdb43838cf34384d47e7b447ab8e1c1d685a16a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: net: call address.flush explicitly after dhclient.kill

2016-07-07 Thread phoracek
Petr Horáček has posted comments on this change.

Change subject: net: call address.flush explicitly after dhclient.kill
..


Patch Set 2: Verified+1

Passed functional/networkTests.py

-- 
To view, visit https://gerrit.ovirt.org/60155
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c03ce4917174a78fc97f216ceac6e8c92d82de8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: vdscli: added DeprecationWarning to module

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: vdscli: added DeprecationWarning to module
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60318
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I728db1ed55e1449000f82c78d26f2774a2650c7e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: v2v: Log detailed output of virt-v2v

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: v2v: Log detailed output of virt-v2v
..


Patch Set 5:

* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* Check Product::#1350465::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59834
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a8d9284316a551edeaffdd66dfcd299fa02478e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: net: call address.flush explicitly after dhclient.kill

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: net: call address.flush explicitly after dhclient.kill
..


Patch Set 2:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60155
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c03ce4917174a78fc97f216ceac6e8c92d82de8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[ovirt-4.0]: build: enable vdsm-gluster build

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: build: enable vdsm-gluster build
..


Patch Set 2:

* #1225728::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1225728::OK, public bug
* Check Product::#1225728::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1225728::ERROR, wrong target milestone for stable branch, 
ovirt-4.1.0-alpha should match ^.*4.0.*
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/60329
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0adff4489b541becbdfb1f414a2c560b12a8117
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sahina Bose 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[ovirt-4.0]: build: enable vdsm-gluster build

2016-07-07 Thread sabose
Sahina Bose has posted comments on this change.

Change subject: build: enable vdsm-gluster build
..


Patch Set 1: Code-Review-1

-- 
To view, visit https://gerrit.ovirt.org/60329
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0adff4489b541becbdfb1f414a2c560b12a8117
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sahina Bose 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[ovirt-4.0]: build: enable vdsm-gluster build

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: build: enable vdsm-gluster build
..


Patch Set 1:

* #1225728::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1225728::OK, public bug
* Check Product::#1225728::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1225728::ERROR, wrong target milestone for stable branch, 
ovirt-4.1.0-alpha should match ^.*4.0.*
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/60329
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0adff4489b541becbdfb1f414a2c560b12a8117
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sahina Bose 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: migration: wait properly for migration to begin

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: migration: wait properly for migration to begin
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60073
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1ba369a0992c2473acf1395fad0b0c260c250ba
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: build: enable vdsm-gluster build

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: build: enable vdsm-gluster build
..


Patch Set 9:

* #1225728::Update tracker: OK
* Set MODIFIED::bug 1225728#1225728IGNORE, not oVirt classification but 
Red Hat

-- 
To view, visit https://gerrit.ovirt.org/58605
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0adff4489b541becbdfb1f414a2c560b12a8117
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: build: enable vdsm-gluster build

2016-07-07 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: build: enable vdsm-gluster build
..


Patch Set 8: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/58605
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0adff4489b541becbdfb1f414a2c560b12a8117
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: image: Add timing for copy volume operations

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: image: Add timing for copy volume operations
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/60164
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a509397c756a51bfed43b89a2505e3e4cbb9edc
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: Using startCmd func for running async execution

2016-07-07 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: Using startCmd func for running async execution
..


Patch Set 3: Code-Review-1

Please address the comments, and split this to:

- new start_cmd function
- use new function in storage
- use new function in virt
- use new function in networking

-- 
To view, visit https://gerrit.ovirt.org/60237
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id38507a04a124918f3865cf011bbf5adc7bc31d5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: Using startCmd func for running async execution

2016-07-07 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: Using startCmd func for running async execution
..


Patch Set 2:

(6 comments)

https://gerrit.ovirt.org/#/c/60237/2/lib/vdsm/commands.py
File lib/vdsm/commands.py:

Line 65: printable = command
Line 66: 
Line 67: execCmdLogger.debug(cmdutils.command_log_line(printable, cwd=cwd))
Line 68: 
Line 69: p = CPopen(command, close_fds=True, cwd=cwd, env=env)
> redundant and its splitting the code and make it uglier 
You can do:

extra = {}
if deathSignal is not None:
extra['deathSignal'] = deathSignal

CPopen(cmd, ..., **extra)

This is much better then duplicating code as you do here.
Line 70: 
Line 71: with terminating(p):
Line 72: (out, err) = p.communicate(data)
Line 73: 


Line 70: 
Line 71: with terminating(p):
Line 72: (out, err) = p.communicate(data)
Line 73: 
Line 74: if out is None:
> its not related to the patch.. you can post a patch for that separately
OK, we can wait with this.
Line 75: # Prevent splitlines() from barfing later on
Line 76: out = ""
Line 77: 
Line 78: execCmdLogger.debug(cmdutils.retcode_log_line(p.returncode, 
err=err))


Line 83: 
Line 84: return p.returncode, out, err
Line 85: 
Line 86: 
Line 87: def startCmd(command, sudo=False, cwd=None, data=None, raw=False,
> I prefer to keep the same arguments in this patch. we can remove redundant 
I agree with the steps by step, but the steps should be:

- Introduce start_cmd doing *only* what we need (nobody calls it)
- convert existing code to call new method, separate patches by group.

And not duplicating the arguments we cannot and should not support from the old 
crapy execCmd.
Line 88:  printable=None, env=None, nice=None, ioclass=None,
Line 89:  ioclassdata=None, setsid=False, 
execCmdLogger=logging.root,
Line 90:  deathSignal=0, resetCpuAffinity=True):
Line 91: """


Line 85: 
Line 86: 
Line 87: def startCmd(command, sudo=False, cwd=None, data=None, raw=False,
Line 88:  printable=None, env=None, nice=None, ioclass=None,
Line 89:  ioclassdata=None, setsid=False, 
execCmdLogger=logging.root,
> same
See my comment above
Line 90:  deathSignal=0, resetCpuAffinity=True):
Line 91: """
Line 92: Executes an external command, optionally via sudo.
Line 93: 


Line 111: 
Line 112: execCmdLogger.debug(cmdutils.command_log_line(printable, cwd=cwd))
Line 113: 
Line 114: p = AsyncProc(CPopen(command, close_fds=True, cwd=cwd, env=env,
Line 115:  deathSignal=deathSignal))
> no helper man ...
I have limited time to review this, please fix this in this patch.
Line 116: if data is not None:
Line 117: p.stdin.write(data)
Line 118: p.stdin.flush()
Line 119: 


Line 114: p = AsyncProc(CPopen(command, close_fds=True, cwd=cwd, env=env,
Line 115:  deathSignal=deathSignal))
Line 116: if data is not None:
Line 117: p.stdin.write(data)
Line 118: p.stdin.flush()
> there are tests that use it
Delete the useless tests (can be done in separate patch before this patch)
Line 119: 
Line 120: return p
Line 121: 
Line 122: 


-- 
To view, visit https://gerrit.ovirt.org/60237
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id38507a04a124918f3865cf011bbf5adc7bc31d5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: tests: add helper to read test data

2016-07-07 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: tests: add helper to read test data
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/60271/1/tests/testlib.py
File tests/testlib.py:

Line 567: return wrapper
Line 568: 
Line 569: 
Line 570: def read_data(filename):
Line 571: test_path = os.path.realpath(__file__)
> this is a good point, but still we have this idiom relatively widespread in
How about move data files to data/ on same directory, and making 
read_data(name) read from os.path.join(os.path.dirname(__file__), name)?

This way we have the convenience helper, but you can use it only if you use the 
project conventions, no mixing tests and data files.
Line 572: dir_name = os.path.dirname(test_path)
Line 573: path = os.path.join(dir_name, filename)
Line 574: with open(path) as src:


-- 
To view, visit https://gerrit.ovirt.org/60271
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id69ac8e6c5a2cc113f7573771f90da1dce2bcb74
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: vm: devices: drop support for ancient Engines

2016-07-07 Thread fromani
Francesco Romani has posted comments on this change.

Change subject: vm: devices: drop support for ancient Engines
..


Patch Set 9: Code-Review-2

please let's continue here: 
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:virt-dev-drop-compat-early3x-split

will abandon this patch once the above topic is merged.

-- 
To view, visit https://gerrit.ovirt.org/49173
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b9acd500670a2ace449cc50ac99bf94f58f165b
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra 
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: vm: graphics: report display info from device

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: vm: graphics: report display info from device
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60320
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f501addd40458887ae27cd9615a8856a02d8967
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: vm: storage: drop legacy drive config support

2016-07-07 Thread fromani
Francesco Romani has uploaded a new change for review.

Change subject: vm: storage: drop legacy drive config support
..

vm: storage: drop legacy drive config support

Drop the legacy Vm methods to rebuild specific drive configuration
from the generic Vm configuration.

Change-Id: Ib7f719c8e89fd976cbccdc6e93d124b5e34c9ce7
Signed-off-by: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 0 insertions(+), 61 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/60323/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index ba6d2af..9292a82 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -385,40 +385,6 @@
 drv['truesize'] = 0
 drv['apparentsize'] = 0
 
-def __legacyDrives(self):
-"""
-Backward compatibility for qa scripts that specify direct paths.
-"""
-legacies = []
-DEVICE_SPEC = ((0, 'hda'), (1, 'hdb'), (2, 'hdc'), (3, 'hdd'))
-for index, linuxName in DEVICE_SPEC:
-path = self.conf.get(linuxName)
-if path:
-legacies.append({'type': hwclass.DISK,
- 'device': 'disk', 'path': path,
- 'iface': 'ide', 'index': index,
- 'truesize': 0})
-return legacies
-
-def __removableDrives(self):
-removables = [{
-'type': hwclass.DISK,
-'device': 'cdrom',
-'iface': vmdevices.storage.DEFAULT_INTERFACE_FOR_ARCH[self.arch],
-'path': self.conf.get('cdrom', ''),
-'index': 2,
-'truesize': 0}]
-floppyPath = self.conf.get('floppy')
-if floppyPath:
-removables.append({
-'type': hwclass.DISK,
-'device': 'floppy',
-'path': floppyPath,
-'iface': 'fdc',
-'index': 0,
-'truesize': 0})
-return removables
-
 def _devMapFromDevSpecMap(self, dev_spec_map):
 dev_map = self._emptyDevMap()
 
@@ -600,33 +566,6 @@
  'nicModel': model, 'network': bridge,
  'device': 'bridge'})
 return nics
-
-def getConfDrives(self):
-"""
-Normalize drives provided by conf.
-"""
-# FIXME
-# Will be better to change the self.conf but this implies an API change
-# Remove this when the API parameters will be consistent.
-confDrives = self.conf.get('drives', [])
-if not confDrives:
-confDrives.extend(self.__legacyDrives())
-confDrives.extend(self.__removableDrives())
-
-for drv in confDrives:
-drv['type'] = hwclass.DISK
-drv['format'] = drv.get('format') or 'raw'
-drv['propagateErrors'] = drv.get('propagateErrors') or 'off'
-drv['readonly'] = False
-drv['shared'] = False
-# FIXME: For BC we have now two identical keys: iface = if
-# Till the day that conf will not returned as a status anymore.
-drv['iface'] = drv.get('iface') or \
-drv.get(
-'if',
-vmdevices.storage.DEFAULT_INTERFACE_FOR_ARCH[self.arch])
-
-return confDrives
 
 def updateDriveIndex(self, drv):
 if not drv['iface'] in self._usedIndices:


-- 
To view, visit https://gerrit.ovirt.org/60323
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7f719c8e89fd976cbccdc6e93d124b5e34c9ce7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: build: enable vdsm-gluster build

2016-07-07 Thread sabose
Sahina Bose has posted comments on this change.

Change subject: build: enable vdsm-gluster build
..


Patch Set 8: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/58605
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0adff4489b541becbdfb1f414a2c560b12a8117
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: vdscli: added DeprecationWarning to module

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: vdscli: added DeprecationWarning to module
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60318
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I728db1ed55e1449000f82c78d26f2774a2650c7e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: vdscli: added DeprecationWarning to module

2016-07-07 Thread igoihman
Irit Goihman has uploaded a new change for review.

Change subject: vdscli: added DeprecationWarning to module
..

vdscli: added DeprecationWarning to module

vdscli is deprecated and will be replaced soon by jsonrpccli.
since we want to eliminate the calls to vdscli module a
DeprecationWarning will be issued once this module will be
imported.

Change-Id: I728db1ed55e1449000f82c78d26f2774a2650c7e
Signed-off-by: Irit Goihman 
---
M lib/vdsm/vdscli.py
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/60318/1

diff --git a/lib/vdsm/vdscli.py b/lib/vdsm/vdscli.py
index 5bc91c9..656b774 100644
--- a/lib/vdsm/vdscli.py
+++ b/lib/vdsm/vdscli.py
@@ -25,6 +25,7 @@
 import re
 from six.moves import xmlrpc_client as xmlrpclib
 import sys
+import warnings
 from xml.parsers.expat import ExpatError
 from .sslcompat import sslutils
 
@@ -133,6 +134,9 @@
 server = xmlrpclib.Server('http://%s' % hostPort, transport)
 return server
 
+warnings.filterwarnings("always", category=DeprecationWarning)
+warnings.warn('vdscli is deprecated.', DeprecationWarning)
+
 if __name__ == '__main__':
 print('connecting to %s:%s ssl %s ts %s' % (
 ADDRESS, PORT, _USE_SSL, _TRUSTED_STORE_PATH))


-- 
To view, visit https://gerrit.ovirt.org/60318
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I728db1ed55e1449000f82c78d26f2774a2650c7e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: migration: wait properly for migration to begin

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: migration: wait properly for migration to begin
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60073
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1ba369a0992c2473acf1395fad0b0c260c250ba
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: ovs hook: fix dhclient imports

2016-07-07 Thread phoracek
Petr Horáček has posted comments on this change.

Change subject: ovs hook: fix dhclient imports
..


Patch Set 2: Verified+1

OVS hook stopped NIC's dhclient and started a new one on OVS bridge.

-- 
To view, visit https://gerrit.ovirt.org/60154
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie13c017538750902713831bbcb07a30c885abd7d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: ovs hook: fix dhclient imports

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: ovs hook: fix dhclient imports
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60154
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie13c017538750902713831bbcb07a30c885abd7d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: contrib: add simple tool to prettify python dumps

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: contrib: add simple tool to prettify python dumps
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60272
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3962648db542afb4297e7712c017ffa266c52424
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: schema: fix VM.create return value

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: schema: fix VM.create return value
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60279
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I751da2f0b2148c208975ed0e022141b2f19ec60a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: net: add address.flush family argument

2016-07-07 Thread phoracek
Petr Horáček has posted comments on this change.

Change subject: net: add address.flush family argument
..


Patch Set 2: Verified+1

iproute configurator was able to flush IP from used NIC.

-- 
To view, visit https://gerrit.ovirt.org/60153
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia149ae17e0546ed0df83576d1b16c68c5c2ccd3e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: migration: wait properly for migration to begin

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: migration: wait properly for migration to begin
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60073
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1ba369a0992c2473acf1395fad0b0c260c250ba
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: stomp: simplified client

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: stomp: simplified client
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: stomp: simplified client

2016-07-07 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change.

Change subject: stomp: simplified client
..


Patch Set 8:

(2 comments)

https://gerrit.ovirt.org/#/c/59151/8/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:

Line 1
> 2014-2016
Done


Line 575: )
Line 576: )
Line 577: 
Line 578: 
Line 579: def SimpleClient(host, port=54321, ssl=True):
> I'd default host to localhost
this client is not meant to be used only for local connections. It just 
simplifies ssl and messaging configurations. I would keep it without any 
default value.
Line 580: """
Line 581: Returns JsonRpcClient able to receive jsonrpc messages and 
notifications.
Line 582: It is required to provide a host where we want to connect, port 
and whether
Line 583: we want to use ssl (True by default). Other settings use defaults 
and if


-- 
To view, visit https://gerrit.ovirt.org/59151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: Using startCmd func for running async execution

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: Using startCmd func for running async execution
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60237
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id38507a04a124918f3865cf011bbf5adc7bc31d5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: net: add address.flush family argument

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: net: add address.flush family argument
..


Patch Set 2:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60153
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia149ae17e0546ed0df83576d1b16c68c5c2ccd3e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: Using startCmd func for running async execution

2016-07-07 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: Using startCmd func for running async execution
..


Patch Set 2:

(6 comments)

https://gerrit.ovirt.org/#/c/60237/2/lib/vdsm/commands.py
File lib/vdsm/commands.py:

Line 65: printable = command
Line 66: 
Line 67: execCmdLogger.debug(cmdutils.command_log_line(printable, cwd=cwd))
Line 68: 
Line 69: p = CPopen(command, close_fds=True, cwd=cwd, env=env)
> Replace the code above with:
redundant and its splitting the code and make it uglier 

if deathSignal:
 CPopen(.. deathSignal ...)
else:
 CPopen(...)

_oO_

I leave it as is for now. we'll might want to change the rest of the code as 
well between them, why to force common logic.
lets focus about the split in this patch and keep the same code base. later we 
can factorize this area as we wish.
Line 70: 
Line 71: with terminating(p):
Line 72: (out, err) = p.communicate(data)
Line 73: 


Line 70: 
Line 71: with terminating(p):
Line 72: (out, err) = p.communicate(data)
Line 73: 
Line 74: if out is None:
> I never seen Popen return None, we probably can remove this.
its not related to the patch.. you can post a patch for that separately
Line 75: # Prevent splitlines() from barfing later on
Line 76: out = ""
Line 77: 
Line 78: execCmdLogger.debug(cmdutils.retcode_log_line(p.returncode, 
err=err))


Line 83: 
Line 84: return p.returncode, out, err
Line 85: 
Line 86: 
Line 87: def startCmd(command, sudo=False, cwd=None, data=None, raw=False,
> Remove the data argument.
I prefer to keep the same arguments in this patch. we can remove redundant 
argument later. removing it can expose bugs - so lets do it step by step
Line 88:  printable=None, env=None, nice=None, ioclass=None,
Line 89:  ioclassdata=None, setsid=False, 
execCmdLogger=logging.root,
Line 90:  deathSignal=0, resetCpuAffinity=True):
Line 91: """


Line 85: 
Line 86: 
Line 87: def startCmd(command, sudo=False, cwd=None, data=None, raw=False,
Line 88:  printable=None, env=None, nice=None, ioclass=None,
Line 89:  ioclassdata=None, setsid=False, 
execCmdLogger=logging.root,
> Do we have code using sync=False and execCmdLogger? We should remove this p
same
Line 90:  deathSignal=0, resetCpuAffinity=True):
Line 91: """
Line 92: Executes an external command, optionally via sudo.
Line 93: 


Line 111: 
Line 112: execCmdLogger.debug(cmdutils.command_log_line(printable, cwd=cwd))
Line 113: 
Line 114: p = AsyncProc(CPopen(command, close_fds=True, cwd=cwd, env=env,
Line 115:  deathSignal=deathSignal))
> This should wrap the process returned by the helper.
no helper man ...
maybe in separate patch
Line 116: if data is not None:
Line 117: p.stdin.write(data)
Line 118: p.stdin.flush()
Line 119: 


Line 114: p = AsyncProc(CPopen(command, close_fds=True, cwd=cwd, env=env,
Line 115:  deathSignal=deathSignal))
Line 116: if data is not None:
Line 117: p.stdin.write(data)
Line 118: p.stdin.flush()
> We can drop this part as no code is using this, and the caller can do this.
there are tests that use it
Line 119: 
Line 120: return p
Line 121: 
Line 122: 


-- 
To view, visit https://gerrit.ovirt.org/60237
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id38507a04a124918f3865cf011bbf5adc7bc31d5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: Rename execCmd and startCmd to run_cmd and start_cmd

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: Rename execCmd and startCmd to run_cmd and start_cmd
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60280
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e271c07f204c405483c24b03b2792a25bf4256d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: stomp: simplified client

2016-07-07 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: simplified client
..


Patch Set 8:

(2 comments)

https://gerrit.ovirt.org/#/c/59151/8/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:

Line 1
2014-2016


Line 575: )
Line 576: )
Line 577: 
Line 578: 
Line 579: def SimpleClient(host, port=54321, ssl=True):
I'd default host to localhost
Line 580: """
Line 581: Returns JsonRpcClient able to receive jsonrpc messages and 
notifications.
Line 582: It is required to provide a host where we want to connect, port 
and whether
Line 583: we want to use ssl (True by default). Other settings use defaults 
and if


-- 
To view, visit https://gerrit.ovirt.org/59151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: fcoe hook: enable service

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: fcoe hook: enable service
..


Patch Set 1:

* #1353456::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1353456::OK, public bug
* Check Product::#1353456::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60311
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb3e7c45620ebb4ee80dfe333119a3d0766491ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: fcoe hook: enable service

2016-07-07 Thread danken
Dan Kenigsberg has uploaded a new change for review.

Change subject: fcoe hook: enable service
..

fcoe hook: enable service

When fcoe is requested, we should start fcoe and lldpad immediately, but
also after next boot.

Change-Id: Icb3e7c45620ebb4ee80dfe333119a3d0766491ea
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1353456
Signed-off-by: Dan Kenigsberg 
---
M vdsm_hooks/fcoe/fcoe_before_network_setup.py
1 file changed, 16 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/60311/1

diff --git a/vdsm_hooks/fcoe/fcoe_before_network_setup.py 
b/vdsm_hooks/fcoe/fcoe_before_network_setup.py
index c507c07..eb677fc 100755
--- a/vdsm_hooks/fcoe/fcoe_before_network_setup.py
+++ b/vdsm_hooks/fcoe/fcoe_before_network_setup.py
@@ -209,6 +209,22 @@
 if ret:
 hooking.log('Failed to restart fcoe service. err = %s' % (err))
 
+if changed_fcoe:
+ret, _, err = hooking.execCmd(['/bin/systemctl', 'enable', 'lldpad'])
+if ret:
+hooking.log('Failed to enable lldpad service. err = %s' % (err))
+ret, _, err = hooking.execCmd(['/bin/systemctl', 'enable', 'fcoe'])
+if ret:
+hooking.log('Failed to enable fcoe service. err = %s' % (err))
+else:
+ret, _, err = hooking.execCmd(['/bin/systemctl', 'disable', 'lldpad'])
+if ret:
+hooking.log('Failed to disable lldpad service. err = %s' % (err))
+ret, _, err = hooking.execCmd(['/bin/systemctl', 'disable', 'fcoe'])
+if ret:
+hooking.log('Failed to disable lldpad service. err = %s' % (err))
+
+
 if __name__ == '__main__':
 try:
 main()


-- 
To view, visit https://gerrit.ovirt.org/60311
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb3e7c45620ebb4ee80dfe333119a3d0766491ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: virt: Limit the number of workers in executor

2016-07-07 Thread fromani
Francesco Romani has posted comments on this change.

Change subject: virt: Limit the number of workers in executor
..


Patch Set 18: Code-Review+1

(1 comment)

one minor comment in the tests, overall looks good to me.

https://gerrit.ovirt.org/#/c/57754/18/tests/executorTests.py
File tests/executorTests.py:

Line 177: 
Line 178: # The other tasks shouldn't be unblocked and executed, 
let's check
Line 179: # things go as expected before proceeding (however we 
don't want to
Line 180: # stop and wait on each of the tasks, the first one is 
enough)
Line 181: self.assertFalse(tasks[0].executed.wait(1))
minor: perhaps just use wait(0.01) and check all of them?
Line 182: self.assertEqual([t for t in tasks if 
t.executed.is_set()],
Line 183:  [tasks[-1]])
Line 184: 
Line 185: # Extra tasks are not blocking, they were blocked just by 
the


-- 
To view, visit https://gerrit.ovirt.org/57754
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba56d91474c6b14a1cfe2db827b6fd61843a1db2
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: tests: add helper to read test data

2016-07-07 Thread fromani
Francesco Romani has posted comments on this change.

Change subject: tests: add helper to read test data
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/60271/1/tests/testlib.py
File tests/testlib.py:

Line 567: return wrapper
Line 568: 
Line 569: 
Line 570: def read_data(filename):
Line 571: test_path = os.path.realpath(__file__)
> You are assuming that the test data is in the same directory as the tests, 
this is a good point, but still we have this idiom relatively widespread in the 
tests: 

$ git grep realpath
capsTests.py:39:testPath = os.path.realpath(__file__)
capsTests.py:52:CPU_MAP_FILE = 
os.path.join(os.path.dirname(os.path.realpath(__file__)),
capsTests.py:62:testPath = os.path.realpath(__file__)
capsTests.py:72:testPath = os.path.realpath(__file__)
capsTests.py:85:testPath = os.path.realpath(__file__)
cpuinfo_test.py:33:test_path = os.path.realpath(__file__)
devices/parsing/complex_vm_tests.py:47:test_path = 
os.path.realpath(__file__)
devices/parsing/complex_vm_tests.py:84:test_path = 
os.path.realpath(__file__)
hwinfo_test.py:36:test_path = os.path.realpath(__file__)
iscsiTests.py:51:dirName = os.path.dirname(os.path.realpath(__file__))
momPolicyTests.py:18:path = 
os.path.join(os.path.dirname(os.path.realpath(__file__)),
network/sourcerouting_test.py:36:dirName = 
os.path.dirname(os.path.realpath(__file__))
network/tc_test.py:96:dirName = 
os.path.dirname(os.path.realpath(__file__))
network/tc_test.py:168:dirName = 
os.path.dirname(os.path.realpath(__file__))
schemaValidationTest.py:87:testPath = os.path.realpath(__file__)
testlib.py:571:test_path = os.path.realpath(__file__)
toolTests.py:36:dirName = os.path.dirname(os.path.realpath(__file__))
toolTests.py:299:srcPath = 
os.path.dirname(os.path.dirname(os.path.realpath(__file__)))
utilsTests.py:324:testPath = os.path.realpath(__file__)
vmTests.py:1734:test_path = os.path.realpath(__file__)
vmfakelib.py:98:fakelib_path = os.path.realpath(__file__)


I concur this may not be the best solution, but I believe that splitting test 
data from test code is good practice, and tests often need to load their data.
So the path trick here will be duplicated all around.

Could you please suggest a different approach, perhaps?
Line 572: dir_name = os.path.dirname(test_path)
Line 573: path = os.path.join(dir_name, filename)
Line 574: with open(path) as src:


-- 
To view, visit https://gerrit.ovirt.org/60271
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id69ac8e6c5a2cc113f7573771f90da1dce2bcb74
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: tox: fail make process if required tox version isn't installed.

2016-07-07 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: tox: fail make process if required tox version isn't installed.
..


Patch Set 21:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59306
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: contrib: add simple tool to prettify python dumps

2016-07-07 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change.

Change subject: contrib: add simple tool to prettify python dumps
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/60272
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3962648db542afb4297e7712c017ffa266c52424
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: schema: fix VM.create return value

2016-07-07 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change.

Change subject: schema: fix VM.create return value
..


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.ovirt.org/#/c/60279/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

Line 3608: 
Line 3609: -   description: ''
Line 3610: name: spiceSslCipherSuite
Line 3611: type: string
Line 3612: 
Extra line not needed
Line 3613: type: object
Line 3614: 
Line 3615: VmGraphicsDeviceType: 
Line 3616: added: '3.4'


PS1, Line 4088: enablerd
enabled


PS1, Line 4093: enablerd
enabled


https://gerrit.ovirt.org/#/c/60279/1/lib/api/vdsmapi.py
File lib/api/vdsmapi.py:

Line 255: """
Line 256: This method verify whether argument value align with different
Line 257: types we support such as: alias, map, union, enum and object.
Line 258: """
Line 259: print t_type, name, identifier
please remove
Line 260: if t_type == 'alias':
Line 261: # if alias we need to check sourcetype
Line 262: self._check_primitive_type(t.get('sourcetype'), arg, name)
Line 263: elif t_type == 'map':


-- 
To view, visit https://gerrit.ovirt.org/60279
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I751da2f0b2148c208975ed0e022141b2f19ec60a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org


Change in vdsm[master]: schema: fix VM.create parameters

2016-07-07 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change.

Change subject: schema: fix VM.create parameters
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org