Change in vdsm[ovirt-4.0]: Adding python-setuptools to required ci packages
Francesco Romani has posted comments on this change. Change subject: Adding python-setuptools to required ci packages .. Patch Set 4: no change to production code -> no BZ needed -- To view, visit https://gerrit.ovirt.org/60847 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb72f3e15091bd103718cc1354c135b7b79b7f50 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Adding python-setuptools to required ci packages
Francesco Romani has posted comments on this change. Change subject: Adding python-setuptools to required ci packages .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60847 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb72f3e15091bd103718cc1354c135b7b79b7f50 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Adding python-setuptools to required ci packages
Francesco Romani has posted comments on this change. Change subject: Adding python-setuptools to required ci packages .. Patch Set 4: Continuous-Integration+1 we can't really trust the fc24 CI score without this patch -- To view, visit https://gerrit.ovirt.org/60847 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb72f3e15091bd103718cc1354c135b7b79b7f50 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: doc: Typo fixes and other doc improvements in periodic.py
gerrit-hooks has posted comments on this change. Change subject: doc: Typo fixes and other doc improvements in periodic.py .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59734 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9550acf4c8c8ffde0ae3f7d5aad6e8b9d22fed95 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdscli: added DeprecationWarning to module
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdscli: added DeprecationWarning to module .. vdscli: added DeprecationWarning to module vdscli is deprecated and will be replaced soon by jsonrpccli. since we want to eliminate the calls to vdscli module a DeprecationWarning will be issued once this module will be imported. Change-Id: I728db1ed55e1449000f82c78d26f2774a2650c7e Signed-off-by: Irit Goihman Reviewed-on: https://gerrit.ovirt.org/60318 Continuous-Integration: Jenkins CI Reviewed-by: Yaniv Bronhaim Reviewed-by: Dan Kenigsberg --- M lib/vdsm/vdscli.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Irit Goihman: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60318 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I728db1ed55e1449000f82c78d26f2774a2650c7e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdscli: added DeprecationWarning to module
Dan Kenigsberg has posted comments on this change. Change subject: vdscli: added DeprecationWarning to module .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60318 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I728db1ed55e1449000f82c78d26f2774a2650c7e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdscli: added DeprecationWarning to module
gerrit-hooks has posted comments on this change. Change subject: vdscli: added DeprecationWarning to module .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/60318 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I728db1ed55e1449000f82c78d26f2774a2650c7e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sos report: removed call to vdsClient getVGList
Dan Kenigsberg has submitted this change and it was merged. Change subject: sos report: removed call to vdsClient getVGList .. sos report: removed call to vdsClient getVGList getVGList has been deprecated in patch https://gerrit.ovirt.org/#/c/48998/ and will be fully removed in the future, so the call to it is useless Change-Id: I2c39da7b1b87dd00be3e4302e8f7d7dba76faf0d Signed-off-by: Irit Goihman Reviewed-on: https://gerrit.ovirt.org/60613 Reviewed-by: Yaniv Bronhaim Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer --- M vdsm/sos/vdsm.py.in 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Irit Goihman: Verified -- To view, visit https://gerrit.ovirt.org/60613 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c39da7b1b87dd00be3e4302e8f7d7dba76faf0d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sos report: removed call to vdsClient getVGList
gerrit-hooks has posted comments on this change. Change subject: sos report: removed call to vdsClient getVGList .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/60613 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c39da7b1b87dd00be3e4302e8f7d7dba76faf0d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonrpcvdscli: added getAllTasksInfo verb
Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonrpcvdscli: added getAllTasksInfo verb .. jsonrpcvdscli: added getAllTasksInfo verb getAllTasksInfo verb is needed by sos report Change-Id: I8c02c3aeb35b1b6dbddbdce66f8112aa281a0bc6 Signed-off-by: Irit Goihman Reviewed-on: https://gerrit.ovirt.org/60607 Continuous-Integration: Jenkins CI Reviewed-by: Yaniv Bronhaim Reviewed-by: Nir Soffer --- M lib/vdsm/jsonrpcvdscli.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Irit Goihman: Verified -- To view, visit https://gerrit.ovirt.org/60607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c02c3aeb35b1b6dbddbdce66f8112aa281a0bc6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonrpcvdscli: added getAllTasksInfo verb
gerrit-hooks has posted comments on this change. Change subject: jsonrpcvdscli: added getAllTasksInfo verb .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/60607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c02c3aeb35b1b6dbddbdce66f8112aa281a0bc6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: storage: Support new dd output
Francesco Romani has posted comments on this change. Change subject: storage: Support new dd output .. Patch Set 2: Verified+1 verified on master -same code. Re-verified on branch running 'make check' locally until CI is completely fixed. -- To view, visit https://gerrit.ovirt.org/60857 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I632d99cdc2b41e96a75bdce12e86710241fa0939 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: storage: Support new dd output
Francesco Romani has submitted this change and it was merged. Change subject: storage: Support new dd output .. storage: Support new dd output In Fedora 24 we can find the new dd from coreutils 8.25.5 which has a new fancier output format: Example #1: 1+0 records in 1+0 records out 4096 bytes (4.1 kB, 4.0 KiB) copied, 0.00887814 s, 461 kB/s ^ Example #2: 0+1 records in 0+1 records out 30 bytes copied, 0.00156704 s, 19.1 kB/s Compare with the old dd output found in Fedora 23: Example #1: 1+0 records in 1+0 records out 4096 bytes (4.1 kB) copied, 0.00135703 s, 3.0 MB/s Example #2: 0+1 records in 0+1 records out 30 bytes (30 B) copied, 0.0033204 s, 9.0 kB/s ^^ After a quick glance at the dd manpage, I couldn't find a way to disable the new output, which breaks the storage regex to parse the read speed results. To add compatibility with the new format, without breaking support for older versions, this patch replaces the implementation of storage.check.CheckResult, switching from a regex to a simpler pattern matching using the methods of string objects. Change-Id: I632d99cdc2b41e96a75bdce12e86710241fa0939 Bug-Url: https://bugzilla.redhat.com/1342397 Signed-off-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/56091 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/60857 Reviewed-by: Allon Mureinik --- M lib/vdsm/storage/check.py M tests/storage_check_test.py 2 files changed, 7 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Francesco Romani: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60857 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I632d99cdc2b41e96a75bdce12e86710241fa0939 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: storage: Support new dd output
gerrit-hooks has posted comments on this change. Change subject: storage: Support new dd output .. Patch Set 3: * #1342397::Update tracker: OK * Set MODIFIED::bug 1342397#1342397OK -- To view, visit https://gerrit.ovirt.org/60857 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I632d99cdc2b41e96a75bdce12e86710241fa0939 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Adding python-setuptools to required ci packages
Francesco Romani has posted comments on this change. Change subject: Adding python-setuptools to required ci packages .. Patch Set 4: we'll also need to switch from yum-builddep to dnf, but this is material for another patch I'll post soon. -- To view, visit https://gerrit.ovirt.org/60847 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb72f3e15091bd103718cc1354c135b7b79b7f50 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt net: Change graphics type from network to address
gerrit-hooks has posted comments on this change. Change subject: virt net: Change graphics type from network to address .. Patch Set 12: * #1195208::Update tracker: OK * Set MODIFIED::bug 1195208#1195208OK -- To view, visit https://gerrit.ovirt.org/59336 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0724627bd6c37ce11f943c8818fcd5b559fdf070 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt net: Change graphics type from network to address
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt net: Change graphics type from network to address .. virt net: Change graphics type from network to address This patch changes the graphics listen type of VM/s from a libvirt network name to an address for OVS based display networks. OVS integration has avoided the use of libvirt network entities, for simplicitly and as part of a general effort to eliminate VDSM networking libvirt dependency. With this patch, a VM graphics may be assign to an OVS based host network. NOTE: This patch must be merged with the libvirt hook patch. (id: Ie7d32f9605f9ca99d1e070621) Change-Id: I0724627bd6c37ce11f943c8818fcd5b559fdf070 Bug-Url: https://bugzilla.redhat.com/1195208 Signed-off-by: Edward Haas Reviewed-on: https://gerrit.ovirt.org/59336 Reviewed-by: Petr Horáček Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani Tested-by: Petr Horáček --- M vdsm/virt/vmdevices/graphics.py 1 file changed, 19 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified; Looks good to me, but someone else must approve Francesco Romani: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59336 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0724627bd6c37ce11f943c8818fcd5b559fdf070 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: Restore watermark tracking
Hello Adam Litke,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60889
to review the following change.
Change subject: Live Merge: Restore watermark tracking
..
Live Merge: Restore watermark tracking
Since libvirt 1.2.13, the virConnectGetAllDomainStats API will return
write watermark information for all volumes in the chain. We can use
this information during an active live merge operation to perform
on-demand extension of the merge target (just as we already do for the
active layer). When libvirt does not provide the necessary information,
use a preemptive extension instead.
Change-Id: I52199bb38a2d3f439d33b9e78743c3e611349672
Bug-Url: https://bugzilla.redhat.com/1168327
Signed-off-by: Adam Litke
Signed-off-by: Ala Hino
---
M vdsm/virt/vm.py
1 file changed, 72 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/60889/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 4dd7596..cc50ba7 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -917,6 +917,7 @@
def _getExtendCandidates(self):
ret = []
+mergeCandidates = self._getLiveMergeExtendCandidates()
for drive in self._chunkedDrives():
try:
@@ -929,6 +930,76 @@
ret.append((drive, drive.volumeID, capacity, alloc, physical))
return ret
+
+def _getLiveMergeExtendCandidates(self):
+# The common case is that there are no active jobs.
+if not self.conf['_blockJobs'].values():
+return {}
+
+candidates = {}
+try:
+vm_sample = sampling.stats_cache.get(self.id)
+stats = vmstats.produce(self,
+vm_sample.first_value,
+vm_sample.last_value,
+vm_sample.interval)
+watermarks = stats['watermarks']
+self.log.debug("AHINO: watermarks %s:", watermarks)
+except Exception:
+self.log.exception("Error fetching volumes watermark")
+return {}
+
+for job in self.conf['_blockJobs'].values():
+try:
+drive = self._findDriveByUUIDs(job['disk'])
+except LookupError:
+# After an active layer merge completes the vdsm metadata will
+# be out of sync for a brief period. If we cannot find the old
+# disk then it's safe to skip it.
+self.log.debug("Couldn't find drive %s. After an active"
+ " layer merge completes the vdsm metadata"
+ " will be out of sync for a brief period."
+ " If we cannot find the old disk then it's"
+ " safe to skip it",
+ job['disk'])
+continue
+
+if not drive.blockDev:
+continue
+
+if job['strategy'] == 'commit':
+volumeID = job['baseVolume']
+else:
+self.log.debug("Unrecognized merge strategy '%s'",
+ job['strategy'])
+continue
+
+if volumeID not in watermarks:
+self.log.warning("No watermark info available for %s",
+ volumeID)
+continue
+
+res = self.cif.irs.getVolumeInfo(drive.domainID, drive.poolID,
+ drive.imageID, volumeID)
+if res['status']['code'] != 0:
+self.log.error("Unable to get the info of volume %s (domain: "
+ "%s image: %s)", volumeID, drive.domainID,
+ drive.imageID)
+continue
+volInfo = res['info']
+if volInfo['format'].lower() != 'cow':
+continue
+
+self.log.debug("Adding live merge extension candidate: "
+ "volume=%s allocation=%i", volumeID,
+ watermarks[volumeID])
+candidates[drive.imageID] = {
+'alloc': watermarks[volumeID],
+'physical': int(volInfo['truesize']),
+'capacity': int(volInfo['apparentsize']),
+'volumeID': volumeID}
+
+return candidates
def _chunkedDrives(self):
"""
@@ -4651,20 +4722,8 @@
self.untrackBlockJob(jobUUID)
return response.error('mergeErr')
-# blockCommit will cause data to be written into the base volume.
-# Perform an initial extension to ensure there is enough space to
-# copy all the required data. Normally we'd use monitoring to extend
-# the volume on-demand but internal watermark information is not being
-# reported by libvirt so we must do the ful
Change in vdsm[master]: sampling: Retrieve backing chain stats
gerrit-hooks has posted comments on this change. Change subject: sampling: Retrieve backing chain stats .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60888 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bbb8643d1c86e90d1e2de7cb2a5b00116c71453 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sampling: Retrieve backing chain stats
Ala Hino has uploaded a new change for review.
Change subject: sampling: Retrieve backing chain stats
..
sampling: Retrieve backing chain stats
Update sampling mechanism to retrieve backing chain stats. This is
required to get the allocation value of all volumes in the chain.
These stats will be cachd in a volume UUID to allocatoin value
dictionary.
Based on the allocation value, we will find out how to extend volumes
during live merge. The logic of getting live merge ectend candidates
will be done in a separate patch.
Change-Id: I3bbb8643d1c86e90d1e2de7cb2a5b00116c71453
Signed-off-by: Ala Hino
---
M lib/vdsm/virt/sampling.py
M lib/vdsm/virt/vmstats.py
2 files changed, 27 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/60888/1
diff --git a/lib/vdsm/virt/sampling.py b/lib/vdsm/virt/sampling.py
index 8feaf37..c92fc4a 100644
--- a/lib/vdsm/virt/sampling.py
+++ b/lib/vdsm/virt/sampling.py
@@ -31,6 +31,9 @@
import threading
import time
+# 3rd party libs imports
+import libvirt
+
from vdsm import numa
from vdsm import utils
from vdsm.constants import P_VDSM_RUN, P_VDSM_CLIENT_LOG
@@ -493,17 +496,19 @@
fast_path = acquired and not self._skip_doms
doms = [] # whitelist, meaningful only in the slow path
try:
+flags = libvirt.VIR_CONNECT_GET_ALL_DOMAINS_STATS_BACKING
if fast_path:
# This is expected to be the common case.
# If everything's ok, we can skip all the costly checks.
-bulk_stats = self._conn.getAllDomainStats(self._stats)
+bulk_stats = self._conn.getAllDomainStats(
+self._stats, flags)
else:
# A previous call got stuck, or not every domain
# has properly recovered. Thus we must whitelist domains.
doms = self._get_responsive_doms()
if doms:
bulk_stats = self._conn.domainListGetStats(
-doms, self._stats)
+doms, self._stats, flags)
else:
bulk_stats = []
except Exception:
diff --git a/lib/vdsm/virt/vmstats.py b/lib/vdsm/virt/vmstats.py
index 177e2a9..2f06a66 100644
--- a/lib/vdsm/virt/vmstats.py
+++ b/lib/vdsm/virt/vmstats.py
@@ -21,6 +21,7 @@
import contextlib
import logging
+import os
import six
@@ -43,6 +44,7 @@
cpu(stats, first_sample, last_sample, interval)
networks(vm, stats, first_sample, last_sample, interval)
disks(vm, stats, first_sample, last_sample, interval)
+watermarks(stats, first_sample, last_sample, interval)
balloon(vm, stats, last_sample)
cpu_count(stats, last_sample)
tune_io(vm, stats)
@@ -352,6 +354,24 @@
return stats
+def watermarks(stats, first_sample, last_sample, interval):
+if first_sample is None or last_sample is None:
+return None
+
+watermarks = {}
+for key in last_sample:
+if key.endswith("path"):
+prefix, index, attr = key.split(".", 2)
+path = last_sample[key]
+alloc_key = "block" + "." + index + ".allocation"
+allocation = last_sample[alloc_key]
+vol_uuid = os.path.basename(path)
+watermarks[vol_uuid] = allocation
+
+if watermarks:
+stats['watermarks'] = watermarks
+
+
def _disk_rate(first_sample, first_index, last_sample, last_index, interval):
stats = {}
--
To view, visit https://gerrit.ovirt.org/60888
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3bbb8643d1c86e90d1e2de7cb2a5b00116c71453
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: Restore watermark tracking
gerrit-hooks has posted comments on this change. Change subject: Live Merge: Restore watermark tracking .. Patch Set 1: * #1168327::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1168327::OK, public bug * Check Product::#1168327::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60889 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52199bb38a2d3f439d33b9e78743c3e611349672 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Adding python-setuptools to required ci packages
Yaniv Bronhaim has posted comments on this change. Change subject: Adding python-setuptools to required ci packages .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/60847 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb72f3e15091bd103718cc1354c135b7b79b7f50 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: automation: move master to fc24
Yaniv Bronhaim has posted comments on this change. Change subject: automation: move master to fc24 .. Patch Set 2: but you changed it to run over f24 instead :) http://jenkins.ovirt.org/job/vdsm_4.0_check-patch-fc24-x86_64/12/ : FAILURE either run it over f23 only, or backport this patch. I agree that ovirt-4.0 should run only over f23 -- To view, visit https://gerrit.ovirt.org/60852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c1f04d112ed8eab2e72ba629a3d21ec89536e02 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: Restore watermark tracking
gerrit-hooks has posted comments on this change. Change subject: Live Merge: Restore watermark tracking .. Patch Set 2: * #1168327::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1168327::OK, public bug * Check Product::#1168327::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60889 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52199bb38a2d3f439d33b9e78743c3e611349672 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Adding python-setuptools to required ci packages
Yaniv Bronhaim has posted comments on this change. Change subject: Adding python-setuptools to required ci packages .. Patch Set 4: this is not needed if we continue to run over f23 in ci -- To view, visit https://gerrit.ovirt.org/60847 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb72f3e15091bd103718cc1354c135b7b79b7f50 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: automation: move master to fc24
Sandro Bonazzola has posted comments on this change. Change subject: automation: move master to fc24 .. Patch Set 2: my mistake then, fixing 4.0 branch to not use fc24. you can abandon this patch. -- To view, visit https://gerrit.ovirt.org/60852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c1f04d112ed8eab2e72ba629a3d21ec89536e02 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: automation: move master to fc24
Yaniv Bronhaim has abandoned this change. Change subject: automation: move master to fc24 .. Abandoned ovirt-4.0 should run over f23 -- To view, visit https://gerrit.ovirt.org/60852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I5c1f04d112ed8eab2e72ba629a3d21ec89536e02 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: automation: move master to fc24
gerrit-hooks has posted comments on this change. Change subject: automation: move master to fc24 .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/60852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c1f04d112ed8eab2e72ba629a3d21ec89536e02 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Adding python-setuptools to required ci packages
Yaniv Bronhaim has abandoned this change. Change subject: Adding python-setuptools to required ci packages .. Abandoned this is not needed over f23 -- To view, visit https://gerrit.ovirt.org/60847 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ibb72f3e15091bd103718cc1354c135b7b79b7f50 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: Adding python-setuptools to required ci packages
gerrit-hooks has posted comments on this change. Change subject: Adding python-setuptools to required ci packages .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/60847 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb72f3e15091bd103718cc1354c135b7b79b7f50 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: add createrepo requirement to fc24 ci packages
Yaniv Bronhaim has uploaded a new change for review. Change subject: add createrepo requirement to fc24 ci packages .. add createrepo requirement to fc24 ci packages Change-Id: I1f826dfb5b94e7b92bfe8ca721dfd62d7907206b Signed-off-by: Yaniv Bronhaim --- M automation/check-merged.packages.fc24 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/60893/1 diff --git a/automation/check-merged.packages.fc24 b/automation/check-merged.packages.fc24 index 4c8d12b..995b093 100644 --- a/automation/check-merged.packages.fc24 +++ b/automation/check-merged.packages.fc24 @@ -1,5 +1,6 @@ autoconf automake +createrepo git lago lago-ovirt -- To view, visit https://gerrit.ovirt.org/60893 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1f826dfb5b94e7b92bfe8ca721dfd62d7907206b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: add createrepo requirement to fc24 ci packages
gerrit-hooks has posted comments on this change. Change subject: add createrepo requirement to fc24 ci packages .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60893 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f826dfb5b94e7b92bfe8ca721dfd62d7907206b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: drop painfully ancient vmConf examples
Dan Kenigsberg has uploaded a new change for review. Change subject: drop painfully ancient vmConf examples .. drop painfully ancient vmConf examples These examples are sorely out of date. tests/functional/virtTests.py maybe be more helpful as a reference of how to start a VM. Change-Id: I217d973347f47cd7935d7fba975186c6835bb68b Signed-off-by: Dan Kenigsberg --- D vdsm/vmBootExample.conf D vdsm/vmConfExample.conf D vdsm/withCDExample.conf 3 files changed, 0 insertions(+), 68 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/60894/1 diff --git a/vdsm/vmBootExample.conf b/vdsm/vmBootExample.conf deleted file mode 100644 index 9af2141..000 --- a/vdsm/vmBootExample.conf +++ /dev/null @@ -1,16 +0,0 @@ -#Virtual Machine identification -vmName=ws2003 -#Memory size for the virutal machine in Mbytes -memSize=256 -#The local hard drive image -imageFile="/tmp/WS2003.diskImage" -#Were do send the virtual machine display -#If set to vnc then the server responds with a vnc display for the virtual machine -#access to the virtual machine is then : -display=vnc -#Use file CD-ROM image. -#You can use the host CD-ROM by using /dev/cdrom as filename -#omiting this parameter means no CDROM -cdrom=/home/simong/WS2003_disk1.iso -#Boot on hard disk (c) or CD-ROM (d). Hard disk boot is the default if this parameter is omitted -boot=d diff --git a/vdsm/vmConfExample.conf b/vdsm/vmConfExample.conf deleted file mode 100644 index aa17ad9..000 --- a/vdsm/vmConfExample.conf +++ /dev/null @@ -1,36 +0,0 @@ -#Virtual Machine identification -#vmId=someName -vmId=simon_vm - -#Memory size for the virutal machine in Mbytes -#memSize=number -memSize=256 - -#The local hard drive image -#imageFile="file_name" -imageFile="/data/images/for-qemu/fc5_migrate.vmdk" - -#Were do send the virtual machine display -#If set to vnc then the server responds with a vnc display for the virtual machine -#access to the virtual machine is then : -#display=local | vnc -display=vnc - -#Set the machines MAC address -macAddr=AA:BB:10:0:15:25 - - -#Use file CD-ROM image. -#You can use the host CD-ROM by using /dev/cdrom as filename -#omiting this parameter means no CDROM -#cdrom=/dev/cdrom | fileName - -#Boot on hard disk (c) or CD-ROM (d). Hard disk boot is the default if this parameter is omitted -#boot=c | d - -#Start the machine from saved snapshot -#stateFile="file name" - -#Run the vm using vt or using full emulation mode -#vt=True | False - diff --git a/vdsm/withCDExample.conf b/vdsm/withCDExample.conf deleted file mode 100644 index 7e71e10..000 --- a/vdsm/withCDExample.conf +++ /dev/null @@ -1,16 +0,0 @@ -#Virtual Machine identification -vmName=ws2003 -#Memory size for the virutal machine in Mbytes -memSize=256 -#The local hard drive image -imageFile="/tmp/WS2003.diskImage" -#Were do send the virtual machine display -#If set to vnc then the server responds with a vnc display for the virtual machine -#access to the virtual machine is then : -display=vnc -#Use file CD-ROM image. -#You can use the host CD-ROM by using /dev/cdrom as filename -#omiting this parameter means no CDROM -cdrom=/home/simong/WS2003_disk2.iso -#Boot on hard disk (c) or CD-ROM (d). Hard disk boot is the default if this parameter is omitted -#boot=c -- To view, visit https://gerrit.ovirt.org/60894 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I217d973347f47cd7935d7fba975186c6835bb68b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: drop painfully ancient vmConf examples
gerrit-hooks has posted comments on this change. Change subject: drop painfully ancient vmConf examples .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60894 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I217d973347f47cd7935d7fba975186c6835bb68b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: drop painfully ancient vmConf examples
Francesco Romani has posted comments on this change. Change subject: drop painfully ancient vmConf examples .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60894 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I217d973347f47cd7935d7fba975186c6835bb68b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: openstacknet hook: include after_vm_start hook in rpm
Dan Kenigsberg has uploaded a new change for review.
Change subject: openstacknet hook: include after_vm_start hook in rpm
..
openstacknet hook: include after_vm_start hook in rpm
commit a655be4 excluded an important piece of the code from the
distribution.
Change-Id: I421d9a693bdf8c5ea3689cb4d23d86be81cbaf55
Bug-Url: https://bugzilla.redhat.com/1314371
Signed-off-by: Dan Kenigsberg
---
M vdsm.spec.in
M vdsm_hooks/openstacknet/Makefile.am
2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/60896/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index e8de2df..68ca31e 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1386,6 +1386,7 @@
%{_libexecdir}/%{vdsm_name}/hooks/after_nic_hotplug/openstacknet_utils.py*
%{_libexecdir}/%{vdsm_name}/hooks/after_nic_hotunplug/50_openstacknet
%{_libexecdir}/%{vdsm_name}/hooks/after_nic_hotunplug/openstacknet_utils.py*
+%{_libexecdir}/%{vdsm_name}/hooks/after_vm_start/50_openstacknet
%{_libexecdir}/%{vdsm_name}/hooks/before_device_create/50_openstacknet
%{_libexecdir}/%{vdsm_name}/hooks/before_device_create/openstacknet_utils.py*
%{_libexecdir}/%{vdsm_name}/hooks/before_device_migrate_destination/50_openstacknet
diff --git a/vdsm_hooks/openstacknet/Makefile.am
b/vdsm_hooks/openstacknet/Makefile.am
index da3e470..fe2ac3a 100644
--- a/vdsm_hooks/openstacknet/Makefile.am
+++ b/vdsm_hooks/openstacknet/Makefile.am
@@ -31,6 +31,7 @@
EXTRA_DIST = \
after_device_create.py \
after_device_destroy.py \
+ after_vm_start.py \
before_device_create.py \
before_device_migrate_destination.py \
$(constsfile) \
@@ -64,6 +65,9 @@
$(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/before_nic_hotplug
$(INSTALL_SCRIPT) $(srcdir)/before_device_create.py \
$(DESTDIR)$(vdsmhooksdir)/before_nic_hotplug/50_openstacknet
+ $(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/after_vm_start
+ $(INSTALL_SCRIPT) $(srcdir)/after_vm_start.py \
+ $(DESTDIR)$(vdsmhooksdir)/after_vm_start/50_openstacknet
uninstall-local: uninstall-data-consts uninstall-data-sudoers
$(RM) $(DESTDIR)$(vdsmhooksdir)/after_device_create/50_openstacknet
@@ -74,6 +78,7 @@
$(RM) $(DESTDIR)$(vdsmhooksdir)/before_device_create/50_openstacknet
$(RM)
$(DESTDIR)$(vdsmhooksdir)/before_device_migrate_destination/50_openstacknet
$(RM) $(DESTDIR)$(vdsmhooksdir)/before_nic_hotplug/50_openstacknet
+ $(RM) $(DESTDIR)$(vdsmhooksdir)/after_vm_start/50_openstacknet
install-data-consts:
$(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/after_device_create
--
To view, visit https://gerrit.ovirt.org/60896
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I421d9a693bdf8c5ea3689cb4d23d86be81cbaf55
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: openstacknet hook: include after_vm_start hook in rpm
gerrit-hooks has posted comments on this change. Change subject: openstacknet hook: include after_vm_start hook in rpm .. Patch Set 1: * #1314371::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1314371::OK, public bug * Check Product::#1314371::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I421d9a693bdf8c5ea3689cb4d23d86be81cbaf55 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: openstacknet hook: include after_vm_start hook in rpm
Dan Kenigsberg has uploaded a new change for review.
Change subject: openstacknet hook: include after_vm_start hook in rpm
..
openstacknet hook: include after_vm_start hook in rpm
commit a655be4 excluded an important piece of the code from the
distribution.
Change-Id: I421d9a693bdf8c5ea3689cb4d23d86be81cbaf55
Bug-Url: https://bugzilla.redhat.com/1314371
Signed-off-by: Dan Kenigsberg
---
M vdsm.spec.in
M vdsm_hooks/openstacknet/Makefile.am
2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/60897/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 94a1a67..51d3712 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1403,6 +1403,7 @@
%{_libexecdir}/%{vdsm_name}/hooks/after_nic_hotplug/openstacknet_utils.py*
%{_libexecdir}/%{vdsm_name}/hooks/after_nic_hotunplug/50_openstacknet
%{_libexecdir}/%{vdsm_name}/hooks/after_nic_hotunplug/openstacknet_utils.py*
+%{_libexecdir}/%{vdsm_name}/hooks/after_vm_start/50_openstacknet
%{_libexecdir}/%{vdsm_name}/hooks/before_device_create/50_openstacknet
%{_libexecdir}/%{vdsm_name}/hooks/before_device_create/openstacknet_utils.py*
%{_libexecdir}/%{vdsm_name}/hooks/before_device_migrate_destination/50_openstacknet
diff --git a/vdsm_hooks/openstacknet/Makefile.am
b/vdsm_hooks/openstacknet/Makefile.am
index da3e470..fe2ac3a 100644
--- a/vdsm_hooks/openstacknet/Makefile.am
+++ b/vdsm_hooks/openstacknet/Makefile.am
@@ -31,6 +31,7 @@
EXTRA_DIST = \
after_device_create.py \
after_device_destroy.py \
+ after_vm_start.py \
before_device_create.py \
before_device_migrate_destination.py \
$(constsfile) \
@@ -64,6 +65,9 @@
$(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/before_nic_hotplug
$(INSTALL_SCRIPT) $(srcdir)/before_device_create.py \
$(DESTDIR)$(vdsmhooksdir)/before_nic_hotplug/50_openstacknet
+ $(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/after_vm_start
+ $(INSTALL_SCRIPT) $(srcdir)/after_vm_start.py \
+ $(DESTDIR)$(vdsmhooksdir)/after_vm_start/50_openstacknet
uninstall-local: uninstall-data-consts uninstall-data-sudoers
$(RM) $(DESTDIR)$(vdsmhooksdir)/after_device_create/50_openstacknet
@@ -74,6 +78,7 @@
$(RM) $(DESTDIR)$(vdsmhooksdir)/before_device_create/50_openstacknet
$(RM)
$(DESTDIR)$(vdsmhooksdir)/before_device_migrate_destination/50_openstacknet
$(RM) $(DESTDIR)$(vdsmhooksdir)/before_nic_hotplug/50_openstacknet
+ $(RM) $(DESTDIR)$(vdsmhooksdir)/after_vm_start/50_openstacknet
install-data-consts:
$(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/after_device_create
--
To view, visit https://gerrit.ovirt.org/60897
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I421d9a693bdf8c5ea3689cb4d23d86be81cbaf55
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Dan Kenigsberg
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: openstacknet hook: include after_vm_start hook in rpm
gerrit-hooks has posted comments on this change. Change subject: openstacknet hook: include after_vm_start hook in rpm .. Patch Set 1: Verified-1 * #1314371::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1314371::OK, public bug * Check Product::#1314371::OK, Correct classification oVirt * Check TM::#1314371::ERROR, wrong target milestone for stable branch, ovirt-3.6.9 should match ^.*4.0.* * Check merged to previous::WARN, Still open on branches master -- To view, visit https://gerrit.ovirt.org/60897 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I421d9a693bdf8c5ea3689cb4d23d86be81cbaf55 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sampling: Rename stats_flags variable
Francesco Romani has posted comments on this change. Change subject: sampling: Rename stats_flags variable .. Patch Set 1: Code-Review-1 Not sure about this. What you state is technically correct, but I find the naming choice from libvirt unfortunate on the first place. -- To view, visit https://gerrit.ovirt.org/60862 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaca95656038489f1ce4286e32ab819d78b9524dd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sampling: Retrieve backing chain stats
Francesco Romani has posted comments on this change. Change subject: sampling: Retrieve backing chain stats .. Patch Set 1: we need to asses the performance cost of this patch. -- To view, visit https://gerrit.ovirt.org/60888 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bbb8643d1c86e90d1e2de7cb2a5b00116c71453 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sampling: Retrieve backing chain stats
Francesco Romani has posted comments on this change.
Change subject: sampling: Retrieve backing chain stats
..
Patch Set 1: Code-Review-1
(1 comment)
-1 for visibility
https://gerrit.ovirt.org/#/c/60888/1/lib/vdsm/virt/vmstats.py
File lib/vdsm/virt/vmstats.py:
Line 353:
Line 354: return stats
Line 355:
Line 356:
Line 357: def watermarks(stats, first_sample, last_sample, interval):
please add a test (or few :) about this, mostly to let us see how it will look
like
Line 358: if first_sample is None or last_sample is None:
Line 359: return None
Line 360:
Line 361: watermarks = {}
--
To view, visit https://gerrit.ovirt.org/60888
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bbb8643d1c86e90d1e2de7cb2a5b00116c71453
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sampling: Retrieve backing chain stats
Francesco Romani has posted comments on this change. Change subject: sampling: Retrieve backing chain stats .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/60888/1/lib/vdsm/virt/vmstats.py File lib/vdsm/virt/vmstats.py: Line 43: Line 44: cpu(stats, first_sample, last_sample, interval) Line 45: networks(vm, stats, first_sample, last_sample, interval) Line 46: disks(vm, stats, first_sample, last_sample, interval) Line 47: watermarks(stats, first_sample, last_sample, interval) not sure this fits here. We should use this only in the extension flow, not in the stats reporting flow. Line 48: balloon(vm, stats, last_sample) Line 49: cpu_count(stats, last_sample) Line 50: tune_io(vm, stats) Line 51: PS1, Line 357: watermarks you use only 'last_sample' and 'stats'. This is fine, but then you should drop the unused args. PS1, Line 372: stats['watermarks'] = watermarks if we extract this from the reporting flow (e.g. not call this in produce()), you can just return watermarks. -- To view, visit https://gerrit.ovirt.org/60888 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bbb8643d1c86e90d1e2de7cb2a5b00116c71453 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sos report: replace vdscli with jsonrpcvdscli
gerrit-hooks has posted comments on this change. Change subject: sos report: replace vdscli with jsonrpcvdscli .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cc1ba745dad6d3eba9f480830ea01774eb4db71 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sos report: replace vdscli with jsonrpcvdscli
Irit Goihman has posted comments on this change.
Change subject: sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 3:
(5 comments)
https://gerrit.ovirt.org/#/c/60605/3/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:
Line 117
Line 118
Line 119
Line 120
Line 121
> where is getVdsStats
Done
Line 128
Line 129
Line 130
Line 131
Line 132
> I don't think we need this - jsonrpc probably return list of strings. This
Done
Line 45: # This is hack for import vdsm.config module. because this plugin's
name was
Line 46: # same with vdsm module, so it can not import vdsm.config directly.
And we
Line 47: # keep plugin's name for compatibility.
Line 48: config = _importVdsmPylibModule('config').config
Line 49: jsonrpcvdscli = _importVdsmPylibModule('jsonrpcvdscli')
> I think better to connect here once. not sure how this plugin is running
I added a function for connection setup, but from looking at sos report code I
see that plugin setup is called only once per run so I'm keeping the function
call inside setup.
Line 50:
Line 51: class vdsm(Plugin, RedHatPlugin):
Line 52: """VDSM server related information
Line 53: """
Line 122: requestQueue = requestQueues.split(",")[0]
Line 123: cli = jsonrpcvdscli.connect(requestQueue=requestQueue,)
Line 124:
Line 125: self.addStringAsFile(
Line 126: json.dumps(cli.getVdsCapabilities()),
'cli.getVdsCapabilities')
> Why do we need the "cli." prefix?
Done
Line 127: self.addStringAsFile(
Line 128: json.dumps(cli.getAllVmStats()), 'cli.getAllVmStats')
Line 129: self.addStringAsFile(json.dumps(cli.list()), 'cli.list')
Line 130: self.addStringAsFile(
Line 134: self.addStringAsFile(
Line 135: json.dumps(cli.getAllTasksStatuses()),
'cli.getAllTasksStatuses')
Line 136:
Line 137: pools_list =
cli.getConnectedStoragePoolsList()['status']['message']
Line 138: for line in pools_list.splitlines()[1:-1]:
> why do you cut the last and the first? we need to do so? maybe the vdsClien
Done
Line 139: pool = line.strip()
Line 140: self.addStringAsFile(json.dumps(cli.getSpmStatus(pool)))
Line 141:
Line 142: self.collectExtOutput(
--
To view, visit https://gerrit.ovirt.org/60605
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cc1ba745dad6d3eba9f480830ea01774eb4db71
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman
Gerrit-Reviewer: Irit Goihman
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: Restore watermark tracking
Francesco Romani has posted comments on this change.
Change subject: Live Merge: Restore watermark tracking
..
Patch Set 2:
(4 comments)
-1 for visibility
https://gerrit.ovirt.org/#/c/60889/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS2, Line 920: mergeCandidates
how do you use this?
PS2, Line 936: if not self.conf['_blockJobs'].values():
: return {}
why not just:
if not self.conf['_blockJobs']:
return {}
plus, more important: let's check carefully about the locking here.
PS2, Line 941: stats_cache
please note that this is updated each 15s - and it is modifiable by the users.
Is this good enough for live merge?
PS2, Line 981: getVolumeInfo
how costly is this?
--
To view, visit https://gerrit.ovirt.org/60889
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52199bb38a2d3f439d33b9e78743c3e611349672
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: Restore watermark tracking
Francesco Romani has posted comments on this change. Change subject: Live Merge: Restore watermark tracking .. Patch Set 2: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/60889 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52199bb38a2d3f439d33b9e78743c3e611349672 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: openstacknet hook: include after_vm_start hook in rpm
gerrit-hooks has posted comments on this change. Change subject: openstacknet hook: include after_vm_start hook in rpm .. Patch Set 2: Verified-1 * #1314371::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1314371::OK, public bug * Check Product::#1314371::OK, Correct classification oVirt * Check TM::#1314371::ERROR, wrong target milestone for stable branch, ovirt-3.6.9 should match ^.*4.0.* * Check merged to previous::WARN, Still open on branches master -- To view, visit https://gerrit.ovirt.org/60897 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I421d9a693bdf8c5ea3689cb4d23d86be81cbaf55 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Michael Burman Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sos report: added full module name to _importVdsmPylibModule
gerrit-hooks has posted comments on this change. Change subject: sos report: added full module name to _importVdsmPylibModule .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60627 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab7570d843590ac5fccb669cb13bc758b218655f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sos report: replace vdscli with jsonrpcvdscli
gerrit-hooks has posted comments on this change. Change subject: sos report: replace vdscli with jsonrpcvdscli .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cc1ba745dad6d3eba9f480830ea01774eb4db71 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sos report: added full module name to _importVdsmPylibModule
Irit Goihman has posted comments on this change. Change subject: sos report: added full module name to _importVdsmPylibModule .. Patch Set 5: please ignore last update -- To view, visit https://gerrit.ovirt.org/60627 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab7570d843590ac5fccb669cb13bc758b218655f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: Restore watermark tracking
Francesco Romani has posted comments on this change. Change subject: Live Merge: Restore watermark tracking .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/60889/2/vdsm/virt/vm.py File vdsm/virt/vm.py: PS2, Line 4725: extendDrivesIfNeeded why do you want to run all over all the drives (like extendDrivesIfNeeded() does) and not just the specific drive like the old code did? What's the new need? -- To view, visit https://gerrit.ovirt.org/60889 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52199bb38a2d3f439d33b9e78743c3e611349672 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: vmxml.all_devices removed
gerrit-hooks has posted comments on this change. Change subject: virt: vmxml.all_devices removed .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56105 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ab3c272ab47aa2a298a912266a275bf313c1dfe Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: Use DOM helpers in Vm._getVmPolicy
gerrit-hooks has posted comments on this change. Change subject: virt: Use DOM helpers in Vm._getVmPolicy .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc71252fed1ca1a3706e091c003a7d2459730d0e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: Use DOM helpers in Vm._findGraphicsDeviceXMLByType etc.
gerrit-hooks has posted comments on this change. Change subject: virt: Use DOM helpers in Vm._findGraphicsDeviceXMLByType etc. .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56107 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15b041ab89caa7b967d2a7e0a9d262274a5a3f90 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: Use vmxml DOM helpers in graphics devices
gerrit-hooks has posted comments on this change. Change subject: virt: Use vmxml DOM helpers in graphics devices .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56099 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a50166a083af0d453fce682670efbd058d71bff Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: Use DOM helpers in Vm disk device handling
gerrit-hooks has posted comments on this change. Change subject: virt: Use DOM helpers in Vm disk device handling .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56108 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I165819d5bfaaccc76296f58e7f59d18ad4240fc1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: Use DOM helpers in Vm iotune processing
gerrit-hooks has posted comments on this change. Change subject: virt: Use DOM helpers in Vm iotune processing .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58192 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1dce80e0d2bf85af1387cd7a5200bb66bfee3704 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: Use DOM helpers in _diskXMLGetVolumeChainInfo
gerrit-hooks has posted comments on this change. Change subject: virt: Use DOM helpers in _diskXMLGetVolumeChainInfo .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58189 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I517a6072438071731388d6f56a6f7b22bf3f79db Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: Use DOM helpers in vmxml.device_address
gerrit-hooks has posted comments on this change. Change subject: virt: Use DOM helpers in vmxml.device_address .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56104 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I409b2b290df5ee52418addd008325294594b5283 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: Use vmxml DOM helpers in vmdevices/common.py
gerrit-hooks has posted comments on this change. Change subject: virt: Use vmxml DOM helpers in vmdevices/common.py .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2941f79b65f80152255c27260942efc38f8f8ceb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: Use vmxml DOM helpers in core devices
gerrit-hooks has posted comments on this change. Change subject: virt: Use vmxml DOM helpers in core devices .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56804e394f0a26efeb226a4173f50770769a9512 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: Switch to etree in vmxml.py
gerrit-hooks has posted comments on this change. Change subject: virt: Switch to etree in vmxml.py .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c6d3d6e6bf5ae012f2e0ee4363f742a8cfcdcce Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: Don't use minidom directly in vmxml.Domain
gerrit-hooks has posted comments on this change. Change subject: virt: Don't use minidom directly in vmxml.Domain .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58195 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bcf8157364055685a2b266b4e02073c1ad78c4f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: Return first child from vmxml.xml_to_dom
gerrit-hooks has posted comments on this change. Change subject: virt: Return first child from vmxml.xml_to_dom .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58194 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e4c92c32e8fa88836d9434a3917b758feead277 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: Use DOM helpers in Vm._updateDevicesDomxmlCache
gerrit-hooks has posted comments on this change. Change subject: virt: Use DOM helpers in Vm._updateDevicesDomxmlCache .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia059bde089d60d9a6a16b3884d99bdc3cfe5776e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: Restore watermark tracking
Francesco Romani has posted comments on this change. Change subject: Live Merge: Restore watermark tracking .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/60889/2/vdsm/virt/vm.py File vdsm/virt/vm.py: PS2, Line 4725: extendDrivesIfNeeded > why do you want to run all over all the drives (like extendDrivesIfNeeded() Let me calrify a bit. In the commit message you state: "We can use this information during an active live merge operation to perform on-demand extension of the merge target (just as we already do for the active layer). When libvirt does not provide the necessary information, use a preemptive extension instead." and this is fine, but I think we know exactly which drives we need to extend, no need to run over all of them - right? To summarize, I think it is better to avoid to run too generic code in this flow, and be more specific, avoiding unneeded work. -- To view, visit https://gerrit.ovirt.org/60889 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52199bb38a2d3f439d33b9e78743c3e611349672 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: Use vmxml DOM helpers in storage devices
gerrit-hooks has posted comments on this change. Change subject: virt: Use vmxml DOM helpers in storage devices .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I485b23748779e8161768f5a9a6607d72bffa1eef Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: Use vmxml DOM helpers in network devices
gerrit-hooks has posted comments on this change. Change subject: virt: Use vmxml DOM helpers in network devices .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia31d71f686aaa15e2b1f3064f700398fd4d6a5db Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: Use DOM helpers instead of toxml calls
gerrit-hooks has posted comments on this change. Change subject: virt: Use DOM helpers instead of toxml calls .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58191 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib43255c33fc8aa9116e98fb8ef9a14de9c6c5be3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: Remove vmxml.filter_devices_with_alias helper
gerrit-hooks has posted comments on this change. Change subject: virt: Remove vmxml.filter_devices_with_alias helper .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8199f1607bb3a0562e037a95154a2678387a3cb Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: Use DOM helpers in Vm.setLinkAndNetwork
gerrit-hooks has posted comments on this change. Change subject: virt: Use DOM helpers in Vm.setLinkAndNetwork .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58190 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idba2262b106c6ceb136eeb95defcf07280699ed6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: Use vmxml DOM helpers in host devices
gerrit-hooks has posted comments on this change. Change subject: virt: Use vmxml DOM helpers in host devices .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2015eb48bc5251145d875373f9cdb2639b1816b0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: Use DOM helpers in Vm vcpuLimit processing
gerrit-hooks has posted comments on this change. Change subject: virt: Use DOM helpers in Vm vcpuLimit processing .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58193 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97fc48d926f799cfb7f0b48fb539f221662740b5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tests: Use assertXMLEqual instead of _xml_sanitizer in vmTests
gerrit-hooks has posted comments on this change. Change subject: tests: Use assertXMLEqual instead of _xml_sanitizer in vmTests .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58897 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6dcc429a2992611f463c77e24eab175997dd4d60 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tests: Use assertXMLEqual for XML comparison in vmOperations...
gerrit-hooks has posted comments on this change. Change subject: tests: Use assertXMLEqual for XML comparison in vmOperationsTests .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1eb072e065e954c3b8672c5f0b3ec807daf03b7b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: Use DOM helpers in graphics ticket handling
gerrit-hooks has posted comments on this change. Change subject: virt: Use DOM helpers in graphics ticket handling .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58187 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib46e8ff84c49e619b9390f7c4c76bf1e84efd8a8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: openstacknet hook: include after_vm_start hook in rpm
gerrit-hooks has posted comments on this change. Change subject: openstacknet hook: include after_vm_start hook in rpm .. Patch Set 2: * #1314371::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1314371::OK, public bug * Check Product::#1314371::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I421d9a693bdf8c5ea3689cb4d23d86be81cbaf55 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michael Burman Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers
gerrit-hooks has posted comments on this change. Change subject: virt: Make DomainDescriptor use XML helpers .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/55769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib169735936d19171ff8b8d127666d7258c308f34 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: doc: Typo fixes and other doc improvements in periodic.py
Francesco Romani has posted comments on this change. Change subject: doc: Typo fixes and other doc improvements in periodic.py .. Patch Set 2: Code-Review+2 Thanks, much appreciated. -- To view, visit https://gerrit.ovirt.org/59734 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9550acf4c8c8ffde0ae3f7d5aad6e8b9d22fed95 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storage: add getDeviceList discard related fields
gerrit-hooks has posted comments on this change. Change subject: storage: add getDeviceList discard related fields .. Patch Set 3: * #1241106::Update tracker: OK * #1342919::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1241106::OK, public bug * Check Public Bug::#1342919::OK, public bug * Check Product::#1241106::OK, Correct classification oVirt * Check Product::#1342919::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60628 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ff477dab23a195bd9ce10c36defa35e8a0749d8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: multipath: add the read_int helper function
gerrit-hooks has posted comments on this change. Change subject: multipath: add the read_int helper function .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60856 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c439fca88c56e7ff8ede458fc3d7ae81afb0905 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storage: add getDeviceList discard related fields
Idan Shaby has posted comments on this change.
Change subject: storage: add getDeviceList discard related fields
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/60628/2/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 2012: 'pvsize': str(pvsize),
Line 2013: 'serial': dev.get("serial", ""),
Line 2014: 'vendorID': dev.get("vendor", ""),
Line 2015: 'vgUUID': vguuid,
Line 2016: "discard_max_bytes": dev["discard_max_bytes"],
> dev.get(name) is correct only when you are ok with sending None when the va
Done
Line 2017: "discard_zeroes_data": dev["discard_zeroes_data"],
Line 2018: }
Line 2019: if not checkStatus:
Line 2020: devInfo["status"] = "unknown"
--
To view, visit https://gerrit.ovirt.org/60628
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ff477dab23a195bd9ce10c36defa35e8a0749d8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Idan Shaby
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Tal Nisan
Gerrit-Reviewer: Yaniv Kaul
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: oop: Explicitly close running ioprocesses
Francesco Romani has posted comments on this change. Change subject: oop: Explicitly close running ioprocesses .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60830 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9fce2bcc8a7916dd9e31a8b23a4199611c7938f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: multipath: add the read_int helper function
Idan Shaby has posted comments on this change. Change subject: multipath: add the read_int helper function .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/60856/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2016-07-17 14:26:42 +0300 Line 4: Commit: Idan Shaby Line 5: CommitDate: 2016-07-18 12:17:31 +0300 Line 6: Line 7: multipath: add the read_int helper function > read_int Done Line 8: Line 9: This patch adds a new function that reads the first line of a file noted Line 10: by the given path and returns it as an int. Line 11: It's useful for getting different device attributes from Line 6: Line 7: multipath: add the read_int helper function Line 8: Line 9: This patch adds a new function that reads the first line of a file noted Line 10: by the given path and returns it as an int. > Add that this useful for sysfs attributes. Done Line 11: It's useful for getting different device attributes from Line 12: /sys/block//queue/. Line 13: Line 14: Change-Id: I4c439fca88c56e7ff8ede458fc3d7ae81afb0905 -- To view, visit https://gerrit.ovirt.org/60856 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c439fca88c56e7ff8ede458fc3d7ae81afb0905 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: spec: Require python-ioprocess-0.16.1-1
Francesco Romani has posted comments on this change. Change subject: spec: Require python-ioprocess-0.16.1-1 .. Patch Set 1: Code-Review+1 need to check that ioprocess 0.16.1-1 is available, will merge once it is. -- To view, visit https://gerrit.ovirt.org/60860 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib93b5649981ef423f88d354334bd7d3364f52a0b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: hostdev: move scsi device code to separate class
gerrit-hooks has posted comments on this change. Change subject: hostdev: move scsi device code to separate class .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/57960 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I784c158192433bba1ea4dd330f8a633024b9fec2 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: hostdev: use proper scsi address
gerrit-hooks has posted comments on this change. Change subject: hostdev: use proper scsi address .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60600 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95f8272e1da0a2a718b0d6bcfee2ead8d45d24c6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: hostdev: use specific device classes in HostDevice
gerrit-hooks has posted comments on this change. Change subject: hostdev: use specific device classes in HostDevice .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/57963 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2734b7ec789c0ce57b64d7699cbe967c774bb608 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: network/sr-iov: fix ambiguous log message
Martin Polednik has uploaded a new change for review.
Change subject: network/sr-iov: fix ambiguous log message
..
network/sr-iov: fix ambiguous log message
The log message for detached device used self.device, which, in case of
network device, is just "hostdev". We should show self.hostdev
attribute where the libvirt name of the device is stored.
Change-Id: I2850fdf88c60b14e022854c2120e9979035a0b4f
Signed-off-by: Martin Polednik
---
M vdsm/virt/vmdevices/network.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/05/60905/1
diff --git a/vdsm/virt/vmdevices/network.py b/vdsm/virt/vmdevices/network.py
index 755c794..2577337 100644
--- a/vdsm/virt/vmdevices/network.py
+++ b/vdsm/virt/vmdevices/network.py
@@ -193,7 +193,7 @@
def setup(self):
if self.is_hostdevice:
-logging.debug('Detaching device %s from the host.' % self.device)
+logging.debug('Detaching device %s from the host.' % self.hostdev)
detach_detachable(self.hostdev)
@property
--
To view, visit https://gerrit.ovirt.org/60905
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2850fdf88c60b14e022854c2120e9979035a0b4f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: network/sr-iov: fix ambiguous log message
gerrit-hooks has posted comments on this change. Change subject: network/sr-iov: fix ambiguous log message .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60905 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2850fdf88c60b14e022854c2120e9979035a0b4f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: network/sr-iov: use setup in hotplug routine
gerrit-hooks has posted comments on this change. Change subject: network/sr-iov: use setup in hotplug routine .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60904 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88517f61d286a313e496fd02cb949d38c9b683b3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: network/sr-iov: use setup in hotplug routine
Martin Polednik has uploaded a new change for review.
Change subject: network/sr-iov: use setup in hotplug routine
..
network/sr-iov: use setup in hotplug routine
Setup is new preferred way of setting up a device. Network used code in
hotplugNic method to handle detaching of the device, it's more future
proof to use the setup method.
Change-Id: I88517f61d286a313e496fd02cb949d38c9b683b3
Signed-off-by: Martin Polednik
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/60904/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 4dd7596..491edc0 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -2141,8 +2141,7 @@
self.log.info("Hotplug NIC xml: %s", nicXml)
try:
-if nic.is_hostdevice:
-hostdev.detach_detachable(nicParams[hwclass.HOSTDEV])
+nic.setup()
self._dom.attachDevice(nicXml)
except libvirt.libvirtError as e:
self.log.exception("Hotplug failed")
--
To view, visit https://gerrit.ovirt.org/60904
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I88517f61d286a313e496fd02cb949d38c9b683b3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: network/sr-iov: use device teardown to reattach device
gerrit-hooks has posted comments on this change. Change subject: network/sr-iov: use device teardown to reattach device .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60667 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff3299e4a9baaf02a3b96cd94cdf9871d190b17 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: hostdev: properly detect attached scsi devices
gerrit-hooks has posted comments on this change. Change subject: hostdev: properly detect attached scsi devices .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60601 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5aca2db8dfd73b431e1b7e9255121338ce0e44c1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: hostdev: move usb device code to separate class
gerrit-hooks has posted comments on this change. Change subject: hostdev: move usb device code to separate class .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/57958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I481a966776089f37971a27637e06d21eafabd05c Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: hostdev: properly teardown on hotunplug
gerrit-hooks has posted comments on this change. Change subject: hostdev: properly teardown on hotunplug .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60706 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6af53a48e92c666da915e9c9e6b1ba8f8cd522ba Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: hostdev: improve robustness of libvirt SCSI access
gerrit-hooks has posted comments on this change. Change subject: hostdev: improve robustness of libvirt SCSI access .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58011 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e9983fd309869ebd8a4aacd8bfe42158cd26e64 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: hostdev: cleanup udev files after PCI host devices
gerrit-hooks has posted comments on this change. Change subject: hostdev: cleanup udev files after PCI host devices .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59042 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8af3f4d359768f7857e5f8b2fe6c5f89a5037a51 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: hostdev: move pci device code to separate class
gerrit-hooks has posted comments on this change. Change subject: hostdev: move pci device code to separate class .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/57956 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bceb93c2434ff827406bbf4ee0af30f5726f6af Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
