Change in vdsm[master]: storage: Introduce guarded utilities

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Introduce guarded utilities
..


Patch Set 2:

(10 comments)

https://gerrit.ovirt.org/#/c/61435/2//COMMIT_MSG
Commit Message:

Line 23: 
Line 24: The following rules are currently enforced:
Line 25: - Locks are collected from all entities and sorted
Line 26: - Duplicate locks are removed
Line 27: - Exclusive mode takes precedence over shared mode
We removed this feature, right?
Line 28: 
Line 29: Change-Id: I2b0a204818d44b6205515277f4c2834cb2b7a057


https://gerrit.ovirt.org/#/c/61435/2/lib/vdsm/storage/guarded.py
File lib/vdsm/storage/guarded.py:

Line 34: Provides a guarded context associated with the given entities. 
 Each
Line 35: entity must provide a locks property which holds an iterable of
Line 36: guarded.Lock objects.  The locks associated with the entities 
are
Line 37: filtered for duplicates and sorted according to vdsm locking 
rules.
Line 38: """
We need a class docstring to explain about this class, here we describe the 
entities argument.
Line 39: self._locks = self._collect_locks(entities)
Line 40: self._held_locks = []
Line 41: 
Line 42: def __enter__(self):


Line 44: for lock in self._locks:
Line 45: lock.acquire()
Line 46: self._held_locks.append(lock)
Line 47: except:
Line 48: self._release()
Here we always want to log release failures, so:

try:
self._release()
except:
logging.exception(...)
raise
Line 49: raise
Line 50: 
Line 51: def __exit__(self, exc_type, exc_val, exc_tb):
Line 52: self._release()


Line 47: except:
Line 48: self._release()
Line 49: raise
Line 50: 
Line 51: def __exit__(self, exc_type, exc_val, exc_tb):
If releasing some locks failed, and there was no exception in the context 
(exc_type == None, exc_val == None, exc_tb == None), we should fail with the 
first error inside _release.

If there was an exception in the context, and we are cleaning up before raising 
it, we should not release failures, as it will hide the original error. In this 
case, we like to log release failures.

So maybe _release should raise an error with a description of the failures, 
instead of logging the failures.

Then, we can do here:

try:
self._release()
except:
if exc_type is None:
raise
log.exception("Error releasing locks")
Line 52: self._release()
Line 53: 
Line 54: def _collect_locks(self, entities):
Line 55: locks = set()


Line 62: lock = self._held_locks.pop()
Line 63: try:
Line 64: lock.release()
Line 65: except:
Line 66: log.exception("Exception while releasing lock %r", 
lock)
One issue, we may like to report release failure if called from __exit__.

This is very similar to utils.RollbackContext.

I think the best thing to do here is to collect the errors and raise an error 
describing the failures:

errors = []
while self._held_locks:
lock.self._held_locks.pop()
try:
lock.release()
except Exception as e:
errors.append(e)
if errors:
raise ReleaseError(errors)
Line 67: 
Line 68: 
Line 69: class Lock(object):
Line 70: def __init__(self, ns, name, mode):


Line 65: except:
Line 66: log.exception("Exception while releasing lock %r", 
lock)
Line 67: 
Line 68: 
Line 69: class Lock(object):
Lets document the purpose of this class, adding uniform interface to different 
kinds of locks (resourceManager locks, clusterlock leases).
Line 70: def __init__(self, ns, name, mode):
Line 71: self.ns = ns
Line 72: self.name = name
Line 73: self.mode = mode


Line 69: class Lock(object):
Line 70: def __init__(self, ns, name, mode):
Line 71: self.ns = ns
Line 72: self.name = name
Line 73: self.mode = mode
Having __init__ in the base class will not work well for other lock types.

Lets move down init to the concrete classes, so we have:

class ResourceManagerLock(Lock):

def __init__(self, ns, name, mode):
...

class VolumeLease(Lock):

def __init__(self, sd, img_id, vol_id):
...

@property
def name(self):
return self.vol_id

@property
def ns(self):
return "00_cluster"


I would start with single class - simplest code needed now, and add the base 
class later when we add the second class, if needed. If you want to work now on 
the base class, please also the other class that require it. Otherwise we will 
make the wrong design.
Line 74: 
Line 75: def acquire(self):
Line 76: raise NotImplementedError
Line 77: 


Line 87: def __lt__(self, 

Change in vdsm[master]: storage: Sortable ResourceManager lock namespaces

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Sortable ResourceManager lock namespaces
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/61436/2/lib/vdsm/storage/constants.py
File lib/vdsm/storage/constants.py:

Line 24: 
Line 25: 
Line 26: # ResourceManager Lock Namespaces
Line 27: STORAGE = "00_Storage"
Line 28: LVM_ACTIVATION_NAMESPACE = '01_lvmActivationNS'
I asked in the previous patch - why lvmActivationNS comes before imageNS?

Please check again my comments in 
https://gerrit.ovirt.org/#/c/61436/1/lib/vdsm/storage/constants.py
Line 29: IMAGE_NAMESPACE = '02_imageNS'
Line 30: VOLUME_NAMESPACE = '03_volumeNS'
Line 31: 
Line 32: SECTOR_SIZE = 512


-- 
To view, visit https://gerrit.ovirt.org/61436
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Move IMAGE_NAMESPACE and VOLUME_NAMESPACE to consta...

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Move IMAGE_NAMESPACE and VOLUME_NAMESPACE to 
constants.py
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/61434
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd5d8308b09b418440a29f5ff585ea30b193643f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Move IMAGE_NAMESPACE and VOLUME_NAMESPACE to consta...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Move IMAGE_NAMESPACE and VOLUME_NAMESPACE to 
constants.py
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61434
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd5d8308b09b418440a29f5ff585ea30b193643f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Introduce guarded utilities

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Introduce guarded utilities
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b0a204818d44b6205515277f4c2834cb2b7a057
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Sortable ResourceManager lock namespaces

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Sortable ResourceManager lock namespaces
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61436
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: mount: Support NFS4 mounts with double slash

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: mount: Support NFS4 mounts with double slash
..


Patch Set 1: Code-Review-1

More work needed to make normalize_path work with mounts like "proc".

-- 
To view, visit https://gerrit.ovirt.org/61581
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee85efb6aaff5d3fe887d11d7c4a5045ae72ea57
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Support NFS4 mounts with double slash

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: mount: Support NFS4 mounts with double slash
..


Patch Set 1: Code-Review-1

normalize_path cannot handle "proc" or other special mounts. We need more work 
to make it work.

-- 
To view, visit https://gerrit.ovirt.org/61579
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee85efb6aaff5d3fe887d11d7c4a5045ae72ea57
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Introduce guarded utilities

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Introduce guarded utilities
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/61435/1/lib/vdsm/storage/guarded.py
File lib/vdsm/storage/guarded.py:

Line 49: locks = []
Line 50: for entity in entities:
Line 51: locks.extend(entity.get_rm_locks())
Line 52: 
Line 53: # Exclusive locks always take precedence over shared
> Exactly.  I'll reword it.  I think there are valid scenarios when you'd hav
We decided to remove this handling and let locking errors happen naturally in 
this situation since we can't think of a valid use case now.
Line 54: lock_set = set([l for l in locks if l.mode == 
rm.LockType.exclusive])
Line 55: shared_locks = set([l for l in locks if l.mode == 
rm.LockType.shared])
Line 56: lock_set.update(shared_locks)
Line 57: return sorted(lock_set)


-- 
To view, visit https://gerrit.ovirt.org/61435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b0a204818d44b6205515277f4c2834cb2b7a057
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: mount: Support NFS4 mounts with double slash

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: mount: Support NFS4 mounts with double slash
..

mount: Support NFS4 mounts with double slash

With NFS4, the kernel may present fs_spec using double slashes [1]:

noveria.wodel.wd://vmengine

Instead of the original (normalized) mount path:

noveria.wodel.wd:/vmengine

According to [2], this is unlikely to be fixed in the near future.

This patch normalizes fs_spec read from /proc/mounts, restoring
Mount.isMounted() with NFS4.

[1] http://lists.ovirt.org/pipermail/users/2016-July/041519.html
[2] http://www.spinics.net/lists/util-linux-ng/msg13079.html

Change-Id: Iee85efb6aaff5d3fe887d11d7c4a5045ae72ea57
Reported-By: wodel youchi 
Bug-Url: XXX
Signed-off-by: Nir Soffer 
---
M lib/vdsm/storage/mount.py
M tests/mountTests.py
2 files changed, 21 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/61581/1

diff --git a/lib/vdsm/storage/mount.py b/lib/vdsm/storage/mount.py
index da1179e..dd54225 100644
--- a/lib/vdsm/storage/mount.py
+++ b/lib/vdsm/storage/mount.py
@@ -35,6 +35,8 @@
 from vdsm import supervdsm
 from vdsm import utils
 
+from vdsm.storage import fileUtils
+
 # Common vfs types
 
 VFS_NFS = "nfs"
@@ -58,9 +60,11 @@
 fs_freq = int(fs_freq)
 fs_passno = int(fs_passno)
 
-# We expect normalized inputs for
-# fs_spec and fs_file from the kernel.
-fs_spec = _parseFstabPath(fs_spec)
+# Using NFS4 the kernel shows the mount path with double slashes,
+# regarless of the original (normalized) mount path.
+fs_spec = fileUtils.normalize_path(_parseFstabPath(fs_spec))
+
+# We expect normalized fs_file from the kernel.
 fs_file = _parseFstabPath(fs_file)
 for suffix in (" (deleted)", ):
 if not fs_file.endswith(suffix):
diff --git a/tests/mountTests.py b/tests/mountTests.py
index 0133a3f..3b49b84 100644
--- a/tests/mountTests.py
+++ b/tests/mountTests.py
@@ -184,6 +184,20 @@
 mnt = mount.Mount(fs_spec, fs_file)
 self.assertEqual(mnt.isMounted(), equality)
 
+@permutations([
+# NFS4 using fsid=0 - kernel display mount as server://path instead of
+# normalized server:/path
+(b"server://a/b /mnt/server:_a_b nfs defaults 0 0",),
+
+# Not seen yet, but it should work now
+(b"server:/a//b /mnt/server:_a_b nfs defaults 0 0",),
+(b"server:/a/b// /mnt/server:_a_b nfs defaults 0 0",),
+])
+def test_is_mounted_normalize_kernel_mounts(self, mount_line):
+with fake_mounts([mount_line]):
+mnt = mount.Mount("server:/a/b", "/mnt/server:_a_b")
+self.assertTrue(mnt.isMounted())
+
 def test_is_mounted_with_symlink(self):
 with namedTemporaryDir() as dir:
 file = os.path.join(dir, "file")


-- 
To view, visit https://gerrit.ovirt.org/61581
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee85efb6aaff5d3fe887d11d7c4a5045ae72ea57
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: mount: Support NFS4 mounts with double slash

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: mount: Support NFS4 mounts with double slash
..


Patch Set 1:

Francesco, this a backport for testing by the user reporting this issue.

We will open a bug later.

-- 
To view, visit https://gerrit.ovirt.org/61581
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee85efb6aaff5d3fe887d11d7c4a5045ae72ea57
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: mount: Support NFS4 mounts with double slash

[automation]

gerrit-hooks has posted comments on this change.

Change subject: mount: Support NFS4 mounts with double slash
..


Patch Set 1: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::WARN, Still open on branches master

-- 
To view, visit https://gerrit.ovirt.org/61581
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee85efb6aaff5d3fe887d11d7c4a5045ae72ea57
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: fileUtils: Normalize initial double slashes

[automation]

gerrit-hooks has posted comments on this change.

Change subject: fileUtils: Normalize initial double slashes
..


Patch Set 1: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::WARN, Still open on branches master

-- 
To view, visit https://gerrit.ovirt.org/61580
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa3f8724e9a423263b5676d691308d0188b26935
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: fileUtils: Normalize initial double slashes

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: fileUtils: Normalize initial double slashes
..

fileUtils: Normalize initial double slashes

POSIX allows both /path and //path. The second slash may be interpreted
in an implementation-defined manner. The Linux interpretation seems to
be to ignore the double slash, so it seems to be safe to remove it.

See https://bugs.python.org/issue26329 for more info.

Change-Id: Ifa3f8724e9a423263b5676d691308d0188b26935
Bug-Url: XXX
Signed-off-by: Nir Soffer 
---
M lib/vdsm/storage/fileUtils.py
M tests/fileUtilTests.py
2 files changed, 20 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/61580/1

diff --git a/lib/vdsm/storage/fileUtils.py b/lib/vdsm/storage/fileUtils.py
index 78688d7..dc9b037 100644
--- a/lib/vdsm/storage/fileUtils.py
+++ b/lib/vdsm/storage/fileUtils.py
@@ -39,7 +39,6 @@
 
 from contextlib import closing
 from contextlib import contextmanager
-from os.path import normpath
 from StringIO import StringIO
 
 import six
@@ -116,6 +115,22 @@
 return address.hosttail_join(host, tail)
 
 
+def normpath(path):
+"""
+Normalize file system path.
+
+POSIX allows both /path and //path. The second slash may be interpreted in
+an implementation-defined manner. The Linux interpretation seems to be to
+ignore the double slash, so it seems to be safe to remove it.
+
+See https://bugs.python.org/issue26329 for more info.
+"""
+path = os.path.normpath(path)
+if path.startswith('//'):
+path = path[1:]
+return path
+
+
 def is_port(port_str):
 if port_str.startswith('0'):
 return False
diff --git a/tests/fileUtilTests.py b/tests/fileUtilTests.py
index 28a9cea..0a47dd0 100644
--- a/tests/fileUtilTests.py
+++ b/tests/fileUtilTests.py
@@ -226,10 +226,14 @@
 @permutations([
 # Remote paths without a port
 ("server:/path", "server:/path"),
+("server://path", "server:/path"),
+("server:///path", "server:/path"),
 ("server:/path/", "server:/path"),
 ("server:/pa:th", "server:/pa:th"),
 ("server:/path//", "server:/path"),
 ("server:/", "server:/"),
+("server://", "server:/"),
+("server:///", "server:/"),
 ("12.34.56.78:/", "12.34.56.78:/"),
 ("[2001:db8::60fe:5bf:febc:912]:/", "[2001:db8::60fe:5bf:febc:912]:/"),
 ("server:01234:/", "server:01234:"),


-- 
To view, visit https://gerrit.ovirt.org/61580
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa3f8724e9a423263b5676d691308d0188b26935
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: fileUtils: Normalize initial double slashes

[automation]

gerrit-hooks has posted comments on this change.

Change subject: fileUtils: Normalize initial double slashes
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61578
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa3f8724e9a423263b5676d691308d0188b26935
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Support NFS4 mounts with double slash

[automation]

gerrit-hooks has posted comments on this change.

Change subject: mount: Support NFS4 mounts with double slash
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61579
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee85efb6aaff5d3fe887d11d7c4a5045ae72ea57
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Support NFS4 mounts with double slash

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: mount: Support NFS4 mounts with double slash
..

mount: Support NFS4 mounts with double slash

With NFS4, the kernel may present fs_spec using double slashes [1]:

noveria.wodel.wd://vmengine

Instead of the original (normalized) mount path:

noveria.wodel.wd:/vmengine

According to [2], this is unlikely to be fixed in the near future.

This patch normalizes fs_spec read from /proc/mounts, restoring
Mount.isMounted() with NFS4.

[1] http://lists.ovirt.org/pipermail/users/2016-July/041519.html
[2] http://www.spinics.net/lists/util-linux-ng/msg13079.html

Change-Id: Iee85efb6aaff5d3fe887d11d7c4a5045ae72ea57
Reported-By: wodel youchi 
Bug-Url: XXX
Signed-off-by: Nir Soffer 
---
M lib/vdsm/storage/mount.py
M tests/mountTests.py
2 files changed, 21 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/61579/1

diff --git a/lib/vdsm/storage/mount.py b/lib/vdsm/storage/mount.py
index da1179e..dd54225 100644
--- a/lib/vdsm/storage/mount.py
+++ b/lib/vdsm/storage/mount.py
@@ -35,6 +35,8 @@
 from vdsm import supervdsm
 from vdsm import utils
 
+from vdsm.storage import fileUtils
+
 # Common vfs types
 
 VFS_NFS = "nfs"
@@ -58,9 +60,11 @@
 fs_freq = int(fs_freq)
 fs_passno = int(fs_passno)
 
-# We expect normalized inputs for
-# fs_spec and fs_file from the kernel.
-fs_spec = _parseFstabPath(fs_spec)
+# Using NFS4 the kernel shows the mount path with double slashes,
+# regarless of the original (normalized) mount path.
+fs_spec = fileUtils.normalize_path(_parseFstabPath(fs_spec))
+
+# We expect normalized fs_file from the kernel.
 fs_file = _parseFstabPath(fs_file)
 for suffix in (" (deleted)", ):
 if not fs_file.endswith(suffix):
diff --git a/tests/mountTests.py b/tests/mountTests.py
index 0133a3f..3b49b84 100644
--- a/tests/mountTests.py
+++ b/tests/mountTests.py
@@ -184,6 +184,20 @@
 mnt = mount.Mount(fs_spec, fs_file)
 self.assertEqual(mnt.isMounted(), equality)
 
+@permutations([
+# NFS4 using fsid=0 - kernel display mount as server://path instead of
+# normalized server:/path
+(b"server://a/b /mnt/server:_a_b nfs defaults 0 0",),
+
+# Not seen yet, but it should work now
+(b"server:/a//b /mnt/server:_a_b nfs defaults 0 0",),
+(b"server:/a/b// /mnt/server:_a_b nfs defaults 0 0",),
+])
+def test_is_mounted_normalize_kernel_mounts(self, mount_line):
+with fake_mounts([mount_line]):
+mnt = mount.Mount("server:/a/b", "/mnt/server:_a_b")
+self.assertTrue(mnt.isMounted())
+
 def test_is_mounted_with_symlink(self):
 with namedTemporaryDir() as dir:
 file = os.path.join(dir, "file")


-- 
To view, visit https://gerrit.ovirt.org/61579
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee85efb6aaff5d3fe887d11d7c4a5045ae72ea57
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: fileUtils: Normalize initial double slashes

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: fileUtils: Normalize initial double slashes
..

fileUtils: Normalize initial double slashes

POSIX allows both /path and //path. The second slash may be interpreted
in an implementation-defined manner. The Linux interpretation seems to
be to ignore the double slash, so it seems to be safe to remove it.

See https://bugs.python.org/issue26329 for more info.

Change-Id: Ifa3f8724e9a423263b5676d691308d0188b26935
Bug-Url: XXX
Signed-off-by: Nir Soffer 
---
M lib/vdsm/storage/fileUtils.py
M tests/fileUtilTests.py
2 files changed, 20 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/61578/1

diff --git a/lib/vdsm/storage/fileUtils.py b/lib/vdsm/storage/fileUtils.py
index fcd8829..49ee937 100644
--- a/lib/vdsm/storage/fileUtils.py
+++ b/lib/vdsm/storage/fileUtils.py
@@ -36,8 +36,6 @@
 import types
 import warnings
 
-from os.path import normpath
-
 import six
 
 from vdsm import constants
@@ -106,6 +104,22 @@
 return address.hosttail_join(host, tail)
 
 
+def normpath(path):
+"""
+Normalize file system path.
+
+POSIX allows both /path and //path. The second slash may be interpreted in
+an implementation-defined manner. The Linux interpretation seems to be to
+ignore the double slash, so it seems to be safe to remove it.
+
+See https://bugs.python.org/issue26329 for more info.
+"""
+path = os.path.normpath(path)
+if path.startswith('//'):
+path = path[1:]
+return path
+
+
 def is_port(port_str):
 if port_str.startswith('0'):
 return False
diff --git a/tests/fileUtilTests.py b/tests/fileUtilTests.py
index a9a7270..ec4c278 100644
--- a/tests/fileUtilTests.py
+++ b/tests/fileUtilTests.py
@@ -180,10 +180,14 @@
 @permutations([
 # Remote paths without a port
 ("server:/path", "server:/path"),
+("server://path", "server:/path"),
+("server:///path", "server:/path"),
 ("server:/path/", "server:/path"),
 ("server:/pa:th", "server:/pa:th"),
 ("server:/path//", "server:/path"),
 ("server:/", "server:/"),
+("server://", "server:/"),
+("server:///", "server:/"),
 ("12.34.56.78:/", "12.34.56.78:/"),
 ("[2001:db8::60fe:5bf:febc:912]:/", "[2001:db8::60fe:5bf:febc:912]:/"),
 ("server:01234:/", "server:01234:"),


-- 
To view, visit https://gerrit.ovirt.org/61578
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa3f8724e9a423263b5676d691308d0188b26935
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: netinfo.dhcp - dhcp info update refactoring

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: netinfo.dhcp - dhcp info update refactoring
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/61457
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd64d67f52ac30c97e0730035dbe35c9c4e3c098
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhcp reporting based on dhclient daemon state

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: dhcp reporting based on dhclient daemon state
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/61458
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I346b8d2d52a457a3cffd543a8da800edd53ce186
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: clusterlock: Support for multiple leases

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: clusterlock: Support for multiple leases
..


Patch Set 7:

Same with block storage:

jsonrpc.Executor/6::INFO::2016-07-27 
19:22:49,639::clusterlock::246::Storage.SANLock::(acquireHostId) Acquiring host 
id for domain 5f35b5c0-17d7-4475-9125-e97f1cdb06f9 (id: 1)

jsonrpc.Executor/6::INFO::2016-07-27 
19:22:49,775::clusterlock::307::Storage.SANLock::(acquire) Acquiring 
Lease(name='SDM', path='/dev/5f35b5c0-17d7-4475-9125-e97f1cdb06f9/leases', 
offset=1048576) for host id 1

jsonrpc.Executor/6::INFO::2016-07-27 
19:22:53,055::clusterlock::352::Storage.SANLock::(release) Releasing 
Lease(name='SDM', 
path=u'/rhev/data-center/mnt/dumbo.tlv.redhat.com:_export_voodoo_02/a879709e-26e5-4c3e-ac5d-f437e5bbc95b/dom_md/leases',
 offset=1048576)
jsonrpc.Executor/6::INFO::2016-07-27 

Thread-29::INFO::2016-07-27 
19:22:53,245::clusterlock::269::Storage.SANLock::(releaseHostId) Releasing host 
id for domain a879709e-26e5-4c3e-ac5d-f437e5bbc95b (id: 1)

-- 
To view, visit https://gerrit.ovirt.org/60422
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7903b13bd017e3da6762e8979f7f4dfc6520de9e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: netinfo.dhcp - dhcp info update refactoring

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: netinfo.dhcp - dhcp info update refactoring
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/61457/1/lib/vdsm/network/netinfo/dhcp.py
File lib/vdsm/network/netinfo/dhcp.py:

PS1, Line 27: dev_info['dhcpv4'] = network_info['dhcpv4']
: dev_info['dhcpv6'] = network_info['dhcpv6']
> shouldn't this be the other way around? network_info[...] = dev_info[...]?
Nope, it is setting the net device dhcp data, copying it from the already 
updated network data.
(same logic as the original)


-- 
To view, visit https://gerrit.ovirt.org/61457
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd64d67f52ac30c97e0730035dbe35c9c4e3c098
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhcp reporting based on dhclient daemon state

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: dhcp reporting based on dhclient daemon state
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/61458/1//COMMIT_MSG
Commit Message:

PS1, Line 19: existence
> existence
Done


-- 
To view, visit https://gerrit.ovirt.org/61458
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I346b8d2d52a457a3cffd543a8da800edd53ce186
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhcp reporting based on dhclient daemon state

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: dhcp reporting based on dhclient daemon state
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61458
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I346b8d2d52a457a3cffd543a8da800edd53ce186
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: clusterlock: Support for multiple leases

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: clusterlock: Support for multiple leases
..


Patch Set 7:

Log using this patch:

Starting spm:

7b810c6a-b74d-456f-b01d-dcc0343524f1::INFO::2016-07-27 
19:13:19,343::clusterlock::307::Storage.SANLock::(acquire) Acquiring 
Lease(name='SDM', path=u'/rhev/data-center/mnt/du
mbo.tlv.redhat.com:_export_voodoo_02/a879709e-26e5-4c3e-ac5d-f437e5bbc95b/dom_md/leases',
 offset=1048576) for host id 2
7b810c6a-b74d-456f-b01d-dcc0343524f1::DEBUG::2016-07-27 
19:13:19,464::clusterlock::334::Storage.SANLock::(acquire) Successfully 
acquired Lease(name='SDM', 
path=u'/rhev/data-center/mnt/dumbo.tlv.redhat.com:_export_voodoo_02/a879709e-26e5-4c3e-ac5d-f437e5bbc95b/dom_md/leases',
 offset=1048576) for host id 2

Stopping spm:

jsonrpc.Executor/4::INFO::2016-07-27 
19:21:00,580::clusterlock::352::Storage.SANLock::(release) Releasing 
Lease(name='SDM', 
path=u'/rhev/data-center/mnt/dumbo.tlv.redhat.com:_export_voodoo_02/a879709e-26e5-4c3e-ac5d-f437e5bbc95b/dom_md/leases',
 offset=1048576)
jsonrpc.Executor/4::DEBUG::2016-07-27 
19:21:00,656::clusterlock::362::Storage.SANLock::(release) Successfully 
released Lease(name='SDM', 
path=u'/rhev/data-center/mnt/dumbo.tlv.redhat.com:_export_voodoo_02/a879709e-26e5-4c3e-ac5d-f437e5bbc95b/dom_md/leases',
 offset=1048576)

-- 
To view, visit https://gerrit.ovirt.org/60422
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7903b13bd017e3da6762e8979f7f4dfc6520de9e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ifcfg: write current DNS information to a management network...

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: ifcfg: write current DNS information to a management network's 
ifcfg file
..


Patch Set 5: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/61184
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie10ee7938b26a7f3b2b7be80bc1a2a83cd1c376c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Silently skip persisting a non-existent running-config

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Silently skip persisting a non-existent running-config
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/60744
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If95795f79872d0ae404c4fc4b3be1babac1e2d24
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhcp reporting based on dhclient daemon state

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: dhcp reporting based on dhclient daemon state
..


Patch Set 1: Code-Review-1

(1 comment)

Just a nit, great work!

https://gerrit.ovirt.org/#/c/61458/1//COMMIT_MSG
Commit Message:

PS1, Line 19: existance
existence


-- 
To view, visit https://gerrit.ovirt.org/61458
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I346b8d2d52a457a3cffd543a8da800edd53ce186
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: sampling: add is_empty() method to StatsSample

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: virt: sampling: add is_empty() method to StatsSample
..


Patch Set 6: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 5

-- 
To view, visit https://gerrit.ovirt.org/61420
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bc3712d36c46ade9a779411028817c197ec34b3
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Silently skip persisting a non-existent running-config

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Silently skip persisting a non-existent running-config
..


Patch Set 4:

* #1329387::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1329387::OK, public bug
* Check Product::#1329387::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60744
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If95795f79872d0ae404c4fc4b3be1babac1e2d24
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Silently skip persisting a non-existent running-config

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Silently skip persisting a non-existent running-config
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/60744/3//COMMIT_MSG
Commit Message:

PS3, Line 7: non existance
> non-existent
Done


-- 
To view, visit https://gerrit.ovirt.org/60744
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If95795f79872d0ae404c4fc4b3be1babac1e2d24
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: Cleanup _fakeTypeDetection

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net test: Cleanup _fakeTypeDetection
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/61362
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43a456051f9ad4d50fa4ebaff584bc2828980608
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Silently skip persisting a non existance running-config

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Silently skip persisting a non existance running-config
..


Patch Set 3: Code-Review-1

(1 comment)

Just a nit.

https://gerrit.ovirt.org/#/c/60744/3//COMMIT_MSG
Commit Message:

PS3, Line 7: non existance
non-existent


-- 
To view, visit https://gerrit.ovirt.org/60744
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If95795f79872d0ae404c4fc4b3be1babac1e2d24
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: periodic: fix stats age reporting

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: periodic: fix stats age reporting
..


Patch Set 11:

* #1357798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1357798::OK, public bug
* Check Product::#1357798::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61310
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e61626625a2e0517d55dc61e361f3f5eb690c00
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sampling: micro-optimization

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sampling: micro-optimization
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61311
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4361bf4ccae67be3a9e42a0d3368e1e1c246393
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: sampling: add is_empty() method to StatsSample

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: sampling: add is_empty() method to StatsSample
..


Patch Set 6:

* #1357798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1357798::OK, public bug
* Check Product::#1357798::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61420
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bc3712d36c46ade9a779411028817c197ec34b3
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: introduce acquire module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: introduce acquire module
..


Patch Set 10:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I180cfd7d69c0ae0a24188bc3d909b9d3d7c12145
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: introduce acquire module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: introduce acquire module
..


Patch Set 9:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I180cfd7d69c0ae0a24188bc3d909b9d3d7c12145
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spec: Require sanlock version handling EINTR

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: spec: Require sanlock version handling EINTR
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/61200/6//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: spec: Require sanlock version handling EINTR
Line 8: 
Line 9: libsanlock was not handling EINTR, causing failures in sanlock calls if 
vdsm
Line 10: received a signal while libsnalock was block in a syscall. A typical 
case is
> lines seem a bit long, don't they?
Indeed, fixed in latest version.
Line 11: when child process terminates and vdsm receive a SIGCHLD.
Line 12: 
Line 13: When this happens, the vdsm operation fails with this error:
Line 14: 


-- 
To view, visit https://gerrit.ovirt.org/61200
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1203ad58f0f0ed1789a1e85d7f0b364891ef5864
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spec: Require sanlock version handling EINTR

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Require sanlock version handling EINTR
..


Patch Set 7:

* #1356676::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356676::OK, public bug
* Check Product::#1356676::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61200
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1203ad58f0f0ed1789a1e85d7f0b364891ef5864
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spec: Require sanlock version handling EINTR

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: spec: Require sanlock version handling EINTR
..


Patch Set 6: Code-Review+1

(1 comment)

Huh! The CI failure, oddly enough, proves that the patch is correct :-)

https://gerrit.ovirt.org/#/c/61200/6//COMMIT_MSG
Commit Message:

PS6, Line 9: libsanlock was not handling EINTR, causing failures in sanlock 
calls if vdsm
   : received a signal while libsnalock was block in a syscall. A 
typical case is
lines seem a bit long, don't they?


-- 
To view, visit https://gerrit.ovirt.org/61200
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1203ad58f0f0ed1789a1e85d7f0b364891ef5864
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sampling: micro-optimization

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sampling: micro-optimization
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61311
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4361bf4ccae67be3a9e42a0d3368e1e1c246393
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: sampling: add empty() method to StatsSample

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: sampling: add empty() method to StatsSample
..


Patch Set 5:

* #1357798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1357798::OK, public bug
* Check Product::#1357798::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61420
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bc3712d36c46ade9a779411028817c197ec34b3
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: periodic: fix stats age reporting

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: periodic: fix stats age reporting
..


Patch Set 10:

* #1357798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1357798::OK, public bug
* Check Product::#1357798::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61310
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e61626625a2e0517d55dc61e361f3f5eb690c00
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: Make DomainDescriptor use XML helpers
..


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 78: result = [element] + result
Line 79: return result
Line 80: 
Line 81: 
Line 82: def dom_find_tag(element, tag, index=0):
> We can return None only on explicit required=False and raise NotFound other
Please don't add required=False argument and do not return None, raising 
exceptions is the best way here.
Line 83: """
Line 84: Find a DOM element specified by given arguments.
Line 85: 
Line 86: :param element: DOM object to be searched for given `tag`


-- 
To view, visit https://gerrit.ovirt.org/55769
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib169735936d19171ff8b8d127666d7258c308f34
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Make DomainDescriptor use XML helpers
..


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 78: result = [element] + result
Line 79: return result
Line 80: 
Line 81: 
Line 82: def dom_find_tag(element, tag, index=0):
> I would raise some NotFound error if there is no such element.  Returning N
We can return None only on explicit required=False and raise NotFound 
otherwise. Some helpers, typically dom_text, work fine when the element is None 
-- it's better than wrapping xml data access with exception handling or other 
extra checks when the intention (specified by required=False) is clear. I'll 
check how it'd look in practice.
Line 83: """
Line 84: Find a DOM element specified by given arguments.
Line 85: 
Line 86: :param element: DOM object to be searched for given `tag`


-- 
To view, visit https://gerrit.ovirt.org/55769
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib169735936d19171ff8b8d127666d7258c308f34
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: sampling: add empty() method to StatsSample

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: sampling: add empty() method to StatsSample
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/61420/4/lib/vdsm/virt/sampling.py
File lib/vdsm/virt/sampling.py:

Line 351:'interval', 'stats_age'])
Line 352: 
Line 353: 
Line 354: class StatsSample(_StatsSample):
Line 355: def empty(self):
> I'm not a big fan this naming convention, but in this case calling this is_
will rename is_empty()
Line 356: return (
Line 357: self.first_value is None and
Line 358: self.last_value is None and
Line 359: self.interval is None


-- 
To view, visit https://gerrit.ovirt.org/61420
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bc3712d36c46ade9a779411028817c197ec34b3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spec: Require sanlock version handling EINTR

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: spec: Require sanlock version handling EINTR
..


Patch Set 6:

The packages are not released yet, CI failure is correct.

-- 
To view, visit https://gerrit.ovirt.org/61200
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1203ad58f0f0ed1789a1e85d7f0b364891ef5864
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: sampling: add empty() method to StatsSample

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: virt: sampling: add empty() method to StatsSample
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/61420/4/lib/vdsm/virt/sampling.py
File lib/vdsm/virt/sampling.py:

Line 351:'interval', 'stats_age'])
Line 352: 
Line 353: 
Line 354: class StatsSample(_StatsSample):
Line 355: def empty(self):
I'm not a big fan this naming convention, but in this case calling this 
is_empty() would be clearer. At first glance, I thought that it returns an 
EMPTY_SAMPLE.
Line 356: return (
Line 357: self.first_value is None and
Line 358: self.last_value is None and
Line 359: self.interval is None


-- 
To view, visit https://gerrit.ovirt.org/61420
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bc3712d36c46ade9a779411028817c197ec34b3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: Make DomainDescriptor use XML helpers
..


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 78: result = [element] + result
Line 79: return result
Line 80: 
Line 81: 
Line 82: def dom_find_tag(element, tag, index=0):
> Most often we want the first element, there's just one exception (besides t
I would raise some NotFound error if there is no such element.  Returning None 
is error prone, and leads to hard to debug code (the value is accessed later in 
the flow, we will have unrelated AttributeError).
Line 83: """
Line 84: Find a DOM element specified by given arguments.
Line 85: 
Line 86: :param element: DOM object to be searched for given `tag`


-- 
To view, visit https://gerrit.ovirt.org/55769
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib169735936d19171ff8b8d127666d7258c308f34
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Move IMAGE_NAMESPACE and VOLUME_NAMESPACE to consta...

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Move IMAGE_NAMESPACE and VOLUME_NAMESPACE to 
constants.py
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/61434/1//COMMIT_MSG
Commit Message:

Line 4: Commit: Adam Litke 
Line 5: CommitDate: 2016-07-26 17:06:09 -0400
Line 6: 
Line 7: storage: Move IMAGE_NAMESPACE and VOLUME_NAMESPACE to constants.py
Line 8: 
> Can you explain why this is needed here?
Done
Line 9: Change-Id: Icd5d8308b09b418440a29f5ff585ea30b193643f


-- 
To view, visit https://gerrit.ovirt.org/61434
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd5d8308b09b418440a29f5ff585ea30b193643f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: EXPERIMENT: move static files to their subfolder

[automation]

gerrit-hooks has posted comments on this change.

Change subject: EXPERIMENT: move static files to their subfolder
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icaa04c99399c013a640a985dd4da6d9b48c8fea8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Make DomainDescriptor use XML helpers
..


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 78: result = [element] + result
Line 79: return result
Line 80: 
Line 81: 
Line 82: def dom_find_tag(element, tag, index=0):
> Aren't actually interested always in the first element?
Most often we want the first element, there's just one exception (besides 
tests) that we can handle separately. So we can omit `index' and use find_first 
method (maybe with optional `required' argument to be able to explicitly 
specify the presence of the element?).
Line 83: """
Line 84: Find a DOM element specified by given arguments.
Line 85: 
Line 86: :param element: DOM object to be searched for given `tag`


-- 
To view, visit https://gerrit.ovirt.org/55769
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib169735936d19171ff8b8d127666d7258c308f34
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: Make DomainDescriptor use XML helpers
..


Patch Set 8:

(2 comments)

https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 78: result = [element] + result
Line 79: return result
Line 80: 
Line 81: 
Line 82: def dom_find_tag(element, tag, index=0):
> We are typically interested in just a single element, not all elements of t
Aren't actually interested always in the first element?

If we never use index > 0, I would just add a method to return the first 
element, maybe find_first(element, tag).

We should be careful not to offer to generic interfaces that we will have to 
maintain later.
Line 83: """
Line 84: Find a DOM element specified by given arguments.
Line 85: 
Line 86: :param element: DOM object to be searched for given `tag`


Line 98: except IndexError:
Line 99: return None
Line 100: 
Line 101: 
Line 102: def dom_find_attr(element, tag, attribute=True, index=0):
Same here
Line 103: """
Line 104: Find attribute values of a DOM element specified by given 
arguments.
Line 105: 
Line 106: :param element: DOM object to be searched for given `tag`


-- 
To view, visit https://gerrit.ovirt.org/55769
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib169735936d19171ff8b8d127666d7258c308f34
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt net: Interface default driver name set to 'vhost'

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt net: Interface default driver name set to 'vhost'
..


Patch Set 4:

* #1359520::Update tracker: OK
* Set MODIFIED::bug 1359520#1359520FAILED, illegal change from NEW

-- 
To view, visit https://gerrit.ovirt.org/61297
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I508675f9dd40ba70803938902a1c2f8fced00504
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt net: Interface default driver name set to 'vhost'

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt net: Interface default driver name set to 'vhost'
..


virt net: Interface default driver name set to 'vhost'

When following these steps:
- Create a VM with vnic_profile that has queues custom properties.
- Start the VM.
- Hot-unplug the vNIC from the VM.

An exception occurs:
libvirtError: unsupported configuration:
Unknown interface  has been specified

Due to a missing default driver name.


Change-Id: I508675f9dd40ba70803938902a1c2f8fced00504
Bug-Url: https://bugzilla.redhat.com/1359520
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/61297
Continuous-Integration: Jenkins CI
Tested-by: Meni Yakove 
Reviewed-by: Dan Kenigsberg 
Reviewed-by: Petr Horáček 
---
M vdsm/virt/vmdevices/network.py
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Meni Yakove: Verified
  Jenkins CI: Passed CI tests
  Petr Horáček: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/61297
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I508675f9dd40ba70803938902a1c2f8fced00504
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Make DomainDescriptor use XML helpers
..


Patch Set 8:

(2 comments)

https://gerrit.ovirt.org/#/c/55769/8//COMMIT_MSG
Commit Message:

Line 33: DomainDescriptor class from minidom to XML helpers.  The reason for 
this
Line 34: start is that DomainDescriptor class is simple while it requires most 
of
Line 35: the needed XML helpers.  So we can start with a small change of the
Line 36: existent code while becoming equipped with a nice set XML helpers for
Line 37: the following, perhaps more complicated, patches.
> I think we have a good plan.
Thank you for reviewing the plan, now when we all agree on it, I'll proceed 
with polishing the patches.
Line 38: 
Line 39: Change-Id: Ib169735936d19171ff8b8d127666d7258c308f34


https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 78: result = [element] + result
Line 79: return result
Line 80: 
Line 81: 
Line 82: def dom_find_tag(element, tag, index=0):
> This is strange helper - why do we need it?
We are typically interested in just a single element, not all elements of the 
given tag. So a common (minidom) pattern is

  element.getElementsByTagName(tag_name)[0]

when the given tag must be present or something like (in different forms at 
different places)
  
  found = element.getElementsByTagName(tag_name)
  result = found[0] if found else None

when the tag is optional.

So the helper is introduced for two reasons:
- Convenience.
- Avoiding using different patterns for the same purpose at different places.
Line 83: """
Line 84: Find a DOM element specified by given arguments.
Line 85: 
Line 86: :param element: DOM object to be searched for given `tag`


-- 
To view, visit https://gerrit.ovirt.org/55769
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib169735936d19171ff8b8d127666d7258c308f34
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt net: Interface default driver name set to 'vhost'

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: virt net: Interface default driver name set to 'vhost'
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/61297
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I508675f9dd40ba70803938902a1c2f8fced00504
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt net: Interface default driver name set to 'vhost'

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt net: Interface default driver name set to 'vhost'
..


Patch Set 3:

* #1359520::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1359520::OK, public bug
* Check Product::#1359520::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61297
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I508675f9dd40ba70803938902a1c2f8fced00504
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: modprobe: set bonding max_bonds to 0

[fabiand]

Fabian Deutsch has posted comments on this change.

Change subject: modprobe: set bonding max_bonds to 0
..


Patch Set 4: Code-Review+1

I think there is a good chance that this will work (at least on node).

On node we are rebuilding initrd on each image update (and after installation). 
This means that the contents of modprobe.d will be in initrd. 
Now, whenever the bond module is loaded the first time (either in initrd or 
userspace) then the modprobe.d conf is there, which should ensure that bond0 is 
not getting created.

-- 
To view, visit https://gerrit.ovirt.org/61396
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic264e8a89eb07b8da42494a9b12ac9c871f78c51
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt net: Interface default driver name set to 'vhost'

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt net: Interface default driver name set to 'vhost'
..


Patch Set 2:

* #1359520::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1359520::OK, public bug
* Check Product::#1359520::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61297
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I508675f9dd40ba70803938902a1c2f8fced00504
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt net: Interface default driver name set to 'vhost'

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: virt net: Interface default driver name set to 'vhost'
..


Patch Set 1: -Code-Review

-- 
To view, visit https://gerrit.ovirt.org/61297
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I508675f9dd40ba70803938902a1c2f8fced00504
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: modprobe: set bonding max_bonds to 0

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: modprobe: set bonding max_bonds to 0
..


Patch Set 4:

Code wise, I believe there isn't anything wrong. My approval would be based on 
assumption that network team will investigate possibility to remove the hack in 
future by contacting relevant parties.

One question remains unanswered though - 
"Unfortunately, this solution is not consistent.
the /etc/modprobe.d/* may be loaded after the kernel module is, making it 
irrelevant for the existing state." - is it true in this case?

-- 
To view, visit https://gerrit.ovirt.org/61396
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic264e8a89eb07b8da42494a9b12ac9c871f78c51
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt net: Interface default driver name set to 'vhost'

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: virt net: Interface default driver name set to 'vhost'
..


Patch Set 1: Code-Review-1

(1 comment)

-1 just for attention

https://gerrit.ovirt.org/#/c/61297/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2016-07-25 12:04:39 +0300
Line 4: Commit: Edward Haas 
Line 5: CommitDate: 2016-07-25 12:04:39 +0300
Line 6: 
Line 7: virt net: Interface default driver name set to 'vhost'
why?
Line 8: 
Line 9: Change-Id: I508675f9dd40ba70803938902a1c2f8fced00504
Line 10: Bug-Url: https://bugzilla.redhat.com/1359520


-- 
To view, visit https://gerrit.ovirt.org/61297
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I508675f9dd40ba70803938902a1c2f8fced00504
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: EXPERIMENT: move static files to their subfolder

[automation]

gerrit-hooks has posted comments on this change.

Change subject: EXPERIMENT: move static files to their subfolder
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icaa04c99399c013a640a985dd4da6d9b48c8fea8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: makefile: remove unused stuff

[automation]

gerrit-hooks has posted comments on this change.

Change subject: makefile: remove unused stuff
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61545
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10865cf3b48b5572708fd34bdeb6e5a178f38398
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: introduce acquire module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: introduce acquire module
..


Patch Set 8:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I180cfd7d69c0ae0a24188bc3d909b9d3d7c12145
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Revert "NetworkManager: configure to monitor ifcfg/connectio...

[fabiand]

Fabian Deutsch has posted comments on this change.

Change subject: Revert "NetworkManager: configure to monitor ifcfg/connection 
files"
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59260
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I392a918112c3a7b5bfee6fccb2a51b038d5a543f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Anonymous Coward #1001177
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spec: Require sanlock version handling EINTR

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Require sanlock version handling EINTR
..


Patch Set 6:

* #1356676::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356676::OK, public bug
* Check Product::#1356676::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61200
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1203ad58f0f0ed1789a1e85d7f0b364891ef5864
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: docs: add README about logging configuration

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: docs: add README about logging configuration
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/60533/6/README.logging
File README.logging:

Line 23: 
Line 24: Using vdsClient, you can tune the log level of any logger Vdsm uses.
Line 25: The basic syntax is:
Line 26: 
Line 27: # vdsClient [OPTIONS]  setLogLevel LEVEL [logger]
Do we have other options?

Also, we should be consistent about values case.

How about:

vdsClient [-s] SERVER setLogLevel LEVEL [LOGGER]
Line 28: 
Line 29: `LEVEL` is one of DEBUG, INFO, WARNING
Line 30: `logger` is any logger Vdsm uses. Please check the configuration file
Line 31: to learn about some predefined loggers.


-- 
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spec: Require sanlock version handling EINTR

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: spec: Require sanlock version handling EINTR
..


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/61200/5/vdsm.spec.in
File vdsm.spec.in:

PS5, Line 193: sanlock-
Should remove "sanlock" here.


-- 
To view, visit https://gerrit.ovirt.org/61200
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1203ad58f0f0ed1789a1e85d7f0b364891ef5864
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: introduce acquire module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: introduce acquire module
..


Patch Set 7:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I180cfd7d69c0ae0a24188bc3d909b9d3d7c12145
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt net: Interface default driver name set to 'vhost'

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: virt net: Interface default driver name set to 'vhost'
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/61297
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I508675f9dd40ba70803938902a1c2f8fced00504
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Introduce guarded utilities

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Introduce guarded utilities
..


Patch Set 1:

(7 comments)

https://gerrit.ovirt.org/#/c/61435/1/lib/vdsm/storage/guarded.py
File lib/vdsm/storage/guarded.py:

Line 26: log = logging.getLogger('storage.guarded')
Line 27: rmanager = rm.ResourceManager.getInstance()
Line 28: 
Line 29: 
Line 30: class operation_context(object):
> This name is not clear - why operation?
I'll rename to guard.context.
Line 31: 
Line 32: def __init__(self, entities):
Line 33: self._rm_locks = self._collect_rm_locks(entities)
Line 34: self._held_locks = []


Line 49: locks = []
Line 50: for entity in entities:
Line 51: locks.extend(entity.get_rm_locks())
Line 52: 
Line 53: # Exclusive locks always take precedence over shared
> This is not very clear - do you mean that if we get both shared and exclusi
Exactly.  I'll reword it.  I think there are valid scenarios when you'd have 
both types.  For example, copying within an image, the source would specify a 
shared lock and the destination might want exclusive.
Line 54: lock_set = set([l for l in locks if l.mode == 
rm.LockType.exclusive])
Line 55: shared_locks = set([l for l in locks if l.mode == 
rm.LockType.shared])
Line 56: lock_set.update(shared_locks)
Line 57: return sorted(lock_set)


Line 58: 
Line 59: def _release(self):
Line 60: while self._held_locks:
Line 61: lock = self._held_locks.pop()
Line 62: lock.release()
> We need to catch and log exceptions here, and continue releasing.
ok
Line 63: 
Line 64: 
Line 65: class Entity(object):
Line 66: """


Line 67: Defines the interface that must be implemented by objects that 
wish to be
Line 68: guarded by operation_context.
Line 69: """
Line 70: 
Line 71: def get_rm_locks(self):
> Can we avoid get_ prefix?
Good idea.  I can add a new NS and make it a class attribute for these locks.
Line 72: return []
Line 73: 
Line 74: 
Line 75: class ResourceManagerLock(object):


Line 84: def release(self):
Line 85: rmanager.releaseResource(self.ns, self.name)
Line 86: 
Line 87: def _key(self):
Line 88: return self.ns, self.name
> We don't really need this
see below.
Line 89: 
Line 90: def __cmp__(self, other):
Line 91: return cmp(self._key(), other._key())
Line 92: 


Line 87: def _key(self):
Line 88: return self.ns, self.name
Line 89: 
Line 90: def __cmp__(self, other):
Line 91: return cmp(self._key(), other._key())
> Do you want to put these objects into a set for removing duplicate locks?
I need these functions for two reasons:
* __cmp__ to sort locks
* __hash__ for putting into sets

According to the docs, sets depend on hashable objects, not __lt__ and __eq__.
Line 92: 
Line 93: def __hash__(self):


Line 90: def __cmp__(self, other):
Line 91: return cmp(self._key(), other._key())
Line 92: 
Line 93: def __hash__(self):
Line 94: return hash(self._key())
> Then this hash is wrong, ignoring both the class and the mode.
I want two locks that only differ in mode to go into the same hash bucket in 
order to eliminate duplicates.


-- 
To view, visit https://gerrit.ovirt.org/61435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b0a204818d44b6205515277f4c2834cb2b7a057
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: sampling: add empty() method to StatsSample

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: sampling: add empty() method to StatsSample
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/61420
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bc3712d36c46ade9a779411028817c197ec34b3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: periodic: fix stats age reporting

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: periodic: fix stats age reporting
..


Patch Set 9:

* #1357798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1357798::OK, public bug
* Check Product::#1357798::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61310
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e61626625a2e0517d55dc61e361f3f5eb690c00
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sampling: micro-optimization

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sampling: micro-optimization
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61311
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4361bf4ccae67be3a9e42a0d3368e1e1c246393
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: sampling: add empty() method to StatsSample

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: sampling: add empty() method to StatsSample
..


Patch Set 4:

* #1357798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1357798::OK, public bug
* Check Product::#1357798::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61420
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bc3712d36c46ade9a779411028817c197ec34b3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: supervdsmServer: using moduleloader for dynamic imports

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: supervdsmServer: using moduleloader for dynamic imports
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/61313/1/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 258: 
Line 259: modules = moduleloader.load_modules(supervdsm_api)
Line 260: for module_name in modules:
Line 261: api_funcs = [f for _, f in 
modules[module_name].__dict__.iteritems()
Line 262:  if callable(f) and getattr(f, 'exposed_api', 
False)]
this part is eqvivalent to listPublicFunctions that is used in line 256. can we 
use such listPublicFunctions method in moduleloader for both parts?
Line 263: for func in api_funcs:
Line 264: setattr(_SuperVdsm, func.__name__, 
bind(logDecorator(func)))
Line 265: 
Line 266: try:


-- 
To view, visit https://gerrit.ovirt.org/61313
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba05dc1433fc9c3fea53e17c1c0cae835078233d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: sampling: add empty() method to StatsSample

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: sampling: add empty() method to StatsSample
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/61420/3//COMMIT_MSG
Commit Message:

Line 7: virt: sampling: add empty() method to StatsSample
Line 8: 
Line 9: kill the EMPTY_SAMPLE constant.
Line 10: we always need to fill the 'stats_age' field with meaningful
Line 11: value, None is not good.
> It confuses me, since you replace the constant with instances still having 
Yes, the next patch wants to fill stats_age with a not-None value. This is 
another preparation patch, and this commit message needs to be reformatted.
Line 12: Replace it with a proper method.
Line 13: 
Line 14: Change-Id: I7bc3712d36c46ade9a779411028817c197ec34b3
Line 15: Backport-To: 4.0


-- 
To view, visit https://gerrit.ovirt.org/61420
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bc3712d36c46ade9a779411028817c197ec34b3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: sampling: add empty() method to StatsSample

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: sampling: add empty() method to StatsSample
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/61420/3//COMMIT_MSG
Commit Message:

Line 7: virt: sampling: add empty() method to StatsSample
Line 8: 
Line 9: kill the EMPTY_SAMPLE constant.
Line 10: we always need to fill the 'stats_age' field with meaningful
Line 11: value, None is not good.
It confuses me, since you replace the constant with instances still having None 
as stats_age. Is it to be handled in a followup patch or did you actually mean 
that stats_age is going to be replaced with something meaningful ASAP and so 
comparisons against the constant lose the sense?
Line 12: Replace it with a proper method.
Line 13: 
Line 14: Change-Id: I7bc3712d36c46ade9a779411028817c197ec34b3
Line 15: Backport-To: 4.0


-- 
To view, visit https://gerrit.ovirt.org/61420
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bc3712d36c46ade9a779411028817c197ec34b3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: atomic write

[automation]

gerrit-hooks has posted comments on this change.

Change subject: utils: atomic write
..


Patch Set 4:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb5a2d3ac439a334db2c9075376f219c356762c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: automation: fix check-merged.sh

[automation]

gerrit-hooks has posted comments on this change.

Change subject: automation: fix check-merged.sh
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61415
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4cecee04bd4311444052bcdc701c90d60f8ebe29
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: periodic: fix stats age reporting

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: vm: periodic: fix stats age reporting
..


Patch Set 8:

> Commit message was updated.

It's better now, thanks!

-- 
To view, visit https://gerrit.ovirt.org/61310
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e61626625a2e0517d55dc61e361f3f5eb690c00
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: docs: add README about logging configuration

[fromani]

Francesco Romani has posted comments on this change.

Change subject: docs: add README about logging configuration
..


Patch Set 6: Verified+1

copied score (changing the content doesn't affect "verification" here)

-- 
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: atomic write

[automation]

gerrit-hooks has posted comments on this change.

Change subject: utils: atomic write
..


Patch Set 3:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb5a2d3ac439a334db2c9075376f219c356762c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: atomic write

[automation]

gerrit-hooks has posted comments on this change.

Change subject: utils: atomic write
..


Patch Set 2:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb5a2d3ac439a334db2c9075376f219c356762c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: atomic write

[automation]

gerrit-hooks has posted comments on this change.

Change subject: utils: atomic write
..


Patch Set 1:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb5a2d3ac439a334db2c9075376f219c356762c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: atomic write

[phoracek]

Petr Horáček has uploaded a new change for review.

Change subject: utils: atomic write
..

utils: atomic write

Atomic writes are needed for safe file editation. This function will
be used in following network patch 'acquire external interfaces'.

Change-Id: Icbb5a2d3ac439a334db2c9075376f219c356762c
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
---
M lib/vdsm/utils.py
M tests/utilsTests.py
2 files changed, 73 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/61482/1

diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py
index 0beac90..10888bb 100644
--- a/lib/vdsm/utils.py
+++ b/lib/vdsm/utils.py
@@ -834,8 +834,7 @@
 suffix, e.g. dummy_ilXaYiSn7. The name is bound to IFNAMSIZ of 16-1 chars.
 """
 suffix_len = max_length - len(prefix)
-suffix = ''.join(random.choice(string.ascii_letters + string.digits)
- for _ in range(suffix_len))
+suffix = _random_alnum_string(suffix_len)
 return prefix + suffix
 
 
@@ -929,3 +928,43 @@
 elif len(keys) == 0:
 return dict
 return rget(dict.get(keys[0]), keys[1:], default)
+
+
+@contextmanager
+def atomic_write(path, flag):
+"""Atomically write into a file.
+
+Usage:
+
+with atomic_write('foo.txt', 'w') as f:
+f.write('shrubery')
+# there are no changes on foo.txt yet
+# now it is changed
+
+Temporary copy of the original is created in the same folder == same file
+system.
+"""
+tmp_path = _generate_tmp_path(path)
+if os.path.exists(path):
+shutil.copyfile(path, tmp_path)
+try:
+with open(tmp_path, flag) as f:
+yield f
+except:
+raise
+else:
+shutil.copyfile(tmp_path, path)
+finally:
+os.remove(tmp_path)
+
+
+def _generate_tmp_path(path):
+id = _random_alnum_string(8)
+tmp_path = '{}.{}.tmp'.format(path, id)
+return tmp_path
+
+
+def _random_alnum_string(length):
+return ''.join(
+random.choice(string.ascii_letters + string.digits)
+for _ in range(length))
diff --git a/tests/utilsTests.py b/tests/utilsTests.py
index 975cb0b..1fc4f95 100644
--- a/tests/utilsTests.py
+++ b/tests/utilsTests.py
@@ -47,7 +47,7 @@
 from monkeypatch import MonkeyPatch, MonkeyPatchScope
 from vmTestsData import VM_STATUS_DUMP
 from monkeypatch import Patch
-from testlib import forked, online_cpus
+from testlib import forked, online_cpus, namedTemporaryDir
 from testlib import permutations, expandPermutations
 from testlib import VdsmTestCase as TestCaseBase
 from testValidation import brokentest
@@ -1059,3 +1059,34 @@
 proc.start()
 self._noIntrWatchFd(myPipe, isEpoll=False, mask=select.POLLIN)
 proc.join()
+
+
+class AtomicWriteTest(TestCaseBase):
+
+def test_create_a_new_file(self):
+TEST_TEXT = 'shrubery'
+
+with namedTemporaryDir() as tmp_dir:
+test_file_path = os.path.join(tmp_dir, 'foo.txt')
+with utils.atomic_write(test_file_path, 'w') as f:
+f.write(TEST_TEXT)
+self.assertFalse(os.path.exists(test_file_path))
+self._assert_file_contains(test_file_path, TEST_TEXT)
+
+def test_edit_file(self):
+TEST_TEXT_1 = 'foo'
+TEST_TEXT_2 = 'bar'
+
+with namedTemporaryDir() as tmp_dir:
+test_file_path = os.path.join(tmp_dir, 'foo.txt')
+with open(test_file_path, 'w') as f:
+f.write(TEST_TEXT_1)
+with utils.atomic_write(test_file_path, 'w') as f:
+f.write(TEST_TEXT_2)
+self._assert_file_contains(test_file_path, TEST_TEXT_1)
+self._assert_file_contains(test_file_path, TEST_TEXT_2)
+
+def _assert_file_contains(self, path, expected_content):
+with open(path) as f:
+content = f.read()
+self.assertEqual(content, expected_content)


-- 
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icbb5a2d3ac439a334db2c9075376f219c356762c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Revert "configurator: libvirt: do not jump on virtlogd"

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Revert "configurator: libvirt: do not jump on virtlogd"
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61481
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d5ec539ce4d9ffbb92a357cf59104f073b372ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Revert "configurator: libvirt: do not jump on virtlogd"

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: Revert "configurator: libvirt: do not jump on virtlogd"
..

Revert "configurator: libvirt: do not jump on virtlogd"

This reverts commit 0d9be09351814571655fab23bbfa21733916e36d.
The feature looks good for us now.

Change-Id: I9d5ec539ce4d9ffbb92a357cf59104f073b372ef
Signed-off-by: Francesco Romani 
---
M lib/vdsm/tool/configurators/libvirt.py
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/61481/1

diff --git a/lib/vdsm/tool/configurators/libvirt.py 
b/lib/vdsm/tool/configurators/libvirt.py
index 8315bb3..40d4958 100644
--- a/lib/vdsm/tool/configurators/libvirt.py
+++ b/lib/vdsm/tool/configurators/libvirt.py
@@ -285,7 +285,6 @@
 'remote_display_port_min': 5900,
 'remote_display_port_max': 6923,
 'auto_dump_path': '"/var/log/core"',
-'stdio_handler': '"file"',
 },
 
 },


-- 
To view, visit https://gerrit.ovirt.org/61481
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d5ec539ce4d9ffbb92a357cf59104f073b372ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: docs: add README about logging configuration

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: docs: add README about logging configuration
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: docs: add README about logging configuration

[automation]

gerrit-hooks has posted comments on this change.

Change subject: docs: add README about logging configuration
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sampling: micro-optimization

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sampling: micro-optimization
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61311
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4361bf4ccae67be3a9e42a0d3368e1e1c246393
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: periodic: fix stats age reporting

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: periodic: fix stats age reporting
..


Patch Set 8:

* #1357798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1357798::OK, public bug
* Check Product::#1357798::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61310
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e61626625a2e0517d55dc61e361f3f5eb690c00
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: docs: add README about logging configuration

[fromani]

Francesco Romani has posted comments on this change.

Change subject: docs: add README about logging configuration
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/60533/5/README.logging
File README.logging:

Line 23: 
Line 24: Using vdsClient, you can tune the log level of any logger Vdsm uses.
Line 25: The basic syntax is:
Line 26: 
Line 27: # vdsClient [options] setLogLevel LEVEL [logger]
> It should be
Better to be explicit, yes. Fixing.
Line 28: 
Line 29: `LEVEL` is one of DEBUG, INFO, WARNING
Line 30: `logger` is any logger Vdsm uses. Please check the configuration file
Line 31: to learn about some predefined loggers.


-- 
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: periodic: fix stats age reporting

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: periodic: fix stats age reporting
..


Patch Set 7:

(4 comments)

https://gerrit.ovirt.org/#/c/61310/7//COMMIT_MSG
Commit Message:

PS7, Line 24: it
> its ?
yes, fixed.


PS7, Line 28: we do
: so using earlier in the flow the vm last timestamp, which is 
needed
: and guaranteed to be present
> I can't parse this sentence.
Because it's ugly! Rewritten.


PS7, Line 37: to to
> duplicated `to'
Thanks, removed


Line 37: to to get created, it will be reported as unresponsive until the domain
Line 38: is ready. This is actually a more correct representation of reality.
Line 39: 2. if the powerdown flow takes too long (same as #1), again the
Line 40: VM will be reported as unresponsive until the domain is completely
Line 41: cleaned up. This is also a more thrutful reporting.
> Maybe it would be worth to mention the consequences of reporting a VM as no
More the latter, and worth mentioning indeed.
Line 42: 
Line 43: Change-Id: I3e61626625a2e0517d55dc61e361f3f5eb690c00
Line 44: Backport-To: 4.0
Line 45: Backport-To: 3.6


-- 
To view, visit https://gerrit.ovirt.org/61310
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e61626625a2e0517d55dc61e361f3f5eb690c00
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: docs: add README about logging configuration

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: docs: add README about logging configuration
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/60533/5/README.logging
File README.logging:

Line 23: 
Line 24: Using vdsClient, you can tune the log level of any logger Vdsm uses.
Line 25: The basic syntax is:
Line 26: 
Line 27: # vdsClient [options] setLogLevel LEVEL [logger]
It should be

  vdsClient [options] SERVER setLogLevel LEVEL [logger]
Line 28: 
Line 29: `LEVEL` is one of DEBUG, INFO, WARNING
Line 30: `logger` is any logger Vdsm uses. Please check the configuration file
Line 31: to learn about some predefined loggers.


-- 
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: migration: switch to concurrent.thread()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: migration: switch to concurrent.thread()
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61463
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23b98be05103529c827e6e21c0ed82cca58cb346
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: vm: switch to concurrent.thread()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: vm: switch to concurrent.thread()
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61464
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I149315a1934a565012870c87a67f5a0185b9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org