Change in vdsm[master]: virt: Report paused VM status in post-copy
Milan Zamazal has posted comments on this change. Change subject: virt: Report paused VM status in post-copy .. Patch Set 10: Just rebase + updates. -- To view, visit https://gerrit.ovirt.org/64147 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4738a7519f8d1af2ee30bfe766f3407853263cf2 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Prevent monitoring of VMs in post-copy
Milan Zamazal has posted comments on this change. Change subject: virt: Prevent monitoring of VMs in post-copy .. Patch Set 10: Just rebase + updates. -- To view, visit https://gerrit.ovirt.org/64146 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I010d3311ce497081720a871e2a3c715f53dcb299 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Stop guest agent before switching to post-copy
Milan Zamazal has posted comments on this change. Change subject: virt: Stop guest agent before switching to post-copy .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/64145/8/vdsm/virt/migration.py File vdsm/virt/migration.py: PS8, Line 820: except > at very least let's make this > except Exception: Done. > Besides that, any chance to narrow this down? I don't think so, Python doesn't declare exceptions. -- To view, visit https://gerrit.ovirt.org/64145 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd855ee36847b293009ac35d8d03b01521aaace8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Distinguish between switching to and entering post-cop...
Milan Zamazal has posted comments on this change. Change subject: virt: Distinguish between switching to and entering post-copy migration .. Patch Set 8: The PostCopyPhase idea implemented (and 3 states are enough actually). If you don't like PostCopyPhase as a nested class then please suggest a better place (we don't want to import vm.py). -- To view, visit https://gerrit.ovirt.org/64143 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88dddeab84a609ebd3d5d9139724adff9cdb1352 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Refuse to cancel post-copy migrations
Milan Zamazal has posted comments on this change. Change subject: virt: Refuse to cancel post-copy migrations .. Patch Set 10: The post-copy flag is set at the proper place now. No changes wrt. locking itself. -- To view, visit https://gerrit.ovirt.org/63554 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I670ab48ed3fe69582646675d8b683bcdb3cfa038 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Refuse to cancel post-copy migrations
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Refuse to cancel post-copy migrations
..
virt: Refuse to cancel post-copy migrations
A VM in post-copy migration is split between the source and the
destination, with inconsistent memory state on both the ends of the
migration. Stopping the migration in that phase is not a good idea, it
loses the VM and leaves it in the pause state on the source and may lead
to data loss.
Since it's not possible to stop a post-copy migration safely and the
migration is guaranteed to finish sooner or later, we prevent its
cancellation with this patch.
Change-Id: I670ab48ed3fe69582646675d8b683bcdb3cfa038
Signed-off-by: Milan Zamazal
---
M vdsm/virt/vm.py
1 file changed, 25 insertions(+), 17 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/63554/10
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index b5a92cb..11cacc9 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -274,6 +274,7 @@
self._guestEventTime = 0
self._guestCpuRunning = False
self._guestCpuLock = threading.Lock()
+self._post_copy_lock = threading.Lock()
self._startTime = time.time() - \
float(self.conf.pop('elapsedTimeOffset', 0))
@@ -1447,20 +1448,26 @@
return self._migrationSourceThread.getStat()
def migrateCancel(self):
-self._acquireCpuLockWithTimeout()
-try:
-self._migrationSourceThread.stop()
-self._migrationSourceThread.status['status']['message'] = \
-'Migration process cancelled'
-return self._migrationSourceThread.status
-except libvirt.libvirtError as e:
-if e.get_error_code() == libvirt.VIR_ERR_OPERATION_INVALID:
+with self._post_copy_lock:
+if self.post_copy:
+return response.error(
+'migCancelErr',
+message=("Can't cancel migration in post-copy mode")
+)
+self._acquireCpuLockWithTimeout()
+try:
+self._migrationSourceThread.stop()
+self._migrationSourceThread.status['status']['message'] = \
+'Migration process cancelled'
+return self._migrationSourceThread.status
+except libvirt.libvirtError as e:
+if e.get_error_code() == libvirt.VIR_ERR_OPERATION_INVALID:
+return response.error('migCancelErr')
+raise
+except virdomain.NotConnectedError:
return response.error('migCancelErr')
-raise
-except virdomain.NotConnectedError:
-return response.error('migCancelErr')
-finally:
-self._guestCpuLock.release()
+finally:
+self._guestCpuLock.release()
def _getSerialConsole(self):
"""
@@ -1512,10 +1519,11 @@
corresponding libvirt event.
"""
self.log.info('Switching to post-copy migration')
-result = self._dom.migrateStartPostCopy(0)
-success = result >= 0
-if success:
-self._post_copy = True
+with self._post_copy_lock:
+result = self._dom.migrateStartPostCopy(0)
+success = result >= 0
+if success:
+self._post_copy = True
return success
def _customDevices(self):
--
To view, visit https://gerrit.ovirt.org/63554
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I670ab48ed3fe69582646675d8b683bcdb3cfa038
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Milan Zamazal
Gerrit-Reviewer: gerrit-hooks
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Use a variable for self._vm in MonitorThread action ha...
Milan Zamazal has posted comments on this change. Change subject: virt: Use a variable for self._vm in MonitorThread action handling .. Patch Set 9: Rebase + resolved conflicts. -- To view, visit https://gerrit.ovirt.org/63553 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e41f8b3ef27319c51e18ad2c75bbb3c61b61c76 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Use a variable for self._vm in MonitorThread action ha...
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Use a variable for self._vm in MonitorThread action
handling
..
virt: Use a variable for self._vm in MonitorThread action handling
This is a reformatting patch to prevent further line breaking in a
followup patch.
Change-Id: I3e41f8b3ef27319c51e18ad2c75bbb3c61b61c76
Signed-off-by: Milan Zamazal
---
M vdsm/virt/migration.py
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/63553/9
diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py
index 4633d47..6cd88f4 100644
--- a/vdsm/virt/migration.py
+++ b/vdsm/virt/migration.py
@@ -783,19 +783,19 @@
def _execute_action_with_params(self, action_with_params):
action = str(action_with_params['name'])
+vm = self._vm
if action == CONVERGENCE_SCHEDULE_SET_DOWNTIME:
downtime = int(action_with_params['params'][0])
-self._vm.log.debug('Setting downtime to %d',
- downtime)
-self._vm._dom.migrateSetMaxDowntime(downtime, 0)
+vm.log.debug('Setting downtime to %d', downtime)
+vm._dom.migrateSetMaxDowntime(downtime, 0)
elif action == CONVERGENCE_SCHEDULE_POST_COPY:
if not self._vm.switch_migration_to_post_copy():
# Do nothing for now; the next action will be invoked after a
# while
-self._vm.log.warn('Failed to switch to post-copy migration')
+vm.log.warn('Failed to switch to post-copy migration')
elif action == CONVERGENCE_SCHEDULE_SET_ABORT:
-self._vm.log.warn('Aborting migration')
-self._vm._dom.abortJob()
+vm.log.warn('Aborting migration')
+vm._dom.abortJob()
self.stop()
--
To view, visit https://gerrit.ovirt.org/63553
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e41f8b3ef27319c51e18ad2c75bbb3c61b61c76
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: gerrit-hooks
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Fetch only minimum VM stats during post-copy migration
Milan Zamazal has posted comments on this change. Change subject: virt: Fetch only minimum VM stats during post-copy migration .. Patch Set 9: Simplified thanks to the refactorization in the initial patch. -- To view, visit https://gerrit.ovirt.org/63552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac3da08b0816e7a9a247969147c17b15518c7624 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Destroy VM after post-copy migration failure
Milan Zamazal has posted comments on this change. Change subject: virt: Destroy VM after post-copy migration failure .. Patch Set 8: Just rebase + resolved conflicts. -- To view, visit https://gerrit.ovirt.org/64142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1918e9afce189c8b3f617766e55afa13f1e153f1 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Initial support for post-copy migration
Milan Zamazal has posted comments on this change. Change subject: virt: Initial support for post-copy migration .. Patch Set 12: I moved the migration switching and the post-copy flag to Vm as was suggested in and as a preparation for the followup patches. (Please note that I rebased the whole topic on master, so don't get confused if you check diffs against last versions.) -- To view, visit https://gerrit.ovirt.org/62873 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Distinguish between switching to and entering post-cop...
gerrit-hooks has posted comments on this change. Change subject: virt: Distinguish between switching to and entering post-copy migration .. Patch Set 8: * Update Tracker::#1354343::OK, status: POST * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::#1354343::OK, public bug * Check Product::IGNORE, not relevant for branch: master * Check TM::IGNORE, not relevant for branch: master * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64143 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88dddeab84a609ebd3d5d9139724adff9cdb1352 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Destroy VM after post-copy migration failure
gerrit-hooks has posted comments on this change. Change subject: virt: Destroy VM after post-copy migration failure .. Patch Set 8: * Update Tracker::#1354343::OK, status: POST * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::#1354343::OK, public bug * Check Product::IGNORE, not relevant for branch: master * Check TM::IGNORE, not relevant for branch: master * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1918e9afce189c8b3f617766e55afa13f1e153f1 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Fetch only minimum VM stats during post-copy migration
gerrit-hooks has posted comments on this change. Change subject: virt: Fetch only minimum VM stats during post-copy migration .. Patch Set 9: * Update Tracker::#1354343::OK, status: POST * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::#1354343::OK, public bug * Check Product::IGNORE, not relevant for branch: master * Check TM::IGNORE, not relevant for branch: master * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac3da08b0816e7a9a247969147c17b15518c7624 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Inform Engine about switching to post-copy
gerrit-hooks has posted comments on this change. Change subject: virt: Inform Engine about switching to post-copy .. Patch Set 11: * Update Tracker::#1354343::OK, status: POST * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::#1354343::OK, public bug * Check Product::IGNORE, not relevant for branch: master * Check TM::IGNORE, not relevant for branch: master * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I281ec36a6bd65b816afbdeef79205e6241d4a27c Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Report paused VM status in post-copy
gerrit-hooks has posted comments on this change. Change subject: virt: Report paused VM status in post-copy .. Patch Set 10: * Update Tracker::#1354343::OK, status: POST * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::#1354343::OK, public bug * Check Product::IGNORE, not relevant for branch: master * Check TM::IGNORE, not relevant for branch: master * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64147 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4738a7519f8d1af2ee30bfe766f3407853263cf2 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Stop guest agent before switching to post-copy
gerrit-hooks has posted comments on this change. Change subject: virt: Stop guest agent before switching to post-copy .. Patch Set 9: * Update Tracker::#1354343::OK, status: POST * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::#1354343::OK, public bug * Check Product::IGNORE, not relevant for branch: master * Check TM::IGNORE, not relevant for branch: master * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64145 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd855ee36847b293009ac35d8d03b01521aaace8 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Initial support for post-copy migration
gerrit-hooks has posted comments on this change. Change subject: virt: Initial support for post-copy migration .. Patch Set 12: * Update Tracker::#1354343::OK, status: POST * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::#1354343::OK, public bug * Check Product::IGNORE, not relevant for branch: master * Check TM::IGNORE, not relevant for branch: master * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62873 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Start all VM related stuff after switching to post-cop...
gerrit-hooks has posted comments on this change. Change subject: virt: Start all VM related stuff after switching to post-copy migration .. Patch Set 9: * Update Tracker::#1354343::OK, status: POST * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::#1354343::OK, public bug * Check Product::IGNORE, not relevant for branch: master * Check TM::IGNORE, not relevant for branch: master * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b17e58f63cbd9db09e4420871a562eaa0b3f3d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Prevent monitoring of VMs in post-copy
gerrit-hooks has posted comments on this change. Change subject: virt: Prevent monitoring of VMs in post-copy .. Patch Set 10: * Update Tracker::#1354343::OK, status: POST * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::#1354343::OK, public bug * Check Product::IGNORE, not relevant for branch: master * Check TM::IGNORE, not relevant for branch: master * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64146 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I010d3311ce497081720a871e2a3c715f53dcb299 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: edit nic detached from bridge but still attached to a vlan
Petr Horáček has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 4: I cannot check the ifcfg for BRIDGE, it works OK when I use dummies, have no idea why is there a difference with physical NIC. The difference is there even outside tests, reproduced via vdscli. -- To view, visit https://gerrit.ovirt.org/65231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: Unify SimpleLogAdapter format
gerrit-hooks has posted comments on this change. Change subject: logging: Unify SimpleLogAdapter format .. Patch Set 3: * Update Tracker::IGNORE, no bug url/s found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/64227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4edb64d214e515c9cfc45175f6cfee4340d28de Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: Unify SimpleLogAdapter format
Dan Kenigsberg has submitted this change and it was merged. Change subject: logging: Unify SimpleLogAdapter format .. logging: Unify SimpleLogAdapter format SimpleLogAdapter was prefixing the log message with context info, using "::" as message separator. This made sense when the log was using "::" as field separator, but now we are using spaces. Additionally the old format use strange quoting and no spacing between pairs, making the format harder to read: task=`xxxyyy`res=`foo.bar.baz`::Message text ... The new format fixes these issues and enclose the context info in parenthesis to match the new log format: (task='xxxyyy', res='foo.bar.baz') Message text ... This matches the format we used lately in many logs for adding message details. Here is an example line using the format: 2016-09-23 02:21:57,965 INFO (Thread-11) [virt.vm] (vmId='45b59cae-f2a0-4d83-8da8-b7c0a21fbe14') VM wrapper has started (vm:1751) Change-Id: Ib4edb64d214e515c9cfc45175f6cfee4340d28de Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/64227 Continuous-Integration: Jenkins CI Reviewed-by: Milan Zamazal Reviewed-by: Edward Haas Reviewed-by: Piotr Kliczewski Reviewed-by: Dan Kenigsberg --- M lib/vdsm/logUtils.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Nir Soffer: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Edward Haas: Looks good to me, but someone else must approve Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4edb64d214e515c9cfc45175f6cfee4340d28de Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: Improve log level alignment
gerrit-hooks has posted comments on this change. Change subject: logging: Improve log level alignment .. Patch Set 4: * Update Tracker::IGNORE, no bug url/s found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/64217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia18649258f145f974fd4a8f7a96b5849c4a77938 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: Unify SimpleLogAdapter format
Dan Kenigsberg has posted comments on this change. Change subject: logging: Unify SimpleLogAdapter format .. Patch Set 2: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/64227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4edb64d214e515c9cfc45175f6cfee4340d28de Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: Improve log level alignment
Dan Kenigsberg has posted comments on this change. Change subject: logging: Improve log level alignment .. Patch Set 3: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/64217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia18649258f145f974fd4a8f7a96b5849c4a77938 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: Improve log level alignment
Dan Kenigsberg has submitted this change and it was merged.
Change subject: logging: Improve log level alignment
..
logging: Improve log level alignment
Shorten WARNING to WARN and CRITICAL to CRIT to make log messages align
nicer.
Here is an example log:
2016-09-23 02:18:32,060 INFO (MainThread) [vds] (PID: 26597) I am the actual
vdsm 4.18.999-606.gitd60b2e8.el7 voodoo6.tlv.redhat.com (3.10.0-489.el7.x86_64)
(vdsm:150)
2016-09-23 02:18:32,060 INFO (MainThread) [vds] VDSM will run with cpu
affinity: frozenset([1]) (vdsm:256)
2016-09-23 02:18:32,126 INFO (MainThread) [storage.check] Starting check
service (check:91)
2016-09-23 02:18:32,130 INFO (MainThread) [storage.Dispatcher] Starting
StorageDispatcher... (dispatcher:47)
2016-09-23 02:18:32,130 INFO (check/loop) [storage.asyncevent] Starting
(asyncevent:122)
2016-09-23 02:18:32,218 INFO (MainThread) [dispatcher] Run and protect:
registerDomainStateChangeCallback(callbackFunc=) (logUtils:49)
2016-09-23 02:18:32,218 INFO (MainThread) [dispatcher] Run and protect:
registerDomainStateChangeCallback, Return response: None (logUtils:52)
2016-09-23 02:18:32,218 INFO (MainThread) [MOM] Preparing MOM interface
(momIF:49)
2016-09-23 02:18:32,219 INFO (MainThread) [MOM] Using named unix socket
/var/run/vdsm/mom-vdsm.sock (momIF:58)
2016-09-23 02:18:32,219 INFO (MainThread) [root] Unregistering all secrets
(secret:91)
2016-09-23 02:18:32,224 INFO (MainThread) [vds] Setting channels' timeout to
30 seconds. (vmchannels:223)
2016-09-23 02:18:32,226 INFO (MainThread) [vds.MultiProtocolAcceptor]
Listening at :::54321 (protocoldetector:178)
2016-09-23 02:18:32,424 INFO (clientIFinit) [vds] recovery [1:1/1]: recovered
domain 45b59cae-f2a0-4d83-8da8-b7c0a21fbe14 from libvirt (recovery:178)
2016-09-23 02:18:32,424 INFO (clientIFinit) [vds] recovery: waiting for 1
domains to go up (clientIF:545)
2016-09-23 02:18:32,424 INFO (Thread-11) [virt.vm]
vmId=`45b59cae-f2a0-4d83-8da8-b7c0a21fbe14`::VM wrapper has started (vm:1751)
2016-09-23 02:18:32,425 INFO (Thread-11) [dispatcher] Run and protect:
getVolumeSize(sdUUID=u'5f35b5c0-17d7-4475-9125-e97f1cdb06f9',
spUUID=u'f9374c0e-ae24-4bc1-a596-f61d5f05bc5f',
imgUUID=u'3bdc1ff7-22f9-4263-8955-7e3bfa540edc',
volUUID=u'7e159928-0e2f-423a-a02d-3faddbf55585', options=None) (logUtils:49)
2016-09-23 02:18:33,022 ERROR (Thread-11) [storage.StorageDomainCache] looking
for unfetched domain 5f35b5c0-17d7-4475-9125-e97f1cdb06f9 (sdc:151)
2016-09-23 02:18:33,022 ERROR (Thread-11) [storage.StorageDomainCache] looking
for domain 5f35b5c0-17d7-4475-9125-e97f1cdb06f9 (sdc:168)
2016-09-23 02:18:33,153 INFO (Thread-11) [storage.LVM] Refreshing lvs:
vg=5f35b5c0-17d7-4475-9125-e97f1cdb06f9 lvs=['metadata'] (lvm:1226)
2016-09-23 02:18:33,425 INFO (clientIFinit) [vds] recovery: waiting for 1
domains to go up (clientIF:545)
2016-09-23 02:18:33,445 INFO (Thread-11) [storage.LVM] Refreshing lvs:
vg=5f35b5c0-17d7-4475-9125-e97f1cdb06f9 lvs=['ids'] (lvm:1226)
2016-09-23 02:18:33,470 INFO (hsm/init) [storage.LVM] Refreshing lvs:
vg=5f35b5c0-17d7-4475-9125-e97f1cdb06f9 lvs=['ids', 'master', 'inbox',
'metadata', 'outbox', 'leases'] (lvm:677)
2016-09-23 02:18:33,547 INFO (Thread-11) [storage.LVM] Refreshing lvs:
vg=5f35b5c0-17d7-4475-9125-e97f1cdb06f9 lvs=['leases'] (lvm:1226)
2016-09-23 02:18:33,670 INFO (Thread-11) [storage.LVM] Refreshing lvs:
vg=5f35b5c0-17d7-4475-9125-e97f1cdb06f9 lvs=['metadata', 'leases', 'ids',
'inbox', 'outbox', 'master'] (lvm:1226)
2016-09-23 02:18:33,829 INFO (Thread-11) [dispatcher] Run and protect:
getVolumeSize, Return response: {'truesize': '1073741824', 'apparentsize':
'1073741824'} (logUtils:52)
2016-09-23 02:18:33,829 INFO (Thread-11) [dispatcher] Run and protect:
getVolumeSize(sdUUID=u'5f35b5c0-17d7-4475-9125-e97f1cdb06f9',
spUUID=u'f9374c0e-ae24-4bc1-a596-f61d5f05bc5f',
imgUUID=u'65e74f9f-a41b-4636-8e72-db3dd7d73055',
volUUID=u'3a9f341b-4149-4794-88d6-4fd12ff84307', options=None) (logUtils:49)
2016-09-23 02:18:33,830 INFO (Thread-11) [dispatcher] Run and protect:
getVolumeSize, Return response: {'truesize': '7650410496', 'apparentsize':
'7650410496'} (logUtils:52)
2016-09-23 02:18:33,830 INFO (Thread-11) [dispatcher] Run and protect:
getVolumeSize(sdUUID=u'5f35b5c0-17d7-4475-9125-e97f1cdb06f9',
spUUID=u'f9374c0e-ae24-4bc1-a596-f61d5f05bc5f',
imgUUID=u'69107a7c-acd6-44b0-a481-e7ec13486847',
volUUID=u'88816475-3ea1-4d1f-ac93-7767cf9a2d2c', options=None) (logUtils:49)
2016-09-23 02:18:33,830 INFO (Thread-11) [dispatcher] Run and protect:
getVolumeSize, Return response: {'truesize': '1073741824', 'apparentsize':
'1073741824'} (logUtils:52)
2016-09-23 02:18:33,848 INFO (Thread-11) [virt.vm]
vmId=`45b59cae-f2a0-4d83-8da8-b7c0a21fbe14`::Starting connection
(guestagent:234)
2016-09-23 02:18:33,849 INFO (Thread-11) [virt.vm]
vmId=`45b59cae-f2a0-4d83-8da8-b7c0a21fbe14`::CPU running: domain in
Change in vdsm[master]: net: Validate nameservers setup
gerrit-hooks has posted comments on this change. Change subject: net: Validate nameservers setup .. Patch Set 2: * Update Tracker::IGNORE, no bug url/s found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/65613 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68b8a834eabd9775178e395f643d555a18eecc81 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Validate nameservers setup
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: Validate nameservers setup .. net: Validate nameservers setup Add address validation for the nameservers setup. Change-Id: I68b8a834eabd9775178e395f643d555a18eecc81 Signed-off-by: Edward Haas Reviewed-on: https://gerrit.ovirt.org/65613 Continuous-Integration: Jenkins CI Reviewed-by: Petr Horáček Reviewed-by: Dan Kenigsberg --- M lib/vdsm/network/ip/validator.py 1 file changed, 24 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/65613 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68b8a834eabd9775178e395f643d555a18eecc81 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Change classmethod to staticmethod in IPv4 and IPv6 cla...
Dan Kenigsberg has posted comments on this change. Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I061a33c6404198c7691d853d683e8535c38442e6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Change classmethod to staticmethod in IPv4 and IPv6 cla...
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes .. net: Change classmethod to staticmethod in IPv4 and IPv6 classes Several validation methods have been defined as classmethods where staticmethods seems to fit better. Using a classmethod usually implies the need to instantiate or use the class inside the method. This is not the case here, making the reader raising uneeded questions. Change-Id: I061a33c6404198c7691d853d683e8535c38442e6 Signed-off-by: Edward Haas Reviewed-on: https://gerrit.ovirt.org/65609 Continuous-Integration: Jenkins CI Reviewed-by: Petr Horáček Reviewed-by: Dan Kenigsberg --- M lib/vdsm/network/ip/address.py 1 file changed, 21 insertions(+), 21 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/65609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I061a33c6404198c7691d853d683e8535c38442e6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Change classmethod to staticmethod in IPv4 and IPv6 cla...
gerrit-hooks has posted comments on this change. Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes .. Patch Set 3: * Update Tracker::IGNORE, no bug url/s found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/65609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I061a33c6404198c7691d853d683e8535c38442e6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Validate nameservers setup
Dan Kenigsberg has posted comments on this change. Change subject: net: Validate nameservers setup .. Patch Set 1: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/65613 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68b8a834eabd9775178e395f643d555a18eecc81 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Change classmethod to staticmethod in IPv4 and IPv6 cla...
Petr Horáček has posted comments on this change. Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I061a33c6404198c7691d853d683e8535c38442e6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Distinguish between switching to and entering post-cop...
Milan Zamazal has posted comments on this change. Change subject: virt: Distinguish between switching to and entering post-copy migration .. Patch Set 7: (2 comments) Thank you for the suggestion, I'll do it this way. https://gerrit.ovirt.org/#/c/64143/7//COMMIT_MSG Commit Message: Line 15: request phase and the post-copy switch phase. For instance, we should Line 16: block canceling migrations very early to avoid timing issues and Line 17: possibly canceling a post-copy migration. On the other hand we should Line 18: report a true VM state to Engine, so we can report post-copy only after Line 19: the VM actually enters it. > do we need two separate variables or can we turn the boolean in one state a Good idea. I came to a similar conclusion when thinking about some subtleties of the preceding (cancel migration) patch. I'll probably introduce 4 states: none, initiated (just before calling libvirt to switch), requested (after a *successful* libvirt call), running (after confirming libvirt event). Line 20: Line 21: Change-Id: I88dddeab84a609ebd3d5d9139724adff9cdb1352 Line 22: Signed-off-by: Milan Zamazal https://gerrit.ovirt.org/#/c/64143/7/vdsm/virt/migration.py File vdsm/virt/migration.py: PS7, Line 811: if ret >= 0: : self._post_copy_initiated = True > not related to this patch, but I realized just now. Yes, you're right, thanks for pointing this out. -- To view, visit https://gerrit.ovirt.org/64143 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88dddeab84a609ebd3d5d9139724adff9cdb1352 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: py3: make toolBondingTests pass
Dan Kenigsberg has uploaded a new change for review. Change subject: py3: make toolBondingTests pass .. py3: make toolBondingTests pass I don't really know why, but under Python 3, file.close() seems to issue another attempt to flush "invalid" data. The added code explicitly ignores the ensuing exception. Change-Id: I4487b787c3a14ca9508847572622f431f1188e7f Signed-off-by: Dan Kenigsberg --- M lib/vdsm/network/netinfo/bonding.py M tests/Makefile.am 2 files changed, 9 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/65666/1 diff --git a/lib/vdsm/network/netinfo/bonding.py b/lib/vdsm/network/netinfo/bonding.py index 0ca2259..2f40b88 100644 --- a/lib/vdsm/network/netinfo/bonding.py +++ b/lib/vdsm/network/netinfo/bonding.py @@ -218,7 +218,7 @@ e.g. 'ad_num_ports' or 'slaves'. """ return dict(((opt, val) for (opt, val) - in _bond_opts_name2numeric(bond).iteritems() + in six.iteritems(_bond_opts_name2numeric(bond)) if opt not in EXCLUDED_BONDING_ENTRIES)) @@ -268,6 +268,14 @@ vals[name] = numeric +# On Python 3, the final close seems to issue another flush attempt, +# which results in a repeated exception. Ignore it. +try: +opt_file.close() +except EnvironmentError as e: +if e.errno not in (errno.EINVAL, errno.EPERM, errno.EACCES): +raise + return vals diff --git a/tests/Makefile.am b/tests/Makefile.am index e96f226..6eb815b 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -227,7 +227,6 @@ storage_workarounds_test.py \ storagefakelibTests.py \ storagetestlib_test.py \ - toolBondingTests.py \ unicode_test.py \ utilsTests.py \ v2vTests.py \ -- To view, visit https://gerrit.ovirt.org/65666 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4487b787c3a14ca9508847572622f431f1188e7f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: py3: make toolBondingTests pass
gerrit-hooks has posted comments on this change. Change subject: py3: make toolBondingTests pass .. Patch Set 1: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65666 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4487b787c3a14ca9508847572622f431f1188e7f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: py3: make ovs_test pass
Dan Kenigsberg has posted comments on this change. Change subject: py3: make ovs_test pass .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65599 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id812fb7c37573ed68dd4be9f982b8ae892532c9c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: py3: make ovs_test pass
Dan Kenigsberg has submitted this change and it was merged. Change subject: py3: make ovs_test pass .. py3: make ovs_test pass Change-Id: Id812fb7c37573ed68dd4be9f982b8ae892532c9c Signed-off-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/65599 Continuous-Integration: Jenkins CI Reviewed-by: Petr Horáček --- M tests/Makefile.am M tests/network/ovs_test.py 2 files changed, 4 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65599 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id812fb7c37573ed68dd4be9f982b8ae892532c9c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: py3: make ovs_test pass
gerrit-hooks has posted comments on this change. Change subject: py3: make ovs_test pass .. Patch Set 2: * Update Tracker::IGNORE, no bug url/s found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/65599 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id812fb7c37573ed68dd4be9f982b8ae892532c9c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: enable glusterfs access through libgfapi interface
Sahina Bose has posted comments on this change. Change subject: virt: enable glusterfs access through libgfapi interface .. Patch Set 14: Verified+1 @Nir, can this patch be merged. Have verified the vm creation/migration/snapshot flows. Anything else required? -- To view, visit https://gerrit.ovirt.org/44061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54b81e87b959b0b49c0f06810f88410e7c75de1d Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Prasanna Kumar Kalever Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: virt: Start all VM related stuff after switching to post-cop...
Milan Zamazal has posted comments on this change.
Change subject: virt: Start all VM related stuff after switching to post-copy
migration
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/63551/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 263: self._lastStatus = vmstatus.WAIT_FOR_LAUNCH
Line 264: self._migrationSourceThread = migration.SourceThread(self)
Line 265: self._kvmEnable = self.conf.get('kvmEnable', 'true')
Line 266: self._incomingMigrationFinished = threading.Event()
Line 267: self._incoming_migration_vm_running = threading.Event()
> Why can't we just do incomingMigrationFinished.set() earlier?
Well, what (except for the status and the corresponding event) will change if
we simply finish the creation thread on switching to post-copy? I'd be worried
about unsetting self.recovery, but it seems to be safe. Then perhaps raising
exceptions in the rest of the creation thread, but there should be no exception
in that path, right? And finally there is the incoming_migrations semaphore, it
can be handled together with status. So it might work.
But the primary question is: What do we gain by exiting the creation thread
early or what do we lose by not exiting it early? Is it just to avoid
introducing another synchronization variable (for the price of slightly more
complicated handling of the status and the semaphore) or anything else?
Line 268: self.id = self.conf['vmId']
Line 269: self._volPrepareLock = threading.Lock()
Line 270: self._initTimePauseCode = None
Line 271: self._initTimeRTC = int(self.conf.get('timeOffset', 0))
--
To view, visit https://gerrit.ovirt.org/63551
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8b17e58f63cbd9db09e4420871a562eaa0b3f3d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
