Dan Kenigsberg has submitted this change and it was merged. Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes ......................................................................
net: Change classmethod to staticmethod in IPv4 and IPv6 classes Several validation methods have been defined as classmethods where staticmethods seems to fit better. Using a classmethod usually implies the need to instantiate or use the class inside the method. This is not the case here, making the reader raising uneeded questions. Change-Id: I061a33c6404198c7691d853d683e8535c38442e6 Signed-off-by: Edward Haas <edwa...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/65609 Continuous-Integration: Jenkins CI Reviewed-by: Petr Horáček <phora...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M lib/vdsm/network/ip/address.py 1 file changed, 21 insertions(+), 21 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/65609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I061a33c6404198c7691d853d683e8535c38442e6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
