Change in vdsm[master]: Adding dns vdsm hook
'addr addr1 ... addrN'
diff --git a/vdsm_hooks/dns/dns.py b/vdsm_hooks/dns/dns.py
new file mode 100644
index 000..2038ea6
--- /dev/null
+++ b/vdsm_hooks/dns/dns.py
@@ -0,0 +1,97 @@
+#!/usr/bin/env python
+# Copyright 2014 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+import sys
+import hooking
+import traceback
+
+from vdsm import netinfo
+from vdsm import utils
+
+_NMCLI_BINARY = '/usr/bin/nmcli'
+_RESOLV_CONF = '/etc/resolv.conf'
+
+
+def test():
+dns_list = '1.1.1.1 2.2.2.2 3.3.3.3'
+commands = ['nmcli connection modify foo_con +ipv4.dns "%s"' % dns_list,
+'nmcli connection modify foo_con ipv4.dns "%s"' % dns_list,
+]
+print(commands)
+assert [_generate_nmcli_command(dns_list, 'foo_con', keep_dns_config)
+for keep_dns_config in [True, False]] == commands
+
+
+def main():
+"""Read dns from the network 'custom' properties and apply them
+to the network's top device"""
+setup_nets_config = hooking.read_json()
+for network, attrs in setup_nets_config['request']['networks'].items():
+if 'custom' in attrs:
+_set_dns(network, attrs)
+
+
+def _set_dns(network, attrs):
+"""adding manual DNS entries"""
+dns_list = attrs['custom'].get('DNS')
+if dns_list:
+connection = _connection(network, attrs)
+nmcli_cmd = _generate_nmcli_command(dns_list, connection)
+rc, out, err = hooking.execCmd(nmcli_cmd, sudo=True)
+# pushing to /etc/resolve.conf
+if rc:
+sys.stderr.write(
+'set_dns: error executing command "%s" output: %s error: %s' %
+(nmcli_cmd, out, err))
+sys.stderr.write('Trying to modify directly /etc/resolv.conf')
+data = '\n'.join(
+["nameserver %s" % entry for entry in dns_list.split(' ')])
+data += '\n'
+with open(_RESOLV_CONF, "a") as f:
+f.write(data)
+
+
+def _generate_nmcli_command(dns_list, connection,
+keep_existing_dns_config=True):
+"""Generating relevant nmcli command"""
+# TODO: to add ipv6 stuff if needed
+cmd = [_NMCLI_BINARY, "connection", "modify", connection,
+ "+ipv4.dns" if keep_existing_dns_config else "ipv4.dns",
+ '"%s"' % dns_list]
+return cmd
+
+
+def _connection(network, attrs):
+if utils.tobool(attrs.get('bridged')):
+return network
+# bridgeless
+nics, vlan, _, bonding = netinfo.cache.CachingNetInfo(
+).getNicsVlanAndBondingForNetwork(network)
+return vlan or bonding or nics[0]
+
+
+if __name__ == '__main__':
+try:
+if '--test' in sys.argv:
+test()
+else:
+main()
+except:
+hooking.exit_hook('set dns hook: [unexpected error]: %s\n' %
+ traceback.format_exc())
diff --git a/vdsm_hooks/dns/sudoers.vdsm_hook_dns
b/vdsm_hooks/dns/sudoers.vdsm_hook_dns
new file mode 100644
index 000..6f1a7a2
--- /dev/null
+++ b/vdsm_hooks/dns/sudoers.vdsm_hook_dns
@@ -0,0 +1 @@
+vdsm ALL=(ALL) NOPASSWD: /usr/bin/nmcli *
--
To view, visit https://gerrit.ovirt.org/55750
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f18f64cf566e15a7b3317b20d5cfad24e75f95e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ilia Meerovich
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ilia Meerovich
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: virt: raise exception if create vm fails
Dan Kenigsberg has abandoned this change. Change subject: tests: virt: raise exception if create vm fails .. Abandoned -- To view, visit https://gerrit.ovirt.org/43638 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ib8b075310056dd2290c638048b3f9e463a46cff8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: makefile: ship new test data
Dan Kenigsberg has abandoned this change. Change subject: build: makefile: ship new test data .. Abandoned sorry, I've noticed https://gerrit.ovirt.org/47815 first. -- To view, visit https://gerrit.ovirt.org/47841 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I3b57024ece99471c178f15a92e2575f970a16809 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: fix testGetHostNameservers
Dan Kenigsberg has abandoned this change. Change subject: tests: fix testGetHostNameservers .. Abandoned I've already taken https://gerrit.ovirt.org/46396 -- To view, visit https://gerrit.ovirt.org/46441 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I556c7fd9a43bb2a21bf51fc6b42f23513aa7f526 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_master_unit-tests_merged - Build # 4605 - Failure!
On Tue, Feb 10, 2015 at 02:19:59PM +, Jenkins ci oVirt Server wrote: > Project: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/ > Build: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4605/ > Build Number: 4605 > Build Status: Failure > Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/37456 Haven't we already installed newer pyflakes (such as http://danken.fedorapeople.org/pyflakes-0.8.1-3.el6.noarch.rpm) on our slaves? We should. 14:19:47 pyflakes-0.4.0 14:19:47 ( find . -path './.git' -prune -type f -o \ 14:19:47-path './vdsm_compat' -prune -type f -o \ 14:19:47-name '*.py' -o -name '*.py.in' && \ 14:19:47echo contrib/profile-stats init/daemonAdapter vdsm/get-conf-item vdsm/set-conf-item vdsm/supervdsmServer vdsm/vdsm vdsm/vdsm-restore-net-config vdsm/storage/curl-img-wrap vdsm/storage/fc-scan vdsm-tool/vdsm-tool vds_bootstrap/setup vdsm_reg/vdsm-reg-setup.in ) | xargs /usr/bin/pyflakes | \ 14:19:47grep -w -v "\./vdsm/storage/lvm\.py.*: list comprehension redefines 'lv' from line .*" | \ 14:19:47while read LINE; do echo "$LINE"; false; done 14:19:57 ./vdsm/sos/vdsm.py.in:25: redefinition of unused 'RedHatPlugin' from line 22 14:19:57 ./vdsm/sos/vdsm.py.in:25: redefinition of unused 'Plugin' from line 22 14:19:57 ./vdsm/virt/guestagent.py:140: redefinition of function 'guestDiskMapping' from line 136 14:19:57 vdsm/get-conf-item:11: redefinition of unused 'config' from line 8 14:19:57 vdsm/set-conf-item:13: redefinition of unused 'config' from line 10 14:19:58 make: *** [pyflakes] Error 1 14:19:58 Build step 'Execute shell' marked build as failure ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_master_unit-tests_merged - Build # 4481 - Still Failing!
On Fri, Jan 16, 2015 at 11:57:28AM +, Jenkins ci oVirt Server wrote: > Project: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/ > Build: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4481/ > Build Number: 4481 > Build Status: Still Failing > Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/36974 > > - > Changes Since Last Success: > - > Changes for Build #4479 > [Martin Polednik] hostdev: fix el6 'format' issue > > > Changes for Build #4480 > [Timothy Asir] gluster: add glusterStorageDevicesList verb Bala, Timothy, This job is failing because you need to add python-blivet to BuildRequires, since it is used for testing. Beyond this, python-blivet is not available on el6. Are you fine with that? If so, Engine should be notified that glusterStorageDevicesList API would not be available there. In any case, the python-blivet requirement should be dropped from the el6 spec ASAP. Regards, Dan. ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_master_unit-tests_merged - Build # 4469 - Still Failing!
On Wed, Jan 14, 2015 at 12:37:16PM +, Jenkins ci oVirt Server wrote: > Project: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/ > Build: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4469/ > Build Number: 4469 > Build Status: Still Failing > Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/36890 Please see a quick fix: http://gerrit.ovirt.org/#/c/36909/ and run the unit tests before ticking V+1... ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_master_unit-tests_merged - Build # 4456 - Failure!
On Mon, Jan 12, 2015 at 05:30:44PM +, Jenkins ci oVirt Server wrote: > Project: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/ > Build: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4456/ > Build Number: 4456 > Build Status: Failure > Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/31529 Mooli, Please unbreak 17:30:44 ./lib/vdsm/tool/configurator.py:70: undefined name 'configurators' 17:30:44 ./lib/vdsm/tool/configurator.py:71: undefined name 'configurators' as soon as you can. > - > Changes Since Last Success: > - > Changes for Build #4456 > [Amador Pahim] Set sysctl to allow iSCSI multipath with multiple NICs in the > same subnet > > [Mooli Tayer] tool: autoload modules. > > [Mooli Tayer] tool: small doc format change. > > [Mooli Tayer] tool: configurator module names optional, defaults to file name. > > > > > - > Failed Tests: > - > No tests ran. > ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_master_unit-tests_merged - Build # 4379 - Still Failing!
On Tue, Dec 16, 2014 at 09:27:43PM +, Jenkins ci oVirt Server wrote: > Project: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/ > Build: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4379/ > Build Number: 4379 > Build Status: Still Failing > Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/34925 David, is you mock-based new job running? Can we silence this ever-failing job now? ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_master_unit-tests_merged - Build # 4349 - Still Failing!
On Thu, Dec 11, 2014 at 11:42:39AM +0100, David Caro wrote: > On 12/11, Dan Kenigsberg wrote: > > On Thu, Dec 11, 2014 at 10:29:52AM +0100, David Caro wrote: > > > On 12/11, Dan Kenigsberg wrote: > > > > On Wed, Dec 10, 2014 at 11:42:07PM +, Jenkins ci oVirt Server wrote: > > > > > Project: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/ > > > > > Build: > > > > > http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4349/ > > > > > Build Number: 4349 > > > > > Build Status: Still Failing > > > > > Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/36075 > > > > > > > > > > > > David, > > > > > > > > This junk mail is tiring. > > > > > > > > Could you get this job to run on a host with ioprocess>=0.14 ? > > > > > > > > > I prefer getting this fixed: > > > > > > http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/ > > > > > > It's just missing a test that hangs (testMonitorIteration) waiting for > > > a interface down event. They passed because I manually executed: > > > > > > > ip link set $interface_name down > > > > > > When the test was stuck. It passed once though without that. > > > > Can you pass NOSE_EXCLUDE=testMonitorIteration so that the test is not > > attempted? > > > > Petr, since you figured out why the test is blocking (race with starting > > ip monitor on terribly slow jenkins slave), would you post a quick hack > > so we can disable the old test? > > I've been able to reproduce on idle slaves, it's not that the slave is > loaded, or anything similar. I've reproduced also on my laptop (8GB > RAM, 8cores i7...not doing anything else). So it might be a delay when > running the monitoring, but it's not due to a slow slave (not in this > case at least). We've "solved" it in master with a short sleep added to the test. Would you check if your new job flies now? I'd love to decomission the old-and-broken vdsm_master_unit-tests_merged . Dan. ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_master_unit-tests_merged - Build # 4349 - Still Failing!
On Thu, Dec 11, 2014 at 08:10:14PM +0100, David Caro wrote: > On 12/11, Petr Horacek wrote: > > > > > > - Original Message - > > > From: "David Caro" > > > To: "Dan Kenigsberg" > > > Cc: phora...@redhat.com, "Jenkins ci oVirt Server" , > > > ee...@redhat.com, > > > vdsm-patches@lists.fedorahosted.org, nsof...@redhat.com > > > Sent: Thursday, December 11, 2014 11:42:39 AM > > > Subject: Re: [oVirt Jenkins] vdsm_master_unit-tests_merged - Build # 4349 > > > - Still Failing! > > > > > > On 12/11, Dan Kenigsberg wrote: > > > > On Thu, Dec 11, 2014 at 10:29:52AM +0100, David Caro wrote: > > > > > On 12/11, Dan Kenigsberg wrote: > > > > > > On Wed, Dec 10, 2014 at 11:42:07PM +, Jenkins ci oVirt Server > > > > > > wrote: > > > > > > > Project: > > > > > > > http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/ > > > > > > > Build: > > > > > > > http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4349/ > > > > > > > Build Number: 4349 > > > > > > > Build Status: Still Failing > > > > > > > Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/36075 > > > > > > > > > > > > > > > > > > David, > > > > > > > > > > > > This junk mail is tiring. > > > > > > > > > > > > Could you get this job to run on a host with ioprocess>=0.14 ? > > > > > > > > > > > > > > > I prefer getting this fixed: > > > > > > > > > > http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/ > > > > > > > > > > It's just missing a test that hangs (testMonitorIteration) waiting for > > > > > a interface down event. They passed because I manually executed: > > > > > > > > > > > ip link set $interface_name down > > > > > > > > > > When the test was stuck. It passed once though without that. > > > > > > > > Can you pass NOSE_EXCLUDE=testMonitorIteration so that the test is not > > > > attempted? > > I've done that, but now it seems to fail on another test (might be > that something got merged in the meantime that breaks it): > > 00:06:54.192 ERROR: testAddNetworkValidation > (configNetworkTests.TestConfigNetwork) > ... > 00:06:54.192 File "/tmp/run/vdsm/tests/monkeypatch.py", line 133, in wrapper > 00:06:54.192 return f(*args, **kw) > 00:06:54.192 File "/tmp/run/vdsm/tests/configNetworkTests.py", line 101, in > testAddNetworkValidation > 00:06:54.192 _netinfo=fakeInfo), errors.ERR_USED_BRIDGE) > 00:06:54.192 File "/tmp/run/vdsm/tests/configNetworkTests.py", line 47, in > _addNetworkWithExc > 00:06:54.192 api.addNetwork(netName, **opts) > 00:06:54.192 AttributeError: 'module' object has no attribute 'addNetwork' That's a new bug in the test case, which was not updated with the underlying code. Fixed in http://gerrit.ovirt.org/36125 ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_master_unit-tests_merged - Build # 4349 - Still Failing!
On Thu, Dec 11, 2014 at 10:29:52AM +0100, David Caro wrote: > On 12/11, Dan Kenigsberg wrote: > > On Wed, Dec 10, 2014 at 11:42:07PM +, Jenkins ci oVirt Server wrote: > > > Project: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/ > > > Build: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4349/ > > > Build Number: 4349 > > > Build Status: Still Failing > > > Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/36075 > > > > > > David, > > > > This junk mail is tiring. > > > > Could you get this job to run on a host with ioprocess>=0.14 ? > > > I prefer getting this fixed: > > http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/ > > It's just missing a test that hangs (testMonitorIteration) waiting for > a interface down event. They passed because I manually executed: > > > ip link set $interface_name down > > When the test was stuck. It passed once though without that. Can you pass NOSE_EXCLUDE=testMonitorIteration so that the test is not attempted? Petr, since you figured out why the test is blocking (race with starting ip monitor on terribly slow jenkins slave), would you post a quick hack so we can disable the old test? ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_master_unit-tests_merged - Build # 4349 - Still Failing!
On Wed, Dec 10, 2014 at 11:42:07PM +, Jenkins ci oVirt Server wrote: > Project: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/ > Build: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4349/ > Build Number: 4349 > Build Status: Still Failing > Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/36075 David, This junk mail is tiring. Could you get this job to run on a host with ioprocess>=0.14 ? ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libnl: workaround for NLE_OPNOTSUPP
Dan Kenigsberg has abandoned this change. Change subject: libnl: workaround for NLE_OPNOTSUPP .. Abandoned we decided to ask for forgiveness instead in http://gerrit.ovirt.org/#/c/35518/ -- To view, visit http://gerrit.ovirt.org/35705 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: If44a30be72cdfc506225224e95f81a26ffaa8fcd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_master_unit-tests_merged - Build # 4202 - Still Failing!
On Mon, Nov 17, 2014 at 04:36:38PM +0200, David Caro wrote: > On 11/17, Dan Kenigsberg wrote: > > On Sun, Nov 16, 2014 at 09:21:18AM +, Jenkins ci oVirt Server wrote: > > > Project: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/ > > > Build: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4202/ > > > Build Number: 4202 > > > Build Status: Still Failing > > > Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/35014 > > > > David, I know there are other causes of failures, but > > https://admin.fedoraproject.org/updates/FEDORA-2014-13355/ioprocess-0.14.0-1.fc19 > > is in stable, yet this job still fails due to fc19-vm01.phx.ovirt.org > > not having it. > > > > Any idea why it's not there by now? > > > > Because it's no being installed in the slaves. I started moving the > vdsm unit tets into mock to be able to handle properly the > dependencies and avoid messing the slave, but lots of issues happened > lately and is being delayed. > > I just installed it manually on that slave to give some time, but it > might fail on next reinstall or when running on other slaves. Indeed, it keeps failing. http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13686/console ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_master_unit-tests_merged - Build # 4202 - Still Failing!
On Mon, Nov 17, 2014 at 04:36:38PM +0200, David Caro wrote: > On 11/17, Dan Kenigsberg wrote: > > On Sun, Nov 16, 2014 at 09:21:18AM +, Jenkins ci oVirt Server wrote: > > > Project: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/ > > > Build: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4202/ > > > Build Number: 4202 > > > Build Status: Still Failing > > > Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/35014 > > > > David, I know there are other causes of failures, but > > https://admin.fedoraproject.org/updates/FEDORA-2014-13355/ioprocess-0.14.0-1.fc19 > > is in stable, yet this job still fails due to fc19-vm01.phx.ovirt.org > > not having it. > > > > Any idea why it's not there by now? > > > > Because it's no being installed in the slaves. I started moving the > vdsm unit tets into mock to be able to handle properly the > dependencies and avoid messing the slave, but lots of issues happened > lately and is being delayed. > > I just installed it manually on that slave to give some time, but it > might fail on next reinstall or when running on other slaves. But mock (should have?) pulled it in regardless, no? ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_master_unit-tests_merged - Build # 4202 - Still Failing!
On Sun, Nov 16, 2014 at 09:21:18AM +, Jenkins ci oVirt Server wrote: > Project: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/ > Build: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4202/ > Build Number: 4202 > Build Status: Still Failing > Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/35014 David, I know there are other causes of failures, but https://admin.fedoraproject.org/updates/FEDORA-2014-13355/ioprocess-0.14.0-1.fc19 is in stable, yet this job still fails due to fc19-vm01.phx.ovirt.org not having it. Any idea why it's not there by now? ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_master_create-rpms_merged_test_debug » centos7 - Build # 398 - Still Failing!
On Wed, Nov 12, 2014 at 12:06:13PM +, Jenkins ci oVirt Server wrote: > Project: > http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/label=centos7/ > > Build: > http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/label=centos7/398/ > Build Number: 398 > Build Status: Still Failing > Triggered By: Started by upstream project > "vdsm_master_create-rpms_merged_test_debug" build number 398 These jobs keep on failing due to 12:06:11 error: Failed build dependencies: 12:06:11python-ioprocess >= 0.14 is needed by vdsm-4.16.0-521.git1e98e69.el7.centos.x86_64 despite the availability of http://mirror.nonstop.co.il/epel/7/x86_64/i/ioprocess-0.14.0-1.el7.x86_64.rpm on epel7. David, do you know why this package is not pulled to that slave? ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: fix configuratorTests inheritance
Dan Kenigsberg has abandoned this change. Change subject: vdsm: fix configuratorTests inheritance .. Abandoned Already merged in http://gerrit.ovirt.org/#/c/31968/. Sorry about this breakage. Recent vdsm-tool worked should have been tested on el6. -- To view, visit http://gerrit.ovirt.org/31993 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Iabaf0663a76d07ad7f19d87b9678a9d916f91f88 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_master_create-rpms_merged » fedora19 - Build # 1606 - Failure!
On Thu, Jul 10, 2014 at 11:51:15AM +0100, Jenkins ci oVirt Server wrote: > Project: > http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/label=fedora19/ > Build: > http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/label=fedora19/1606/ > Build Number: 1606 > Build Status: Failure > Triggered By: Started by upstream project "vdsm_master_create-rpms_merged" > build number 1,606 > > - > Changes Since Last Success: > - > Changes for Build #1606 > [pkliczewski] jsonrpc: Accept all stomp commands > > > > > - > Failed Tests: > - > No tests ran. 11:51:14 IOError: [Errno 28] No space left on device 11:51:14 make[3]: *** [install-dist_vdsmtestsPYTHON] Error 1 11:51:14 make[3]: Leaving directory `/home/jenkins/workspace/vdsm_master_create-rpms_merged/label/fedora19/rpmbuild/BUILD/vdsm-4.16.0/tests' 11:51:14 make[2]: *** [install-am] Error 2 ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8: continuation line indentation is not a multiple of four
Dan Kenigsberg has abandoned this change. Change subject: pep8: continuation line indentation is not a multiple of four .. Abandoned Thanks a lot, and sorry for the noise. This has already been merged with http://gerrit.ovirt.org/29826 -- To view, visit http://gerrit.ovirt.org/29876 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ibd7c06aa18cff4a1a9b9465168e42be59544c163 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_master_create-rpms_merged » centos7 - Build # 1597 - Failure!
On Thu, Jul 10, 2014 at 09:38:14AM +0200, David Caro wrote: > On 07/10, Dan Kenigsberg wrote: > > On Wed, Jul 09, 2014 at 08:54:32PM +0100, Jenkins ci oVirt Server wrote: > > > Project: > > > http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/label=centos7/ > > > > > > Build: > > > http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/label=centos7/1597/ > > > Build Number: 1597 > > > Build Status: Failure > > > Triggered By: Started by upstream project > > > "vdsm_master_create-rpms_merged" build number 1,597 > > > > 20:54:30 checking python module: cpopen... no > > > > Can python-cpopen be added to the centos7 (and any other) slave? > > Is there a place where I can get automatically the requirements for the > running > code? > > That is a MUST if we want to automate and ease the management of dependecies > for the jobs and the tests, > > We had a lot f issues with cpopen, and most probably it's not automated it's > installation because certain versions on certain distribution make certain > vdsm > code version to fail. We had awful pains and embarrassments with python-cpopen/vdsm-cpopen, but that was back in ovirt-3.3. Nowadays, the most up-to-date python-cpopen of the relevant platform should be installed on any slave with Vdsm jobs. > To avoid that, we can use mock to build the rpms, but I'll > need anyhow the build dependencies specified somewhere with the code and as > easily parseable as possible. > > Meanwhile I can just install cpopen and let it fail the next time a slave is > set up, the version is changed or an old vdsm patch is tested. Is that ok for > you? I'd love python-cpopen to be added to our puppet definition, and forget about anything that may conflict with it. > > ps. we can use mock as a generic rom build env, tox or venv for python based > projects (I think that needs a setup.py/distutils install process though), or > with time and investment, we can try to use ephemeral virtual machines but > that's not ready yet. ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_master_create-rpms_merged » centos7 - Build # 1597 - Failure!
On Wed, Jul 09, 2014 at 08:54:32PM +0100, Jenkins ci oVirt Server wrote: > Project: > http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/label=centos7/ > Build: > http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/label=centos7/1597/ > Build Number: 1597 > Build Status: Failure > Triggered By: Started by upstream project "vdsm_master_create-rpms_merged" > build number 1,597 20:54:30 checking python module: cpopen... no Can python-cpopen be added to the centos7 (and any other) slave? Dan. ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_master_unit-tests_merged - Build # 3483 - Failure!
On Thu, Jun 19, 2014 at 09:47:23PM +0200, Piotr Kliczewski wrote: > Dan, Top-posting is evil. If someone joins the list now, he'd fine it harder to understand which shutdown problem we refer to. > > I have seen the shutdown problem. It appears every time I run the > tests. I checked the M2C code and it looks like it is issue with the > library. > I think that closing issue is not related to failing test. So do I. But can you find a simpler reproducer to this, and file a M2C bug on it? On the interpreter shutdown, __del__ is called after a module it refers to has been unloaded. > > Looking at the stack trance I see that the response never came back > from the server. I have never seen it in my local environment. > How many times we can see it when running CI? It's a timeout. I would guess it would show on an overloaded server. If I'm right, this particular timeout should be marked as a @brokentest; join the fight against false negatives. It's the first time I notice it, but maybe https://lists.fedorahosted.org/pipermail/vdsm-patches/2014-June/thread.html has other instances. > > Thanks, > Piotr > > On Thu, Jun 19, 2014 at 3:44 PM, Dan Kenigsberg wrote: > > On Thu, Jun 19, 2014 at 02:14:41PM +0100, Jenkins ci oVirt Server wrote: >> Project: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/ > >> Build: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3483/ > >> Build Number: 3483 > >> Build Status: Failure > >> Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/26576 > >> > >> - > >> Changes Since Last Success: > >> - > >> Changes for Build #3483 > > > > Piotr, > > > > http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3483/console > > shows a timeout, > > > > 14:14:41 FAIL: testMethodMissingMethod(ssl=False, type='stomp') > > (jsonRpcTests.JsonRpcServerTests) > > 14:14:41 > > -- > > 14:14:41 Traceback (most recent call last): > > 14:14:41 File > > "/home/jenkins/workspace/vdsm_master_unit-tests_merged/tests/testrunner.py", > > line 75, in wrapper > > 14:14:41 return f(self, *args) > > 14:14:41 File > > "/home/jenkins/workspace/vdsm_master_unit-tests_merged/tests/jsonRpcTests.py", > > line 123, in testMethodMissingMethod > > 14:14:41 CALL_ID, CALL_TIMEOUT) > > 14:14:41 File > > "/home/jenkins/workspace/vdsm_master_unit-tests_merged/tests/jsonRpcTests.py", > > line 63, in _callTimeout > > 14:14:41 self.assertTrue(call.wait(timeout)) > > 14:14:41 AssertionError: False is not true > > > > but beyond this, there's a shutdown problem > > > > 14:14:41 Exception AttributeError: "'NoneType' object has no attribute > > 'bio_noclose'" in > > ignored > > > > are you aware of it? ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_master_unit-tests_merged - Build # 3483 - Failure!
On Thu, Jun 19, 2014 at 02:14:41PM +0100, Jenkins ci oVirt Server wrote: > Project: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/ > Build: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3483/ > Build Number: 3483 > Build Status: Failure > Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/26576 > > - > Changes Since Last Success: > - > Changes for Build #3483 Piotr, http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3483/console shows a timeout, 14:14:41 FAIL: testMethodMissingMethod(ssl=False, type='stomp') (jsonRpcTests.JsonRpcServerTests) 14:14:41 -- 14:14:41 Traceback (most recent call last): 14:14:41 File "/home/jenkins/workspace/vdsm_master_unit-tests_merged/tests/testrunner.py", line 75, in wrapper 14:14:41 return f(self, *args) 14:14:41 File "/home/jenkins/workspace/vdsm_master_unit-tests_merged/tests/jsonRpcTests.py", line 123, in testMethodMissingMethod 14:14:41 CALL_ID, CALL_TIMEOUT) 14:14:41 File "/home/jenkins/workspace/vdsm_master_unit-tests_merged/tests/jsonRpcTests.py", line 63, in _callTimeout 14:14:41 self.assertTrue(call.wait(timeout)) 14:14:41 AssertionError: False is not true but beyond this, there's a shutdown problem 14:14:41 Exception AttributeError: "'NoneType' object has no attribute 'bio_noclose'" in > ignored are you aware of it? ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_master_unit_tests - Build # 3043 - Failure!
Francesco, Yaniv, Have you found the time to dig into the coredump of these Segmentation faults? (It is unrelated to Liron's new patches) On Fri, May 30, 2014 at 01:14:03PM +0100, Jenkins ci oVirt Server wrote: > Project: http://jenkins.ovirt.org/job/vdsm_master_unit_tests/ > Build: http://jenkins.ovirt.org/job/vdsm_master_unit_tests/3043/ > Build Number: 3043 > Build Status: Failure > Triggered By: Started by an SCM change > > - > Changes Since Last Success: > - > Changes for Build #3043 > [Federico Simoncelli] hsm: unify vm ovf management lock > > [Liron Aravot] core: imageSharing - export logic to functions > > [Liron Aravot] core: removal of unneeded callback passing > > [Liron Aravot] core: generify "streamDownloadImage" related methods > > [Liron Aravot] core: BindingXMLRPC - exporting logic out from do_PUT. > > [Liron Aravot] core: introducing uploadImageToStream > > > > > - > Failed Tests: > - > 1 tests failed. > FAILED: nosetests.xml. > > Error Message: > > > Stack Trace: > Test report file > /home/jenkins/workspace/vdsm_master_unit_tests/tests/nosetests.xml was length > 0 > > > ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_3.4_create-rpms_merged » fedora20 - Build # 219 - Failure!
On Thu, May 29, 2014 at 11:32:53AM -0400, Antoni Segura Puimedon wrote: > > > - Original Message - > > From: "Jenkins ci oVirt Server" > > To: dan...@redhat.com, vdsm-patches@lists.fedorahosted.org, > > asegu...@redhat.com > > Sent: Thursday, May 29, 2014 3:11:11 PM > > Subject: [oVirt Jenkins] vdsm_3.4_create-rpms_merged » fedora20 - Build # > > 219 - Failure! > > > > Project: > > http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms_merged/label=fedora20/ > > Build: > > http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms_merged/label=fedora20/219/ > > It is because of the pep8 in the building machine is too new for ovirt-3.4 Please disable pep8 checks in this job, by setting PEP8=true in the environment. ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_unit_tests - Build # 2873 - Failure!
On Tue, Apr 01, 2014 at 10:03:44PM +0100, Jenkins ci oVirt Server wrote: > Project: http://jenkins.ovirt.org/job/vdsm_unit_tests/ > Build: http://jenkins.ovirt.org/job/vdsm_unit_tests/2873/ > Build Number: 2873 > Build Status: Failure > Triggered By: Started by an SCM change > > - > Changes Since Last Success: > - > Changes for Build #2873 > [Yaniv Bronhaim] Initial commit for vdsm-tool testing infrastructure > > > > > - > Failed Tests: > - > All tests passed > David, has there been a change of the pyflakes version on this slave? The mentioned code lines are ancient. find . -path './.git' -prune -type f -o \ -name '*.py' -o -name '*.py.in' | xargs /usr/bin/pyflakes | \ grep -w -v "\./vdsm/storage/lvm\.py.*: list comprehension redefines 'lv' from line .*" | \ while read LINE; do echo "$LINE"; false; done ./vdsm_reg/engine.py.in:151: local variable 'item' is assigned to but never used ./vdsm_reg/engine.py:151: local variable 'item' is assigned to but never used ./vdsm/network/sourceroute.py:159: list comprehension redefines 'rule' from line 152 ./vdsm/clientIF.py:492: list comprehension redefines 'vm' from line 482 ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_create_rpms » centos6 - Build # 1107 - Still Failing!
On Mon, Feb 17, 2014 at 06:19:53PM +, Jenkins ci oVirt Server wrote: > Project: http://jenkins.ovirt.org/job/vdsm_create_rpms/label=centos6/ > Build: http://jenkins.ovirt.org/job/vdsm_create_rpms/label=centos6/1107/ > Build Number: 1107 > Build Status: Still Failing > Triggered By: Started by Naginator > > - > Changes Since Last Success: > - > Changes for Build #1100 > [Antoni S. Puimedon] netinfo: optimize ipaddr retrieval > > [Antoni S. Puimedon] net_scale: avoid netinfo instantiation for removal check These failures seems to be due to a recent change in pep8 :-( Could you fix the code, or mask the failure? /usr/bin/pep8 --version 1.4.5 /usr/bin/pep8 --exclude="config.py,constants.py" --filename '*.py,*.py.in' \ client lib/vdsm/*.py lib/vdsm/*.py.in tests vds_bootstrap vdsm-tool vdsm/*.py vdsm/*.py.in vdsm/netconf vdsm/sos/vdsm.py.in vdsm/storage vdsm/vdsm vdsm_api vdsm_hooks vdsm_reg lib/vdsm/netlink.py:158:9: E123 closing bracket does not match indentation of opening bracket's line make[3]: *** [check-local] Error 1 ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: add missing attribute
Dan Kenigsberg has abandoned this change. Change subject: tests: add missing attribute .. Abandoned I'm so sorry for not having noticed your patch: two days later I've authored my own http://gerrit.ovirt.org/23929 which is already merged. -- To view, visit http://gerrit.ovirt.org/23790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I874bed6aff0b3dc4199a5870a293cf05e57986c9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_unit_tests - Build # 2773 - Failure!
On Tue, Feb 11, 2014 at 05:24:57PM +, Jenkins ci oVirt Server wrote: > Project: http://jenkins.ovirt.org/job/vdsm_unit_tests/ > Build: http://jenkins.ovirt.org/job/vdsm_unit_tests/2773/ > Build Number: 2773 > Build Status: Failure > Triggered By: Started by an SCM change > > - > Changes Since Last Success: > - > Changes for Build #2773 > [Dan Kenigsberg] fencing: stop using a deprecated command > > > > > - > Failed Tests: > - > 1 tests failed. > REGRESSION: miscTests.WatchCmd.testLeakFd > > Error Message: > 79 != 80 > >> begin captured logging << > root: DEBUG: 'echo "Real stupidity beats artificial intelligence every > time."' (cwd None) > root: DEBUG: SUCCESS: = []; = 0 > - >> end captured logging << - > > Stack Trace: > File "/usr/lib64/python2.6/unittest.py", line 278, in run > testMethod() > File "/home/jenkins/workspace/vdsm_unit_tests/tests/miscTests.py", line > 988, in testLeakFd > self.assertEquals(openFdNum(), openFds) > File "/usr/lib64/python2.6/unittest.py", line 349, in failUnlessEqual > (msg or '%r != %r' % (first, second)) > 79 != 80 > >> begin captured logging << > root: DEBUG: 'echo "Real stupidity beats artificial intelligence every > time."' (cwd None) > root: DEBUG: SUCCESS: = []; = 0 > - >> end captured logging << - this is certainly unrelated to my string change; any idea what it *is* related to? ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_create_rpms » fedora20 - Build # 1010 - Failure!
On Mon, Jan 20, 2014 at 04:36:32PM +, Jenkins ci oVirt Server wrote: > Project: http://jenkins.ovirt.org/job/vdsm_create_rpms/./label=fedora20/ > Build: http://jenkins.ovirt.org/job/vdsm_create_rpms/./label=fedora20/1010/ > Build Number: 1010 > Build Status: Failure > Triggered By: Started by upstream project "vdsm_create_rpms" build number > 1,010 rpm building now fails due to the recent requirement of error: Failed build dependencies: python-cpopen >= 1.3 is needed by vdsm-4.14.1-0.fc20.x86_64 python-cpopen-1.3 should be available via Fedora channels. Would you make sure it installs on our slaves? Dan. ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: split xmlrpcTests.py
Dan Kenigsberg has abandoned this change. Change subject: split xmlrpcTests.py .. Abandoned Martin Polednik has done this several months ago. -- To view, visit http://gerrit.ovirt.org/11385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: If38afd417e5bb32066b13de4ff8f7b1f766f8215 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: ShaoHe Feng Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configNetwork: provide IPv6 configuration editing API
Dan Kenigsberg has abandoned this change. Change subject: configNetwork: provide IPv6 configuration editing API .. Abandoned Hunt Xu, thanks a lot for this initiative! Now we should extend it to the Engine! -- To view, visit http://gerrit.ovirt.org/11741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ibf39d8cba75e8879a84e83e22a46a4a00eab1384 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_create_rpms - Build # 812 - Failure!
On Mon, Nov 18, 2013 at 03:36:45AM -0500, Antoni Segura Puimedon wrote: > Thanks Eyal! Toni, that's not enough - we should add a BuildRequires line for something that our build scrtip requires. ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_create_rpms - Build # 812 - Failure!
On Sun, Nov 17, 2013 at 03:53:38PM +, Jenkins ci oVirt Server wrote: > Project: http://jenkins.ovirt.org/job/vdsm_create_rpms/ > Build: http://jenkins.ovirt.org/job/vdsm_create_rpms/812/ > Build Number: 812 > Build Status: Failure > Triggered By: Started by an SCM change > > - > Changes Since Last Success: > - > Changes for Build #812 > [Antoni S. Puimedon] Added missing python modules to the configure.ac checks http://jenkins.ovirt.org/job/vdsm_create_rpms/812/label=fedora18/console has checking python module: pyinotify... no configure: error: failed to find required module pyinotify even though we explictly have Requires: python-inotify in our spec. How could this happen? Is python-inotify installed on the amazon-f18 slave? ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_unit_tests - Build # 2492 - Still Failing!
On Thu, Nov 07, 2013 at 06:12:48AM -0500, Eyal Edri wrote: > > > - Original Message - > > From: "Vinzenz Feenstra" > > To: "Dan Kenigsberg" > > Cc: in...@ovirt.org, oba...@redhat.com, ee...@redhat.com, > > aba...@redhat.com, vdsm-patches@lists.fedorahosted.org, > > dc...@redhat.com > > Sent: Thursday, November 7, 2013 12:50:38 PM > > Subject: Re: [oVirt Jenkins] vdsm_unit_tests - Build # 2492 - Still Failing! > > > > On 11/07/2013 11:36 AM, Dan Kenigsberg wrote: > > > Dear infra, > > > > > > Would you install > > > http://kojipkgs.fedoraproject.org//packages/python-cpopen/1.2.3/4.el6/x86_64/python-cpopen-1.2.3-4.el6.x86_64.rpm > > > on centos64-vm02 (and any other slave running el6 vdsm_unit_tests? > > > > > > Has the package been downgraded since (the successful) > > > http://jenkins.ovirt.org/job/vdsm_unit_tests/2489/ ? > > > > > > I do not know why that build is not yet on EPEL6, but its maintainer is > > > at large until Monday. Missing this version gives annoying false > > > negatives. > > I hope that this the version which fixes the broken version 1.2.3-3 > > which is on Fedora 18,19,20 failing because of a wrong import. Yes. Vinzenz, do you have any clue why -4 is not (yet) poshed to bodhi? https://admin.fedoraproject.org/updates/search/python-cpopen > > > > > > On Thu, Nov 07, 2013 at 09:27:34AM +, Jenkins ci oVirt Server wrote: > > >> Project: http://jenkins.ovirt.org/job/vdsm_unit_tests/ > > >> Build: http://jenkins.ovirt.org/job/vdsm_unit_tests/2492/ > > >> Build Number: 2492 > > >> Build Status: Still Failing > > >> Triggered By: Started by an SCM change > > update manually for now on our centos64 slaves. > but i think we should ensure latest on our slave for all packages when they > are available. [1] > > [1] http://gerrit.ovirt.org/#/c/21021/ Would this allow newer-than-latest in rare conditions such as now? ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_unit_tests - Build # 2492 - Still Failing!
Dear infra, Would you install http://kojipkgs.fedoraproject.org//packages/python-cpopen/1.2.3/4.el6/x86_64/python-cpopen-1.2.3-4.el6.x86_64.rpm on centos64-vm02 (and any other slave running el6 vdsm_unit_tests? Has the package been downgraded since (the successful) http://jenkins.ovirt.org/job/vdsm_unit_tests/2489/ ? I do not know why that build is not yet on EPEL6, but its maintainer is at large until Monday. Missing this version gives annoying false negatives. On Thu, Nov 07, 2013 at 09:27:34AM +, Jenkins ci oVirt Server wrote: > Project: http://jenkins.ovirt.org/job/vdsm_unit_tests/ > Build: http://jenkins.ovirt.org/job/vdsm_unit_tests/2492/ > Build Number: 2492 > Build Status: Still Failing > Triggered By: Started by an SCM change ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: vdsm_create_rpms - Build # 758 - Failure!
On Fri, Oct 18, 2013 at 11:05:14AM -0400, R P Herrold wrote: > On Fri, 18 Oct 2013, Dan Kenigsberg wrote: > > >Ohad, can we get python-cpopen on fedora19? > > > >error: Failed build dependencies: > > python-cpopen is needed by vdsm-4.13.0-53.git3a915c5.fc19.x86_64 > > It seems to be there under another name, and so blocked, needing > addition of a new Provides entry > > https://bugzilla.redhat.com/show_bug.cgi?id=903246#c26 > > as noted in > > https://bugzilla.redhat.com/show_bug.cgi?id=1020321 > > Perhaps (to get an immediate local control over solving the issue), > instead of using the 'package requires', have vdsm look for a > capability and let yum sort it out? > > Requires: cpopen.so > vs > Requires: python-cpopen > > [root@vdsm-builder ~]# rpm -qa \*cpopen\* > python-cpopen-1.2.3-2.el6.x86_64 > [root@vdsm-builder ~]# rpm -q --provides python-cpopen > cpopen.so()(64bit) > python-cpopen = 1.2.3-2.el6 > python-cpopen(x86-64) = 1.2.3-2.el6 > [root@vdsm-builder ~]# > > > [root@vdsm-builder SPECS]# grep cpopen *spec > BuildRequires: python-cpopen > Requires: python-cpopen > - Removing vdsm-python-cpopen from the spec > - Adding dependency on formal cpopen package > - Adding cpopen package > [root@vdsm-builder SPECS]# I'd love the problem in python-cpopen's upgrade path is solved in parallel to the problem of our slave. The latter can be quickly avoided by `yum remove vdsm-python-cpopen`. The current rate of false Jenkins failure make Jenkins unaffective (as people tend to ignore its results). ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_create_rpms - Build # 758 - Failure!
Ohad, can we get python-cpopen on fedora19? error: Failed build dependencies: python-cpopen is needed by vdsm-4.13.0-53.git3a915c5.fc19.x86_64 On Thu, Oct 17, 2013 at 08:29:07PM +0100, Jenkins ci oVirt Server wrote: > Project: http://jenkins.ovirt.org/job/vdsm_create_rpms/ > Build: http://jenkins.ovirt.org/job/vdsm_create_rpms/758/ > Build Number: 758 > Build Status: Failure > Triggered By: Started by an SCM change > > - > Changes Since Last Success: > - > Changes for Build #758 > [Zhou Zheng Sheng] Packaging: fix ./configure option for libvirt environment > file > > [Zhou Zheng Sheng] Packaging: libvirt configuration detection should skip > /dev/null > > > > > - > Failed Tests: > - > No tests ran. > ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_unit_tests - Build # 2379 - Failure!
On Thu, Oct 03, 2013 at 07:57:19AM +0100, Jenkins ci oVirt Server wrote: > Project: http://jenkins.ovirt.org/job/vdsm_unit_tests/ > Build: http://jenkins.ovirt.org/job/vdsm_unit_tests/2379/ > Build Number: 2379 > Build Status: Failure > Triggered By: Started by an SCM change > > - > Changes Since Last Success: > - > Changes for Build #2379 > > > > - > Failed Tests: > - > 3 tests failed. > REGRESSION: mkimageTests.MkimageTestCase.test_mkIsoFs(label=None) Something on the slaves (and I do not currently care if it's gvfs or not) is causing a leak of loopback devices. If we cannot solve the problem, it is time to NOSE_EXCLUDE this test. Having people disregard test results is more dangerous than skipping this test. Dan. ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8 clean vdsm/storage/securable.py
Dan Kenigsberg has abandoned this change. Change subject: pep8 clean vdsm/storage/securable.py .. Abandoned All pending pep8 issues have been fixed. -- To view, visit http://gerrit.ovirt.org/4682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ie1c5b97b22ffc921e17e4cef2e79244d5ad190c7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Title: fix some code style consist with pep8
Dan Kenigsberg has abandoned this change. Change subject: Title: fix some code style consist with pep8 .. Abandoned All pending pep8 issues have been fixed. -- To view, visit http://gerrit.ovirt.org/4500 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I50cf61d9b7815cbdd5571930e3f9be59183a83f4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Changming Bai Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Changming Bai Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Zhou Zheng Sheng ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modify before_vm_migrate_source.py for PEP8 compliance
Dan Kenigsberg has abandoned this change. Change subject: Modify before_vm_migrate_source.py for PEP8 compliance .. Abandoned All pending pep8 issues have been fixed. -- To view, visit http://gerrit.ovirt.org/4332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I0b02d00083eb0390be4708f122c94f6682c03359 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Qiao Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modify before_vm_migrate_source.py for PEP8 compliance
Dan Kenigsberg has abandoned this change. Change subject: Modify before_vm_migrate_source.py for PEP8 compliance .. Abandoned All pending pep8 issues have been fixed. -- To view, visit http://gerrit.ovirt.org/4331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I33b157093350f0c96639836175d2b313fd684984 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Qiao Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modify ./vdsm/__init__.py for PEP8 compliance ./vdsm/__init_...
Dan Kenigsberg has abandoned this change. Change subject: Modify ./vdsm/__init__.py for PEP8 compliance ./vdsm/__init__.py .. Abandoned All pending pep8 issues have been fixed. -- To view, visit http://gerrit.ovirt.org/4333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ifca40b37c8a4a01d30589e33d49016975ed0f53e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Qiao Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pep8 clean vdsm/storage/hba.py
Dan Kenigsberg has abandoned this change. Change subject: pep8 clean vdsm/storage/hba.py .. Abandoned All pending pep8 issues have been fixed. -- To view, visit http://gerrit.ovirt.org/4382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I5afe01d5cf3a6018f6d513a04b3b0e37335c5675 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_create_rpms » centos64 - Build # 683 - Still Failing!
Thanks! On Mon, Sep 23, 2013 at 03:11:40PM -0400, Eyal Edri wrote: > already fixed: > > http://jenkins.ovirt.org/job/vdsm_create_rpms/./label=centos64/ > > thanks, > > Eyal > > - Original Message - > > From: "Dan Kenigsberg" > > To: ee...@redhat.com > > Cc: vdsm-patches@lists.fedorahosted.org, sbona...@redhat.com > > Sent: Monday, September 23, 2013 8:16:50 PM > > Subject: Re: [oVirt Jenkins] vdsm_create_rpms » centos64 - Build # 683 - > > Still Failing! > > > > On Mon, Sep 23, 2013 at 04:11:34PM +0100, Jenkins ci oVirt Server wrote: > > > Project: http://jenkins.ovirt.org/job/vdsm_create_rpms/./label=centos64/ > > > Build: http://jenkins.ovirt.org/job/vdsm_create_rpms/./label=centos64/683/ > > > Build Number: 683 > > > Build Status: Still Failing > > > Triggered By: Started by upstream project "vdsm_create_rpms" build number > > > 683 > > > > > > - > > > Changes Since Last Success: > > > - > > > Changes for Build #682 > > > > > > Changes for Build #683 > > > [Sandro Bonazzola] packaging: spec: selinux-policy-targeted requirements > > > > This fails due to a missing BuildRequires on that centos64 slave. > > > > error: Failed build dependencies: > > libselinux-python is needed by vdsm-4.12.0-146.gitc2a54cb.el6.x86_64 > > > > can it be fixed? > > ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_create_rpms » centos64 - Build # 683 - Still Failing!
On Mon, Sep 23, 2013 at 04:11:34PM +0100, Jenkins ci oVirt Server wrote: > Project: http://jenkins.ovirt.org/job/vdsm_create_rpms/./label=centos64/ > Build: http://jenkins.ovirt.org/job/vdsm_create_rpms/./label=centos64/683/ > Build Number: 683 > Build Status: Still Failing > Triggered By: Started by upstream project "vdsm_create_rpms" build number 683 > > - > Changes Since Last Success: > - > Changes for Build #682 > > Changes for Build #683 > [Sandro Bonazzola] packaging: spec: selinux-policy-targeted requirements This fails due to a missing BuildRequires on that centos64 slave. error: Failed build dependencies: libselinux-python is needed by vdsm-4.12.0-146.gitc2a54cb.el6.x86_64 can it be fixed? ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Modify vdsm/netinfo.py for PEP8 compliance
Dan Kenigsberg has abandoned this change. Change subject: Modify vdsm/netinfo.py for PEP8 compliance .. Abandoned Zhou Zheng ShengMar 15, 2013 Patch Set 1: Hi Tal. I think this patch is outdated. There is a similar patch (commit ID 6822c4b) merged. -- To view, visit http://gerrit.ovirt.org/4334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I5a8370da88235ff0edce7cf7b1a350fb0402e7d9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Qiao Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_create_rpms - Build # 637 - Still Failing!
On Tue, Sep 03, 2013 at 06:55:23PM +0100, Jenkins ci oVirt Server wrote:
> Project: http://jenkins.ovirt.org/job/vdsm_create_rpms/
> Build: http://jenkins.ovirt.org/job/vdsm_create_rpms/637/
> Build Number: 637
> Build Status: Still Failing
> Triggered By: Started by an SCM change
>
> -
> Changes Since Last Success:
> -
> Changes for Build #636
> [Yaniv Bronhaim] Fixing start return the return value of vdsm execution
>
>
> Changes for Build #637
> [Federico Simoncelli] storage: kill ongoing operations on exit
Douglas, the fedora18 slave has
RPM build errors:
File must begin with "/": %{_tmpfilesdir}/vdsm.conf
make: *** [rpm] Error 1
Build step 'Execute shell' marked build as failure
Archiving artifacts
Finished: FAILURE
but AFAIR %{_tmpfilesdir} should have been well-defined in F18. Any idea?
David, could you find out what is `rpm --version` on fedora18, and what is `rpm
--eval '%{_tmpfilesdir}'`?
Dan.
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_create_rpms - Build # 514 - Failure!
On Tue, Jul 16, 2013 at 09:17:07AM +0100, Jenkins ci oVirt Server wrote:
> Project: http://jenkins.ovirt.org/job/vdsm_create_rpms/
> Build: http://jenkins.ovirt.org/job/vdsm_create_rpms/514/
> Build Number: 514
> Build Status: Failure
> Triggered By: Started by an SCM change, Started by an SCM change
>
> -
> Changes Since Last Success:
> -
> Changes for Build #514
> [Douglas Schilling Landgraf] vdsm: /usr/lib/tmpfiles.d/vdsm.conf
>
> [Mark Wu] Remove mac address from host interface statistics
>
> [Zhou Zheng Sheng] destroyStoragePool: release host id lease correctly
Douglas, could this failure
http://jenkins.ovirt.org/job/vdsm_create_rpms/514/label=fedora17/console
stems from %{_tmpfilesdir} being undefined in Fedora 17?
I do not really mind obsoleting support for F17, but until we do that -
please make sure the spec builds there (i.e. by defining the macro
explicitly if it is missing).
Dan.
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_unit_tests - Build # 2050 - Failure!
On Wed, Jun 05, 2013 at 04:58:50AM -0400, Eyal Edri wrote:
> anyone is looking into these failures?
Haven't we seen a similar race in cpopen before?
>
> - Original Message -
> > From: "Jenkins ci oVirt Server"
> > To: ee...@redhat.com, aba...@redhat.com, dan...@redhat.com,
> > vdsm-patches@lists.fedorahosted.org, dc...@redhat.com,
> > ybron...@redhat.com
> > Sent: Tuesday, June 4, 2013 8:14:52 PM
> > Subject: [oVirt Jenkins] vdsm_unit_tests - Build # 2050 - Failure!
> >
> > Project: http://jenkins.ovirt.org/job/vdsm_unit_tests/
> > Build: http://jenkins.ovirt.org/job/vdsm_unit_tests/2050/
> > Build Number: 2050
> > Build Status: Failure
> > Triggered By: Started by an SCM change
> >
> > -
> > Changes Since Last Success:
> > -
> > Changes for Build #2050
> > [Yaniv Bronhaim] Making getAllTasks[List and Statuses] an SPM command
> >
> >
> >
> >
> > -
> > Failed Tests:
> > -
> > 4 tests failed.
> > REGRESSION: miscTests.GetCmdArgsTests.test
> >
> > Error Message:
> > Tuples differ: () != ('sleep', '4')
> >
> > Second tuple contains 2 additional elements.
> > First extra element 0:
> > sleep
> >
> > - ()
> > + ('sleep', '4')
> > >> begin captured logging <<
> > Storage.Misc.excCmd: DEBUG: 'sleep 4' (cwd None)
> > - >> end captured logging << -
> >
> > Stack Trace:
> > Traceback (most recent call last):
> > File "/usr/lib64/python2.7/unittest/case.py", line 365, in run
> > testMethod()
> > File "/home/jenkins/workspace/vdsm_unit_tests/tests/miscTests.py", line
> > 87,
> > in test
> > self.assertEquals(misc.getCmdArgs(sproc.pid), tuple(args))
> > File "/usr/lib64/python2.7/unittest/case.py", line 549, in assertEqual
> > assertion_func(first, second, msg=msg)
> > File "/usr/lib64/python2.7/unittest/case.py", line 789, in
> > assertTupleEqual
> > self.assertSequenceEqual(tuple1, tuple2, msg, seq_type=tuple)
> > File "/usr/lib64/python2.7/unittest/case.py", line 760, in
> > assertSequenceEqual
> > self.fail(msg)
> > File "/usr/lib64/python2.7/unittest/case.py", line 446, in fail
> > raise self.failureException(msg)
> > AssertionError: Tuples differ: () != ('sleep', '4')
> >
> > Second tuple contains 2 additional elements.
> > First extra element 0:
> > sleep
> >
> > - ()
> > + ('sleep', '4')
> > >> begin captured logging <<
> > Storage.Misc.excCmd: DEBUG: 'sleep 4' (cwd None)
> > - >> end captured logging << -
> >
> >
> > REGRESSION: remoteFileHandlerTests.PoolHandlerTests.testStop
> >
> > Error Message:
> >
> >
> > Stack Trace:
> > Traceback (most recent call last):
> > File "/usr/lib64/python2.7/unittest/case.py", line 365, in run
> > testMethod()
> > File
> > "/home/jenkins/workspace/vdsm_unit_tests/tests/remoteFileHandlerTests.py",
> > line 67, in testStop
> > procPath))
> > File
> >
> > "/home/jenkins/workspace/vdsm_unit_tests/vdsm/storage/remoteFileHandler.py",
> > line 184, in callCrabRPCFunction
> > rawLength = self._recvAll(LENGTH_STRUCT_LENGTH, timeout)
> > File
> >
> > "/home/jenkins/workspace/vdsm_unit_tests/vdsm/storage/remoteFileHandler.py",
> > line 150, in _recvAll
> > raise Timeout()
> > Timeout
> >
> >
> > REGRESSION: remoteFileHandlerTests.RemoteFileHandlerTests.testEcho
> >
> > Error Message:
> >
> >
> > Stack Trace:
> > Traceback (most recent call last):
> > File "/usr/lib64/python2.7/unittest/case.py", line 365, in run
> > testMethod()
> > File
> > "/home/jenkins/workspace/vdsm_unit_tests/tests/remoteFileHandlerTests.py",
> > line 41, in testEcho
> > self.assertEquals(self.pool.callCrabRPCFunction(5, "echo", data), data)
> > File
> >
> > "/home/jenkins/workspace/vdsm_unit_tests/vdsm/storage/remoteFileHandler.py",
> > line 284, in callCrabRPCFunction
> > *args, **kwargs)
> > File
> >
> > "/home/jenkins/workspace/vdsm_unit_tests/vdsm/storage/remoteFileHandler.py",
> > line 184, in callCrabRPCFunction
> > rawLength = self._recvAll(LENGTH_STRUCT_LENGTH, timeout)
> > File
> >
> > "/home/jenkins/workspace/vdsm_unit_tests/vdsm/storage/remoteFileHandler.py",
> > line 150, in _recvAll
> > raise Timeout()
> > Timeout
> >
> >
> > REGRESSION: remoteFileHandlerTests.RemoteFileHandlerTests.testRegeneration
> >
> > Error Message:
> >
> >
> > Stack Trace:
> > Traceback (most recent call last):
> > File "/usr/lib64/python2.7/unittest/case.py", line 365, in run
> > testMethod()
> > File
> > "/home/jenkins/workspace/vdsm_unit_tests/tests/remoteFileHandlerTests.py",
> > line 54, in testRegeneration
> > self.testEcho()
> > File
> > "/home/jenkins/workspace/vdsm_unit_tests/tests/remoteFileHandlerTests.py",
> > line 41, in testEcho
> > self.assertEquals(self
Re: vdsm does not build on fedora17
On Mon, Apr 29, 2013 at 06:13:38PM +0200, Ewoud Kohl van Wijngaarden wrote: > On Mon, Apr 29, 2013 at 11:02:43AM -0400, Kiril Nesenko wrote: > > > > - Original Message - > > > From: "Ewoud Kohl van Wijngaarden" > > > To: "David Caro" > > > Cc: "Kiril Nesenko" , "Dan Kenigsberg" > > > , vdsm-patches@lists.fedorahosted.org, > > > "Mark Wu" > > > Sent: Monday, April 29, 2013 4:20:03 PM > > > Subject: Re: vdsm does not build on fedora17 > > > > > > On Mon, Apr 29, 2013 at 03:05:32PM +0200, David Caro wrote: > > > > On 04/29, Kiril Nesenko wrote: > > > > > [Adding David] > > > > > > > > > > David, > > > > > Can you access the slave and update pep8 there ? > > > > > > > > No, that server is owned by ekohl, adding him to the thread. > > > > > > Update to which version? I've done a yum update python-pep8 but that > > > shows no possible updates. > > > > > > > Can you post here the version of python-pep8 you have ? > > yum tells me 1.0.1-1.fc17. And what do we have on other slaves? My python-pep8-1.4.4 do not mind the code. Would you agree to build it from source http://kojipkgs.fedoraproject.org//packages/python-pep8/1.4.4/1.fc18/src/python-pep8-1.4.4-1.fc18.src.rpm and put on that slave? If that's difficult, I would like to ask you, Mark, to mangle the code to make pep8-1.0.1 happy with it. Regards, Dan. Would you agree to upgrade to ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
vdsm does not build on fedora17
On Mon, Apr 29, 2013 at 04:46:18AM +0100, Jenkins ci oVirt Server wrote: > Project: http://jenkins.ovirt.org/job/vdsm_create_rpms/ > Build: http://jenkins.ovirt.org/job/vdsm_create_rpms/365/ Hi Mark, Kiril, Since I've taken http://gerrit.ovirt.org/14198 in, we're getting pep8 error on fedora17 slave http://jenkins.ovirt.org/job/vdsm_create_rpms/label=fedora17/365/consoleFull /bin/pep8 --exclude="config.py,constants.py" --filename '*.py,*.py.in' \ client lib/betterPopen/*.py lib/vdsm/*.py lib/vdsm/*.py.in tests vds_bootstrap vdsm-tool vdsm/*.py vdsm/*.py.in vdsm/netconf vdsm/sos/vdsm.py.in vdsm/storage vdsm/vdsm vdsm_api vdsm_hooks vdsm_reg vdsm/configNetwork.py:562:56: E251 no spaces around keyword / parameter equals I'm guessing that this can be fixed by updating pep8 on the fedora17 slave as the issue is not caught by other slaves. Kiril, could you do this upgrade? Dan. ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_unit_tests_gerrit - Build # 1673 - Still Failing!
On Mon, Mar 18, 2013 at 03:53:52PM +0100, Vinzenz Feenstra wrote: > On 03/18/2013 03:50 PM, Jenkins ci oVirt Server wrote: > >Jelly script [fail-test-name] was not found in $JENKINS_HOME/email-templates. > Can we fix that issue? > This is still this false positive of > > ./vdsm/storage/lvm.py:612: list comprehension redefines 'lv' from line 607 > > It's pretty annoying :( Just rebase on top of commit 6177a169fc845762d6ce9115566dbed1894c6acb Author: Douglas Schilling Landgraf Date: Fri Mar 8 11:24:13 2013 -0500 Makefile.am: ignore false positive pyflakes lvm.py ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: Refactor communication infra
On Mon, Jan 07, 2013 at 03:10:38PM -0500, dan...@redhat.com wrote:
> Dan Kenigsberg has posted comments on this change.
>
> Change subject: Refactor communication infra
> ..
>
>
> Patch Set 15: (2 inline comments)
>
>
> File vdsm_api/BindingJsonRpc.py
> Line 37: self._reactors = reactors
> Line 38:
> Line 39: def _createTcpReactor(self, cfg):
> Line 40: address = cfg.get("ip", "0.0.0.0")
> Line 41: port = cfg.get("port", 4044)
> sorry, I do not follow. which error handling code would have been required?
> to handle the case of not having cfg['ip'] ? having a default here only hide
> such an error instead of crying out loud about it.
Saggi, Adam, could you help me here?
I do not understand the need for the default port here.
Could you elaborate on the justification?
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_unit_tests - Build # 1502 - Still Failing!
On Tue, Nov 06, 2012 at 12:41:42PM -0500, Jenkins oVirt Server wrote: > > BUILD FAILURE > Build URL: http://jenkins.ovirt.org/job/vdsm_unit_tests/1502/ > Project: vdsm_unit_tests > Date of build: Tue, 06 Nov 2012 12:41:22 -0500 > Build duration: 20 sec Eyal, please take a look at this machine: it seems that /home/jenkins/workspace/vdsm_unit_tests/ has some trash remainder, an old vdsm/pthread.pyc. Would you make sure that the directory is clean before checking out from git? Dan. ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_unit_tests - Build # 646 - Still Failing!
On Wed, Oct 31, 2012 at 02:19:32AM -0400, Eyal Edri wrote: > Danken, > > is anyone looking at these unit tests failures? Saggi is aware of these failures, but he cannot reproduce them on his machines. Would you grant him access to one of your slaves, where he could test the issue? If this is not solved promptly, I would have to revert the offending commit message. > > - Original Message - > > From: "Jenkins oVirt Server" > > To: ee...@redhat.com, aba...@redhat.com, dan...@redhat.com, > > vdsm-patches@lists.fedorahosted.org > > Sent: Tuesday, October 30, 2012 8:57:14 PM > > Subject: [oVirt Jenkins] vdsm_unit_tests - Build # 646 - Still Failing! > > > > > > BUILD FAILURE > > Build URL: http://jenkins.ovirt.org/job/vdsm_unit_tests/646/ > > Project: vdsm_unit_tests > > Date of build: Tue, 30 Oct 2012 14:56:21 -0400 > > Build duration: 52 sec > > > > CHANGE SET > > Revision 4f47bd28bee26ed37f98d7899f1bd26a2003fc70 by ybronhei: > > (Reporting error instead of warn when timeout is raised in oop > > operation) > > change: edit vdsm/storage/remoteFileHandler.py > > > > > > JUNIT RESULTS > > > > Name: alignmentScanTests Failed: 0 test(s), Passed: 0 test(s), > > Skipped: 4 test(s), Total: 4 test(s) > > > > > > Name: betterPopenTests Failed: 0 test(s), Passed: 11 test(s), > > Skipped: 1 test(s), Total: 12 test(s) > > > > > > Name: capsTests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 > > test(s), Total: 4 test(s) > > > > > > Name: configNetworkTests Failed: 0 test(s), Passed: 10 test(s), > > Skipped: 0 test(s), Total: 10 test(s) > > > > > > Name: fileUtilTests Failed: 0 test(s), Passed: 5 test(s), Skipped: 2 > > test(s), Total: 7 test(s) > > > > > > Name: getAllVolumesTests Failed: 0 test(s), Passed: 2 test(s), > > Skipped: 0 test(s), Total: 2 test(s) > > > > > > Name: gluster_cli_tests Failed: 0 test(s), Passed: 3 test(s), > > Skipped: 0 test(s), Total: 3 test(s) > > > > > > Name: guestIFTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 > > test(s), Total: 2 test(s) > > > > > > Name: hooksTests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 > > test(s), Total: 6 test(s) > > > > > > Name: libvirtvmTests Failed: 0 test(s), Passed: 17 test(s), Skipped: > > 0 test(s), Total: 17 test(s) > > > > > > Name: lsblkTests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 > > test(s), Total: 1 test(s) > > > > > > Name: main Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), > > Total: 3 test(s) > > > > > > Name: md_utils_tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 > > test(s), Total: 1 test(s) > > > > > > Name: miscTests Failed: 1 test(s), Passed: 69 test(s), Skipped: 0 > > test(s), Total: 70 test(s) > > > > Failed: miscTests.GetCmdArgsTests.test > > > > Name: mkimageTests Failed: 0 test(s), Passed: 3 test(s), Skipped: 1 > > test(s), Total: 4 test(s) > > > > > > Name: mountTests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 > > test(s), Total: 1 test(s) > > > > > > Name: netinfoTests Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 > > test(s), Total: 5 test(s) > > > > > > Name: outOfProcessTests Failed: 0 test(s), Passed: 4 test(s), > > Skipped: 0 test(s), Total: 4 test(s) > > > > > > Name: parted_utils_tests Failed: 0 test(s), Passed: 0 test(s), > > Skipped: 1 test(s), Total: 1 test(s) > > > > > > Name: permutationTests Failed: 0 test(s), Passed: 3 test(s), Skipped: > > 0 test(s), Total: 3 test(s) > > > > > > Name: persistentDictTests Failed: 0 test(s), Passed: 2 test(s), > > Skipped: 0 test(s), Total: 2 test(s) > > > > > > Name: remoteFileHandlerTests Failed: 0 test(s), Passed: 3 test(s), > > Skipped: 0 test(s), Total: 3 test(s) > > > > > > Name: resourceManagerTests Failed: 0 test(s), Passed: 33 test(s), > > Skipped: 0 test(s), Total: 33 test(s) > > > > > > Name: restTests Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 > > test(s), Total: 16 test(s) > > > > > > Name: tcTests Failed: 0 test(s), Passed: 1 test(s), Skipped: 7 > > test(s), Total: 8 test(s) > > > > > > Name: vdsClientTests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 > > test(s), Total: 1 test(s) > > > > ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ignore
Dan Kenigsberg has posted comments on this change. Change subject: ignore .. Patch Set 1: I'm not going to ignore a public suicide notification. That would be inhumane. -- To view, visit http://gerrit.ovirt.org/8630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11af1911a7a5bf8cdc3653714629096c0368893f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: add emulator pin support to create vm
Dan Kenigsberg has posted comments on this change.
Change subject: add emulator pin support to create vm
..
Patch Set 1: (2 inline comments)
File vdsm/libvirtvm.py
Line 735: f.setAttribute('name', feature[1:])
Line 736: cpu.appendChild(f)
Line 737: self.dom.appendChild(cpu)
Line 738:
Line 739: def appendTunable(self):
I find "tunable" as a very vague name. how about appendCpuPin?
Line 740: #CPU-pinning support
Line 741: # see http://www.ovirt.org/wiki/Features/Design/cpu-pinning
Line 742: if 'cpuPinning' in self.conf:
Line 743: cputune = self.doc.createElement('cputune')
Line 746: emulatorset = cpuPinning.pop('emulator')
Line 747: emulatorpin = self.doc.createElement('emulatorpin')
Line 748: emulatorpin.setAttribute('cpuset', emulatorset)
Line 749: cputune.appendChild(emulatorpin)
Line 750: except:
catch-all "except" is evil. Do not use it unless you have a very good reason.
Certainly not with a "pass".
Line 751: pass
Line 752: for cpuPin in cpuPinning.keys():
Line 753: vcpupin = self.doc.createElement('vcpupin')
Line 754: vcpupin.setAttribute('vcpu', cpuPin)
--
To view, visit http://gerrit.ovirt.org/8411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic616b825eca94682e1563ab51773d8a23351998d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv
Gerrit-Reviewer: Laszlo Hornyak
Gerrit-Reviewer: Royce Lv
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configNetworkTests: Fix wrong key for interface of bridgeles...
Dan Kenigsberg has posted comments on this change. Change subject: configNetworkTests: Fix wrong key for interface of bridgeless network .. Patch Set 1: Thanks anyway for the fix. -- To view, visit http://gerrit.ovirt.org/6845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib070e476f8fa059c2c181e52768d7623526cf8db Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_unit_tests - Build # 313 - Still Failing!
On Tue, Jul 17, 2012 at 02:27:38AM -0400, Ayal Baron wrote: > > > - Original Message - > > Is someone having a look at that unit test error? > > Dan? > > > Name: configNetworkTests Failed: 1 test(s), Passed: 3 test(s), Eyal, could you (or someone else from infra) install vdsm.rpm once on each slave? This failure is about 'vdsm' user not reqognized on the host. Installing vdsm once would define it and its group. > > > > > fyi, i've added a vdsm unit test gerrit job that will be triggered on > > each vdsm patch. > > for now it's on silent mode, so it won't -1 patches on failure, once > > we'll see jenkins can handle the load of commits, > > we'll enable verify. > > great! I hope this test is being run only on patches from vetted posters, or a patch that got a +1 from a human vetted poster. We *must not* be running code from John Doe on our servers. Dan. ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_unit_tests - Build # 286 - Still Failing!
Eyal, could you (or someone else with access to jenkins slaves) install cherrypy (and its dependencies) to make this problem go away? On Sat, Jul 07, 2012 at 02:17:16AM -0400, Jenkins oVirt Server wrote: > > BUILD FAILURE > Build URL: http://jenkins.ovirt.org/job/vdsm_unit_tests/286/ > Project: vdsm_unit_tests ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_unit_tests - Build # 244 - Still Failing!
On Thu, Jun 28, 2012 at 10:18:31AM -0400, Eyal Edri wrote: > > > - Original Message - > > From: "Dan Kenigsberg" > > To: "Eyal Edri" > > Cc: aba...@redhat.com, vdsm-patches@lists.fedorahosted.org, > > zhshz...@linux.vnet.ibm.com, "Moran Goldboim" > > > > Sent: Thursday, June 28, 2012 4:22:55 PM > > Subject: Re: [oVirt Jenkins] vdsm_unit_tests - Build # 244 - Still Failing! > > > > On Thu, Jun 28, 2012 at 08:58:06AM -0400, Eyal Edri wrote: > > > > > > > > > - Original Message - > > > > From: "Dan Kenigsberg" > > > > To: "Eyal Edri" , "Moran Goldboim" > > > > > > > > Cc: aba...@redhat.com, vdsm-patches@lists.fedorahosted.org, > > > > zhshz...@linux.vnet.ibm.com > > > > Sent: Thursday, June 28, 2012 3:34:36 PM > > > > Subject: Re: [oVirt Jenkins] vdsm_unit_tests - Build # 244 - > > > > Still Failing! > > > > > > > > On Thu, Jun 28, 2012 at 07:53:03AM -0400, Jenkins oVirt Server > > > > wrote: > > > > > > > > > > BUILD FAILURE > > > > > Build URL: http://jenkins.ovirt.org/job/vdsm_unit_tests/244/ > > > > > Project: vdsm_unit_tests > > > > > Date of build: Thu, 28 Jun 2012 07:52:49 -0400 > > > > > Build duration: 14 sec > > > > > > > > > > CHANGE SET > > > > > Revision ea3fbf451d8f9a7490e8f5f0892fd20694ec16af by zhshzhou: > > > > > (fix > > > > > "make check" failing on "vdscli.py" > > > > > missing) > > > > > change: edit vdsm_cli/Makefile.am > > > > > Revision ddeb9dd8cbf6e814e416c6e75a320b65590c3446 by danken: > > > > > (BZ# > > > > href='http://bugzilla.redhat.com/show_bug.cgi?id=806555'>806555 > > > > > having /etc/ovirt-node-* means it is a node) > > > > > change: edit vdsm/caps.py > > > > > > > > checking for pyflakes... no > > > > configure: error: pyflakes not found, please install it. > > > > > > pyflakes is installed on host, but job still fails. > > > > Fails why? http://jenkins.ovirt.org/job/vdsm_unit_tests/245/console > > still complains about pyflakes. > > Jenkins had an error where the job said it was running on a slave, but it was > actually running on a different server for some reason. > the slave it was set to run on had all rpms installed on it. > > > > > > i'm disabling the job until the issue is resolved. > > > > I've become addicted to these unit tests, give me my portion asap! > > Yay! We're back at the blues. Thanks! ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_unit_tests - Build # 244 - Still Failing!
On Thu, Jun 28, 2012 at 08:58:06AM -0400, Eyal Edri wrote: > > > - Original Message - > > From: "Dan Kenigsberg" > > To: "Eyal Edri" , "Moran Goldboim" > > Cc: aba...@redhat.com, vdsm-patches@lists.fedorahosted.org, > > zhshz...@linux.vnet.ibm.com > > Sent: Thursday, June 28, 2012 3:34:36 PM > > Subject: Re: [oVirt Jenkins] vdsm_unit_tests - Build # 244 - Still Failing! > > > > On Thu, Jun 28, 2012 at 07:53:03AM -0400, Jenkins oVirt Server wrote: > > > > > > BUILD FAILURE > > > Build URL: http://jenkins.ovirt.org/job/vdsm_unit_tests/244/ > > > Project: vdsm_unit_tests > > > Date of build: Thu, 28 Jun 2012 07:52:49 -0400 > > > Build duration: 14 sec > > > > > > CHANGE SET > > > Revision ea3fbf451d8f9a7490e8f5f0892fd20694ec16af by zhshzhou: (fix > > > "make check" failing on "vdscli.py" missing) > > > change: edit vdsm_cli/Makefile.am > > > Revision ddeb9dd8cbf6e814e416c6e75a320b65590c3446 by danken: (BZ# > > href='http://bugzilla.redhat.com/show_bug.cgi?id=806555'>806555 > > > having /etc/ovirt-node-* means it is a node) > > > change: edit vdsm/caps.py > > > > checking for pyflakes... no > > configure: error: pyflakes not found, please install it. > > pyflakes is installed on host, but job still fails. Fails why? http://jenkins.ovirt.org/job/vdsm_unit_tests/245/console still complains about pyflakes. > i'm disabling the job until the issue is resolved. I've become addicted to these unit tests, give me my portion asap! ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_unit_tests - Build # 244 - Still Failing!
On Thu, Jun 28, 2012 at 07:53:03AM -0400, Jenkins oVirt Server wrote: > > BUILD FAILURE > Build URL: http://jenkins.ovirt.org/job/vdsm_unit_tests/244/ > Project: vdsm_unit_tests > Date of build: Thu, 28 Jun 2012 07:52:49 -0400 > Build duration: 14 sec > > CHANGE SET > Revision ea3fbf451d8f9a7490e8f5f0892fd20694ec16af by zhshzhou: (fix > "make check" failing on "vdscli.py" missing) > change: edit vdsm_cli/Makefile.am > Revision ddeb9dd8cbf6e814e416c6e75a320b65590c3446 by danken: (BZ# href='http://bugzilla.redhat.com/show_bug.cgi?id=806555'>806555 having > /etc/ovirt-node-* means it is a node) > change: edit vdsm/caps.py checking for pyflakes... no configure: error: pyflakes not found, please install it. Could we please not deploy a slave before it has vdsm's build requirements? I creates a lot of false negative results. ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: As previously what we agreed, the agent-assisted shutdown an...
Dan Kenigsberg has posted comments on this change. Change subject: As previously what we agreed, the agent-assisted shutdown and fsfreeze would be handled by the qemu guest agent while oVirt-specific functionality such as Single-Sign-On would continue to be managed by the ovirt guest agent. .. Patch Set 1: It is better to re-use you change-id when you fix the commit message (or anything else in your commit). now I'll have to ask Gal to review this patch, again. -- To view, visit http://gerrit.ovirt.org/5639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieaa12a050137261d81ed2d813ce08b146534787d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao Gerrit-Reviewer: Gal Hammer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_unit_tests - Build # 222 - Still Failing!
On Thu, Jun 21, 2012 at 04:36:15AM -0400, Jenkins oVirt Server wrote: > > BUILD FAILURE > Build URL: http://jenkins.ovirt.org/job/vdsm_unit_tests/222/ > Project: vdsm_unit_tests > Date of build: Thu, 21 Jun 2012 04:31:35 -0400 > Build duration: 4 min 39 sec > > CHANGE SET > Revision 8d03cb7c11881ba0dedb2b22c7c136c8320611b2 by fsimonce: (Internal > volumes must be RW in domain version href='http://bugzilla.redhat.com/show_bug.cgi?id=3'>3) > change: edit vdsm/storage/fileVolume.py > change: edit vdsm/storage/misc.py > change: edit vdsm/storage/volume.py > change: edit vdsm/storage/hsm.py > change: edit vdsm/storage/blockVolume.py > Revision 4b1810bd728325aec4f38e406aab7a5fe54518e2 by fsimonce: (Move the > SANLock SDM lease to a different offset) > change: edit vdsm/storage/blockVolume.py > change: edit vdsm/storage/safelease.py > Revision d8b33031b4f20538be36f5d11156ea006e6e01e3 by fsimonce: (Add the > hasHostId method to the cluster locks) > change: edit vdsm/storage/sd.py > change: edit vdsm/storage/safelease.py > Revision 558edf6f2850ae37050a5ead87606a0e1d608869 by fsimonce: (Remove the > traceback from the getVSize warning) > change: edit vdsm/storage/blockVolume.py > > > JUNIT RESULTS Error Message No module named sanlock Should we now even add sanlock-python to vdsm BuildRequires? It's is becoming a joke - we'd need all runtime packages in order to test vdsm during its build. ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Re: your mail
On Wed, Jun 20, 2012 at 04:07:28PM -0400, Jenkins oVirt Server wrote: > That's not so informative ;-) ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_unit_tests - Build # 219 - Failure!
On Wed, Jun 20, 2012 at 08:56:57AM -0400, Jenkins oVirt Server wrote: > > BUILD FAILURE > Build URL: http://jenkins.ovirt.org/job/vdsm_unit_tests/219/ > Project: vdsm_unit_tests > Date of build: Wed, 20 Jun 2012 08:56:34 -0400 > Build duration: 22 sec > > CHANGE SET > Revision 0f4ad8a01eb0dcc03ef4633afef2465d5082d6c5 by danken: > (deployUtil.yumFind: rename and simplify semantics) > change: edit vdsm_reg/deployUtil.py.in > Revision af04764b03cdb767e83a773e959ddf2e91c1981e by danken: (drop > deployUtil.yumSearch) > change: edit vdsm_reg/deployUtil.py.in > change: edit vds_bootstrap/vds_bootstrap.py > Revision e1c486f8fc483a36d8b82dcd6464d0966a8e5e8d by danken: > (deployUtil.yumSearchVersion: compare versions sanely) > change: edit vds_bootstrap/vds_bootstrap.py > change: edit vdsm_reg/deployUtil.py.in Could it be that this slave does not have autoconf/autmake installed? + ./autogen.sh --system ./autogen.sh: line 3: autoreconf: command not found ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_unit_tests - Build # 176 - Failure!
On Fri, Jun 01, 2012 at 03:34:25PM +0300, Dan Kenigsberg wrote: > On Fri, Jun 01, 2012 at 05:16:28AM -0400, Laszlo Hornyak wrote: > > Hi, > > > > I ran this test a couple of times but but did not fail. Possibly a random > > error in the test environment? > > > > Yep. dd trying to fsync /dev/null. Someone needs to fix that test. Or > dd. or the kernel. I was not joking. The test uses `dd of=/dev/null`. From time to time, dd calls fsync(2) on its output file. The /dev/null kernel device does not support fsync(2). Something in this chain should be fixed. - I have no idea why fsync(/dev/null) returns EINVLD. I'd expect it to be silently ignored. - dd can be made to avoid fsync on /dev/null - All tests using `dd with /dev/null` can be changed to write to a real temporary file. That's sad, as it wastes real disk space an io cycles, but that's the easiest path. Any takers? > > > - Original Message - > > > From: "Jenkins oVirt Server" > > > To: aba...@redhat.com, dan...@redhat.com, > > > vdsm-patches@lists.fedorahosted.org, lhorn...@redhat.com > > > Sent: Friday, June 1, 2012 10:37:31 AM > > > Subject: [oVirt Jenkins] vdsm_unit_tests - Build # 176 - Failure! > > > > > > > > > > Name: miscTests Failed: 1 test(s), Passed: 63 test(s), Skipped: 0 > > > test(s), Total: 64 test(s) > > > > > > Failed: miscTests.DdWatchCopy.testStop > > > > ___ > vdsm-patches mailing list > vdsm-patches@lists.fedorahosted.org > https://fedorahosted.org/mailman/listinfo/vdsm-patches ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_unit_tests - Build # 176 - Failure!
On Fri, Jun 01, 2012 at 05:16:28AM -0400, Laszlo Hornyak wrote: > Hi, > > I ran this test a couple of times but but did not fail. Possibly a random > error in the test environment? > Yep. dd trying to fsync /dev/null. Someone needs to fix that test. Or dd. or the kernel. > - Original Message - > > From: "Jenkins oVirt Server" > > To: aba...@redhat.com, dan...@redhat.com, > > vdsm-patches@lists.fedorahosted.org, lhorn...@redhat.com > > Sent: Friday, June 1, 2012 10:37:31 AM > > Subject: [oVirt Jenkins] vdsm_unit_tests - Build # 176 - Failure! > > > > > > Name: miscTests Failed: 1 test(s), Passed: 63 test(s), Skipped: 0 > > test(s), Total: 64 test(s) > > > > Failed: miscTests.DdWatchCopy.testStop > > ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_unit_tests - Build # 173 - Failure!
On Wed, May 30, 2012 at 08:26:39AM -0400, Jenkins oVirt Server wrote: > > BUILD FAILURE > Build URL: http://jenkins.ovirt.org/job/vdsm_unit_tests/173/ > Project: vdsm_unit_tests > Date of build: Wed, 30 May 2012 08:20:29 -0400 > Build duration: 6 min 9 sec > > CHANGE SET > Revision bae377258fb4da02517407a7d04e0178369f76cc by nigjones: (BZ# href='http://bugzilla.redhat.com/show_bug.cgi?id=824729'>824729 - Use > doubler param in _loadCorrectedTimeout) > change: edit vdsm/vm.py Saggi, haven't you solved (worked around) this issue elsewhere? Storage.Misc.excCmd: DEBUG: '/bin/nice -n 19 /usr/bin/ionice -c 2 -n 7 /bin/dd if=/dev/zero of=/dev/null bs=64 seek=0 skip=0 conv=notrunc,fdatasync count=1' (cwd None) Storage.Misc.excCmd: DEBUG: FAILED: = ["/bin/dd: fsync failed for `/dev/null': Invalid argument", '1+0 records in', '1+0 records out', '64 bytes (64 B) copied, 0.000129239 s, 495 kB/s']; = 1 Anyway, it is unrelated to Nigel's patch. > > > Name: miscTests Failed: 1 test(s), Passed: 63 test(s), Skipped: 0 test(s), > Total: 64 test(s) > > Failed: miscTests.DdWatchCopy.testStop > ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_unit_tests - Build # 163 - Failure!
On Fri, May 25, 2012 at 03:46:39AM -0400, Jenkins oVirt Server wrote: > > BUILD FAILURE > Build URL: http://jenkins.ovirt.org/job/vdsm_unit_tests/163/ > Project: vdsm_unit_tests > Date of build: Fri, 25 May 2012 03:40:29 -0400 > Build duration: 6 min 10 sec > > CHANGE SET > Revision d707ce49718d7506b3107b8699240322e6a8058c by barumuga: (Added gluster > cli support in supervdsm.) > > Name: main Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 > test(s) > > Failed: main.TestGlusterExceptions.test_collisions > > Name: md_utils_tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 > test(s), Total: 1 test(s) > Timothy, have you tested this during verification? I know that I haven't :-( Either way, please have it fixed as soon as possible. Regards, Dan. ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_unit_tests - Build # 114 - Failure!
Saggi, it seems that On Thu, May 10, 2012 at 07:11:23AM -0400, Jenkins oVirt Server wrote: > > Name: resourceManagerTests Failed: 2 test(s), Passed: 32 test(s), Skipped: 0 > test(s), Total: 34 test(s) > > Failed: resourceManagerTests.ResourceManagerTests.testStressTest > Failed: resourceManagerTests.ResourceManagerTests.testStressTest > has over-stressed the Jenkins server. Could it be that 75% of rlimit_nproc is too much if something else is running on host? Regards, Dan. ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [RFC] vdsm/libvirtvm.py: spice channels: send correct names
On Wed, May 09, 2012 at 09:32:38AM +0300, Alon Levy wrote:
> Old code used to remove the first char unconditionally. This requires a
> hack in the vdsm user (i.e. ovirt engine) to keep sending the leading
> 's', even though upstream spice has stopped using the first char to
> signify secure channel, and passes instead a specific message for that
> purpose. Change the logic to only remove 's' from the specific legacy
> channel names. This will not break old clients that only know about the
> six channels, [main, inputs, display, cursor, playback, record].
>
> Signed-off-by: Alon Levy
Ok... Few minor style comments.
(You do know that we prefer posts to gerrit.ovirt.org?)
> ---
> vdsm/libvirtvm.py |8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
> index 5a4d1bc..df06393 100644
> --- a/vdsm/libvirtvm.py
> +++ b/vdsm/libvirtvm.py
> @@ -778,6 +778,12 @@ class _DomXML:
>
>
> """
> +legacy_s_prefixed_channels = ['smain', 'sinputs', 'sdisplay',
> 'scursor',
> + 'splayback', 'srecord']
CONSTANTS are all caps, and preferably immutable tuple, not list. In
this case, set() would be even better.
> +def plainChannelName(channel):
> +if channel in legacy_s_prefixed_channels:
> +return channel[1:]
> +return channel
> graphics = self.doc.createElement('graphics')
> if self.conf['display'] == 'vnc':
> graphics.setAttribute('type', 'vnc')
> @@ -791,7 +797,7 @@ class _DomXML:
> if self.conf.get('spiceSecureChannels'):
> for channel in self.conf['spiceSecureChannels'].split(','):
> m = self.doc.createElement('channel')
> -m.setAttribute('name', channel[1:])
> +m.setAttribute('name', plainChannelName(channel))
> m.setAttribute('mode', 'secure')
> graphics.appendChild(m)
>
> --
> 1.7.10.1
>
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
Re: add for in hackVdsmModule - taken from Adam Litke
On Tue, Apr 24, 2012 at 03:39:42PM -0400, dan...@redhat.com wrote: > Dan Kenigsberg has posted comments on this change. > > Change subject: add for in hackVdsmModule - taken from Adam Litke > .. > > > Patch Set 1: Looks good to me, but someone else must approve > > (1 inline comment) > > > File tests/testrunner.py > Line 185: mod.vdscli = None > any idea why vdscli is so different? > On Tue, Apr 24, 2012 at 04:38:01PM -0400, a...@us.ibm.com wrote: > Adam Litke has posted comments on this change. > > Change subject: add for in hackVdsmModule - taken from Adam Litke > .. > > > Patch Set 1: Verified; Looks good to me, but someone else must approve > > Code looks good and verified that the test suite runs fine with this change. Adam, would you tell why vdscli is handled so differently? Regards, Dan. ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add missing \ to Makefile.am
Dan Kenigsberg has posted comments on this change. Change subject: Add missing \ to Makefile.am .. Patch Set 1: oops, my bad rebase. thanks for fixing. -- To view, visit http://gerrit.ovirt.org/3598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20a9acf804266fc0e20978150d1b618154c0ff5a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Saggi Mizrahi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix import error when running vdsm tests
Dan Kenigsberg has posted comments on this change. Change subject: Fix import error when running vdsm tests .. Patch Set 1: (1 inline comment) File tests/testrunner.py Line 173: import config If only someone had invented the "loop" concept! -- To view, visit http://gerrit.ovirt.org/3407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9821a0b3f2141b534635194ed2612918959c475 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Saggi Mizrahi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Re: iSER patch for VDSM
On Wed, Mar 07, 2012 at 04:52:49PM +0200, Roi Dayan wrote: > On Wed, Mar 7, 2012 at 4:09 PM, Dan Kenigsberg wrote: > > > On Wed, Mar 07, 2012 at 02:08:57PM +0200, Roi Dayan wrote: > > > Hi > > > > > > I answered inline. > > > > > > Thanks, > > > Roi > > > > > > On Wed, Mar 7, 2012 at 1:33 PM, Dan Kenigsberg > > wrote: > > > > > > > On Wed, Mar 07, 2012 at 09:43:27AM +0200, Roi Dayan wrote: > > > > > ok. > > > > > > > > > > attached patch for getSessionInfo() only. > > > > > > > > Roi, > > > > > > > > It's nice that you've reached agreement with Saggi, but would you > > please > > > > give > > > > the laymen a short description of this patch? It seems unrelated to > > iser. > > > > > > > > > > > > > The patch for getSessionInfo() is to read session info from > > > /sys/class/iscsi_session and /sys/class/iscsi_connection directories > > > if could not be found under /sys/devices/platform/host*/ which is how the > > > function with right now. > > > Actually from a mail from Mike Christie I saw this morning I understood > > > that relaying on the /sys/devices/platform/host*/ directory is not right. > > > Also he gave an example that all offload drivers have pci devs instead of > > > platform so they wont appear in /sys/devices/platform/. > > > > So, you say that a more intrusive patch is needed? Or your current version > > is an > > acceptable step forward? > > > > > yes. we can just skip checking the platform directory since even if a > platform exists for a session > it will exists in /sys/class/iscsi_session/ anyway. > > I also saw now that the function iterateIscsiSessions() also checking > platform to know which sessions > exists. > I edited it to work with /sys/class/iscsi_session/ instead. > > I attached an updated patch with the above. > its actually cleaner after removing the platform directory glob stuff. Ok. I've posted it in http://gerrit.ovirt.org/2628 for you. Please review, ack, comment, there. In the future, if you send a patch to the list, better make it the output of git-format-patches. Otherwise, there's a lot of guesswork left for me. ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Re: iSER patch for VDSM
On Wed, Mar 07, 2012 at 02:08:57PM +0200, Roi Dayan wrote: > Hi > > I answered inline. > > Thanks, > Roi > > On Wed, Mar 7, 2012 at 1:33 PM, Dan Kenigsberg wrote: > > > On Wed, Mar 07, 2012 at 09:43:27AM +0200, Roi Dayan wrote: > > > ok. > > > > > > attached patch for getSessionInfo() only. > > > > Roi, > > > > It's nice that you've reached agreement with Saggi, but would you please > > give > > the laymen a short description of this patch? It seems unrelated to iser. > > > > > The patch for getSessionInfo() is to read session info from > /sys/class/iscsi_session and /sys/class/iscsi_connection directories > if could not be found under /sys/devices/platform/host*/ which is how the > function with right now. > Actually from a mail from Mike Christie I saw this morning I understood > that relaying on the /sys/devices/platform/host*/ directory is not right. > Also he gave an example that all offload drivers have pci devs instead of > platform so they wont appear in /sys/devices/platform/. So, you say that a more intrusive patch is needed? Or your current version is an acceptable step forward? > > > > > > > > Note that you will need the OK of someone in the ovirt management to > > > > approve this API semantic change and it's supportability. I'm just an > > > > annoying developer, I don't have veto powers. > > > > If this is enabled via a config item, it would be easily acceptible. > > > > > Yes. this is from vdsm.conf under [irq] section: > iscsi_transports = iser,tcp > > by default iscsi_transports is tcp only. But this is from your old, obsoleted patch, right? We are going to have a slightly different patch (this time to hsm.py) I think a clearer name would be be iscsi_default_ifaces = default,iser > > > > But please note my unanswered questions: > > > > > > > A casual read of the man page makes we wonder: could a simple > > > > > > > > > > iscsiadm -m discoverydb -t st -p ip:port -I iser --discover > > > > > > > > > > do the trick for discovery? > > > > > Could HeaderDigest mangling be avoided? > > > > > > > > > > BTW, Saggi, does it make sense to have our API accomodate > > > > > discovery/login over multiple interfaces? > > > > iscsi.discoverSendTargets() could accept a *list* of interfaces, so that > > both > > -I iser and -I default are used. > > > > > > The patch doesn't touch HeaderDigest anymore. Changing iface to iser is > enough. Which patch? Is there anything beyond the getSessionInfo patch? > > If we can tell from the start that we want iser target with do do discovery > with iser iface > but then all targets discovered will be set to iser iface. > Discovery is done over tcp so it's not that the result will be iser targets > only. I still do not understand if it is possible/beneficial to use iscsiadm -m discoverydb -t st -p ip:port -I iser -I default --discover in your use case. > > The patch modifies addIscsiNode() which is called after discovery. > If the user wanted iser, according to the config file, we change the iface > to iser. > If login fails we change iface back to "iface.name" which currently is > always default (tcp). that's the old patch, right? when you can, please provide a patch with logic moved to hsm.py. Regards, Dan ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Re: iSER patch for VDSM
On Wed, Mar 07, 2012 at 09:43:27AM +0200, Roi Dayan wrote:
> ok.
>
> attached patch for getSessionInfo() only.
Roi,
It's nice that you've reached agreement with Saggi, but would you please give
the laymen a short description of this patch? It seems unrelated to iser.
>
> thanks,
> Roi
>
> On Wed, Mar 7, 2012 at 12:23 AM, Saggi Mizrahi wrote:
>
> > Hi, first of all I'm truly sorry about sending you all back and forth and
> > you have been most patient.
> >
> > Secondly I would like you to split your patch to 2 parts.
> > The getSessionInfo() changes are good and I would have ACKed them if they
> > where posted on their own.
> >
> > Again, discovery will use the interface passed in iface. There is no need
> > to do all the looping and there is no need for the config values. Accepting
> > your patch means that the transport in the interface given in the parameter
> > is ignored.
> >
> > I do know that there is no way to currently select iser in the UI and
> > backend.
> > This, although unfortunate, does not mean we need to start hacking things
> > in to VDSM.
> > My problem with accepting this change is that it is now supported by VDSMs
> > interface.
> > This will make things hard for us to support in the future.
> >
> > I completely sympathize with your strong will to not start poking in the
> > Engine and UI.
> >
> > In any case, there is a way I can meet you half way. I would rather it'd
> > be fixed properly but I do get that time constraints might force us to fix
> > this in a less than optimal manner.
> >
> > The fix as I see it:
> > In HSM when there is no initiator name passed, hsm will not only try
> > iface('default') but also iface('iser').
> > Doing it this way will mean that the fallback is only supported by the old
> > API and is implemented at the API level and not the iscsi abstraction layer.
> > I would have done it myself and sent the patch if I had a set up to test
> > it in.
> >
> > Note that you will need the OK of someone in the ovirt management to
> > approve this API semantic change and it's supportability. I'm just an
> > annoying developer, I don't have veto powers.
If this is enabled via a config item, it would be easily acceptible.
But please note my unanswered questions:
> > > A casual read of the man page makes we wonder: could a simple
> > >
> > > iscsiadm -m discoverydb -t st -p ip:port -I iser --discover
> > >
> > > do the trick for discovery?
> > > Could HeaderDigest mangling be avoided?
> > >
> > > BTW, Saggi, does it make sense to have our API accomodate
> > > discovery/login over multiple interfaces?
iscsi.discoverSendTargets() could accept a *list* of interfaces, so that both
-I iser and -I default are used.
Dan
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
Re: iSER patch for VDSM
On Mon, Mar 05, 2012 at 04:30:26PM +, Roi Dayan wrote: > Hi, > > With "the new code supports iser" do you mean the iface iser in iscsiadm? > I want to use, I don’t want to create a new one. > I did a fallback since I don’t have in the gui anywhere to choose between > iser and iscsi. > Now I see it doesn't help me anyway since if I want to use the iser iface in > iscsiadm, > I need to set this iface when doing discovery since it can't be changed later > with op update. > > With a talk with Ayal Baron I was told I can currently submit the patch to > vdsm-patches without gerrit > And to have a fixme comment about the fallback (which doesn't really help > right now since I need discovery anyway). > > From you're answer I understand it is possible to choose iser iface from the > gui? > How I do that? > I only have fields for ip,port,chap. I'm afraid you cannot. I'll try to explain Saggi's text, hopefully without introducing mistakes of my own: Vdsm's connectStorageServer accpets a parameter named initiatorName, which is abused and passed as-is to iscsiadm's -I argument. This can be abused in order to pass the special "iser" interface to iscsiadm. HOWEVER, I don't think that initiatorName has ever been used by ovirt Engine. Since I have very little knowledge of iscsiadm (and when it comes to iser even less), maybe you would agree to give me a more detailed explanation of your patch. A casual read of the man page makes we wonder: could a simple iscsiadm -m discoverydb -t st -p ip:port -I iser --discover do the trick for discovery? Could HeaderDigest mangling be avoided? BTW, Saggi, does it make sense to have our API accomodate discovery/login over multiple interfaces? Regards, Dan. ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [PATCH] iscsi.py: fixed discovery issue and added support for iSER transport
On Sun, Dec 18, 2011 at 02:57:07PM +, Roi Dayan wrote: > Yes we are blocked to external unknown ports. > Anything else we can do? 1. Teach your IT department about Gerrit and make them know about its port. 2. Push your commits from home, or any other place with less draconic firewall rules (try China). 3. Ask your friendly project maintainer to push the patch for you. Note that (3) does not scale, and may lead to maintainers becoming less friendly. Dan. ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [PATCH] iscsi.py: fixed discovery issue and added support for iSER transport
On Wed, Dec 14, 2011 at 03:02:06PM +, Roi Dayan wrote: > I'm failing to setup gerrit with the insructions provided. > > This is what I have in .git/config: > > [remote "gerrit"] > url = http://gerrit.ovirt.org/p/vdsm > pushurl = ssh://r...@gerrit.ovirt.org:29418/vdsm.git > fetch = +refs/heads/*:refs/remotes/gerrit/* > > but git-review -s saying connection refused. > > Port 29418 doesn't seem to be open. Could the problem lie on your side (company firewall maybe?) I get a nice response: $ nc gerrit.ovirt.org 29418 SSH-2.0-GerritCodeReview_2.2.1 (SSHD-CORE-0.5.1-R1095809) ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [PATCH] iscsi.py: fixed discovery issue and added support for iSER transport
On Mon, Dec 12, 2011 at 03:52:57PM +, Roi Dayan wrote: > Never got to http://gerrit.ovirt.org from the prev link you gave us. > So we never saw 'register' link just the message: > > 'You cannot create your own account, you must ask any other account holder to > do it for you. We are protecting this wiki from spambots and bad actors > through self-management. This includes the creation of new accounts. > If you need an account, contact one of the existing account holders, who are > fellow participants and contributors. > > Discover of new targets is tcp. > After detecting the targets, a user needs to know if a specific target > transport is iser or tcp and update the iface.transport_name accordingly. I'd expect iscsiadm's --login command to let you select the transport. It is not very safe to set the transport in one command, have a window where vdsm can die, and login later. If Vdsm actually die, host will be left with an uninteded transport. > > What config parameter do you suggest? > In /etc/vdsm.conf ? like unser [vars] so put transport=tcp,iser | iser,tcp | > tcp | iser ? yeah, though storage-related vars sit under [irs] (don't ask why), and I think iscsi_transports is a clearer name. Dan. ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [PATCH] iscsi.py: fixed discovery issue and added support for iSER transport
On Mon, Dec 12, 2011 at 02:41:34PM +, Roi Dayan wrote: > Same patch, beside fix to discover command. > I addressed to the last review and that’s why I mailed it here. > About the race. The gui doesn't let you choose between iser or tcp. > So we first try iser and then tcp. I understand why you do it, but I think the solution is wrong. Is it possible to ask iscsiadm to use iser only during a specific call? Why does there need to be a node state holding the used transport? I think it makes a lot of sense to have one host using both tcp and iser in tandem. If this is currently impossible in iscsiadm, someone has to patch it... Anyway, it is "not fair" to force the default Vdsm user, who never had iser, to first try to discover over iser and fail. Please make the transports that are used a configurational parameter. By default it could be just tcp; people with both tcp and iser could set it to a list tcp,iser. > > I can't use gerrit without and account. > I can't create an account, says on the page someone with an account should > create one for me. I don't understand your error flow. You browse to gerrit.ovirt.org, click Register. What happens next? > On irc #vdsm I was forwarded to #ovirt for help but chanserv always kicks me > out of the channel > with the reason that I'm not authorized to join there. Could it be that you've used the wrong irc server? > > Roi > ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [PATCH] iscsi.py: fixed discovery issue and added support for iSER transport
On Thu, Dec 08, 2011 at 12:41:10PM +0200, Roi Dayan wrote:
> Fixed discovery of targets not to overwrite settings of already
> connected targets.
> Added support for iSER transport.
Roi, what is the difference from your previous patch?
Have you addressed all the former comments? It seems that at least two (race
between setting node transport to using it, trying iser on hosts that did not
opt for it) are just as problematic as in the former patch.
It would be easier for us to review your patch if you send it via
gerrit.ovirt.org (see http://www.ovirt.org/wiki/Working_with_oVirt_Gerrit for
explanations)
Regards,
Dan.
> ---
> vdsm/storage/iscsi.py | 44 +++-
> 1 files changed, 39 insertions(+), 5 deletions(-)
>
> diff --git a/vdsm/storage/iscsi.py b/vdsm/storage/iscsi.py
> index d2a5bdd..b5ccbd9 100644
> --- a/vdsm/storage/iscsi.py
> +++ b/vdsm/storage/iscsi.py
> @@ -34,7 +34,7 @@ import misc
> import storage_exception as se
> import devicemapper
>
> -SENDTARGETS_DISCOVERY = [constants.EXT_ISCSIADM, "-m", "discoverydb", "-t",
> "sendtargets"]
> +SENDTARGETS_DISCOVERY = [constants.EXT_ISCSIADM, "-m", "discoverydb", "-t",
> "sendtargets", "-o", "new", "-o", "delete"]
> ISCSIADM_NODE = [constants.EXT_ISCSIADM, "-m", "node"]
> ISCSIADM_IFACE = [constants.EXT_ISCSIADM, "-m", "iface"]
> ISCSI_DEFAULT_PORT = "3260"
> @@ -248,14 +248,26 @@ def addiSCSINode(ip, port, iqn, tpgt, initiator,
> username=None, password=None):
> rc = misc.execCmd(cmd + [password], printable=cmd +
> ["**"])[0]
> if rc != 0:
> raise se.SetiSCSIPasswdError(portal)
> +
>
> # Finally instruct the iscsi initiator to login to the target
> +# Since currently its not possible to choose transport from RHEV
> +# we try iSER transport first since its faster and if it fails we
> +# will try iSCSI tranport
> +setNodeTransport(portal, iqn, 'iser')
> cmd = cmdt + ["-l", "-p", portal]
> rc = misc.execCmd(cmd)[0]
> -if rc == ISCSI_ERR_LOGIN_AUTH_FAILED:
> -raise se.iSCSILoginAuthError(portal)
> -elif rc not in (0, ISCSI_ERR_SESS_EXISTS):
> -raise se.iSCSILoginError(portal)
> +
> + if rc == ISCSI_ERR_LOGIN_AUTH_FAILED:
> + raise se.iSCSILoginAuthError(portal)
> + elif rc not in (0, ISCSI_ERR_SESS_EXISTS):
> + setNodeTransport(portal, iqn, 'tcp')
> + rc = misc.execCmd(cmd)[0]
> +
> +if rc == ISCSI_ERR_LOGIN_AUTH_FAILED:
> +raise se.iSCSILoginAuthError(portal)
> +elif rc not in (0, ISCSI_ERR_SESS_EXISTS):
> +raise se.iSCSILoginError(portal)
>
> except se.StorageException:
> exc_class, exc, tb = sys.exc_info()
> @@ -329,6 +341,28 @@ def getiScsiSession(dev):
> session = os.path.basename(sessiondir)
> return session
>
> +def setNodeTransport(portal, iqn, transport='tcp'):
> +"""
> +Configure a node transport
> +transport :tcp, iser
> +"""
> +if transport not in ['tcp', 'iser']:
> +transport = 'tcp'
> +
> +log.info('Set transport %s to target %s on portal %s' % (transport, iqn,
> portal))
> +
> +params = [
> +['node.conn[0].iscsi.HeaderDigest', 'None'],
> +['iface.transport_name', transport]
> +]
> +
> +cmdt = [constants.EXT_ISCSIADM, '-m', 'node', '-o', 'update', '-p',
> portal, '-T', iqn]
> +for param in params:
> +cmd = cmdt + ['-n', param[0], '-v', param[1]]
> +rc = misc.execCmd(cmd)[0]
> +if rc not in (0, ISCSI_ERR_SESS_EXISTS):
> +raise se.iSCSILoginError(portal)
> +
> def getdeviSCSIinfo(dev):
> """
> Reports the iSCSI parameters of the given device 'dev'
> --
> 1.7.1
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
[ABANDONED PATCH] expose qemu monitorCommand (via gerrit-bot)
Patch was abandoned by Dan Kenigsberg (dan...@redhat.com) because: Igor convinced me that we have no real benefit from re-introducing this API. I've mentioned that upstream: https://fedorahosted.org/pipermail/vdsm-devel/2011-December/000348.html You can review this change at: http://gerrit.usersys.redhat.com/1013 ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
[ABANDONED PATCH] [WIP] fix faqemu for fedora host (via gerrit-bot)
Patch was abandoned by Dan Kenigsberg (dan...@redhat.com) because: tracked upstream http://gerrit.ovirt.org/324 You can review this change at: http://gerrit.usersys.redhat.com/1089 ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix __cleanupStoragePool()
Dan Kenigsberg has posted comments on this change. Change subject: Fix __cleanupStoragePool() .. Patch Set 3: gosh, this bug in calling detachSD is old! introduced while solving bug 549740 -- To view, visit http://gerrit.ovirt.org/188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ff24dde33e5a73fab4ab3c848d18071643af3a8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Saggi Mizrahi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
[ABANDONED PATCH] init.d/vdsmd: look for initctl where it is expected (via gerrit-bot)
Patch was abandoned by Dan Kenigsberg (dan...@redhat.com) because: would be tracked upstream http://gerrit.ovirt.org/198 You can review this change at: http://gerrit.usersys.redhat.com/1124 ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
[MERGED PATCH] BZ#746766 deployUtil: restorecon on created ~/.ssh/ dir (via gerrit-bot)
Patch merged into repository You can review this change at: http://gerrit.usersys.redhat.com/1100 ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
[MERGED PATCH] BZ#749151 revive Vm ticket just before migration (via gerrit-bot)
Patch merged into repository You can review this change at: http://gerrit.usersys.redhat.com/1086 ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
[MERGED PATCH] BZ#733000 vdsmd: upstart hates soflinks (via gerrit-bot)
Patch merged into repository You can review this change at: http://gerrit.usersys.redhat.com/1062 ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
[MERGED PATCH] BZ#748466 bootstrap: report vendor properly (via gerrit-bot)
Patch merged into repository You can review this change at: http://gerrit.usersys.redhat.com/1060 ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
[MERGED PATCH] BZ#746766 BZ#747337: bootstrap: download selinux module before usage (via gerrit-bot)
Patch merged into repository You can review this change at: http://gerrit.usersys.redhat.com/1047 ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
[ABANDONED PATCH] BZ#744755 daemonize HSM_MailMonitor thread (via gerrit-bot)
Patch was abandoned by Dan Kenigsberg (dan...@redhat.com) because: I prefer that the issue is tracked by Federico's http://gerrit.usersys.redhat.com/1049 You can review this change at: http://gerrit.usersys.redhat.com/1036 ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
[MERGED PATCH] BZ#748222 netinfo: report operstate, not adminstate (via gerrit-bot)
Patch merged into repository You can review this change at: http://gerrit.usersys.redhat.com/1057 ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
