Change in vdsm[ovirt-3.5-gluster]: gluster: Added VDSM verb to stop gluster related processes
Bala.FA has submitted this change and it was merged. Change subject: gluster: Added VDSM verb to stop gluster related processes .. gluster: Added VDSM verb to stop gluster related processes Added a verb which stops the gluster related process like brick processes, gsyncd process. This needs to be done as part of a host moving to maintenance mode. as data should not be available if a host is moved to maintenence mode for some migration etc. Change-Id: Id686e098b323eededcf1f89de331a1d524274995 Bug-URL: https://bugzilla.redhat.com/1189285 Signed-off-by: Shubhendu Tripathi Reviewed-on: https://gerrit.ovirt.org/43821 Tested-by: Ramesh N Continuous-Integration: Jenkins CI Reviewed-by: Bala.FA Reviewed-by: Piotr Kliczewski Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/48449 Continuous-Integration: Bala.FA --- M client/vdsClientGluster.py M vdsm/gluster/api.py M vdsm/gluster/apiwrapper.py M vdsm/gluster/exception.py M vdsm/rpc/vdsmapi-gluster-schema.json 5 files changed, 45 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Bala.FA: Looks good to me, approved; Passed CI tests Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/48449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Ramesh N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: Added VDSM verb to stop gluster related processes
Bala.FA has posted comments on this change. Change subject: gluster: Added VDSM verb to stop gluster related processes .. Patch Set 2: -Verified -- To view, visit https://gerrit.ovirt.org/48449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Ramesh N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: Added VDSM verb to stop gluster related processes
Bala.FA has posted comments on this change. Change subject: gluster: Added VDSM verb to stop gluster related processes .. Patch Set 2: Code-Review+2 Continuous-Integration+1 Verified+1 -- To view, visit https://gerrit.ovirt.org/48449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Ramesh N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes
Bala.FA has posted comments on this change. Change subject: gluster: Added VDSM verb to stop gluster related processes .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan Narayana Murthy Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes
Bala.FA has posted comments on this change. Change subject: gluster: Added VDSM verb to stop gluster related processes .. Patch Set 6: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/43821/6/vdsm/gluster/exception.py File vdsm/gluster/exception.py: Line 106: GlusterStopProcessesFailedException Please change the name to GlusterProcessesStopFailedException() -- To view, visit https://gerrit.ovirt.org/43821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan Narayana Murthy Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes
Bala.FA has posted comments on this change. Change subject: gluster: Added VDSM verb to stop gluster related processes .. Patch Set 4: Code-Review-1 (1 comment) Please make yourself to -1 till the dependency patch gets merged in glusterfs. https://gerrit.ovirt.org/#/c/43821/4/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 771: stopProcesses(sel Please change the name as ProcessesStop to be consistent with other verbs. You should change it everywhere. Sorry for the late review on this. -- To view, visit https://gerrit.ovirt.org/43821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan Narayana Murthy Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes
Bala.FA has posted comments on this change. Change subject: gluster: Added VDSM verb to stop gluster related processes .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/43821/3/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 53: ) Line 54: Line 55: _stopAllProcessesPath = utils.CommandPath( Line 56: "stop-all-gluster-processes.sh", Line 57: "/usr/share/glusterfs/scripts/stop-all-gluster-processes.sh", > The patch https://review.gluster.org/#/c/11739/ is already acked and can be You could check with gluster team about the location of the script for various platform and how to resolve that. Line 58: ) Line 59: Line 60: Line 61: GLUSTER_RPM_PACKAGES = ( Line 276: _stopAllProcessesPath > I am not sure why it has execute permission in RHEL7 and Fedora but not in May be a bug. You should check with glusterfs team. -- To view, visit https://gerrit.ovirt.org/43821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan Narayana Murthy Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes
Bala.FA has posted comments on this change. Change subject: gluster: Added VDSM verb to stop gluster related processes .. Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/43821/3/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 53: ) Line 54: Line 55: _stopAllProcessesPath = utils.CommandPath( Line 56: "stop-all-gluster-processes.sh", Line 57: "/usr/share/glusterfs/scripts/stop-all-gluster-processes.sh", > I think so. But may be we should verify with gluster team as well. Please confirm this. Line 58: ) Line 59: Line 60: Line 61: GLUSTER_RPM_PACKAGES = ( Line 276: _stopAllProcessesPath Is there any reason why the script is not set with execute permission? https://gerrit.ovirt.org/#/c/43821/3/vdsm/gluster/exception.py File vdsm/gluster/exception.py: Line 607: GlusterStopProcessesFailedException You should move it to gluster general -- To view, visit https://gerrit.ovirt.org/43821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan Narayana Murthy Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added VDSM verb to stop gluster related processes
Bala.FA has posted comments on this change. Change subject: gluster: Added VDSM verb to stop gluster related processes .. Patch Set 3: Code-Review-1 As this patch depends on https://review.gluster.org/#/c/11739/, set -1 till that patch gets merged. -- To view, visit https://gerrit.ovirt.org/43821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan Narayana Murthy Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix brick devices are created with incorrect data a...
Bala.FA has posted comments on this change. Change subject: gluster: fix brick devices are created with incorrect data alignment .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/47959/2//COMMIT_MSG Commit Message: Line 10: device If there is no partition on the disk, how do we know a disk has filesystem in it? Does blivet provide such information? -- To view, visit https://gerrit.ovirt.org/47959 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Manoj Pillai Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: fix TypeError in exception.py
Bala.FA has posted comments on this change. Change subject: gluster: fix TypeError in exception.py .. Patch Set 3: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/45277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a0622baf0e2fcba810f9ef3e36a1ea8b95b61c4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: fix TypeError in exception.py
Bala.FA has submitted this change and it was merged.
Change subject: gluster: fix TypeError in exception.py
..
gluster: fix TypeError in exception.py
Currently gluster cli functions throws error in exception due to a bug
in python multiprocess http://bugs.python.org/issue15440 which fails
to re-raise in supervdsm side. This is workaround fix to set optional
arguments to constructor of VdsmException and GlusterException
Traceback (most recent call last):
File "/usr/share/vdsm/rpc/BindingXMLRPC.py", line 1136, in wrapper
res = f(*args, **kwargs)
File "/usr/share/vdsm/gluster/api.py", line 80, in wrapper
rv = func(*args, **kwargs)
File "/usr/share/vdsm/gluster/api.py", line 686, in createBrick
raidParams)
File "/usr/share/vdsm/supervdsm.py", line 50, in __call__
return callMethod()
File "/usr/share/vdsm/supervdsm.py", line 48, in
**kwargs)
File "", line 2, in glusterCreateBrick
File "/usr/lib64/python2.6/multiprocessing/managers.py", line 726, in
_callmethod
kind, result = conn.recv()
TypeError: ('__init__() takes exactly 2 arguments (1 given)',
, ())
Change-Id: I9a0622baf0e2fcba810f9ef3e36a1ea8b95b61c4
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1231722
Signed-off-by: Timothy Asir Jeyasingh
Reviewed-on: https://gerrit.ovirt.org/45001
Reviewed-by: Ramesh N
Reviewed-by: Dan Kenigsberg
Continuous-Integration: Dan Kenigsberg
Signed-off-by: Timothy Asir Jeyasingh
Reviewed-on: https://gerrit.ovirt.org/45277
Reviewed-by: Bala.FA
Continuous-Integration: Bala.FA
---
M vdsm/gluster/exception.py
1 file changed, 14 insertions(+), 12 deletions(-)
Approvals:
Timothy Asir: Verified
Bala.FA: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45277
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a0622baf0e2fcba810f9ef3e36a1ea8b95b61c4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Timothy Asir
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ramesh N
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: Timothy Asir
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: fix AttributeError in exception.py
Bala.FA has submitted this change and it was merged. Change subject: gluster: fix AttributeError in exception.py .. gluster: fix AttributeError in exception.py Currently whenever an exception raised with extra arguments apart from rc, out, err; the exception failed with AttributeError due to base class member variables are not initialized properly. This patch fixes this AttributeError issue by calling the ancestor's __init__ method explicitly to invoke base class constructor which will initialize the base class member variables like rc, out and err. Change-Id: Ic4c72daf30aee8f0024b1ef9ee064a205a500620 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1231722 Signed-off-by: Timothy Asir Jeyasingh Reviewed-on: https://gerrit.ovirt.org/41530 Reviewed-by: Francesco Romani Reviewed-by: Ramesh N Reviewed-by: Dan Kenigsberg Continuous-Integration: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/45276 Reviewed-by: Bala.FA Continuous-Integration: Bala.FA --- M vdsm/gluster/exception.py 1 file changed, 17 insertions(+), 9 deletions(-) Approvals: Timothy Asir: Verified Bala.FA: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45276 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4c72daf30aee8f0024b1ef9ee064a205a500620 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: fix AttributeError in exception.py
Bala.FA has posted comments on this change. Change subject: gluster: fix AttributeError in exception.py .. Patch Set 4: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/45276 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4c72daf30aee8f0024b1ef9ee064a205a500620 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: fix TypeError in exception.py
Bala.FA has posted comments on this change. Change subject: gluster: fix TypeError in exception.py .. Patch Set 2: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/45277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a0622baf0e2fcba810f9ef3e36a1ea8b95b61c4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: fix AttributeError in exception.py
Bala.FA has posted comments on this change. Change subject: gluster: fix AttributeError in exception.py .. Patch Set 3: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/45276 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4c72daf30aee8f0024b1ef9ee064a205a500620 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: create pv with custom dataalignment value
Bala.FA has submitted this change and it was merged. Change subject: gluster: create pv with custom dataalignment value .. gluster: create pv with custom dataalignment value Blivet creates pv with 1mb dataalignment forcefully for whatever given value. This patch uses lvm pvcreate command till this bug fixed in blivet. Change-Id: I5eb58f81679729af4d3dc34bc9f7edba757acc67 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1225831 Signed-off-by: Timothy Asir Jeyasingh Reviewed-on: https://gerrit.ovirt.org/42782 Continuous-Integration: Jenkins CI Reviewed-by: Bala.FA Reviewed-by: Nir Soffer Reviewed-by: Piotr Kliczewski Reviewed-by: Dan Kenigsberg Signed-off-by: Timothy Asir Jeyasingh Reviewed-on: https://gerrit.ovirt.org/45278 Continuous-Integration: Bala.FA --- M vdsm/gluster/storagedev.py 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Timothy Asir: Verified Bala.FA: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45278 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5eb58f81679729af4d3dc34bc9f7edba757acc67 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: create pv with custom dataalignment value
Bala.FA has posted comments on this change. Change subject: gluster: create pv with custom dataalignment value .. Patch Set 1: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/45278 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5eb58f81679729af4d3dc34bc9f7edba757acc67 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: fix xfs filesystem is created with wrong inode size
Bala.FA has submitted this change and it was merged. Change subject: gluster: fix xfs filesystem is created with wrong inode size .. gluster: fix xfs filesystem is created with wrong inode size Currently brick create function creates an xfs filesystem with inode size of 256 for brick which uses raid0 or JBOD devices. This patch uses the striping parameters "-d su=stripe_unit_size, sw=stripe_width_in_number_of_disks" during xfs file system create for RAID6. For RAID 10, JBOD and other devices it omits the "-d su=<>,sw=<>" option and set only the inode size to 512 and the directory block size to 8192. Change-Id: If3f350d2f79172705a93a9d69fe1b7b78867861e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1244865 Signed-off-by: Timothy Asir Jeyasingh Reviewed-on: https://gerrit.ovirt.org/43847 Reviewed-by: Bala.FA Reviewed-by: Manoj Pillai Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg (cherry picked from commit d6f46a0095e381d1ea9e2dd10cea30bcaf64ce3d) Reviewed-on: https://gerrit.ovirt.org/45299 Continuous-Integration: Bala.FA --- M vdsm/gluster/storagedev.py 1 file changed, 15 insertions(+), 5 deletions(-) Approvals: Timothy Asir: Verified Bala.FA: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45299 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3f350d2f79172705a93a9d69fe1b7b78867861e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: fix xfs filesystem is created with wrong inode size
Bala.FA has posted comments on this change. Change subject: gluster: fix xfs filesystem is created with wrong inode size .. Patch Set 1: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/45299 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3f350d2f79172705a93a9d69fe1b7b78867861e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Publish gluster get volume info
Bala.FA has posted comments on this change. Change subject: gluster: Publish gluster get volume info .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c70e9afa2fd776dfd9c2767c2e83e7f179b5c2 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Darshan Narayana Murthy Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:cleanup: Remove unnecessary wrapper
Bala.FA has posted comments on this change. Change subject: gluster:cleanup: Remove unnecessary wrapper .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ff1b4f785f453a6fbf1660949db779712d88758 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix xfs filesystem is created with wrong inode size
Bala.FA has posted comments on this change. Change subject: gluster: fix xfs filesystem is created with wrong inode size .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43847 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3f350d2f79172705a93a9d69fe1b7b78867861e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan Narayana Murthy Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix xfs filesystem is created with wrong inode size
Bala.FA has posted comments on this change.
Change subject: gluster: fix xfs filesystem is created with wrong inode size
..
Patch Set 4: Code-Review-1
(1 comment)
is any test case update required?
https://gerrit.ovirt.org/#/c/43847/4/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:
Line 329: =
How about rewriting this if block as
format._defaultFormatOptions = ["-f", "-i", "size=512", "-n", "size=8192"]
if raidParams.get('type') == '6':
format._defaultFormatOptions += [ "-d", "sw=%s,su=%sk" % (count,
raidParams.get('stripeSize'))]
?
--
To view, visit https://gerrit.ovirt.org/43847
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3f350d2f79172705a93a9d69fe1b7b78867861e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Darshan Narayana Murthy
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: Shubhendu Tripathi
Gerrit-Reviewer: Timothy Asir
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: handle an unhandled exception in gfapi.py
Bala.FA has posted comments on this change. Change subject: gluster: handle an unhandled exception in gfapi.py .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43670 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I222345801e8d33ef17f0ae5ca66b1d34fa80d95b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: rename glusterCreateBrick to glusterBrickCreate
Hello Piotr Kliczewski, Timothy Asir, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/43263
to review the following change.
Change subject: gluster: rename glusterCreateBrick to glusterBrickCreate
..
gluster: rename glusterCreateBrick to glusterBrickCreate
To make consistency in function names in supervdsm and verb names in
vdsm, this patch renames verb glusterCreateBrick to glusterBrickCreate
Change-Id: I367a864bc9bf4aa9b6a0d36b64f541fa89c61c0d
Signed-off-by: Bala.FA
---
M client/vdsClientGluster.py
M vdsm/gluster/api.py
M vdsm/gluster/apiwrapper.py
M vdsm/gluster/storagedev.py
M vdsm/rpc/vdsmapi-gluster-schema.json
5 files changed, 11 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/43263/1
diff --git a/client/vdsClientGluster.py b/client/vdsClientGluster.py
index a4bce63..76b91e1 100644
--- a/client/vdsClientGluster.py
+++ b/client/vdsClientGluster.py
@@ -633,7 +633,7 @@
pp.pprint(status)
return status['status']['code'], status['status']['message']
-def do_glusterCreateBrick(self, args):
+def do_glusterBrickCreate(self, args):
params = self._eqSplit(args)
devList = params.get('devices', '').split(',')
brickName = params.get('brickName', '')
@@ -646,7 +646,7 @@
raidParams['stripeSize'] = int(params.get('stripeSize', 0))
raidParams['pdCount'] = int(params.get('pdCount', 0))
-status = self.s.glusterCreateBrick(brickName, mountPoint,
+status = self.s.glusterBrickCreate(brickName, mountPoint,
devList, fsType, raidParams)
pp.pprint(status)
return status['status']['code'], status['status']['message']
@@ -1172,8 +1172,8 @@
('[volumeName=]',
'snapshot list for given volume'
)),
- 'glusterCreateBrick': (
- serv.do_glusterCreateBrick,
+ 'glusterBrickCreate': (
+ serv.do_glusterBrickCreate,
('brickName= mountPoint= '
'devices= '
'[raidType=] [stripeSize=] '
diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py
index 0c5829f..361e0c5 100644
--- a/vdsm/gluster/api.py
+++ b/vdsm/gluster/api.py
@@ -677,9 +677,9 @@
return {'snapshotList': status}
@exportAsVerb
-def createBrick(self, name, mountPoint, devList, fsType=None,
+def brickCreate(self, name, mountPoint, devList, fsType=None,
raidParams={}, options=None):
-status = self.svdsmProxy.glusterCreateBrick(name,
+status = self.svdsmProxy.glusterBrickCreate(name,
mountPoint,
devList,
fsType,
diff --git a/vdsm/gluster/apiwrapper.py b/vdsm/gluster/apiwrapper.py
index 4768a86..f607dd4 100644
--- a/vdsm/gluster/apiwrapper.py
+++ b/vdsm/gluster/apiwrapper.py
@@ -81,9 +81,9 @@
def storageDevicesList(self, options=None):
return self._gluster.storageDevicesList()
-def createBrick(self, name, mountPoint, devList, fsType=None,
+def brickCreate(self, name, mountPoint, devList, fsType=None,
raidParams={}):
-return self._gluster.createBrick(name, mountPoint,
+return self._gluster.brickCreate(name, mountPoint,
devList, fsType, raidParams)
diff --git a/vdsm/gluster/storagedev.py b/vdsm/gluster/storagedev.py
index eb8b103..4fffef8 100644
--- a/vdsm/gluster/storagedev.py
+++ b/vdsm/gluster/storagedev.py
@@ -129,7 +129,7 @@
@makePublic
-def createBrick(brickName, mountPoint, devNameList, fsType=DEFAULT_FS_TYPE,
+def brickCreate(brickName, mountPoint, devNameList, fsType=DEFAULT_FS_TYPE,
raidParams={}):
def _getDeviceList(devNameList):
return [blivetEnv.devicetree.getDeviceByName(devName.split("/")[-1])
diff --git a/vdsm/rpc/vdsmapi-gluster-schema.json
b/vdsm/rpc/vdsmapi-gluster-schema.json
index d83344c..51dd699 100644
--- a/vdsm/rpc/vdsmapi-gluster-schema.json
+++ b/vdsm/rpc/vdsmapi-gluster-schema.json
@@ -1271,7 +1271,7 @@
'data': {'type': 'str', 'stripeSize': 'int', 'diskCnt': 'int'}}
##
-# @GlusterHost.createBrick:
+# @GlusterHost.brickCreate:
#
# Create a brick for the gluster volume
#
@@ -1290,7 +1290,7 @@
#
# Since: 4.17.0
##
-{'command': {'class': 'GlusterHost', 'name': 'createBrick'},
+{'command': {'class': 'GlusterHost', 'name': 'brickCreate'},
'data': {'name': 'str', 'mountPoint': 'str', 'devList': ['str'],
'*fsType': 'str', '*raidParams': 'RaidDevice'},
'returns': 'bool'}
--
To view, visit https://gerrit.ovirt.org/43263
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I367a864bc9bf4aa9b6
Change in vdsm[master]: gluster: create pv with custom dataalignment value
Bala.FA has posted comments on this change. Change subject: gluster: create pv with custom dataalignment value .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5eb58f81679729af4d3dc34bc9f7edba757acc67 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: disable truncating diff in assert error messages
Bala.FA has posted comments on this change. Change subject: tests: disable truncating diff in assert error messages .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42902 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70efdc56e7638ebe363453f1df4d3a520ab44f2e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Mooli Tayer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: run restorecon for files created during geo-rep cre...
Bala.FA has submitted this change and it was merged. Change subject: gluster: run restorecon for files created during geo-rep create. .. gluster: run restorecon for files created during geo-rep create. This patch runs restorecon on ssh directory and authorized_keys file if they are created as part of geoRepKeysUpdate verb. This is used by geo replication feature. When selinux is enabled, without this fix ssh between master and slave nodes fail. Change-Id: I23a9bb5dfd2e22f91a796635a3192ca617b69632 Bug-Url:https://bugzilla.redhat.com/show_bug.cgi?id=1230353 Signed-off-by: Darshan N Reviewed-on: https://gerrit.ovirt.org/42804 Continuous-Integration: Jenkins CI Reviewed-by: Bala.FA Reviewed-by: Piotr Kliczewski Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/42913 Continuous-Integration: Bala.FA --- M vdsm/gluster/api.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Bala.FA: Looks good to me, approved; Passed CI tests Darshan N: Verified -- To view, visit https://gerrit.ovirt.org/42913 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23a9bb5dfd2e22f91a796635a3192ca617b69632 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: run restorecon for files created during geo-rep cre...
Bala.FA has posted comments on this change. Change subject: gluster: run restorecon for files created during geo-rep create. .. Patch Set 1: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/42913 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23a9bb5dfd2e22f91a796635a3192ca617b69632 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: create pv with custom dataalignment value
Bala.FA has posted comments on this change. Change subject: gluster: create pv with custom dataalignment value .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5eb58f81679729af4d3dc34bc9f7edba757acc67 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: run restorecon for files created during geo-rep cre...
Bala.FA has posted comments on this change. Change subject: gluster: run restorecon for files created during geo-rep create. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42804 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23a9bb5dfd2e22f91a796635a3192ca617b69632 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: create pv with custom dataalignment value
Bala.FA has posted comments on this change. Change subject: gluster: create pv with custom dataalignment value .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/42782/1//COMMIT_MSG Commit Message: Line 14: cgi we should finalize on the bz before taking this workaround. I see this patch as workaround (blivet) of workaround (vdsm.lvm) -- To view, visit https://gerrit.ovirt.org/42782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5eb58f81679729af4d3dc34bc9f7edba757acc67 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Remove Vdsm's dependency on glusterfs-server pkg
Bala.FA has posted comments on this change. Change subject: gluster: Remove Vdsm's dependency on glusterfs-server pkg .. Patch Set 12: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43c8f16e8171693d1bbbff40198c59646022603e Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Remove Vdsm's dependency on glusterfs-server pkg
Bala.FA has posted comments on this change.
Change subject: gluster: Remove Vdsm's dependency on glusterfs-server pkg
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/41568/11/vdsm.spec.in
File vdsm.spec.in:
Line 279: %endif # rhel
Line 280:
Line 281: # GlusterFS client-side RPMs needed for Gluster SD
Line 282: Requires: glusterfs-cli >= %{gluster_version}
Line 283: Requires: glusterfs-fuse >= %{gluster_version}
> Darshan,
This is not a valid assumption. vdsm/gluster/cli.py is part of vdsm package
itself and we have all gluster function calls available in supervdsm (It got
moved to vdsm package along with GlusterSD long back).
Please refer line #1189.
Line 284:
Line 285: Requires: psmisc >= 22.6-15
Line 286: Requires: bridge-utils
Line 287: Requires: sos
--
To view, visit https://gerrit.ovirt.org/41568
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43c8f16e8171693d1bbbff40198c59646022603e
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Darshan N
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: Timothy Asir
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:refactor: Remove Vdsm's dependency on glusterfs-serv...
Bala.FA has posted comments on this change. Change subject: gluster:refactor: Remove Vdsm's dependency on glusterfs-server pkg .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/41568/10//COMMIT_MSG Commit Message: Line 7: Remove Please take changes made in patch set #9 -- To view, visit https://gerrit.ovirt.org/41568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43c8f16e8171693d1bbbff40198c59646022603e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Remove Vdsm's dependency on glusterfs-server pkg
Bala.FA has posted comments on this change. Change subject: gluster: Remove Vdsm's dependency on glusterfs-server pkg .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43c8f16e8171693d1bbbff40198c59646022603e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:refactor: Remove Vdsm's dependency on glusterfs-serv...
Bala.FA has posted comments on this change.
Change subject: gluster:refactor: Remove Vdsm's dependency on glusterfs-server
pkg
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/41568/8//COMMIT_MSG
Commit Message:
Line 7: refactor
you need to change the heading properly.
https://gerrit.ovirt.org/#/c/41568/8/vdsm.spec.in
File vdsm.spec.in:
Line 281:
Line 282: # GlusterFS client-side RPMs needed for Gluster SD
Line 283: %if 0%{?with_gluster}
Line 284: Requires: glusterfs-cli >= 3.7.1
Line 285: Requires: glusterfs-fuse >= 3.7.1
> This version does not exists yet in rhel 7 server channel (I found only 3.6
For rhel-7, glusterfs client packages are available in rh-common. As v3.7.1 is
under development in downstream, it is not available yet. You could try brew
builds.
Line 286: %endif
Line 287:
Line 288: Requires: psmisc >= 22.6-15
Line 289: Requires: bridge-utils
--
To view, visit https://gerrit.ovirt.org/41568
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43c8f16e8171693d1bbbff40198c59646022603e
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Darshan N
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: Timothy Asir
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Provides partial device details on any disk failure
Bala.FA has posted comments on this change. Change subject: Provides partial device details on any disk failure .. Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/42435/1/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 130: ignoredDisks You should have global ignoredDisks and use whenever needed. You should also have an option to re-probe ignoredDisks. Line 139: _ignoreFaultyDevAndRetry This leads to never-ending loop. You should fix without recursion. -- To view, visit https://gerrit.ovirt.org/42435 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd92b49df10e35365868d243423e01cb3d84832b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix mount point issue for snapshot thin lv
Bala.FA has posted comments on this change. Change subject: gluster: fix mount point issue for snapshot thin lv .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/42424/1/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 101: mountPaths Why do you choose mountPaths[0]? -- To view, visit https://gerrit.ovirt.org/42424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifadcfaedf87d325b09211c52c77a08769f57cf53 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster:refactor: Remove Vdsm's dependency on glusterfs-serv...
Bala.FA has posted comments on this change. Change subject: gluster:refactor: Remove Vdsm's dependency on glusterfs-server pkg .. Patch Set 8: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/41568/8/vdsm.spec.in File vdsm.spec.in: Line 283: with_gluster is this still valid here? Line 641: replication please define gluster_version prior and use it everywhere -- To view, visit https://gerrit.ovirt.org/41568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43c8f16e8171693d1bbbff40198c59646022603e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: refresh lvm devices after brick create
Bala.FA has posted comments on this change. Change subject: gluster: refresh lvm devices after brick create .. Patch Set 1: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/42365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a6a10a2746c6f44a16de41c153ce46460d37b7f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: refresh lvm devices after brick create
Bala.FA has submitted this change and it was merged. Change subject: gluster: refresh lvm devices after brick create .. gluster: refresh lvm devices after brick create Issue: Brick create function in vdsm gluster module which creates lvm devices like pv, vg, thinlv and format the lv and mount it using python-blivet. In the brick creation process, the created vgs are not visible to lvm vgs command and the lvm devices and its details are not available or not listed by devices list function. Cause: On every successful brick creation the thin lv mount details will be updated into fstab entry to get the devices mounted automatically on reboot. Because of this visibility issue with lvm devices, the thin lvs which are mounted during brick create process are not getting mounted automatically on any number of reboot. The Blocking bug filed in https://bugzilla.redhat.com/show_bug.cgi?id=1227788 Observations: This issue is observed in any plain RHEL6.6 or RHEL6.7 node with the latest kernel (2.6.32-567.el6.x86_64) and python- blivet installed with or without vdsm installed in the node. This issue identified in the rhel system where it has the default lvm configuration. Findings: According to LVM2 man page documentation, vgscan should take place automatically and the manuel vgscan required only when there is any hardware change. The created vg details should be updated automatically. But it fails here some how. This shows that, this is absolutely an lvm issue. We have to run pvscan or vgscan to make lvm see vgs or lvs. Bug for lvm filed in https://bugzilla.redhat.com/show_bug.cgi?id=1230495 However there may be a little chances for blivet could cause this issue by passing some causing arguments to lvm. Blivet team is working on this to verify this. This issue never observed on any reboots or brick creates; when we execute a lvm pvs command or vgscan command at-least once afer any first brick create. Fix: This patch refresh lvm devices after brick create by running vgscan. This is a workaround patch and this will be removed once the lvm bz#1230495 is fixed. Kindly refer the bugs for any further details or logs. Change-Id: I6a6a10a2746c6f44a16de41c153ce46460d37b7f Signed-off-by: Timothy Asir Jeyasingh Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1227742 Bug-Url: https://bugzilla.redhat.com/1227788 Signed-off-by: Timothy Asir Jeyasingh Reviewed-on: https://gerrit.ovirt.org/42142 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/42365 Tested-by: Darshan N Reviewed-by: Bala.FA Continuous-Integration: Bala.FA --- M vdsm/gluster/exception.py M vdsm/gluster/storagedev.py 2 files changed, 14 insertions(+), 0 deletions(-) Approvals: Bala.FA: Looks good to me, approved; Passed CI tests Darshan N: Verified -- To view, visit https://gerrit.ovirt.org/42365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a6a10a2746c6f44a16de41c153ce46460d37b7f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: add xfsprogs as dependency to gluster sub-package
Bala.FA has submitted this change and it was merged. Change subject: gluster: add xfsprogs as dependency to gluster sub-package .. gluster: add xfsprogs as dependency to gluster sub-package As glusterBrickCreate verb uses xfs filesystem as default, this patch add xfsprogs package as dependency. Change-Id: I8823e9a5e1c84af8c3afdf1fc5a26e04b4be831b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1231210 Signed-off-by: Bala.FA Reviewed-on: https://gerrit.ovirt.org/42301 Continuous-Integration: Jenkins CI Reviewed-by: Timothy Asir Tested-by: Timothy Asir Reviewed-by: Darshan N Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/42364 Tested-by: Darshan N --- M vdsm.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Bala.FA: Looks good to me, approved; Passed CI tests Darshan N: Verified -- To view, visit https://gerrit.ovirt.org/42364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8823e9a5e1c84af8c3afdf1fc5a26e04b4be831b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: fix vg create failed first time during brick create
Bala.FA has submitted this change and it was merged. Change subject: gluster: fix vg create failed first time during brick create .. gluster: fix vg create failed first time during brick create Currently brick create uses vdsm lvm module for pv create and blivet to create a vg. This issue not occured if both pv and vg are created using blivet itself. But unfortunately blivet has few issues while creating a vg. Its able to create a vg with a pesize of minimum 1mb only. Also the vdsm lvm module has some issue while creating a vg. So this path uses lvm vgcreate command to create the vg as a workaround. Change-Id: Ibf558aab450d6c4546c34e9439249c44e930a304 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1226186 Signed-off-by: Timothy Asir Jeyasingh Reviewed-on: https://gerrit.ovirt.org/41392 Continuous-Integration: Jenkins CI Reviewed-by: Bala.FA Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/42363 Tested-by: Darshan N Continuous-Integration: Bala.FA --- M vdsm/gluster/exception.py M vdsm/gluster/storagedev.py 2 files changed, 28 insertions(+), 5 deletions(-) Approvals: Bala.FA: Looks good to me, approved; Passed CI tests Darshan N: Verified -- To view, visit https://gerrit.ovirt.org/42363 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf558aab450d6c4546c34e9439249c44e930a304 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: add xfsprogs as dependency to gluster sub-package
Bala.FA has posted comments on this change. Change subject: gluster: add xfsprogs as dependency to gluster sub-package .. Patch Set 1: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/42364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8823e9a5e1c84af8c3afdf1fc5a26e04b4be831b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: handle partition table corruption error
Bala.FA has submitted this change and it was merged. Change subject: gluster: handle partition table corruption error .. gluster: handle partition table corruption error Currently vdsm throws an exception if there is any corruption in the partitition entry of any device and returns an error for devices list and create brick. This path fixes this issue by just loggin the issue and continue with remaining devices. Change-Id: Iaeb3d42091b69f052ae93bbb114f9d3b9d158be4 Signed-off-by: Timothy Asir Jeyasingh Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1227781 Signed-off-by: Timothy Asir Jeyasingh Reviewed-on: https://gerrit.ovirt.org/42210 Continuous-Integration: Jenkins CI Reviewed-by: Bala.FA Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/42350 Tested-by: Darshan N Continuous-Integration: Bala.FA --- M vdsm/gluster/storagedev.py 1 file changed, 12 insertions(+), 6 deletions(-) Approvals: Bala.FA: Looks good to me, approved; Passed CI tests Darshan N: Verified -- To view, visit https://gerrit.ovirt.org/42350 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaeb3d42091b69f052ae93bbb114f9d3b9d158be4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: fix vg create failed first time during brick create
Bala.FA has posted comments on this change. Change subject: gluster: fix vg create failed first time during brick create .. Patch Set 1: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/42363 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf558aab450d6c4546c34e9439249c44e930a304 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: handle partition table corruption error
Bala.FA has posted comments on this change. Change subject: gluster: handle partition table corruption error .. Patch Set 1: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/42350 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaeb3d42091b69f052ae93bbb114f9d3b9d158be4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: tests: fix redefinition pyflakes error
Bala.FA has submitted this change and it was merged. Change subject: tests: fix redefinition pyflakes error .. tests: fix redefinition pyflakes error The build fails with the following error in pyflakes version "0.7.3-4" installed. ./tests/functional/networkTests.py:93: redefinition of unused 'vdsm' from line 28 ./tests/functional/networkTests.py:101: redefinition of unused 'vdsm' from line 28 make[1]: *** [pyflakes] Error 1 Change-Id: I244dfbc031a4c10f1938d3f5a07daed757011d16 Signed-off-by: Timothy Asir Jeyasingh Reviewed-on: https://gerrit.ovirt.org/41402 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer Reviewed-by: Piotr Kliczewski Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/42349 Tested-by: Darshan N Reviewed-by: Bala.FA Continuous-Integration: Bala.FA --- M tests/functional/networkTests.py 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Bala.FA: Looks good to me, approved; Passed CI tests Darshan N: Verified -- To view, visit https://gerrit.ovirt.org/42349 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I244dfbc031a4c10f1938d3f5a07daed757011d16 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: tests: fix redefinition pyflakes error
Bala.FA has posted comments on this change. Change subject: tests: fix redefinition pyflakes error .. Patch Set 1: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/42349 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I244dfbc031a4c10f1938d3f5a07daed757011d16 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: add xfsprogs as dependency to gluster sub-package
Bala.FA has posted comments on this change. Change subject: gluster: add xfsprogs as dependency to gluster sub-package .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/42301/2/vdsm.spec.in File vdsm.spec.in: Line 648: xfsprogs > would it be better if we add this dependency only with_gluster, as its used Its added that way. gluster sub-package gives only api and the sub-package is enabled only if _with_gluster is set. -- To view, visit https://gerrit.ovirt.org/42301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8823e9a5e1c84af8c3afdf1fc5a26e04b4be831b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: refresh lvm devices after brick create
Bala.FA has posted comments on this change. Change subject: gluster: refresh lvm devices after brick create .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a6a10a2746c6f44a16de41c153ce46460d37b7f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix vg create failed first time during brick create
Bala.FA has posted comments on this change. Change subject: gluster: fix vg create failed first time during brick create .. Patch Set 8: Code-Review+1 We would need this patch urgently for RHGS downstream. However once this patch https://gerrit.ovirt.org/#/c/42070/ gets merged we will adopt the change accordingly. -- To view, visit https://gerrit.ovirt.org/41392 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ca89347b537e0ab6cffc2b1293ba9b5a32c366d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: refresh lvm devices after brick create
Bala.FA has posted comments on this change. Change subject: gluster: refresh lvm devices after brick create .. Patch Set 5: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/42142/5/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 308: explain why you are doing this. -- To view, visit https://gerrit.ovirt.org/42142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a6a10a2746c6f44a16de41c153ce46460d37b7f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: rename glusterCreateBrick to glusterBrickCreate
Hello Piotr Kliczewski, Timothy Asir, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/42308
to review the following change.
Change subject: gluster: rename glusterCreateBrick to glusterBrickCreate
..
gluster: rename glusterCreateBrick to glusterBrickCreate
To make consistency in function names in supervdsm and verb names in
vdsm, this patch renames verb glusterCreateBrick to glusterBrickCreate
Change-Id: I367a864bc9bf4aa9b6a0d36b64f541fa89c61c0d
Signed-off-by: Bala.FA
---
M client/vdsClientGluster.py
M vdsm/gluster/api.py
M vdsm/gluster/apiwrapper.py
M vdsm/gluster/storagedev.py
M vdsm/rpc/vdsmapi-gluster-schema.json
5 files changed, 11 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/42308/1
diff --git a/client/vdsClientGluster.py b/client/vdsClientGluster.py
index a4bce63..76b91e1 100644
--- a/client/vdsClientGluster.py
+++ b/client/vdsClientGluster.py
@@ -633,7 +633,7 @@
pp.pprint(status)
return status['status']['code'], status['status']['message']
-def do_glusterCreateBrick(self, args):
+def do_glusterBrickCreate(self, args):
params = self._eqSplit(args)
devList = params.get('devices', '').split(',')
brickName = params.get('brickName', '')
@@ -646,7 +646,7 @@
raidParams['stripeSize'] = int(params.get('stripeSize', 0))
raidParams['pdCount'] = int(params.get('pdCount', 0))
-status = self.s.glusterCreateBrick(brickName, mountPoint,
+status = self.s.glusterBrickCreate(brickName, mountPoint,
devList, fsType, raidParams)
pp.pprint(status)
return status['status']['code'], status['status']['message']
@@ -1172,8 +1172,8 @@
('[volumeName=]',
'snapshot list for given volume'
)),
- 'glusterCreateBrick': (
- serv.do_glusterCreateBrick,
+ 'glusterBrickCreate': (
+ serv.do_glusterBrickCreate,
('brickName= mountPoint= '
'devices= '
'[raidType=] [stripeSize=] '
diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py
index 24b8230..918c3cc 100644
--- a/vdsm/gluster/api.py
+++ b/vdsm/gluster/api.py
@@ -672,9 +672,9 @@
return {'snapshotList': status}
@exportAsVerb
-def createBrick(self, name, mountPoint, devList, fsType=None,
+def brickCreate(self, name, mountPoint, devList, fsType=None,
raidParams={}, options=None):
-status = self.svdsmProxy.glusterCreateBrick(name,
+status = self.svdsmProxy.glusterBrickCreate(name,
mountPoint,
devList,
fsType,
diff --git a/vdsm/gluster/apiwrapper.py b/vdsm/gluster/apiwrapper.py
index 4768a86..f607dd4 100644
--- a/vdsm/gluster/apiwrapper.py
+++ b/vdsm/gluster/apiwrapper.py
@@ -81,9 +81,9 @@
def storageDevicesList(self, options=None):
return self._gluster.storageDevicesList()
-def createBrick(self, name, mountPoint, devList, fsType=None,
+def brickCreate(self, name, mountPoint, devList, fsType=None,
raidParams={}):
-return self._gluster.createBrick(name, mountPoint,
+return self._gluster.brickCreate(name, mountPoint,
devList, fsType, raidParams)
diff --git a/vdsm/gluster/storagedev.py b/vdsm/gluster/storagedev.py
index 2aeabad..f4178e9 100644
--- a/vdsm/gluster/storagedev.py
+++ b/vdsm/gluster/storagedev.py
@@ -123,7 +123,7 @@
@makePublic
-def createBrick(brickName, mountPoint, devNameList, fsType=DEFAULT_FS_TYPE,
+def brickCreate(brickName, mountPoint, devNameList, fsType=DEFAULT_FS_TYPE,
raidParams={}):
def _getDeviceList(devNameList):
return [blivetEnv.devicetree.getDeviceByName(devName.split("/")[-1])
diff --git a/vdsm/rpc/vdsmapi-gluster-schema.json
b/vdsm/rpc/vdsmapi-gluster-schema.json
index c86f43c..209bfbd 100644
--- a/vdsm/rpc/vdsmapi-gluster-schema.json
+++ b/vdsm/rpc/vdsmapi-gluster-schema.json
@@ -1274,7 +1274,7 @@
'data': {'type': 'str', 'stripeSize': 'int', 'diskCnt': 'int'}}
##
-# @GlusterHost.createBrick:
+# @GlusterHost.brickCreate:
#
# Create a brick for the gluster volume
#
@@ -1293,7 +1293,7 @@
#
# Since: 4.17.0
##
-{'command': {'class': 'GlusterHost', 'name': 'createBrick'},
+{'command': {'class': 'GlusterHost', 'name': 'brickCreate'},
'data': {'name': 'str', 'mountPoint': 'str', 'devList': ['str'],
'*fsType': 'str', '*raidParams': 'RaidDevice'},
'returns': 'bool'}
--
To view, visit https://gerrit.ovirt.org/42308
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I367a864bc9bf4aa9b6
Change in vdsm[ovirt-3.5-gluster]: gluster: verbs to override/reset cli snapshot scheduling.
Bala.FA has submitted this change and it was merged. Change subject: gluster: verbs to override/reset cli snapshot scheduling. .. gluster: verbs to override/reset cli snapshot scheduling. This patch adds two verbs to override/reset gluster cli based snapshot scheduling. The verbs are as follows: *snapshotScheduleOverride: This verb sets the snapshot scheduling flag in meta-volume to ovirt, this means the snapshot scheduling job will be taken care by engine and the gluster won't be able to schedule snapshots. This has optional argument force. With force option, any existing gluster schedules will be disabled. *snapshotScheduleReset: This verb sets the snapshot scheduling flag in meta-volume to none, this means the snapshot scheduling job will no longer be taken care by engine. Change-Id: Iff8f21593921bac18950a9ee42bb3972d278f7aa Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1230342 Signed-off-by: Darshan N Reviewed-on: https://gerrit.ovirt.org/40141 Reviewed-by: Bala.FA Continuous-Integration: Jenkins CI Reviewed-by: Shubhendu Tripathi Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/42302 Continuous-Integration: Bala.FA --- M client/vdsClientGluster.py M vdsm.spec.in M vdsm/gluster/api.py M vdsm/gluster/apiwrapper.py M vdsm/gluster/exception.py M vdsm/rpc/vdsmapi-gluster-schema.json 6 files changed, 123 insertions(+), 1 deletion(-) Approvals: Bala.FA: Looks good to me, approved; Passed CI tests Shubhendu Tripathi: Looks good to me, but someone else must approve Darshan N: Verified -- To view, visit https://gerrit.ovirt.org/42302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff8f21593921bac18950a9ee42bb3972d278f7aa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: verbs to override/reset cli snapshot scheduling.
Bala.FA has posted comments on this change. Change subject: gluster: verbs to override/reset cli snapshot scheduling. .. Patch Set 1: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/42302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff8f21593921bac18950a9ee42bb3972d278f7aa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: add xfsprogs as dependency to gluster sub-package
Hello Piotr Kliczewski, Timothy Asir, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/42301
to review the following change.
Change subject: gluster: add xfsprogs as dependency to gluster sub-package
..
gluster: add xfsprogs as dependency to gluster sub-package
As glusterBrickCreate verb uses xfs filesystem as default, this patch
add xfsprogs package as dependency.
Change-Id: I8823e9a5e1c84af8c3afdf1fc5a26e04b4be831b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1231210
Signed-off-by: Bala.FA
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/42301/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index b269265..8611a10 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -645,6 +645,7 @@
%if 0%{?rhel} > 6 || 0%{?fedora}
Requires: python-blivet
%endif
+Requires: xfsprogs
%description gluster
Gluster plugin enables VDSM to serve Gluster functionalities.
--
To view, visit https://gerrit.ovirt.org/42301
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8823e9a5e1c84af8c3afdf1fc5a26e04b4be831b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Timothy Asir
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: handle partition table corruption error
Bala.FA has posted comments on this change. Change subject: gluster: handle partition table corruption error .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42210 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaeb3d42091b69f052ae93bbb114f9d3b9d158be4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: Added an optional argument to mountBrokerSetup verb
Bala.FA has submitted this change and it was merged. Change subject: gluster: Added an optional argument to mountBrokerSetup verb .. gluster: Added an optional argument to mountBrokerSetup verb Added an optional argument called "partial" to mountBrokerSetup verb. This argument takes boolean value. If true only mount broker root creation is done as part of mountBrokerSetup, else along with root creation user addition and few mount broker options are also set. This is introduced because in only one of the slave node's all the operations mentioned above has to be done, this is synced to all the remaining nodes automatically. Only mount broker root creation has to be performed on all the slave nodes. Engine can call this verb with partial as false on one of the nodes and on all the other nodes verb can be called with partial set to true. Change-Id: I732675c611221cf10f191f69990f78bd713da245 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1230353 Signed-off-by: Darshan N Reviewed-on: https://gerrit.ovirt.org/41600 Reviewed-by: Sahina Bose Reviewed-by: Piotr Kliczewski Reviewed-by: Bala.FA Reviewed-by: Dan Kenigsberg Continuous-Integration: Jenkins CI Reviewed-on: https://gerrit.ovirt.org/42298 Continuous-Integration: Bala.FA --- M client/vdsClientGluster.py M vdsm/gluster/api.py M vdsm/gluster/apiwrapper.py M vdsm/rpc/vdsmapi-gluster-schema.json 4 files changed, 20 insertions(+), 13 deletions(-) Approvals: Bala.FA: Looks good to me, approved; Passed CI tests Darshan N: Verified -- To view, visit https://gerrit.ovirt.org/42298 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I732675c611221cf10f191f69990f78bd713da245 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: Added an optional argument to mountBrokerSetup verb
Bala.FA has posted comments on this change. Change subject: gluster: Added an optional argument to mountBrokerSetup verb .. Patch Set 1: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/42298 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I732675c611221cf10f191f69990f78bd713da245 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: verbs to override/reset cli snapshot scheduling.
Bala.FA has posted comments on this change. Change subject: gluster: verbs to override/reset cli snapshot scheduling. .. Patch Set 14: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/40141/14//COMMIT_MSG Commit Message: Line 26: https thanks -- To view, visit https://gerrit.ovirt.org/40141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff8f21593921bac18950a9ee42bb3972d278f7aa Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: handle partition table corruption error
Bala.FA has posted comments on this change. Change subject: gluster: handle partition table corruption error .. Patch Set 3: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/42210/3/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 46: blivet looks like default log level is DEBUG and it can't be changed, we should disable logging. -- To view, visit https://gerrit.ovirt.org/42210 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaeb3d42091b69f052ae93bbb114f9d3b9d158be4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: verbs to override/reset cli snapshot scheduling.
Bala.FA has posted comments on this change. Change subject: gluster: verbs to override/reset cli snapshot scheduling. .. Patch Set 11: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/40141/11/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 44: META_VOL_MOUNT_POINT its better to have SNAP_SCHEDULER_FLAG_FILE Line 740: force I think force=True should be default. Line 741: glusterUpdateSnapshotScheduleFlag supervdsm function name ends with action eg. glusterVolumeCreate() Please change function names accordingly. -- To view, visit https://gerrit.ovirt.org/40141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff8f21593921bac18950a9ee42bb3972d278f7aa Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added an optional argument to mountBrokerSetup verb.
Bala.FA has posted comments on this change. Change subject: gluster: Added an optional argument to mountBrokerSetup verb. .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41600 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I732675c611221cf10f191f69990f78bd713da245 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: anmolbabu Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: handle partition table corruption error
Bala.FA has posted comments on this change.
Change subject: gluster: handle partition table corruption error
..
Patch Set 2: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/42210/2/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:
Line 42:
Line 43: log = logging.getLogger("Gluster")
Line 44:
Line 45: try:
Line 46: blivet.util.set_up_logging("/var/log/blivet.log")
> /var/log/blivet.log or /var/log/vdsm/blivet.log? Would ovirt-log-collector
1. Why do you need to set logger?
2. If logger is needed, set proper log level. may be ERROR
3. Set log file as /var/log/vdsm/blivet.log
Line 47: except AttributeError:
Line 48: pass
Line 49:
Line 50: _lvconvertCommandPath = utils.CommandPath("lvconvert",
Line 121: blivet
except (blivet.errors.UnusableConfigurationError, blivet.errors.StorageError)
as e
--
To view, visit https://gerrit.ovirt.org/42210
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaeb3d42091b69f052ae93bbb114f9d3b9d158be4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: Timothy Asir
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added an optional argument to mountBrokerSetup verb.
Bala.FA has posted comments on this change. Change subject: gluster: Added an optional argument to mountBrokerSetup verb. .. Patch Set 1: Looks good to me. Please add a bug for this patch -- To view, visit https://gerrit.ovirt.org/41600 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I732675c611221cf10f191f69990f78bd713da245 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: anmolbabu Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Gluster packages are not always available
Bala.FA has posted comments on this change. Change subject: Gluster packages are not always available .. Patch Set 3: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/41645/3/vdsm.spec.in File vdsm.spec.in: Line 294 Line 295 Line 296 Line 297 Line 298 > For mounting gluster storage domain and use gluster based vm disk, we must +1 better to have Requires: glusterfs-cli >= 3.6.999 Line 296 Line 297 Line 298 Line 299 Line 300 > To mount glusterfs storage domain, we must have /usr/sbin/mount.glusterfs. +1 glusterfs-fuse >= 3.6.999 please note that vdsm-gluster sub-package should depend on glusterfs-api -- To view, visit https://gerrit.ovirt.org/41645 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia51d9c30538c8f5f6f287c18de8fc2803ac1c76d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: verbs to enable/disable snapshot scheduling.
Bala.FA has posted comments on this change. Change subject: gluster: verbs to enable/disable snapshot scheduling. .. Patch Set 8: Code-Review-1 (4 comments) https://gerrit.ovirt.org/#/c/40141/8//COMMIT_MSG Commit Message: Line 7: enable you should update vdsm.spec.in to reflect minimum glusterfs version. https://gerrit.ovirt.org/#/c/40141/8/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 740: overrideSnapshotSchedule Change name to snapshotScheduleOverride() Line 746: resetSnapshotSchedule Change name to snapshotScheduleReset() https://gerrit.ovirt.org/#/c/40141/8/vdsm/gluster/apiwrapper.py File vdsm/gluster/apiwrapper.py: Line 319: resetSnapshotSchedule change the name same as api.py for above two function. -- To view, visit https://gerrit.ovirt.org/40141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff8f21593921bac18950a9ee42bb3972d278f7aa Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: handle partition table corruption error
Bala.FA has posted comments on this change.
Change subject: gluster: handle partition table corruption error
..
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/42210/1/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:
Line 40: from . import makePublic
Line 41:
Line 42:
Line 43: log = logging.getLogger("Gluster")
Line 44: blivet.util.set_up_logging()
> Currently blivet log to /tmp only. They have not yet implement the logging
Are you sure the location can't be changed?
Line 45: _lvconvertCommandPath = utils.CommandPath("lvconvert",
Line 46: "/sbin/lvconvert",
Line 47: "/usr/sbin/lvconvert",)
Line 48: _lvchangeCommandPath = utils.CommandPath("lvchange",
Line 117: error
As this try-except is repeating, have a function like
def _reset_blivet(blivetEnv):
try:
...
...
--
To view, visit https://gerrit.ovirt.org/42210
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaeb3d42091b69f052ae93bbb114f9d3b9d158be4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: Timothy Asir
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage.lvm: add prefix, check and initialize pvs as optiona...
Bala.FA has posted comments on this change. Change subject: storage.lvm: add prefix, check and initialize pvs as optional for vgcreate .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42070 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31ffb8b77660c0c63a8a89a769e30f15f2f92826 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: refresh lvm devices after brick create
Bala.FA has posted comments on this change. Change subject: gluster: refresh lvm devices after brick create .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/42142/2//COMMIT_MSG Commit Message: Line 14: com See https://bugzilla.redhat.com/show_bug.cgi?id=1227742#c16 You should not assume something. -- To view, visit https://gerrit.ovirt.org/42142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a6a10a2746c6f44a16de41c153ce46460d37b7f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix vg create failed first time during brick create
Bala.FA has posted comments on this change. Change subject: gluster: fix vg create failed first time during brick create .. Patch Set 8: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/41392/8//COMMIT_MSG Commit Message: Line 14: issue What is the issue with vdsm/lvm module? Its better to fix that. -- To view, visit https://gerrit.ovirt.org/41392 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ca89347b537e0ab6cffc2b1293ba9b5a32c366d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster:fix NoneType error for some devices does not contain...
Bala.FA has posted comments on this change. Change subject: gluster:fix NoneType error for some devices does not contain sysfsPath .. Patch Set 5: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/41466 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54efdf3958519e2ae038b527a03e0b57569c2e8f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster:fix NoneType error for some devices does not contain...
Bala.FA has submitted this change and it was merged. Change subject: gluster:fix NoneType error for some devices does not contain sysfsPath .. gluster:fix NoneType error for some devices does not contain sysfsPath Currently devices list returns the list of available disks and its fs type properly. However it fails for some devices which does not contain sysfsPath and the dev details become None. This is a workaround patch. This fixes this error by assigning empty dictonary if the dev is empty or None. This will be removed once the dependent bugs fixed Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1225417 Change-Id: I54efdf3958519e2ae038b527a03e0b57569c2e8f Signed-off-by: Timothy Asir Jeyasingh Reviewed-on: https://gerrit.ovirt.org/41262 Reviewed-by: Piotr Kliczewski Reviewed-by: Ramesh N Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/41466 Tested-by: Ramesh N Reviewed-by: Bala.FA Continuous-Integration: Bala.FA --- M vdsm/gluster/storagedev.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Timothy Asir: Verified Bala.FA: Looks good to me, approved; Passed CI tests Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/41466 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54efdf3958519e2ae038b527a03e0b57569c2e8f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster:fix NoneType error for some devices does not contain...
Bala.FA has posted comments on this change. Change subject: gluster:fix NoneType error for some devices does not contain sysfsPath .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41466 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54efdf3958519e2ae038b527a03e0b57569c2e8f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster:fix NoneType error for some devices does not contain...
Bala.FA has posted comments on this change. Change subject: gluster:fix NoneType error for some devices does not contain sysfsPath .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41466 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54efdf3958519e2ae038b527a03e0b57569c2e8f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: create vg with custom pesize
Bala.FA has posted comments on this change. Change subject: gluster: create vg with custom pesize .. Patch Set 3: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/41392/3/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 173: Workaround 1. Please use the format how workaround comments are described. 2. You haven't updated the rpm spec file. -- To view, visit https://gerrit.ovirt.org/41392 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ca89347b537e0ab6cffc2b1293ba9b5a32c366d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster:fix NoneType error for some devices does not contain...
Bala.FA has posted comments on this change.
Change subject: gluster:fix NoneType error for some devices does not contain
sysfsPath
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/41466/1/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:
Line 82: # lvm vg will not have sysfs path
Line 83: if hasattr(udev, 'get_device'):
Line 84: dev = udev.get_device(device.sysfsPath) or {}
Line 85: elif hasattr(udev, 'udev_get_device'):
Line 86: dev = udev.udev_get_device(device.sysfsPath) or {}
> We have't think of creating a new bug in blivet for this device.format.type
The bz in blivet should have been filed before those patches got merged. You
are just doing a workaround of an issue. It means the issue has to be fixed
properly in the right place.
We need a bz in blivet and you should clearly tell in the patch why you are
doing the workaround.
Line 87: else:
Line 88: dev = {}
Line 89: info['fsType'] = device.format.type or dev.get('ID_FS_TYPE',
'')
Line 90: if hasattr(device.format, 'mountpoint'):
--
To view, visit https://gerrit.ovirt.org/41466
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54efdf3958519e2ae038b527a03e0b57569c2e8f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Timothy Asir
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Darshan N
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Ramesh N
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: Timothy Asir
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster:fix NoneType error for some devices does not contain...
Bala.FA has posted comments on this change.
Change subject: gluster:fix NoneType error for some devices does not contain
sysfsPath
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/41466/1/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:
Line 82: # lvm vg will not have sysfs path
Line 83: if hasattr(udev, 'get_device'):
Line 84: dev = udev.get_device(device.sysfsPath) or {}
Line 85: elif hasattr(udev, 'udev_get_device'):
Line 86: dev = udev.udev_get_device(device.sysfsPath) or {}
> bz#1223725. device.format.type discovery mechanism for xfs they are working
Got it. But bz#1209493 is ovirt one. What about the bug in blivet of missing
fstype for valid file system on a device?
Line 87: else:
Line 88: dev = {}
Line 89: info['fsType'] = device.format.type or dev.get('ID_FS_TYPE',
'')
Line 90: if hasattr(device.format, 'mountpoint'):
--
To view, visit https://gerrit.ovirt.org/41466
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54efdf3958519e2ae038b527a03e0b57569c2e8f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Timothy Asir
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Darshan N
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Ramesh N
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: Timothy Asir
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster:fix NoneType error for some devices does not contain...
Bala.FA has posted comments on this change.
Change subject: gluster:fix NoneType error for some devices does not contain
sysfsPath
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/41466/1/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:
Line 82: # lvm vg will not have sysfs path
Line 83: if hasattr(udev, 'get_device'):
Line 84: dev = udev.get_device(device.sysfsPath) or {}
Line 85: elif hasattr(udev, 'udev_get_device'):
Line 86: dev = udev.udev_get_device(device.sysfsPath) or {}
> The bug which was open for this in blivet closed as not a bug and this is t
What is the bz? And what is the bz for None value set to device.format.type
for valid fs type? I believe at least one of bug has to be addressed in blivet.
Line 87: else:
Line 88: dev = {}
Line 89: info['fsType'] = device.format.type or dev.get('ID_FS_TYPE',
'')
Line 90: if hasattr(device.format, 'mountpoint'):
--
To view, visit https://gerrit.ovirt.org/41466
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54efdf3958519e2ae038b527a03e0b57569c2e8f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Timothy Asir
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Darshan N
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Ramesh N
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: Timothy Asir
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: create vg with custom pesize
Bala.FA has posted comments on this change. Change subject: gluster: create vg with custom pesize .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41392/2/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 167: return deviceList Line 168: Line 169: def _createVG(vgName, deviceList, stripeSize=0): Line 170: if stripeSize: Line 171: devices = ','.join([device.path for device in deviceList]) > Yes, I will describe. you should add this into the spec accordingly Line 172: rc, out, err = utils.execCmd([_vgCreateCommandPath.cmd, Line 173: '-s', '%sk' % stripeSize, Line 174: vgName, devices]) Line 175: -- To view, visit https://gerrit.ovirt.org/41392 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ca89347b537e0ab6cffc2b1293ba9b5a32c366d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: create vg with custom pesize
Bala.FA has posted comments on this change. Change subject: gluster: create vg with custom pesize .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/41392/2/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 171: devices you should describe here about the workaround and how to remove this workaround once the bz got fixed. What is required blivet version in RHEL-6, RHEL-7, F20, F21 and F22? -- To view, visit https://gerrit.ovirt.org/41392 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ca89347b537e0ab6cffc2b1293ba9b5a32c366d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster:fix NoneType error for some devices does not contain...
Bala.FA has posted comments on this change.
Change subject: gluster:fix NoneType error for some devices does not contain
sysfsPath
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/41466/1/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:
Line 82: # lvm vg will not have sysfs path
Line 83: if hasattr(udev, 'get_device'):
Line 84: dev = udev.get_device(device.sysfsPath) or {}
Line 85: elif hasattr(udev, 'udev_get_device'):
Line 86: dev = udev.udev_get_device(device.sysfsPath) or {}
Have you identified this issue or do you have bz# for this issue?
Line 87: else:
Line 88: dev = {}
Line 89: info['fsType'] = device.format.type or dev.get('ID_FS_TYPE',
'')
Line 90: if hasattr(device.format, 'mountpoint'):
--
To view, visit https://gerrit.ovirt.org/41466
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54efdf3958519e2ae038b527a03e0b57569c2e8f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Timothy Asir
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Darshan N
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Ramesh N
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: Timothy Asir
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: use socket.getfqdn instead of 'hostname' binary
Bala.FA has posted comments on this change. Change subject: gluster: use socket.getfqdn instead of 'hostname' binary .. Patch Set 4: Code-Review+1 Thanks for the change. -- To view, visit https://gerrit.ovirt.org/37621 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4b4a0062bedc41bee6528c1d06d707b4f7547e6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster.hostname: simplify by using a constant for the 'host...
Bala.FA has posted comments on this change. Change subject: gluster.hostname: simplify by using a constant for the 'hostname' executable .. Patch Set 2: Code-Review-1 Can we use socket.getfqdn() and get rid of hostname command entirely? At engine side output of hostname command does not help much. -- To view, visit https://gerrit.ovirt.org/37621 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4b4a0062bedc41bee6528c1d06d707b4f7547e6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: fix no attribute error
Bala.FA has posted comments on this change. Change subject: gluster: fix no attribute error .. Patch Set 1: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/41218 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4ee6f3d62e51c67db12b4859da6508c50e92753 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: fix no attribute error
Bala.FA has submitted this change and it was merged. Change subject: gluster: fix no attribute error .. gluster: fix no attribute error This was introduced with the patch: https://gerrit.ovirt.org/#/c/40206/. In rhel6 and rhel7 this patch was passing the build. In fedora this was introducing AttributeError. This patch fixes that issue by selectively checking if attribute exists or not. Change-Id: Ie4ee6f3d62e51c67db12b4859da6508c50e92753 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1209493 Signed-off-by: Timothy Asir Jeyasingh Reviewed-on: https://gerrit.ovirt.org/41056 Reviewed-by: Federico Simoncelli Tested-by: Piotr Kliczewski Tested-by: Darshan N Reviewed-by: Bala.FA Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/41218 Continuous-Integration: Bala.FA --- M vdsm/gluster/storagedev.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Bala.FA: Looks good to me, approved; Passed CI tests Darshan N: Verified -- To view, visit https://gerrit.ovirt.org/41218 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4ee6f3d62e51c67db12b4859da6508c50e92753 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: fix format type test-case error
Bala.FA has posted comments on this change. Change subject: gluster: fix format type test-case error .. Patch Set 1: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/41216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I193616848d6ae6153f3f203c33acd42e974836f0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: Added volumeReplaceBrickCommitForce verb.
Bala.FA has submitted this change and it was merged. Change subject: gluster: Added volumeReplaceBrickCommitForce verb. .. gluster: Added volumeReplaceBrickCommitForce verb. This patch adds volumeReplaceBrickCommitForce verb, This verb replaces a gluster brick without any data migration. * volumeReplaceBrickCommitForce: It takes volumeName, currentBrick and newBrick as arguments. It returns success/failure. Change-Id: Id2dc16121cdba99c49d56c4e0b8e7a0194d58d14 Signed-off-by: Darshan N Reviewed-on: https://gerrit.ovirt.org/40587 Reviewed-by: Piotr Kliczewski Continuous-Integration: Jenkins CI Tested-by: Timothy Asir Reviewed-by: Bala.FA Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/41217 Continuous-Integration: Bala.FA --- M client/vdsClientGluster.py M vdsm/gluster/api.py M vdsm/gluster/apiwrapper.py M vdsm/gluster/cli.py M vdsm/gluster/exception.py M vdsm/rpc/vdsmapi-gluster-schema.json 6 files changed, 67 insertions(+), 0 deletions(-) Approvals: Bala.FA: Looks good to me, approved; Passed CI tests Darshan N: Verified -- To view, visit https://gerrit.ovirt.org/41217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2dc16121cdba99c49d56c4e0b8e7a0194d58d14 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: Added volumeReplaceBrickCommitForce verb.
Bala.FA has posted comments on this change. Change subject: gluster: Added volumeReplaceBrickCommitForce verb. .. Patch Set 1: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/41217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2dc16121cdba99c49d56c4e0b8e7a0194d58d14 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: fix format type test-case error
Bala.FA has submitted this change and it was merged. Change subject: gluster: fix format type test-case error .. gluster: fix format type test-case error Change-Id: I193616848d6ae6153f3f203c33acd42e974836f0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1209493 Signed-off-by: Timothy Asir Jeyasingh Reviewed-on: https://gerrit.ovirt.org/41045 Continuous-Integration: Jenkins CI Reviewed-by: Darshan N Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/41216 Tested-by: Darshan N Reviewed-by: Bala.FA Continuous-Integration: Bala.FA --- M tests/glusterTestData.py 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Bala.FA: Looks good to me, approved; Passed CI tests Darshan N: Verified -- To view, visit https://gerrit.ovirt.org/41216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I193616848d6ae6153f3f203c33acd42e974836f0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: fix pyflakes error in mount point verification
Bala.FA has submitted this change and it was merged. Change subject: gluster: fix pyflakes error in mount point verification .. gluster: fix pyflakes error in mount point verification Change-Id: Id4ad096e0c8cb470311d9f219e7469b16fd697de Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1209475 Signed-off-by: Timothy Asir Jeyasingh Reviewed-on: https://gerrit.ovirt.org/41046 Continuous-Integration: Jenkins CI Reviewed-by: Darshan N Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/41215 Tested-by: Darshan N Reviewed-by: Bala.FA Continuous-Integration: Bala.FA --- M vdsm/gluster/exception.py M vdsm/gluster/storagedev.py 2 files changed, 2 insertions(+), 6 deletions(-) Approvals: Bala.FA: Looks good to me, approved; Passed CI tests Darshan N: Verified -- To view, visit https://gerrit.ovirt.org/41215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4ad096e0c8cb470311d9f219e7469b16fd697de Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: fix pyflakes error in mount point verification
Bala.FA has posted comments on this change. Change subject: gluster: fix pyflakes error in mount point verification .. Patch Set 1: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/41215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4ad096e0c8cb470311d9f219e7469b16fd697de Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster:Remove support for Replace gluster brick with data m...
Bala.FA has posted comments on this change. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. Patch Set 1: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/41214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster:Remove support for Replace gluster brick with data m...
Bala.FA has submitted this change and it was merged. Change subject: gluster:Remove support for Replace gluster brick with data migration. .. gluster:Remove support for Replace gluster brick with data migration. This patch removes verbs related to replace gluster brick with data migration. Now only replace brick with commit is retained. As this feature is deprecated in glusterfs-3.7 on wards. These verbs were not consumed by engine, so it should not cause any backward-compatibility issues when removed. The list of verbs removed are as follows: *volumeReplaceBrickStart *volumeReplaceBrickAbort *volumeReplaceBrickPause *volumeReplaceBrickStatus *volumeReplaceBrickCommit Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Signed-off-by: Darshan N Reviewed-on: https://gerrit.ovirt.org/40545 Continuous-Integration: Jenkins CI Reviewed-by: Bala.FA Reviewed-by: Piotr Kliczewski Reviewed-by: Dan Kenigsberg Signed-off-by: Darshan N Reviewed-on: https://gerrit.ovirt.org/41214 Continuous-Integration: Bala.FA --- M client/vdsClientGluster.py M vdsm/gluster/api.py M vdsm/gluster/apiwrapper.py M vdsm/gluster/cli.py M vdsm/gluster/exception.py M vdsm/rpc/vdsmapi-gluster-schema.json 6 files changed, 0 insertions(+), 273 deletions(-) Approvals: Bala.FA: Looks good to me, approved; Passed CI tests Darshan N: Verified -- To view, visit https://gerrit.ovirt.org/41214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1569972120da27c17407bec5301b1ba417ce0768 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: Adds a new element 'additionalFeatures' to getVdsCaps.
Bala.FA has submitted this change and it was merged. Change subject: gluster: Adds a new element 'additionalFeatures' to getVdsCaps. .. gluster: Adds a new element 'additionalFeatures' to getVdsCaps. This patch adds a new element 'additionalFeatures' to getVdsCaps, which gives the list of additional fetures supported by the host. This patch also adds additional gluster features supported in vdsm to the above list, if the host has vdsm support for features like snapshot, geo-replication and disk-provisoning they will be added to the list. Change-Id: Ic203fa0565914d528ae457427f6f1ff7708017d2 Signed-off-by: Darshan N Reviewed-on: https://gerrit.ovirt.org/40044 Reviewed-by: Bala.FA Continuous-Integration: Bala.FA --- M vdsm/caps.py M vdsm/gluster/api.py M vdsm/rpc/vdsmapi-schema.json 3 files changed, 25 insertions(+), 2 deletions(-) Approvals: Bala.FA: Looks good to me, approved; Passed CI tests Darshan N: Verified -- To view, visit https://gerrit.ovirt.org/40044 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic203fa0565914d528ae457427f6f1ff7708017d2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: Adds a new element 'additionalFeatures' to getVdsCaps.
Bala.FA has posted comments on this change. Change subject: gluster: Adds a new element 'additionalFeatures' to getVdsCaps. .. Patch Set 2: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/40044 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic203fa0565914d528ae457427f6f1ff7708017d2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5-gluster]: gluster: New verb to mount & update fstab for meta-volume
Bala.FA has submitted this change and it was merged. Change subject: gluster: New verb to mount & update fstab for meta-volume .. gluster: New verb to mount & update fstab for meta-volume This patch adds a new verb 'MetaVolumeMount' to update fstab entry for meta-volume and mount it. This meta-volume is needed by various glusterfs features like snapshot-schedule, geo-replication etc. It is expected to be mounted on all gluster nodes. It takes an optional argument metaVolumeName. Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4 Signed-off-by: Darshan N Reviewed-on: https://gerrit.ovirt.org/40497 Continuous-Integration: Jenkins CI Reviewed-by: Bala.FA Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/41209 Continuous-Integration: Bala.FA --- M client/vdsClientGluster.py M vdsm/gluster/api.py M vdsm/gluster/apiwrapper.py M vdsm/gluster/exception.py M vdsm/rpc/vdsmapi-gluster-schema.json 5 files changed, 98 insertions(+), 1 deletion(-) Approvals: Bala.FA: Looks good to me, approved; Passed CI tests Darshan N: Verified -- To view, visit https://gerrit.ovirt.org/41209 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5-gluster Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
