Change in vdsm[ovirt-4.0]: jsonvdscli: change hostname default
Oved Ourfali has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 1: Rerun-Hooks: all -- To view, visit https://gerrit.ovirt.org/63308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: dump_volume_chains: migrate to jsonrpcvdscli
Oved Ourfali has posted comments on this change. Change subject: dump_volume_chains: migrate to jsonrpcvdscli .. Patch Set 11: Irit - can you answer Piotr? -- To view, visit https://gerrit.ovirt.org/62324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sos: replace dumpStorageTable with dump_volume_chains
Oved Ourfali has posted comments on this change. Change subject: sos: replace dumpStorageTable with dump_volume_chains .. Patch Set 3: Irit - can you answer Dan's comment? -- To view, visit https://gerrit.ovirt.org/62628 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73a85e6e720b61da1673af7161a21589ade79831 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marina Kalinin Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sd: Remove unused setMetadata
Oved Ourfali has posted comments on this change. Change subject: sd: Remove unused setMetadata .. Patch Set 10: Nir, please abandon this if it isn't needed anymore. -- To view, visit https://gerrit.ovirt.org/45613 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0906bfd7dfa128c323aa399810bbd75883618434 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Modify reports to metrics
Oved Ourfali has posted comments on this change. Change subject: Modify reports to metrics .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60450 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0aa10042b1c50fbdd94ae69053c74b57c3e6f40 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Modify reports to metrics
Oved Ourfali has posted comments on this change. Change subject: Modify reports to metrics .. Patch Set 2: We don't want to use the terminology "reports" at all here, as it confused with other reports mechanism we used to have. Please make sure this gets merged ASAP. Nir, we discussed it and we want to avoid the reports. I'll appreciate asking this on a short loop. If you don't like metrics alone, we can use metrics dispatching or metrics broadcasting. -- To view, visit https://gerrit.ovirt.org/60450 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0aa10042b1c50fbdd94ae69053c74b57c3e6f40 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.5]: jsonrpc: recovery error passed as response
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: recovery error passed as response .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/60138 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87ca49c91f1705abe55e044980442faf61b0ed22 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Oved Ourfali Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.5]: jsonrpc: recovery error passed as response
Hello Piotr Kliczewski, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60138
to review the following change.
Change subject: jsonrpc: recovery error passed as response
..
jsonrpc: recovery error passed as response
When we notice that vdsm is in recovery mode we return information about
recovery as result instead of returning error.
Backport-To: 4.0
Backport-To: 3.6
Backport-To: 3.5
Change-Id: I87ca49c91f1705abe55e044980442faf61b0ed22
Signed-off-by: Piotr Kliczewski
Signed-off-by: Oved Ourfali
Bug-Url: https://bugzilla.redhat.com/1352612
Reviewed-on: https://gerrit.ovirt.org/59948
Reviewed-by: Oved Ourfali
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani
---
M lib/yajsonrpc/__init__.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/60138/1
diff --git a/lib/yajsonrpc/__init__.py b/lib/yajsonrpc/__init__.py
index 029de4a..ca2c66f 100644
--- a/lib/yajsonrpc/__init__.py
+++ b/lib/yajsonrpc/__init__.py
@@ -484,7 +484,7 @@
if not self._cif.ready:
self.log.info("In recovery, ignoring '%s' in bridge with %s",
req.method, req.params)
-ctx.requestDone(JsonRpcResponse(errCode['recovery'], None, req.id))
+ctx.requestDone(None, JsonRpcResponse(errCode['recovery'], req.id))
return
protected_params = self._protected_params(req.method, req.params)
--
To view, visit https://gerrit.ovirt.org/60138
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I87ca49c91f1705abe55e044980442faf61b0ed22
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Oved Ourfali
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Piotr Kliczewski
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: [WIP]fencenode: split fenceNode into its own module
Oved Ourfali has posted comments on this change. Change subject: [WIP]fencenode: split fenceNode into its own module .. Patch Set 1: We need to separate it -- To view, visit https://gerrit.ovirt.org/43597 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bd5e7246cf6da21e355849014a8fc71d5edbde6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: jsonrpc: recovery error passed as response
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: recovery error passed as response .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/60006 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87ca49c91f1705abe55e044980442faf61b0ed22 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Oved Ourfali Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: jsonrpc: recovery error passed as response
Hello Piotr Kliczewski, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60006
to review the following change.
Change subject: jsonrpc: recovery error passed as response
..
jsonrpc: recovery error passed as response
When we notice that vdsm is in recovery mode we return information about
recovery as result instead of returning error.
Backport-To: 4.0
Backport-To: 3.6
Change-Id: I87ca49c91f1705abe55e044980442faf61b0ed22
Signed-off-by: Piotr Kliczewski
Signed-off-by: Oved Ourfali
Bug-Url: https://bugzilla.redhat.com/1350763
Reviewed-on: https://gerrit.ovirt.org/59948
Reviewed-by: Oved Ourfali
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani
---
M lib/yajsonrpc/__init__.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/60006/1
diff --git a/lib/yajsonrpc/__init__.py b/lib/yajsonrpc/__init__.py
index ec3b5ed..3f6c24b 100644
--- a/lib/yajsonrpc/__init__.py
+++ b/lib/yajsonrpc/__init__.py
@@ -515,7 +515,7 @@
self.log.info("In recovery, ignoring '%s' in bridge with %s",
req.method, req.params)
# TODO: take the response from the exception instead of via errCode
-ctx.requestDone(JsonRpcResponse(errCode['recovery'], None, req.id))
+ctx.requestDone(JsonRpcResponse(None, errCode['recovery'], req.id))
return
self.log.log(logLevel, "Calling '%s' in bridge with %s",
--
To view, visit https://gerrit.ovirt.org/60006
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I87ca49c91f1705abe55e044980442faf61b0ed22
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Oved Ourfali
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Piotr Kliczewski
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonrpc: recovery error passed as response
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: recovery error passed as response .. Patch Set 1: Verified+1 verified by QE and us. -- To view, visit https://gerrit.ovirt.org/59948 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87ca49c91f1705abe55e044980442faf61b0ed22 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonrpc: recovery error passed as response
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: recovery error passed as response .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59948 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87ca49c91f1705abe55e044980442faf61b0ed22 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Oved Ourfali Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: migration: usage of single reactor in vdsm
Oved Ourfali has posted comments on this change. Change subject: migration: usage of single reactor in vdsm .. Patch Set 5: We want this merged ASAP. Tests will be added in the future. Nir - can you merge? -- To view, visit https://gerrit.ovirt.org/59720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: client: use representation object
Oved Ourfali has posted comments on this change. Change subject: client: use representation object .. Patch Set 2: is it for 4.0 as well? -- To view, visit https://gerrit.ovirt.org/59827 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3492c104e726867dd75488a475202789277e8914 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdsm: return error when status cmd fail
Oved Ourfali has posted comments on this change. Change subject: vdsm: return error when status cmd fail .. Patch Set 3: should you retrigger the build? -- To view, visit https://gerrit.ovirt.org/57463 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b076349e01412ef9757e3b3346d1dc17183bf84 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Mesika Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: change python-yaml to PyYAML
Oved Ourfali has posted comments on this change. Change subject: spec: change python-yaml to PyYAML .. Patch Set 2: It would be nice to understand what's the origin (i.e., where does it happen exactly) to prevent future occurrences. -- To view, visit https://gerrit.ovirt.org/57286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee6210352befa657cfaf7e83e15d1abd262bed2c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: change python-yaml to PyYAML
Oved Ourfali has uploaded a new change for review.
Change subject: spec: change python-yaml to PyYAML
..
spec: change python-yaml to PyYAML
Seems like python-yaml is provided by PyYAML, and CI complains.
Change-Id: Iee6210352befa657cfaf7e83e15d1abd262bed2c
Signed-off-by: Oved Ourfali
---
M automation/check-merged.packages.fc23
M automation/check-patch.packages.fc23
M vdsm.spec.in
3 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/57286/1
diff --git a/automation/check-merged.packages.fc23
b/automation/check-merged.packages.fc23
index 56608d1..7c9334a 100644
--- a/automation/check-merged.packages.fc23
+++ b/automation/check-merged.packages.fc23
@@ -10,6 +10,7 @@
mom
openvswitch
policycoreutils-python
+PyYAML
python-blivet
python-coverage
python-devel
@@ -20,7 +21,6 @@
python-pthreading
python-rtslib
python-six
-python-yaml
python3-netaddr
python3-nose
python3-six
diff --git a/automation/check-patch.packages.fc23
b/automation/check-patch.packages.fc23
index d05bed4..b52cca6 100644
--- a/automation/check-patch.packages.fc23
+++ b/automation/check-patch.packages.fc23
@@ -8,6 +8,7 @@
mom
openvswitch
policycoreutils-python
+PyYAML
python-blivet
python-coverage
python-devel
@@ -17,7 +18,6 @@
python-nose
python-pthreading
python-six
-python-yaml
python3-netaddr
python3-nose
python3-six
diff --git a/vdsm.spec.in b/vdsm.spec.in
index cc95292..5559877 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -74,6 +74,7 @@
BuildRequires: openvswitch >= 2.0.0
BuildRequires: policycoreutils-python
BuildRequires: psmisc
+BuildRequires: PyYAML
BuildRequires: python-cpopen >= 1.4
BuildRequires: python-inotify
BuildRequires: python-ioprocess >= 0.15.0-4
@@ -81,7 +82,6 @@
BuildRequires: qemu-img
BuildRequires: rpm-python
BuildRequires: python-blivet
-BuildRequires: python-yaml
%if 0%{?with_python3}
%if 0%{?rhel}
@@ -112,6 +112,7 @@
Requires: xz
Requires: ntp
Requires: iproute >= 3.10.0
+Requires: PyYAML
Requires: python-netaddr
Requires: python-inotify
Requires: python-argparse
@@ -120,7 +121,6 @@
Requires: python-pthreading >= 0.1.3-3
Requires: python-six >= 1.9.0
Requires: python-requests
-Requires: python-yaml
Requires: %{name}-infra = %{version}-%{release}
Requires: rpm-python
Requires: nfs-utils
--
To view, visit https://gerrit.ovirt.org/57286
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee6210352befa657cfaf7e83e15d1abd262bed2c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Oved Ourfali has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 8: can it be merged? -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: set timeout to 10 mins
Oved Ourfali has posted comments on this change. Change subject: migration: set timeout to 10 mins .. Patch Set 4: Can we merge that? -- To view, visit https://gerrit.ovirt.org/51786 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c30f972af5d96541a20c168bb27a9b3536ff247 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: health: Introduce Vdsm health monitoring
Oved Ourfali has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 1: Code-Review+1
(1 comment)
Wait for Piotr/Yaniv to review, of course.
https://gerrit.ovirt.org/#/c/51708/1/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 428: 'false by default. Use environment file
/etc/sysconfig/vdsm to '
Line 429: 'set COVERAGE_PROCESS_START and COVERAGE_FILE
variables.'),
Line 430:
Line 431: ('health_monitor_enable', 'false',
Line 432: 'Enable Vdsm health monitoring.'),
s/Vdsm/VDSM, or consider just writing
Enable health monitoring.
Line 433:
Line 434: ('health_check_interval', '60',
Line 435: 'Number of seconds to wait between health checks.'),
Line 436:
--
To view, visit https://gerrit.ovirt.org/51708
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2abbd753118cb212a298055138087ca2e48ede91
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Oved Ourfali
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: set timeout to 10 mins
Oved Ourfali has posted comments on this change. Change subject: migration: set timeout to 10 mins .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51786 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c30f972af5d96541a20c168bb27a9b3536ff247 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: set timeout to 10 mins
Oved Ourfali has posted comments on this change. Change subject: migration: set timeout to 10 mins .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51786 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c30f972af5d96541a20c168bb27a9b3536ff247 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: Require safelease 1.0-6 for fedora 23 due to wrong build
Oved Ourfali has posted comments on this change. Change subject: Require safelease 1.0-6 for fedora 23 due to wrong build .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51377 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4a0e36f6da05b463b46d8c86be9b82bff78257c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: spec: remove leftover directories on host
Oved Ourfali has posted comments on this change. Change subject: spec: remove leftover directories on host .. Patch Set 1: as the relevent patch it merged on master, can this be merged as well? -- To view, visit https://gerrit.ovirt.org/49607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8230624958f0a195a6ee4124e9c6cbec4a85c4e3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Oved Ourfali has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 6: Douglas - can you elaborate? -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding compatibility for ovirt-engine 4.0 support
Oved Ourfali has posted comments on this change. Change subject: Adding compatibility for ovirt-engine 4.0 support .. Patch Set 2: the test issue is with: 14:51:28 FAIL: testEnablePromisc (ipwrapperTests.TestDrvinfo) 14:51:28 -- 14:51:28 Traceback (most recent call last): 14:51:28 File "/var/lib/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/ipwrapperTests.py", line 130, in testEnablePromisc 14:51:28 "Could not enable promiscuous mode.") 14:51:28 AssertionError: Could not enable promiscuous mode. @Dan - any clue? -- To view, visit https://gerrit.ovirt.org/49060 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0bf31758ad211f49582af4d6fb8b23adcd8b369 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding compatibility for ovirt-engine 4.0 support
Oved Ourfali has posted comments on this change. Change subject: Adding compatibility for ovirt-engine 4.0 support .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49060 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0bf31758ad211f49582af4d6fb8b23adcd8b369 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: adding compatibility for ovirt-engine 4.0 support
Oved Ourfali has posted comments on this change. Change subject: adding compatibility for ovirt-engine 4.0 support .. Patch Set 1: Who can merge this? -- To view, visit https://gerrit.ovirt.org/49060 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0bf31758ad211f49582af4d6fb8b23adcd8b369 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: adding compatibility for ovirt-engine 4.0 support
Oved Ourfali has posted comments on this change. Change subject: adding compatibility for ovirt-engine 4.0 support .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/49060/1/vdsm/dsaversion.py.in File vdsm/dsaversion.py.in: Line 39: '4.0' > but we do not support 4.0 clusterLevel yet... We have not even defined what This was discussed when we developed 3.6. In order to be able to develop properly, the engine must be able to accept hosts to the cluster. Otherwise you're forcing developers to do this change manually in order to developer, which, imo, is wrong. Please re-consider pushing that, to prevent wasting developers time on hacks. -- To view, visit https://gerrit.ovirt.org/49060 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0bf31758ad211f49582af4d6fb8b23adcd8b369 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: jsonrpc: executor based thread factory
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: executor based thread factory .. Patch Set 4: @Francesco - so should we merge it without CI? Or, is it in the works? -- To view, visit https://gerrit.ovirt.org/48293 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: jsonrpc: executor based thread factory
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: executor based thread factory .. Patch Set 2: bug created + commit message updated. -- To view, visit https://gerrit.ovirt.org/48293 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: jsonrpc: executor based thread factory
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: executor based thread factory .. Patch Set 2: any way to trigger CI? I don't see it running at all on this patch... -- To view, visit https://gerrit.ovirt.org/48293 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: init: run configure --force on upgrade from ovirt-3.5
Oved Ourfali has posted comments on this change. Change subject: init: run configure --force on upgrade from ovirt-3.5 .. Patch Set 2: No. It should be abandoned. Thanks for the quick response on this one. -- To view, visit https://gerrit.ovirt.org/48194 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9044d10dc5252f2407eccbbf82cd7589638b44ea Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6.0]: Adding call to configure passwd (libvirt sasl password)
Oved Ourfali has posted comments on this change. Change subject: Adding call to configure passwd (libvirt sasl password) .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied7346f8d6db0acd38c51bc68167bacbbba9c657 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6.0 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: Adding call to configure passwd (libvirt sasl password)
Oved Ourfali has posted comments on this change. Change subject: Adding call to configure passwd (libvirt sasl password) .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48232 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied7346f8d6db0acd38c51bc68167bacbbba9c657 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: Adding call to configure passwd (libvirt sasl password)
Oved Ourfali has posted comments on this change. Change subject: Adding call to configure passwd (libvirt sasl password) .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48232 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied7346f8d6db0acd38c51bc68167bacbbba9c657 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: init: configure multipath on upgrade from ovirt-3.5
Oved Ourfali has posted comments on this change. Change subject: init: configure multipath on upgrade from ovirt-3.5 .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/47941 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbebdebb6bda25606b20d91804977fa8eb7f13e8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: ssl: ssl socket may throw sslerror during reading
Oved Ourfali has posted comments on this change. Change subject: ssl: ssl socket may throw sslerror during reading .. Patch Set 2: Code-Review+1 As this is a backport, why do we need to wait? -- To view, visit https://gerrit.ovirt.org/47358 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8de60d91f81b08e9cb78df07f09d2bcc903c1bad Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: ssl socket may throw sslerror during reading
Oved Ourfali has posted comments on this change. Change subject: ssl: ssl socket may throw sslerror during reading .. Patch Set 2: do you understand the jenkins failure? -- To view, visit https://gerrit.ovirt.org/46625 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8de60d91f81b08e9cb78df07f09d2bcc903c1bad Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: ssl socket may throw sslerror during reading
Oved Ourfali has posted comments on this change. Change subject: ssl: ssl socket may throw sslerror during reading .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/46625 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8de60d91f81b08e9cb78df07f09d2bcc903c1bad Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: ssl socket may throw sslerror during reading
Oved Ourfali has posted comments on this change. Change subject: ssl: ssl socket may throw sslerror during reading .. Patch Set 1: Code-Review+1 Is this fix only for m2crypto? What about standard SSL module? -- To view, visit https://gerrit.ovirt.org/46625 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8de60d91f81b08e9cb78df07f09d2bcc903c1bad Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: vdsClient: parse no value arguments
Oved Ourfali has posted comments on this change. Change subject: vdsClient: parse no value arguments .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/46511 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I317cf2f9cfd83e2cb3f0c0f833350c3b95ebe7f1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator doesn't load pyc files under configurators folder
Oved Ourfali has posted comments on this change. Change subject: configurator doesn't load pyc files under configurators folder .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia529de0069e2f4ec168a4b9df82ba62c56d66730 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator doesn't load pyc files under configurators folder
Oved Ourfali has posted comments on this change. Change subject: configurator doesn't load pyc files under configurators folder .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia529de0069e2f4ec168a4b9df82ba62c56d66730 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator doesn't load pyc files under configurators folder
Oved Ourfali has posted comments on this change. Change subject: configurator doesn't load pyc files under configurators folder .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia529de0069e2f4ec168a4b9df82ba62c56d66730 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator doesn't load pyc files under configurators folder
Oved Ourfali has posted comments on this change. Change subject: configurator doesn't load pyc files under configurators folder .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia529de0069e2f4ec168a4b9df82ba62c56d66730 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator doesn't load pyc files under configurators folder
Oved Ourfali has posted comments on this change. Change subject: configurator doesn't load pyc files under configurators folder .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia529de0069e2f4ec168a4b9df82ba62c56d66730 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator doesn't load pyc files under configurators folder
Oved Ourfali has posted comments on this change.
Change subject: configurator doesn't load pyc files under configurators folder
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45846/1/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 57: filter_ = lambda x: not x.startswith('_')
Line 58:
Line 59: return [
Line 60: getmname(module)
Line 61: for module in iglob("%s*.py*" % path)
Is it an issue if both py and pyc are loaded?
In case of having a regular host.
Line 62: if filter_(getmname(module))
Line 63: ]
Line 64:
Line 65:
--
To view, visit https://gerrit.ovirt.org/45846
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia529de0069e2f4ec168a4b9df82ba62c56d66730
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Oved Ourfali has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 4: thanks for the clarification. -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Oved Ourfali has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Oved Ourfali has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 4: Yeela - can you verify? Can we merge this? -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: logging: remove log messages which give little or no value
Oved Ourfali has posted comments on this change. Change subject: logging: remove log messages which give little or no value .. Patch Set 2: can we make sure the master patch is merged, and also merge this one? -- To view, visit https://gerrit.ovirt.org/43262 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: remove log messages which give little or no value
Oved Ourfali has posted comments on this change. Change subject: logging: remove log messages which give little or no value .. Patch Set 1: can we merge this one? -- To view, visit https://gerrit.ovirt.org/43720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ssl: ssl protocol configurable
Oved Ourfali has posted comments on this change. Change subject: ssl: ssl protocol configurable .. Patch Set 3: can we merge this one? -- To view, visit https://gerrit.ovirt.org/43183 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb4889cb30f23c5e3e9221893cf07a02d051d8b5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Report librbd1 package details
Oved Ourfali has posted comments on this change.
Change subject: ceph: Report librbd1 package details
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/42717/1/vdsm/caps.py
File vdsm/caps.py:
Line 756: 'vdsm': ('vdsm',),
Line 757: 'spice-server': ('spice-server',),
Line 758: 'libvirt': ('libvirt', 'libvirt-daemon-kvm'),
Line 759: 'mom': ('mom',),
Line 760: 'librbd1': ('librbd1',),
> Can someone approve that Engine is comfortable with this form of reporting
I'm not sure.
However, I suggested Allon to use the features supported like gluster did,
instead of relying on package reporting.
Dan - what do you think about that?
Line 761: }
Line 762:
Line 763: if _glusterEnabled:
Line 764: KEY_PACKAGES.update(GLUSTER_RPM_PACKAGES)
--
To view, visit https://gerrit.ovirt.org/42717
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5fa4a2832e04e0782728660046fef5acfa7a27d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Oved Ourfali
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: fix to commit aff0ccd which catches el7 exception when sysv ...
Oved Ourfali has posted comments on this change. Change subject: fix to commit aff0ccd which catches el7 exception when sysv not exist .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41496 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fde015945a8327ad5ba40bc39a98c2390a5151c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: only write to stderr on plaintext connection given t...
Oved Ourfali has posted comments on this change. Change subject: vdscli: only write to stderr on plaintext connection given timeout .. Patch Set 2: -Code-Review yes. we will probably abandon this one, as the issue will be addressed in the hosted engine side, until the proper fix is in place. -- To view, visit https://gerrit.ovirt.org/41384 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief84241e6fe34c8b0f75522458c87c2a5cabaf40 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: only write to stderr on plaintext connection given t...
Oved Ourfali has posted comments on this change. Change subject: vdscli: only write to stderr on plaintext connection given timeout .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41384 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief84241e6fe34c8b0f75522458c87c2a5cabaf40 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool
Oved Ourfali has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 5: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/39823/5//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-04-27 05:47:13 -0400 Line 6: Line 7: Move passwd (set saslpassword for libvirt) to vdsm-tool Line 8: Line 9: In this patch we stop calling saslpassword command directly, don't know if whitespaces in commit message are allowed... Line 10: instead we move passwd logic to vdsm-tool configure. Line 11: with that patch after rpm installation user will need to call configure Line 12: to set the sasl libvirt password - therefore we remove those parts from spec, Line 13: and update the manual accordingly. -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: client: Add warning prompt on dangerous commands
Oved Ourfali has posted comments on this change. Change subject: client: Add warning prompt on dangerous commands .. Patch Set 2: Code-Review-1 I closed the bug as wontfix. Dima - please abandon. -- To view, visit https://gerrit.ovirt.org/28174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idea34ad7c3d5b66993bcb56b61e7edb0549ef9fb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: client: Add warning prompt on dangerous commands
Oved Ourfali has posted comments on this change. Change subject: client: Add warning prompt on dangerous commands .. Patch Set 2: Ping for storage review -- To view, visit https://gerrit.ovirt.org/28174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idea34ad7c3d5b66993bcb56b61e7edb0549ef9fb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introducing getAvailableUpdates API
Oved Ourfali has posted comments on this change.
Change subject: Introducing getAvailableUpdates API
..
Patch Set 9:
(2 comments)
https://gerrit.ovirt.org/#/c/38559/9/vdsm/API.py
File vdsm/API.py:
Line 1311: with open(constants.P_VDSM_LIB + 'updates.list', 'r') as
f:
Line 1312: updates = json.loads(f.read())
Line 1313:
Line 1314: for pkgInfo in updates:
Line 1315: if packages is None or pkgInfo['name'] in packages:
> how long is the expected list of packages? it may make sense to translate p
well, in the general use-case it may be long, but for what we plan for the host
upgrade manager it should be just a few.
Line 1316: info['updates'].append(pkgInfo)
Line 1317:
Line 1318: return {'status': doneCode, 'info': info}
Line 1319: except:
Line 1314: for pkgInfo in updates:
Line 1315: if packages is None or pkgInfo['name'] in packages:
Line 1316: info['updates'].append(pkgInfo)
Line 1317:
Line 1318: return {'status': doneCode, 'info': info}
> I think it would be good to report how old is the cache. If it's older than
Good idea, just in case it is highly out of date, although not sure we will
monitor that for now, but we can display it.
Line 1319: except:
Line 1320: self.log.error("failed to read update info",
exc_info=True)
Line 1321: return errCode['updateInfoErr']
Line 1322:
--
To view, visit https://gerrit.ovirt.org/38559
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d47d5395519fff4378ab7dd88b30c4766467427
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Moti Asayag
Gerrit-Reviewer: Oved Ourfali
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Hack to fix vdsm-tool import issues during upgrade
Oved Ourfali has posted comments on this change. Change subject: Hack to fix vdsm-tool import issues during upgrade .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39408 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Hack to fix vdsm-tool import issues during upgrade
Oved Ourfali has posted comments on this change. Change subject: Hack to fix vdsm-tool import issues during upgrade .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39408 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf3669b06b308399cb78866d72b592ac2d8b1732 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: json-rpc: fix the Host.getVMList return value
Oved Ourfali has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value .. Patch Set 1: Rerun-Hooks: all -- To view, visit https://gerrit.ovirt.org/38322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b8b2ed205385f4bdd341cdc576b44312c3fc117 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding support for cluster level 3.6
Oved Ourfali has posted comments on this change. Change subject: Adding support for cluster level 3.6 .. Patch Set 1: There are no engine tricks... People will just keep on doing the vdsm trick manually... -- To view, visit http://gerrit.ovirt.org/37384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16b1f27924cc617f8144356791c1890bb6546623 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lior Vernia Gerrit-Reviewer: Michael Burns Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding support for cluster level 3.6
Oved Ourfali has posted comments on this change. Change subject: Adding support for cluster level 3.6 .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16b1f27924cc617f8144356791c1890bb6546623 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lior Vernia Gerrit-Reviewer: Michael Burns Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: stomp: Make sure the \0 is read before slicing the buffer
Oved Ourfali has posted comments on this change. Change subject: stomp: Make sure the \0 is read before slicing the buffer .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/36806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6d7d25719f814b97ebd2cc4c33ff25dc32e1357 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: client: Add warning prompt on dangerous commands
Oved Ourfali has posted comments on this change. Change subject: client: Add warning prompt on dangerous commands .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idea34ad7c3d5b66993bcb56b61e7edb0549ef9fb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: regression on setupNetworks
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: regression on setupNetworks .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/36612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41c304d70f1040eac6a2098d8ab9734fd1115e61 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert "jsonrpc: Image_upload missing in command_info"
Oved Ourfali has posted comments on this change. Change subject: Revert "jsonrpc: Image_upload missing in command_info" .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/36534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3837c27bfbe2629c8959bf47a10ee72bcdec37cf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert "jsonrpc: Image_upload missing in command_info"
Oved Ourfali has reverted this change. Change subject: Revert "jsonrpc: Image_upload missing in command_info" .. Patch Set 2: Reverted This patchset was reverted in change: I3837c27bfbe2629c8959bf47a10ee72bcdec37cf -- To view, visit http://gerrit.ovirt.org/36534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: revert Gerrit-Change-Id: I3837c27bfbe2629c8959bf47a10ee72bcdec37cf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert "jsonrpc: Image_upload missing in command_info"
Oved Ourfali has uploaded a new change for review.
Change subject: Revert "jsonrpc: Image_upload missing in command_info"
..
Revert "jsonrpc: Image_upload missing in command_info"
This reverts commit 691a6f49b785b725439230a3f0bf55a9e71f539b.
Change-Id: I3837c27bfbe2629c8959bf47a10ee72bcdec37cf
Signed-off-by: Oved Ourfali
---
M vdsm/rpc/Bridge.py
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/36534/1
diff --git a/vdsm/rpc/Bridge.py b/vdsm/rpc/Bridge.py
index a42ff97..f8c06f6 100644
--- a/vdsm/rpc/Bridge.py
+++ b/vdsm/rpc/Bridge.py
@@ -423,7 +423,6 @@
'Image_deleteVolumes': {'ret': 'uuid'},
'Image_getVolumes': {'ret': 'uuidlist'},
'Image_download': {'ret': 'uuid'},
-'Image_upload': {'ret': 'uuid'},
'Image_mergeSnapshots': {'ret': 'uuid'},
'Image_move': {'ret': 'uuid'},
'Image_reconcileVolumeChain': {'ret': 'volumes'},
--
To view, visit http://gerrit.ovirt.org/36534
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3837c27bfbe2629c8959bf47a10ee72bcdec37cf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: Image_upload missing in command_info
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: Image_upload missing in command_info .. Patch Set 1: Rerun-Hooks: all -- To view, visit http://gerrit.ovirt.org/36516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79e28fed4caf3da5bdfefe030e4cfccb823d81d7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Oved Ourfali Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: Image_upload missing in command_info
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: Image_upload missing in command_info .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/36516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79e28fed4caf3da5bdfefe030e4cfccb823d81d7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Oved Ourfali Gerrit-Reviewer: Oved Ourfali Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: Image_upload missing in command_info
Oved Ourfali has uploaded a new change for review.
Change subject: jsonrpc: Image_upload missing in command_info
..
jsonrpc: Image_upload missing in command_info
Change-Id: I79e28fed4caf3da5bdfefe030e4cfccb823d81d7
Bug-Url: https://bugzilla.redhat.com/1177952
Signed-off-by: Oved Ourfali
---
M vdsm/rpc/Bridge.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/36516/1
diff --git a/vdsm/rpc/Bridge.py b/vdsm/rpc/Bridge.py
index 8600f5f..e4b12aa 100644
--- a/vdsm/rpc/Bridge.py
+++ b/vdsm/rpc/Bridge.py
@@ -418,6 +418,7 @@
'Image_deleteVolumes': {'ret': 'uuid'},
'Image_getVolumes': {'ret': 'uuidlist'},
'Image_download': {'ret': 'uuid'},
+'Image_upload': {'ret': 'uuid'},
'Image_mergeSnapshots': {'ret': 'uuid'},
'Image_move': {'ret': 'uuid'},
'Image_reconcileVolumeChain': {'ret': 'volumes'},
--
To view, visit http://gerrit.ovirt.org/36516
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I79e28fed4caf3da5bdfefe030e4cfccb823d81d7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Oved Ourfali
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Image_upload missing in command_info
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: Image_upload missing in command_info .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/36515 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79e28fed4caf3da5bdfefe030e4cfccb823d81d7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Image_upload missing in command_info
Oved Ourfali has uploaded a new change for review.
Change subject: jsonrpc: Image_upload missing in command_info
..
jsonrpc: Image_upload missing in command_info
Change-Id: I79e28fed4caf3da5bdfefe030e4cfccb823d81d7
Bug-Url: https://bugzilla.redhat.com/1177952
Signed-off-by: Oved Ourfali
---
M vdsm/rpc/Bridge.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/36515/1
diff --git a/vdsm/rpc/Bridge.py b/vdsm/rpc/Bridge.py
index f8c06f6..a42ff97 100644
--- a/vdsm/rpc/Bridge.py
+++ b/vdsm/rpc/Bridge.py
@@ -423,6 +423,7 @@
'Image_deleteVolumes': {'ret': 'uuid'},
'Image_getVolumes': {'ret': 'uuidlist'},
'Image_download': {'ret': 'uuid'},
+'Image_upload': {'ret': 'uuid'},
'Image_mergeSnapshots': {'ret': 'uuid'},
'Image_move': {'ret': 'uuid'},
'Image_reconcileVolumeChain': {'ret': 'volumes'},
--
To view, visit http://gerrit.ovirt.org/36515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I79e28fed4caf3da5bdfefe030e4cfccb823d81d7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: StoragePool_getDomainsContainingImage
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: StoragePool_getDomainsContainingImage .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4bcca37ffa5e35636606c0d0cf0c4218068a833 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: StoragePool_removeVM
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: StoragePool_removeVM .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16acb11982e70ff7f8a05ac816d36b2aa34caea0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: StoragePool_updateVMs
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: StoragePool_updateVMs .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26f7011b633c289f0d36bfd987f9392d2edf10f8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: VM_getDiskAlignment
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: VM_getDiskAlignment .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35550 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5b42a756c3171d5317df70e197ccc0809a37ecf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: VM_setCpuTunePeriod
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: VM_setCpuTunePeriod .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac8159c951bb9b85914a51e78e9678c2918097b6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: VM_setIoTune
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: VM_setIoTune .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35554 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a4827dd6dac84eed0430ee6e433f1b0b403dd81 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: VM_snapshot
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: VM_snapshot .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/3 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8af5bf7d0b15e98ad1352bffe3ee41ef2bccbe2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: VM_updateVmPolicy
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: VM_updateVmPolicy .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39c3e0a675b0574c25a2602f672ed6a36a05547c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: VM_setCpuTuneQuota
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: VM_setCpuTuneQuota .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I397d12419ff1e108c57ad6098f7ca1be5ef44711 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: Wrong key name for getDevicesVisibility
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: Wrong key name for getDevicesVisibility .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35306 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63180a87e40e48134e6da8b9996f849362fb5501 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: diskSizeExtend missing in command_info
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: diskSizeExtend missing in command_info .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35229 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I099b83defd9fc3f0280ddeb28f3c4b706f8998c2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: ssl: accept_ssl needs to close socket
Oved Ourfali has posted comments on this change. Change subject: ssl: accept_ssl needs to close socket .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e521db78bf35334ad3bbfafd8396401924d254f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: diskSizeExtend missing in command_info
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: diskSizeExtend missing in command_info .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I099b83defd9fc3f0280ddeb28f3c4b706f8998c2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: diskSizeExtend missing in command_info
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: diskSizeExtend missing in command_info .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I099b83defd9fc3f0280ddeb28f3c4b706f8998c2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: diskSizeExtend missing in command_info
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: diskSizeExtend missing in command_info .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I099b83defd9fc3f0280ddeb28f3c4b706f8998c2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: cannot put link down on vNIC
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: cannot put link down on vNIC .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81bd4fccdbb64594ed4592fed6b84b6fb07b357b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: Bridge.py reducing logging level
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: Bridge.py reducing logging level .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34397 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69caf6ce30746ee3e8e843de8dcdddb793c55e2b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: protocol_acceptor: Make SSL handshake asynchronous
Oved Ourfali has posted comments on this change. Change subject: protocol_acceptor: Make SSL handshake asynchronous .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8808633344389297fe026cd2219aa513f6f1dff Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Bridge.py reducing logging level
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: Bridge.py reducing logging level .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69caf6ce30746ee3e8e843de8dcdddb793c55e2b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: default args values in wrong order
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: default args values in wrong order .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33861 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e256468833851cd4ce866297de916332a560f2f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: ssl: ssl_accept blocks after reboot
Oved Ourfali has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
