Oved Ourfali has posted comments on this change. Change subject: adding compatibility for ovirt-engine 4.0 support ......................................................................
Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/49060/1/vdsm/dsaversion.py.in File vdsm/dsaversion.py.in: Line 39: '4.0' > but we do not support 4.0 clusterLevel yet... We have not even defined what This was discussed when we developed 3.6. In order to be able to develop properly, the engine must be able to accept hosts to the cluster. Otherwise you're forcing developers to do this change manually in order to developer, which, imo, is wrong. Please re-consider pushing that, to prevent wasting developers time on hacks. -- To view, visit https://gerrit.ovirt.org/49060 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0bf31758ad211f49582af4d6fb8b23adcd8b369 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
