Change in vdsm[master]: localFsSD: Use the right manifest.

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: localFsSD: Use the right manifest.
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/53688
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I482511290032cad3813e5c8b85b59d2369da2e90
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: new functional tests for vdsm storage

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: tests: new functional tests for vdsm storage
..


Patch Set 9: Code-Review-1

-- 
To view, visit http://gerrit.ovirt.org/32496
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1703e7c1dc223ff707775865cd14c7dd62314caf
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: introducing whitebox tests

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: tests: introducing whitebox tests
..


Patch Set 5: Code-Review-1

-- 
To view, visit http://gerrit.ovirt.org/29745
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e20d17c3ebee1203bb5a721ce44d5867570ce8e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: use 'localhost' explicitly in test

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: tests: use 'localhost' explicitly in test
..


Patch Set 1: Code-Review-1

-- 
To view, visit http://gerrit.ovirt.org/28107
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89990cff46e64120262e250eee9238b49c4edee4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: new functional tests for vdsm storage

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: tests: new functional tests for vdsm storage
..


Patch Set 6: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/32496
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1703e7c1dc223ff707775865cd14c7dd62314caf
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Do Not Merge!!!

[vvolansk]

Vered Volansky has abandoned this change.

Change subject: Do Not Merge!!!
..


Abandoned

-- 
To view, visit http://gerrit.ovirt.org/28854
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I59cb914122b1f6c42a11a2f303f15d00c74892c3
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Testing storageTest.py as CI job. Do NOT MERGE!

[vvolansk]

Vered Volansky has abandoned this change.

Change subject: Testing storageTest.py as CI job. Do NOT MERGE!
..


Abandoned

-- 
To view, visit http://gerrit.ovirt.org/23343
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I4d0caab1749e075f3650c91161b473e66b19977d
Gerrit-PatchSet: 35
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Ohad Basan oba...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: revived forgotten test

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: tests: revived forgotten test
..


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/29780
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a847e83046ea12596076fabaa42baba6939e1cd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: alignmentScanTests.py is a functional test

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: tests: alignmentScanTests.py is a functional test
..


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/29745
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e20d17c3ebee1203bb5a721ce44d5867570ce8e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Tests: log actual exceptions in RollbackContext

[vvolansk]

Vered Volansky has abandoned this change.

Change subject: Tests: log actual exceptions in RollbackContext
..


Abandoned

Too much of a hassle for a small detour improvement.

-- 
To view, visit http://gerrit.ovirt.org/28175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I3e8244f2b6ede47967025eb35e54ee2401fec30b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utilsTests: Styling of RollbackContextTests

[vvolansk]

Vered Volansky has abandoned this change.

Change subject: utilsTests: Styling of RollbackContextTests
..


Abandoned

Too much of a hassle for a small detour improvement.

-- 
To view, visit http://gerrit.ovirt.org/22886
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I877f65569f4304bdd4160bb9f84facf261e568e8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: logs: improve VDSM logs human-readability

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: logs: improve VDSM logs human-readability
..


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/28869/4/vdsm/logger.conf.in
File vdsm/logger.conf.in:

Line 66: [formatter_none]
Line 67: format: %(message)s
Line 68: 
Line 69: [formatter_long]
Line 70: format: %(asctime)s %(levelname)s %(threadName)s [%(name)s 
::%(module)s in function %(funcName)s %(pathname)s:%(lineno)d]: %(message)s
 I think this is a good improvement and I like more than the old format.
Only redundant if you know the location of each module by heart. Sure, you can 
look it up, but why?
Line 71: 
Line 72: [formatter_sysform]
Line 73: format= vdsm %(name)s %(levelname)s %(message)s
Line 74: datefmt=


-- 
To view, visit http://gerrit.ovirt.org/28869
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65fcc843b4c2c6f1b0f438937a0702b80b714978
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Liron Aravot lara...@redhat.com
Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com
Gerrit-Reviewer: Marina Kalinin marina...@gmail.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: logs: improve VDSM logs human-readability

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: logs: improve VDSM logs human-readability
..


Patch Set 3: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/28869
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65fcc843b4c2c6f1b0f438937a0702b80b714978
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Liron Aravot lara...@redhat.com
Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com
Gerrit-Reviewer: Marina Kalinin marina...@gmail.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: logs: improve VDSM logs human-readability

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: logs: improve VDSM logs human-readability
..


Patch Set 4: Code-Review+1

Although this patch is now reduced to de facto changing the delimeter from :: 
to space, I'm in favor. The current log is just a bulk of data, making the 
human reader actively search for the double-colons in order to read it. With 
spaces instead, the mind makes the field separation automatically. On the one 
hand, double colon was retained before the module name so it doesn't bother 
searches, and on the other, a space was added for clear human readability.

-- 
To view, visit http://gerrit.ovirt.org/28869
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65fcc843b4c2c6f1b0f438937a0702b80b714978
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Liron Aravot lara...@redhat.com
Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com
Gerrit-Reviewer: Marina Kalinin marina...@gmail.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: clarify that scsiKey parameter is not passed on

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: clarify that scsiKey parameter is not passed on
..


Patch Set 4: Code-Review-1

Just fix the typo, after all, it is API doc...

-- 
To view, visit http://gerrit.ovirt.org/28560
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Do Not Merge!!!

[vvolansk]

Vered Volansky has uploaded a new change for review.

Change subject: Do Not Merge!!!
..

Do Not Merge!!!

checking a CI jobs with this test.

Change-Id: I59cb914122b1f6c42a11a2f303f15d00c74892c3
Signed-off-by: Vered Volansky vvola...@redhat.com
---
M tests/functional/storageTests.py
M vdsm/virt/vm.py
2 files changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/28854/1

diff --git a/tests/functional/storageTests.py b/tests/functional/storageTests.py
index 80ba312..cad4096 100644
--- a/tests/functional/storageTests.py
+++ b/tests/functional/storageTests.py
@@ -1,4 +1,5 @@
-#
+la la la
+
 # Copyright 2012 Red Hat, Inc.
 #
 # This program is free software; you can redistribute it and/or modify
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 6c42089..eb99c6e 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1,4 +1,4 @@
-#
+# la la la
 # Copyright 2008-2014 Red Hat, Inc.
 #
 # This program is free software; you can redistribute it and/or modify


-- 
To view, visit http://gerrit.ovirt.org/28854
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I59cb914122b1f6c42a11a2f303f15d00c74892c3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Do Not Merge!!!

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: Do Not Merge!!!
..


Patch Set 2: Verified-1

-- 
To view, visit http://gerrit.ovirt.org/28854
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59cb914122b1f6c42a11a2f303f15d00c74892c3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utilsTests: Styling of RollbackContextTests

[vvolansk]

Vered Volansky has restored this change.

Change subject: utilsTests: Styling of RollbackContextTests
..


Restored

Back to being relevant. Storage functional tests context.

-- 
To view, visit http://gerrit.ovirt.org/22886
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: I877f65569f4304bdd4160bb9f84facf261e568e8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Tests: log actual exceptions in RollbackContext

[vvolansk]

Vered Volansky has uploaded a new change for review.

Change subject: Tests: log actual exceptions in RollbackContext
..

Tests: log actual exceptions in RollbackContext

When a wrong exception is thrown, the alert to this fact now contains
the actual exception that's been raised.

Change-Id: I3e8244f2b6ede47967025eb35e54ee2401fec30b
Signed-off-by: Vered Volansky vvola...@redhat.com
---
M tests/utilsTests.py
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/28175/1

diff --git a/tests/utilsTests.py b/tests/utilsTests.py
index b799ee9..a7bfd60 100644
--- a/tests/utilsTests.py
+++ b/tests/utilsTests.py
@@ -407,8 +407,8 @@
 except RuntimeError:
 self.assertEquals(self._called, 3)
 return
-except Exception:
-self.fail(Wrong exception was raised)
+except Exception as e:
+self.fail(Wrong exception was raised - %s % e)
 
 self.fail(Exception was not raised)
 
@@ -422,8 +422,8 @@
 {}['aKey']
 except KeyError:
 pass
-except Exception:
-self.fail(Wrong exception was raised)
+except Exception as e:
+self.fail(Wrong exception was raised - %s % e)
 else:
 self.fail(Exception was not raised)
 
@@ -444,8 +444,8 @@
 except self.UndoException:
 self.fail(Wrong exception was raised - from undo function. \
 should have re-raised OriginalException)
-except Exception:
-self.fail(Wrong exception was raised)
+except Exception as e:
+self.fail(Wrong exception was raised - %s % e)
 else:
 self.fail(Exception was not raised)
 


-- 
To view, visit http://gerrit.ovirt.org/28175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e8244f2b6ede47967025eb35e54ee2401fec30b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utilsTests: Styling of RollbackContextTests

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: utilsTests: Styling of RollbackContextTests
..


Patch Set 6:

Addressed Nir's comment. Another patch follows.

-- 
To view, visit http://gerrit.ovirt.org/22886
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I877f65569f4304bdd4160bb9f84facf261e568e8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: fix wrong use of assertions

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: tests: fix wrong use of assertions
..


Patch Set 4: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/28124
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I693923e6dcaa05bc1479db814c0b7696b3536c9c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: fix wrong use of assertions

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: tests: fix wrong use of assertions
..


Patch Set 1:

(3 comments)

http://gerrit.ovirt.org/#/c/28124/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: tests: fix wrong use of assertions
Line 8: 
Line 9: Previously, the test used assertEquals for checking return code of
Line 10: subprocesses spawned by the test itself. This resulted in a resported
s/resported/reported
Line 11: test failure, when it should have reported an error.
Line 12: 
Line 13: To fix this, I replaced execCmd which does not belong in test code (we
Line 14: should not use the vdsm code to write tests that check vdsm) with a new


Line 9: Previously, the test used assertEquals for checking return code of
Line 10: subprocesses spawned by the test itself. This resulted in a resported
Line 11: test failure, when it should have reported an error.
Line 12: 
Line 13: To fix this, I replaced execCmd which does not belong in test code (we
Please add comma after execCmd.
Line 14: should not use the vdsm code to write tests that check vdsm) with a new
Line 15: testrunner.runCommand which is easier to use, and simplified the test.
Line 16: 
Line 17: Change-Id: I693923e6dcaa05bc1479db814c0b7696b3536c9c


http://gerrit.ovirt.org/#/c/28124/1/tests/testrunner.py
File tests/testrunner.py:

Line 36: 
Line 37: 
Line 38: class TestRunnerError(Exception):
Line 39: 
Line 40: This is an error in the test itself (e.g. could not cleanup some 
temproray
s/temproray/temporary
Line 41: file).  It is not an error in the tested code.
Line 42: 
Line 43: 
Line 44: 


-- 
To view, visit http://gerrit.ovirt.org/28124
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I693923e6dcaa05bc1479db814c0b7696b3536c9c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Testing storageTest.py as CI job. Do NOT MERGE!

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: Testing storageTest.py as CI job. Do NOT MERGE!
..


Patch Set 35:

This is a debug patch that is still in need.

-- 
To view, visit http://gerrit.ovirt.org/23343
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d0caab1749e075f3650c91161b473e66b19977d
Gerrit-PatchSet: 35
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Ohad Basan oba...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Use testrunner.TEMPDIR

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: tests: Use testrunner.TEMPDIR
..


Patch Set 1: Code-Review+1

(1 comment)

Just fix commit message please before merge.

http://gerrit.ovirt.org/#/c/27503/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: tests: Use testrunner.TEMPDIR
Line 8: 
Line 9: Storage functional tests used to define their own temporary directory
Line 10: path. Use now the testrunner default.
s/Use now/They now use
Line 11: 
Line 12: Change-Id: Ib3a8047ef0f5d4fdccf79b5000b5385f371f4db8


-- 
To view, visit http://gerrit.ovirt.org/27503
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3a8047ef0f5d4fdccf79b5000b5385f371f4db8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yoav Kleinberger yklei...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Misc storage exception class name style

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: Misc storage exception class name style
..


Patch Set 4:

For what it's worth, verified storage functional tests -localfs and nfs only, 
versions 0 and 3 on RHEL 3.4 .

-- 
To view, visit http://gerrit.ovirt.org/8847
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f6f279d13b92bbb8f573a0d772d7504860bbbe3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stroageTests.py: Call detachStorageDomain on rollback

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: stroageTests.py: Call detachStorageDomain on rollback
..


Patch Set 4:

Updated commit message.
Will change ugly lambda usage in a different patch for the entire file.

-- 
To view, visit http://gerrit.ovirt.org/23725
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I943c117b36ac3dd6ccba1e195853b53d83df43c8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stroageTests.py: Call detachStorageDomain on rollback

[vvolansk]

Vered Volansky has uploaded a new change for review.

Change subject: stroageTests.py: Call detachStorageDomain on rollback
..

stroageTests.py: Call detachStorageDomain on rollback

vdsClient.deactivateStorageDomain() should be called as
vdsClient.activateStorageDomain() 's rollback.

Change-Id: I943c117b36ac3dd6ccba1e195853b53d83df43c8
Signed-off-by: Vered Volansky vvola...@redhat.com
---
M tests/functional/storageTests.py
1 file changed, 8 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/23725/1

diff --git a/tests/functional/storageTests.py b/tests/functional/storageTests.py
index 91f43a9..d87cb76 100644
--- a/tests/functional/storageTests.py
+++ b/tests/functional/storageTests.py
@@ -197,13 +197,19 @@
 if sdid != storagePools[poolid]['master_uuid']:
 r = self.s.attachStorageDomain(sdid, poolid)
 self.assertVdsOK(r)
-undo = lambda sdid=sdid, poolid=poolid: \
+undo1 = lambda sdid=sdid, poolid=poolid: \
 self.assertVdsOK(
 self.s.detachStorageDomain(
 sdid, poolid, storage.sd.BLANK_UUID,
 storagePools[poolid]['master_ver']))
-rollback.prependDefer(undo)
+rollback.prependDefer(undo1)
 r = self.s.activateStorageDomain(sdid, poolid)
+undo2 = lambda sdid=sdid, poolid=poolid: \
+self.assertVdsOK(
+self.s.deactivateStorageDomain(
+sdid, poolid, storage.sd.BLANK_UUID,
+storagePools[poolid]['master_ver']))
+rollback.prependDefer(undo2)
 self.assertVdsOK(r)
 
 r = self.s.getVdsStats()


-- 
To view, visit http://gerrit.ovirt.org/23725
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I943c117b36ac3dd6ccba1e195853b53d83df43c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stroageTests.py: Call detachStorageDomain on rollback

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: stroageTests.py: Call detachStorageDomain on rollback
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/23725
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I943c117b36ac3dd6ccba1e195853b53d83df43c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changing vdsm-tool and vdsmd pre-tasks outputs to be more me...

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: Changing vdsm-tool and vdsmd pre-tasks outputs to be more 
meaningful to user
..


Patch Set 2: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/23253/2/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 248: if not ret:
Line 249: msg = \
Line 250: 
Line 251: 
Line 252: One of the modules is not configured to VDSM.
Didn't address my comment... - s/to/with
Line 253: To configure the module use the following:
Line 254: 'vdsm-tool configure [module_name]'.
Line 255: 
Line 256: If all modules are not configured try to use:


-- 
To view, visit http://gerrit.ovirt.org/23253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If29f41081a70c0734cd78dab36f86c794a44b2d3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changing vdsm-tool and vdsmd pre-tasks outputs to be more me...

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: Changing vdsm-tool and vdsmd pre-tasks outputs to be more 
meaningful to user
..


Patch Set 3: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/23253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If29f41081a70c0734cd78dab36f86c794a44b2d3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storageTests: Configure via environment variables

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: storageTests: Configure via environment variables
..


Patch Set 4: Verified+1

Amended according to reviews.

-- 
To view, visit http://gerrit.ovirt.org/23259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84f1ee57e43d921ae38afaabddecca9f38dd2687
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changing vdsm-tool and vdsmd pre-tasks outputs to be more me...

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: Changing vdsm-tool and vdsmd pre-tasks outputs to be more 
meaningful to user
..


Patch Set 1: Verified+1 Code-Review+1

(3 comments)

*Great* patch. Usage is soo much better now.

http://gerrit.ovirt.org/#/c/23253/1//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2014-01-14 18:09:31 +0200
Line 6: 
Line 7: Changing vdsm-tool and vdsmd pre-tasks outputs to be more meaningful to 
user
Line 8: 
Line 9: Previously to this changes the output was misleading. Users
/this/these
Line 10: could not understand how to handle configuration issues properly.
Line 11: 
Line 12: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1029812
Line 13: Change-Id: If29f41081a70c0734cd78dab36f86c794a44b2d3


http://gerrit.ovirt.org/#/c/23253/1/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 247: 
Line 248: if not ret:
Line 249: msg = \
Line 250: 
Line 251: 
Is there a redundant empty line here or is it just gerrit?
Line 252: One of the modules is not configured to VDSM.
Line 253: To configure the module use the following:
Line 254: 'vdsm-tool configure [module_name]'.
Line 255: 


Line 248: if not ret:
Line 249: msg = \
Line 250: 
Line 251: 
Line 252: One of the modules is not configured to VDSM.
/to/with
Line 253: To configure the module use the following:
Line 254: 'vdsm-tool configure [module_name]'.
Line 255: 
Line 256: If all modules are not configured try to use:


-- 
To view, visit http://gerrit.ovirt.org/23253
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If29f41081a70c0734cd78dab36f86c794a44b2d3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: testing storageTest.py as CI job.

[vvolansk]

Vered Volansky has uploaded a new change for review.

Change subject: testing storageTest.py as CI job.
..

testing storageTest.py as CI job.

Change-Id: I4d0caab1749e075f3650c91161b473e66b19977d
Signed-off-by: Vered Volansky vvola...@redhat.com
---
M vdsm/storage/sp.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/23343/1

diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index 0bab95d..0cb7164 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -1,6 +1,7 @@
 #
 # Copyright 2009-2011 Red Hat, Inc.
 #
+#
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
 # the Free Software Foundation; either version 2 of the License, or


-- 
To view, visit http://gerrit.ovirt.org/23343
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d0caab1749e075f3650c91161b473e66b19977d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: testing storageTest.py as CI job.

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: testing storageTest.py as CI job.
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/23343
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d0caab1749e075f3650c91161b473e66b19977d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storageTests: Extract storage types and versions to an envir...

[vvolansk]

Vered Volansky has uploaded a new change for review.

Change subject: storageTests: Extract storage types and versions to an 
environment variable
..

storageTests: Extract storage types and versions to an environment variable

These are used as permutations for the test. We want to automate the
test and call it with whatever storage type(s) and metadata
version(s).

Change-Id: I84f1ee57e43d921ae38afaabddecca9f38dd2687
Signed-off-by: Vered Volansky vvola...@redhat.com
---
M tests/functional/storageTests.py
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/23259/1

diff --git a/tests/functional/storageTests.py b/tests/functional/storageTests.py
index 39102e5..4618ef9 100644
--- a/tests/functional/storageTests.py
+++ b/tests/functional/storageTests.py
@@ -58,6 +58,11 @@
 )
 _exportfs = CommandPath(exportfs, /usr/sbin/exportfs)
 
+defaultStorageTypes = ('localfs', 'iscsi', 'glusterfs', 'nfs')
+storageTypes = tuple(os.environ.get('VDSM_STORAGE_TEST_TYPES', '').split()) or 
defaultStorageTypes
+
+defaultVersions = (0, 3)
+versions = tuple(os.environ.get('VDSM_METADATA_VERSION', '').split()) or 
defaultVersions
 
 @expandPermutations
 class StorageTest(TestCaseBase):
@@ -81,8 +86,8 @@
 
 @permutations(
 [[backend, ver]
- for backend in ['localfs', 'iscsi', 'glusterfs', 'nfs']
- for ver in [0, 3]])
+ for backend in storageTypes
+ for ver in versions]) 
 def testStorage(self, backendType, domVersion):
 conf = storageLayouts[backendType]
 with RollbackContext() as rollback:


-- 
To view, visit http://gerrit.ovirt.org/23259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I84f1ee57e43d921ae38afaabddecca9f38dd2687
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storageTests: Extract storage types and versions to an envir...

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: storageTests: Extract storage types and versions to an 
environment variable
..


Patch Set 2: Verified+1

Storage type localfs is verified with versions 0 and 3.
We want to add it as a CI job, currently ONLY with the above verified 
configuration.

-- 
To view, visit http://gerrit.ovirt.org/23259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84f1ee57e43d921ae38afaabddecca9f38dd2687
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storageTests: Extract storage types and versions to an envir...

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: storageTests: Extract storage types and versions to an 
environment variable
..


Patch Set 3: Verified+1

Addressed comments from previous patch. Verified in the same manner.

-- 
To view, visit http://gerrit.ovirt.org/23259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84f1ee57e43d921ae38afaabddecca9f38dd2687
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: misc: Fix exception re-raising in RollbackContext

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: misc: Fix exception re-raising in RollbackContext
..


Patch Set 8: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/22860
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0052717e2307ad6fec2225b3ad5f438c5a60e1c6
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: misc: Fix exception re-raising in RollbackContext

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: misc: Fix exception re-raising in RollbackContext
..


Patch Set 8:

Zhou, Nir, thanks for the reviews.
I'll add a patch according to Nir's last comments later on.

-- 
To view, visit http://gerrit.ovirt.org/22860
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0052717e2307ad6fec2225b3ad5f438c5a60e1c6
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: misc: Fix exception re-raising in RollbackContext

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: misc: Fix exception re-raising in RollbackContext
..


Patch Set 9: Verified+1

Rebased, addressed Nir's comments.

-- 
To view, visit http://gerrit.ovirt.org/22860
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0052717e2307ad6fec2225b3ad5f438c5a60e1c6
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utils: Moved RollbackContext from misc to utils

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: utils: Moved RollbackContext from misc to utils
..


Patch Set 10: Verified+1

Rebased.

-- 
To view, visit http://gerrit.ovirt.org/22861
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I985103650a5706d35d9cd519618d09c692feb0be
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utils: cleanup - typos, grammar and comments refinement

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: utils: cleanup - typos, grammar and comments refinement
..


Patch Set 11: Verified+1

Rebased.

-- 
To view, visit http://gerrit.ovirt.org/22862
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04a1c4d444f2604b66b44bb9deac7d780db04aaf
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utils: Moved RollbackContext from misc to utils

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: utils: Moved RollbackContext from misc to utils
..


Patch Set 11: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/22861
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I985103650a5706d35d9cd519618d09c692feb0be
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utils: cleanup - typos, grammar and comments refinement

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: utils: cleanup - typos, grammar and comments refinement
..


Patch Set 12: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/22862
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04a1c4d444f2604b66b44bb9deac7d780db04aaf
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utilsTests: Styling of RollbackContextTests

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: utilsTests: Styling of RollbackContextTests
..


Patch Set 5: Verified+1

Rebased.

-- 
To view, visit http://gerrit.ovirt.org/22886
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I877f65569f4304bdd4160bb9f84facf261e568e8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: do not check permissions on dos filesystem

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: tests: do not check permissions on dos filesystem
..


Patch Set 1: Verified+1 Code-Review+1

Verified on a RHEL 6.4 host.

-- 
To view, visit http://gerrit.ovirt.org/22816
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c14b3cc0538e2f8b09ea99a185ec86e067217f6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utils: Moved RollbackContext from misc to utils

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: utils: Moved RollbackContext from misc to utils
..


Patch Set 3:

(3 comments)


Commit Message
Line 7: utils: Moved RollbackContext from misc to utils
Line 8: 
Line 9: The RollbackContext class was located in storage/misc, and is used by
Line 10: several non-storage tests. It was therefore moved to utils, where it
Line 11: belongs. Accordingly, ContextManagerTests class was moved to utilsTests
Done
Line 12: from miscTests.
Line 13: 
Line 14: Change-Id: I985103650a5706d35d9cd519618d09c692feb0be



File lib/vdsm/utils.py
Line 1091: def undoStep2(arg): pass
Line 1092: step2()
Line 1093: rollback.prependDefer(undoStep2, arg)
Line 1094: 
Line 1095: More examples see tests/miscTests.py
Done
Line 1096: '''
Line 1097: def __init__(self, *args):
Line 1098: self._finally = []
Line 1099: 



File vdsm/storage/resourceManager.py
Line 28: 
Line 29: import storage_exception as se
Line 30: import misc
Line 31: from logUtils import SimpleLogAdapter
Line 32: from vdsm.utils import RollbackContext
Done
Line 33: 
Line 34: 
Line 35: # Errors
Line 36: 


-- 
To view, visit http://gerrit.ovirt.org/22861
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I985103650a5706d35d9cd519618d09c692feb0be
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utils: cleanup - typos, grammar and comments refinement

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: utils: cleanup - typos, grammar and comments refinement
..


Patch Set 4:

(2 comments)


File lib/vdsm/utils.py
Line 55: 
Line 56: from cpopen import CPopen
Line 57: from . import constants
Line 58: 
Line 59: # Buffsize is 1K because it was tested on some use cases and 1K was 
fastest. If
LOL, will remove
Line 60: # you find this number to be a bottleneck in any way you are welcome 
to change
Line 61: # it
Line 62: BUFFSIZE = 1024
Line 63: 


Line 982: Returns the result as a tuple of (result, error).
Line 983: If the operation is still running it will block until it 
returns.
Line 984: 
Line 985: If no resultParser has been set the default result
Line 986: is (rc, out, err) 
yep, that wasn't supposed to be so.
Line 987: with self._lock:
Line 988: if self._result is None:
Line 989: out, err = self._proc.communicate()
Line 990: rc = self._proc.returncode


-- 
To view, visit http://gerrit.ovirt.org/22862
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04a1c4d444f2604b66b44bb9deac7d780db04aaf
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: misc: Fix exception re-rasing in RollbackContext

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: misc: Fix exception re-rasing in RollbackContext
..


Patch Set 3:

(3 comments)


File tests/miscTests.py
Line 1140: self.fail(Wrong exception was raised)
Line 1141: 
Line 1142: self.fail(Exception was not raised)
Line 1143: 
Line 1144: def testKeyErrorException(self):
Done
Line 1145: 
Line 1146: KeyError is raised as a tuple and not expection. Re-rasing it
Line 1147: should be aware of this fact and handled carfully.
Line 1148: 


Line 1142: self.fail(Exception was not raised)
Line 1143: 
Line 1144: def testKeyErrorException(self):
Line 1145: 
Line 1146: KeyError is raised as a tuple and not expection. Re-rasing it
Done
Line 1147: should be aware of this fact and handled carfully.
Line 1148: 
Line 1149: try:
Line 1150: with misc.RollbackContext():


Line 1153: return
Line 1154: except Exception:
Line 1155: self.fail(Wrong exception was raised)
Line 1156: 
Line 1157: self.fail(Exception was not raised)
I prefer to do it in another patch.
Line 1158: 
Line 1159: 
Line 1160: class FindCallerTests(TestCaseBase):
Line 1161: def _assertFindCaller(self, callback):


-- 
To view, visit http://gerrit.ovirt.org/22860
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0052717e2307ad6fec2225b3ad5f438c5a60e1c6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: misc: Fix exception re-raising in RollbackContext

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: misc: Fix exception re-raising in RollbackContext
..


Patch Set 5: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/22860
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0052717e2307ad6fec2225b3ad5f438c5a60e1c6
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utils: Moved RollbackContext from misc to utils

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: utils: Moved RollbackContext from misc to utils
..


Patch Set 6: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/22861
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I985103650a5706d35d9cd519618d09c692feb0be
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utils: cleanup - typos, grammar and comments refinement

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: utils: cleanup - typos, grammar and comments refinement
..


Patch Set 7: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/22862
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04a1c4d444f2604b66b44bb9deac7d780db04aaf
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utilsTests: Avoiding returning in the middle of the method

[vvolansk]

Vered Volansky has uploaded a new change for review.

Change subject: utilsTests: Avoiding returning in the middle of the method
..

utilsTests: Avoiding returning in the middle of the method

In RollbackContextTest there are some tests which returns in the first
except. This patch avoids that.

Change-Id: I877f65569f4304bdd4160bb9f84facf261e568e8
Signed-off-by: Vered Volansky vvola...@redhat.com
---
M tests/utilsTests.py
1 file changed, 7 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/22886/1

diff --git a/tests/utilsTests.py b/tests/utilsTests.py
index bf27f30..7ce15dc 100644
--- a/tests/utilsTests.py
+++ b/tests/utilsTests.py
@@ -334,9 +334,8 @@
 rollback.prependDefer(self._callDef)
 except Exception:
 self.assertEquals(self._called, 2)
-return
-
-self.fail(Exception was not raised)
+else:
+self.fail(Exception was not raised)
 
 def testFirstException(self):
 
@@ -353,11 +352,10 @@
 rollback.prependDefer(self._callDef)
 except RuntimeError:
 self.assertEquals(self._called, 3)
-return
 except Exception:
 self.fail(Wrong exception was raised)
-
-self.fail(Exception was not raised)
+else:
+self.fail(Exception was not raised)
 
 def testKeyErrorException(self):
 
@@ -368,8 +366,8 @@
 with utils.RollbackContext():
 {}['aKey']
 except KeyError:
-return
+pass
 except Exception:
 self.fail(Wrong exception was raised)
-
-self.fail(Exception was not raised)
+else:
+self.fail(Exception was not raised)


-- 
To view, visit http://gerrit.ovirt.org/22886
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I877f65569f4304bdd4160bb9f84facf261e568e8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utils: Moved RollbackContext from misc to utils

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: utils: Moved RollbackContext from misc to utils
..


Patch Set 7: Verified+1

Rebased

-- 
To view, visit http://gerrit.ovirt.org/22861
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I985103650a5706d35d9cd519618d09c692feb0be
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: misc: Fix exception re-raising in RollbackContext

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: misc: Fix exception re-raising in RollbackContext
..


Patch Set 6: Verified+1

Rebased

-- 
To view, visit http://gerrit.ovirt.org/22860
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0052717e2307ad6fec2225b3ad5f438c5a60e1c6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utils: cleanup - typos, grammar and comments refinement

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: utils: cleanup - typos, grammar and comments refinement
..


Patch Set 8: Verified+1

Rebased

-- 
To view, visit http://gerrit.ovirt.org/22862
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04a1c4d444f2604b66b44bb9deac7d780db04aaf
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utilsTests: Avoiding returning in the middle of the method

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: utilsTests: Avoiding returning in the middle of the method
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/22886
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I877f65569f4304bdd4160bb9f84facf261e568e8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utils: Moved ContextManager from misc to utils

[vvolansk]

Vered Volansky has uploaded a new change for review.

Change subject: utils: Moved ContextManager from misc to utils
..

utils: Moved ContextManager from misc to utils

The ContextManager was located in storage/misc, and is used by several 
non-storage tests.
It was therefore moved to utils, where it belongs.
Accordingly, ContextManagerTests class was moved to utilstests from mistests.

Change-Id: I985103650a5706d35d9cd519618d09c692feb0be
Signed-off-by: Vered Volansky vvola...@redhat.com
---
M lib/vdsm/utils.py
M tests/functional/networkTests.py
M tests/functional/storageTests.py
M tests/functional/virtTests.py
M tests/miscTests.py
M tests/utilsTests.py
M vdsm/storage/misc.py
M vdsm/storage/resourceManager.py
8 files changed, 118 insertions(+), 121 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/22861/1

diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py
index b072bd4..d6c65b2 100644
--- a/lib/vdsm/utils.py
+++ b/lib/vdsm/utils.py
@@ -1077,3 +1077,44 @@
 :return:
 
 self.callbacks.append(Callback(func, args, kwargs))
+
+
+class RollbackContext(object):
+'''
+A context manager for recording and playing rollback.
+The first exception will be remembered and re-raised after rollback
+
+Sample usage:
+with RollbackContext() as rollback:
+step1()
+rollback.prependDefer(lambda: undo step1)
+def undoStep2(arg): pass
+step2()
+rollback.prependDefer(undoStep2, arg)
+
+More examples see tests/miscTests.py
+'''
+def __init__(self, *args):
+self._finally = []
+
+def __enter__(self):
+return self
+
+def __exit__(self, exc_type, exc_value, traceback):
+for undo, args, kwargs in self._finally:
+try:
+undo(*args, **kwargs)
+except Exception:
+# keep the earliest exception info
+if exc_type is None:
+exc_type, exc_value, traceback = sys.exc_info()
+
+# re-raise the earliest exception
+if exc_type is not None:
+raise exc_type, exc_value, traceback
+
+def defer(self, func, *args, **kwargs):
+self._finally.append((func, args, kwargs))
+
+def prependDefer(self, func, *args, **kwargs):
+self._finally.insert(0, (func, args, kwargs))
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 21d00ff..9f8e50f 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -21,8 +21,6 @@
 import os.path
 
 import neterrors
-from storage.misc import RollbackContext
-
 from hookValidation import ValidatesHook
 from testrunner import (VdsmTestCase as TestCaseBase,
 expandPermutations, permutations)
@@ -40,6 +38,7 @@
 ruleExists, Route, Rule, addrFlush, LinkType,
 getLinks)
 
+from vdsm.utils import RollbackContext
 from vdsm.netinfo import operstate, prefix2netmask, getRouteDeviceTo
 from vdsm import ipwrapper
 
diff --git a/tests/functional/storageTests.py b/tests/functional/storageTests.py
index 542f72a..de70864 100644
--- a/tests/functional/storageTests.py
+++ b/tests/functional/storageTests.py
@@ -40,12 +40,11 @@
 import storage.storage_exception as se
 import storage.volume
 from storage.misc import execCmd
-from storage.misc import RollbackContext
 from storage.mount import Mount
 
 from vdsm.config import config
 from vdsm.constants import VDSM_USER, VDSM_GROUP
-from vdsm.utils import CommandPath
+from vdsm.utils import CommandPath, RollbackContext
 from vdsm import vdscli
 
 _VARTMP = '/var/tmp'
diff --git a/tests/functional/virtTests.py b/tests/functional/virtTests.py
index bd54621..f41de07 100644
--- a/tests/functional/virtTests.py
+++ b/tests/functional/virtTests.py
@@ -30,10 +30,9 @@
 from testrunner import VdsmTestCase as TestCaseBase
 from testrunner import permutations, expandPermutations
 
-from vdsm.utils import CommandPath
+from vdsm.utils import CommandPath, RollbackContext
 import storageTests as storage
 from storage.misc import execCmd
-from storage.misc import RollbackContext
 
 from utils import VdsProxy, SUCCESS
 
diff --git a/tests/miscTests.py b/tests/miscTests.py
index c726908..824e783 100644
--- a/tests/miscTests.py
+++ b/tests/miscTests.py
@@ -1086,77 +1086,6 @@
 proc.wait()
 
 
-class RollbackContextTests(TestCaseBase):
-def setUp(self):
-self._called = 0
-
-def _callDef(self):
-self._called += 1
-self.log.info(Incremented call count (%d), self._called)
-
-def _raiseDef(self, ex=Exception()):
-self.log.info(Raised exception (%s), ex.__class__.__name__)
-raise ex
-
-def test(self):
-with misc.RollbackContext() as rollback:
-rollback.prependDefer(self._callDef)
-
-self.assertEquals(self._called, 1)
-
-def testRaise(self):

Change in vdsm[master]: misc: Fix exception re-rasing in RollbackContext

[vvolansk]

Vered Volansky has uploaded a new change for review.

Change subject: misc: Fix exception re-rasing in RollbackContext
..

misc: Fix exception re-rasing in RollbackContext

Former re-rasing is faulty, as it doesn't take into consideration the
possibility of a tuple being thrown. This can occur when accessing a
dictionary with a missing key, for instance. In this case dictionary raises a 
tuple, i.e,
{}['missingKey'], raises the tuple ('missingKey',).
In the former implementation, the variable firstException is assinged with 
exc_value,
which, in the above case, is a tuple. When it's re-raised (raise 
firstException, None, traceback),
the type of the exception is the class of the original exc_value,
which is the tuple ('missingKey',), as is (implicitly) exc_value.
This scenario is not supported by the raise statement,
which is not supposed to receive a tuple as the first expression.
This is then being interpreted as a string by python and we receive the 
following:
TypeError: exceptions must be old-style classes or derived from BaseException, 
not str,
instead of the exception we were expecting.

In this patch, the first exception is saved and rethrown with the original 
order and values of
exc_type, exc_value, traceback.
A test (testKeyErrorException) is added to miscTests to verify that the above 
scenario is handled correctly,
a test which fails when tested on the previous RollbackContext implementation.

Change-Id: I0052717e2307ad6fec2225b3ad5f438c5a60e1c6
Signed-off-by: Vered Volansky vvola...@redhat.com
---
M tests/miscTests.py
M vdsm/storage/misc.py
2 files changed, 20 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/22860/1

diff --git a/tests/miscTests.py b/tests/miscTests.py
index fb1191b..c726908 100644
--- a/tests/miscTests.py
+++ b/tests/miscTests.py
@@ -1141,6 +1141,21 @@
 
 self.fail(Exception was not raised)
 
+def testKeyErrorException(self):
+
+KeyError is raised as a tuple and not expection. Re-rasing it
+should be aware of this fact and handled carfully.
+
+try:
+with misc.RollbackContext():
+{}['aKey']
+except KeyError:
+return
+except Exception:
+   self.fail(Wrong exception was raised)
+
+self.fail(Exception was not raised)
+
 
 class FindCallerTests(TestCaseBase):
 def _assertFindCaller(self, callback):
diff --git a/vdsm/storage/misc.py b/vdsm/storage/misc.py
index 48020b6..f1d8ab0 100644
--- a/vdsm/storage/misc.py
+++ b/vdsm/storage/misc.py
@@ -699,21 +699,17 @@
 return self
 
 def __exit__(self, exc_type, exc_value, traceback):
-firstException = exc_value
-
 for undo, args, kwargs in self._finally:
 try:
 undo(*args, **kwargs)
-except Exception as e:
+except Exception:
 # keep the earliest exception info
-if not firstException:
-firstException = e
-# keep the original traceback info
-traceback = sys.exc_info()[2]
+if exc_type is None:
+exc_type, exc_value, traceback = sys.exc_info()
 
 # re-raise the earliest exception
-if firstException is not None:
-raise firstException, None, traceback
+if exc_type is not None:
+raise exc_type, exc_value, traceback
 
 def defer(self, func, *args, **kwargs):
 self._finally.append((func, args, kwargs))


-- 
To view, visit http://gerrit.ovirt.org/22860
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0052717e2307ad6fec2225b3ad5f438c5a60e1c6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: utils: cleanup - typos, grammar and comments refinment

[vvolansk]

Vered Volansky has uploaded a new change for review.

Change subject: utils: cleanup - typos, grammar and comments refinment
..

utils: cleanup - typos, grammar and comments refinment

Change-Id: I04a1c4d444f2604b66b44bb9deac7d780db04aaf
Signed-off-by: Vered Volansky vvola...@redhat.com
---
M lib/vdsm/utils.py
1 file changed, 24 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/22862/1

diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py
index d6c65b2..122da3e 100644
--- a/lib/vdsm/utils.py
+++ b/lib/vdsm/utils.py
@@ -19,7 +19,7 @@
 #
 
 
-A module containing miscellaneous functions and classes that are user
+A module containing miscellaneous functions and classes that are used
 plentifuly around vdsm.
 
 .. attribute:: utils.symbolerror
@@ -56,7 +56,7 @@
 from cpopen import CPopen
 from . import constants
 
-# Buffsize is 1K because I tested it on some use cases and 1k was fastets. If
+# Buffsize is 1K because it was tested on some use cases and 1K was fastest. If
 # you find this number to be a bottleneck in any way you are welcome to change
 # it
 BUFFSIZE = 1024
@@ -118,7 +118,7 @@
 
 Try to remove a file.
 
-If the file doesn't exist is assumed that it was already removed.
+If the file doesn't exist it's assumed that it was already removed.
 
 try:
 os.unlink(fileToRemove)
@@ -135,7 +135,7 @@
 
 Try to remove a directory and all it's contents.
 
-If the directory doesn't exist is assumed that it was already removed.
+If the directory doesn't exist it's assumed that it was already removed.
 
 try:
 shutil.rmtree(directoryToRemove)
@@ -180,7 +180,7 @@
 
 Parse ``/proc/meminfo`` and return its content as a dictionary.
 
-For a reason unknown to me, ``/proc/meminfo`` is is sometime
+For a reason unknown to me, ``/proc/meminfo`` is sometimes
 empty when opened. If that happens, the function retries to open it
 3 times.
 
@@ -297,7 +297,7 @@
 
 class AsyncProc(object):
 
-AsyncProc is a funky class. It warps a standard subprocess.Popen
+AsyncProc is a funky class. It wraps a standard subprocess.Popen
 Object and gives it super powers. Like the power to read from a stream
 without the fear of deadlock. It does this by always sampling all
 stream while waiting for data. By doing this the other process can freely
@@ -440,7 +440,7 @@
 try:
 if self._stdin.len  0 and self._stdin.pos == 0:
 # Polling stdin is redundant if there is nothing to write
-# trun on only if data is waiting to be pushed
+# turn on only if data is waiting to be pushed
 self._poller.modify(self._fdin, select.EPOLLOUT)
 
 pollres = NoIntrPoll(self._poller.poll, 1)
@@ -801,12 +801,12 @@
 
 
 class memoized(object):
-Decorator that caches a function's return value each time it is called.
+
+Decorator that caches a function's return value each time it is called.
 If called later with the same arguments, the cached value is returned, and
 not re-evaluated. There is no support for uncachable arguments.
 
 Adaptation from http://wiki.python.org/moin/PythonDecoratorLibrary#Memoize
-
 
 def __init__(self, func):
 self.func = func
@@ -914,7 +914,7 @@
 :param func: The callable to run.
 :param expectedException: The exception you expect to receive when the
   function fails.
-:param tries: The number of time to try. None\0,-1 means infinite.
+:param tries: The number of times to try. None\0,-1 means infinite.
 :param timeout: The time you want to spend waiting. This **WILL NOT** stop
 the method. It will just not run it if it ended after the
 timeout.
@@ -950,10 +950,12 @@
 
 class AsyncProcessOperation(object):
 def __init__(self, proc, resultParser=None):
-Wraps a running process operation.
+
+Wraps a running process operation.
 
 resultParser should be of type callback(rc, out, err) and can return
-anything or throw exceptions.
+anything or throw exceptions.
+
 self._lock = threading.Lock()
 
 self._result = None
@@ -962,17 +964,22 @@
 self._proc = proc
 
 def wait(self, timeout=None, cond=None):
-Waits until the process has exited, the timeout has been reached or
-the condition has been met
+
+Waits until the process has exited, the timeout has been reached or
+the condition has been met
+
 return self._proc.wait(timeout, cond)
 
 def stop(self):
-Stops the running operation, effectively sending a kill signal to
-the process
+
+Stops the running operation, effectively sending a kill signal to
+the process
+
 

Change in vdsm[master]: utils: cleanup - typos, grammar and comments refinment

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: utils: cleanup - typos, grammar and comments refinment
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/22862
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04a1c4d444f2604b66b44bb9deac7d780db04aaf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sp: split metadata transaction in createMaster

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: sp: split metadata transaction in createMaster
..


Patch Set 2: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/22418
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b22af92b1f9a481be9af844b1acc47ae513d078
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sp: encapsulate spm status in StoragePool

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: sp: encapsulate spm status in StoragePool
..


Patch Set 8: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/21527
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b71349e2a0dfc453b68cd2d9ca6c563b1bee90c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: get currImgDir correctly in fileSD.deleteImage()

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: storage: get currImgDir correctly in fileSD.deleteImage()
..


Patch Set 4: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/22359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ee6cb963a428f18b6e43f0585d461d0975c377a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu mhun...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Hunt Xu mhun...@gmail.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: get currImgDir correctly in fileSD.deleteImage()

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: storage: get currImgDir correctly in fileSD.deleteImage()
..


Patch Set 4: -Code-Review

Huntxu, did you verify against other-than-gluster Storage Domains? Do we know 
the removed logic isn't necessary for them? What's the reason for the logic 
change from the last patch, which seemed just fine logically?
Also, why are you against moving getImagePath into FileStorageDomain? It is, 
after all, the only class using this function.

-- 
To view, visit http://gerrit.ovirt.org/22359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ee6cb963a428f18b6e43f0585d461d0975c377a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu mhun...@gmail.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Hunt Xu mhun...@gmail.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sp: _refreshDomainLinks must not change the metadata

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: sp: _refreshDomainLinks must not change the metadata
..


Patch Set 3: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/22131
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ecf801d58b34c1c811e311e3779887a406af5f0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sp: remove unused transaction in createMaster

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: sp: remove unused transaction in createMaster
..


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/22418
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b22af92b1f9a481be9af844b1acc47ae513d078
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: get currImgDir correctly in fileSD.deleteImage()

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: storage: get currImgDir correctly in fileSD.deleteImage()
..


Patch Set 3: Code-Review-1

(1 comment)

Please see comment inline.


File vdsm/storage/fileSD.py
Line 83: 
Line 84: raise
Line 85: 
Line 86: 
Line 87: def getImagePath(DomPath, imgUUID):
It looks like it's going to work, and I don't mean to discourage you, but it 
would be better to push findDomainPath() into getImagePat90h as follows:
def getImagePath(sdUUID, imgUUID):
   return os.path.join(self.findDomainPath(sdUUID),  'images', imgUUID)
Then call getImagePath() as before.
Line 88: return os.path.join(DomPath, 'images', imgUUID)
Line 89: 
Line 90: 
Line 91: def getDomUuidFromMetafilePath(metafile):


-- 
To view, visit http://gerrit.ovirt.org/22359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ee6cb963a428f18b6e43f0585d461d0975c377a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu mhun...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: get currImgDir correctly in fileSD.deleteImage()

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: storage: get currImgDir correctly in fileSD.deleteImage()
..


Patch Set 1: Code-Review-1

You've removed the only usage of getImagePath() leaving dead code.
I'd leave getImagePath() and just change its implementation to what you suggest.

-- 
To view, visit http://gerrit.ovirt.org/22359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ee6cb963a428f18b6e43f0585d461d0975c377a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu mhun...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: domainMonitor: Log unhandled exceptions in domain monitor th...

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: domainMonitor: Log unhandled exceptions in domain monitor thread
..


Patch Set 3: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/21487
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I743c59bffa99ab9868f1878ca96b7d979a703efb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: Log exceptions in storage refresh thread

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: hsm: Log exceptions in storage refresh thread
..


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/21486
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e69464ba27b7d522c5ceb3a3099949efe7fbc88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: Rescan multipath before loading lvm cache

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: hsm: Rescan multipath before loading lvm cache
..


Patch Set 2: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/21567
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ec7beee1db193a47d9e8109929badfd5b322c02
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: domainMonitor: Log exceptions in domain monitor thread

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: domainMonitor: Log exceptions in domain monitor thread
..


Patch Set 2: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/21487
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I743c59bffa99ab9868f1878ca96b7d979a703efb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdc: Change error messages to info

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: sdc: Change error messages to info
..


Patch Set 1:

This is going to be n'acked, just for due process - the bug url is actually 
https://bugzilla.redhat.com/show_bug.cgi?id=1031881

-- 
To view, visit http://gerrit.ovirt.org/21597
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdc: Change error messages to info

[vvolansk]

Vered Volansky has uploaded a new change for review.

Change subject: sdc: Change error messages to info
..

sdc: Change error messages to info

Two informative, non-error log messages were logged as error and are now
logged as info:
1._findDomain - looking for unfetched domain
2._findUnfetchedDomain - looking for domain

Also an error is raised in the process, now logged as info.

Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b
Signed-off-by: Vered Volansky vvola...@redhat.com
Bug-url: https://bugzilla.redhat.com/1031814
---
M vdsm/storage/sdc.py
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/21597/1

diff --git a/vdsm/storage/sdc.py b/vdsm/storage/sdc.py
index 2767d6c..bb8b93f 100644
--- a/vdsm/storage/sdc.py
+++ b/vdsm/storage/sdc.py
@@ -134,13 +134,13 @@
 try:
 findMethod = self.knownSDs[sdUUID]
 except KeyError:
-self.log.error(looking for unfetched domain %s, sdUUID)
+self.log.info(looking for unfetched domain %s, sdUUID)
 findMethod = self._findUnfetchedDomain
 
 try:
 dom = findMethod(sdUUID)
 except se.StorageDomainDoesNotExist:
-self.log.error(domain %s not found, sdUUID, exc_info=True)
+self.log.info(domain %s not found, sdUUID, exc_info=True)
 raise
 else:
 return dom
@@ -151,7 +151,7 @@
 import localFsSD
 import nfsSD
 
-self.log.error(looking for domain %s, sdUUID)
+self.log.info(looking for domain %s, sdUUID)
 
 # The order is somewhat important, it's ordered
 # by how quickly get can find the domain. For instance


-- 
To view, visit http://gerrit.ovirt.org/21597
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdc: Change error messages to info

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: sdc: Change error messages to info
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/21597
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1aaf82604beef7ec9abbeb83b6a0c2b0b708853b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Improve error when multipath can't access a pv

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: Improve error when multipath can't access a pv
..


Patch Set 4:

Some more info on verification:
Reproduced and verified as QA suggested, which is discovering targets, 
disconnection the host from them and then trying to connect, having the error. 
As mentioned before, a corresponding patch was sent to engine. verified with 
old engine vs. new vdsm and new engine vs. both new and old vdsm. Works as 
expected.

The reason the fix is different for the to raises is that in one (hsm) the 
dev's size is accumulated. Therefore iterating has to be used. Didn't seem 
worth to switch to set and then iterate over it...

-- 
To view, visit http://gerrit.ovirt.org/21089
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I648ee519873c51573e6e6306b79380f54bb25d2e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: Remove uneeded public annotation

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: hsm: Remove uneeded public annotation
..


Patch Set 1:

(1 comment)


Commit Message
Line 3: AuthorDate: 2013-11-12 14:17:17 +0200
Line 4: Commit: Nir Soffer nsof...@redhat.com
Line 5: CommitDate: 2013-11-12 14:17:17 +0200
Line 6: 
Line 7: hsm: Remove uneeded public annotation
s/uneeded/unneeded
Line 8: 
Line 9: Commit 15c7f74365cb5 added new undocuemnted public method. This patch
Line 10: remove the public annotation.
Line 11: 


-- 
To view, visit http://gerrit.ovirt.org/21167
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I684b573089d216ace5cec71c9e4923187241fa4a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Improve err msg when multipath can't access a pv

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: Improve err msg when multipath can't access a pv
..


Patch Set 3: Verified+1

The oVirt engine corresponding key was also changed to InaccessbilePhysDev. 
Communication between engine and vdsm is only through code, which did not 
change. Also verified all possibilities (old/new engine vs. old/new vdsm). All 
verified.

-- 
To view, visit http://gerrit.ovirt.org/21089
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I648ee519873c51573e6e6306b79380f54bb25d2e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Improve error when multipath can't access a pv

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: Improve error when multipath can't access a pv
..


Patch Set 4: Verified+1

Only commit message changed.

-- 
To view, visit http://gerrit.ovirt.org/21089
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I648ee519873c51573e6e6306b79380f54bb25d2e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: Remove uneeded public annotation

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: hsm: Remove uneeded public annotation
..


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/21167
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I684b573089d216ace5cec71c9e4923187241fa4a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Improve err msg when multipath cant access a pv

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: Improve err msg when multipath cant access a pv
..


Patch Set 2:

(5 comments)

Accepted Dan's suggestion, will submit soon.


Commit Message
Line 3: AuthorDate: 2013-11-05 17:33:36 +0200
Line 4: Commit: Vered Volansky vvola...@redhat.com
Line 5: CommitDate: 2013-11-10 13:40:15 +0200
Line 6: 
Line 7: Improve err msg when multipath cant access a pv
Because there's a limit to how long the error message can be, and I'm a 
character away from that limit.
Line 8: 
Line 9: InvalidPhysDev gave a cryptic error message - Invalid physical device.
Line 10: The message was amended to Multipath cannot access storage device 
along
Line 11: with the device name. The error key was changed according to the new


Line 3: AuthorDate: 2013-11-05 17:33:36 +0200
Line 4: Commit: Vered Volansky vvola...@redhat.com
Line 5: CommitDate: 2013-11-10 13:40:15 +0200
Line 6: 
Line 7: Improve err msg when multipath cant access a pv
Wasn't there before, I thought it might fail the script. If it won't, will add.
Line 8: 
Line 9: InvalidPhysDev gave a cryptic error message - Invalid physical device.
Line 10: The message was amended to Multipath cannot access storage device 
along
Line 11: with the device name. The error key was changed according to the new


Line 7: Improve err msg when multipath cant access a pv
Line 8: 
Line 9: InvalidPhysDev gave a cryptic error message - Invalid physical device.
Line 10: The message was amended to Multipath cannot access storage device 
along
Line 11: with the device name. The error key was changed according to the new
Done to both.
Line 12: message content. The only thing needed here by the engine is the
Line 13: error code, which was not changed in this patch.
Line 14: 
Line 15: Change-Id: I648ee519873c51573e6e6306b79380f54bb25d2e



File vdsm/storage/hsm.py
Line 2037: in multipath.getMPDevNamesIter())
Line 2038: size = 0
Line 2039: devices = []
Line 2040: 
Line 2041: for dev in devlist:
More important does not mean the other issue is NOT important. Current 
situation is exception-name almost equals already-agreed-upon-bad-message. Why 
do you want to fix the whole thing and then have an exception name that turns 
not really related to it's error message? What if were totally different? would 
you still want the older exception name? I think you should look at this 
extremity to decide, and if you still think the naming should remain the same 
please explain why.
Line 2042: if dev in knowndevs:
Line 2043: devices.append(dev)
Line 2044: size += 
multipath.getDeviceSize(devicemapper.getDmId(dev))
Line 2045: else:



File vdsm/storage/storage_exception.py
Line 1456: class InaccessiblePhysDev(StorageException):
Line 1457: def __init__(self, pvname):
Line 1458: self.value = pvname=%s % (pvname)
Line 1459: code = 606
Line 1460: message = Multipath cannot access storage device
Ack. Note that when digging into the code in this exact flow the same devices 
are referred to as pvs. Maybe this should be changed as well (in a different 
patch, of course).
Line 1461: 
Line 1462: 
Line 1463: class PartitionedPhysDev(StorageException):
Line 1464: code = 607


-- 
To view, visit http://gerrit.ovirt.org/21089
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I648ee519873c51573e6e6306b79380f54bb25d2e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changed InvalidPhysDev to InaccessiblePhysDev InvalidPhysDev...

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: Changed InvalidPhysDev to InaccessiblePhysDev InvalidPhysDev 
gave a cryptic error message - Invalid physical device. The message was amended 
into Multipath cannot access device along with device name. The error key was 
changed according to the new messa
..


Patch Set 1:

(6 comments)


Commit Message
Line 3: AuthorDate: 2013-11-05 17:33:36 +0200
Line 4: Commit: Vered Volansky vvola...@redhat.com
Line 5: CommitDate: 2013-11-10 07:47:43 +0200
Line 6: 
Line 7: Changed InvalidPhysDev to InaccessiblePhysDev
There's a limit to the number of characters, you know...
Will change though.
Line 8: InvalidPhysDev gave a cryptic error message - Invalid physical device.
Line 9: The message was amended into Multipath cannot access device along with
Line 10: device name. The error key was changed according to the new message 
content.
Line 11: The error code remains the same.


Line 3: AuthorDate: 2013-11-05 17:33:36 +0200
Line 4: Commit: Vered Volansky vvola...@redhat.com
Line 5: CommitDate: 2013-11-10 07:47:43 +0200
Line 6: 
Line 7: Changed InvalidPhysDev to InaccessiblePhysDev
Done
Line 8: InvalidPhysDev gave a cryptic error message - Invalid physical device.
Line 9: The message was amended into Multipath cannot access device along with
Line 10: device name. The error key was changed according to the new message 
content.
Line 11: The error code remains the same.


Line 5: CommitDate: 2013-11-10 07:47:43 +0200
Line 6: 
Line 7: Changed InvalidPhysDev to InaccessiblePhysDev
Line 8: InvalidPhysDev gave a cryptic error message - Invalid physical device.
Line 9: The message was amended into Multipath cannot access device along with
Done
Line 10: device name. The error key was changed according to the new message 
content.
Line 11: The error code remains the same.
Line 12: 
Line 13: Change-Id: I648ee519873c51573e6e6306b79380f54bb25d2e


Line 6: 
Line 7: Changed InvalidPhysDev to InaccessiblePhysDev
Line 8: InvalidPhysDev gave a cryptic error message - Invalid physical device.
Line 9: The message was amended into Multipath cannot access device along with
Line 10: device name. The error key was changed according to the new message 
content.
Sorry, engine naming. This is verified against engine (only code is used).
Line 11: The error code remains the same.
Line 12: 
Line 13: Change-Id: I648ee519873c51573e6e6306b79380f54bb25d2e
Line 14: Bug-url: https://bugzilla.redhat.com/852003


Line 7: Changed InvalidPhysDev to InaccessiblePhysDev
Line 8: InvalidPhysDev gave a cryptic error message - Invalid physical device.
Line 9: The message was amended into Multipath cannot access device along with
Line 10: device name. The error key was changed according to the new message 
content.
Line 11: The error code remains the same.
Motivation is engine compatibility, will clarify.
Line 12: 
Line 13: Change-Id: I648ee519873c51573e6e6306b79380f54bb25d2e
Line 14: Bug-url: https://bugzilla.redhat.com/852003



File vdsm/storage/storage_exception.py
Line 1454: 
Line 1455: 
Line 1456: class InaccessiblePhysDev(StorageException):
Line 1457: def __init__(self, pvname):
Line 1458: self.value = pvname=%s % (pvname)
Allon, followed the norm in this file.
Line 1459: code = 606
Line 1460: message = Multipath cannot access storage device
Line 1461: 
Line 1462: 


-- 
To view, visit http://gerrit.ovirt.org/21089
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I648ee519873c51573e6e6306b79380f54bb25d2e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changed InvalidPhysDev to InaccessiblePhysDev InvalidPhysDev...

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: Changed InvalidPhysDev to InaccessiblePhysDev InvalidPhysDev 
gave a cryptic error message - Invalid physical device. The message was amended 
into Multipath cannot access device along with device name. The error key was 
changed according to the new messa
..


Patch Set 1:

Nir, I disagree. The name no longer (or was ever) fits the content and IMO has 
to change within this scope.

-- 
To view, visit http://gerrit.ovirt.org/21089
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I648ee519873c51573e6e6306b79380f54bb25d2e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Improve err msg when multipath cant access a pv

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: Improve err msg when multipath cant access a pv
..


Patch Set 2: Verified+1

Addressed comments on previous patch.

-- 
To view, visit http://gerrit.ovirt.org/21089
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I648ee519873c51573e6e6306b79380f54bb25d2e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changed InvalidPhysDev to InaccessiblePhysDev InvalidPhysDev...

[vvolansk]

Vered Volansky has uploaded a new change for review.

Change subject: Changed InvalidPhysDev to InaccessiblePhysDev InvalidPhysDev 
gave a cryptic error message - Invalid physical device. The message was amended 
into Multipath cannot access device along with device name. The error key was 
changed according to the new messa
..

Changed InvalidPhysDev to InaccessiblePhysDev
InvalidPhysDev gave a cryptic error message - Invalid physical device.
The message was amended into Multipath cannot access device along with
device name. The error key was changed according to the new message content.
The error code remains the same.

Change-Id: I648ee519873c51573e6e6306b79380f54bb25d2e
Bug-url: https://bugzilla.redhat.com/852003
Signed-off-by: Vered Volansky vvola...@redhat.com
---
M vdsm/storage/blockSD.py
M vdsm/storage/hsm.py
M vdsm/storage/storage_exception.py
3 files changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/21089/1

diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py
index b95be21..69e25e0 100644
--- a/vdsm/storage/blockSD.py
+++ b/vdsm/storage/blockSD.py
@@ -730,7 +730,7 @@
 if dev in knowndevs:
 devices.append(dev)
 else:
-raise se.InvalidPhysDev(dev)
+raise se.InaccessiblePhysDev(dev)
 
 lvm.extendVG(self.sdUUID, devices, force)
 self.updateMapping()
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 25340f5..9acaa45 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -2043,7 +2043,7 @@
 devices.append(dev)
 size += multipath.getDeviceSize(devicemapper.getDmId(dev))
 else:
-raise se.InvalidPhysDev(dev)
+raise se.InaccessiblePhysDev(dev)
 
 # Minimal size check
 if size  MINIMALVGSIZE:
diff --git a/vdsm/storage/storage_exception.py 
b/vdsm/storage/storage_exception.py
index 0a69569..796a5ff 100644
--- a/vdsm/storage/storage_exception.py
+++ b/vdsm/storage/storage_exception.py
@@ -1453,9 +1453,11 @@
 message = Could not retrieve lv list
 
 
-class InvalidPhysDev(StorageException):
+class InaccessiblePhysDev(StorageException):
+def __init__(self, pvname):
+self.value = pvname=%s % (pvname)
 code = 606
-message = Invalid physical device
+message = Multipath cannot access storage device
 
 
 class PartitionedPhysDev(StorageException):


-- 
To view, visit http://gerrit.ovirt.org/21089
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I648ee519873c51573e6e6306b79380f54bb25d2e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changed InvalidPhysDev to InaccessiblePhysDev InvalidPhysDev...

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: Changed InvalidPhysDev to InaccessiblePhysDev InvalidPhysDev 
gave a cryptic error message - Invalid physical device. The message was amended 
into Multipath cannot access device along with device name. The error key was 
changed according to the new messa
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/21089
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I648ee519873c51573e6e6306b79380f54bb25d2e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: Add after_vdsm_start hook

[vvolansk]

Vered Volansky has abandoned this change.

Change subject: vdsm: Add after_vdsm_start hook
..


Abandoned

RFE is now closed-wontfix.

-- 
To view, visit http://gerrit.ovirt.org/13543
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Id02b2b7d091ffa0be57a3850fa97cdcd35778466
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add miniaml issciadm tests

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: tests: Add miniaml issciadm tests
..


Patch Set 11:

(1 comment)


File tests/fake.py
Line 41: 
Line 42: 
Line 43: class Scope(object):
Line 44: 
Line 45: I'm a contenxt manager, useful for ensuring locks are taken 
correctly.
s/contenxt/context
Line 46: 
Line 47: 
Line 48: def __init__(self):
Line 49: self.log = ''


-- 
To view, visit http://gerrit.ovirt.org/19856
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ed21408c7b496c384053ce02cdb66d47df9a14b
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: multipath.py: use vdsm.tool.service to restart multipathd

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: multipath.py: use vdsm.tool.service to restart multipathd
..


Patch Set 4: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/14728
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1130a4baf770b805aaea8de97556d18a2da86207
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Allow modification of disk xml by before_disk_hotplug

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: Allow modification of disk xml by before_disk_hotplug
..


Patch Set 3: Verified

Rebased and verified, no code changes.

--
To view, visit http://gerrit.ovirt.org/13803
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b1cf81c696f68fbdb67a5a41a54f8f055c5b73b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Read pool metadata once in StoragePool.getInfo()

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: Read pool metadata once in StoragePool.getInfo()
..


Patch Set 2: (2 inline comments)


File vdsm/storage/sp.py
Line 1474: self.log.error(Couldn't read from master domain, 
exc_info=True)
Line 1475: raise se.StoragePoolMasterNotFound(self.spUUID, msdUUID)
Line 1476: 
Line 1477: try:
Line 1478: pmd = self._getPoolMD(self.masterDomain)
Why not use _metadata() ?
Line 1479: except Exception:
Line 1480: self.log.error(Pool metadata error, exc_info=True)
Line 1481: raise se.StoragePoolActionError(self.spUUID)
Line 1482: 


Line 1482: 
Line 1483: poolInfo = {
Line 1484: 'type': msdInfo['type'],
Line 1485: 'name': pmd[PMDK_POOL_DESCRIPTION],
Line 1486: 'domains': 
domainListEncoder(pmd[PMDK_DOMAINS].iteritems()),
This looks different than origin with no explanation as to why this is ok. Was 
this intentional?
Line 1487: 'master_uuid': msdUUID,
Line 1488: 'master_ver': pmd[PMDK_MASTER_VER],
Line 1489: 'lver': pmd[PMDK_LVER],
Line 1490: 'spm_id': pmd[PMDK_SPM_ID],


--
To view, visit http://gerrit.ovirt.org/14672
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41a79662a4bd01fc310aa5554c38a16f3f8ba546
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Paikov pai...@gmail.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm now prints when a SIGTERM or SIGUSR1 is handled.

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: vdsm now prints when a SIGTERM or SIGUSR1 is handled.
..


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/14434
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2285a1e4af10bfa40b7e8f1d6a1dba4fd1f7a48c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm now reports pid when starting up.

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: vdsm now reports pid when starting up.
..


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/14430
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I029581f4ab1cc5005a55c0f7ecec8672d08da49e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: update volume apparentsize after snapshot

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: vm: update volume apparentsize after snapshot
..


Patch Set 5: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/13346
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I472c2931551643914e6a09b54d3d96f371f34864
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dafna Ron d...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Retry MD reads when validating pool-domain membership.

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: Retry MD reads when validating pool-domain membership.
..


Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/14013
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c11e1a0ce70e85b17167af5613bf597b42717c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Paikov pai...@gmail.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-tool: add service management utilities

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: vdsm-tool: add service management utilities
..


Patch Set 5: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/13701
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1cbcf5fd00bb1ec73c5970be012e294b3b4c55
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: agent: XML Character filtering improvement

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: agent: XML Character filtering improvement
..


Patch Set 5: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/13809
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21b970c8552b3f238c6bfe9271c5c5a37d40ea4d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: NetReload: Moved delNetwork logic to the configurator

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: NetReload: Moved delNetwork logic to the configurator
..


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/14015
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0da21ebbddc1d920a4b13f6f417955f3d0a814d3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Retry MD reads when validating pool-domain membership.

[vvolansk]

Vered Volansky has posted comments on this change.

Change subject: Retry MD reads when validating pool-domain membership.
..


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/14013
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c11e1a0ce70e85b17167af5613bf597b42717c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Paikov pai...@gmail.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches