Vered Volansky has uploaded a new change for review. Change subject: Changed InvalidPhysDev to InaccessiblePhysDev InvalidPhysDev gave a cryptic error message - Invalid physical device. The message was amended into "Multipath cannot access device" along with device name. The error key was changed according to the new messa ......................................................................
Changed InvalidPhysDev to InaccessiblePhysDev InvalidPhysDev gave a cryptic error message - Invalid physical device. The message was amended into "Multipath cannot access device" along with device name. The error key was changed according to the new message content. The error code remains the same. Change-Id: I648ee519873c51573e6e6306b79380f54bb25d2e Bug-url: https://bugzilla.redhat.com/852003 Signed-off-by: Vered Volansky <[email protected]> --- M vdsm/storage/blockSD.py M vdsm/storage/hsm.py M vdsm/storage/storage_exception.py 3 files changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/21089/1 diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py index b95be21..69e25e0 100644 --- a/vdsm/storage/blockSD.py +++ b/vdsm/storage/blockSD.py @@ -730,7 +730,7 @@ if dev in knowndevs: devices.append(dev) else: - raise se.InvalidPhysDev(dev) + raise se.InaccessiblePhysDev(dev) lvm.extendVG(self.sdUUID, devices, force) self.updateMapping() diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 25340f5..9acaa45 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -2043,7 +2043,7 @@ devices.append(dev) size += multipath.getDeviceSize(devicemapper.getDmId(dev)) else: - raise se.InvalidPhysDev(dev) + raise se.InaccessiblePhysDev(dev) # Minimal size check if size < MINIMALVGSIZE: diff --git a/vdsm/storage/storage_exception.py b/vdsm/storage/storage_exception.py index 0a69569..796a5ff 100644 --- a/vdsm/storage/storage_exception.py +++ b/vdsm/storage/storage_exception.py @@ -1453,9 +1453,11 @@ message = "Could not retrieve lv list" -class InvalidPhysDev(StorageException): +class InaccessiblePhysDev(StorageException): + def __init__(self, pvname): + self.value = "pvname=%s" % (pvname) code = 606 - message = "Invalid physical device" + message = "Multipath cannot access storage device" class PartitionedPhysDev(StorageException): -- To view, visit http://gerrit.ovirt.org/21089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I648ee519873c51573e6e6306b79380f54bb25d2e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
