Change in vdsm[master]: [wip] subscriptions

2015-03-15 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: [wip] subscriptions
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/38451/2/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReactor.py:

Line 213: dispatcher.handle_error()
Line 214: 
Line 215: 
Line 216: class _StompConnection(object):
Line 217: log = logging.getLogger("yajsonrpc.StompServer")
> you don't use the log..
Done
Line 218: 
Line 219: def __init__(self, server, aclient, sock, reactor):
Line 220: self._socket = sock
Line 221: self._reactor = reactor


Line 241: def get_local_address(self):
Line 242: return self._socket.getsockname()[0]
Line 243: 
Line 244: def setMessageHandler(self, msgHandler):
Line 245: self._messageHandler = msgHandler
> why not to initialize it with None? you'll get attributeError in handleMess
Done
Line 246: self._dispatcher.handle_read_event()
Line 247: 
Line 248: def handleMessage(self, data):
Line 249: if self._messageHandler is not None:


-- 
To view, visit https://gerrit.ovirt.org/38451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dima Kuznetsov 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: [wip] subscriptions

2015-03-15 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: [wip] subscriptions
..


Patch Set 2:

There is still a bit to be done for this patch but I would like you to take a 
look:
- simplify the code and remove dups
- reorder last 3 patches (this one should be before the others)
- write more stomp related tests

-- 
To view, visit https://gerrit.ovirt.org/38451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: [wip] subscriptions

2015-03-15 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: [wip] subscriptions
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/38451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: [wip] subscriptions

2015-03-08 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: [wip] subscriptions
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/38451/2/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReactor.py:

Line 213: dispatcher.handle_error()
Line 214: 
Line 215: 
Line 216: class _StompConnection(object):
Line 217: log = logging.getLogger("yajsonrpc.StompServer")
you don't use the log..
Line 218: 
Line 219: def __init__(self, server, aclient, sock, reactor):
Line 220: self._socket = sock
Line 221: self._reactor = reactor


Line 241: def get_local_address(self):
Line 242: return self._socket.getsockname()[0]
Line 243: 
Line 244: def setMessageHandler(self, msgHandler):
Line 245: self._messageHandler = msgHandler
why not to initialize it with None? you'll get attributeError in handleMessage
Line 246: self._dispatcher.handle_read_event()
Line 247: 
Line 248: def handleMessage(self, data):
Line 249: if self._messageHandler is not None:


-- 
To view, visit https://gerrit.ovirt.org/38451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dima Kuznetsov 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: [wip] subscriptions

2015-03-06 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: [wip] subscriptions
..


Patch Set 2:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16357/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15557/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16527/ : SUCCESS

-- 
To view, visit https://gerrit.ovirt.org/38451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dima Kuznetsov 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: [wip] subscriptions

2015-03-06 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: [wip] subscriptions
..


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16355/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/1/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16525/ : SUCCESS

-- 
To view, visit https://gerrit.ovirt.org/38451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dima Kuznetsov 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches