Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/525/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/902/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/939/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/521/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/937/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/534/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/79/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/79/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/11/ : 0 -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 9: Build Started (6/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/534/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 9: Build Started (5/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/902/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 9: Build Started (8/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/521/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 9: Build Started (4/9) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/11/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 9: Build Started (9/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/79/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
automat...@ovirt.org has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 9: Build Started (2/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/937/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 9: Build Started (7/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/79/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 9: Build Started (3/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/939/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 9: Build Started (1/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/525/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
Dan Kenigsberg has submitted this change and it was merged. Change subject: Added support for iothreads .. Added support for iothreads Added a new parameter 'numOfIoThreads' to VM and a new parameter 'pinToIoThread' to Drive's spec params. If not set, nothing happens. If set, the libvirt xml is enriched on two places: - The 'domain' will have a direct child N - The disk will have the 'driver' enriched by 'iothread="i"' The meaning is that the qemu will allocate N threads and pin the disk to the thread provided in it's spec params. Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Signed-off-by: Tomas Jelinek Reviewed-on: https://gerrit.ovirt.org/39796 Reviewed-by: Francesco Romani Reviewed-by: Dan Kenigsberg --- M vdsm/rpc/vdsmapi-schema.json M vdsm/virt/vmdevices/storage.py M vdsm/virt/vmxml.py 3 files changed, 14 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
Dan Kenigsberg has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
Tomas Jelinek has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18081/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18080/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17909/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 8: Build Started -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18081/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 8: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18080/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18079/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17908/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 7: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18079/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
Tomas Jelinek has uploaded a new change for review.
Change subject: Added support for iothreads
..
Added support for iothreads
Added a new parameter 'numOfIoThreads' to VM and
a new parameter 'pinToIoThread' to Drive's spec params.
If not set, nothing happens.
If set, the libvirt xml is enriched on two places:
- The 'domain' will have a direct child N
- The disk will have the 'driver' enriched by 'iothread="i"'
The meaning is that the qemu will allocate N threads and pin the disk to the
thread provided in it's spec params.
Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed
Signed-off-by: Tomas Jelinek
---
M vdsm/rpc/vdsmapi-schema.json
M vdsm/virt/vmdevices/storage.py
M vdsm/virt/vmxml.py
3 files changed, 14 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/39796/8
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 0c8638e..fbeecf1 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -2450,11 +2450,14 @@
#
# @ioTune: #optional Additional IO tune parameters
#
+# @pinToIoThread: #optional pin this device to a specific IO Thread
+#
# Since: 4.10.0
##
{'type': 'VmDiskDeviceSpecParams',
'data': {'*path': 'str'
- '*ioTune': 'VmDiskDeviceIoTuneParams'}}
+ '*ioTune': 'VmDiskDeviceIoTuneParams',
+ '*pinToIoThread': 'uint'}}
##
# @VmDiskDeviceTuneParams:
@@ -3571,6 +3574,8 @@
#
# @serial:#optional Serial number for the VM.
#
+# @numOfIoThreads:#optional The num of iothreads qemu allocates
+#
# Since: 4.10.0
##
{'type': 'VmDefinition',
@@ -3587,7 +3592,7 @@
'status': 'VmStatus', 'timeOffset': 'uint',
'transparentHugePages': 'bool', 'vmId': 'UUID', 'vmName': 'str',
'vmType': 'VmType', '*exitCode': 'int', '*exitMessage': 'str',
- '*serial': 'str'}}
+ '*serial': 'str', '*numOfIoThreads': 'uint'}}
##
# @VmParameters:
diff --git a/vdsm/virt/vmdevices/storage.py b/vdsm/virt/vmdevices/storage.py
index e92de47..dc7c000 100644
--- a/vdsm/virt/vmdevices/storage.py
+++ b/vdsm/virt/vmdevices/storage.py
@@ -363,6 +363,10 @@
elif self.format:
driverAttrs['type'] = 'raw'
+if hasattr(self, 'specParams') and (
+ 'pinToIoThread' in self.specParams):
+driverAttrs['iothread'] = str(self.specParams['pinToIoThread'])
+
driverAttrs['cache'] = self.cache
if (self.propagateErrors == 'on' or
diff --git a/vdsm/virt/vmxml.py b/vdsm/virt/vmxml.py
index 8a9c64d..fb58883 100644
--- a/vdsm/virt/vmxml.py
+++ b/vdsm/virt/vmxml.py
@@ -162,6 +162,9 @@
self.dom.appendChildWithArgs('name', text=self.conf['vmName'])
self.dom.appendChildWithArgs('uuid', text=self.conf['vmId'])
+if 'numOfIoThreads' in self.conf:
+self.dom.appendChildWithArgs('iothreads',
+ text=str(self.conf['numOfIoThreads']))
memSizeKB = str(int(self.conf.get('memSize', '256')) * 1024)
self.dom.appendChildWithArgs('memory', text=memSizeKB)
self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
--
To view, visit https://gerrit.ovirt.org/39796
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Tomas Jelinek
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
Francesco Romani has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 8: Code-Review+1 thanks! -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
Tomas Jelinek has posted comments on this change.
Change subject: Added support for iothreads
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/39796/7/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 2457: {'type': 'VmDiskDeviceSpecParams',
Line 2458: 'data': {'*path': 'str'
Line 2459: '*ioTune': 'VmDiskDeviceIoTuneParams',
Line 2460: '*pinToIoThread': 'uint'}}
Line 2461:
> this change is fine, but numOfIoThreads was gone, and we still need it. Ple
yeah, right, restored
Line 2462: ##
Line 2463: # @VmDiskDeviceTuneParams:
Line 2464: #
Line 2465: # Extra parameters for VM disk devices. At least one
https://gerrit.ovirt.org/#/c/39796/7/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 362: driverAttrs['type'] = 'qcow2'
Line 363: elif self.format:
Line 364: driverAttrs['type'] = 'raw'
Line 365:
Line 366: if hasattr(self, 'specParams') and \
> we usually prefer to write like
Done
Line 367:'pinToIoThread' in self.specParams:
Line 368: driverAttrs['iothread'] =
str(self.specParams['pinToIoThread'])
Line 369:
Line 370: driverAttrs['cache'] = self.cache
--
To view, visit https://gerrit.ovirt.org/39796
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Tomas Jelinek
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
automat...@ovirt.org has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 8: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17909/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
Tomas Jelinek has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 7: so created a simpler version of the patch which just takes the value from spec params and passes it to libvirt. If accepted and the engine side will be merged we can consider if we want the same logic which anyway will have to be in engine with round robin also in vdsm or not. But I'd say if vdsm accepts the argument this way it does not make much sense to also do some logic here. -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
Francesco Romani has posted comments on this change.
Change subject: Added support for iothreads
..
Patch Set 7:
(2 comments)
thanks for the updates, almost there.
https://gerrit.ovirt.org/#/c/39796/7/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 2457: {'type': 'VmDiskDeviceSpecParams',
Line 2458: 'data': {'*path': 'str'
Line 2459: '*ioTune': 'VmDiskDeviceIoTuneParams',
Line 2460: '*pinToIoThread': 'uint'}}
Line 2461:
this change is fine, but numOfIoThreads was gone, and we still need it. Please
restore, after that this patch should be ready to go.
Line 2462: ##
Line 2463: # @VmDiskDeviceTuneParams:
Line 2464: #
Line 2465: # Extra parameters for VM disk devices. At least one
https://gerrit.ovirt.org/#/c/39796/7/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 362: driverAttrs['type'] = 'qcow2'
Line 363: elif self.format:
Line 364: driverAttrs['type'] = 'raw'
Line 365:
Line 366: if hasattr(self, 'specParams') and \
we usually prefer to write like
if hasattr(self, 'specParams') and (
'pinToIoThread' in self.specParams):
# code
but minor thing indeed
Line 367:'pinToIoThread' in self.specParams:
Line 368: driverAttrs['iothread'] =
str(self.specParams['pinToIoThread'])
Line 369:
Line 370: driverAttrs['cache'] = self.cache
--
To view, visit https://gerrit.ovirt.org/39796
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Tomas Jelinek
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 7: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17908/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
automat...@ovirt.org has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
Tomas Jelinek has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/39796/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 831: """ Line 832: if 'numOfIoThreads' in self.conf and 'index' in drv\ Line 833: and drv['type'] == 'disk' and drv['iface'] == 'virtio': Line 834: drv['pinToIoThread'] = int(drv['index']) \ Line 835: % self.conf['numOfIoThreads'] + 1 > I came to think only now that this, albeit very simple, is policy and we us ok, removed this logic Line 836: Line 837: def __legacyDrives(self): Line 838: """ Line 839: Backward compatibility for qa scripts that specify direct paths. -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18018/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17847/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18016/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17845/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 6: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17847/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 6: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18018/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
automat...@ovirt.org has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 5: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18016/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
automat...@ovirt.org has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 5: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17845/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
Francesco Romani has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 4: (1 comment) let's split this patch in two: - this patch should just pass through numOfIoThreads and pinToThread received by Engine (the latter should added to specParams and documented in schema), with maybe validation of both fields but no policy/assignment - a followup patch will add the existing round-robin algo to pin disks to threads. On this patch we will discuss (with other reviewers as well) if we want this algo here in VDSM or not. https://gerrit.ovirt.org/#/c/39796/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 831: """ Line 832: if 'numOfIoThreads' in self.conf and 'index' in drv\ Line 833: and drv['type'] == 'disk' and drv['iface'] == 'virtio': Line 834: drv['pinToIoThread'] = int(drv['index']) \ Line 835: % self.conf['numOfIoThreads'] + 1 I came to think only now that this, albeit very simple, is policy and we usually keep policy in Engine, not in VDSM. Engine may want to handle the pinning in a different way, for example: - have a VM with two iothreads - pin a disk alone to one iothread (maybe that disk will run a database of some kind) - pin everything else to other iothread Line 836: Line 837: def __legacyDrives(self): Line 838: """ Line 839: Backward compatibility for qa scripts that specify direct paths. -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17851/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17680/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 4: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17851/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
automat...@ovirt.org has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 4: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17680/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 3: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17850/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17679/ : UNSTABLE -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 3: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17850/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
Tomas Jelinek has posted comments on this change.
Change subject: Added support for iothreads
..
Patch Set 2:
(4 comments)
https://gerrit.ovirt.org/#/c/39796/2/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 3588: '*smpCoresPerSocket': 'uint', '*smpThreadsPerCore': 'uint',
Line 3589: 'status': 'VmStatus', 'timeOffset': 'uint',
Line 3590: 'transparentHugePages': 'bool', 'vmId': 'UUID', 'vmName':
'str',
Line 3591: 'vmType': 'VmType', '*exitCode': 'int', '*exitMessage':
'str',
Line 3592: '*serial': 'str', 'numOfIoThreads': 'str'}}
> ok - will fix that
Done
Line 3593:
Line 3594: ##
Line 3595: # @VmParameters:
Line 3596: #
https://gerrit.ovirt.org/#/c/39796/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 827: # the numOfIoThreads has to be passed to the specific disks
Line 828: # so they can set the pinning up
Line 829: if 'numOfIoThreads' in self.conf:
Line 830: if drv['type'] == 'disk' and drv['iface'] == 'virtio':
Line 831: drv['numOfIoThreads'] = self.conf['numOfIoThreads']
> As tempting as is option #2, I'm inclined toward option #1 above (be carefu
ok, done
Line 832:
Line 833: def __legacyDrives(self):
Line 834: """
Line 835: Backward compatibility for qa scripts that specify direct
paths.
https://gerrit.ovirt.org/#/c/39796/2/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 365:
Line 366: if self.iface == 'virtio' and hasattr(self,
'numOfIoThreads'):
Line 367: i = int(self.index)
Line 368: pinToThread = i % self.numOfIoThreads + 1
Line 369: driverAttrs['iothread'] = str(pinToThread)
> please look at comment in vm.py
ok, so moved to vm.py
Line 370:
Line 371: driverAttrs['cache'] = self.cache
Line 372:
Line 373: if (self.propagateErrors == 'on' or
https://gerrit.ovirt.org/#/c/39796/2/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 162:
Line 163: self.dom.appendChildWithArgs('name', text=self.conf['vmName'])
Line 164: self.dom.appendChildWithArgs('uuid', text=self.conf['vmId'])
Line 165: if 'numOfIoThreads' in self.conf:
Line 166: ioThreads = self.conf['numOfIoThreads']
> ok, I will break it up
Done
Line 167: self.dom.appendChildWithArgs('iothreads',
text=str(ioThreads))
Line 168: memSizeKB = str(int(self.conf.get('memSize', '256')) * 1024)
Line 169: self.dom.appendChildWithArgs('memory', text=memSizeKB)
Line 170: self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
--
To view, visit https://gerrit.ovirt.org/39796
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Tomas Jelinek
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 3: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17679/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
automat...@ovirt.org has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
Francesco Romani has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/39796/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 827: # the numOfIoThreads has to be passed to the specific disks Line 828: # so they can set the pinning up Line 829: if 'numOfIoThreads' in self.conf: Line 830: if drv['type'] == 'disk' and drv['iface'] == 'virtio': Line 831: drv['numOfIoThreads'] = self.conf['numOfIoThreads'] > I don't think this should concern us since typically (by default) you will As tempting as is option #2, I'm inclined toward option #1 above (be careful and call everywhere). My reasoning is these two operations have a dependency on each other (IO thread pin requires valid index) but this is an implementation detail. A policy decides the binding between drive and iothread, that policy happens to use drive index. So I don't want an early tie between those two operations. Descending on the realm of personal taste, I still believe that it should not be Drive's responsability to select a thread to pin itself against, but rather VM to choose it, or even some upper level code. Line 832: Line 833: def __legacyDrives(self): Line 834: """ Line 835: Backward compatibility for qa scripts that specify direct paths. -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
Tomas Jelinek has posted comments on this change.
Change subject: Added support for iothreads
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/39796/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 827: # the numOfIoThreads has to be passed to the specific disks
Line 828: # so they can set the pinning up
Line 829: if 'numOfIoThreads' in self.conf:
Line 830: if drv['type'] == 'disk' and drv['iface'] == 'virtio':
Line 831: drv['numOfIoThreads'] = self.conf['numOfIoThreads']
> Indeed the root issue here is the (fragile and convoluted) assignement of i
I don't think this should concern us since typically (by default) you will have
only one ioThread anyway :) And after restart it will get distributed properly
anyway.
So, what about this:
- make a method like "setupPinToIoThread" this will expect the index to be
already set up for the drv and will set the pin to iothread properly (e.g. will
remove this logic from the Drive class)
- now either be careful to call it everywhere the updateDriveIndex is called (2
places) or to create a new method like "updateDrivePositionalParams" which will
first call the updateDriveIndex and than the setupPinToIoThread (and of course
replace the call to updateDriveIndex by this new method)
what do you think?
Line 832:
Line 833: def __legacyDrives(self):
Line 834: """
Line 835: Backward compatibility for qa scripts that specify direct
paths.
https://gerrit.ovirt.org/#/c/39796/2/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 162:
Line 163: self.dom.appendChildWithArgs('name', text=self.conf['vmName'])
Line 164: self.dom.appendChildWithArgs('uuid', text=self.conf['vmId'])
Line 165: if 'numOfIoThreads' in self.conf:
Line 166: ioThreads = self.conf['numOfIoThreads']
> it is fine and also considered good style to break lines inside parenthesis
ok, I will break it up
Line 167: self.dom.appendChildWithArgs('iothreads',
text=str(ioThreads))
Line 168: memSizeKB = str(int(self.conf.get('memSize', '256')) * 1024)
Line 169: self.dom.appendChildWithArgs('memory', text=memSizeKB)
Line 170: self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
--
To view, visit https://gerrit.ovirt.org/39796
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Tomas Jelinek
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
Francesco Romani has posted comments on this change.
Change subject: Added support for iothreads
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/39796/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 827: # the numOfIoThreads has to be passed to the specific disks
Line 828: # so they can set the pinning up
Line 829: if 'numOfIoThreads' in self.conf:
Line 830: if drv['type'] == 'disk' and drv['iface'] == 'virtio':
Line 831: drv['numOfIoThreads'] = self.conf['numOfIoThreads']
> In that case I have to put it both to buildConfDevices and to hotplugDisk w
Indeed the root issue here is the (fragile and convoluted) assignement of
indexes to drives. Yes, you'll need a good amount of care to do this right, but
that's only because of the existing code, none of your fault.
Still, doing the pinning or even just dispatching this information is not
'normalizing', so it should be done into a companion method
You have a point about the drive calculating itself the pinning.
The problem I see is that each drive does not know about the placement of other
drives on iothreads. In some complex hotplug/hotunplug scenarios this can lead
to some unbalancement on iothread load, or even in some iothreads completely
idle.
Is this of our concern?
Line 832:
Line 833: def __legacyDrives(self):
Line 834: """
Line 835: Backward compatibility for qa scripts that specify direct
paths.
https://gerrit.ovirt.org/#/c/39796/2/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 162:
Line 163: self.dom.appendChildWithArgs('name', text=self.conf['vmName'])
Line 164: self.dom.appendChildWithArgs('uuid', text=self.conf['vmId'])
Line 165: if 'numOfIoThreads' in self.conf:
Line 166: ioThreads = self.conf['numOfIoThreads']
> yeah, but if I write it like:
it is fine and also considered good style to break lines inside parenthesis, so
for example you can write
self.dom.appendChildWithArgs('iothreads',
text=str(self.conf['numOfIoThreads']))
or
self.dom.appendChildWithArgs('iothreads', text=str(
self.conf['numOfIoThreads']))
or whatever fits bests.
BTW, very minor issue indeed.
Line 167: self.dom.appendChildWithArgs('iothreads',
text=str(ioThreads))
Line 168: memSizeKB = str(int(self.conf.get('memSize', '256')) * 1024)
Line 169: self.dom.appendChildWithArgs('memory', text=memSizeKB)
Line 170: self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
--
To view, visit https://gerrit.ovirt.org/39796
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Tomas Jelinek
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
Tomas Jelinek has posted comments on this change.
Change subject: Added support for iothreads
..
Patch Set 2:
(4 comments)
https://gerrit.ovirt.org/#/c/39796/2/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 3588: '*smpCoresPerSocket': 'uint', '*smpThreadsPerCore': 'uint',
Line 3589: 'status': 'VmStatus', 'timeOffset': 'uint',
Line 3590: 'transparentHugePages': 'bool', 'vmId': 'UUID', 'vmName':
'str',
Line 3591: 'vmType': 'VmType', '*exitCode': 'int', '*exitMessage':
'str',
Line 3592: '*serial': 'str', 'numOfIoThreads': 'str'}}
> if it is optional, you miss the leading *, should be
ok - will fix that
Line 3593:
Line 3594: ##
Line 3595: # @VmParameters:
Line 3596: #
https://gerrit.ovirt.org/#/c/39796/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 827: # the numOfIoThreads has to be passed to the specific disks
Line 828: # so they can set the pinning up
Line 829: if 'numOfIoThreads' in self.conf:
Line 830: if drv['type'] == 'disk' and drv['iface'] == 'virtio':
Line 831: drv['numOfIoThreads'] = self.conf['numOfIoThreads']
> I don't think this is the right place. AFAIU we do want to
In that case I have to put it both to buildConfDevices and to hotplugDisk which
would not be a big issue. The bigger is that for calculating to which iothread
to pin the specific drive to I need the index of that drive. If I want to
actually calculate the correct pinning I would have to be careful to call this
logic only after the normalizeDrivesIndices (or maybe better from inside the
updateDriveIndex).
Not sure if this procedural approach (first this than that) is much better than
to let the Drive to calculate it by itself. Is it preferred in VDSM?
Line 832:
Line 833: def __legacyDrives(self):
Line 834: """
Line 835: Backward compatibility for qa scripts that specify direct
paths.
https://gerrit.ovirt.org/#/c/39796/2/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 365:
Line 366: if self.iface == 'virtio' and hasattr(self,
'numOfIoThreads'):
Line 367: i = int(self.index)
Line 368: pinToThread = i % self.numOfIoThreads + 1
Line 369: driverAttrs['iothread'] = str(pinToThread)
> I think you should receive the optional pinToThread attribute and add it to
please look at comment in vm.py
Line 370:
Line 371: driverAttrs['cache'] = self.cache
Line 372:
Line 373: if (self.propagateErrors == 'on' or
https://gerrit.ovirt.org/#/c/39796/2/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 162:
Line 163: self.dom.appendChildWithArgs('name', text=self.conf['vmName'])
Line 164: self.dom.appendChildWithArgs('uuid', text=self.conf['vmId'])
Line 165: if 'numOfIoThreads' in self.conf:
Line 166: ioThreads = self.conf['numOfIoThreads']
> hit 'done' too fast. Besides the temporary, this code looks fine. It is jus
yeah, but if I write it like:
self.dom.appendChildWithArgs('iothreads',
text=str(self.conf['numOfIoThreads']))
than I will jump off the 80 chars limit per line. I could write a private
helper method. Not sure, any other options?
Line 167: self.dom.appendChildWithArgs('iothreads',
text=str(ioThreads))
Line 168: memSizeKB = str(int(self.conf.get('memSize', '256')) * 1024)
Line 169: self.dom.appendChildWithArgs('memory', text=memSizeKB)
Line 170: self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
--
To view, visit https://gerrit.ovirt.org/39796
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Tomas Jelinek
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
Francesco Romani has posted comments on this change.
Change subject: Added support for iothreads
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/39796/2/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 162:
Line 163: self.dom.appendChildWithArgs('name', text=self.conf['vmName'])
Line 164: self.dom.appendChildWithArgs('uuid', text=self.conf['vmId'])
Line 165: if 'numOfIoThreads' in self.conf:
Line 166: ioThreads = self.conf['numOfIoThreads']
> we don't need this temporary
hit 'done' too fast. Besides the temporary, this code looks fine. It is just
the pinning between iothreads and drives that should be changed.
Line 167: self.dom.appendChildWithArgs('iothreads',
text=str(ioThreads))
Line 168: memSizeKB = str(int(self.conf.get('memSize', '256')) * 1024)
Line 169: self.dom.appendChildWithArgs('memory', text=memSizeKB)
Line 170: self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
--
To view, visit https://gerrit.ovirt.org/39796
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17835/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17664/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 2: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17835/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
Francesco Romani has posted comments on this change.
Change subject: Added support for iothreads
..
Patch Set 2:
(4 comments)
fine with the concept, the placement of the dispatching logic needs a bit of
work
https://gerrit.ovirt.org/#/c/39796/2/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 3588: '*smpCoresPerSocket': 'uint', '*smpThreadsPerCore': 'uint',
Line 3589: 'status': 'VmStatus', 'timeOffset': 'uint',
Line 3590: 'transparentHugePages': 'bool', 'vmId': 'UUID', 'vmName':
'str',
Line 3591: 'vmType': 'VmType', '*exitCode': 'int', '*exitMessage':
'str',
Line 3592: '*serial': 'str', 'numOfIoThreads': 'str'}}
if it is optional, you miss the leading *, should be
'*numOfIoThreads': 'str'
besides that, should'nt this be 'uint'?
Line 3593:
Line 3594: ##
Line 3595: # @VmParameters:
Line 3596: #
https://gerrit.ovirt.org/#/c/39796/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 827: # the numOfIoThreads has to be passed to the specific disks
Line 828: # so they can set the pinning up
Line 829: if 'numOfIoThreads' in self.conf:
Line 830: if drv['type'] == 'disk' and drv['iface'] == 'virtio':
Line 831: drv['numOfIoThreads'] = self.conf['numOfIoThreads']
I don't think this is the right place. AFAIU we do want to
- propagate the settings to the main xml, to let libvirt spawn the right number
of ioThreads
and
- pin each drive to the appropriate iothread
I think it is best to move this code -and partially the code you added to Drive
class- and make a new helper to be called in buildConfDevices.
In buildConfDevices you should setup the pinning using round robin algo and
just pass an ioThread identifier to each Drive.
Line 832:
Line 833: def __legacyDrives(self):
Line 834: """
Line 835: Backward compatibility for qa scripts that specify direct
paths.
https://gerrit.ovirt.org/#/c/39796/2/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 365:
Line 366: if self.iface == 'virtio' and hasattr(self,
'numOfIoThreads'):
Line 367: i = int(self.index)
Line 368: pinToThread = i % self.numOfIoThreads + 1
Line 369: driverAttrs['iothread'] = str(pinToThread)
I think you should receive the optional pinToThread attribute and add it to
driverAttrs here. The mapping should be done in the Vm class.
Line 370:
Line 371: driverAttrs['cache'] = self.cache
Line 372:
Line 373: if (self.propagateErrors == 'on' or
https://gerrit.ovirt.org/#/c/39796/2/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 162:
Line 163: self.dom.appendChildWithArgs('name', text=self.conf['vmName'])
Line 164: self.dom.appendChildWithArgs('uuid', text=self.conf['vmId'])
Line 165: if 'numOfIoThreads' in self.conf:
Line 166: ioThreads = self.conf['numOfIoThreads']
we don't need this temporary
Line 167: self.dom.appendChildWithArgs('iothreads',
text=str(ioThreads))
Line 168: memSizeKB = str(int(self.conf.get('memSize', '256')) * 1024)
Line 169: self.dom.appendChildWithArgs('memory', text=memSizeKB)
Line 170: self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
--
To view, visit https://gerrit.ovirt.org/39796
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 2: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17664/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
automat...@ovirt.org has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 1: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17834/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17663/ : UNSTABLE -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17834/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17663/ -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for iothreads
automat...@ovirt.org has posted comments on this change. Change subject: Added support for iothreads .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
