Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 51: Build Unstable http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9333/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1529/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10117/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/879/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10273/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5199/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3357/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1315/ : The patch does not pass the storage functional tests -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 51 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 51: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9333/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1529/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10117/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/879/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10273/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5199/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3357/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1313/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 51 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 51: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9333/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1529/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10117/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/879/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10273/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5199/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3357/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1307/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 51 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 52: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1462/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 52 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Dan Kenigsberg has submitted this change and it was merged. Change subject: Adding "updateVmPolicy" api .. Adding "updateVmPolicy" api Adding an API method "updateVmPolicy". The method will be called from the engine when a VM SLA parameter will change, for now it will support the change of vcpuLimit. Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Signed-off-by: Kobi Ianko Reviewed-on: http://gerrit.ovirt.org/27272 Reviewed-by: Francesco Romani Tested-by: Martin Sivák Reviewed-by: Dan Kenigsberg --- M client/vdsClient.py M lib/vdsm/define.py M tests/functional/utils.py M tests/functional/virtTests.py M vdsm/API.py M vdsm/rpc/BindingXMLRPC.py M vdsm/rpc/vdsmapi-schema.json M vdsm/virt/vm.py 8 files changed, 126 insertions(+), 2 deletions(-) Approvals: Martin Sivák: Verified Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 52 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Martin Sivák has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 51: I see no connection. -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 51 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Dan Kenigsberg has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 51: Code-Review+2 I assume that the storage failure as nothing to do with this patch AssertionError: error code: 16, message: Unexpected exception -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 51 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 51: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9333/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1529/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10117/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/879/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10273/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5199/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3357/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1298/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 51 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Martin Sivák has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 51: Verified+1 This patchset only moved unrelated code to a proper place and inlined a var. Still passes tests, functionality not affected so it is still verified. -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 51 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Francesco Romani has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 51: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 51 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Martin Sivák has posted comments on this change.
Change subject: Adding "updateVmPolicy" api
..
Patch Set 50:
(3 comments)
Urgent as in blocking a major feature a whole group is working on (this is the
connecting point between engine and mom).
Also 50 revisions seem to be getting a bit too much for my taste (I admit to
have caused quite a few myself).
http://gerrit.ovirt.org/#/c/27272/50/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 315: metadataCpuLimit = self._vm._dom.metadata(
Line 316: libvirt.VIR_DOMAIN_METADATA_ELEMENT,
METADATA_VM_TUNE_URI, 0)
Line 317: except libvirt.libvirtError as e:
Line 318: if e.get_error_code() !=
libvirt.VIR_ERR_NO_DOMAIN_METADATA:
Line 319: self._log.exception("Failed to retrieve QoS metadata")
> this fits better in http://gerrit.ovirt.org/#/c/27258
Done
Line 320:
Line 321: if metadataCpuLimit:
Line 322: metadataCpuLimitXML = _domParseStr(metadataCpuLimit)
Line 323: nodeList = \
Line 3668: #
Line 3669: # Process provided properties, remove property after it is
processed
Line 3670:
Line 3671: if 'vcpuLimit' in params:
Line 3672: metadataType = libvirt.VIR_DOMAIN_METADATA_ELEMENT
> the assignment to this one-time-used variable is only confusing, in my opin
I inlined it, but I do not think it makes this more readable.. long names and
80 char limit just do not mix well in my opinion
Line 3673:
Line 3674: try:
Line 3675: self._dom.setMetadata(metadataType,
'' +
Line 3676: params['vcpuLimit'] +
Line 3678: METADATA_VM_TUNE_URI, 0)
Line 3679: except libvirt.libvirtError as e:
Line 3680: self.log.exception("updateVmPolicy failed")
Line 3681: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 3682: return errCode['noVM']
> I'm OK to keep this code (better safe than sorry), but what condition is su
Just theoretically, we will probably issue this API call right after we start
the VM.
If anything goes wrong and the VM dies unexpectedly then there is a destroy
race between the check in xmlrpc bindings, vdsm and libvirt calls.
Line 3683: else:
Line 3684: return self._reportError(key='updateVmPolicyErr',
Line 3685: msg=e.message)
Line 3686: else:
--
To view, visit http://gerrit.ovirt.org/27272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe
Gerrit-PatchSet: 50
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: David Caro
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Gilad Chaplik
Gerrit-Reviewer: Kobi Ianko
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Francesco Romani has posted comments on this change.
Change subject: Adding "updateVmPolicy" api
..
Patch Set 50:
(2 comments)
How urgent is this? I'm not 100% happy but I'm not going to do a roadblock
against this patch. Please see inline comments
http://gerrit.ovirt.org/#/c/27272/50/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 315: metadataCpuLimit = self._vm._dom.metadata(
Line 316: libvirt.VIR_DOMAIN_METADATA_ELEMENT,
METADATA_VM_TUNE_URI, 0)
Line 317: except libvirt.libvirtError as e:
Line 318: if e.get_error_code() !=
libvirt.VIR_ERR_NO_DOMAIN_METADATA:
Line 319: self._log.exception("Failed to retrieve QoS metadata")
this fits better in http://gerrit.ovirt.org/#/c/27258
Line 320:
Line 321: if metadataCpuLimit:
Line 322: metadataCpuLimitXML = _domParseStr(metadataCpuLimit)
Line 323: nodeList = \
Line 3678: METADATA_VM_TUNE_URI, 0)
Line 3679: except libvirt.libvirtError as e:
Line 3680: self.log.exception("updateVmPolicy failed")
Line 3681: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 3682: return errCode['noVM']
I'm OK to keep this code (better safe than sorry), but what condition is
supposed to trigger this?
Line 3683: else:
Line 3684: return self._reportError(key='updateVmPolicyErr',
Line 3685: msg=e.message)
Line 3686: else:
--
To view, visit http://gerrit.ovirt.org/27272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe
Gerrit-PatchSet: 50
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: David Caro
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Gilad Chaplik
Gerrit-Reviewer: Kobi Ianko
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Dan Kenigsberg has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 50: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/27272/50/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3668: # Line 3669: # Process provided properties, remove property after it is processed Line 3670: Line 3671: if 'vcpuLimit' in params: Line 3672: metadataType = libvirt.VIR_DOMAIN_METADATA_ELEMENT the assignment to this one-time-used variable is only confusing, in my opinion. Line 3673: Line 3674: try: Line 3675: self._dom.setMetadata(metadataType, '' + Line 3676: params['vcpuLimit'] + -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 50 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Kobi Ianko has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 50: Verified+1 -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 50 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 50: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9311/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1521/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10095/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/872/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10251/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5177/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3335/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1293/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 50 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Kobi Ianko has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 49: Verified+1 -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 49 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 49: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9217/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1507/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10001/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/837/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10156/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5083/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1260/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3240/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 49 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 48: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9216/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1506/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/1/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/836/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10155/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5082/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1259/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3239/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 48 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Martin Sivák has posted comments on this change.
Change subject: Adding "updateVmPolicy" api
..
Patch Set 47:
(1 comment)
http://gerrit.ovirt.org/#/c/27272/47/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 7472: # @period: a number representing the period to be set
Line 7473: # Returns:
Line 7474: # Status code
Line 7475: #
Line 7476: # Since: 4.15.0dge
> As in patch set #45 we do not need those characters here. Please remove.
I hate it when a search dialog leaks to the underlying window.. fixed
Line 7477: ##
Line 7478: {'command': {'class': 'VM', 'name': 'setCpuTunePeriod'},
Line 7479: 'data': {'period': 'int'},
Line 7480: 'returns': 'TasksStatus'}
--
To view, visit http://gerrit.ovirt.org/27272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe
Gerrit-PatchSet: 47
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: David Caro
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Gilad Chaplik
Gerrit-Reviewer: Kobi Ianko
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 47: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9212/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1505/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9996/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/833/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10151/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5078/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1257/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3235/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 47 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 46: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9208/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1503/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9992/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/830/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10147/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5074/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1255/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3231/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 46 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Francesco Romani has posted comments on this change.
Change subject: Adding "updateVmPolicy" api
..
Patch Set 46:
(1 comment)
http://gerrit.ovirt.org/#/c/27272/46/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3657: if not params:
Line 3658: self.log.error("updateVmPolicy got an empty policy.")
Line 3659: return {'status': {'code': errCode['MissParam']
Line 3660: ['status']['code'],
Line 3661: 'message': "updateVmPolicy got an empty
policy."}}
consider self._reportError() here
Line 3662:
Line 3663: #
Line 3664: # Process provided properties, remove property after it is
processed
Line 3665:
--
To view, visit http://gerrit.ovirt.org/27272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe
Gerrit-PatchSet: 46
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: David Caro
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Gilad Chaplik
Gerrit-Reviewer: Kobi Ianko
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 45: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9200/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1499/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9984/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/827/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10139/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5066/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1252/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3223/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 45 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Martin Sivák has posted comments on this change.
Change subject: Adding "updateVmPolicy" api
..
Patch Set 44:
(7 comments)
I rebased the patches, all tests pass and we will reverify the functionality of
course.
http://gerrit.ovirt.org/#/c/27272/44/tests/functional/virtTests.py
File tests/functional/virtTests.py:
Line 408: with RunningVm(self.vdsm, customization) as vm:
Line 409: self._waitForStartup(vm, VM_MINIMAL_UPTIME)
Line 410: status, msg, stats = self.vdsm.getVmStats(vm)
Line 411: self.assertEqual(status, SUCCESS, msg)
Line 412:
self.vdsm.updateVmPolicy('----',
> better use customization[vmId] to avoid string duplication
Done
Line 413: '50')
Line 410: status, msg, stats = self.vdsm.getVmStats(vm)
Line 411: self.assertEqual(status, SUCCESS, msg)
Line 412:
self.vdsm.updateVmPolicy('----',
Line 413: '50')
Line 414: self.assertEqual(status, SUCCESS, msg)
> is it possible to verify that the new policy is acted upon?
It is written to the metadata section as far as VDSM is concerned. We tested
the set/get logic, MoM will then use it so it will be verified there.
http://gerrit.ovirt.org/#/c/27272/44/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3526: params['vcpuLimit'] +
Line 3527: '', 'ovirt',
Line 3528: METADATA_VM_TUNE_URI, 0)
Line 3529: except libvirt.libvirtError as e:
Line 3530: self.log.error("updateVmPolicy failed",
exc_info=True)
> use exception() that does not need an explicit exc_info=True.
Done
Line 3531: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 3532: return errCode['noVM']
Line 3533: else:
Line 3534: return {'status': {'code':
errCode['updateVmPolicyErr']
Line 3530: self.log.error("updateVmPolicy failed",
exc_info=True)
Line 3531: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 3532: return errCode['noVM']
Line 3533: else:
Line 3534: return {'status': {'code':
errCode['updateVmPolicyErr']
> how about using the reportError method which you introduced in a previous p
Done
Line 3535: ['status']['code'], 'message':
e.message}}
Line 3536: else:
Line 3537: del params['vcpuLimit']
Line 3538:
Line 3542: if params:
Line 3543: unknownParams = params.keys()
Line 3544: unknownParamsStr = ", ".join(unknownParams)
Line 3545: self.log.warn("updateVmPolicy got unknown parameters:
%s",
Line 3546: unknownParamsStr)
> the intermediate variables are unhelpful imo. Placing
Done
Line 3547:
Line 3548: return {'status': doneCode}
Line 3549:
Line 3550: def _createTransientDisk(self, diskParams):
http://gerrit.ovirt.org/#/c/27272/44/vdsm_api/Bridge.py
File vdsm_api/Bridge.py:
Line 363: 'VM_hotUnplugNic': {'ret': 'vmList'},
Line 364: 'VM_mergeStatus': {'ret': 'mergeStatus'},
Line 365: 'VM_migrationCreate': {'ret': VM_migrationCreate_Ret},
Line 366: 'VM_setNumberOfCpus': {'ret': 'vmList'},
Line 367: 'VM_updateVmPolicy': {},
> We do not need empty command_info. Please remove.
Done
Line 368: 'Volume_copy': {'ret': 'uuid'},
Line 369: 'Volume_create': {'ret': 'uuid'},
Line 370: 'Volume_delete': {'ret': 'uuid'},
Line 371: 'Volume_getInfo': {'ret': 'info'},
http://gerrit.ovirt.org/#/c/27272/44/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:
Line 7364: # @vmID:The UUID of the VM
Line 7365: #
Line 7366: # @vcpuLimit: vcpu limit to set - the value is a percentage
representation
Line 7367: # of the amount of cpu from the Host that the VM can
consume
Line 7368: #
> Please align in line description of parameters.
Done
Line 7369: # Returns:
Line 7370: # The VM definition, as updated
Line 7371: #
Line 7372: # Since: 4.15.0
--
To view, visit http://gerrit.ovirt.org/27272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe
Gerrit-PatchSet: 44
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: David Caro
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Gilad Chaplik
Gerrit-Reviewer: Kobi Ianko
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm
Change in vdsm[master]: Adding "updateVmPolicy" api
Dan Kenigsberg has posted comments on this change.
Change subject: Adding "updateVmPolicy" api
..
Patch Set 44: Code-Review-1
(5 comments)
http://gerrit.ovirt.org/#/c/27272/44/tests/functional/virtTests.py
File tests/functional/virtTests.py:
Line 408: with RunningVm(self.vdsm, customization) as vm:
Line 409: self._waitForStartup(vm, VM_MINIMAL_UPTIME)
Line 410: status, msg, stats = self.vdsm.getVmStats(vm)
Line 411: self.assertEqual(status, SUCCESS, msg)
Line 412:
self.vdsm.updateVmPolicy('----',
better use customization[vmId] to avoid string duplication
Line 413: '50')
Line 410: status, msg, stats = self.vdsm.getVmStats(vm)
Line 411: self.assertEqual(status, SUCCESS, msg)
Line 412:
self.vdsm.updateVmPolicy('----',
Line 413: '50')
Line 414: self.assertEqual(status, SUCCESS, msg)
is it possible to verify that the new policy is acted upon?
http://gerrit.ovirt.org/#/c/27272/44/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3526: params['vcpuLimit'] +
Line 3527: '', 'ovirt',
Line 3528: METADATA_VM_TUNE_URI, 0)
Line 3529: except libvirt.libvirtError as e:
Line 3530: self.log.error("updateVmPolicy failed",
exc_info=True)
use exception() that does not need an explicit exc_info=True.
Line 3531: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 3532: return errCode['noVM']
Line 3533: else:
Line 3534: return {'status': {'code':
errCode['updateVmPolicyErr']
Line 3530: self.log.error("updateVmPolicy failed",
exc_info=True)
Line 3531: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 3532: return errCode['noVM']
Line 3533: else:
Line 3534: return {'status': {'code':
errCode['updateVmPolicyErr']
how about using the reportError method which you introduced in a previous patch?
Line 3535: ['status']['code'], 'message':
e.message}}
Line 3536: else:
Line 3537: del params['vcpuLimit']
Line 3538:
Line 3542: if params:
Line 3543: unknownParams = params.keys()
Line 3544: unknownParamsStr = ", ".join(unknownParams)
Line 3545: self.log.warn("updateVmPolicy got unknown parameters:
%s",
Line 3546: unknownParamsStr)
the intermediate variables are unhelpful imo. Placing
", ".join(params.iterkeys())
on the log is simpler and clearer.
Line 3547:
Line 3548: return {'status': doneCode}
Line 3549:
Line 3550: def _createTransientDisk(self, diskParams):
--
To view, visit http://gerrit.ovirt.org/27272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe
Gerrit-PatchSet: 44
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: David Caro
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Gilad Chaplik
Gerrit-Reviewer: Kobi Ianko
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 43: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9163/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1496/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9948/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/817/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10103/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5030/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3187/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1239/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 43 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Kobi Ianko has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 43: Verified+1 -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 43 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Martin Sivák has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 44: Verified+1 Verified by Kobi (setting and retrieving the cpu limits). I only modified one failing test in the last revision. -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 44 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 44: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9179/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1498/ : The patch does not pass the network functional tests http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9963/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/820/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10118/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5045/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1242/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3202/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 44 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 42: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9135/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1493/ : The patch does not pass the network functional tests http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9920/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/801/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10075/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5002/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3159/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1225/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 42 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Martin Sivák has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 41: Code-Review+1 I am quite satisfied with how this looks and works now, but I also helped to shape it to this form. -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 41 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 41: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9129/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1492/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9914/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/798/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10069/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/4996/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3153/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1222/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 41 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 40: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9127/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1491/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9912/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/796/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10067/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/4994/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3151/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1221/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 40 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 39: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9125/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1490/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9910/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/794/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10065/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/4992/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3149/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1220/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 39 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 38: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9124/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1489/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9909/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/793/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10064/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/4991/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3148/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1219/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 38 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 37: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9122/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1488/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9906/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/791/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10062/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/4989/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3146/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1218/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 37 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 36: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9119/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1487/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9903/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/789/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10059/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/4986/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3143/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1216/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 35: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9085/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1485/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9869/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/772/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1202/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10025/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/4951/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3108/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 35 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 34: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9079/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1483/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9863/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/767/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1201/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10019/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/4945/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3102/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 34 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 33: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9068/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1482/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9852/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/759/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1197/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10008/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/4934/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3091/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 32: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9066/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1481/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9850/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/757/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1196/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10006/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/4932/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3089/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 31: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9046/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1478/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9830/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/748/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1192/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9986/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Kobi Ianko has posted comments on this change.
Change subject: Adding "updateVmPolicy" api
..
Patch Set 27:
(1 comment)
http://gerrit.ovirt.org/#/c/27272/27/client/vdsClient.py
File client/vdsClient.py:
Line 258: def setNumberOfCpus(self, args):
Line 259: return self.ExecAndExit(self.s.setNumberOfCpus(args[0],
args[1]))
Line 260:
Line 261: def updateVmPolicy(self, args):
Line 262: params = {'vmId': args[0], 'vcpuLimit': args[1]}
> shouldn't** be kept
I don't think that's user friendly to ask the user to type in a python dict
Line 263: return self.ExecAndExit(self.s.updateVmPolicy(params))
Line 264:
Line 265: def do_changeCD(self, args):
Line 266: vmId = args[0]
--
To view, visit http://gerrit.ovirt.org/27272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: David Caro
Gerrit-Reviewer: Gilad Chaplik
Gerrit-Reviewer: Kobi Ianko
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 30: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9012/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1473/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9796/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/725/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1179/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9952/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 29: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9009/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1472/ : The patch does not pass the network functional tests http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9793/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/722/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1177/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9949/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 28: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9007/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1471/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9791/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/721/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1175/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9947/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 27: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8969/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1464/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9753/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/701/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1164/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9908/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 26: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8961/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1460/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9745/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/696/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1161/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9900/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 25: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8959/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1458/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9743/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/695/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1160/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9898/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 24: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9626/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8694/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1436/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9480/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1027/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 23: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8617/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/985/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9551/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9405/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8616/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/984/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9550/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9404/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28190 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6921bf349ce88000539150fc884f1163c738186 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Kobi Ianko has posted comments on this change.
Change subject: Adding "updateVmPolicy" api
..
Patch Set 22:
(5 comments)
http://gerrit.ovirt.org/#/c/27272/22/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3224:
Line 3225: if self.isMigrating():
Line 3226: return errCode['migInProgress']
Line 3227:
Line 3228: self.log.debug("Setting VM policy to [vcpuLimit: %s]",
> we log each API call on entry. Do we need a second line here?
Done
Line 3229:params['vcpuLimit'])
Line 3230:
Line 3231: try:
Line 3232: domain = self._connection.lookupByUUIDString(self.id)
Line 3228: self.log.debug("Setting VM policy to [vcpuLimit: %s]",
Line 3229:params['vcpuLimit'])
Line 3230:
Line 3231: try:
Line 3232: domain = self._connection.lookupByUUIDString(self.id)
> please use self._dom
Done
Line 3233: domain.setMetadata(2, ''+params['vcpuLimit'] +
Line 3234:'', 'ovirt',
Line 3235:'http://ovirt.org/param/vcpu_limit',
0)
Line 3236: except libvirt.libvirtError as e:
Line 3229:params['vcpuLimit'])
Line 3230:
Line 3231: try:
Line 3232: domain = self._connection.lookupByUUIDString(self.id)
Line 3233: domain.setMetadata(2, ''+params['vcpuLimit'] +
> what is the magic number 2?
changed to VIR_DOMAIN_METADATA_ELEMENT
Line 3234:'', 'ovirt',
Line 3235:'http://ovirt.org/param/vcpu_limit',
0)
Line 3236: except libvirt.libvirtError as e:
Line 3237: self.log.error("updateVmPolicy failed", exc_info=True)
Line 3239: return errCode['noVM']
Line 3240: return {'status': {'code': errCode['updateVmPolicyErr']
Line 3241: ['status']['code'], 'message': e.message}}
Line 3242:
Line 3243: domain = self._connection.lookupByUUIDString(self.id)
> why is this extra lookup?
removed
Line 3244: return {'status': doneCode}
Line 3245:
Line 3246: def _createTransientDisk(self, diskParams):
Line 3247: if diskParams.get('shared', None) !=
DRIVE_SHARED_TYPE.TRANSIENT:
Line 4507: return self.reportError(msg='an integer is required for
quota',
Line 4508: entity='vcpu quota')
Line 4509: except libvirt.libvirtError as e:
Line 4510: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 4511: return self.reportError(key='noVM', entity='vcpu
quota')
> unrelated whitespace distracts reviewers.
Done
Line 4512:
Line 4513: return self.reportError(msg=e.message, entity='vcpu
quota')
Line 4514:
Line 4515: def setCpuTunePeriod(self, period):
--
To view, visit http://gerrit.ovirt.org/27272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: David Caro
Gerrit-Reviewer: Gilad Chaplik
Gerrit-Reviewer: Kobi Ianko
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Kobi Ianko has abandoned this change. Change subject: Adding "updateVmPolicy" api .. Abandoned by mistake changed the commit id -- To view, visit http://gerrit.ovirt.org/28190 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ib6921bf349ce88000539150fc884f1163c738186 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Kobi Ianko has uploaded a new change for review.
Change subject: Adding "updateVmPolicy" api
..
Adding "updateVmPolicy" api
Adding an API method "updateVmPolicy".
The method will be called from the engine
when a VM SLA parameter will change, for now
it will support the change of vcpuLimit.
Change-Id: Ib6921bf349ce88000539150fc884f1163c738186
Signed-off-by: Kobi Ianko
---
M client/vdsClient.py
M debian/vdsm.install
M lib/vdsm/define.py
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm/Makefile.am
M vdsm/virt/vm.py
M vdsm_api/Bridge.py
M vdsm_api/vdsmapi-schema.json
9 files changed, 76 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/28190/1
diff --git a/client/vdsClient.py b/client/vdsClient.py
index 0235837..d9c53bd 100644
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -258,6 +258,10 @@
def setNumberOfCpus(self, args):
return self.ExecAndExit(self.s.setNumberOfCpus(args[0], args[1]))
+def updateVmPolicy(self, args):
+params = {'vmId': args[0], 'vcpuLimit': args[1]}
+return self.ExecAndExit(self.s.updateVmPolicy(params))
+
def do_changeCD(self, args):
vmId = args[0]
file = self._parseDriveSpec(args[1])
@@ -2567,6 +2571,11 @@
' ',
'set the number of cpus for a running VM'
)),
+'updateVmPolicy': (
+serv.updateVmPolicy, (
+' ',
+'set SLA parameter for a VM'
+)),
}
if _glusterEnabled:
commands.update(ge.getGlusterCmdDict(serv))
diff --git a/debian/vdsm.install b/debian/vdsm.install
index b435fa6..696286d 100644
--- a/debian/vdsm.install
+++ b/debian/vdsm.install
@@ -17,6 +17,7 @@
./etc/vdsm/mom.d/01-parameters.policy
./etc/vdsm/mom.d/02-balloon.policy
./etc/vdsm/mom.d/03-ksm.policy
+./etc/vdsm/mom.d/04-cputune.policy
./etc/vdsm/svdsm.logger.conf
./etc/vdsm/upgrade.logger.conf
./etc/vdsm/vdsm-tmpfiles.conf
diff --git a/lib/vdsm/define.py b/lib/vdsm/define.py
index 7e6cadb..025d952 100644
--- a/lib/vdsm/define.py
+++ b/lib/vdsm/define.py
@@ -138,6 +138,9 @@
'haErr': {'status': {
'code': 61,
'message': 'Failed to set Hosted Engine HA policy'}},
+'updateVmPolicyErr': {'status': {
+'code': 62,
+'message': 'Failed to update VM SLA policy'}},
'recovery': {'status': {
'code': 99,
'message': 'Recovering from crash or Initializing'}},
diff --git a/vdsm/API.py b/vdsm/API.py
index 3235a6f..456a083 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -483,6 +483,23 @@
return curVm.setNumberOfCpus(int(numberOfCpus))
+def updateVmPolicy(self, params):
+
+if params['vmId'] is None or params['vcpuLimit'] is None:
+self.log.error('Missing one of required parameters: \
+ vmId: (%s), numberOfCpus: (%s)', params['vmId'],
+ params['vcpuLimit'])
+return {'status': {'code': errCode['MissParam']['status']['code'],
+ 'message': 'Missing one of required '
+ 'parameters: vmId, vcpuLimit'}}
+try:
+curVm = self._cif.vmContainer[self._UUID]
+except KeyError:
+self.log.warning("vm %s doesn't exist", self._UUID)
+return errCode['noVM']
+
+return curVm.updateVmPolicy(params)
+
def migrate(self, params):
"""
Migrate a VM to a remote host.
diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py
index 629ed62..18ded0a 100644
--- a/vdsm/BindingXMLRPC.py
+++ b/vdsm/BindingXMLRPC.py
@@ -362,6 +362,10 @@
vm = API.VM(vmId)
return vm.setNumberOfCpus(vmId, numberOfCpus)
+def vmUpdateVmPolicy(self, params):
+vm = API.VM(params['vmId'])
+return vm.updateVmPolicy(params)
+
def vmSnapshot(self, vmId, snapDrives, snapMemVolHandle=''):
"""
Take snapshot of VM
@@ -932,7 +936,8 @@
(self.vmHotplugNic, 'hotplugNic'),
(self.vmHotunplugNic, 'hotunplugNic'),
(self.vmUpdateDevice, 'vmUpdateDevice'),
-(self.vmSetNumberOfCpus, 'setNumberOfCpus'))
+(self.vmSetNumberOfCpus, 'setNumberOfCpus'),
+(self.vmUpdateVmPolicy, 'updateVmPolicy'))
def getIrsMethods(self):
return ((self.domainActivate, 'activateStorageDomain'),
diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am
index b72c100..3d6ac9c 100644
--- a/vdsm/Makefile.am
+++ b/vdsm/Makefile.am
@@ -105,6 +105,7 @@
mom.d/01-parameters.policy \
mom.d/02-balloon.policy \
mom.d/03-ksm.policy \
+ mom.d/04-cputune.policy \
sourceRoute.sh \
sudoers.vdsm.in \
svdsm.logger.conf.in \
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 691e952..a5298eb 100644
--- a/vdsm/virt/vm.py
+++ b/vd
Change in vdsm[master]: Adding "updateVmPolicy" api
Dan Kenigsberg has posted comments on this change.
Change subject: Adding "updateVmPolicy" api
..
Patch Set 22: Code-Review-1
(5 comments)
Please add a functional test for the new verb.
http://gerrit.ovirt.org/#/c/27272/22/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3224:
Line 3225: if self.isMigrating():
Line 3226: return errCode['migInProgress']
Line 3227:
Line 3228: self.log.debug("Setting VM policy to [vcpuLimit: %s]",
we log each API call on entry. Do we need a second line here?
Line 3229:params['vcpuLimit'])
Line 3230:
Line 3231: try:
Line 3232: domain = self._connection.lookupByUUIDString(self.id)
Line 3228: self.log.debug("Setting VM policy to [vcpuLimit: %s]",
Line 3229:params['vcpuLimit'])
Line 3230:
Line 3231: try:
Line 3232: domain = self._connection.lookupByUUIDString(self.id)
please use self._dom
Line 3233: domain.setMetadata(2, ''+params['vcpuLimit'] +
Line 3234:'', 'ovirt',
Line 3235:'http://ovirt.org/param/vcpu_limit',
0)
Line 3236: except libvirt.libvirtError as e:
Line 3229:params['vcpuLimit'])
Line 3230:
Line 3231: try:
Line 3232: domain = self._connection.lookupByUUIDString(self.id)
Line 3233: domain.setMetadata(2, ''+params['vcpuLimit'] +
what is the magic number 2?
Line 3234:'', 'ovirt',
Line 3235:'http://ovirt.org/param/vcpu_limit',
0)
Line 3236: except libvirt.libvirtError as e:
Line 3237: self.log.error("updateVmPolicy failed", exc_info=True)
Line 3239: return errCode['noVM']
Line 3240: return {'status': {'code': errCode['updateVmPolicyErr']
Line 3241: ['status']['code'], 'message': e.message}}
Line 3242:
Line 3243: domain = self._connection.lookupByUUIDString(self.id)
why is this extra lookup?
Line 3244: return {'status': doneCode}
Line 3245:
Line 3246: def _createTransientDisk(self, diskParams):
Line 3247: if diskParams.get('shared', None) !=
DRIVE_SHARED_TYPE.TRANSIENT:
Line 4507: return self.reportError(msg='an integer is required for
quota',
Line 4508: entity='vcpu quota')
Line 4509: except libvirt.libvirtError as e:
Line 4510: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 4511: return self.reportError(key='noVM', entity='vcpu
quota')
unrelated whitespace distracts reviewers.
Line 4512:
Line 4513: return self.reportError(msg=e.message, entity='vcpu
quota')
Line 4514:
Line 4515: def setCpuTunePeriod(self, period):
--
To view, visit http://gerrit.ovirt.org/27272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: David Caro
Gerrit-Reviewer: Gilad Chaplik
Gerrit-Reviewer: Kobi Ianko
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 22: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9079/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9220/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8291/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Martin Sivák has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 21: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8970/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9111/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8182/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Kobi Ianko has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 20: Verified+1 -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 20: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8943/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9084/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8155/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 19: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8940/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9081/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8152/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 18: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8938/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9079/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8150/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 17: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8937/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9078/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8149/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 16: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8936/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9077/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8148/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Kobi Ianko has posted comments on this change.
Change subject: Adding "updateVmPolicy" api
..
Patch Set 14:
(3 comments)
http://gerrit.ovirt.org/#/c/27272/14/vdsm/mom.d/04-cputune.policy
File vdsm/mom.d/04-cputune.policy:
Line 9: ### Helper functions
Line 10: (def check_and_set_quota (guest)
Line 11: {
Line 12:
Line 13: (defvar calcQuota (/ (* anchor (/ guest.vcpu_user_limit 100.0))
guest.vcpu_count))
> Merge this to the patch that added this file please.
Done
Line 14:
Line 15: (if (!= guest.vcpu_quota calcQuota)
Line 16: (guest.Control "vcpu_quota" calcQuota) 0)
Line 17: })
http://gerrit.ovirt.org/#/c/27272/14/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4411: return {}
Line 4412:
Line 4413: def _getUserCpuTuneInfo(self):
Line 4414: ret = {}
Line 4415: try:
> Merge those to the files that added the functionality.
Done
Line 4416: domain = self._connection.lookupByUUIDString(self.id)
Line 4417:
Line 4418: if domain:
Line 4419: vcpuLimitUri = 'http://ovirt.org/param/vcpu_limit'
http://gerrit.ovirt.org/#/c/27272/14/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:
Line 7255: # Set VM SLA parameters
Line 7256: #
Line 7257: # @vmID:The UUID of the VM
Line 7258: #
Line 7259: # @vcpuLimit: vcpu limit to set
> Can you add a description of what the value actually means? OR a link to do
Done
Line 7260: #
Line 7261: # Returns:
Line 7262: # The VM definition, as updated
Line 7263: #
--
To view, visit http://gerrit.ovirt.org/27272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: David Caro
Gerrit-Reviewer: Gilad Chaplik
Gerrit-Reviewer: Kobi Ianko
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 15: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8935/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9076/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8147/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8775/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8911/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7985/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 13: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8759/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8895/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7969/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 12: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8751/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8887/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7961/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Martin Sivák has posted comments on this change.
Change subject: Adding "updateVmPolicy" api
..
Patch Set 14:
(3 comments)
http://gerrit.ovirt.org/#/c/27272/14/vdsm/mom.d/04-cputune.policy
File vdsm/mom.d/04-cputune.policy:
Line 9: ### Helper functions
Line 10: (def check_and_set_quota (guest)
Line 11: {
Line 12:
Line 13: (defvar calcQuota (/ (* anchor (/ guest.vcpu_user_limit 100.0))
guest.vcpu_count))
Merge this to the patch that added this file please.
Line 14:
Line 15: (if (!= guest.vcpu_quota calcQuota)
Line 16: (guest.Control "vcpu_quota" calcQuota) 0)
Line 17: })
http://gerrit.ovirt.org/#/c/27272/14/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4411: return {}
Line 4412:
Line 4413: def _getUserCpuTuneInfo(self):
Line 4414: ret = {}
Line 4415: try:
Merge those to the files that added the functionality.
Line 4416: domain = self._connection.lookupByUUIDString(self.id)
Line 4417:
Line 4418: if domain:
Line 4419: vcpuLimitUri = 'http://ovirt.org/param/vcpu_limit'
http://gerrit.ovirt.org/#/c/27272/14/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:
Line 7255: # Set VM SLA parameters
Line 7256: #
Line 7257: # @vmID:The UUID of the VM
Line 7258: #
Line 7259: # @vcpuLimit: vcpu limit to set
Can you add a description of what the value actually means? OR a link to
documentation maybe?
Line 7260: #
Line 7261: # Returns:
Line 7262: # The VM definition, as updated
Line 7263: #
--
To view, visit http://gerrit.ovirt.org/27272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: David Caro
Gerrit-Reviewer: Gilad Chaplik
Gerrit-Reviewer: Kobi Ianko
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Kobi Ianko has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 14: Verified+1 -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8720/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8856/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7930/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: David Caro Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8666/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7876/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8797/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: David Caro Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8653/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7863/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8783/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: David Caro Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 8: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8470/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7680/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8591/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: David Caro Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 7: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8469/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7679/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8590/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: David Caro Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 6: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8466/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7676/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8587/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: David Caro Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8463/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7673/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8584/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: David Caro Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8461/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7671/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8582/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: David Caro Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 3: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8460/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7670/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8581/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: David Caro Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Kobi Ianko has posted comments on this change.
Change subject: Adding "updateVmPolicy" api
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/27272/2/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:
Line 7088: {'command': {'class': 'VM', 'name': 'setNumberOfCpus'},
Line 7089: 'data': {'vmID': 'UUID', 'numberOfCpus': 'int'},
Line 7090: 'returns': 'VmDefinition'}
Line 7091:
Line 7092: ##
> I think this space might be breaking the tests
Done
Line 7093: # @VM.updateVmPolicy:
Line 7094: #
Line 7095: # Set VM SLA parameters
Line 7096: #
--
To view, visit http://gerrit.ovirt.org/27272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko
Gerrit-Reviewer: David Caro
Gerrit-Reviewer: Kobi Ianko
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
David Caro has posted comments on this change.
Change subject: Adding "updateVmPolicy" api
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/27272/2/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:
Line 7088: {'command': {'class': 'VM', 'name': 'setNumberOfCpus'},
Line 7089: 'data': {'vmID': 'UUID', 'numberOfCpus': 'int'},
Line 7090: 'returns': 'VmDefinition'}
Line 7091:
Line 7092: ##
I think this space might be breaking the tests
Line 7093: # @VM.updateVmPolicy:
Line 7094: #
Line 7095: # Set VM SLA parameters
Line 7096: #
--
To view, visit http://gerrit.ovirt.org/27272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko
Gerrit-Reviewer: David Caro
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 2: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8455/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7665/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8576/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding "updateVmPolicy" api .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8454/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7664/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8575/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding "updateVmPolicy" api
Kobi Ianko has uploaded a new change for review.
Change subject: Adding "updateVmPolicy" api
..
Adding "updateVmPolicy" api
Adding an API method "updateVmPolicy".
The method will be called from the engine
when a VM SLA parameter will change, for now
it will support the change of vcpuLimit.
Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe
Signed-off-by: Kobi Ianko
---
M client/vdsClient.py
M lib/vdsm/define.py
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm/virt/vm.py
M vdsm_api/Bridge.py
M vdsm_api/vdsmapi-schema.json
7 files changed, 71 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/27272/1
diff --git a/client/vdsClient.py b/client/vdsClient.py
index 9764ea5..564ba40 100644
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -258,6 +258,10 @@
def setNumberOfCpus(self, args):
return self.ExecAndExit(self.s.setNumberOfCpus(args[0], args[1]))
+def updateVmPolicy(self, args):
+params = {'vmId': args[0], 'vcpuLimit':args[1]}
+return self.ExecAndExit(self.s.updateVmPolicy(params))
+
def do_changeCD(self, args):
vmId = args[0]
file = self._parseDriveSpec(args[1])
@@ -2556,6 +2560,11 @@
' ',
'set the number of cpus for a running VM'
)),
+'updateVmPolicy': (
+serv.updateVmPolicy, (
+' ',
+'set SLA parameter for a VM'
+)),
}
if _glusterEnabled:
commands.update(ge.getGlusterCmdDict(serv))
diff --git a/lib/vdsm/define.py b/lib/vdsm/define.py
index 7e6cadb..025d952 100644
--- a/lib/vdsm/define.py
+++ b/lib/vdsm/define.py
@@ -138,6 +138,9 @@
'haErr': {'status': {
'code': 61,
'message': 'Failed to set Hosted Engine HA policy'}},
+'updateVmPolicyErr': {'status': {
+'code': 62,
+'message': 'Failed to update VM SLA policy'}},
'recovery': {'status': {
'code': 99,
'message': 'Recovering from crash or Initializing'}},
diff --git a/vdsm/API.py b/vdsm/API.py
index 94b39b6..304cbc0 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -482,6 +482,22 @@
return curVm.setNumberOfCpus(int(numberOfCpus))
+def updateVmPolicy(self, params):
+
+if params['vmId'] is None or params['vcpuLimit'] is None:
+self.log.error('Missing one of required parameters: \
+vmId: (%s), numberOfCpus: (%s)', params['vmId'],
params['vcpuLimit'])
+return {'status': {'code': errCode['MissParam']['status']['code'],
+ 'message': 'Missing one of required '
+ 'parameters: vmId, vcpuLimit'}}
+try:
+curVm = self._cif.vmContainer[self._UUID]
+except KeyError:
+self.log.warning("vm %s doesn't exist", self._UUID)
+return errCode['noVM']
+
+return curVm.updateVmPolicy(params)
+
def migrate(self, params):
"""
Migrate a VM to a remote host.
diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py
index 76251f5..6bbc333 100644
--- a/vdsm/BindingXMLRPC.py
+++ b/vdsm/BindingXMLRPC.py
@@ -359,6 +359,10 @@
vm = API.VM(vmId)
return vm.setNumberOfCpus(vmId, numberOfCpus)
+def vmUpdateVmPolicy(self, params):
+vm = API.VM(params['vmId'])
+return vm.updateVmPolicy(params)
+
def vmSnapshot(self, vmId, snapDrives, snapMemVolHandle=''):
"""
Take snapshot of VM
@@ -939,7 +943,8 @@
(self.vmHotplugNic, 'hotplugNic'),
(self.vmHotunplugNic, 'hotunplugNic'),
(self.vmUpdateDevice, 'vmUpdateDevice'),
-(self.vmSetNumberOfCpus, 'setNumberOfCpus'))
+(self.vmSetNumberOfCpus, 'setNumberOfCpus')
+(self.vmUpdateVmPolicy, 'updateVmPolicy'))
def getIrsMethods(self):
return ((self.domainActivate, 'activateStorageDomain'),
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 670e8b8..87360c8 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -3174,6 +3174,25 @@
hooks.after_set_num_of_cpus()
return {'status': doneCode, 'vmList': self.status()}
+def updateVmPolicy(self, params):
+
+if self.isMigrating():
+return errCode['migInProgress']
+
+self.log.debug("Setting VM policy to [vcpuLimit: %s]",
params['vcpuLimit'])
+# hooks.before_set_num_of_cpus()
+try:
+domain = self._connection.lookupByUUIDString(self.id)
+domain.setMetadata(2, params['vcpuLimit'],
'http://ovirt.org/param/vcpu_limit',0)
+except libvirt.libvirtError as e:
+self.log.error("updateVmPolicy failed", exc_info=True)
+if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
+return errCode['noVM']
+return {'status': {'code': errCode['u
