Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
Zhou Zheng Sheng has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 6: Verified -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 6: No score Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2526/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2597/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1702/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 6: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2526/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1699/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2597/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
Zhou Zheng Sheng has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 5: Verified Rebase to the latest master, because this patch needs the changes from commit '422d40b'. 422d40b makes probing a service status does not lead to un-caught exception. -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 5: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2550/ (3/3) -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2480/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1649/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2550/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 5: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1649/ (2/3) -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 5: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2480/ (1/3) -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
Aravinda VK has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 4: Looks good to me, but someone else must approve Tested in Fedora 18 -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
Zhou Zheng Sheng has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Aravinda VK Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 4: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2429/ (1/3) -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2429/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1596/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2498/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
Zhou Zheng Sheng has posted comments on this change.
Change subject: Extend vdsm.tool.service to cover alternative service names
..
Patch Set 3: (1 inline comment)
Thanks Yaniv. I split it into two.
File lib/vdsm/tool/service.py
Line 57: "/usr/sbin/update-rc.d",
Line 58: )
Line 59:
Line 60: _srvNameAlts = {
Line 61: 'iscsid': ['iscsid', 'open-iscsi'],
Lists are OK too, I think.
Line 62: 'libvirtd': ['libvirtd', 'libvirt-bin'],
Line 63: 'multipathd': ['multipathd', 'multipath-tools'],
Line 64: 'network': ['network', 'networking'],
Line 65: }
--
To view, visit http://gerrit.ovirt.org/14720
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 4: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2498/ (3/3) -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 4: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1596/ (2/3) -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
Yaniv Bronhaim has posted comments on this change.
Change subject: Extend vdsm.tool.service to cover alternative service names
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Please split to 2 patches, one that adds the alternative names and one that
adds the initctlNative and sysvNative decorators.
File lib/vdsm/tool/service.py
Line 57: "/usr/sbin/update-rc.d",
Line 58: )
Line 59:
Line 60: _srvNameAlts = {
Line 61: 'iscsid': ['iscsid', 'open-iscsi'],
tuples ?
Line 62: 'libvirtd': ['libvirtd', 'libvirt-bin'],
Line 63: 'multipathd': ['multipathd', 'multipath-tools'],
Line 64: 'network': ['network', 'networking'],
Line 65: }
--
To view, visit http://gerrit.ovirt.org/14720
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
Zhou Zheng Sheng has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2320/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1481/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2385/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2385/ (3/3) -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1481/ (2/3) -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2320/ (1/3) -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2264/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1425/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2328/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2264/ (3/3) -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1425/ (2/3) -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2328/ (1/3) -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2258/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1419/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2322/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2322/ (2/3) -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1419/ (3/3) -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm.tool.service to cover alternative service names .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2258/ (1/3) -- To view, visit http://gerrit.ovirt.org/14720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extend vdsm.tool.service to cover alternative service names
Zhou Zheng Sheng has uploaded a new change for review.
Change subject: Extend vdsm.tool.service to cover alternative service names
..
Extend vdsm.tool.service to cover alternative service names
Service names are different on various systems, instead of hard-coded
service names for each supported system, we can extend vdsm.tool.service
to detect the right service name given some hints (possible alternative
names). This makes the service management more flexible and helps to
port us to new systems easily.
This patch detect each alternative service name before actual commiting
the management operation. This is done by decorating each management
operation with _XXXNative tag, and iterating over the alternative
service names list for each management operation.
Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447
Signed-off-by: Zhou Zheng Sheng
---
M lib/vdsm/tool/service.py
1 file changed, 52 insertions(+), 12 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/14720/1
diff --git a/lib/vdsm/tool/service.py b/lib/vdsm/tool/service.py
index f71f714..4aafb67 100644
--- a/lib/vdsm/tool/service.py
+++ b/lib/vdsm/tool/service.py
@@ -56,6 +56,13 @@
"/usr/sbin/update-rc.d",
)
+_srvNameAlts = {
+'iscsid': ['iscsid', 'open-iscsi'],
+'libvirtd': ['libvirtd', 'libvirt-bin'],
+'multipathd': ['multipathd', 'multipath-tools'],
+'network': ['network', 'networking'],
+}
+
_srvStartAlts = []
_srvStopAlts = []
_srvStatusAlts = []
@@ -75,9 +82,9 @@
if rc != 0:
return (rc, out, err)
for line in out:
-if srvName + ".service" == line.split(" ", 1):
+if srvName + ".service" == line.split(" ", 1)[0]:
return systemctlFun(srvName)
-return (1, "", "%s is not native systemctl service")
+return (1, "", "%s is not native systemctl service" % srvName)
return wrapper
@_systemctlNative
@@ -121,6 +128,18 @@
except OSError:
pass
else:
+def _initctlNative(initctlFun):
+@functools.wraps(initctlFun)
+def wrapper(srvName):
+cmd = [_INITCTL.cmd, "usage", srvName]
+rc, out, err = execCmd(cmd, raw=False)
+if rc != 0:
+return (1, "", "%s is not an Upstart service" % srvName)
+
+return initctlFun(srvName)
+return wrapper
+
+@_initctlNative
def _initctlStart(srvName):
cmd = [_INITCTL.cmd, "start", srvName]
alreadyRunRegex = r"\bis already running\b"
@@ -131,6 +150,7 @@
rc = int(not re.search(alreadyRunRegex, err, re.MULTILINE))
return (rc, out, err)
+@_initctlNative
def _initctlStop(srvName):
cmd = [_INITCTL.cmd, "stop", srvName]
alreadyStoppedRegex = r'\bUnknown instance\b'
@@ -141,6 +161,7 @@
rc = int(not re.search(alreadyStoppedRegex, err, re.MULTILINE))
return (rc, out, err)
+@_initctlNative
def _initctlStatus(srvName):
cmd = [_INITCTL.cmd, "status", srvName]
rc, out, err = execCmd(cmd)
@@ -149,12 +170,14 @@
rc = _isStopped(out)
return (rc, out, err)
+@_initctlNative
def _initctlRestart(srvName):
# "initctl restart someSrv" will not restart the service if it is
# already running, so we force it to do so
_initctlStop(srvName)
return _initctlStart(srvName)
+@_initctlNative
def _initctlDisable(srvName):
if not os.path.isfile("/etc/init/%s.conf" % srvName):
return 1, "", ""
@@ -169,19 +192,32 @@
_srvDisableAlts.append(_initctlDisable)
+def _sysvNative(sysvFun):
+@functools.wraps(sysvFun)
+def wrapper(srvName):
+srvPath = os.path.join(os.sep + 'etc', 'init.d', srvName)
+if os.path.exists(srvPath):
+return sysvFun(srvName)
+
+return (1, "", "%s is not a SysV service" % srvName)
+return wrapper
+
try:
_SERVICE.cmd
except OSError:
pass
else:
+@_sysvNative
def _serviceStart(srvName):
cmd = [_SERVICE.cmd, srvName, "start"]
return execCmd(cmd)
+@_sysvNative
def _serviceStop(srvName):
cmd = [_SERVICE.cmd, srvName, "stop"]
return execCmd(cmd)
+@_sysvNative
def _serviceStatus(srvName):
cmd = [_SERVICE.cmd, srvName, "status"]
rc, out, err = execCmd(cmd)
@@ -190,6 +226,7 @@
rc = _isStopped(out)
return (rc, out, err)
+@_sysvNative
def _serviceRestart(srvName):
cmd = [_SERVICE.cmd, srvName, "restart"]
return execCmd(cmd)
@@ -205,6 +242,7 @@
except OSError:
pass
else:
+@_sysvNative
def _chkconfigDisable(srvName):
cmd = [_CHKCONFIG.cmd, srvName, "off"]
return execCmd(cmd)
@@ -217,6 +255,7 @@
except OSError:
