Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-05-09 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 10:

* Update tracker::#1169338::OK
* Set MODIFIED::bug 1169338#1169338IGNORE, not oVirt prod but Red Hat 
Enterprise Virtualization Manager

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-05-09 Thread danken
Dan Kenigsberg has submitted this change and it was merged.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Move passwd (set saslpassword for libvirt) to vdsm-tool

In this patch we stop calling saslpassword command directly,
instead we move passwd logic to vdsm-tool configure.
with that patch after rpm installation user will need to call configure
to set the sasl libvirt password - therefore we remove those parts from spec,
and update the manual accordingly.

In additional this patch moves all related constants to passwd and replace
usages.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1169338
Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Signed-off-by: Yaniv Bronhaim 
Reviewed-on: https://gerrit.ovirt.org/39823
Reviewed-by: Dan Kenigsberg 
Continuous-Integration: Jenkins CI
---
M configure.ac
M lib/vdsm/constants.py.in
M lib/vdsm/libvirtconnection.py
M lib/vdsm/tool/Makefile.am
M lib/vdsm/tool/configurators/Makefile.am
A lib/vdsm/tool/configurators/passwd.py
D lib/vdsm/tool/passwd.py
M tests/libvirtconnectionTests.py
M vdsm-tool/vdsm-tool.1.in
M vdsm.spec.in
10 files changed, 87 insertions(+), 112 deletions(-)

Approvals:
  Yaniv Bronhaim: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-05-09 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 9: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 9:

* Update tracker::#1169338::OK
* Check Bug-Url::OK
* Check Public Bug::#1169338::OK, public bug
* Check Product::#1169338::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-05-07 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 8: Code-Review+2

please rebase on top of master. The test failure below is fixed by 
https://gerrit.ovirt.org/40346


16:38:13 ERROR: testHostSampleHandlesDisappearingVlanInterfaces 
(samplingTests.InterfaceSampleTests)
16:38:13 --
16:38:13 Traceback (most recent call last):
16:38:13   File "/tmp/run/vdsm/tests/monkeypatch.py", line 132, in wrapper
16:38:13 with MonkeyPatchScope([(module, name, that)]):
16:38:13   File "/usr/lib64/python2.7/contextlib.py", line 17, in __enter__
16:38:13 return self.gen.next()
16:38:13   File "/tmp/run/vdsm/tests/monkeypatch.py", line 108, in 
MonkeyPatchScope
16:38:13 patch.apply()
16:38:13   File "/tmp/run/vdsm/tests/monkeypatch.py", line 63, in apply
16:38:13 old = getattr(module, name)
16:38:13 AttributeError: 'module' object has no attribute '_read_password'

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-05-07 Thread fabiand
Fabian Deutsch has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/39823/8/lib/vdsm/tool/configurators/passwd.py
File lib/vdsm/tool/configurators/passwd.py:

Line 52: if rc != 0:
Line 53: raise RuntimeError("Set password failed: %s" % (err,))
Line 54: if utils.isOvirtNode():
Line 55: # It seems that all /etc/libvirt folder is persisted in node,
Line 56: # but better to persist the db file explicitly
> why is it better?
It is safer.
It can be that subdirs of /etc7libvirt are persisted.

The golden rule is: Persist whatever you touch and what needs persistence.
Line 57: utils.persist(_LIBVIRT_SASLDB)
Line 58: 
Line 59: 
Line 60: def removeConf():


-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-05-07 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/39823/8/lib/vdsm/tool/configurators/passwd.py
File lib/vdsm/tool/configurators/passwd.py:

Line 52: if rc != 0:
Line 53: raise RuntimeError("Set password failed: %s" % (err,))
Line 54: if utils.isOvirtNode():
Line 55: # It seems that all /etc/libvirt folder is persisted in node,
Line 56: # but better to persist the db file explicitly
why is it better?

I'd rather have Fabian ack about that.
Line 57: utils.persist(_LIBVIRT_SASLDB)
Line 58: 
Line 59: 
Line 60: def removeConf():


-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-05-07 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/39823/6/lib/vdsm/tool/configurators/passwd.py
File lib/vdsm/tool/configurators/passwd.py:

Line 49: def configure():
Line 50: script = (str(_SASLPASSWD2), '-p', '-a', 'libvirt', SASL_USERNAME)
Line 51: rc, _, err = utils.execCmd(script, data=libvirt_password())
Line 52: if rc != 0:
Line 53: raise RuntimeError("Set password failed: %s" % (err,))
> we currently run each boot https://github.com/oVirt/ovirt-node-plugin-vdsm/
isn't it a shame to revert to "vdsm-tool is-configured" == False on every boot? 
We do try to persist our modification to libvirtd.conf etc. Why not here?
Line 54: 
Line 55: 
Line 56: def removeConf():
Line 57: if isconfigured() == YES:


-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-05-07 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 8:

* Update tracker::#1169338::OK
* Check Bug-Url::OK
* Check Public Bug::#1169338::OK, public bug
* Check Product::#1169338::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-05-07 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 7: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-05-07 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 7:

* Update tracker::#1169338::OK
* Check Bug-Url::OK
* Check Public Bug::#1169338::OK, public bug
* Check Product::#1169338::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-05-07 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 6:

(1 comment)

replied to the comment

https://gerrit.ovirt.org/#/c/39823/6/lib/vdsm/tool/configurators/passwd.py
File lib/vdsm/tool/configurators/passwd.py:

Line 49: def configure():
Line 50: script = (str(_SASLPASSWD2), '-p', '-a', 'libvirt', SASL_USERNAME)
Line 51: rc, _, err = utils.execCmd(script, data=libvirt_password())
Line 52: if rc != 0:
Line 53: raise RuntimeError("Set password failed: %s" % (err,))
> should we persist the sasl db? Otherwise, we would call configure on every 
we currently run each boot 
https://github.com/oVirt/ovirt-node-plugin-vdsm/blob/master/hooks/on-boot/01-vdsm-configure

so it won't be an issue..
Line 54: 
Line 55: 
Line 56: def removeConf():
Line 57: if isconfigured() == YES:


-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 6: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/851/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/860/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1405/ 
: SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/90/ : 
FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18214/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1444/ : 0

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 6:

(2 comments)

https://gerrit.ovirt.org/#/c/39823/6/lib/vdsm/tool/configurators/passwd.py
File lib/vdsm/tool/configurators/passwd.py:

Line 1: # Copyright 2012 IBM, Inc.
Also Red Hat and also 2015.
Line 2: #
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License as published by
Line 5: # the Free Software Foundation; either version 2 of the License, or


Line 49: def configure():
Line 50: script = (str(_SASLPASSWD2), '-p', '-a', 'libvirt', SASL_USERNAME)
Line 51: rc, _, err = utils.execCmd(script, data=libvirt_password())
Line 52: if rc != 0:
Line 53: raise RuntimeError("Set password failed: %s" % (err,))
should we persist the sasl db? Otherwise, we would call configure on every boot.
Line 54: 
Line 55: 
Line 56: def removeConf():
Line 57: if isconfigured() == YES:


-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 6:

Build Started (6/6) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/90/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 5: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/850/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/859/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1404/ 
: SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/89/ : 
FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18213/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1443/ : 0

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 6:

Build Started (5/6) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/851/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 6: Code-Review-1

please use CommandPath.cmd.
Also, please verify that this works on ovirt-node

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/39823/5/lib/vdsm/tool/configurators/passwd.py
File lib/vdsm/tool/configurators/passwd.py:

Line 46: return NO
Line 47: 
Line 48: 
Line 49: def configure():
Line 50: script = (str(_SASLPASSWD2), '-p', '-a', 'libvirt', SASL_USERNAME)
_SASLPASSWD2.cmd returns a string. If it does not - we have a big problem 
everywhere.
Line 51: rc, _, err = utils.execCmd(script, data=libvirt_password())
Line 52: if rc != 0:
Line 53: raise RuntimeError("Set password failed: %s" % (err,))
Line 54: 


-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 6:

Build Started (3/6) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1405/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 6:

Build Started (2/6)

0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1444/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 6:

Build Started (4/6) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/860/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 6:

Build Started (1/6) -> 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18214/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 5:

Build Started (6/6) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/89/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 6:

* Update tracker::#1169338::OK
* Check Bug-Url::OK
* Check Public Bug::#1169338::OK, public bug
* Check Product::#1169338::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 5:

Build Started (4/6) -> 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18213/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 5:

Build Started (1/5) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/850/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 5:

Build Started (5/6)

0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1443/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 5:

Build Started (2/6) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/859/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 5:

Build Started (3/6) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1404/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 5: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/849/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/858/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1403/ 
: SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/88/ : 
FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18212/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1442/ : 0

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread oourfali
Oved Ourfali has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 5: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/39823/5//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2015-04-27 05:47:13 -0400
Line 6: 
Line 7: Move passwd (set saslpassword for libvirt) to vdsm-tool
Line 8: 
Line 9: In this patch we stop calling saslpassword command directly, 
don't know if whitespaces in commit message are allowed...
Line 10: instead we move passwd logic to vdsm-tool configure.
Line 11: with that patch after rpm installation user will need to call configure
Line 12: to set the sasl libvirt password - therefore we remove those parts 
from spec,
Line 13: and update the manual accordingly.


-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 5:

Build Started (6/6) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/88/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 5:

Build Started (5/6) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1403/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 5: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 5: -Verified

Build Started (1/6) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/849/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 5:

Build Started (3/6) -> 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18212/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 5:

updated commit message anyhow to make it more clear

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 5:

Build Started (2/6) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/858/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 5:

Build Started (4/6)

0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1442/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 5:

* Update tracker::#1169338::OK
* Check Bug-Url::OK
* Check Public Bug::#1169338::OK, public bug
* Check Product::#1169338::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/39823/4/vdsm-tool/vdsm-tool.1.in
File vdsm-tool/vdsm-tool.1.in:

Line 85
Line 86
Line 87
Line 88
Line 89
> I am missing information in commit message why we removed it.
we don't have this command anymore - as stated this patch moves "vdsm-tool 
passwd" to be part of vdsm-tool configure - so this manual should update.


https://gerrit.ovirt.org/#/c/39823/4/vdsm.spec.in
File vdsm.spec.in:

Line 851
Line 852
Line 853
Line 854
Line 855
> I do not know why we removed this. Please provide some info about this chan
same - we don't define the saslpasswd anymore directly - we use vdsm-tool 
configure for that manually (or by host-deploy) after rpm installation


-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-27 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 4: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/39823/4/vdsm-tool/vdsm-tool.1.in
File vdsm-tool/vdsm-tool.1.in:

Line 85
Line 86
Line 87
Line 88
Line 89
I am missing information in commit message why we removed it.


https://gerrit.ovirt.org/#/c/39823/4/vdsm.spec.in
File vdsm.spec.in:

Line 851
Line 852
Line 853
Line 854
Line 855
I do not know why we removed this. Please provide some info about this change.


Line 911
Line 912
Line 913
Line 914
Line 915
As above.


-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-26 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 4: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/845/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/854/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1399/ 
: SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/84/ : 
FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18194/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1424/ : 0

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 4:

Build Started (6/6) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/84/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 4:

Build Started (5/6)

0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1424/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-26 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 4:

* Update tracker::#1169338::OK
* Check Bug-Url::OK
* Check Public Bug::#1169338::OK, public bug
* Check Product::#1169338::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 4:

Build Started (3/6) -> 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18194/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 4:

Build Started (1/6) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1399/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 4:

Build Started (4/6) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/845/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 4:

Build Started (2/6) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/854/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-21 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 3: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/39823/3/configure.ac
File configure.ac:

Line 320: AC_PATH_PROG([RM_PATH], [rm], [/bin/rm])
Line 321: AC_PATH_PROG([RPM_PATH], [rpm], [/bin/rpm])
Line 322: AC_PATH_PROG([RSYNC_PATH], [rsync], [/usr/bin/rsync])
Line 323: AC_PATH_PROG([SASLPASSWD2_PATH], [saslpasswd2], 
[/usr/sbin/saslpasswd2])
Line 324: AC_PATH_PROG([SASLDBLISTUSERS2_PATH], [sasldblistusers2], 
[/usr/sbin/sasldblistusers2])
please use CommandPath instead of adding autoconf dependencies
Line 325: AC_PATH_PROG([SED_PATH], [sed], [/bin/sed])
Line 326: AC_PATH_PROG([SERVICE_PATH], [service], [/sbin/service])
Line 327: AC_PATH_PROG([SETSID_PATH], [setsid], [/usr/bin/setsid])
Line 328: AC_PATH_PROG([SUDO_PATH], [sudo], [/usr/bin/sudo])


https://gerrit.ovirt.org/#/c/39823/3/lib/vdsm/constants.py.in
File lib/vdsm/constants.py.in:

Line 71: #
Line 72: # Path definitions
Line 73: #
Line 74: P_LIBVIRT_VMCHANNELS = '/var/lib/libvirt/qemu/channels/'
Line 75: P_LIBVIRT_SASL_DB_PATH = '/etc/libvirt/passwd.db'
if there is no need for intr-product exposure of this path, keep it in its own 
module.
Line 76: P_VDSM = '@VDSMDIR@/'
Line 77: P_VDSM_RPC = '@VDSMDIR@/rpc/'
Line 78: P_VDSM_HOOKS = '@HOOKSDIR@/'
Line 79: P_VDSM_LIB = '@VDSMLIBDIR@/'


https://gerrit.ovirt.org/#/c/39823/3/vdsm.spec.in
File vdsm.spec.in:

Line 911: 
Line 912: /bin/sed -i '/# VDSM section begin/,/# VDSM section end/d' \
Line 913: /etc/sysctl.conf
Line 914: 
Line 915: if /sbin/initctl status libvirtd >/dev/null 2>/dev/null ; then
please remove set-saslpasswd from here, and from the doc, too.

Make sure that ovirt-node does not call this removed command, too.
Line 916: /sbin/initctl stop libvirtd  >/dev/null 2>/dev/null
Line 917: rm -f /etc/init/libvirtd.conf
Line 918: 
Line 919: /sbin/chkconfig libvirtd on


-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 3: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/799/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1365/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18035/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/808/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1353/ 
: SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/36/ : 
FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17864/ : SUCCESS

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 3:

Build Started (7/7) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1353/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 3:

Build Started (6/7) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/799/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 3:

Build Started (5/7) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/808/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 3:

Build Started (4/7) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/36/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 3:

Build Started (3/7) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1365/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-20 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 3:

Build Started (2/7) -> 
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18035/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 3:

Build Started (1/7) -> 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17864/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-20 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 3:

* Update tracker::#1169338::OK
* Check Bug-Url::OK
* Check Public Bug::#1169338::OK, public bug
* Check Product::#1169338::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 2: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/797/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1363/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18029/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/806/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1351/ 
: SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/34/ : 
FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17858/ : SUCCESS

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 2:

Build Started (7/7) -> 
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18029/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 2:

Build Started (6/7) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/34/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 2:

Build Started (5/7) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1351/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 2:

Build Started (4/7) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/797/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 2:

Build Started (3/7) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/806/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 2:

Build Started (2/7) -> 
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1363/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 2:

Build Started (1/7) -> 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17858/

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-04-20 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool
..


Patch Set 2:

* Update tracker::#1169338::OK
* Check Bug-Url::OK
* Check Public Bug::#1169338::OK, public bug
* Check Product::#1169338::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/39823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches