Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/944/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/120/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/52/ : 0 http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/577/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/979/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/120/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/566/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/981/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/562/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 5: Build Started (9/9) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/52/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 5: Build Started (8/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/577/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 5: Build Started (8/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/562/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 5: Build Started (1/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/566/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 5: Build Started (2/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/576/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 5: Build Started (4/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/979/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 5: Build Started (5/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/981/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 5: Build Started (6/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/944/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 5: Build Started (7/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/120/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
Dan Kenigsberg has submitted this change and it was merged. Change subject: Move udevadm to lib/vdsm .. Move udevadm to lib/vdsm udevadm is a handy tool that other parts of vdsm could use beside storage. Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Signed-off-by: Ido Barkan Reviewed-on: https://gerrit.ovirt.org/40119 Reviewed-by: Dan Kenigsberg Reviewed-by: Nir Soffer --- M debian/vdsm-python.install M debian/vdsm.install M lib/vdsm/Makefile.am R lib/vdsm/udevadm.py M vdsm.spec.in M vdsm/storage/Makefile.am M vdsm/storage/multipath.py M vdsm/storage/storageServer.py 8 files changed, 6 insertions(+), 6 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Ido Barkan: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 5: Build Started (3/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/120/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
automat...@ovirt.org has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
Ido Barkan has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 4: as described above: verified by importing udevadm from vdsm >>> from vdsm import udevadm -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
Nir Soffer has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 4: Ido, can you described how did you verify? -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
Ido Barkan has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
Nir Soffer has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
Dan Kenigsberg has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/871/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/880/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1425/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18339/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1569/ : FAILURE -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 4: Build Started (5/5) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1425/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 4: Build Started (4/5) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/880/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
Ido Barkan has posted comments on this change.
Change subject: Move udevadm to lib/vdsm
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/40119/3/tests/samplingTests.py
File tests/samplingTests.py:
Line 149: s1 = sampling.InterfaceSample(lo)
Line 150: s1.operstate = 'x'
Line 151: self.assertEquals('operstate:x', s1.connlog_diff(s0))
Line 152:
Line 153: #@brokentest("Broken unless libvirtd is running")
> this is a real pep8 error. add a space after the #.
slippery fingers.
Line 154: @MonkeyPatch(libvirtconnection, '_read_password', read_password)
Line 155: @ValidateRunningAsRoot
Line 156: def testHostSampleReportsNewInterface(self):
Line 157: hs_before = sampling.HostSample(os.getpid())
--
To view, visit https://gerrit.ovirt.org/40119
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
automat...@ovirt.org has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 4: Build Started (3/5) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1569/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 4: Build Started (1/5) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18339/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 4: Build Started (2/5) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/871/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
Dan Kenigsberg has posted comments on this change.
Change subject: Move udevadm to lib/vdsm
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/40119/3/tests/samplingTests.py
File tests/samplingTests.py:
Line 149: s1 = sampling.InterfaceSample(lo)
Line 150: s1.operstate = 'x'
Line 151: self.assertEquals('operstate:x', s1.connlog_diff(s0))
Line 152:
Line 153: #@brokentest("Broken unless libvirtd is running")
this is a real pep8 error. add a space after the #.
but hey, this change is completely unrelated to settle!
Line 154: @MonkeyPatch(libvirtconnection, '_read_password', read_password)
Line 155: @ValidateRunningAsRoot
Line 156: def testHostSampleReportsNewInterface(self):
Line 157: hs_before = sampling.HostSample(os.getpid())
--
To view, visit https://gerrit.ovirt.org/40119
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
Nir Soffer has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 3: Code-Review+1 Please check why jenkins is complaining; it is know to be grumpy and wrong, but sometimes it catches real issues. -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 3: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/862/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/871/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1416/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18263/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1493/ : 0 -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 3: Build Started (5/5) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1493/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 3: Build Started (4/5) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18263/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 3: Build Started (3/5) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1416/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 3: Build Started (2/5) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/871/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 3: -Code-Review -Verified Build Started (1/5) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/862/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
automat...@ovirt.org has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 2: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/848/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/857/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1402/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/87/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18210/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1440/ : 0 -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 2: Build Started (6/6) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1440/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 2: Build Started (5/6) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18210/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 2: Build Started (4/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/87/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
Ido Barkan has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 2: Build Started (1/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/857/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
automat...@ovirt.org has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 2: Build Started (3/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/848/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 2: Build Started (2/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1402/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
Nir Soffer has posted comments on this change.
Change subject: Move udevadm to lib/vdsm
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/40119/1/lib/vdsm/udevadm.py
File lib/vdsm/udevadm.py:
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20:
Line 21: import logging
Line 22: import utils
Please use relative import
Line 23:
Line 24: _UDEVADM = utils.CommandPath("udevadm", "/sbin/udevadm",
"/usr/sbin/udevadm")
Line 25:
Line 26:
--
To view, visit https://gerrit.ovirt.org/40119
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/815/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1381/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18155/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/824/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1369/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/53/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17983/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1212/ : 0 -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 1: Build Started (8/8) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1212/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
Ido Barkan has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 1: Verified+1 verified by importing udevadm from vdsm >>> from vdsm import udevadm -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 1: Build Started (5/8) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18155/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 1: Build Started (7/8) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/824/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 1: Build Started (6/8) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/53/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 1: Build Started (2/8) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1369/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 1: Build Started (3/8) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/815/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 1: Build Started (4/8) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17983/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
Ido Barkan has uploaded a new change for review.
Change subject: Move udevadm to lib/vdsm
..
Move udevadm to lib/vdsm
udevadm is a handy tool that other parts of vdsm could use beside
storage.
Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637
Signed-off-by: Ido Barkan
---
M debian/vdsm-python.install
M debian/vdsm.install
M lib/vdsm/Makefile.am
R lib/vdsm/udevadm.py
M vdsm.spec.in
M vdsm/storage/Makefile.am
M vdsm/storage/multipath.py
M vdsm/storage/storageServer.py
8 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/19/40119/1
diff --git a/debian/vdsm-python.install b/debian/vdsm-python.install
index 9cdf711..2e17c76 100644
--- a/debian/vdsm-python.install
+++ b/debian/vdsm-python.install
@@ -41,6 +41,7 @@
./usr/lib/python2.7/dist-packages/vdsm/tool/upgrade_300_networks.py
./usr/lib/python2.7/dist-packages/vdsm/tool/validate_ovirt_certs.py
./usr/lib/python2.7/dist-packages/vdsm/tool/vdsm-id.py
+./usr/lib/python2.7/dist-packages/vdsm/udevadm.py
./usr/lib/python2.7/dist-packages/vdsm/utils.py
./usr/lib/python2.7/dist-packages/vdsm/vdscli.py
./usr/lib/python2.7/dist-packages/vdsm/virtsparsify.py
diff --git a/debian/vdsm.install b/debian/vdsm.install
index 919398b..6c9ca32 100644
--- a/debian/vdsm.install
+++ b/debian/vdsm.install
@@ -138,7 +138,6 @@
./usr/share/vdsm/storage/taskManager.py
./usr/share/vdsm/storage/threadLocal.py
./usr/share/vdsm/storage/threadPool.py
-./usr/share/vdsm/storage/udevadm.py
./usr/share/vdsm/storage/volume.py
./usr/share/vdsm/supervdsm.py
./usr/share/vdsm/supervdsmServer
diff --git a/lib/vdsm/Makefile.am b/lib/vdsm/Makefile.am
index edc79a5..bbbe900 100644
--- a/lib/vdsm/Makefile.am
+++ b/lib/vdsm/Makefile.am
@@ -38,6 +38,7 @@
schedule.py \
sslutils.py \
sysctl.py \
+ udevadm.py \
utils.py \
vdscli.py \
virtsparsify.py \
diff --git a/vdsm/storage/udevadm.py b/lib/vdsm/udevadm.py
similarity index 98%
rename from vdsm/storage/udevadm.py
rename to lib/vdsm/udevadm.py
index 4b4b54a..19d5746 100644
--- a/vdsm/storage/udevadm.py
+++ b/lib/vdsm/udevadm.py
@@ -19,7 +19,7 @@
#
import logging
-from vdsm import utils
+import utils
_UDEVADM = utils.CommandPath("udevadm", "/sbin/udevadm", "/usr/sbin/udevadm")
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 93c7073..19d575d 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1207,7 +1207,6 @@
%{_datadir}/%{vdsm_name}/storage/task.py*
%{_datadir}/%{vdsm_name}/storage/threadLocal.py*
%{_datadir}/%{vdsm_name}/storage/threadPool.py*
-%{_datadir}/%{vdsm_name}/storage/udevadm.py*
%{_datadir}/%{vdsm_name}/storage/volume.py*
%{_datadir}/%{vdsm_name}/storage/imageRepository/__init__.py*
%{_datadir}/%{vdsm_name}/storage/imageRepository/formatConverter.py*
@@ -1351,6 +1350,7 @@
%{python_sitelib}/%{vdsm_name}/schedule.py*
%{python_sitelib}/%{vdsm_name}/sslutils.py*
%{python_sitelib}/%{vdsm_name}/sysctl.py*
+%{python_sitelib}/%{vdsm_name}/udevadm.py*
%{python_sitelib}/%{vdsm_name}/utils.py*
%{python_sitelib}/%{vdsm_name}/vdscli.py*
%{python_sitelib}/%{vdsm_name}/virtsparsify.py*
diff --git a/vdsm/storage/Makefile.am b/vdsm/storage/Makefile.am
index a342efb..4ebe0a2 100644
--- a/vdsm/storage/Makefile.am
+++ b/vdsm/storage/Makefile.am
@@ -69,7 +69,6 @@
task.py \
threadLocal.py \
threadPool.py \
- udevadm.py \
volume.py
dist_vdsmexec_SCRIPTS = \
diff --git a/vdsm/storage/multipath.py b/vdsm/storage/multipath.py
index a1c42b3..20b8ec6 100644
--- a/vdsm/storage/multipath.py
+++ b/vdsm/storage/multipath.py
@@ -30,6 +30,7 @@
from collections import namedtuple
from vdsm import constants
+from vdsm import udevadm
from vdsm import utils
from vdsm.config import config
@@ -38,7 +39,6 @@
import iscsi
import supervdsm
import devicemapper
-import udevadm
DEV_ISCSI = "iSCSI"
DEV_FCP = "FCP"
diff --git a/vdsm/storage/storageServer.py b/vdsm/storage/storageServer.py
index 22a90d1..82c8674 100644
--- a/vdsm/storage/storageServer.py
+++ b/vdsm/storage/storageServer.py
@@ -31,6 +31,7 @@
from vdsm.compat import pickle
from vdsm.config import config
+from vdsm import udevadm
import mount
import fileUtils
@@ -39,7 +40,6 @@
from sync import asyncmethod, AsyncCallStub
from mount import MountError
import storage_exception as se
-import udevadm
class AliasAlreadyRegisteredError(RuntimeError):
--
To view, visit https://gerrit.ovirt.org/40119
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
automat...@ovirt.org has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 1: Build Started (1/8) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1381/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
