Change in vdsm[master]: Only run speed() on nic devices
Itamar Heim has abandoned this change. Change subject: Only run speed() on nic devices .. Abandoned no comment for 30 days post last ping. abandoning. please re-open if/when relevant and/or ping reviewers directly / promote discussion about the patch in the mailing list. -- To view, visit http://gerrit.ovirt.org/13839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I721b823a28cc36498119e67061d462b780105e7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Only run speed() on nic devices
Itamar Heim has posted comments on this change. Change subject: Only run speed() on nic devices .. Patch Set 4: ping? -- To view, visit http://gerrit.ovirt.org/13839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I721b823a28cc36498119e67061d462b780105e7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Only run speed() on nic devices
Dan Kenigsberg has posted comments on this change. Change subject: Only run speed() on nic devices .. Patch Set 4: (1 inline comment) File vdsm/sampling.py Line 487: class HostStatsThread(StatsThread): Line 488: Line 489: A thread that periodically samples host statistics. Line 490: Line 491: def __init__(self, cif, log): *Ouch* for ifmacs' being missing. It only proves my point that the inheritance here is flawed and should be broken. I do not think that we should use it as a reason for making the inheritance even worse... Line 492: self.startTime = time.time() Line 493: self.nics = netinfo.nics() Line 494: bondings = netinfo.bondings() Line 495: ifids = self.nics + bondings -- To view, visit http://gerrit.ovirt.org/13839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I721b823a28cc36498119e67061d462b780105e7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Only run speed() on nic devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: Only run speed() on nic devices .. Patch Set 4: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1405/ (2/3) -- To view, visit http://gerrit.ovirt.org/13839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I721b823a28cc36498119e67061d462b780105e7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Only run speed() on nic devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: Only run speed() on nic devices .. Patch Set 4: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2308/ (1/3) -- To view, visit http://gerrit.ovirt.org/13839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I721b823a28cc36498119e67061d462b780105e7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Only run speed() on nic devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: Only run speed() on nic devices .. Patch Set 4: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2244/ (3/3) -- To view, visit http://gerrit.ovirt.org/13839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I721b823a28cc36498119e67061d462b780105e7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Only run speed() on nic devices
Mark Wu has posted comments on this change. Change subject: Only run speed() on nic devices .. Patch Set 4: Verified Verified by running vdsClient -s 0 getVdsStats on fedora18. -- To view, visit http://gerrit.ovirt.org/13839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I721b823a28cc36498119e67061d462b780105e7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Only run speed() on nic devices
Mark Wu has posted comments on this change. Change subject: Only run speed() on nic devices .. Patch Set 4: (1 inline comment) File vdsm/sampling.py Line 487: class HostStatsThread(StatsThread): Line 488: Line 489: A thread that periodically samples host statistics. Line 490: Line 491: def __init__(self, cif, log): Dan, Sorry, I can't understand why I can't remove arguments from init function. Does it break the inheritance from StatsThread? Thanks! Line 492: self.startTime = time.time() Line 493: self.nics = netinfo.nics() Line 494: bondings = netinfo.bondings() Line 495: ifids = self.nics + bondings -- To view, visit http://gerrit.ovirt.org/13839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I721b823a28cc36498119e67061d462b780105e7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Only run speed() on nic devices
Zhou Zheng Sheng has posted comments on this change. Change subject: Only run speed() on nic devices .. Patch Set 4: (1 inline comment) File vdsm/sampling.py Line 487: class HostStatsThread(StatsThread): Line 488: Line 489: A thread that periodically samples host statistics. Line 490: Line 491: def __init__(self, cif, log): If we initiate HostStatsThread instance by HostStatsThread(arg0, agr1, arg2) It fetches arg3 and arg4 from other place and initiates the StatsThread with these 5 arguments. So in this way, reducing arguments is OK. However sometimes we want the __init__ signatures are the same in these two classes, because the class names can be passed as value to other functions, for example. def f(statsClass): statsClass(arg0, ..., ag4) f(HostStatsThread) Line 492: self.startTime = time.time() Line 493: self.nics = netinfo.nics() Line 494: bondings = netinfo.bondings() Line 495: ifids = self.nics + bondings -- To view, visit http://gerrit.ovirt.org/13839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I721b823a28cc36498119e67061d462b780105e7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
