Zhou Zheng Sheng has posted comments on this change.
Change subject: Only run speed() on nic devices
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File vdsm/sampling.py
Line 487: class HostStatsThread(StatsThread):
Line 488: """
Line 489: A thread that periodically samples host statistics.
Line 490: """
Line 491: def __init__(self, cif, log):
If we initiate HostStatsThread instance by
HostStatsThread(arg0, agr1, arg2)
It fetches arg3 and arg4 from other place and initiates the StatsThread with
these 5 arguments. So in this way, reducing arguments is OK. However sometimes
we want the __init__ signatures are the same in these two classes, because the
class names can be passed as value to other functions, for example.
def f(statsClass):
statsClass(arg0, ..., ag4)
f(HostStatsThread)
Line 492: self.startTime = time.time()
Line 493: self.nics = netinfo.nics()
Line 494: bondings = netinfo.bondings()
Line 495: ifids = self.nics + bondings
--
To view, visit http://gerrit.ovirt.org/13839
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I721b823a28cc36498119e67061d462b780105e7b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
