Change in vdsm[master]: Remove _udevrulesdir global macro
gerrit-hooks has posted comments on this change. Change subject: Remove _udevrulesdir global macro .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/62196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c55297cdf08c5bc2484792a171880ee2fef25da Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Remove _udevrulesdir global macro
Nir Soffer has posted comments on this change. Change subject: Remove _udevrulesdir global macro .. Patch Set 4: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/62196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c55297cdf08c5bc2484792a171880ee2fef25da Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Remove _udevrulesdir global macro
Nir Soffer has submitted this change and it was merged.
Change subject: Remove _udevrulesdir global macro
..
Remove _udevrulesdir global macro
Patch 271dd9bca1288e732f8d80d98a3d022e5c466bcc changed the definition
of the "_udevrulesdir" global macro to use %{_libdir}, and with that
added a regression that prevents the udev rule "12-vdsm-lvm" from
being installed, which causes our logical volumes to be own by root.
This leads to a situation where libvirt cannot access them at all, so
for example, a Vm with a block domain cannot be started.
This patch removes this macro as it's already defined in macros.systemd.
Change-Id: I4c55297cdf08c5bc2484792a171880ee2fef25da
Signed-off-by: Idan Shaby
Reviewed-on: https://gerrit.ovirt.org/62196
Reviewed-by: Yaniv Bronhaim
Reviewed-by: Allon Mureinik
Tested-by: Eyal Edri
Reviewed-by: Nir Soffer
Continuous-Integration: Nir Soffer
---
M vdsm.spec.in
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Nir Soffer: Looks good to me, approved; Passed CI tests
Eyal Edri: Verified
Yaniv Bronhaim: Looks good to me, but someone else must approve
Allon Mureinik: Looks good to me, but someone else must approve
Idan Shaby: Verified
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/62196
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c55297cdf08c5bc2484792a171880ee2fef25da
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Eyal Edri
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Idan Shaby
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Tal Nisan
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Remove _udevrulesdir global macro
Eyal Edri has posted comments on this change. Change subject: Remove _udevrulesdir global macro .. Patch Set 4: Verified+1 test worked with this patch. -- To view, visit https://gerrit.ovirt.org/62196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c55297cdf08c5bc2484792a171880ee2fef25da Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Remove _udevrulesdir global macro
Eyal Edri has posted comments on this change. Change subject: Remove _udevrulesdir global macro .. Patch Set 4: running: http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_master/746/console -- To view, visit https://gerrit.ovirt.org/62196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c55297cdf08c5bc2484792a171880ee2fef25da Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Remove _udevrulesdir global macro
Eyal Edri has posted comments on this change. Change subject: Remove _udevrulesdir global macro .. Patch Set 4: i published the new ioprocess to the repos, the test job should run shortly -- To view, visit https://gerrit.ovirt.org/62196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c55297cdf08c5bc2484792a171880ee2fef25da Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Remove _udevrulesdir global macro
Eyal Edri has posted comments on this change. Change subject: Remove _udevrulesdir global macro .. Patch Set 4: -Verified Allon, this is exactly what i'm trying to do, run the experimental flow on this patch.. if you're positive it works, lets merge, if we can wait for 30 min, maybe we can get verification on the job... -- To view, visit https://gerrit.ovirt.org/62196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c55297cdf08c5bc2484792a171880ee2fef25da Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Remove _udevrulesdir global macro
Eyal Edri has posted comments on this change. Change subject: Remove _udevrulesdir global macro .. Patch Set 4: for some reason the ioprocess build artifacts didn't run from june, i run it once manually and it created newer rpms from august: http://jenkins.ovirt.org/job/ioprocess_master_build-artifacts-el7-x86_64/ i'm running the publisher now to deploy it nightly and then we can retest this. -- To view, visit https://gerrit.ovirt.org/62196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c55297cdf08c5bc2484792a171880ee2fef25da Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Remove _udevrulesdir global macro
Allon Mureinik has posted comments on this change. Change subject: Remove _udevrulesdir global macro .. Patch Set 4: Code-Review+1 The CI error seems unrelated to the patch. Needs to be fixed, but shouldn't block a critical patch that reverts the complete breakage of block storage. -- To view, visit https://gerrit.ovirt.org/62196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c55297cdf08c5bc2484792a171880ee2fef25da Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Remove _udevrulesdir global macro
Eyal Edri has posted comments on this change. Change subject: Remove _udevrulesdir global macro .. Patch Set 4: Verified-1 failing on missing ioprocess 0.17 from repo: Package rpm-build-4.11.3-17.el7.x86_64 already installed and latest version DEBUG util.py:421: Error: Package: python-ioprocess-0.17.0-1.201608101414.gitbd272f2.el7.centos.noarch (ovirt-snapshot) DEBUG util.py:421: Requires: ioprocess = 0.17.0-1.201608101414.gitbd272f2.el7.centos DEBUG util.py:421: Available: ioprocess-0.15.1-1.el7.x86_64 (centos-epel) DEBUG util.py:421: ioprocess = 0.15.1-1.el7 DEBUG util.py:421: Available: ioprocess-0.17.0-1.201606160904.gitbd272f2.el7.centos.x86_64 (ovirt-snapshot) DEBUG util.py:421: ioprocess = 0.17.0-1.201606160904.gitbd272f2.el7.centos DEBUG util.py:421: You could try using --skip-broken to work around the problem DEBUG util.py:421: You could try running: rpm -Va --nofiles --nodigest -- To view, visit https://gerrit.ovirt.org/62196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c55297cdf08c5bc2484792a171880ee2fef25da Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Remove _udevrulesdir global macro
Yaniv Bronhaim has posted comments on this change. Change subject: Remove _udevrulesdir global macro .. Patch Set 4: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/62196/4//COMMIT_MSG Commit Message: Line 12: being installed, which causes our logical volumes to be own by root. Line 13: This leads to a situation where libvirt cannot access them at all, so Line 14: for example, a Vm with a block domain cannot be started. Line 15: Line 16: This patch removes this macro as it's already defined in macros.systemd. I think saying this line if enough for this patch.. Line 17: Line 18: Change-Id: I4c55297cdf08c5bc2484792a171880ee2fef25da -- To view, visit https://gerrit.ovirt.org/62196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c55297cdf08c5bc2484792a171880ee2fef25da Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Remove _udevrulesdir global macro
gerrit-hooks has posted comments on this change. Change subject: Remove _udevrulesdir global macro .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c55297cdf08c5bc2484792a171880ee2fef25da Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Remove _udevrulesdir global macro
gerrit-hooks has posted comments on this change. Change subject: Remove _udevrulesdir global macro .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c55297cdf08c5bc2484792a171880ee2fef25da Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Remove _udevrulesdir global macro
Idan Shaby has posted comments on this change. Change subject: Remove _udevrulesdir global macro .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/62196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c55297cdf08c5bc2484792a171880ee2fef25da Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
