Change in vdsm[master]: Revert "hostdev: don't implicitly reattach devices"

2016-04-14 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: Revert "hostdev: don't implicitly reattach devices"
..


Patch Set 2: Code-Review+1

we now have a plan to go forward

-- 
To view, visit https://gerrit.ovirt.org/56013
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia46068b4905d480e50957d3611bd9ae74e45a77d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Revert "hostdev: don't implicitly reattach devices"

2016-04-14 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: Revert "hostdev: don't implicitly reattach devices"
..


Revert "hostdev: don't implicitly reattach devices"

This reverts commit 2bdcf4f99e4723f08886 as SR-IOV feature
depends on implicit reattchement of VFs. Commit 74ac384510b
makes sure that the reversal would affect only SRIOV NICs
and not generic host devices.

Change-Id: Ia46068b4905d480e50957d3611bd9ae74e45a77d
Signed-off-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/56013
Continuous-Integration: Jenkins CI
Reviewed-by: Martin Polednik 
Reviewed-by: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 12 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve
  Martin Polednik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/56013
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia46068b4905d480e50957d3611bd9ae74e45a77d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Revert "hostdev: don't implicitly reattach devices"

2016-04-14 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Revert "hostdev: don't implicitly reattach devices"
..


Patch Set 2: Code-Review+2 Verified+1

copying V+1

-- 
To view, visit https://gerrit.ovirt.org/56013
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia46068b4905d480e50957d3611bd9ae74e45a77d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Revert "hostdev: don't implicitly reattach devices"

2016-04-14 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Revert "hostdev: don't implicitly reattach devices"
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/56013
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia46068b4905d480e50957d3611bd9ae74e45a77d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Revert "hostdev: don't implicitly reattach devices"

2016-04-14 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: Revert "hostdev: don't implicitly reattach devices"
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56013
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia46068b4905d480e50957d3611bd9ae74e45a77d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Revert "hostdev: don't implicitly reattach devices"

2016-04-14 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Revert "hostdev: don't implicitly reattach devices"
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56013
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia46068b4905d480e50957d3611bd9ae74e45a77d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Revert "hostdev: don't implicitly reattach devices"

2016-04-12 Thread michal . skrivanek 
Michal Skrivanek has posted comments on this change.

Change subject: Revert "hostdev: don't implicitly reattach devices"
..


Patch Set 1: Code-Review-1

this may make sense for 3.6, but on master the engine code should be more smart 
and not depend on reattach. it proved dangerous and it should not be needed. Or 
can you please explain in more detail why it needs to be attached on the host?

-- 
To view, visit https://gerrit.ovirt.org/56013
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia46068b4905d480e50957d3611bd9ae74e45a77d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Revert "hostdev: don't implicitly reattach devices"

2016-04-12 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: Revert "hostdev: don't implicitly reattach devices"
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/56013/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1256: pass
Line 1257: 
Line 1258: cleanup_guest_socket(self._guestSocketFile)
Line 1259: 
Line 1260: def _reattachHostDevices(self):
> can we do this - maybe in a later patch - only for NICs?
It doesn't really change the fact that engine/networking code should not depend 
on the driver providing interface on top of device AFTER it has already 
provided this information.
Line 1261: # reattach host devices
Line 1262: for dev_name, _ in self._host_devices():
Line 1263: self.log.debug('Reattaching device %s to host.' % 
dev_name)
Line 1264: try:


-- 
To view, visit https://gerrit.ovirt.org/56013
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia46068b4905d480e50957d3611bd9ae74e45a77d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Revert "hostdev: don't implicitly reattach devices"

2016-04-12 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: Revert "hostdev: don't implicitly reattach devices"
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/56013/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1256: pass
Line 1257: 
Line 1258: cleanup_guest_socket(self._guestSocketFile)
Line 1259: 
Line 1260: def _reattachHostDevices(self):
can we do this - maybe in a later patch - only for NICs?
Martin, thoughts?
Line 1261: # reattach host devices
Line 1262: for dev_name, _ in self._host_devices():
Line 1263: self.log.debug('Reattaching device %s to host.' % 
dev_name)
Line 1264: try:


-- 
To view, visit https://gerrit.ovirt.org/56013
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia46068b4905d480e50957d3611bd9ae74e45a77d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Revert "hostdev: don't implicitly reattach devices"

2016-04-12 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: Revert "hostdev: don't implicitly reattach devices"
..


Patch Set 1: Code-Review+1

if we need 55993, we also need this one.

-- 
To view, visit https://gerrit.ovirt.org/56013
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia46068b4905d480e50957d3611bd9ae74e45a77d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Revert "hostdev: don't implicitly reattach devices"

2016-04-12 Thread danken 
Dan Kenigsberg has uploaded a new change for review.

Change subject: Revert "hostdev: don't implicitly reattach devices"
..

Revert "hostdev: don't implicitly reattach devices"

This reverts commit 2bdcf4f99e4723f08886 as SR-IOV feature
depends on implicit reattchement of VFs. Commit 74ac384510b
makes sure that the reversal would affect only SRIOV NICs
and not generic host devices.

Change-Id: Ia46068b4905d480e50957d3611bd9ae74e45a77d
Signed-off-by: Dan Kenigsberg 
---
M vdsm/virt/vm.py
1 file changed, 11 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/56013/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 08a20be..c52e509 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1257,6 +1257,16 @@
 
 cleanup_guest_socket(self._guestSocketFile)
 
+def _reattachHostDevices(self):
+# reattach host devices
+for dev_name, _ in self._host_devices():
+self.log.debug('Reattaching device %s to host.' % dev_name)
+try:
+hostdev.reattach_detachable(dev_name)
+except hostdev.NoIOMMUSupportException:
+self.log.exception('Could not reattach device %s back to host '
+   'due to missing IOMMU support.')
+
 def _host_devices(self):
 for device in self._devices[hwclass.NIC][:]:
 if device.is_hostdevice:
@@ -1678,6 +1688,7 @@
 self._cleanupFloppy()
 self._cleanupGuestAgent()
 cleanup_guest_socket(self._qemuguestSocketFile)
+self._reattachHostDevices()
 self._cleanupStatsCache()
 numa.invalidateNumaCache(self)
 for con in self._devices[hwclass.CONSOLE]:


-- 
To view, visit https://gerrit.ovirt.org/56013
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia46068b4905d480e50957d3611bd9ae74e45a77d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Revert "hostdev: don't implicitly reattach devices"

2016-04-12 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Revert "hostdev: don't implicitly reattach devices"
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/56013
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia46068b4905d480e50957d3611bd9ae74e45a77d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches