Change in vdsm[master]: Test: regression test to catch cross imports.
Dan Kenigsberg has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 31: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Dan Kenigsberg has submitted this change and it was merged. Change subject: Test: regression test to catch cross imports. .. Test: regression test to catch cross imports. This test is useful to catch non legal imports in lib/vdsm. Lib modules cannot use/depend upon regular (non python package vdsm) modules: for example lib/vdscli.py can't depend on vdsm/guestIF.py module. This test updates the PYTHONPATH by removing the regular vdsm modules, later it tries to import lib modules, if there are non legal imports an ImportError is raised. The error message reports the traceback showing the non legal import. Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Signed-off-by: Giuseppe Vallarelli --- M .gitignore M tests/Makefile.am A tests/crossImportsTests.py.in 3 files changed, 77 insertions(+), 0 deletions(-) Approvals: Giuseppe Vallarelli: Verified Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Antoni Segura Puimedon has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 31: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Giuseppe Vallarelli has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 31: Verified -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 31: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2325/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1489/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2392/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 31: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2325/ (3/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 31: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1489/ (1/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 31: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2392/ (2/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Antoni Segura Puimedon has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 30: Looks good to me, but someone else must approve Thanks Giuseppe. I think that this should do it. -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Giuseppe Vallarelli has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 30: Verified -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 30: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2296/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1457/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2361/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 30: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1457/ (3/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 30: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2361/ (1/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 30: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2296/ (2/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 29: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2294/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1455/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2359/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 29: No score Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2359/ (3/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 29: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2294/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1455/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2358/ : FAILURE -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 29: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1455/ (1/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 29: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2358/ (3/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 29: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2294/ (2/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 28: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2293/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1454/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2357/ : FAILURE -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 28: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2357/ (2/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 28: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2293/ (3/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 28: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1454/ (1/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 27: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1453/ (3/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 27: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2356/ (1/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 27: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2292/ (2/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 26: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2291/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1452/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2355/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 26: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2355/ (2/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 26: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2291/ (3/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 26: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1452/ (1/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 25: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1451/ (1/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 25: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2290/ (3/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 25: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2354/ (2/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Giuseppe Vallarelli has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 24: @Toni, I knew you had your -1 red card ready in your pocket! :-D I'll have a try to solve the issue. -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Antoni Segura Puimedon has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 24: I would prefer that you didn't submit this (1 inline comment) File tests/crossImportsTests.py.in Line 43: Line 44: @MonkeyPatch(sys, 'path', path_without_vdsm_ext_mod()) Line 45: def test_fail_when_importing_ext_mod(self): Line 46: paths = ['@VDSMDIR@', '../lib/vdsm'] Line 47: for path in paths: Could you not add here a check to see if the path exists and only do the imports in that case? -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Antoni Segura Puimedon has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 24: Fails In that case :( -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Giuseppe Vallarelli has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 24: but I'm always open listening for some hints :-) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Giuseppe Vallarelli has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 24: No score if "running the tests on vdsm-tests" (cut) you mean cd-ing in /usr/share/vdsm/tests and from there running the tests. Then it's not going to work due to the relative path '../lib/vdsm' . -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Antoni Segura Puimedon has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 24: Looks good to me, but someone else must approve Let's make sure that it works when running the tests on the source dir and also when having them installed from vdsm-tests -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Giuseppe Vallarelli has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 24: Verified -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 24: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2281/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1442/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2345/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Giuseppe Vallarelli has posted comments on this change.
Change subject: Test: regression test to catch cross imports.
..
Patch Set 23: (1 inline comment)
File tests/crossImportsTests.py.in
Line 31: for sub_dir in sub_dirs]
Line 32: new_path = [path for path in sys.path
Line 33: if os.path.abspath(path)
Line 34: not in exclude_dirs]
Line 35: return new_path
Done
Line 36:
Line 37:
Line 38: def get_mods(path):
Line 39: return [(file.strip('.py')).strip('.pyc') for file in
--
To view, visit http://gerrit.ovirt.org/14311
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Livnat Peer
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 24: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1442/ (3/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 24: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2345/ (1/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 24: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2281/ (2/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Antoni Segura Puimedon has posted comments on this change.
Change subject: Test: regression test to catch cross imports.
..
Patch Set 23: I would prefer that you didn't submit this
(1 inline comment)
Only a minor comment.
File tests/crossImportsTests.py.in
Line 31: for sub_dir in sub_dirs]
Line 32: new_path = [path for path in sys.path
Line 33: if os.path.abspath(path)
Line 34: not in exclude_dirs]
Line 35: return new_path
I'd rather have it without the extra variable.
return [path for path in sys.path
if os.path.abspath(path) not in exclude_dirs]
If that is not possible... How about just having the not in line 33 considering
it fits there perfectly?
Line 36:
Line 37:
Line 38: def get_mods(path):
Line 39: return [(file.strip('.py')).strip('.pyc') for file in
--
To view, visit http://gerrit.ovirt.org/14311
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Livnat Peer
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Giuseppe Vallarelli has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 23: Verified -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 23: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2277/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1438/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2341/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 23: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1438/ (3/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 23: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2277/ (2/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 23: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2341/ (1/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 22: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2275/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1436/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2339/ : FAILURE -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 22: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1436/ (3/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 22: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2275/ (2/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 22: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2339/ (1/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2274/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1435/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2338/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 21: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2274/ (3/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 21: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2338/ (1/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 21: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1435/ (2/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Giuseppe Vallarelli has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 20: Verified -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 20: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2260/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1421/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2324/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 20: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2260/ (3/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 20: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1421/ (2/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 20: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2324/ (1/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Giuseppe Vallarelli has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 19: (2 inline comments) File tests/crossImportsTests.py.in Line 27: Line 28: def path_without_vdsm_ext_mod(): Line 29: sub_dirs = ['client', 'vdsm', 'vdsm_api'] Line 30: exclude_dirs = [os.path.abspath( Line 31: os.path.join(os.path.dirname(__file__), '..', sub_dir)) You're probably right, I'm not so sure now about which installation and non installation paths to include/exclude. This test started as a simple way to check dependencies of modules in lib/vdsm towards modules available in different dirs. Line 32: for sub_dir in sub_dirs] Line 33: new_path = list(it.ifilterfalse( Line 34: lambda x: os.path.abspath(x) in exclude_dirs, sys.path)) Line 35: return new_path Line 30: exclude_dirs = [os.path.abspath( Line 31: os.path.join(os.path.dirname(__file__), '..', sub_dir)) Line 32: for sub_dir in sub_dirs] Line 33: new_path = list(it.ifilterfalse( Line 34: lambda x: os.path.abspath(x) in exclude_dirs, sys.path)) Thanks for the feedback is simpler in the way you suggest. Line 35: return new_path Line 36: Line 37: Line 38: def get_mods(path): -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Antoni Segura Puimedon has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 19: I would prefer that you didn't submit this (2 inline comments) File tests/crossImportsTests.py.in Line 27: Line 28: def path_without_vdsm_ext_mod(): Line 29: sub_dirs = ['client', 'vdsm', 'vdsm_api'] Line 30: exclude_dirs = [os.path.abspath( Line 31: os.path.join(os.path.dirname(__file__), '..', sub_dir)) Shouldn't exclude_dirs reference also /usr/share/vdsm (rather the macro for it), and such other installation directories to make sure that the interpreter does not get the modules from there? Line 32: for sub_dir in sub_dirs] Line 33: new_path = list(it.ifilterfalse( Line 34: lambda x: os.path.abspath(x) in exclude_dirs, sys.path)) Line 35: return new_path Line 30: exclude_dirs = [os.path.abspath( Line 31: os.path.join(os.path.dirname(__file__), '..', sub_dir)) Line 32: for sub_dir in sub_dirs] Line 33: new_path = list(it.ifilterfalse( Line 34: lambda x: os.path.abspath(x) in exclude_dirs, sys.path)) I'd rather have: return [path for path in sys.path if os.path.abspath(path) not in exclude_dirs] Line 35: return new_path Line 36: Line 37: Line 38: def get_mods(path): -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Giuseppe Vallarelli has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 19: There was a problem in the job config in jenkins. Now is fixed. -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 19: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2206/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1367/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2289/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 19: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2289/ (3/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 19: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2206/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1367/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2288/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 19: No score Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2288/ (3/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 19: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2206/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1367/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2268/ : FAILURE -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 19: No score Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2268/ (3/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Giuseppe Vallarelli has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 19: '@VDSMDIR@' is substituted on my env with '/usr/share/vdsm' on jenkins with '/usr/local/share/vdsm' -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 19: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2267/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2206/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1367/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 19: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2267/ (2/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 19: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1367/ (1/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 19: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2206/ (3/3) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Giuseppe Vallarelli has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 18: Now it's more simple but it can still be improved. I'm not able to substitute that vdsm lib dir path with VDSMLIBDIR via a variable expansion (the idea is to have a crossImportsTests.py.in). Feedback highly appreciated :) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 18: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2241/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2180/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 18: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2241/ (1/2) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 18: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2180/ (2/2) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 17: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2238/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2177/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 17: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2177/ (1/2) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 17: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2238/ (2/2) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 16: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2227/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2166/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 16: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2166/ (2/2) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 16: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2227/ (1/2) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Giuseppe Vallarelli has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 15: Thanks for the feedback. -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
Dan Kenigsberg has posted comments on this change.
Change subject: Test: regression test to catch cross imports.
..
Patch Set 15: I would prefer that you didn't submit this
(5 inline comments)
Thanks
File tests/crossImportsTests.py
Line 38: class CrossImportsTestCaseShould(TestCaseBase):
Line 39:
Line 40: def test_fail_when_importing_ext_mod(self):
Line 41: path_backup = sys.path
Line 42: sys.path = path_without_vdsm_ext_mod()
Playing with sys.path is dangerous. Better use the monkeypatch module.
Line 43: import_ext_mod = False
Line 44: try:
Line 45: mods = [file.strip('.py') for file in
Line 46: os.listdir(os.path.abspath('../lib/vdsm'))
Line 41: path_backup = sys.path
Line 42: sys.path = path_without_vdsm_ext_mod()
Line 43: import_ext_mod = False
Line 44: try:
Line 45: mods = [file.strip('.py') for file in
this assignment is not expected to raise ImportError, so it should sit outside
of the try-except block.
Line 46: os.listdir(os.path.abspath('../lib/vdsm'))
Line 47: if file.endswith(".py")]
Line 48: __import__('vdsm', fromlist=mods)
Line 49: except ImportError:
Line 42: sys.path = path_without_vdsm_ext_mod()
Line 43: import_ext_mod = False
Line 44: try:
Line 45: mods = [file.strip('.py') for file in
Line 46: os.listdir(os.path.abspath('../lib/vdsm'))
the test should succeed also when vdsm-tests.rpm is installed, and there is no
../lib/vdsm directory. Preferably if only .pyc are present, too.
Line 47: if file.endswith(".py")]
Line 48: __import__('vdsm', fromlist=mods)
Line 49: except ImportError:
Line 50: import_ext_mod = True
Line 46: os.listdir(os.path.abspath('../lib/vdsm'))
Line 47: if file.endswith(".py")]
Line 48: __import__('vdsm', fromlist=mods)
Line 49: except ImportError:
Line 50: import_ext_mod = True
I do not see the grand benefit of collecting all failures. Your code would be
simpler if you raise on the first failure, and it would usually be enough.
Line 51: e_type, e_value, e_tb = sys.exc_info()
Line 52: msg = 'Fail due to: %s' % (''.join(fmt_exc(e_type,
e_value, e_tb)))
Line 53: sys.path = path_backup
Line 54:
Line 51: e_type, e_value, e_tb = sys.exc_info()
Line 52: msg = 'Fail due to: %s' % (''.join(fmt_exc(e_type,
e_value, e_tb)))
Line 53: sys.path = path_backup
Line 54:
Line 55: assert import_ext_mod is False, msg
use self.assertTrue() to give nose more control on how to handle assertions.
--
To view, visit http://gerrit.ovirt.org/14311
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2219/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2158/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 15: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2158/ (2/2) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 15: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2219/ (1/2) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 14: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2218/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2157/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 14: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2218/ (1/2) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 14: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2157/ (2/2) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 13: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2135/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2196/ : FAILURE -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 13: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2135/ (2/2) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Test: regression test to catch cross imports.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Test: regression test to catch cross imports. .. Patch Set 13: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2196/ (1/2) -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
