Change in vdsm[master]: always teardown snapshot's memory volume
Arik Hadas has uploaded a new change for review. Change subject: always teardown snapshot's memory volume .. always teardown snapshot's memory volume Change-Id: If59047f7d5ba6cfa942b593683f6f9987619a7ea Signed-off-by: Arik Hadas --- M vdsm/virt/vm.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/26544/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index b8ce533..3982116 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -3680,6 +3680,7 @@ # with size that is not multiple of block size correctly. if memoryParams: _padMemoryVolume(memoryVolPath, memoryVol['domainID']) +# Teardown should happen anyway (also in case of exceptions). self.cif.teardownVolumePath(memoryVol) for drive in newDrives.values(): # Update the drive information -- To view, visit http://gerrit.ovirt.org/26544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If59047f7d5ba6cfa942b593683f6f9987619a7ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: always teardown snapshot's memory volume
oVirt Jenkins CI Server has posted comments on this change. Change subject: always teardown snapshot's memory volume .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7908/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7118/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/8020/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If59047f7d5ba6cfa942b593683f6f9987619a7ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: always teardown snapshot's memory volume
Dan Kenigsberg has posted comments on this change. Change subject: always teardown snapshot's memory volume .. Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/26544/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3679: # This code should be removed once qemu-img will handle files Line 3680: # with size that is not multiple of block size correctly. Line 3681: if memoryParams: Line 3682: _padMemoryVolume(memoryVolPath, memoryVol['domainID']) Line 3683: # Teardown should happen anyway (also in case of exceptions). not if an exception is raised from within _padMemoryVolume(). Line 3684: self.cif.teardownVolumePath(memoryVol) Line 3685: Line 3686: for drive in newDrives.values(): # Update the drive information Line 3687: try: -- To view, visit http://gerrit.ovirt.org/26544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If59047f7d5ba6cfa942b593683f6f9987619a7ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: always teardown snapshot's memory volume
Michal Skrivanek has posted comments on this change. Change subject: always teardown snapshot's memory volume .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/26544/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3649: # is to prevent spurious libvirt errors about missing drive paths Line 3650: # (since we're changing them), and also to prevent to trigger a drive Line 3651: # extension for the new volume with the apparent size of the old one Line 3652: # (the apparentsize is updated as last step in updateDriveParameters) Line 3653: self.stopDisksStatsCollection() Arik, just wondering…once we do the real live RAM snapshot the above must not happen since the VM continues to run Line 3654: Line 3655: try: Line 3656: try: Line 3657: self._dom.snapshotCreateXML(snapxml, snapFlags) Line 3680: # with size that is not multiple of block size correctly. Line 3681: if memoryParams: Line 3682: _padMemoryVolume(memoryVolPath, memoryVol['domainID']) Line 3683: # Teardown should happen anyway (also in case of exceptions). Line 3684: self.cif.teardownVolumePath(memoryVol) how about a "if memoryVolPath" in the "finally" section? Line 3685: Line 3686: for drive in newDrives.values(): # Update the drive information Line 3687: try: Line 3688: self.updateDriveParameters(drive) -- To view, visit http://gerrit.ovirt.org/26544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If59047f7d5ba6cfa942b593683f6f9987619a7ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: always teardown snapshot's memory volume
Arik Hadas has posted comments on this change. Change subject: always teardown snapshot's memory volume .. Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/26544/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3649: # is to prevent spurious libvirt errors about missing drive paths Line 3650: # (since we're changing them), and also to prevent to trigger a drive Line 3651: # extension for the new volume with the apparent size of the old one Line 3652: # (the apparentsize is updated as last step in updateDriveParameters) Line 3653: self.stopDisksStatsCollection() > Arik, just wondering…once we do the real live RAM snapshot the above must n I'm not sure, but I see that it is also called from diskReplicateFinish which is part of live-storage-migration - similar flow to real live snapshot since in both cases the VM is running and the volume we're writing to is changed. so I think it would still be needed Line 3654: Line 3655: try: Line 3656: try: Line 3657: self._dom.snapshotCreateXML(snapxml, snapFlags) Line 3679: # This code should be removed once qemu-img will handle files Line 3680: # with size that is not multiple of block size correctly. Line 3681: if memoryParams: Line 3682: _padMemoryVolume(memoryVolPath, memoryVol['domainID']) Line 3683: # Teardown should happen anyway (also in case of exceptions). > not if an exception is raised from within _padMemoryVolume(). right right, it was just a TODO for me :) sorry for the confusion Line 3684: self.cif.teardownVolumePath(memoryVol) Line 3685: Line 3686: for drive in newDrives.values(): # Update the drive information Line 3687: try: Line 3680: # with size that is not multiple of block size correctly. Line 3681: if memoryParams: Line 3682: _padMemoryVolume(memoryVolPath, memoryVol['domainID']) Line 3683: # Teardown should happen anyway (also in case of exceptions). Line 3684: self.cif.teardownVolumePath(memoryVol) > how about a "if memoryVolPath" in the "finally" section? Done Line 3685: Line 3686: for drive in newDrives.values(): # Update the drive information Line 3687: try: Line 3688: self.updateDriveParameters(drive) -- To view, visit http://gerrit.ovirt.org/26544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If59047f7d5ba6cfa942b593683f6f9987619a7ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: always teardown snapshot's memory volume
Michal Skrivanek has posted comments on this change. Change subject: always teardown snapshot's memory volume .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26544/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3649: # is to prevent spurious libvirt errors about missing drive paths Line 3650: # (since we're changing them), and also to prevent to trigger a drive Line 3651: # extension for the new volume with the apparent size of the old one Line 3652: # (the apparentsize is updated as last step in updateDriveParameters) Line 3653: self.stopDisksStatsCollection() > I'm not sure, but I see that it is also called from diskReplicateFinish whi Federico, what do you say? Why is it ok to stop stats during live-storage-migration? Line 3654: Line 3655: try: Line 3656: try: Line 3657: self._dom.snapshotCreateXML(snapxml, snapFlags) -- To view, visit http://gerrit.ovirt.org/26544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If59047f7d5ba6cfa942b593683f6f9987619a7ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: always teardown snapshot's memory volume
oVirt Jenkins CI Server has posted comments on this change. Change subject: always teardown snapshot's memory volume .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8984/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9125/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8196/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If59047f7d5ba6cfa942b593683f6f9987619a7ea Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: always teardown snapshot's memory volume
Dan Kenigsberg has posted comments on this change. Change subject: always teardown snapshot's memory volume .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/26544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If59047f7d5ba6cfa942b593683f6f9987619a7ea Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: always teardown snapshot's memory volume
Arik Hadas has posted comments on this change. Change subject: always teardown snapshot's memory volume .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/26544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If59047f7d5ba6cfa942b593683f6f9987619a7ea Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: always teardown snapshot's memory volume
Francesco Romani has posted comments on this change. Change subject: always teardown snapshot's memory volume .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If59047f7d5ba6cfa942b593683f6f9987619a7ea Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: always teardown snapshot's memory volume
Dan Kenigsberg has submitted this change and it was merged. Change subject: always teardown snapshot's memory volume .. always teardown snapshot's memory volume Teardown the memory volume of snapshot with memory as part of 'finally' block to ensure it is done in case an exception is thrown in the 'snapshot' method as well. Change-Id: If59047f7d5ba6cfa942b593683f6f9987619a7ea Signed-off-by: Arik Hadas Reviewed-on: http://gerrit.ovirt.org/26544 Reviewed-by: Dan Kenigsberg Reviewed-by: Francesco Romani --- M vdsm/virt/vm.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/26544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If59047f7d5ba6cfa942b593683f6f9987619a7ea Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: always teardown snapshot's memory volume
oVirt Jenkins CI Server has posted comments on this change. Change subject: always teardown snapshot's memory volume .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1340/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If59047f7d5ba6cfa942b593683f6f9987619a7ea Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
