Change in vdsm[master]: events: sending stats with vm status change event
automat...@ovirt.org has posted comments on this change. Change subject: events: sending stats with vm status change event .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/40204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: sending stats with vm status change event
Piotr Kliczewski has abandoned this change. Change subject: events: sending stats with vm status change event .. Abandoned This patch was squashed with vm status notifications. -- To view, visit https://gerrit.ovirt.org/40204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: sending stats with vm status change event
Piotr Kliczewski has posted comments on this change.
Change subject: events: sending stats with vm status change event
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/40204/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 368: return status
Line 369:
Line 370: def _set_lastStatus(self, value):
Line 371: with self._statusLock:
Line 372: self._send_status_event(value)
> possibly. though till now it didn't really matter as it has no significance
Done
Line 373: if self._lastStatus == vmstatus.DOWN:
Line 374: self.log.warning(
Line 375: 'trying to set state to %s when already Down',
Line 376: value)
Line 386:
Line 387: def _send_status_event(self, value):
Line 388: if self.lastStatus == vmstatus.DOWN:
Line 389: stats = self._getExitedVmStats()
Line 390: else:
> we would need to dissect it more as some of the guest stats are currently n
I am happy to make sure that the engine is able to process. Please provide your
suggestion what should be sent.
Line 391: stats = self._getConfigVmStats()
Line 392: stats.update(self._getRunningVmStats())
Line 393: stats.update(self._getVmStatus())
Line 394:
Line 4635: self.log.warning('monitor become unresponsive'
Line 4636: ' (command timeout, age=%s)',
Line 4637: statsAge)
Line 4638: stats['monitorResponse'] = '-1'
Line 4639: self._send_status_event('NotResponding')
> yes, but vdsm never sent this status. did you check engine's behavior in th
I haven't tested this one. Will need to do a bit more preparation to do it.
Will check.
Line 4640:
Line 4641: def updateNumaInfo(self):
Line 4642: self._numaInfo = numaUtils.getVmNumaNodeRuntimeInfo(self)
Line 4643:
--
To view, visit https://gerrit.ovirt.org/40204
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: sending stats with vm status change event
Michal Skrivanek has posted comments on this change.
Change subject: events: sending stats with vm status change event
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/40204/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 368: return status
Line 369:
Line 370: def _set_lastStatus(self, value):
Line 371: with self._statusLock:
Line 372: self._send_status_event(value)
> During testing of my changes I have never received the same status twice. I
possibly. though till now it didn't really matter as it has no significance to
override lastStatus with the same thing. The only special handling is below for
DoubleDown (and yes, I do see it sometimes;-)
should be harmless to send only on a change, no?
Line 373: if self._lastStatus == vmstatus.DOWN:
Line 374: self.log.warning(
Line 375: 'trying to set state to %s when already Down',
Line 376: value)
Line 386:
Line 387: def _send_status_event(self, value):
Line 388: if self.lastStatus == vmstatus.DOWN:
Line 389: stats = self._getExitedVmStats()
Line 390: else:
> I checked the code and I believe that applist is added during _getGuestStat
we would need to dissect it more as some of the guest stats are currently
needed.
I do think this is the right place where to do it.
I'd like to ultimately have a custom structure with the minimum set of fields
engine needs to make an update. Some engine-side changes could be needed
Line 391: stats = self._getConfigVmStats()
Line 392: stats.update(self._getRunningVmStats())
Line 393: stats.update(self._getVmStatus())
Line 394:
Line 4635: self.log.warning('monitor become unresponsive'
Line 4636: ' (command timeout, age=%s)',
Line 4637: statsAge)
Line 4638: stats['monitorResponse'] = '-1'
Line 4639: self._send_status_event('NotResponding')
> NotResponding is part of status enum on the engine side. I think this one a
yes, but vdsm never sent this status. did you check engine's behavior in this
case? (I think just follow the code path is enough at this point)
Line 4640:
Line 4641: def updateNumaInfo(self):
Line 4642: self._numaInfo = numaUtils.getVmNumaNodeRuntimeInfo(self)
Line 4643:
--
To view, visit https://gerrit.ovirt.org/40204
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: sending stats with vm status change event
Piotr Kliczewski has posted comments on this change.
Change subject: events: sending stats with vm status change event
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/40204/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 368: return status
Line 369:
Line 370: def _set_lastStatus(self, value):
Line 371: with self._statusLock:
Line 372: self._send_status_event(value)
> would be better if we send it only on a status change, not all the time. I'
During testing of my changes I have never received the same status twice. I
agree that I do not test all possible scenarios because I am not aware of all
of them.
We can add check to compare and send if different but if we think that the same
status could be set twice in my opinion it is a bug.
Line 373: if self._lastStatus == vmstatus.DOWN:
Line 374: self.log.warning(
Line 375: 'trying to set state to %s when already Down',
Line 376: value)
Line 386:
Line 387: def _send_status_event(self, value):
Line 388: if self.lastStatus == vmstatus.DOWN:
Line 389: stats = self._getExitedVmStats()
Line 390: else:
> this is a nice improvement. Still we should drop few fields - this still do
I checked the code and I believe that applist is added during _getGuestStats()
and this was removed.
I have decided to prepare status separately so we can freely modify. I am open
to any suggestions what need to be send.
Line 391: stats = self._getConfigVmStats()
Line 392: stats.update(self._getRunningVmStats())
Line 393: stats.update(self._getVmStatus())
Line 394:
Line 4635: self.log.warning('monitor become unresponsive'
Line 4636: ' (command timeout, age=%s)',
Line 4637: statsAge)
Line 4638: stats['monitorResponse'] = '-1'
Line 4639: self._send_status_event('NotResponding')
> This is aproblematic one...vdsm doesn't have a NotResponding status, it's
NotResponding is part of status enum on the engine side. I think this one and
'Paused' are problematic statuses for versioning.
Line 4640:
Line 4641: def updateNumaInfo(self):
Line 4642: self._numaInfo = numaUtils.getVmNumaNodeRuntimeInfo(self)
Line 4643:
--
To view, visit https://gerrit.ovirt.org/40204
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: sending stats with vm status change event
oVirt Jenkins CI Server has posted comments on this change. Change subject: events: sending stats with vm status change event .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18277/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1507/ : 0 -- To view, visit https://gerrit.ovirt.org/40204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: sending stats with vm status change event
oVirt Jenkins CI Server has posted comments on this change. Change subject: events: sending stats with vm status change event .. Patch Set 2: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1507/ -- To view, visit https://gerrit.ovirt.org/40204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: sending stats with vm status change event
Michal Skrivanek has posted comments on this change. Change subject: events: sending stats with vm status change event .. Patch Set 2: *tweak the engine code* -- To view, visit https://gerrit.ovirt.org/40204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: sending stats with vm status change event
Michal Skrivanek has posted comments on this change.
Change subject: events: sending stats with vm status change event
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/40204/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 368: return status
Line 369:
Line 370: def _set_lastStatus(self, value):
Line 371: with self._statusLock:
Line 372: self._send_status_event(value)
would be better if we send it only on a status change, not all the time. I'd
suspect sometimes we may set the same status twice
Line 373: if self._lastStatus == vmstatus.DOWN:
Line 374: self.log.warning(
Line 375: 'trying to set state to %s when already Down',
Line 376: value)
Line 386:
Line 387: def _send_status_event(self, value):
Line 388: if self.lastStatus == vmstatus.DOWN:
Line 389: stats = self._getExitedVmStats()
Line 390: else:
this is a nice improvement. Still we should drop few fields - this still does
contain applist I think. Also net and disk stats. Let's talk about the content
outside of the review
Line 391: stats = self._getConfigVmStats()
Line 392: stats.update(self._getRunningVmStats())
Line 393: stats.update(self._getVmStatus())
Line 394:
Line 4635: self.log.warning('monitor become unresponsive'
Line 4636: ' (command timeout, age=%s)',
Line 4637: statsAge)
Line 4638: stats['monitorResponse'] = '-1'
Line 4639: self._send_status_event('NotResponding')
This is aproblematic one...vdsm doesn't have a NotResponding status, it's only
derived in engine when monitorResponse==-1.
Since this is a new code maybe we can tweak the code and introduce this state
on engine side
Line 4640:
Line 4641: def updateNumaInfo(self):
Line 4642: self._numaInfo = numaUtils.getVmNumaNodeRuntimeInfo(self)
Line 4643:
--
To view, visit https://gerrit.ovirt.org/40204
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: sending stats with vm status change event
Piotr Kliczewski has posted comments on this change. Change subject: events: sending stats with vm status change event .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40204/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 368: return status Line 369: Line 370: def _set_lastStatus(self, value): Line 371: with self._statusLock: Line 372: self._send_status_event(value) > Have you considered a race between this event and the periodic getAllVmStat Yes. It is main problem to solve. We want to introduce in memory versioning of status changes. Line 373: if self._lastStatus == vmstatus.DOWN: Line 374: self.log.warning( Line 375: 'trying to set state to %s when already Down', Line 376: value) -- To view, visit https://gerrit.ovirt.org/40204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: sending stats with vm status change event
Dan Kenigsberg has posted comments on this change. Change subject: events: sending stats with vm status change event .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40204/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 368: return status Line 369: Line 370: def _set_lastStatus(self, value): Line 371: with self._statusLock: Line 372: self._send_status_event(value) Have you considered a race between this event and the periodic getAllVmStats ? Line 373: if self._lastStatus == vmstatus.DOWN: Line 374: self.log.warning( Line 375: 'trying to set state to %s when already Down', Line 376: value) -- To view, visit https://gerrit.ovirt.org/40204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: sending stats with vm status change event
oVirt Jenkins CI Server has posted comments on this change. Change subject: events: sending stats with vm status change event .. Patch Set 2: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18277/ -- To view, visit https://gerrit.ovirt.org/40204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: sending stats with vm status change event
Piotr Kliczewski has posted comments on this change. Change subject: events: sending stats with vm status change event .. Patch Set 2: Verified+1 Verified by installing a host, creating vm and seeing events being processed by the engine. There are some issues noticed after suspending a vm but not related to this changes. -- To view, visit https://gerrit.ovirt.org/40204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: sending stats with vm status change event
automat...@ovirt.org has posted comments on this change. Change subject: events: sending stats with vm status change event .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: sending stats with vm status change event
oVirt Jenkins CI Server has posted comments on this change. Change subject: events: sending stats with vm status change event .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18094/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1323/ : 0 -- To view, visit https://gerrit.ovirt.org/40204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: sending stats with vm status change event
oVirt Jenkins CI Server has posted comments on this change. Change subject: events: sending stats with vm status change event .. Patch Set 1: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1323/ -- To view, visit https://gerrit.ovirt.org/40204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: sending stats with vm status change event
Piotr Kliczewski has posted comments on this change.
Change subject: events: sending stats with vm status change event
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/40204/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 785:
Line 786: def _send_status_event(self, value):
Line 787: self.cif.notify('|virt|VM_status|' + self.id,
Line 788: **{self.id: {'status': value,
Line 789: 'stats': self.getStats()}})
> I think we should rather assemble our own set of data instead generic getSt
Yes, We agreed to drop app list from an event. Can you please help me to
understand which "things" to check and which we can ignore without checking?
Line 790:
Line 791: lastStatus = property(_get_lastStatus, _set_lastStatus)
Line 792:
Line 793: def __getNextIndex(self, used):
--
To view, visit https://gerrit.ovirt.org/40204
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: sending stats with vm status change event
Michal Skrivanek has posted comments on this change.
Change subject: events: sending stats with vm status change event
..
Patch Set 1: Code-Review-1
(1 comment)
Vinzenz, Francesco, please help with getting the right content to send.
Each omitted field should be checked against latest engine monitoring code
https://gerrit.ovirt.org/#/c/40204/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 785:
Line 786: def _send_status_event(self, value):
Line 787: self.cif.notify('|virt|VM_status|' + self.id,
Line 788: **{self.id: {'status': value,
Line 789: 'stats': self.getStats()}})
I think we should rather assemble our own set of data instead generic
getStats(). We clearly do not need applist (potentially huge), and quite likely
other things.
I'd start with minimum and check the engine side what's really needed. Our
advantage is that we can consider only 3.6 engine, many legacy fields can be
dropped
Line 790:
Line 791: lastStatus = property(_get_lastStatus, _set_lastStatus)
Line 792:
Line 793: def __getNextIndex(self, used):
--
To view, visit https://gerrit.ovirt.org/40204
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: sending stats with vm status change event
Piotr Kliczewski has posted comments on this change. Change subject: events: sending stats with vm status change event .. Patch Set 1: I have some doubts about this change. Please take a look at changes that I had to make to make the tests to pass. Verified with corresponding engine changes. -- To view, visit https://gerrit.ovirt.org/40204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: sending stats with vm status change event
automat...@ovirt.org has posted comments on this change. Change subject: events: sending stats with vm status change event .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: sending stats with vm status change event
oVirt Jenkins CI Server has posted comments on this change. Change subject: events: sending stats with vm status change event .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18094/ -- To view, visit https://gerrit.ovirt.org/40204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: sending stats with vm status change event
Piotr Kliczewski has uploaded a new change for review.
Change subject: events: sending stats with vm status change event
..
events: sending stats with vm status change event
Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321
Signed-off-by: pkliczew
---
M tests/vmfakelib.py
M vdsm/virt/vm.py
2 files changed, 12 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/40204/1
diff --git a/tests/vmfakelib.py b/tests/vmfakelib.py
index 2f9b32f..10ea8d4 100644
--- a/tests/vmfakelib.py
+++ b/tests/vmfakelib.py
@@ -200,6 +200,10 @@
fake.arch = arch
fake.guestAgent = GuestAgent()
fake.conf['devices'] = [] if devices is None else devices
+# need to update for sending event
+fake.conf['exitCode'] = 0
+fake.conf['exitMessage'] = 'message'
+fake.conf['exitReason'] = 'reason'
fake._guestCpuRunning = runCpu
if status is not None:
fake._lastStatus = status
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 6330158..5e953c9 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -768,7 +768,6 @@
def _set_lastStatus(self, value):
with self._statusLock:
-self.cif.notify('|virt|VM_status|' + self.id, **{self.id: value})
if self._lastStatus == vmstatus.DOWN:
self.log.warning(
'trying to set state to %s when already Down',
@@ -782,6 +781,12 @@
if self._lastStatus != value:
self.saveState()
self._lastStatus = value
+self._send_status_event(value)
+
+def _send_status_event(self, value):
+self.cif.notify('|virt|VM_status|' + self.id,
+**{self.id: {'status': value,
+ 'stats': self.getStats()}})
lastStatus = property(_get_lastStatus, _set_lastStatus)
@@ -1532,8 +1537,7 @@
self._guestCpuRunning = isRunning
if (not self._guestCpuRunning and
self._lastStatus in vmstatus.PAUSED_STATES):
-self.cif.notify('|virt|VM_status|' + self.id,
-**{self.id: 'Paused'})
+self._send_status_event('Paused')
finally:
if not guestCpuLocked:
self._guestCpuLock.release()
@@ -5034,8 +5038,7 @@
' (command timeout, age=%s)',
statsAge)
stats['monitorResponse'] = '-1'
-self.cif.notify('|virt|VM_status|' + self.id,
-**{self.id: 'NotResponding'})
+self._send_status_event('NotResponding')
def updateNumaInfo(self):
self._numaInfo = numaUtils.getVmNumaNodeRuntimeInfo(self)
--
To view, visit https://gerrit.ovirt.org/40204
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
