Change in vdsm[master]: faqemu hook: move memory limitation to config
oVirt Jenkins CI Server has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1546/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5531/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3689/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Dan Kenigsberg has submitted this change and it was merged. Change subject: faqemu hook: move memory limitation to config .. faqemu hook: move memory limitation to config *** WARNING: this patch changes default behaviour for faqemu, increasing memory usage to what is supplied in vmCreate call unless changed in /etc/vdsm/vdsm.conf *** This patch removes memory constraints of faqemu, moving one global constraint to configuration. Setting this to '0' causes memory element not be touched by the hook, using nonzero value sets the memory limit. Usage of > 20 MB memory is required when running faqemu with system kernel/initramfs combo. Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Signed-off-by: Martin Polednik Reviewed-on: http://gerrit.ovirt.org/28320 Reviewed-by: Michal Skrivanek Reviewed-by: Dan Kenigsberg --- M lib/vdsm/config.py.in M vdsm_hooks/faqemu/before_vm_start.py 2 files changed, 10 insertions(+), 11 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve Martin Polednik: Verified -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Dan Kenigsberg has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 5: Code-Review+2 No objection on the mailing list; Gil just gave me an ack over the phone. -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Michal Skrivanek has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 5: Code-Review+1 announcement sent http://lists.ovirt.org/pipermail/devel/2014-June/007643.html also separately to QE group no objections till now, let's go ahead -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
oVirt Jenkins CI Server has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9149/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9934/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10089/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5016/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3173/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Martin Polednik has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Michal Skrivanek has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 4: Code-Review+1 supposing you address my comment -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Michal Skrivanek has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/28320/4/vdsm_hooks/faqemu/before_vm_start.py
File vdsm_hooks/faqemu/before_vm_start.py:
Line 29: graphics = domxml.getElementsByTagName("graphics")[0]
Line 30: graphics.removeAttribute("passwdValidTo")
Line 31:
Line 32: memory = config.get('vars', 'fake_kvm_memory')
Line 33: arch = config.get('vars', 'fake_kvm_architecture')
not needed anymore
Line 34:
Line 35: if memory != '0':
Line 36: for memtag in ("memory", "currentMemory"):
Line 37: memvalue = domxml.getElementsByTagName(memtag)[0]
--
To view, visit http://gerrit.ovirt.org/28320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
oVirt Jenkins CI Server has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9002/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9786/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9941/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Martin Polednik has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 3: -Verified
(1 comment)
http://gerrit.ovirt.org/#/c/28320/3/vdsm_hooks/faqemu/before_vm_start.py
File vdsm_hooks/faqemu/before_vm_start.py:
Line 31:
Line 32: memory = config.get('vars', 'fake_kvm_memory', None)
Line 33: arch = config.get('vars', 'fake_kvm_architecture')
Line 34:
Line 35: if memory is None:
> How can memory be ever "None"? You define its default as '0' (and as such,
I've apparently misunderstood how our config works (missed set_defaults call)...
Line 36: if arch == 'x86_64':
Line 37: memory = '20480'
Line 38: if arch == 'ppc64':
Line 39: memory = '262144'
--
To view, visit http://gerrit.ovirt.org/28320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Dan Kenigsberg has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 3: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/28320/3/vdsm_hooks/faqemu/before_vm_start.py
File vdsm_hooks/faqemu/before_vm_start.py:
Line 31:
Line 32: memory = config.get('vars', 'fake_kvm_memory', None)
Line 33: arch = config.get('vars', 'fake_kvm_architecture')
Line 34:
Line 35: if memory is None:
How can memory be ever "None"? You define its default as '0' (and as such, you
change the default behavior of faqemu),
Do not misunderstand me: it is fine to change faqemu behavior. But it should be
clearly declared in the commit message and accepted by its users (most
importantly ovirt QE).
Line 36: if arch == 'x86_64':
Line 37: memory = '20480'
Line 38: if arch == 'ppc64':
Line 39: memory = '262144'
Line 34:
Line 35: if memory is None:
Line 36: if arch == 'x86_64':
Line 37: memory = '20480'
Line 38: if arch == 'ppc64':
why is this elif->if change?
Line 39: memory = '262144'
Line 40:
Line 41: if memory != '0':
Line 42: for memtag in ("memory", "currentMemory"):
--
To view, visit http://gerrit.ovirt.org/28320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Martin Polednik has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Martin Polednik has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/28320/3/vdsm_hooks/faqemu/before_vm_start.py
File vdsm_hooks/faqemu/before_vm_start.py:
Line 32: memory = config.get('vars', 'fake_kvm_memory', None)
Line 33: arch = config.get('vars', 'fake_kvm_architecture')
Line 34:
Line 35: if memory is None:
Line 36: if arch == 'x86_64':
> I think ht efirst version was better - I don't particularly like magic numb
Config keys are commented by default, making them more of an indication rather
than setting. This way, x86 and ppc is preserved, allowing for setting upper
memory limit / using direct vmCreate memory limit.
Line 37: memory = '20480'
Line 38: if arch == 'ppc64':
Line 39: memory = '262144'
Line 40:
--
To view, visit http://gerrit.ovirt.org/28320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
oVirt Jenkins CI Server has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9719/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8786/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9572/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Michal Skrivanek has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/28320/3/vdsm_hooks/faqemu/before_vm_start.py
File vdsm_hooks/faqemu/before_vm_start.py:
Line 32: memory = config.get('vars', 'fake_kvm_memory', None)
Line 33: arch = config.get('vars', 'fake_kvm_architecture')
Line 34:
Line 35: if memory is None:
Line 36: if arch == 'x86_64':
I think ht efirst version was better - I don't particularly like magic numbers
in the code. Why not put 20480 as the default of the config value? That's
preserving the current behavior on x86_64. And for ppc I think changing it is
fine as there are still very few users (if any)
Line 37: memory = '20480'
Line 38: if arch == 'ppc64':
Line 39: memory = '262144'
Line 40:
--
To view, visit http://gerrit.ovirt.org/28320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
oVirt Jenkins CI Server has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9718/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8785/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9571/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Dan Kenigsberg has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 1: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/28320/1//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2014-06-03 12:16:37 +0200
Line 6:
Line 7: faqemu hook: move memory limitation to config
Line 8:
Line 9: Qemu supports more than 20 MB memory[1], removing the need for hardcoded
Your patch seems fine, but the commit message is misleading. The memory limit
of faqemu is unrelated to [1]. It was simply a means to start the least-costly
qemu process - which cannot even run any meaningful guest. That's why it's only
a "fake" qemu.
This patch makes it possible to have true guests running in emulating
(non-virtualizing) qemu, by adhering to Engine-supplied memory size. That's
fine.
Line 10: memory limit. This patch allows faqemu memory to be either unchanged,
Line 11: or limited by the configuration file. Usage of > 20 MB memory is
required
Line 12: when running faqemu with system kernel/initramfs combo.
Line 13:
http://gerrit.ovirt.org/#/c/28320/1/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 182:
Line 183: ('fake_kvm_architecture', 'x86_64',
Line 184: 'Choose the target architecture of the fake KVM mode'),
Line 185:
Line 186: ('fake_kvm_memory', '262144', None),
this changes the default behavior for x86_64 users of faqemu; their processes
would start consuming 10 times more memory.
We could notify them, and have them edit vdsm.conf before usage. Alternatively,
we could set fake_kvm_memory.x86_64 and fake_kvm_memory.ppc64 to maintain
current behaviour.
Also, please avoid (very natural) laziness, and document any new variable such
as this (the third tuple element is intended for that).
Line 187:
Line 188: ('xmlrpc_enable', 'true', 'Enable the xmlrpc server'),
Line 189:
Line 190: ('xmlrpc_http11', 'true',
--
To view, visit http://gerrit.ovirt.org/28320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Francesco Romani has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Michal Skrivanek has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 1: Code-Review+1 i believe this is much better than the last modification for ppc. faqemu still has its merit for automated tests on x86 platform too -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Martin Polednik has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
oVirt Jenkins CI Server has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9671/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8738/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9524/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: faqemu hook: move memory limitation to config
Martin Polednik has uploaded a new change for review.
Change subject: faqemu hook: move memory limitation to config
..
faqemu hook: move memory limitation to config
Qemu supports more than 20 MB memory[1], removing the need for hardcoded
memory limit. This patch allows faqemu memory to be either unchanged,
or limited by the configuration file. Usage of > 20 MB memory is required
when running faqemu with system kernel/initramfs combo.
[1] https://code.launchpad.net/~rvb/maas-test/memory-limit/+merge/198101
Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531
Signed-off-by: Martin Polednik
---
M lib/vdsm/config.py.in
M vdsm_hooks/faqemu/before_vm_start.py
2 files changed, 9 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/28320/1
diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index 8eb1811..2f9eecc 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -183,6 +183,8 @@
('fake_kvm_architecture', 'x86_64',
'Choose the target architecture of the fake KVM mode'),
+('fake_kvm_memory', '262144', None),
+
('xmlrpc_enable', 'true', 'Enable the xmlrpc server'),
('xmlrpc_http11', 'true',
diff --git a/vdsm_hooks/faqemu/before_vm_start.py
b/vdsm_hooks/faqemu/before_vm_start.py
old mode 100755
new mode 100644
index 9539810..92a4a9e
--- a/vdsm_hooks/faqemu/before_vm_start.py
+++ b/vdsm_hooks/faqemu/before_vm_start.py
@@ -29,19 +29,15 @@
graphics = domxml.getElementsByTagName("graphics")[0]
graphics.removeAttribute("passwdValidTo")
-for memtag in ("memory", "currentMemory"):
-memvalue = domxml.getElementsByTagName(memtag)[0]
-while memvalue.firstChild:
-memvalue.removeChild(memvalue.firstChild)
+memory = config.get('vars', 'fake_kvm_memory', None)
-arch = config.get('vars', 'fake_kvm_architecture')
+if memory:
+for memtag in ("memory", "currentMemory"):
+memvalue = domxml.getElementsByTagName(memtag)[0]
+while memvalue.firstChild:
+memvalue.removeChild(memvalue.firstChild)
-if arch == 'x86_64':
-memory = '20480'
-elif arch == 'ppc64':
-memory = '262144'
-
-memvalue.appendChild(domxml.createTextNode(memory))
+memvalue.appendChild(domxml.createTextNode(memory))
for cputag in domxml.getElementsByTagName("cpu"):
cputag.parentNode.removeChild(cputag)
--
To view, visit http://gerrit.ovirt.org/28320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
