Change in vdsm[master]: gluster: Adds a new element 'extraFeaturesSupported' to getV...

2015-04-28 Thread rnachimu
Ramesh N has posted comments on this change.

Change subject: gluster: Adds a new element 'extraFeaturesSupported' to 
getVdsCaps.
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/39324/2/vdsm/caps.py
File vdsm/caps.py:

Line 712: extraFeaturesSupported
> 1. How about 'additionalFeatures' than 'extraFeaturesSupported'?
Its ok to give all the features considering we don't have a good group name. 

Sahina thoughts?


-- 
To view, visit https://gerrit.ovirt.org/39324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic203fa0565914d528ae457427f6f1ff7708017d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: gluster: Adds a new element 'extraFeaturesSupported' to getV...

2015-04-28 Thread barumuga
Bala.FA has posted comments on this change.

Change subject: gluster: Adds a new element 'extraFeaturesSupported' to 
getVdsCaps.
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/39324/2/vdsm/caps.py
File vdsm/caps.py:

Line 712: extraFeaturesSupported
1. How about 'additionalFeatures' than 'extraFeaturesSupported'?

2. Is it good idea to list features (like GLUSTER_BRICK_MANAGEMENT etc) than 
feature group name 'GLUSTER_37_FEATURES'?


-- 
To view, visit https://gerrit.ovirt.org/39324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic203fa0565914d528ae457427f6f1ff7708017d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: gluster: Adds a new element 'extraFeaturesSupported' to getV...

2015-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Adds a new element 'extraFeaturesSupported' to 
getVdsCaps.
..


Patch Set 2:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18026/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17855/ : SUCCESS

-- 
To view, visit https://gerrit.ovirt.org/39324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic203fa0565914d528ae457427f6f1ff7708017d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: gluster: Adds a new element 'extraFeaturesSupported' to getV...

2015-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Adds a new element 'extraFeaturesSupported' to 
getVdsCaps.
..


Patch Set 2:

Build Started (2/2) -> 
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18026/

-- 
To view, visit https://gerrit.ovirt.org/39324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic203fa0565914d528ae457427f6f1ff7708017d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: gluster: Adds a new element 'extraFeaturesSupported' to getV...

2015-04-20 Thread dnarayan
Darshan N has posted comments on this change.

Change subject: gluster: Adds a new element 'extraFeaturesSupported' to 
getVdsCaps.
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/39324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic203fa0565914d528ae457427f6f1ff7708017d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: gluster: Adds a new element 'extraFeaturesSupported' to getV...

2015-04-20 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: gluster: Adds a new element 'extraFeaturesSupported' to 
getVdsCaps.
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/39324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic203fa0565914d528ae457427f6f1ff7708017d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: gluster: Adds a new element 'extraFeaturesSupported' to getV...

2015-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Adds a new element 'extraFeaturesSupported' to 
getVdsCaps.
..


Patch Set 2:

Build Started (1/2) -> 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17855/

-- 
To view, visit https://gerrit.ovirt.org/39324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic203fa0565914d528ae457427f6f1ff7708017d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches