Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-16 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-16 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


gluster: New verb to mount & update fstab for meta-volume

This patch adds a new verb 'MetaVolumeMount' to
update fstab entry for meta-volume and mount it. This
meta-volume is needed by various glusterfs features
like snapshot-schedule, geo-replication etc. It is
expected to be mounted on all gluster nodes. It takes
an optional argument metaVolumeName.

Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Signed-off-by: Darshan N 
Reviewed-on: https://gerrit.ovirt.org/40497
Continuous-Integration: Jenkins CI
Reviewed-by: Bala.FA 
Reviewed-by: Dan Kenigsberg 
---
M client/vdsClientGluster.py
M vdsm/gluster/api.py
M vdsm/gluster/apiwrapper.py
M vdsm/gluster/exception.py
M vdsm/rpc/vdsmapi-gluster-schema.json
5 files changed, 98 insertions(+), 1 deletion(-)

Approvals:
  Bala.FA: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Darshan N: Verified



-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-16 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 8:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-15 Thread barumuga 
Bala.FA has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-15 Thread dnarayan 
Darshan N has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 7: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-15 Thread dnarayan 
Darshan N has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 6:

(2 comments)

https://gerrit.ovirt.org/#/c/40497/6/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 173: ismount
> move this if block to try level.  its ok to execute it on successful os.mak
Done


Line 175: ,
> the check here is
Done


-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-15 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 7:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-15 Thread barumuga 
Bala.FA has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 6: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/40497/6/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 173: ismount
move this if block to try level.  its ok to execute it on successful 
os.makedirs()


Line 175: ,
the check here is

if META_VOL_MOUNT_POINT is mounted
   if META_VOLUME is mounted
  return true
   else
  raise exception abt the mount point is already in use
else
   mount the volume


-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-15 Thread dnarayan 
Darshan N has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-15 Thread dnarayan 
Darshan N has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 5:

(6 comments)

https://gerrit.ovirt.org/#/c/40497/5/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 153: metaVolumeFstabUpdate
> move this function as subfunction to mountMetaVolume()
Done


Line 155: hostname
> hostname as a variable is not needed.
Done


Line 156: ":"
> its called fs_spec as per fstab man page.  please change it accordingly.
Done


Line 163: e
> i think logging.warn() is better
Done


Line 172:  
> how about e.EEXIST check than os.path.exists()?
Done


Line 178: META_VOL_MOUNT_POINT
> you just need to check whether META_VOL_MOUNT_POINT is a mount point.  may 
Done


-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-15 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 6:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-15 Thread barumuga 
Bala.FA has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 5: Code-Review-1

(6 comments)

https://gerrit.ovirt.org/#/c/40497/5/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 153: metaVolumeFstabUpdate
move this function as subfunction to mountMetaVolume()


Line 155: hostname
hostname as a variable is not needed.


Line 156: ":"
its called fs_spec as per fstab man page.  please change it accordingly.


Line 163: e
i think logging.warn() is better


Line 172:  
how about e.EEXIST check than os.path.exists()?


Line 178: META_VOL_MOUNT_POINT
you just need to check whether META_VOL_MOUNT_POINT is a mount point.  may be 
os.path.ismount()?

note that if the meta volume is mounted in other place is not a problem.


-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-14 Thread dnarayan 
Darshan N has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 5: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-14 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 5:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-14 Thread dnarayan 
Darshan N has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-14 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 4:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-14 Thread dnarayan 
Darshan N has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/40497/2/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 686: metaVolumeMount
> Also we should take meta volume name as an argument here, so later if name 
Done


Line 686: metaVolumeMount
> Why can't the meta volume be mounted always by the system itself?  Its bett
meta volume is user created volume, when user creates this volume through 
ovirt, it would be better to mount it through engine.


-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-14 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 3:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-11 Thread shtripat 
Shubhendu Tripathi has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/40497/2/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 686: metaVolumeMount
> Why can't the meta volume be mounted always by the system itself?  Its bett
Also we should take meta volume name as an argument here, so later if name 
changes (for some reason), we dont get affected at all.


-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-11 Thread barumuga 
Bala.FA has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/40497/2/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 686: metaVolumeMount
Why can't the meta volume be mounted always by the system itself?  Its better 
to be a system level than engine triggered activity.


-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-11 Thread dnarayan 
Darshan N has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/40497/2/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 165: @makePublic
Line 166: def mountMetaVolume(device):
Line 167: if not os.path.exists(META_VOL_MOUNT_POINT):
Line 168: try:
Line 169: os.makedirs(META_VOL_MOUNT_POINT, 0o755)
> Why 0o755 ? Any specific reason?
This is new style octal literal. In vdsm this type of literal is being used 
since patch: https://gerrit.ovirt.org/#/c/40211/, which would be helpful for 
python 2 to 3 migration
Line 170: except OSError:
Line 171: raise ge.GlusterMetaVolumeMountFailedException(
Line 172: err=['Mount Point creation failed'])
Line 173: 


-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-10 Thread tjeyasin 
Timothy Asir has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/40497/2/vdsm/gluster/api.py
File vdsm/gluster/api.py:

Line 165: @makePublic
Line 166: def mountMetaVolume(device):
Line 167: if not os.path.exists(META_VOL_MOUNT_POINT):
Line 168: try:
Line 169: os.makedirs(META_VOL_MOUNT_POINT, 0o755)
Why 0o755 ? Any specific reason?
Line 170: except OSError:
Line 171: raise ge.GlusterMetaVolumeMountFailedException(
Line 172: err=['Mount Point creation failed'])
Line 173: 


-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-05 Thread dnarayan 
Darshan N has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-05 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shubhendu Tripathi 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-04 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40497
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: New verb to mount & update fstab for meta-volume

2015-05-04 Thread dnarayan 
Darshan N has uploaded a new change for review.

Change subject: gluster: New verb to mount & update fstab for meta-volume
..

gluster: New verb to mount & update fstab for meta-volume

This patch adds a new verb 'MetaVolumeMount' to
update fstab entry for meta-volume and mount it. This
meta-volume is needed by various glusterfs features
like snapshot-schedule, geo-replication etc. It is
expected to be mounted on all gluster nodes.

Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4
Signed-off-by: Darshan N 
---
M client/vdsClientGluster.py
M vdsm/gluster/api.py
M vdsm/gluster/apiwrapper.py
M vdsm/gluster/exception.py
M vdsm/rpc/vdsmapi-gluster-schema.json
5 files changed, 68 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/40497/1

diff --git a/client/vdsClientGluster.py b/client/vdsClientGluster.py
index 4f53eb4..b78653e 100644
--- a/client/vdsClientGluster.py
+++ b/client/vdsClientGluster.py
@@ -758,6 +758,11 @@
 pp.pprint(status)
 return status['status']['code'], status['status']['message']
 
+def do_glusterMetaVolumeMount(self, args):
+status = self.s.glusterMetaVolumeMount()
+pp.pprint(status)
+return status['status']['code'], status['status']['message']
+
 
 def getGlusterCmdDict(serv):
 return \
@@ -1288,5 +1293,10 @@
  serv.do_glusterVolumeEmptyCheck,
  ('volumeName=',
   'Check if the given volume is empty or not'
+  )),
+ 'glusterMetaVolumeMount': (
+ serv.do_glusterMetaVolumeMount,
+ ('',
+  'mount the meta-volume'
   ))
  }
diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py
index 222aacb..c2ba04c 100644
--- a/vdsm/gluster/api.py
+++ b/vdsm/gluster/api.py
@@ -22,16 +22,23 @@
 import os
 from functools import wraps
 from vdsm.define import doneCode
+from vdsm import constants
+from vdsm import utils
+from hostname import getHostNameFqdn, HostNameException
 from pwd import getpwnam
 
 import supervdsm as svdsm
 import exception as ge
 from . import makePublic
 from . import safeWrite
+import fstab
 
 _SUCCESS = {'status': doneCode}
 GEOREP_PUB_KEY_PATH = "/var/lib/glusterd/geo-replication/common_secret.pem.pub"
 MOUNT_BROKER_ROOT = "/var/mountbroker-root"
+META_VOLUME = "/gluster_shared_storage"
+META_VOL_MOUNT_POINT = "/var/run/gluster/shared_storage"
+FS_TYPE = "glusterfs"
 
 
 GLUSTER_RPM_PACKAGES = (
@@ -140,6 +147,29 @@
 except OSError as e:
 raise ge.GlusterMountBrokerRootCreateFailedException(err=[str(e)])
 return
+
+
+@makePublic
+def metaVolumeFstabUpdate():
+try:
+device = getHostNameFqdn() + ":" + META_VOLUME
+fstab.FsTab().add(device, META_VOL_MOUNT_POINT, FS_TYPE,
+  mntOpts=['defaults', '_netdev'])
+except (IOError, HostNameException) as e:
+raise ge.GlusterMetaVolumeFstabUpdateFailedException(err=[str(e)])
+except ge.GlusterException as e:
+raise ge.GlusterMetaVolumeFstabUpdateFailedException(err=[e.message])
+return device
+
+
+@makePublic
+def mountMetaVolume(device):
+command = [constants.EXT_MOUNT, device]
+rc, out, err = utils.execCmd(command)
+if rc:
+raise ge.GlusterMetaVolumeMountFailedException(
+rc, out, err)
+return True
 
 
 class GlusterApi(object):
@@ -645,6 +675,11 @@
 status = self.svdsmProxy.glusterVolumeEmptyCheck(volumeName)
 return {'volumeEmptyCheck': status}
 
+@exportAsVerb
+def metaVolumeMount(self, options=None):
+device = self.svdsmProxy.glusterMetaVolumeFstabUpdate()
+self.svdsmProxy.glusterMountMetaVolume(device)
+
 
 def getGlusterMethods(gluster):
 l = []
diff --git a/vdsm/gluster/apiwrapper.py b/vdsm/gluster/apiwrapper.py
index 6d70a85..245a823 100644
--- a/vdsm/gluster/apiwrapper.py
+++ b/vdsm/gluster/apiwrapper.py
@@ -309,6 +309,9 @@
 def volumeEmptyCheck(self, volumeName):
 return self._gluster.volumeEmptyCheck(volumeName)
 
+def metaVolumeMount(self):
+return self._gluster.metaVolumeMount()
+
 
 class GlusterSnapshot(GlusterApiBase):
 def __init__(self):
diff --git a/vdsm/gluster/exception.py b/vdsm/gluster/exception.py
index d093661..10f3f76 100644
--- a/vdsm/gluster/exception.py
+++ b/vdsm/gluster/exception.py
@@ -581,6 +581,16 @@
 message = "Failed to Check if gluster volume is empty"
 
 
+class GlusterMetaVolumeMountFailedException(GlusterVolumeException):
+code = 4575
+message = "Failed to mount meta volume"
+
+
+class GlusterMetaVolumeFstabUpdateFailedException(GlusterVolumeException):
+code = 4576
+message = "Failed to Update fstab entry for meta-volume"
+
+
 # geo-replication
 class GlusterGeoRepException(GlusterException):
 code = 4200
diff --git a/vdsm/rpc/vdsmapi-gluster-schema.json 
b/vdsm/rpc/vdsmapi-gluster-schema.json
index 935adff..704