Change in vdsm[master]: hostdev: fix scsi udev rule target

2016-05-17 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix scsi udev rule target

2016-05-17 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: hostdev: fix scsi udev rule target
..


hostdev: fix scsi udev rule target

Previously, the rule worked as expected but did not properly signal
ownership of the device. That is now fixed with kernel and subsystem
targets.

The cause does not affect functionality of hostdev-scsi, but causes the
rule to be triggered with all udev updates - leading to useless chown
execution.

Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Signed-off-by: Martin Polednik 
Reviewed-on: https://gerrit.ovirt.org/57373
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-by: Francesco Romani 
---
M vdsm/supervdsm_api/udev.py
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Martin Polednik: Verified



-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix scsi udev rule target

2016-05-17 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix scsi udev rule target

2016-05-17 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
..


Patch Set 6:

raising score (it is a virt flow after all) after maintainer's +1.

-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix scsi udev rule target

2016-05-16 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix scsi udev rule target

2016-05-16 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix scsi udev rule target

2016-05-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix scsi udev rule target

2016-05-13 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
..


Patch Set 5: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix scsi udev rule target

2016-05-13 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/57373/4/vdsm/supervdsm_api/udev.py
File vdsm/supervdsm_api/udev.py:

Line 56
Line 57
Line 58
Line 59
Line 60
> Something used throughout whole hostdev - it's a libvirt way of naming a de
Please add a docstring with these examples  in another patch.


-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix scsi udev rule target

2016-05-13 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix scsi udev rule target

2016-05-13 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/57373/4/vdsm/supervdsm_api/udev.py
File vdsm/supervdsm_api/udev.py:

Line 56
Line 57
Line 58
Line 59
Line 60
> What is device_name?
Something used throughout whole hostdev - it's a libvirt way of naming a device 
(e.g. scsi_4_0_0_0 or pci__03_00_0).


-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix scsi udev rule target

2016-05-12 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
..


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/57373/4/vdsm/supervdsm_api/udev.py
File vdsm/supervdsm_api/udev.py:

Line 56
Line 57
Line 58
Line 59
Line 60
What is device_name?


Line 59: @expose
Line 60: def appropriateSCSIDevice(device_name, udev_path):
Line 61: ruleFile = _UDEV_RULE_FILE_NAME % ('scsi', device_name)
Line 62: rule = 'KERNEL=="%s" SUBSYSTEM=="scsi_generic" RUN+="%s %s:%s 
%s"\n' % (
Line 63: udev_path.split('/', 2)[2], EXT_CHOWN, QEMU_PROCESS_USER,
> For my understanding:
udev_path.split('/', 2)[2] seems to do:

"/a/b" -> ["", "a", "b"][2] -> "b"

Seems that you are reinventing os.path.basename.
Line 64: QEMU_PROCESS_GROUP, udev_path)
Line 65: with open(ruleFile, "w") as rf:
Line 66: _log.debug("Creating rule %s: %r", ruleFile, rule)
Line 67: rf.write(rule)


-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix scsi udev rule target

2016-05-12 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
..


Patch Set 4: Code-Review+1

wrong button!

-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix scsi udev rule target

2016-05-12 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix scsi udev rule target

2016-05-12 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix scsi udev rule target

2016-05-12 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
..


Patch Set 4:

(1 comment)

same question as PS3

https://gerrit.ovirt.org/#/c/57373/4/vdsm/supervdsm_api/udev.py
File vdsm/supervdsm_api/udev.py:

PS4, Line 63: udev_path.split('/', 2)[2]
For my understanding:
1. this should never raise
2. if it raises, it is better for us to explode here
right?

Also, could you please remind me how udev_path looks like?


-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix scsi udev rule target

2016-05-12 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
..


Patch Set 4: -Code-Review Verified+1

-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix scsi udev rule target

2016-05-12 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/57373/3/vdsm/supervdsm_api/udev.py
File vdsm/supervdsm_api/udev.py:

PS3, Line 63: udev_path.split('/', 2)[2]
> For my understanding:
/dev/sgX in this case.

It will never raise as we wouldn't get to this point, and if it does - yeah, 
exploding is fine.


-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix scsi udev rule target

2016-05-12 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
..


Patch Set 3: Code-Review+1

(1 comment)

looks OK, few questions inside

https://gerrit.ovirt.org/#/c/57373/3/vdsm/supervdsm_api/udev.py
File vdsm/supervdsm_api/udev.py:

PS3, Line 63: udev_path.split('/', 2)[2]
For my understanding:
1. this should never raise
2. if it raises, it is better for us to explode here
right?

Also, could you please remind me how udev_path looks like?


-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix scsi udev rule target

2016-05-12 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
..


Patch Set 3: -Code-Review

...and I didn't notice the typo!

-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: fix scsi udev rule target

2016-05-12 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: hostdev: fix scsi udev rule target
..


Patch Set 3: Code-Review-1 Verified-1

(1 comment)

typo snuck in that broke everything, resubmitting asap

https://gerrit.ovirt.org/#/c/57373/3/vdsm/supervdsm_api/udev.py
File vdsm/supervdsm_api/udev.py:

PS3, Line 62: SUBYSTEM
typo


-- 
To view, visit https://gerrit.ovirt.org/57373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98949e645b748493e3cf4a7377d17ded67e8fd66
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches