Change in vdsm[master]: introducing virtio-scsi support
Dan Kenigsberg has submitted this change and it was merged. Change subject: introducing virtio-scsi support .. introducing virtio-scsi support Drive class: * makeName - map 'scsi' to 'sd' * getXML: - added 'sgio' flag [1] - device='lun' is used instead of device='disk' for supporting LUN passthrough (which can be used with virtio-scsi). Hence, adding 'driver' tag similarly to 'disk' device. LibvirtVm class: * getUnderlyingDriveInfo - get/set 'sgio' attribute. TestLibvirtvm class: * testControllerXML - test 'virtio-scsi' controller * testDriveXML: - test virtio-scsi image disk - test virtio-scsi LUN passthrough API Schema: * Updated: - VmDiskDeviceInterface - VmDiskDeviceType - VmControllerDevice [1] 'sgio': SCSI Generic IO - filtered/unfiltered (indicates whether the kernel will filter unprivileged SG_IO commands for the disk). Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Signed-off-by: Daniel Erez de...@redhat.com Reviewed-on: http://gerrit.ovirt.org/14681 Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M tests/libvirtvmTests.py M vdsm/vm.py M vdsm_api/vdsmapi-schema.json 3 files changed, 58 insertions(+), 9 deletions(-) Approvals: Federico Simoncelli: Looks good to me, approved Daniel Erez: Verified Dan Kenigsberg: -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Federico Simoncelli has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 6: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Daniel Erez has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 6: Verified -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
oVirt Jenkins CI Server has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2747/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1935/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2821/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Dan Kenigsberg has posted comments on this change.
Change subject: introducing virtio-scsi support
..
Patch Set 5: (1 inline comment)
File vdsm/vm.py
Line 1488: driverAttrs['cache'] = self.cache
Line 1489:
Line 1490: self._setErrorPolicy(driverAttrs)
Line 1491: diskelem.appendChildWithArgs('driver', **driverAttrs)
Line 1492: elif self.device == 'lun':
Ayal, what is the meaning of enospace or stop with SCSI passthrough?
Line 1493: driverAttrs = {'name': 'qemu'}
Line 1494: driverAttrs['io'] = 'native'
Line 1495: driverAttrs['type'] = 'raw'
Line 1496: driverAttrs['cache'] = self.cache
--
To view, visit http://gerrit.ovirt.org/14681
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Federico Simoncelli has posted comments on this change.
Change subject: introducing virtio-scsi support
..
Patch Set 5: (1 inline comment)
File vdsm/vm.py
Line 1488: driverAttrs['cache'] = self.cache
Line 1489:
Line 1490: self._setErrorPolicy(driverAttrs)
Line 1491: diskelem.appendChildWithArgs('driver', **driverAttrs)
Line 1492: elif self.device == 'lun':
Actually I'm a fan of the previous patch set. I don't think that 'lun' deserves
a specific elif. Up until now the flow went through the disk code also for
luns and there wasn't anything wrong with that. Moreover I don't think we
should forge static values.
For example here you're tying the luns to the native aio, if we discover that
there's a better aio for block devices we'll have to remember to change this
too.
You're also silently forcing the raw format, if the qcow2 format is not
supported on luns (even though it's legitimate) then we should raise an error
(but this is new, in the old flow we weren't doing it).
I can't see any advantage in this new patch set, it's just duplicated
logic/values.
Line 1493: driverAttrs = {'name': 'qemu'}
Line 1494: driverAttrs['io'] = 'native'
Line 1495: driverAttrs['type'] = 'raw'
Line 1496: driverAttrs['cache'] = self.cache
--
To view, visit http://gerrit.ovirt.org/14681
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Dan Kenigsberg has posted comments on this change.
Change subject: introducing virtio-scsi support
..
Patch Set 5: (1 inline comment)
File vdsm/vm.py
Line 1488: driverAttrs['cache'] = self.cache
Line 1489:
Line 1490: self._setErrorPolicy(driverAttrs)
Line 1491: diskelem.appendChildWithArgs('driver', **driverAttrs)
Line 1492: elif self.device == 'lun':
This patchset is probably my fault, as I find it clearer. 'lun' is a new target
added in this patch (I would have wished that virtio-scsi was added in a
separate previous patch). This new target has similarities, but also
differences, to the 'disk' target.
What is the meaning of error_policy for 'lun'? Does qemu trap scsi errors and
stop qemu?
Indeed, silence while ignoring an arg is bad. Exception is better. But why is
qcow2 is legitimate? libvirt's docs are very dramatic about the source being
very raw:
device='lun' will only be recognized for actual raw devices, never for
individual partitions or LVM partitions (in those cases, the kernel will reject
the generic SCSI commands, making it identical to device='disk'
(sorry for the possibly-stupid questions, I apparently do not understand the
feature very well).
Line 1493: driverAttrs = {'name': 'qemu'}
Line 1494: driverAttrs['io'] = 'native'
Line 1495: driverAttrs['type'] = 'raw'
Line 1496: driverAttrs['cache'] = self.cache
--
To view, visit http://gerrit.ovirt.org/14681
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Ayal Baron has posted comments on this change.
Change subject: introducing virtio-scsi support
..
Patch Set 5: (1 inline comment)
File vdsm/vm.py
Line 1488: driverAttrs['cache'] = self.cache
Line 1489:
Line 1490: self._setErrorPolicy(driverAttrs)
Line 1491: diskelem.appendChildWithArgs('driver', **driverAttrs)
Line 1492: elif self.device == 'lun':
error_policy is exactly that, a policy. It should be configurable at specific
disk level and there is no difference between LUN and 'Disk' in this sense.
The default may be different between qcow and raw though (but again, that is
not LUN specific).
wrt why qcow2 is legitimate, the answer is in your quote from libvirt making
it identical to device='disk'.
There are 2 functionalities gained by using virtio-scsi over virtio-blk
The first is the ability to have hundreds of disks (vs. a limit of less than 30
using PCI devices). This is relevant whether it's qcow or raw, file or block
or whatever other distinction you use.
The second is the ability to passthrough scsi commands - this is only relevant
for raw indeed (non partitioned devices).
So I agree with Federico that we should try and treat LUN as just a disk (since
that is all it is).
Line 1493: driverAttrs = {'name': 'qemu'}
Line 1494: driverAttrs['io'] = 'native'
Line 1495: driverAttrs['type'] = 'raw'
Line 1496: driverAttrs['cache'] = self.cache
--
To view, visit http://gerrit.ovirt.org/14681
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Allon Mureinik has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Daniel Erez has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 4: (1 inline comment) File vdsm/libvirtvm.py Line 1165: driverAttrs['io'] = 'threads' Line 1166: if self.format == 'cow': Line 1167: driverAttrs['type'] = 'qcow2' Line 1168: elif self.format: Line 1169: driverAttrs['type'] = 'raw' Done Line 1170: Line 1171: driverAttrs['cache'] = self.cache Line 1172: Line 1173: if (self.propagateErrors == 'on' or -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Daniel Erez has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 1: (1 inline comment) Commit Message Line 19: - test virtio-scsi image disk Line 20: - test virtio-scsi LUN passthrough Line 21: Line 22: [1] 'sgio': SCSI Generic IO - filtered/unfiltered Line 23: (indicates whether the kernel will filter unprivileged should be supported on el64 Line 24: SG_IO commands for the disk). Line 25: Line 26: Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
oVirt Jenkins CI Server has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2505/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1677/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2576/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Dan Kenigsberg has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 4: I would prefer that you didn't submit this (1 inline comment) Mark, if you are asking an important question, use you -1 powers to make it visible! File vdsm/libvirtvm.py Line 1165: driverAttrs['io'] = 'threads' Line 1166: if self.format == 'cow': Line 1167: driverAttrs['type'] = 'qcow2' Line 1168: elif self.format: Line 1169: driverAttrs['type'] = 'raw' (and the other options too. it's not clear to me that native/threads and enospace/stop are meaningful for lun. Maybe lun deserves its own elif: branch.) Line 1170: Line 1171: driverAttrs['cache'] = self.cache Line 1172: Line 1173: if (self.propagateErrors == 'on' or -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Allon Mureinik has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 4: Looks good to me, but someone else must approve (1 inline comment) File vdsm/libvirtvm.py Line 1165: driverAttrs['io'] = 'threads' Line 1166: if self.format == 'cow': Line 1167: driverAttrs['type'] = 'qcow2' Line 1168: elif self.format: Line 1169: driverAttrs['type'] = 'raw' you're now allowing a lun device to have a cow format. perhaps you should validate against it? Line 1170: Line 1171: driverAttrs['cache'] = self.cache Line 1172: Line 1173: if (self.propagateErrors == 'on' or -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Mark Wu has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 4: Daniel, could you please answer the question I asked before: Which kernel has the support of the flag unpriv_sgio, which the 'unfiltered' function relys on? Thanks! -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Federico Simoncelli has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Federico Simoncelli has posted comments on this change.
Change subject: introducing virtio-scsi support
..
Patch Set 3: (1 inline comment)
File vdsm/libvirtvm.py
Line 1135: if self.device == 'cdrom' or self.device == 'floppy':
Line 1136: sourceAttrs['startupPolicy'] = 'optional'
Line 1137: source.setAttrs(**sourceAttrs)
Line 1138: diskelem = self.createXmlElem('disk', deviceType,
Line 1139: ['device', 'address', 'sgio'])
You should check and make sure that 'sgio' is not used other than with 'lun'.
Line 1140: diskelem.setAttrs(snapshot='no')
Line 1141: diskelem.appendChild(source)
Line 1142:
Line 1143: targetAttrs = {'dev': self.name}
--
To view, visit http://gerrit.ovirt.org/14681
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
oVirt Jenkins CI Server has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 4: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2462/ (1/3) -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
oVirt Jenkins CI Server has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 4: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1560/ (3/3) -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Daniel Erez has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
oVirt Jenkins CI Server has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2394/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1560/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2462/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Mark Wu has posted comments on this change.
Change subject: introducing virtio-scsi support
..
Patch Set 1: (3 inline comments)
Commit Message
Line 19: - test virtio-scsi image disk
Line 20: - test virtio-scsi LUN passthrough
Line 21:
Line 22: [1] 'sgio': SCSI Generic IO - filtered/unfiltered
Line 23: (indicates whether the kernel will filter unprivileged
I found it's not supported by F18 kernel and not included by upstream either.
Could you please tell me which kernel supports unpriv_sgio? Thanks.
Line 24: SG_IO commands for the disk).
Line 25:
Line 26: Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958
File vdsm/libvirtvm.py
Line 1155: diskelem.appendChildWithArgs('serial', text=self.serial)
Line 1156: if hasattr(self, 'bootOrder'):
Line 1157: diskelem.appendChildWithArgs('boot',
order=self.bootOrder)
Line 1158:
Line 1159: if self.device == 'disk' or self.device == 'lun':
I guess the VM should be run with root privilege, so does it work without
permission issue with the current libvirt/qemu setting?
Line 1160: driverAttrs = {'name': 'qemu'}
Line 1161: if self.blockDev:
Line 1162: driverAttrs['io'] = 'native'
Line 1163: else:
Line 3015: # Get disk address
Line 3016: address = self._getUnderlyingDeviceAddress(x)
Line 3017:
Line 3018: # Get sgio value (filtered/unfiltered)
Line 3019: sgio = x.getAttribute('sgio')
I don't understand why you need fetch the configuration of sgio back from
libvirt. Isn't already contained in the vmDrive object and vm'conf?
Line 3020:
Line 3021: for d in self._devices[vm.DISK_DEVICES]:
Line 3022: if d.path == devPath:
Line 3023: d.name = name
--
To view, visit http://gerrit.ovirt.org/14681
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Mark Wu has posted comments on this change.
Change subject: introducing virtio-scsi support
..
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
Could you please also answer my questions in your patch set1?
Thanks!
File vdsm_api/vdsmapi-schema.json
Line 1756: # @floppy: A floppy disk drive
Line 1757: #
Line 1758: # Since: 4.10.0
Line 1759: ##
Line 1760: {'enum': 'VmDiskDeviceType', 'data': ['disk', 'cdrom', 'floppy']}
also need add 'lun' here?
Line 1761:
Line 1762: ##
Line 1763: # @VmDiskDeviceInterface:
Line 1764: #
Line 2226: #
Line 2227: # Since: 4.10.0
Line 2228: ##
Line 2229: {'type': 'VmControllerDevice',
Line 2230: 'data': {'deviceType': 'VmDeviceType', 'device':
'VmControllerDeviceType',
add 'model' here?
Line 2231: 'address': 'VmDeviceAddress', 'alias': 'str', 'deviceId':
'UUID'}}
Line 2232:
Line 2233: ##
Line 2234: # @VmBalloonDeviceType:
--
To view, visit http://gerrit.ovirt.org/14681
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Daniel Erez has posted comments on this change.
Change subject: introducing virtio-scsi support
..
Patch Set 1: (3 inline comments)
Commit Message
Line 19: - test virtio-scsi image disk
Line 20: - test virtio-scsi LUN passthrough
Line 21:
Line 22: [1] 'sgio': SCSI Generic IO - filtered/unfiltered
Line 23: (indicates whether the kernel will filter unprivileged
It should be supported in F17:
http://fedoraproject.org/wiki/Features/virtio-scsi
Line 24: SG_IO commands for the disk).
Line 25:
Line 26: Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958
File vdsm/libvirtvm.py
Line 1155: diskelem.appendChildWithArgs('serial', text=self.serial)
Line 1156: if hasattr(self, 'bootOrder'):
Line 1157: diskelem.appendChildWithArgs('boot',
order=self.bootOrder)
Line 1158:
Line 1159: if self.device == 'disk' or self.device == 'lun':
Do you mean for 'lun' device or 'sgio' attribute?
Line 1160: driverAttrs = {'name': 'qemu'}
Line 1161: if self.blockDev:
Line 1162: driverAttrs['io'] = 'native'
Line 1163: else:
Line 3015: # Get disk address
Line 3016: address = self._getUnderlyingDeviceAddress(x)
Line 3017:
Line 3018: # Get sgio value (filtered/unfiltered)
Line 3019: sgio = x.getAttribute('sgio')
You're right. I'll remove it.
Line 3020:
Line 3021: for d in self._devices[vm.DISK_DEVICES]:
Line 3022: if d.path == devPath:
Line 3023: d.name = name
--
To view, visit http://gerrit.ovirt.org/14681
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
oVirt Jenkins CI Server has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2289/ (1/3) -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
oVirt Jenkins CI Server has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1450/ (2/3) -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
oVirt Jenkins CI Server has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2353/ (3/3) -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
oVirt Jenkins CI Server has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2289/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1450/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2353/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Daniel Erez has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Mark Wu has posted comments on this change.
Change subject: introducing virtio-scsi support
..
Patch Set 1: (2 inline comments)
Commit Message
Line 19: - test virtio-scsi image disk
Line 20: - test virtio-scsi LUN passthrough
Line 21:
Line 22: [1] 'sgio': SCSI Generic IO - filtered/unfiltered
Line 23: (indicates whether the kernel will filter unprivileged
Nope, my question is about support of the flag unpriv_sgio, which 'unfiltered'
relys on.
Line 24: SG_IO commands for the disk).
Line 25:
Line 26: Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958
File vdsm/libvirtvm.py
Line 1155: diskelem.appendChildWithArgs('serial', text=self.serial)
Line 1156: if hasattr(self, 'bootOrder'):
Line 1157: diskelem.appendChildWithArgs('boot',
order=self.bootOrder)
Line 1158:
Line 1159: if self.device == 'disk' or self.device == 'lun':
lun
Line 1160: driverAttrs = {'name': 'qemu'}
Line 1161: if self.blockDev:
Line 1162: driverAttrs['io'] = 'native'
Line 1163: else:
--
To view, visit http://gerrit.ovirt.org/14681
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Daniel Erez has posted comments on this change.
Change subject: introducing virtio-scsi support
..
Patch Set 1: (1 inline comment)
File tests/libvirtvmTests.py
Line 291:
Line 292: def testControllerXML(self):
Line 293: devConfs = [
Line 294: {'device': 'ide', 'index': '0', 'address':
self.PCI_ADDR_DICT},
Line 295: {'device': 'scsi', 'index': '0', 'model': 'virtio-scsi',
Yes, the engine should send the 'model' arg along with 'controller'
(added in the engine patch). Do you think it's better to handle it internally
in the vdsm?
Line 296: 'address': self.PCI_ADDR_DICT},
Line 297: {'device': 'virtio-serial', 'address':
self.PCI_ADDR_DICT},
Line 298: {'device': 'usb', 'model': 'ich9-ehci1', 'index': '0',
Line 299: 'master': {'startport': '0'}, 'address':
self.PCI_ADDR_DICT}]
--
To view, visit http://gerrit.ovirt.org/14681
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
oVirt Jenkins CI Server has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2351/ (2/3) -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
oVirt Jenkins CI Server has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2287/ (3/3) -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
oVirt Jenkins CI Server has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1448/ (1/3) -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Daniel Erez has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 2: Verified Updated API schema and addressed comments. -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
oVirt Jenkins CI Server has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2287/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1448/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2351/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Dan Kenigsberg has posted comments on this change.
Change subject: introducing virtio-scsi support
..
Patch Set 1: (3 inline comments)
I have not checked, but I believe that such a change require s a schema_api
update. Have you?
File tests/libvirtvmTests.py
Line 291:
Line 292: def testControllerXML(self):
Line 293: devConfs = [
Line 294: {'device': 'ide', 'index': '0', 'address':
self.PCI_ADDR_DICT},
Line 295: {'device': 'scsi', 'index': '0', 'model': 'virtio-scsi',
Is model part of our api?
Line 296: 'address': self.PCI_ADDR_DICT},
Line 297: {'device': 'virtio-serial', 'address':
self.PCI_ADDR_DICT},
Line 298: {'device': 'usb', 'model': 'ich9-ehci1', 'index': '0',
Line 299: 'master': {'startport': '0'}, 'address':
self.PCI_ADDR_DICT}]
File vdsm/libvirtvm.py
Line 1138: diskelem = self.createXmlElem('disk', deviceType,
Line 1139: ['device', 'address', 'sgio'])
Line 1140: diskelem.setAttrs(snapshot='no')
Line 1141: if hasattr(self, 'sgio'):
Line 1142: diskelem.setAttrs(sgio=self.sgio)
Isn't adding 'sgio' to the attr list enough? I really am unsure.
Line 1143: diskelem.appendChild(source)
Line 1144:
Line 1145: targetAttrs = {'dev': self.name}
Line 1146: if self.iface:
Line 1155: diskelem.appendChildWithArgs('serial', text=self.serial)
Line 1156: if hasattr(self, 'bootOrder'):
Line 1157: diskelem.appendChildWithArgs('boot',
order=self.bootOrder)
Line 1158:
Line 1159: if self.device == 'disk' or self.device == 'lun':
This change seems unrelated to guest scsi; and it has functionality change for
direct lun. It deserves a commit messages and explanation of its own.
Line 1160: driverAttrs = {'name': 'qemu'}
Line 1161: if self.blockDev:
Line 1162: driverAttrs['io'] = 'native'
Line 1163: else:
--
To view, visit http://gerrit.ovirt.org/14681
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
oVirt Jenkins CI Server has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1397/ (1/3) -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
oVirt Jenkins CI Server has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2300/ (3/3) -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
oVirt Jenkins CI Server has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2236/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1397/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2300/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: introducing virtio-scsi support
Daniel Erez has posted comments on this change. Change subject: introducing virtio-scsi support .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
