Change in vdsm[master]: jsonvdscli: change hostname default
gerrit-hooks has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 7: * #1358530::Update tracker: OK * Set MODIFIED::bug 1358530#1358530IGNORE, not all related patches are closed, check 63308 -- To view, visit https://gerrit.ovirt.org/61782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonvdscli: change hostname default
Dan Kenigsberg has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/61782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonvdscli: change hostname default
Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonvdscli: change hostname default .. jsonvdscli: change hostname default We want to mitigate dns lookups due to potential issues with connectivity or dns servers. Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Signed-off-by: Piotr Kliczewski Bug-Url: https://bugzilla.redhat.com/1358530 Reviewed-on: https://gerrit.ovirt.org/61782 Reviewed-by: Irit Goihman Reviewed-by: Nir Soffer Reviewed-by: Simone Tiraboschi Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M lib/vdsm/jsonrpcvdscli.py M lib/vdsm/vdscli.py M tests/vdsClientTests.py 3 files changed, 3 insertions(+), 6 deletions(-) Approvals: Piotr Kliczewski: Verified Nir Soffer: Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Irit Goihman: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonvdscli: change hostname default
Simone Tiraboschi has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonvdscli: change hostname default
Nir Soffer has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonvdscli: change hostname default
Piotr Kliczewski has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 6: Verified+1 It was verified by couple of people. -- To view, visit https://gerrit.ovirt.org/61782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonvdscli: change hostname default
Irit Goihman has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 6: Code-Review+1 rebased and verified -- To view, visit https://gerrit.ovirt.org/61782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonvdscli: change hostname default
gerrit-hooks has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 6: * #1358530::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1358530::OK, public bug * Check Product::#1358530::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/61782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonvdscli: change hostname default
Piotr Kliczewski has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/61782/5/tests/stompAsyncDispatcherTests.py File tests/stompAsyncDispatcherTests.py: Line 58: def queue_frame(self, frame): Line 59: self._outbox.append(frame) Line 60: Line 61: Line 62: class TestDispatcher(object): > In another patch it better be called something that hints it is a mock/fake Done Line 63: Line 64: socket = None Line 65: Line 66: def __init__(self, data): -- To view, visit https://gerrit.ovirt.org/61782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonvdscli: change hostname default
Edward Haas has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 5: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/61782/5/tests/stompAsyncDispatcherTests.py File tests/stompAsyncDispatcherTests.py: Line 58: def queue_frame(self, frame): Line 59: self._outbox.append(frame) Line 60: Line 61: Line 62: class TestDispatcher(object): In another patch it better be called something that hints it is a mock/fake. It took me a while to understand why you added a line here. Line 63: Line 64: socket = None Line 65: Line 66: def __init__(self, data): -- To view, visit https://gerrit.ovirt.org/61782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonvdscli: change hostname default
Simone Tiraboschi has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonvdscli: change hostname default
Piotr Kliczewski has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 5: Verified+1 Verified by running vdsClient with enabled and disabled ipv6. -- To view, visit https://gerrit.ovirt.org/61782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonvdscli: change hostname default
gerrit-hooks has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 5: * #1358530::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1358530::OK, public bug * Check Product::#1358530::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/61782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonvdscli: change hostname default
gerrit-hooks has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 4: * #1358530::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1358530::OK, public bug * Check Product::#1358530::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/61782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonvdscli: change hostname default
Simone Tiraboschi has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonvdscli: change hostname default
gerrit-hooks has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 3: * #1358530::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1358530::OK, public bug * Check Product::#1358530::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/61782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonvdscli: change hostname default
Piotr Kliczewski has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/61782/2/lib/vdsm/jsonrpcvdscli.py File lib/vdsm/jsonrpcvdscli.py: Line 19: # Line 20: Line 21: from __future__ import absolute_import Line 22: Line 23: import six > six is not a standard library, no need to change its location. Done Line 24: from functools import partial Line 25: from uuid import uuid4 Line 26: Line 27: from yajsonrpc import stompreactor -- To view, visit https://gerrit.ovirt.org/61782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonvdscli: change hostname default
Edward Haas has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 2: Code-Review-1 (1 comment) it also needs to be changed under __guessDefaults for xmlrpc variant. (it will require updating the test as well) https://gerrit.ovirt.org/#/c/61782/2/lib/vdsm/jsonrpcvdscli.py File lib/vdsm/jsonrpcvdscli.py: Line 19: # Line 20: Line 21: from __future__ import absolute_import Line 22: Line 23: import six six is not a standard library, no need to change its location. Line 24: from functools import partial Line 25: from uuid import uuid4 Line 26: Line 27: from yajsonrpc import stompreactor -- To view, visit https://gerrit.ovirt.org/61782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonvdscli: change hostname default
gerrit-hooks has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 2: * #1358530::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1358530::OK, public bug * Check Product::#1358530::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/61782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonvdscli: change hostname default
Piotr Kliczewski has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 1: Simone can you check whether it works with diabled and enabled ipv6? -- To view, visit https://gerrit.ovirt.org/61782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonvdscli: change hostname default
gerrit-hooks has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 1: * #1358530::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1358530::OK, public bug * Check Product::#1358530::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/61782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: jsonvdscli: change hostname default
Piotr Kliczewski has uploaded a new change for review.
Change subject: jsonvdscli: change hostname default
..
jsonvdscli: change hostname default
We want to mitigate dns lookups due to potential issues with
connectivity or dns servers.
Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1
Signed-off-by: Piotr Kliczewski
Bug-Url: https://bugzilla.redhat.com/1358530
---
M lib/vdsm/jsonrpcvdscli.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/61782/1
diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index b0cc5ec..bd9088a 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -203,7 +203,7 @@
useSSL=None,
responseQueue=None):
if host is None:
-host = socket.gethostname()
+host = 'localhost'
if port is None:
port = int(config.getint('addresses', 'management_port'))
--
To view, visit https://gerrit.ovirt.org/61782
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
