Change in vdsm[master]: machinetype: split and slightly refactor cpu_models function
gerrit-hooks has posted comments on this change. Change subject: machinetype: split and slightly refactor cpu_models function .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/54301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I264209f94ef7140e27c534f1df408c7a3a17bbbf Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: machinetype: split and slightly refactor cpu_models function
Dan Kenigsberg has submitted this change and it was merged. Change subject: machinetype: split and slightly refactor cpu_models function .. machinetype: split and slightly refactor cpu_models function cpu_models has grown large as it has to a) having to find the correct architecture element, b) find the cpu models in that element. This patch splits the function and updates variables to have more descriptive names. Change-Id: I264209f94ef7140e27c534f1df408c7a3a17bbbf Signed-off-by: Martin Polednik Reviewed-on: https://gerrit.ovirt.org/54301 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani --- M lib/vdsm/machinetype.py 1 file changed, 30 insertions(+), 26 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/54301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I264209f94ef7140e27c534f1df408c7a3a17bbbf Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: machinetype: split and slightly refactor cpu_models function
Francesco Romani has posted comments on this change. Change subject: machinetype: split and slightly refactor cpu_models function .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I264209f94ef7140e27c534f1df408c7a3a17bbbf Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: machinetype: split and slightly refactor cpu_models function
Francesco Romani has posted comments on this change.
Change subject: machinetype: split and slightly refactor cpu_models function
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/54301/1/lib/vdsm/machinetype.py
File lib/vdsm/machinetype.py:
Line 112: arch = 'ppc64'
Line 113:
Line 114: arch_element = None
Line 115:
Line 116: arch_elements = cpu_map.findall('arch')
> but keeping it avoids needing 2 findalls
So let's keep it!
Line 117:
Line 118: if arch_elements:
Line 119: for element in arch_elements:
Line 120: if element.get('name') == arch:
--
To view, visit https://gerrit.ovirt.org/54301
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I264209f94ef7140e27c534f1df408c7a3a17bbbf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: machinetype: split and slightly refactor cpu_models function
Jenkins CI has posted comments on this change. Change subject: machinetype: split and slightly refactor cpu_models function .. Patch Set 5: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 4 -- To view, visit https://gerrit.ovirt.org/54301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I264209f94ef7140e27c534f1df408c7a3a17bbbf Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: machinetype: split and slightly refactor cpu_models function
Martin Polednik has posted comments on this change. Change subject: machinetype: split and slightly refactor cpu_models function .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/54301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I264209f94ef7140e27c534f1df408c7a3a17bbbf Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: machinetype: split and slightly refactor cpu_models function
gerrit-hooks has posted comments on this change. Change subject: machinetype: split and slightly refactor cpu_models function .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I264209f94ef7140e27c534f1df408c7a3a17bbbf Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: machinetype: split and slightly refactor cpu_models function
Jenkins CI has posted comments on this change. Change subject: machinetype: split and slightly refactor cpu_models function .. Patch Set 3: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 2 -- To view, visit https://gerrit.ovirt.org/54301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I264209f94ef7140e27c534f1df408c7a3a17bbbf Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: machinetype: split and slightly refactor cpu_models function
Martin Polednik has posted comments on this change.
Change subject: machinetype: split and slightly refactor cpu_models function
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/54301/1/lib/vdsm/machinetype.py
File lib/vdsm/machinetype.py:
Line 112: arch = 'ppc64'
Line 113:
Line 114: arch_element = None
Line 115:
Line 116: arch_elements = cpu_map.findall('arch')
> we probably don't need this temporary
but keeping it avoids needing 2 findalls
Line 117:
Line 118: if arch_elements:
Line 119: for element in arch_elements:
Line 120: if element.get('name') == arch:
--
To view, visit https://gerrit.ovirt.org/54301
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I264209f94ef7140e27c534f1df408c7a3a17bbbf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: machinetype: split and slightly refactor cpu_models function
gerrit-hooks has posted comments on this change. Change subject: machinetype: split and slightly refactor cpu_models function .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I264209f94ef7140e27c534f1df408c7a3a17bbbf Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
