Change in vdsm[master]: network: Recognize macvlans as fake devices
Dan Kenigsberg has posted comments on this change. Change subject: network: Recognize macvlans as fake devices .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8193039478020246cac81b86406dfd9dbebed7ea Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Anatoly Litovsky Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Recognize macvlans as fake devices
Dan Kenigsberg has submitted this change and it was merged. Change subject: network: Recognize macvlans as fake devices .. network: Recognize macvlans as fake devices macvlans are yet another type of virtual NICs. This patch allows vdsm to accept macvlan devices as fake NICs. It can be useful if vdsm is run inside a container, and the host's NICs are exposed to the container via macvlans. Change-Id: I8193039478020246cac81b86406dfd9dbebed7ea Signed-off-by: Fabian Deutsch Reviewed-on: https://gerrit.ovirt.org/40608 Tested-by: Fabian Deutsch Continuous-Integration: Jenkins CI Reviewed-by: Ido Barkan Reviewed-by: Dan Kenigsberg --- M lib/vdsm/ipwrapper.py 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Fabian Deutsch: Verified Ido Barkan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8193039478020246cac81b86406dfd9dbebed7ea Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Anatoly Litovsky Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Recognize macvlans as fake devices
automat...@ovirt.org has posted comments on this change. Change subject: network: Recognize macvlans as fake devices .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8193039478020246cac81b86406dfd9dbebed7ea Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Anatoly Litovsky Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Recognize macvlans as fake devices
Ido Barkan has posted comments on this change. Change subject: network: Recognize macvlans as fake devices .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8193039478020246cac81b86406dfd9dbebed7ea Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Anatoly Litovsky Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Recognize macvlans as fake devices
automat...@ovirt.org has posted comments on this change. Change subject: network: Recognize macvlans as fake devices .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8193039478020246cac81b86406dfd9dbebed7ea Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Anatoly Litovsky Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Recognize macvlans as fake devices
automat...@ovirt.org has posted comments on this change. Change subject: network: Recognize macvlans as fake devices .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8193039478020246cac81b86406dfd9dbebed7ea Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Anatoly Litovsky Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Recognize macvlans as fake devices
automat...@ovirt.org has posted comments on this change. Change subject: network: Recognize macvlans as fake devices .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8193039478020246cac81b86406dfd9dbebed7ea Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Anatoly Litovsky Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Recognize macvlans as fake devices
Fabian Deutsch has posted comments on this change. Change subject: network: Recognize macvlans as fake devices .. Patch Set 1: (1 comment) The motivation is to let vdsm use macvlan nics inside a container, where real nics are not always visible. https://gerrit.ovirt.org/#/c/40608/1/lib/vdsm/ipwrapper.py File lib/vdsm/ipwrapper.py: Line 219: """ Line 220: Returns True iff vdsm config marks the DUMMY or VETH dev to be reported Line 221: as NIC. Line 222: """ Line 223: if self.isDUMMY() or self.isVETH() or self.isMACVLAN(): > please note that macvlans are used by libvirt to connect VMs to VFs (used b Right, that is a good hint. It then seems that it should not be enabled by default to also recognice macvlans as nics. Maybe this makese sense when we see that vdsm is run in a container. Line 224: return anyFnmatch(self.name, self._fakeNics) Line 225: return False Line 226: Line 227: def isNICLike(self): -- To view, visit https://gerrit.ovirt.org/40608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8193039478020246cac81b86406dfd9dbebed7ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Anatoly Litovsky Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Recognize macvlans as fake devices
Ido Barkan has posted comments on this change. Change subject: network: Recognize macvlans as fake devices .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/40608/1//COMMIT_MSG Commit Message: can you explain the motivation for this extension? Line 1: Parent: 9fb5009a (utils: add CommandStream class) Line 2: Author: Fabian Deutsch Line 3: AuthorDate: 2015-05-06 14:29:40 +0200 Line 4: Commit: Fabian Deutsch -- To view, visit https://gerrit.ovirt.org/40608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8193039478020246cac81b86406dfd9dbebed7ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Anatoly Litovsky Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Recognize macvlans as fake devices
Dan Kenigsberg has posted comments on this change. Change subject: network: Recognize macvlans as fake devices .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/40608/1/lib/vdsm/ipwrapper.py File lib/vdsm/ipwrapper.py: Line 219: """ Line 220: Returns True iff vdsm config marks the DUMMY or VETH dev to be reported Line 221: as NIC. Line 222: """ Line 223: if self.isDUMMY() or self.isVETH() or self.isMACVLAN(): please note that macvlans are used by libvirt to connect VMs to VFs (used by our vmfex hooks). I think that by default they would not match the _fakeNics glob, so they would not be reported as such. Line 224: return anyFnmatch(self.name, self._fakeNics) Line 225: return False Line 226: Line 227: def isNICLike(self): -- To view, visit https://gerrit.ovirt.org/40608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8193039478020246cac81b86406dfd9dbebed7ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Anatoly Litovsky Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Recognize macvlans as fake devices
Fabian Deutsch has posted comments on this change. Change subject: network: Recognize macvlans as fake devices .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8193039478020246cac81b86406dfd9dbebed7ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Anatoly Litovsky Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Recognize macvlans as fake devices
Fabian Deutsch has uploaded a new change for review. Change subject: network: Recognize macvlans as fake devices .. network: Recognize macvlans as fake devices macvlans are yet another type of virtual NICs. This patch allows vdsm to accept macvlan devices as fake NICs. Change-Id: I8193039478020246cac81b86406dfd9dbebed7ea Signed-off-by: Fabian Deutsch --- M lib/vdsm/ipwrapper.py 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/40608/1 diff --git a/lib/vdsm/ipwrapper.py b/lib/vdsm/ipwrapper.py index 2b7d455..8efc393 100644 --- a/lib/vdsm/ipwrapper.py +++ b/lib/vdsm/ipwrapper.py @@ -212,12 +212,15 @@ def isVLAN(self): return self.type == LinkType.VLAN +def isMACVLAN(self): +return self.type == LinkType.MACVLAN + def isFakeNIC(self): """ Returns True iff vdsm config marks the DUMMY or VETH dev to be reported as NIC. """ -if self.isDUMMY() or self.isVETH(): +if self.isDUMMY() or self.isVETH() or self.isMACVLAN(): return anyFnmatch(self.name, self._fakeNics) return False -- To view, visit https://gerrit.ovirt.org/40608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8193039478020246cac81b86406dfd9dbebed7ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: Recognize macvlans as fake devices
automat...@ovirt.org has posted comments on this change. Change subject: network: Recognize macvlans as fake devices .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8193039478020246cac81b86406dfd9dbebed7ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
