Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
Jenkins CI RO has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 20: Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/37037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
Jenkins CI RO has abandoned this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/37037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
gerrit-hooks has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 20: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/37037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
automat...@ovirt.org has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 19: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
Ido Barkan has posted comments on this change.
Change subject: networkTests: stop NetworkManager from managing devices using
NM_CONTROLLED=no
..
Patch Set 19:
(4 comments)
https://gerrit.ovirt.org/#/c/37037/19/tests/functional/dummy.py
File tests/functional/dummy.py:
Line 51: linkDel(dummy_name)
Line 52: except IPRoute2Error as e:
Line 53: raise SkipTest("Unable to delete the dummy interface %s: %s" %
Line 54:(dummy_name, e))
Line 55: if nm_restore_control:
if the link is removed, why does nm needs to unmanage it?
Line 56: networkmanager.toggle_managed(dummy_name, True)
Line 57:
Line 58:
Line 59: @contextmanager
https://gerrit.ovirt.org/#/c/37037/19/tests/functional/networkmanager.py
File tests/functional/networkmanager.py:
Line 47: """
Line 48: if pgrep('NetworkManager'):
Line 49: ifcfg_path = NET_CONF_PREF + iface
Line 50: with open(ifcfg_path, 'w') as ifcfg:
Line 51: ifcfg.write('# Temporary file generated by VDSM. Makes'
just curious here: is there a nmcli api for ignoring connections (devices)?
Line 52: ' NetworkManager ignore the interface.\n'
Line 53: 'DEVICE={0}\n'
Line 54: 'NM_CONTROLLED={1}\n'.format(iface, 'yes' if
Line 55: nm_controlled
else 'no'))
Line 59: raise SkipTest('Failed to set NetworkManager control
over %s '
Line 60:'to %s.\n%s\n%s' % (iface,
nm_controlled, out,
Line 61:err))
Line 62: finally:
Line 63: rmFile(ifcfg_path)
isn't the file removed too early? or it should exist just for the life of the
'conn load' call?
also, is toggle managed designed to be used only from the unmanage context
manager? if so, rmFile might be called only when nm_controlled is False.
also, do you need a real file here? maybe you can feed nm from a memory buffer
with a pipe?
https://gerrit.ovirt.org/#/c/37037/19/tests/functional/veth.py
File tests/functional/veth.py:
Line 45: except IPRoute2Error:
Line 46: raise SkipTest('Failed to create a veth pair.')
Line 47: finally:
Line 48: # the peer device is removed by the kernel
Line 49: dummy.remove(left_side, nm_restore_control=False)
this try-finally block be changed to 'with vethIf()'?
Line 50:
Line 51:
Line 52: setIP = dummy.setIP
Line 53: setIP
--
To view, visit https://gerrit.ovirt.org/37037
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
Ido Barkan has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 19: Code-Review-1 -1 just for visiblity -- To view, visit https://gerrit.ovirt.org/37037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
Ondřej Svoboda has posted comments on this change.
Change subject: networkTests: stop NetworkManager from managing devices using
NM_CONTROLLED=no
..
Patch Set 19:
(4 comments)
https://gerrit.ovirt.org/#/c/37037/19/tests/functional/dummy.py
File tests/functional/dummy.py:
Line 51: linkDel(dummy_name)
Line 52: except IPRoute2Error as e:
Line 53: raise SkipTest("Unable to delete the dummy interface %s: %s" %
Line 54:(dummy_name, e))
Line 55: if nm_restore_control:
> if the link is removed, why does nm needs to unmanage it?
This patch is quite old so NM's behaviour has changed over the time. Now I can
only say we're being nice to its runtime database. Whatever we modify, it's
good to clean up. I'll try to give you a better answer together with
verification.
Line 56: networkmanager.toggle_managed(dummy_name, True)
Line 57:
Line 58:
Line 59: @contextmanager
https://gerrit.ovirt.org/#/c/37037/19/tests/functional/networkmanager.py
File tests/functional/networkmanager.py:
Line 47: """
Line 48: if pgrep('NetworkManager'):
Line 49: ifcfg_path = NET_CONF_PREF + iface
Line 50: with open(ifcfg_path, 'w') as ifcfg:
Line 51: ifcfg.write('# Temporary file generated by VDSM. Makes'
> just curious here: is there a nmcli api for ignoring connections (devices)?
If I were aware of a nmcli command I would have used it instead of needlessly
bringing ifcfg files into the game.
I would go directly to NM's D-Bus interface (or a binding thereof) if we're to
use its API (but let's save it as a next step, possibly paving a way for a
configurator).
Line 52: ' NetworkManager ignore the interface.\n'
Line 53: 'DEVICE={0}\n'
Line 54: 'NM_CONTROLLED={1}\n'.format(iface, 'yes' if
Line 55: nm_controlled
else 'no'))
Line 59: raise SkipTest('Failed to set NetworkManager control
over %s '
Line 60:'to %s.\n%s\n%s' % (iface,
nm_controlled, out,
Line 61:err))
Line 62: finally:
Line 63: rmFile(ifcfg_path)
> isn't the file removed too early? or it should exist just for the life of t
No, the file's existence is meant to be short-lived, just to pass a message to
NetworkManager. For both managing and unmanaging I want to create a file and
discard it right after use.
I recall that nmcli would refuse to load a file from a location other than
/etc/sysconfig/network-scripts/ (for whatever, security reasons?), it's pretty
picky about its input. I haven't tried to pipe into it but I believe it's not
possible.
https://gerrit.ovirt.org/#/c/37037/19/tests/functional/veth.py
File tests/functional/veth.py:
Line 45: except IPRoute2Error:
Line 46: raise SkipTest('Failed to create a veth pair.')
Line 47: finally:
Line 48: # the peer device is removed by the kernel
Line 49: dummy.remove(left_side, nm_restore_control=False)
> this try-finally block be changed to 'with vethIf()'?
vethIf is gone, and we're actually inside its descendant, just becoming more
beefed up :-)
Line 50:
Line 51:
Line 52: setIP = dummy.setIP
Line 53: setIP
--
To view, visit https://gerrit.ovirt.org/37037
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
automat...@ovirt.org has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 20: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 20: Verified+1 Tested together with https://gerrit.ovirt.org/#/c/37733/11 and https://gerrit.ovirt.org/#/c/38945/4 with no regressions and without the need to stop NetworkManager or firewalld, just a freshly booted current EL7 system. -- To view, visit https://gerrit.ovirt.org/37037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 20: I found a Python wrapper around NetworkManager DBus API but it's not packaged nor fully capable yet. https://github.com/seveas/python-networkmanager https://pythonhosted.org/python-networkmanager/ -- To view, visit https://gerrit.ovirt.org/37037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 20: (1 comment) An answer, but not so thorough for today. https://gerrit.ovirt.org/#/c/37037/20/tests/functional/networkmanager.py File tests/functional/networkmanager.py: Line 38: toggle_managed(iface, True) The simple reason why I let NM manage the iface is that you can see in the logs it was happy to take over control. I believe (but don't have time today to check) that if we don't let NM manage the iface before removing it – and create it anew, NM would still refuse to manage it. It probably has some _runtime_ database of its "connections" (the term means "profiles" in NM parlance). -- To view, visit https://gerrit.ovirt.org/37037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
Ido Barkan has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 20: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/37037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15591/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14789/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15760/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2628/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/567/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
Ondřej Svoboda has posted comments on this change.
Change subject: networkTests: stop NetworkManager from managing devices using
NM_CONTROLLED=no
..
Patch Set 9: Verified+1
All tests (except those marked "slow") were running on Fedora 21 even if left
on the same playground as NetworkManager.
testSetupNetworksAddOverExistingBond sadly made its comeback with:
OperStateChangedError: bond11 operstate changed: down -> [('bond11', 'up'),
('bond11', 'up')]
--
To view, visit http://gerrit.ovirt.org/37037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15592/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14790/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15761/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2629/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/568/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15595/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14793/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15764/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2631/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/571/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15596/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14794/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15765/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2632/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/572/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 11: Verified+1 Removed the now unused veth.remove function. -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15600/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14798/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15769/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2636/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/576/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 12: Verified+1 Mentioned the tiny shortcoming: we make NetworkManager the owner of one veth side twice. Enjoy, NetworkManager. -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15602/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14800/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15771/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2638/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/578/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
Ondřej Svoboda has posted comments on this change.
Change subject: networkTests: stop NetworkManager from managing devices using
NM_CONTROLLED=no
..
Patch Set 12: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/37037/12/tests/functional/networkmanager.py
File tests/functional/networkmanager.py:
Line 44: ifcfg.write('DEVICE={0}\n'
Line 45: 'NM_CONTROLLED={1}\n'.format(iface,
nm_controlled))
Line 46: rc, out, err = execCmd([EXT_NMCLI, 'conn', 'load', ifcfg_path])
Line 47: if rc:
Line 48: raise SkipTest('Failed to set NetworkManager control over
%s to '
In this case the ifcfg file would not be deleted, I'll fix this.
Line 49:'%s.\n%s\n%s' % (iface, nm_controlled, out,
err))
--
To view, visit http://gerrit.ovirt.org/37037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 13: Verified+1 DHCP functional tests run and NetworkManager is happy to ignore and later regain its devices for network management, as logs show: Feb 15 19:47:12 rhel7 NetworkManager[847]: ifcfg-rh: Ignoring connection 'System veth_UGmnRxix35' / device 'veth_UGmnRxix35' due to NM_CONTROLLED=no. Feb 15 19:47:26 rhel7 NetworkManager[847]: ifcfg-rh: Managing connection 'System veth_UGmnRxix35' and its device because NM_CONTROLLED was true. -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
Ondřej Svoboda has posted comments on this change.
Change subject: networkTests: stop NetworkManager from managing devices using
NM_CONTROLLED=no
..
Patch Set 13:
(1 comment)
Why I moved toggle_managed(dummy_name, 'yes') after linkDel() in dummy.remove
(which is also used in veth).
http://gerrit.ovirt.org/#/c/37037/13/tests/functional/dummy.py
File tests/functional/dummy.py:
Line 44: def remove(dummy_name):
Line 45: """
Line 46: Remove the dummy interface. This assumes root privileges.
Line 47: """
Line 48: networkmanager.toggle_managed(dummy_name, 'yes')
If this quite unimportant command failed, for any reason, we would not delete
the dummy/veth. Even if the command is called after the link is deleted,
NetworkManager is still happy.
Line 49: try:
Line 50: linkDel(dummy_name)
Line 51: except IPRoute2Error as e:
Line 52: raise SkipTest("Unable to delete dummy interface %s because
%s" %
--
To view, visit http://gerrit.ovirt.org/37037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 13: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15704/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14903/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15873/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2696/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/680/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 14: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15724/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14923/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15893/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2697/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/700/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 15: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15727/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14926/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15896/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2699/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/703/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
Dan Kenigsberg has posted comments on this change.
Change subject: networkTests: stop NetworkManager from managing devices using
NM_CONTROLLED=no
..
Patch Set 15: Code-Review-1
(4 comments)
http://gerrit.ovirt.org/#/c/37037/15/lib/vdsm/constants.py.in
File lib/vdsm/constants.py.in:
Line 131: EXT_MOUNT = '@MOUNT_PATH@'
Line 132: EXT_MULTIPATH = '@MULTIPATH_PATH@'
Line 133:
Line 134: EXT_NICE = '@NICE_PATH@'
Line 135: EXT_NMCLI = '@NMCLI_PATH@'
please use the more moder CommandPath construct instead of this constants
junkyard.
Line 136:
Line 137: EXT_PGREP = '@PGREP_PATH@'
Line 138: EXT_PYTHON = '@PYTHON@'
Line 139:
http://gerrit.ovirt.org/#/c/37037/15/tests/functional/networkmanager.py
File tests/functional/networkmanager.py:
Line 36: for iface in ifaces:
Line 37: toggle_managed(iface, 'yes')
Line 38:
Line 39:
Line 40: def toggle_managed(iface, nm_controlled):
please pass nm_controlled as a boolean. document that this does nothing if NM
is not found running.
Line 41: if pgrep('NetworkManager'):
Line 42: ifcfg_path = NET_CONF_PREF + iface
Line 43: with open(ifcfg_path, 'w') as ifcfg:
Line 44: ifcfg.write('DEVICE={0}\n'
Line 39:
Line 40: def toggle_managed(iface, nm_controlled):
Line 41: if pgrep('NetworkManager'):
Line 42: ifcfg_path = NET_CONF_PREF + iface
Line 43: with open(ifcfg_path, 'w') as ifcfg:
We must add a comment into the file, stating that it is intended to be
temporary, just to mark the iface as non-managed.
Line 44: ifcfg.write('DEVICE={0}\n'
Line 45: 'NM_CONTROLLED={1}\n'.format(iface,
nm_controlled))
Line 46: try:
Line 47: rc, out, err = execCmd([EXT_NMCLI, 'conn', 'load',
ifcfg_path])
http://gerrit.ovirt.org/#/c/37037/15/tests/functional/veth.py
File tests/functional/veth.py:
Line 27: import networkmanager
Line 28:
Line 29:
Line 30: @contextmanager
Line 31: def pair(prefix='veth_', max_length=15):
since nm patch is being stalled, please split the veth refactoring to its own
patch.
Line 32: """
Line 33: Yield a pair of veth devices. This assumes root privileges
(currently
Line 34: required by all tests anyway).
Line 35:
--
To view, visit http://gerrit.ovirt.org/37037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16672/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16844/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2790/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
automat...@ovirt.org has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
automat...@ovirt.org has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
automat...@ovirt.org has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
automat...@ovirt.org has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
automat...@ovirt.org has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
automat...@ovirt.org has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
automat...@ovirt.org has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
automat...@ovirt.org has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
automat...@ovirt.org has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 15: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
automat...@ovirt.org has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 16: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
automat...@ovirt.org has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 17: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
automat...@ovirt.org has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 18: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 18: Build Started (1/3) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16898/ -- To view, visit https://gerrit.ovirt.org/37037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 18: Build Started (2/3) -> http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2819/ -- To view, visit https://gerrit.ovirt.org/37037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 17: Build Started (3/3) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17067/ -- To view, visit https://gerrit.ovirt.org/37037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 17: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16895/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17067/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2816/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 18: Build Started (3/3) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17070/ -- To view, visit https://gerrit.ovirt.org/37037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 18: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16898/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17070/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2819/ : The patch does not pass the network functional tests -- To view, visit https://gerrit.ovirt.org/37037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
