Change in vdsm[master]: ovs: acquire ifaces
gerrit-hooks has posted comments on this change. Change subject: ovs: acquire ifaces .. Patch Set 40: * #1364081::Update tracker: OK * Set MODIFIED::bug 1364081#1364081IGNORE, not all related patches are closed, check 61049 -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Gerrit-PatchSet: 40 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: acquire ifaces
Dan Kenigsberg has posted comments on this change. Change subject: ovs: acquire ifaces .. Patch Set 39: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Gerrit-PatchSet: 39 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: acquire ifaces
Dan Kenigsberg has submitted this change and it was merged. Change subject: ovs: acquire ifaces .. ovs: acquire ifaces Switch returns list of used devices, on upper level we should check if they are owned by us and if not, aquire them. Bug-Url: https://bugzilla.redhat.com/1364081 Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/60404 Reviewed-by: Edward Haas Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M lib/vdsm/network/netswitch.py M lib/vdsm/network/ovs/switch.py M tests/network/func_dhclient_test.py M tests/network/func_static_ip_test.py M tests/network/netfunctestlib.py M tests/network/nettestlib.py A tests/network/ovs_switch_test.py 7 files changed, 273 insertions(+), 18 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Gerrit-PatchSet: 40 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: acquire ifaces
gerrit-hooks has posted comments on this change. Change subject: ovs: acquire ifaces .. Patch Set 39: * #1364081::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1364081::OK, public bug * Check Product::#1364081::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Gerrit-PatchSet: 39 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: acquire ifaces
gerrit-hooks has posted comments on this change. Change subject: ovs: acquire ifaces .. Patch Set 38: * #1364081::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1364081::OK, public bug * Check Product::#1364081::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Gerrit-PatchSet: 38 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: acquire ifaces
gerrit-hooks has posted comments on this change. Change subject: ovs: acquire ifaces .. Patch Set 37: * #1364081::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1364081::OK, public bug * Check Product::#1364081::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Gerrit-PatchSet: 37 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: acquire ifaces
Edward Haas has posted comments on this change. Change subject: ovs: acquire ifaces .. Patch Set 36: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: acquire ifaces
Petr Horáček has posted comments on this change. Change subject: ovs: acquire ifaces .. Patch Set 36: Verified+1 (2 comments) Passed network/*_test.py OK. https://gerrit.ovirt.org/#/c/60404/34/lib/vdsm/network/ovs/switch.py File lib/vdsm/network/ovs/switch.py: Line 69: self._acquired_ifaces = set() Line 70: Line 71: @property Line 72: def acquired_ifaces(self): Line 73: """ > I prefer a more descriptive and detailed explanation. Done Line 74: Report the interfaces that have been added to networks/bondings, either Line 75: by add or edit actions, including ifaces that have been removed and Line 76: re-added to a different network/bonding. Line 77: """ https://gerrit.ovirt.org/#/c/60404/34/tests/network/ovs_switch_test.py File tests/network/ovs_switch_test.py: PS34, Line 86: _init_ovs_info(mock_ovs_info): > _init_ovs_info(info) Done -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: acquire ifaces
gerrit-hooks has posted comments on this change. Change subject: ovs: acquire ifaces .. Patch Set 36: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: acquire ifaces
gerrit-hooks has posted comments on this change. Change subject: ovs: acquire ifaces .. Patch Set 35: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Gerrit-PatchSet: 35 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: acquire ifaces
Edward Haas has posted comments on this change. Change subject: ovs: acquire ifaces .. Patch Set 34: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/60404/34/lib/vdsm/network/ovs/switch.py File lib/vdsm/network/ovs/switch.py: Line 69: self._acquired_ifaces = set() Line 70: Line 71: @property Line 72: def acquired_ifaces(self): Line 73: """Interfaces used by networks and bonds in this setup.""" I prefer a more descriptive and detailed explanation. Something like: Report the ifaces that have been added to networks, either by add or edit actions, including ifaces that have been removed and re-added to a different network. Line 74: return self._acquired_ifaces Line 75: Line 76: def __enter__(self): Line 77: return self https://gerrit.ovirt.org/#/c/60404/34/tests/network/ovs_switch_test.py File tests/network/ovs_switch_test.py: PS34, Line 86: _empty_mock_ovs_info(mock_ovs_info) _init_ovs_info(info) -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Gerrit-PatchSet: 34 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: acquire ifaces
Petr Horáček has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 34: Verified+1
(4 comments)
Passed network/*_test.py OK
https://gerrit.ovirt.org/#/c/60404/31/tests/network/func_static_ip_test.py
File tests/network/func_static_ip_test.py:
PS31, Line 137: test_attach_nic_with_ip_to_ip_network(self)
> test_attach_nic_with_ip_as_a_slave_to_ip_network
Done. Plus the same for nic-based networks.
https://gerrit.ovirt.org/#/c/60404/31/tests/network/ovs_switch_test.py
File tests/network/ovs_switch_test.py:
PS31, Line 31:
> You can move it to the class, it's a classic scenario to use it.
Done
PS31, Line 33: _empty_mock_ovs_info(mock_ovs_info)
:
: self._assert_acquired_ifaces_post_sw
> Use a helper for this, it repeats 3 times.
I moved it to setUp()
Line 76: with
mock.patch('vdsm.network.ovs.driver.vsctl.Transaction.commit',
Line 77: lambda x: None):
Line 78: with switch.Setup(ovsdb, _ovs_info) as s:
Line 79: s.edit_bonds(bonds2edit)
Line 80: s.add_bonds(bonds2add)
> Missing some scenarios:
This is not needed, we do not filter out ifaces which were part of OVS before.
I added docstring to Setup.acquired_ifaces.
Line 81: s.add_nets(nets2add)
Line 82:
Line 83: self.assertEqual(s.acquired_ifaces, expected_ifaces)
Line 84:
--
To view, visit https://gerrit.ovirt.org/60404
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b
Gerrit-PatchSet: 34
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: acquire ifaces
gerrit-hooks has posted comments on this change. Change subject: ovs: acquire ifaces .. Patch Set 34: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Gerrit-PatchSet: 34 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: acquire ifaces
gerrit-hooks has posted comments on this change. Change subject: ovs: acquire ifaces .. Patch Set 33: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: acquire ifaces
gerrit-hooks has posted comments on this change. Change subject: ovs: acquire ifaces .. Patch Set 32: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: acquire ifaces
Edward Haas has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 31: Code-Review-1
(4 comments)
https://gerrit.ovirt.org/#/c/60404/31/tests/network/func_static_ip_test.py
File tests/network/func_static_ip_test.py:
PS31, Line 137: test_attach_slave_with_ip_to_ipless_network
test_attach_nic_with_ip_as_a_slave_to_ip_network
The IP from the nic should move to the network, nic/s and bond should have no
ip, network should get the nic ip.
https://gerrit.ovirt.org/#/c/60404/31/tests/network/ovs_switch_test.py
File tests/network/ovs_switch_test.py:
PS31, Line 31: @mock.patch('vdsm.network.ovs.info.OvsInfo')
You can move it to the class, it's a classic scenario to use it.
PS31, Line 33: mock_ovs_info.bridges = {}
: mock_ovs_info.bridges_by_sb = {}
: mock_ovs_info.northbounds_by_sb = {}
Use a helper for this, it repeats 3 times.
Perhaps _ovs_info_init(ovs_info)
Line 76: mock_ovs_info,
Line 77: bonds2edit={'bond1': {'nics': ['eth0', 'eth1']}},
Line 78: nets2add={}, bonds2add={},
Line 79: expected_ifaces={'eth0', 'eth1'})
Line 80:
Missing some scenarios:
- Edit bond: Leave one slave unchanged (perhaps just change the edit bond test).
- Edit networks: swapping nics between networks and moving a nic from one
network to another (original network removed).
Line 81: def _assert_acquired_ifaces_post_switch_setup(
Line 82: self, _ovs_info, nets2add, bonds2add, bonds2edit,
expected_ifaces):
Line 83:
Line 84: ovsdb = driver.vsctl.create()
--
To view, visit https://gerrit.ovirt.org/60404
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: acquire ifaces
Jenkins CI has posted comments on this change. Change subject: ovs: acquire ifaces .. Patch Set 31: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 30 -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: acquire ifaces
Petr Horáček has posted comments on this change. Change subject: ovs: acquire ifaces .. Patch Set 31: Verified+1 Passed network/*_test.py -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: acquire ifaces
gerrit-hooks has posted comments on this change. Change subject: ovs: acquire ifaces .. Patch Set 31: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
