Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
automat...@ovirt.org has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 11: * Update tracker::#1138690::OK * Check Bug-Url::OK * Check Public Bug::#1138690::OK, public bug * Check Product::#1138690::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
automat...@ovirt.org has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 10: * Update tracker::#1138690::OK * Check Bug-Url::OK * Check Public Bug::#1138690::OK, public bug * Check Product::#1138690::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
automat...@ovirt.org has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 12: * Update tracker::#1138690::OK * Check Bug-Url::OK * Check Public Bug::#1138690::OK, public bug * Check Product::#1138690::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
automat...@ovirt.org has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 14: * Update tracker::#1138690::OK * Set MODIFIED::bug 1138690#1138690IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
automat...@ovirt.org has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 9: * Update tracker::#1138690::OK * Check Bug-Url::OK * Check Public Bug::#1138690::OK, public bug * Check Product::#1138690::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
automat...@ovirt.org has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 13: * Update tracker::#1138690::OK * Check Bug-Url::OK * Check Public Bug::#1138690::OK, public bug * Check Product::#1138690::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
Dan Kenigsberg has submitted this change and it was merged. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. qemu-img: check/use -T src_cache option in convert/rebase when available qemu-img is used for operations like disk move or snapshot delete. This process reads data using the hypervisor page cache. As this data might be hotter than any VM memory the system starts swapping out memory pages of the running VMs. vdsm already uses -t none option to avoid cache for output image. Now qemu-img introduced a new -T src_cache to avoid cache for the input image (bz#1116558). This patch is testing if qemu-img has the new -T src_cache option available for convert and rebase commands and using it with -T none when true. Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138690 Signed-off-by: Amador Pahim apa...@redhat.com Reviewed-on: http://gerrit.ovirt.org/36308 Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M lib/vdsm/qemuimg.py M tests/qemuimgTests.py 2 files changed, 102 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Federico Simoncelli: Looks good to me, approved Amador Pahim: Verified -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 14: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/630/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/229/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4613/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/606/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/233/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/631/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/233/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/219/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/626/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6452/ : FAILURE -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
Federico Simoncelli has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15536/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15368/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14564/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
Nir Soffer has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 12: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/36308/12/tests/qemuimgTests.py File tests/qemuimgTests.py: Line 315: compare [-f fmt] [-F fmt] [-T src_cache] ... Line 316: convert [-c] [-p] [-q] [-n] [-f fmt] [-t cache] ... Line 317: rebase [-q] [-f fmt] [-t cache] [-T src_cache] [-p] ... Line 318: resize [-q] filename [+ | -]size ... Line 319: ... The ... in my comment was meaning other-text, not literal ... :-) Line 320: Line 321: Line 322: return 0, out, '' Line 323: -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
Amador Pahim has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/36308/12/tests/qemuimgTests.py File tests/qemuimgTests.py: Line 315: compare [-f fmt] [-F fmt] [-T src_cache] ... Line 316: convert [-c] [-p] [-q] [-n] [-f fmt] [-t cache] ... Line 317: rebase [-q] [-f fmt] [-t cache] [-T src_cache] [-p] ... Line 318: resize [-q] filename [+ | -]size ... Line 319: ... The ... in my comment was meaning other-text, not literal ... :-) Oh, ok. compare and resize are the other texts for convert and rebase. Fixing and taking the opportunity to rebase the patch. Line 320: Line 321: Line 322: return 0, out, '' Line 323: -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
Nir Soffer has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 13: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 13: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15542/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15374/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14570/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
Amador Pahim has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 13: Verified+1 -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
Allon Mureinik has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 11: Ping? Can we move forward with this? -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
Nir Soffer has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 11: (3 comments) http://gerrit.ovirt.org/#/c/36308/11/tests/qemuimgTests.py File tests/qemuimgTests.py: Line 287: return 0, ' compare [-f fmt] [-F fmt] [-T src_cache] ...\n' \ Line 288: ' convert [-c] [-p] [-q] [-n] [-f fmt] [-t cache] ' \ Line 289: '[-T src_cache] [-O output_fmt] ...\n' \ Line 290: ' rebase [-q] [-f fmt] [-t cache] [-T src_cache] [-p] ...\n' \ Line 291: ' resize [-q] filename [+ | -]size ...\n', '' This style is fragile and not very clear. Please use this: out = \ ... compare [-f fmt] [-F fmt] [-T src_cache] ... convert [-c] [-f fmt] [-t cache] [-T src_cache] [-O output_fmt] ... rebase [-q] [-f fmt] [-t cache] [-T src_cache] [-p] ... ... return 0, out, '' Note that I remove some non-relevant flags from the output so it keeps pep8 happy. Line 292: Line 293: Line 294: def src_cache_unsupported(cmd, **kw): Line 295: return 0, ' compare [-f fmt] [-F fmt] ...\n' \ Line 291: ' resize [-q] filename [+ | -]size ...\n', '' Line 292: Line 293: Line 294: def src_cache_unsupported(cmd, **kw): Line 295: return 0, ' compare [-f fmt] [-F fmt] ...\n' \ It would be useful to include [-T src_cache] in the commands that you do *not* test, to ensure that code is checking both the command name and the flag. Line 296: ' convert [-c] [-p] [-q] [-n] [-f fmt] [-t cache] ' \ Line 297: '[-O output_fmt] ...\n' \ Line 298: ' rebase [-q] [-f fmt] [-t cache] [-p] ...\n' \ Line 299: ' resize [-q] filename [+ | -]size ...\n', '' Line 295: return 0, ' compare [-f fmt] [-F fmt] ...\n' \ Line 296: ' convert [-c] [-p] [-q] [-n] [-f fmt] [-t cache] ' \ Line 297: '[-O output_fmt] ...\n' \ Line 298: ' rebase [-q] [-f fmt] [-t cache] [-p] ...\n' \ Line 299: ' resize [-q] filename [+ | -]size ...\n', '' Same as previous. Line 300: Line 301: Line 302: class SupportsSrcCacheTests(TestCaseBase): Line 303: -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15346/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15177/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14389/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
Amador Pahim has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
Nir Soffer has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 10: Amdador, if this will break the test, it should be rebase on the patch that fixes the tests. To allow the tests patch merged before this patch, you can mark the tests for -T none as broken. -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
Amador Pahim has posted comments on this change.
Change subject: qemu-img: check/use -T src_cache option in convert/rebase
when available
..
Patch Set 10: -Verified
Nir, but I have to include (qemuimg, '_supports_src_cache',
self.supported('convert', False) in MonkeyPatchScope for convert tests as
well. _supports_src_cache() only will be available with this patch. So
according to your suggestion, ConverTests should be marked as broken as well?
Or I could simply re-integrate http://gerrit.ovirt.org/#/c/36374 here. What do
you suggest?
--
To view, visit http://gerrit.ovirt.org/36308
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
Federico Simoncelli has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
Amador Pahim has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 10: Verified+1 This will break the tests if the qemu-img version in building system has the -T option available. To prevent, please wait for the follow-up test patch to be ready for merge along with this patch. -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15314/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15145/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14357/ : FAILURE -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
Nir Soffer has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 10: Seems that the only way would be to squash the tests into this patch. Will make it little harder to backport, but we cannot merge patches that break the build. -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15100/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14931/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14143/ : FAILURE -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
Nir Soffer has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
