Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
automat...@ovirt.org has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
Dan Kenigsberg has submitted this change and it was merged. Change subject: sampling: hoststats: rationalize getInterfaceStats .. sampling: hoststats: rationalize getInterfaceStats The main job of the HostStatsThread._getInterfaceStats() method is to gather network stats. But this method also initializes the empty `stats' return dict with the default values. The initialization doesn't belong here, rather on the calling, orchestrating function, so this patch moves the initialization code outside. Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Signed-off-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/40426 Reviewed-by: Dan Kenigsberg Continuous-Integration: Jenkins CI --- M vdsm/virt/sampling.py 1 file changed, 19 insertions(+), 16 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
Dan Kenigsberg has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
Francesco Romani has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 7: Verified+1 re-verified using tests -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
automat...@ovirt.org has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
Francesco Romani has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40426/4/vdsm/virt/sampling.py File vdsm/virt/sampling.py: > I meant the job of inserting the keys cpu* before the call to _getCpuCoresS Done in 41371 -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
Francesco Romani has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 6: verified also with 41371 -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
automat...@ovirt.org has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
automat...@ovirt.org has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
Ido Barkan has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40426/4/vdsm/virt/sampling.py File vdsm/virt/sampling.py: > Yep, I do like that in 40429 and 40430, these are the easy parts :) I meant the job of inserting the keys cpu* before the call to _getCpuCoresStats -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
Francesco Romani has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40426/4/vdsm/virt/sampling.py File vdsm/virt/sampling.py: > less messy indeed! I think that since you touch get() you should delegate i Yep, I do like that in 40429 and 40430, these are the easy parts :) I'll add more cleanup in a later series, when I tackle some HostSample cleaning. -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
Ido Barkan has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 4: Code-Review-1 (1 comment) -1 for visibility (comments inside) https://gerrit.ovirt.org/#/c/40426/4/vdsm/virt/sampling.py File vdsm/virt/sampling.py: less messy indeed! I think that since you touch get() you should delegate it's other task to another self documenting methods like stats.update(_getCpuStats()). Maybe in a following patch, but not necessarily. -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
Francesco Romani has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 4: Verified+1 verified running a patched VDSM. I added a new throwaway log and verified that the affected keys are present, especially on the first iteration -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
Francesco Romani has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 4: v4 addresses comments from Dan -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
automat...@ovirt.org has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
Francesco Romani has posted comments on this change.
Change subject: sampling: hoststats: rationalize getInterfaceStats
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/40426/3/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line 608: stats = {
Line 609: 'cpuUser': 0.0,
Line 610: 'cpuSys': 0.0,
Line 611: 'cpuIdle': 100.0,
Line 612: 'rxRate': 0.0,
> I can live with taking the rxRate/txRate junk out to here, but please comme
Done
Line 613: 'txRate': 0.0,
Line 614: 'cpuSysVdsmd': 0.0,
Line 615: 'cpuUserVdsmd': 0.0,
Line 616: 'elapsedTime': int(time.time() - self.startTime)
Line 686: Compile and return a dict containing the stats.
Line 687:
Line 688: :returns: a dict that with the following keys:
Line 689:
Line 690: * cpuUser
> comment is stale
Done
Line 691: * cpuSys
Line 692: * cpuIdle
Line 693: * rxRate
Line 694: * txRate
--
To view, visit https://gerrit.ovirt.org/40426
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
Dan Kenigsberg has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 3: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: hoststats: rationalize getInterfaceStats
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/40426/3/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line 608: stats = {
Line 609: 'cpuUser': 0.0,
Line 610: 'cpuSys': 0.0,
Line 611: 'cpuIdle': 100.0,
Line 612: 'rxRate': 0.0,
I can live with taking the rxRate/txRate junk out to here, but please comment
that they are
REQUIRED_FOR: engine < 3.6
so we can easily drop it in the future.
Line 613: 'txRate': 0.0,
Line 614: 'cpuSysVdsmd': 0.0,
Line 615: 'cpuUserVdsmd': 0.0,
Line 616: 'elapsedTime': int(time.time() - self.startTime)
Line 686: Compile and return a dict containing the stats.
Line 687:
Line 688: :returns: a dict that with the following keys:
Line 689:
Line 690: * cpuUser
comment is stale
Line 691: * cpuSys
Line 692: * cpuIdle
Line 693: * rxRate
Line 694: * txRate
--
To view, visit https://gerrit.ovirt.org/40426
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
automat...@ovirt.org has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
automat...@ovirt.org has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
oVirt Jenkins CI Server has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1645/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18414/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
oVirt Jenkins CI Server has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1645/ -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
oVirt Jenkins CI Server has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18414/ -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
automat...@ovirt.org has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats
Francesco Romani has uploaded a new change for review.
Change subject: sampling: hoststats: rationalize getInterfaceStats
..
sampling: hoststats: rationalize getInterfaceStats
HostStatsThread._getInterfaceStats() is supposed
to gather network stats.
But this method also setups the empty stats with
default value.
This initialization doesn't belong here, so this
patch moves this code outside this method, in the
calling one.
Change-Id: I556149271fb2786a6ff7341642989ea767eb2392
Signed-off-by: Francesco Romani
---
M vdsm/virt/sampling.py
1 file changed, 16 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/40426/1
diff --git a/vdsm/virt/sampling.py b/vdsm/virt/sampling.py
index 7349b9f..710bba9 100644
--- a/vdsm/virt/sampling.py
+++ b/vdsm/virt/sampling.py
@@ -604,13 +604,25 @@
return None
def get(self):
-stats = self._getInterfacesStats()
-stats['cpuSysVdsmd'] = stats['cpuUserVdsmd'] = 0.0
-stats['elapsedTime'] = int(time.time() - self.startTime)
+stats = {
+'cpuUser': 0.0,
+'cpuSys': 0.0,
+'cpuIdle': 100.0,
+'rxRate': 0.0,
+'txRate': 0.0,
+'cpuSysVdsmd': 0.0,
+'cpuUserVdsmd': 0.0,
+'elapsedTime': int(time.time() - self.startTime)
+}
+
if len(self._samples) < 2:
return stats
+
+stats.update(self._getInterfacesStats())
+
hs0, hs1 = self._samples[0], self._samples[-1]
interval = hs1.timestamp - hs0.timestamp
+
jiffies = (hs1.pidcpu.user - hs0.pidcpu.user) % (2 ** 32)
stats['cpuUserVdsmd'] = jiffies / interval
jiffies = (hs1.pidcpu.sys - hs0.pidcpu.sys) % (2 ** 32)
@@ -680,8 +692,7 @@
* rxRate
* txRate
"""
-stats = {'cpuUser': 0.0, 'cpuSys': 0.0, 'cpuIdle': 100.0,
- 'rxRate': 0.0, 'txRate': 0.0}
+stats = {}
if len(self._samples) < 2:
return stats
hs0, hs1 = self._samples[0], self._samples[-1]
--
To view, visit https://gerrit.ovirt.org/40426
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
